Konstantin Obenland
9352eb41fb
Customize: Provide a default way to save cropped images.
...
Allows plugins and themes to use `WP_Customize_Cropped_Image_Control` without
having to define their own way of saving the cropped image.
Props celloexpressions for initial patch.
Fixes #29211 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33280 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 19:53:23 +00:00
Weston Ruter
87b556a77a
Customizer: Fix element focus after menu item is deleted for keyboard accessibility.
...
Also restores box shadow on focus.
Props valendesigns.
Fixes #32740 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33279 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 18:43:50 +00:00
Konstantin Obenland
140ff5cb9b
Properly clean up header image data when the attachment is deleted.
...
Props CreativeInfusion.
Fixes #33005 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33278 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 16:27:17 +00:00
Gary Pendergast
c160106af1
WPDB: When checking that text isn't too long to insert into a column, LONGTEXT
columns could fail, as their length is longer than PHP_INT_MAX
. Treating their length as a float
instead of an int
fixes this.
...
See #32165 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33276 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 04:32:55 +00:00
Konstantin Obenland
bd6c09724e
Update password meter to match new color guidelines.
...
See: https://make.wordpress.org/design/handbook/foundations/colors/
Props melchoyce.
Fixes #32986 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33275 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 00:11:50 +00:00
Drew Jaynes
c928758054
Docs: Update the DocBlock descriptions for a variety of template functions to better reflect that the dynamic $type_template
hook can be used to filter the template path.
...
It's important to reference the actual dynamic hook name instead of an alias for purposes of auto-linking in the Code Reference.
Affects the docs for:
* `get_index_template()`
* `get_404_template()`
* `get_archive_template()`
* `get_post_type_archive_template()`
* `get_author_template()`
* `get_category_template()`
* `get_tag_template()`
* `get_taxonomy_template()`
* `get_date_template()`
* `get_home_template()`
* `get_page_template()`
* `get_paged_template()`
* `get_search_template()`
* `get_single_template()`
* `get_singular_template()`
* `get_attachment_template()`
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33274 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 22:26:32 +00:00
Drew Jaynes
b55154c579
Docs: Clarify the hook docs for the {$type}_template
hook to mention that non-alphanumeric characters delimiting words will also be removed from the passed $type
parameter.
...
Also remove a now-unnecessary inline `@see` tag from the return description.
See #32246 . See #32989 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33273 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 22:11:52 +00:00
Drew Jaynes
7b91a81c4a
Update the descriptions for get_front_page_template()
and get_comments_popup_template()
to reference the correct dynamic hook names.
...
Part props @birgire.
Fixes #32989 . See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33272 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 21:58:16 +00:00
Scott Taylor
3d1f8f292a
After [33148]:
...
Don't nest `esc_attr()` and `htmlspecialchars()` when escaping the post title on the edit post screen.
Unrevert parts of [32851] and [32850].
Adds/alters unit tests.
Props miqrogroove.
Fixes #17780 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33271 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 17:55:07 +00:00
Scott Taylor
aee18d2d38
List Tables:
...
* In `->handle_row_actions()`, bail immediately if `$primary` and `$column_name` do not match. Saves us a nesting level and avoids declaring code that is unusable.
* In `WP_List_Table::single_row_columns()`, allow `_column_{$name}` to be called dynamically by core to avoid having to override the entirety of `->single_row_columns()` in `WP_MS_Users_List_Table` and `WP_Posts_List_Table`
* In `WP_MS_Sites_List_Table`, `id` is not a column.
Props wonderboymusic, paulwilde.
Fixes #29881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33270 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 17:46:13 +00:00
Konstantin Obenland
32bcd95e37
Media: Don't indent action links if there is no media icon.
...
See #32254 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33269 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 17:45:55 +00:00
Konstantin Obenland
8ff5bc6f53
Media: Reduce link noise between icons and titles in list view.
...
Props afercia.
Fixes #32254 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33268 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 17:23:42 +00:00
Scott Taylor
b762b7da92
Monkey patch MediaElement to include a PR that restores responsive videos in Firefox:
...
https://github.com/johndyer/mediaelement/pull/1531
Props joemcgill.
Fixes #32722 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33267 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 16:29:37 +00:00
Helen Hou-Sandi
d651f599bf
List tables: Even more robust fallback for the primary column.
...
Since `WP_List_Table::get_default_primary_column()` can be overridden in a subclass and columns can be further filtered, it is possible to end up with a primary column that no longer exists. This is particularly evident in list tables for custom post types that have been altered via filter.
props ocean90.
fixes #32996 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33266 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 16:17:06 +00:00
Konstantin Obenland
f645e3767a
Login: Reflect new password flow in registration form.
...
Props Ipstenu.
Fixes #32428 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33265 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 16:07:46 +00:00
Konstantin Obenland
0db2e4e6f1
Use default parameter when getting the default avatar type.
...
Props johnjamesjacoby.
Fixes #32997 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33264 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 15:38:02 +00:00
Konstantin Obenland
3a696d7d91
Media: Remove post_type
variable, unused since [32676].
...
Fixes #32948 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33263 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 15:05:29 +00:00
Boone Gorges
ce4b40d794
In wp_unique_post_slug()
, only prevent date archive conflicts when the slug is being changed.
...
This prevents existing posts with numeric slugs from having their permalinks
changed on update.
Fixes #5305 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33262 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 12:27:11 +00:00
Boone Gorges
c718849baa
When creating a new post with an empty post_name
and post_title
, don't generate a post_name
that conflicts with a date archive permalink.
...
See #5305 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33261 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 12:27:03 +00:00
Gary Pendergast
7711b72639
WPDB: When extracting the table name from a query, we had a 1000 character limit on the SQL string that would be searched. This was a hangover from when the code was imported from HyperDB, and isn't appropriate for Core, where a wider range of queries are likely to be run.
...
Fixes #32763
git-svn-id: https://develop.svn.wordpress.org/trunk@33259 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 10:18:57 +00:00
Dion Hulse
56c51da216
Updates: When performing an ajax plugin update, rely upon wp_update_plugins()
to check the contents of the transient and return early if no request needs to be made.
...
This works around a bug where custom update handlers are injecting an update into an empty transient, malforming the transient and causing update failures.
Fixes #32198 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@33257 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 08:00:31 +00:00
Weston Ruter
65f5a16611
Customizer: Improve performance of menus by caching results of wp_setup_nav_menu_item()
calls.
...
Also fixes property list in phpdoc for `wp_setup_nav_menu_item()`.
Fixes #32769 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33256 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 07:08:40 +00:00
Jeremy Felt
33be338e9f
Tests: Use a data provider when testing site flags in update_blog_details()
.
...
See #32988 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33255 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 06:38:19 +00:00
Jeremy Felt
76ef07903d
Tests: Use a data provider when testing path slashing in update_blog_details()
.
...
Trims down 11 tests to 1 clean area of testing and makes for a much saner read.
See #32988 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33254 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 05:51:05 +00:00
Jeremy Felt
e3e828c608
Tests: Move update_blog_details()
tests to their own file.
...
Reduce some of the clutter in `tests/multisite/site.php` and introduce `tests/multisite/updateBlogDetails.php`. Tests moved over are verbatum at this point.
See #32988 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33253 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 05:49:28 +00:00
Konstantin Obenland
3bafaf7983
Editor: Center-align Publish/Update spinner on small-screen devices.
...
Props tywayne for initial patch.
Fixes #32947 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33252 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 04:01:10 +00:00
Konstantin Obenland
8560ac41f1
Password: Improve display of password meter on login screen.
...
Fixes #32925 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33251 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 03:31:35 +00:00
Boone Gorges
04237900a6
Require dependencies when appropriate in some unit test files.
...
Previously, attempting to run certain test files in isolation would resultin
fatal errors, as the parent classes had not been loaded.
Props isaacchapman.
Fixes #32984 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33250 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 03:07:13 +00:00
Konstantin Obenland
a48af6ef86
Passwords: Make show/hide toggle translatable.
...
See #32589 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33249 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:34:18 +00:00
Drew Jaynes
e7e337c4e6
Fix the same typo again in the hook doc summary for the send_pass_change_email
filter.
...
I speak English, I do.
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33248 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:26:34 +00:00
Drew Jaynes
02e3c99234
Fix a typo in the hook docs summary for the send_pass_change_email
filter.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33247 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:24:24 +00:00
Konstantin Obenland
05c4803450
Passwords: New UI for install screen.
...
Also synchronises the use of `pw_weak` as an input name and removes trailing
periods from checkbox labels.
Props MikeHansenMe, adamsilverstein, obenland.
See #32589 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33246 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:21:39 +00:00
Drew Jaynes
ce8944600a
Fix the inline documentation syntax in the hook docs for the email_change_email
filter, introduced in 4.3.
...
Also update the filter summary to reflect that the file is for an "email" change, not a "password" change.
See [32820]. See #32891 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33245 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:14:45 +00:00
Drew Jaynes
a15b51fc6f
Fix the inline documentation syntax in the hook docs for the password_change_email
filter, introduced in 4.3.
...
See [32820]. See #32891 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33244 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:10:49 +00:00
Drew Jaynes
9a0034bb78
Fix the inline documentation syntax in the hook docs for the send_email_change_email
filter, added in 4.3.
...
See [32820]. See #32891 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33243 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:07:19 +00:00
Drew Jaynes
8f5107f7dc
Fix the inline documentation syntax in the hook docs for the send_pass_change_email
filter, added in 4.3.
...
See [32820]. See #32891 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33242 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:04:42 +00:00
Drew Jaynes
1094410e1a
Wrap a long changelog entry description in the DocBlock for count_user_posts()
.
...
Also clarify the description for the new `$public_only` parameter, added in [32523].
See #32891 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33241 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:02:20 +00:00
Drew Jaynes
8227017042
Add an extra line before the hook doc for the editor_stylesheets
filter begins.
...
The parser really likes it when there's breathing room.
See [32928]. See #32891 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33240 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 22:00:13 +00:00
Drew Jaynes
0b9afe692d
Fix inline documentation syntax in the DocBlock for get_singular_template()
, added in 4.3.
...
See [32846]. See #32891 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33239 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 21:58:23 +00:00
Drew Jaynes
78548dd49d
Fix formatting in the DocBlock for _split_shared_term()
.
...
See #32246 . See #32891 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33238 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 21:56:53 +00:00
Drew Jaynes
b3544157ab
Properly mark the $query_var
parameter as optional in the DocBlock for WP_Rewrite->add_endpoint()
.
...
See #32246 . See #32891 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33237 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 21:54:40 +00:00
DrewAPicture
f6ca434cd5
Add better line wrapping and syntax improvements to the description for wp_resolve_numeric_slug_conflicts()
, added in 4.3.
...
Also properly mark `$query_vars` as optional in the parameter description.
See [32648]. See #32891 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33236 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 21:53:02 +00:00
Drew Jaynes
2ebc03741b
Remove a now-unnecessary inline @see
tag from the description for add_rewrite_endpoint()
.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33235 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 21:50:18 +00:00
Drew Jaynes
4274e7fe7e
Wrap a long changelog entry description in the DocBlock for get_post_type_labels()
.
...
See [32673]. See #32891 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33234 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 21:48:44 +00:00
Drew Jaynes
12a932b177
Fix the parameter description syntax in the hook docs for the wp_safe_redirect_fallback
filter, added in 4.3.
...
See #32891 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33233 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 21:45:26 +00:00
Drew Jaynes
8dee1379bd
Fix the parameter description syntax in the hook docs for the wp_get_nav_menu_object
filter, added in 4.3.
...
See #32891 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33232 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 21:44:07 +00:00
Drew Jaynes
67698ae788
Fix inline documentation syntax in the DocBlock for WP_Meta_Query->has_or_relation()
, added in 4.3.
...
See [32713]. See #32891 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33231 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 21:43:05 +00:00
Drew Jaynes
ad38bd2e6c
Remove now-unnecessary inline @see
tag from the DocBlock for wp_dropdown_languages()
.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33230 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 21:41:18 +00:00
Drew Jaynes
0c685e2f23
Fix inline documentation syntax for the language_attributes()
DocBlock.
...
See #32246 . See #32891 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33229 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 21:39:38 +00:00
Drew Jaynes
ed0c6da112
Fix inline documentation syntax in the DocBlock for get_language_attributes()
, introduced in 4.3.
...
See [32868]. See #32891 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33228 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 21:38:21 +00:00