Commit Graph

5580 Commits

Author SHA1 Message Date
Gary Pendergast
d0379f4fb7 Shiny Updates: Add capability checks to the ajax callbacks, to ensure the current user is allowed to install/update plugins.
See #29820



git-svn-id: https://develop.svn.wordpress.org/trunk@31334 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-05 06:04:32 +00:00
Gary Pendergast
748d595b5c Shiny Updates: Add ajax-y updates to the plugin list page, and ajax-y updates and installs to the plugin card page.
This also includes JS architecture that can be expanded to support theme, core and language pack updates.

Props pento, ericlewis, lgladdy, adamsilverstein, DrewAPicture

See #29820



git-svn-id: https://develop.svn.wordpress.org/trunk@31333 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-05 04:18:57 +00:00
Andrew Ozz
f205eb63d0 Fix displaying long tag names in the Tags postbox. Props trishasalas, carolinegeven, iseulde. Fixes #18946.
git-svn-id: https://develop.svn.wordpress.org/trunk@31332 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-04 22:14:31 +00:00
Helen Hou-Sandi
8d0b774e65 Accessibility: remove remaining instances of accesskey.
It is a poorly implemented browser feature, not particularly discoverable, and causes more problems than it helps solve.

props afercia.
fixes #29715.


git-svn-id: https://develop.svn.wordpress.org/trunk@31331 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-04 03:45:24 +00:00
Helen Hou-Sandi
fe32344314 Themes: Allow version number in the overlay to be selected.
props johneckman.
fixes #31205.


git-svn-id: https://develop.svn.wordpress.org/trunk@31330 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-03 15:14:59 +00:00
Dominik Schilling (ocean90)
8bc9ad756d Ensure that WP_Customize_Setting::value() returns default value for setting if not dirty.
There was regression introduced by #28580 where only changed (dirty) settings now are POST'ed to the Customizer preview.

* Allow WP_Customize_Manager::post_value() to accept a second $default argument.
* Introduce WP_Customize_Manager::unsanitized_post_values() for accessing previously-private member variable _post_values.
* Do require_once instead of require for Customizer classes.
* Add unit tests for WP_Customize_Manager and WP_Customize_Setting.

props westonruter.
fixes #30988.

git-svn-id: https://develop.svn.wordpress.org/trunk@31329 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-03 10:14:28 +00:00
Dion Hulse
5811dcbcd6 Remove an extra indent from most of media-new.php.
git-svn-id: https://develop.svn.wordpress.org/trunk@31328 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-03 07:46:21 +00:00
Dion Hulse
4ed2d89ced WP_Upgrader: Remove references to non-existant variables that have never existed.
Props jdgrimes. Fixes  #29087


git-svn-id: https://develop.svn.wordpress.org/trunk@31327 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-03 06:17:05 +00:00
dd32
5f13a0e3e5 Remove an unused parameter on install_plugins_upload().
Props michalzuber. Fixes #28964


git-svn-id: https://develop.svn.wordpress.org/trunk@31326 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-03 06:13:02 +00:00
Sergey Biryukov
4aada86274 Add 'widget_nav_menu_args' filter for Custom Menu widget arguments.
props cyman, DrewAPicture.
fixes #29463.

git-svn-id: https://develop.svn.wordpress.org/trunk@31325 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-03 02:55:21 +00:00
Sergey Biryukov
5e9b89bf59 When using WP_Query's 'fields' => 'ids' (or 'fields' => 'id=>parent'), make sure the returned result is always an array of integers.
fixes #31194. see #27252.

git-svn-id: https://develop.svn.wordpress.org/trunk@31324 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-03 02:28:52 +00:00
Boone Gorges
f05f380638 In get_sample_permalink(), override 'future' status before generating permalink.
In [31114], `get_permalink()` was modified to prevent pretty permalinks from
being generated for posts with the 'future' post status. This inadvertently
broke the pretty permalink preview for scheduled posts. The fix is to include
the 'future' status in the list of statuses that `get_sample_permalink()` fakes
as 'publish' before it fetches a permalink.

Props DrewAPicture.
Fixes #30910.

git-svn-id: https://develop.svn.wordpress.org/trunk@31323 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-02 16:49:23 +00:00
Dominik Schilling (ocean90)
c61dff8c21 jQuery UI: Add jquery-ui-core as dependency for jquery-ui-progressbar.
props tyxla.
fixes #31208.

git-svn-id: https://develop.svn.wordpress.org/trunk@31322 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-02 10:33:49 +00:00
Boone Gorges
5f6ea53e86 When querying for a specific post, allow posts with a non-public status to be returned as long as that status is specified.
This makes it possible to, for example, retrieve a specific post using the
`p` parameter of `WP_Query`, even if the post is in the Trash, by including
the `post_status=trash` parameter.

Props ebinnion.
Fixes #29167.

git-svn-id: https://develop.svn.wordpress.org/trunk@31321 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-01 20:25:42 +00:00
Sergey Biryukov
09d350b835 Menus: Don't display "Move" text without direction if there is only one menu item.
props kucrut for initial patch.
fixes #30765.

git-svn-id: https://develop.svn.wordpress.org/trunk@31320 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-01 05:28:29 +00:00
Sergey Biryukov
54dedff5c7 Reduce the size of the WordPress logo tap target on log in screen on mobile, to avoid unexpected redirect away from the form.
props mzak.
fixes #31185.

git-svn-id: https://develop.svn.wordpress.org/trunk@31318 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-31 21:31:26 +00:00
Sergey Biryukov
cec05576e4 Themes: Remove a Chrome workaround that causes theme screenshots to look too crisp and no longer appears to be relevant.
props mzak.
fixes #26584.

git-svn-id: https://develop.svn.wordpress.org/trunk@31316 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-31 20:38:08 +00:00
Boone Gorges
32f2903248 Prevent terms in a show_in_quick_edit=false taxonomy from being updated by a faked AJAX request.
The UI for these taxonomies was hidden in [31308], but it remained possible to
send a direct POST request to the `inline-edit` endpoint to bypass the
restriction. The current changeset fixes this.

Props meloniq.
Fixes #26948.

git-svn-id: https://develop.svn.wordpress.org/trunk@31313 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-31 19:37:12 +00:00
Boone Gorges
2d737796d2 Improve support for ordering WP_Query results by postmeta.
`WP_Meta_Query` clauses now support a 'name' parameter. When building a
`WP_Query` object, the value of 'orderby' can reference this 'name', so that
it's possible to order by any clause in a meta_query, not just the first one
(as when using 'orderby=meta_value'). This improvement also makes it possible
to order by multiple meta query clauses (or by any other eligible field plus
a meta query clause), using the array syntax for 'orderby' introduced in [29027].

Props Funkatronic, boonebgorges.
Fixes #31045.

git-svn-id: https://develop.svn.wordpress.org/trunk@31312 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-31 15:47:51 +00:00
Drew Jaynes (DrewAPicture)
0c783b06fb Add changelog entries to the post_gallery and post_playlist hook docs for the $instance variable that was added in [31304].
Props ninnypants for the initial patch.
Fixes #31151.


git-svn-id: https://develop.svn.wordpress.org/trunk@31309 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-31 00:32:09 +00:00
Boone Gorges
c7320c5a86 Fix 'quick_edit_show_taxonomy' filter so that can properly be used for overrides in all cases.
See #26948.

git-svn-id: https://develop.svn.wordpress.org/trunk@31308 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-30 19:28:27 +00:00
Boone Gorges
057c428346 Introduce 'show_in_quick_edit' parameter for register_taxonomy().
Setting 'show_in_quick_edit' to false when registering a custom taxonomy will
hide the taxonomy when editing posts using Quick Edit.

The new 'quick_edit_show_taxonomy' filter allows this behavior to be filtered
on a finer scale, as when you want a given taxonomy to be hidden for one post
type but not for others.

Props hlashbrooke.
Fixes #26948.

git-svn-id: https://develop.svn.wordpress.org/trunk@31307 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-30 19:17:51 +00:00
Sergey Biryukov
14c3492ff5 Rename $instances to $instance in wp_audio_shortcode() and wp_video_shortcode() for consistency with gallery_shortcode() and wp_playlist_shortcode().
see #31151.

git-svn-id: https://develop.svn.wordpress.org/trunk@31305 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-30 16:05:52 +00:00
Sergey Biryukov
45b0513c1b Pass the current shortcode instance ID to post_gallery and post_playlist filters.
props justincwatt.
fixes #31151.

git-svn-id: https://develop.svn.wordpress.org/trunk@31304 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-30 16:01:25 +00:00
Sergey Biryukov
e725b36d1e Don't display the Help tab reference in Page Attributes meta box if Help tab was removed.
props bananastalktome.
fixes #31164.

git-svn-id: https://develop.svn.wordpress.org/trunk@31303 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-30 15:33:33 +00:00
Boone Gorges
9cb4d3c1ce In get_adjacent_post(), return private post if the current user has the capacity to read it.
This mirrors the check that happens post-query in `WP_Query`. See #30911.

Props bswatson.
Fixes #30287.

git-svn-id: https://develop.svn.wordpress.org/trunk@31302 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-30 02:19:46 +00:00
Sergey Biryukov
dcb278f006 Switch to a 403 response code in places where it is more appropriate than a 500 due to permissions errors.
props tomdxw.
fixes #30927.

git-svn-id: https://develop.svn.wordpress.org/trunk@31300 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-29 21:14:54 +00:00
Dominik Schilling (ocean90)
4914b74403 Add New User: Remove trailing whitespace from button labels.
fixes #31175.

git-svn-id: https://develop.svn.wordpress.org/trunk@31298 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-29 14:53:05 +00:00
Drew Jaynes (DrewAPicture)
8821a5531c Avoid confusion by clarifying an inline comment on logic for performing multisite upgrades.
Props dmchale for the initial patch.
Fixes #30837.


git-svn-id: https://develop.svn.wordpress.org/trunk@31297 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-29 11:52:55 +00:00
Drew Jaynes (DrewAPicture)
08409d8d33 Fix an inaccurate summary and description in the DocBlock for wpmu_validate_user_signup().
Props ericlewis.
Fixes #31141.


git-svn-id: https://develop.svn.wordpress.org/trunk@31296 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-29 11:45:59 +00:00
Drew Jaynes (DrewAPicture)
18a86bf33a Add a missing description for the $_diff_threshold property in the WP_Text_Diff_Renderer_Table class.
Props ipm-frommen.
Fixes #31008.


git-svn-id: https://develop.svn.wordpress.org/trunk@31295 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-29 11:36:00 +00:00
Drew Jaynes (DrewAPicture)
b98c2c0bb3 Add missing descriptions to the $blogid and $siteid property DocBlocks in the wpdb class.
Props ipm-frommen.
See #31008.


git-svn-id: https://develop.svn.wordpress.org/trunk@31294 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-29 11:34:52 +00:00
Drew Jaynes (DrewAPicture)
f4e2134bee Add missing descriptions to the DocBlocks for various functions in wp-admin/includes/taxonomy.php.
Also adds a few missing parameter descriptions.

Props ipm-frommen.
See #31008.


git-svn-id: https://develop.svn.wordpress.org/trunk@31293 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-29 11:33:02 +00:00
Drew Jaynes (DrewAPicture)
18280eb766 Add missing descriptions to the DocBlocks for various functions in wp-admin/includes/post.php
Props ipm-frommen.
See #31008.


git-svn-id: https://develop.svn.wordpress.org/trunk@31292 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-29 11:31:44 +00:00
Andrew Nacin
65cdb41d31 Update readme recommendations. fixes #31173.
git-svn-id: https://develop.svn.wordpress.org/trunk@31291 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-29 05:09:33 +00:00
Dion Hulse
db3a49f8c8 HTTP API: Fix an issue where the limit_response_size parameter wasn't working properly with large documents and the cURL transport.
Fixes #31172


git-svn-id: https://develop.svn.wordpress.org/trunk@31290 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-29 03:57:42 +00:00
Boone Gorges
fb447fb687 When updating the name a hierarchical term with Quick Edit, update the corresponding option in the Parent dropdown.
Props garyc40, rmarks.
Fixes #14565.

git-svn-id: https://develop.svn.wordpress.org/trunk@31288 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-29 01:52:47 +00:00
Boone Gorges
2e848072eb Don't use term IDs for array indexes when caching object terms.
Uncached results pulled from `wp_get_object_terms()` are zero-indexed (ie 0,
1, 2...). As a result, `get_the_terms()` was returning a strictly different
array when pulling from the cache and when the cache was empty.

Props joshlevinson.
Fixes #31086.

git-svn-id: https://develop.svn.wordpress.org/trunk@31287 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-28 20:42:25 +00:00
Boone Gorges
9d3a6394fb Ensure that 'hierarchical' is respected in get_terms() when multiple taxonomies are passed.
Previously, attempts to descend the family tree of each term were done using
the first taxonomy in the `$taxonomies` array, with the result that terms not
belonging to that taxonomy were not found and their children not properly
parsed. We fix this bug by fetching each term's taxonomy with the SQL query,
and then using that taxonomy to get the correct children for each term.

Fixes #31118.

git-svn-id: https://develop.svn.wordpress.org/trunk@31285 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-26 19:03:09 +00:00
Boone Gorges
fed49d226c Ensure that 'pad_counts' is not discarded when the first of multiple taxonomies passed to get_terms() is non-hierarchical.
See #31118.

git-svn-id: https://develop.svn.wordpress.org/trunk@31284 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-26 18:08:59 +00:00
Lance Willett
081cff1a6e Twenty Fifteen: move RSS icon style rule lower to prevent it from being overridden by other social icon rules.
Props iamtakashi, fixes #31129.


git-svn-id: https://develop.svn.wordpress.org/trunk@31283 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-26 15:57:22 +00:00
Sergey Biryukov
7f6d638bd9 Remove duplicate label on installation screen.
props Ankit K Gupta.
fixes #31131.

git-svn-id: https://develop.svn.wordpress.org/trunk@31282 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-25 19:38:04 +00:00
Sergey Biryukov
cbd723b2b2 Revert [30027]. These fields are already sufficiently labeled; duplicate labels can lead to confused behavior for screen readers.
see #31117, #30101.

git-svn-id: https://develop.svn.wordpress.org/trunk@31281 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-25 18:32:56 +00:00
Sergey Biryukov
da8f896426 Fix a typo in [30138].
see #30224.

git-svn-id: https://develop.svn.wordpress.org/trunk@31279 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-25 09:47:05 +00:00
Andrew Nacin
4857c6996c Allow $autoload in add_option() to receive false.
props dllh.
fixes #31119.


git-svn-id: https://develop.svn.wordpress.org/trunk@31278 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-25 07:50:31 +00:00
Boone Gorges
5bcee9e939 In get_terms(), check hierarchy for all $taxonomies before bailing early from 'parent' or 'child_of'.
There is a pre-check in `get_terms()` that prevents an unnecessary database
query if the 'parent' or 'child_of' parameter is not found in the cached term
hierarchy (since a term without an index in the hierarchy cache has no
descendants). Previously, only the first item in the `$taxonomies` array was
being checked, with the result that an empty array was being erroneously
returned in cases where the 'parent' or 'child_of' term is in a subsequent
taxonomy.

See #31118.

git-svn-id: https://develop.svn.wordpress.org/trunk@31276 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-25 02:45:11 +00:00
Boone Gorges
c67e5da8c9 Introduce 'childless' parameter to get_terms().
This new parameter allows developers to limit queried terms to terminal nodes -
ie, those without any descendants.

As part of the improvement, some internal logic in `get_terms()` has been
consolidated. Parameters that resolve to a NOT IN clause containing term IDs
('exclude', 'exclude_tree', and 'childless') are now parsed into a single
"exclusions" array before the SQL clause is generated.

Props theMikeD, horike.
Fixes #29839.

git-svn-id: https://develop.svn.wordpress.org/trunk@31275 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-24 18:47:30 +00:00
Sergey Biryukov
02b3356750 Quick Edit: Don't save the post if Enter is pressed on the Cancel link.
props afercia.
fixes #30345.

git-svn-id: https://develop.svn.wordpress.org/trunk@31274 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-24 15:06:43 +00:00
Dominik Schilling (ocean90)
1b05ffa982 jQuery UI: Add missing dependencies for puff and scale effects.
see #31113.

git-svn-id: https://develop.svn.wordpress.org/trunk@31273 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-23 22:38:08 +00:00
Aaron Jorbin
7cbe92b0ea Improve accessibility of nav menu locations form.
A couple of small tweaks to the nav menu locations form that make it friendlier to assistive technology.  These include:
 * labels for selects
 * better context for the "Edit" link.  We hide "edit" from screen readers and instead give them a phrase with context since they may not be able to take advantage of the visual context

Additionally, there are some minor css tweaks to improve the visual alignment of the rows.
We also remove duplicate IDs and use classes instead.

Props afercia.
fixes #31090.



git-svn-id: https://develop.svn.wordpress.org/trunk@31272 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-23 18:17:25 +00:00
Boone Gorges
8ec0792557 Add classes for custom taxonomy terms in get_post_class().
Props sillybean.
Fixes #16223.

git-svn-id: https://develop.svn.wordpress.org/trunk@31271 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-23 15:40:31 +00:00
Boone Gorges
10d3b42211 Introduce 'parent' parameter to wp_get_object_terms().
Props mikeschinkel.
Fixes #15675.

git-svn-id: https://develop.svn.wordpress.org/trunk@31270 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-23 14:56:04 +00:00
Sergey Biryukov
63ee24789d In wp_update_user(), make sure $userdata['ID'] is set before using it.
props tyxla.
fixes #31097.

git-svn-id: https://develop.svn.wordpress.org/trunk@31269 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-22 14:45:14 +00:00
Lance Willett
6629feb738 Twenty Eleven and Twelve: fill in support for screen-reader-text class.
Props obenland, fixes #31095.

git-svn-id: https://develop.svn.wordpress.org/trunk@31268 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-22 00:55:09 +00:00
Lance Willett
2487709643 Twenty Eleven: fix indentation (spaces to tabs). See #29127.
git-svn-id: https://develop.svn.wordpress.org/trunk@31267 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-22 00:43:31 +00:00
Lance Willett
9ad83781e9 Twenty Ten: fix escaping and minor code style issues. See #29127.
git-svn-id: https://develop.svn.wordpress.org/trunk@31266 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-22 00:41:58 +00:00
Lance Willett
31b1340825 Twenty Eleven: fix escaping and minor code style issues. See #29127.
git-svn-id: https://develop.svn.wordpress.org/trunk@31265 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-22 00:41:36 +00:00
Gary Pendergast
cd02bd0702 Comments: When a comment fails to insert, remove invalid characters from the email and URL fields, too.
See [31263], #21212



git-svn-id: https://develop.svn.wordpress.org/trunk@31264 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-21 23:17:08 +00:00
Gary Pendergast
b2642750ce Comments: When a comment fails to insert, remove any invalid characters and try again.
See #21212



git-svn-id: https://develop.svn.wordpress.org/trunk@31263 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-21 23:03:48 +00:00
Lance Willett
260f671a95 Twenty Twelve: more fixes for escaping and minor code style issues. See #29127.
git-svn-id: https://develop.svn.wordpress.org/trunk@31262 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-21 21:05:29 +00:00
Lance Willett
74eb9552bf Twenty Twelve: fix escaping and minor code style issues. See #29127.
git-svn-id: https://develop.svn.wordpress.org/trunk@31261 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-21 20:59:15 +00:00
Lance Willett
95f9a91d86 Twenty Thirteen: fix escaping and minor code style issues. See #29127.
git-svn-id: https://develop.svn.wordpress.org/trunk@31260 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-21 20:48:45 +00:00
Dominik Schilling (ocean90)
3089d4d6cc Customizer: Hide the reorder-widgets button when a widget area is empty.
props celloexpressions.
fixes #27787.

git-svn-id: https://develop.svn.wordpress.org/trunk@31255 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-20 22:44:11 +00:00
Dominik Schilling (ocean90)
e3bff14246 Customizer: If there's only one available sidebar, hide the move-widget button.
props celloexpressions.
fixes #30690.

git-svn-id: https://develop.svn.wordpress.org/trunk@31252 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-20 20:35:13 +00:00
Boone Gorges
f1771073dc WP_Date_Query date validation should not fail for hour = 0.
Props ChriCo, tyxla.
Fixes #31067 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31251 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-20 19:12:48 +00:00
Lance Willett
37ea642f69 Twenty Fourteen: fix escaping and minor code style issues. See #29127.
git-svn-id: https://develop.svn.wordpress.org/trunk@31250 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-20 19:02:53 +00:00
Gary Pendergast
3a87ef36e2 Texturize: Add "em" as a cockney term, so that "'em" is texturized with an apostrophe, instead of an open quote.
Fixes #29813.

Props miqrogroove.



git-svn-id: https://develop.svn.wordpress.org/trunk@31249 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-20 18:43:30 +00:00
Boone Gorges
d80ca82693 Better loop detection for _pad_term_counts().
The `$ancestors` check must be reset for each term in order for term counts
to be correct.

Fixes #20635.

git-svn-id: https://develop.svn.wordpress.org/trunk@31248 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-19 16:51:44 +00:00
Sergey Biryukov
2c955c0bbf Remove inaccurate part of {$taxonomy}_add_form_fields action description.
props joostdekeijzer.
fixes #31052.

git-svn-id: https://develop.svn.wordpress.org/trunk@31247 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-19 15:30:09 +00:00
Drew Jaynes (DrewAPicture)
5e301c5794 Add missing summaries and descriptions for various functions in wp-admin/includes/upgrade.php.
Also generally improve existing parameter, return, and other documentation in various function DocBlocks.

Props morganestes.
Fixes #30825.


git-svn-id: https://develop.svn.wordpress.org/trunk@31246 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-19 09:14:39 +00:00
Drew Jaynes (DrewAPicture)
032ec0d24a Remove a stray period introduced in [31242].
Props SergeyBiryukov.
See #31048.


git-svn-id: https://develop.svn.wordpress.org/trunk@31245 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-19 08:46:24 +00:00
Drew Jaynes (DrewAPicture)
b590db9253 Ensure the correct list of default tabs for the Plugin Install screen are documented.
Props stevenkword.
Fixes #31017.


git-svn-id: https://develop.svn.wordpress.org/trunk@31244 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-19 08:43:15 +00:00
Drew Jaynes (DrewAPicture)
73780fdd32 Add more complete documentation for parameters, globals, and return values to the DocBlocks for remove_shortcode(), shortcode_exists(), and do_shortcode().
Props SergeyBiryukov.
Fixes #31048.


git-svn-id: https://develop.svn.wordpress.org/trunk@31243 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-19 08:39:10 +00:00
Drew Jaynes (DrewAPicture)
596412fb0b Ensure both parameters and the return for has_shortcode() are fully documented.
Props cais, SergeyBiryukov
See #31048.


git-svn-id: https://develop.svn.wordpress.org/trunk@31242 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-19 08:35:05 +00:00
Sergey Biryukov
352be0b432 Display correct title in Archives widget if the type of archive was changed using the 'widget_archives_dropdown_args' filter.
props floriansimeth for initial patch.
fixes #31024.

git-svn-id: https://develop.svn.wordpress.org/trunk@31241 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-19 08:25:36 +00:00
Sergey Biryukov
4a1cf7a38b Strip HTML tags when searching for installed themes.
props enej, SergeyBiryukov, obenland.
fixes #27561.

git-svn-id: https://develop.svn.wordpress.org/trunk@31240 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-18 20:39:39 +00:00
Sergey Biryukov
a036114a4d attachment_url_to_postid() should always return an integer.
props nathan_dawson, ashfame.
fixes #31044.

git-svn-id: https://develop.svn.wordpress.org/trunk@31239 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-18 20:32:50 +00:00
Drew Jaynes (DrewAPicture)
a79297ba2d Minor fix for inline doc syntax in a changelog entry for wp_get_object_terms().
See #28688.


git-svn-id: https://develop.svn.wordpress.org/trunk@31238 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-18 19:04:45 +00:00
Boone Gorges
fd886b7d60 Add @since annotation for 'orderby' values introduced in [31236].
See #28688.

git-svn-id: https://develop.svn.wordpress.org/trunk@31237 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-18 19:02:34 +00:00
Boone Gorges
9501fb3213 Additional 'orderby' values for wp_get_object_terms().
Adds support for ordering by 'taxonomy', 'term_taxonomy_id', and 'parent'.

Props ChriCo.
Fixes #28688.

git-svn-id: https://develop.svn.wordpress.org/trunk@31236 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-18 18:56:38 +00:00
Andrew Ozz
9ade002c6f TinyMCE: fix vertical positioning of the image toolbar when there are several instances of the editor. Props avryl, fixes #31028.
git-svn-id: https://develop.svn.wordpress.org/trunk@31235 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-18 17:55:39 +00:00
Sergey Biryukov
2b4099c6bd Customizer: Replicate behavior from options-reading.php and hide front page options if there are no pages.
props Clorith.
fixes #27630.

git-svn-id: https://develop.svn.wordpress.org/trunk@31234 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-18 06:00:18 +00:00
Boone Gorges
c7e95b9433 Correct wp_get_object_terms() documentation.
The 'orderby' parameter accepts a number of values that have never been
properly documented.

git-svn-id: https://develop.svn.wordpress.org/trunk@31232 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 20:38:20 +00:00
Boone Gorges
b18ee3334f Standardize the docblock for wp_get_object_terms().
The enumeration of the `$args` parameter has been moved from the long
description to an array hash associated with the proper `@param` attribute.

git-svn-id: https://develop.svn.wordpress.org/trunk@31231 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 20:08:11 +00:00
Sergey Biryukov
658d1bb32e Add a changelog entry for the new parameter added in [31228].
props DrewAPicture.
fixes #31015.

git-svn-id: https://develop.svn.wordpress.org/trunk@31229 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 17:30:10 +00:00
Sergey Biryukov
54f366da0b Pass $force_reauth value to the 'login_url' filter.
props jfarthing84, MikeHansenMe.
fixes #31015.

git-svn-id: https://develop.svn.wordpress.org/trunk@31228 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 17:19:57 +00:00
Sergey Biryukov
3c86263afe Customizer: Make "Search widgets" input sticky.
props celloexpressions.
fixes #30751.

git-svn-id: https://develop.svn.wordpress.org/trunk@31227 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 13:15:00 +00:00
Sergey Biryukov
4c4de36c5c Customizer: Fix form tag replacement in WP_Customize_Widgets::get_widget_control() after [31200].
see #30126.

git-svn-id: https://develop.svn.wordpress.org/trunk@31226 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 13:10:27 +00:00
Sergey Biryukov
6e206c2973 Use the site's local time to create the first post during installation.
props extendwings.
fixes #29296.

git-svn-id: https://develop.svn.wordpress.org/trunk@31225 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 10:06:42 +00:00
Sergey Biryukov
e7bf16b423 Introduce has_header_image() to check whether a header image is set.
props GunGeekATX, voldemortensen.
fixes #16268.

git-svn-id: https://develop.svn.wordpress.org/trunk@31224 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 06:33:42 +00:00
Andrew Ozz
f18854e866 Add support for IE conditional comments for WP_Scripts to match the functionality of WP_Styles, including unit tests. Props filosofo, aaroncampbell, ethitter, georgestephanis, valendesigns. Fixes #16024.
git-svn-id: https://develop.svn.wordpress.org/trunk@31223 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 01:36:55 +00:00
Andrew Ozz
5378b4e000 TinyMCE: add breaking out of blockquotes by pressing Enter twice. Togging blockquote on|off with the button and the shortcut is unchanged. Props avryl, fixes #23110.
git-svn-id: https://develop.svn.wordpress.org/trunk@31222 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 23:35:24 +00:00
Scott Taylor
cd2d6d27d9 wp_set_object_terms() takes $taxonomy as a string. Update @param.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31221 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 23:26:38 +00:00
Scott Taylor
357fa4131a Fix some internal types that are passed to functions to avoid changing the acceptable types passed as arguments to those functions:
* In `WP_Importer->is_user_over_quota()`, the default value for the first argument for `upload_is_user_over_quota()` is `true`. Don't bother passing `1`.
* When calling `submit_button()` with no `$name`, pass empty string instead of `false`.
* The default value for the 2nd argument to `get_edit_post_link()` is `'display'`. Because PHP is PHP, passing `true` is the same as passing `'display'` or nothing. Don't bother passing `true`. 
* In `WP_User_Meta_Session_Tokens::drop_sessions()`, pass `0` instead of `false` to `delete_metadata()` as the value for `$object_id`, which expects an int. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31220 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 22:50:20 +00:00
Scott Taylor
1d3b42d226 Fix some erroneous @param annotations.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31219 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 22:43:13 +00:00
Boone Gorges
5b7baae907 In get_edit_term_link(), default to a valid $object_type.
The $object_type param is used to set the 'post_type' query var, which
determines the post type menu that will be expanded when clicking through to
the term edit page. Not all taxonomies are associated with Posts, so it makes
sense to default to a post_type that the taxonomy is actually associated with.

Props DzeryCZ, juliobox.
Fixes #29251.

git-svn-id: https://develop.svn.wordpress.org/trunk@31218 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 21:36:12 +00:00
Scott Taylor
5deee71273 Remove unused local vars in delete_plugins(), delete_theme(), WP_Date_Query->validate_date_values(), global_terms(), and WP_Text_Diff_Renderer_Table->_changed().
This will clear out the "Unused Code" label in the next Scrutinizer report.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31217 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 21:18:52 +00:00
Scott Taylor
2ed007c023 Calling ->chown() and ->chgrp() in WP_Filesystem_ftpsockets produces no side-effects. Remove the calls. ->chgrp() is defined in the super class, and does nothing, can be removed from the child class.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31216 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 21:09:18 +00:00
Scott Taylor
9a16e6230b Calling ->chown() and ->chgrp() in WP_Filesystem_FTPext produces no side-effects. Remove the calls. ->chgrp() is defined in the super class, and does nothing, can be removed from the child class.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31215 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 21:06:29 +00:00
Lance Willett
19b4a0053a Twenty Fifteen: keep sub-menus open when visiting sub-menu pages, to show context when navigating a site.
Props jartes, fixes #30722.

git-svn-id: https://develop.svn.wordpress.org/trunk@31214 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 19:16:56 +00:00
Scott Taylor
d29abb1d24 By initializing this array before a loop, Scrutinizer reports 0 (zero) "Coding Style" errors.
There are plenty of other kinds of errors, but this label will be cleared out.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31213 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 19:12:15 +00:00
Scott Taylor
5743898e1e @param cleanup:
* `get_metadata()` will return literally anything, needs to be `mixed`
* `wp()` and `WP_Query::__construct()` no longer just take a query string
* Clarify a few others

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31212 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 19:02:26 +00:00
Scott Taylor
835dbe7baf [31210] broke Supportflow on dotorg, which declares these methods as protected. Switch to protected for the noop methods. The subclasses can make them more visible using public.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31211 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 18:36:46 +00:00
Scott Taylor
e3ac341f24 Add 2 noop methods to WP_List_Table: ->column_default() and ->column_cb().
`WP_List_Table` is essentially an `abstract` class. Some of its methods throw `die()` warnings if they aren't overridden in a child class.

These noop methods wouldn't be `abstract`, because they are not required in subclasses. However, `WP_List_Table` can call these methods in its own method, `->single_row_columns()`, whether a subclass defined them or not.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31210 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 17:41:50 +00:00
Scott Taylor
07d899740e In WP_Filesystem_Base subclasses that set $wp_base, remove this dead code.
Unused since [8009] - "Make WP_Filesystem work with new directory constants"

There is currently no declared field and no `@property` annotation.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31209 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 17:22:07 +00:00
Scott Taylor
b0c6a64fbd WP_Filesystem_Base should declare $errors and $options as fields for use by subclasses.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31208 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 17:09:35 +00:00
Boone Gorges
60f2983b2e Bail out of hierarchy loops in _get_term_children().
This prevents infinite loops that lead to PHP nesting limit fatal errors.

Props boonebgorges, sgrant.
Fixes #24461.

git-svn-id: https://develop.svn.wordpress.org/trunk@31207 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 17:09:11 +00:00
Boone Gorges
8ae64f6384 Bail out of hierarchy loops in _pad_term_counts().
Taxonomy hierarchy loops should not occur naturally, but when they do, the
logic of `_pad_term_counts()` could result in infinite loops, leading to
timeouts. We avoid this by breaking when a loop is detected.

Fixes #20635.

git-svn-id: https://develop.svn.wordpress.org/trunk@31206 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 16:45:21 +00:00
Scott Taylor
18dbceee8c Add <s> to $allowedtags in KSES.
From https://developer.mozilla.org/en-US/docs/Web/HTML/Element/s :
"The <strike> element, alter ego of the <s> element is obsolete and should not be used on Web sites any more."

`<strike>` shall remain for BC, but `<s>` should not be stripped from the author (et al) role's HTML input.

Props paulschreiber.
Fixes #30954.


git-svn-id: https://develop.svn.wordpress.org/trunk@31205 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 16:06:47 +00:00
Scott Taylor
db1ace58ca In comment_form(), add the HTML5 required attribute next to aria-required in fields that utilize it.
Props MMN-o.
Fixes #24732.


git-svn-id: https://develop.svn.wordpress.org/trunk@31204 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 15:55:50 +00:00
Boone Gorges
af146fef8c In paginate_links(), don't override custom format arguments when setting up default 'add_args'.
Since 4.1 [29780], the default value of the 'add_args' argument in
`paginate_links()` has been determined by parsing the current URL. This change
had the side effect of overriding custom values of 'format' that changed the
pagination query var, with the result that plugins using `paginate_links()`
with a custom format generated the incorrect links unless explicitly
declaring 'add_args=false' to prevent the default values from overriding. We
fix this behavior by parsing URL query vars into the 'add_args' array only
after the explicit function params have been parsed, and by skipping the
current page's pagination query var when doing this parsing (to avoid the
override).

Props obenland.
Fixes #30831 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31203 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 15:48:24 +00:00
Scott Taylor
7c707c6633 Add @ignore to _wp_scripts_maybe_doing_it_wrong().
Props DrewAPicture for the thought leadership.
See #20513.


git-svn-id: https://develop.svn.wordpress.org/trunk@31202 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 05:37:06 +00:00
Scott Taylor
8ebe917c6b In wp_ajax_parse_media_shortcode(), don't require a global $post for all passed shortcodes.
`embed` is the only shortcode that requires a post ID. This will allow MCE views to work for `playlist`, `audio`, and `video` outside of the Edit Post screen.

See #30835.


git-svn-id: https://develop.svn.wordpress.org/trunk@31201 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 05:18:17 +00:00
Scott Taylor
83b6fad852 In HTML5, the action attribute is no longer required. Remove this attribute when empty.
The admin HTML is served with the HTML5 doctype.

"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces." 
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action

Props voldemortensen.
Fixes #30126.


git-svn-id: https://develop.svn.wordpress.org/trunk@31200 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 04:15:52 +00:00
Gary Pendergast
c8c8b66bae When a hyphen - or double hyphen -- was at the start or the end of a string, it wasn't texturized correctly.
Fixes #31030



git-svn-id: https://develop.svn.wordpress.org/trunk@31199 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 03:54:00 +00:00
Helen Hou-Sandi
d266ecd5b2 Media: Prevent filter selects from jiggling when the spinner shows.
props valendesigns.
fixes #30725 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@31197 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 02:59:59 +00:00
Scott Taylor
c6ba804b33 Make _wp_scripts_maybe_doing_it_wrong( $function ) "private".
Props obenland for the thought leadership.
See #20513.


git-svn-id: https://develop.svn.wordpress.org/trunk@31196 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 02:41:07 +00:00
Gary Pendergast
58d931dfc7 Allow comment_post_ID to be passed to wp_update_comment(), so that a comment can be moved to a different post.
Props tyxla, rachelbaker

Fixes #30946



git-svn-id: https://develop.svn.wordpress.org/trunk@31195 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 02:38:30 +00:00
Scott Taylor
28d654837d After [31192], create a function, wp_styles(), to reduce duplicated code in functions.wp-styles.php. The style functions can reuse wp_scripts_maybe_doing_it_wrong( $function ) internally.
See #20513.


git-svn-id: https://develop.svn.wordpress.org/trunk@31194 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 02:30:08 +00:00
Scott Taylor
e1da69195d In wp_print_scripts(), bail if $handles is false and the $wp_scripts global has not been instantiated.
See [31192], #20513.


git-svn-id: https://develop.svn.wordpress.org/trunk@31193 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 02:27:49 +00:00
Scott Taylor
7ccdc6b470 functions.wp-scripts.php contains a lot of duplicated code. Make 2 new functions: wp_scripts() and wp_scripts_maybe_doing_it_wrong( $function ), to encapsulate the repeated logic.
Props GaryJ, scribu, wonderboymusic.
Fixes #20513.


git-svn-id: https://develop.svn.wordpress.org/trunk@31192 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 02:06:03 +00:00
Scott Taylor
bcc7f9e093 In WP_User, ->get_role_caps() and ->update_user_level_from_caps() must be called inside ->add_cap() and ->remove_cap() after updating user meta. ->has_cap() checks are currently failing directly after calling ->add_cap().
Adds unit test.

Props rachelbaker.
Fixes #28374.


git-svn-id: https://develop.svn.wordpress.org/trunk@31190 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 01:48:36 +00:00
Scott Taylor
5412af65d8 Revert [31032], this did not get much love.
See #25277.


git-svn-id: https://develop.svn.wordpress.org/trunk@31189 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 01:10:39 +00:00
Scott Taylor
5acc6bdb58 In PHP 5.0.0, is_a() became deprecated in favour of the instanceof operator. Calling is_a() would result in an E_STRICT warning.
In PHP 5.3.0, `is_a()` is no longer deprecated, and will therefore no longer throw `E_STRICT` warnings.

To avoid warnings in PHP < 5.3.0, convert all `is_a()` calls to `$var instanceof WP_Class` calls.

`instanceof` does not throw any error if the variable being tested is not an object, it simply returns `false`.

Props markoheijnen, wonderboymusic.
Fixes #25672.


git-svn-id: https://develop.svn.wordpress.org/trunk@31188 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 01:05:52 +00:00
Scott Taylor
102fb4ac5c Replace the 3 remaining occurrences of wpspin GIF with spinner.
Props avryl.
Fixes #27482.


git-svn-id: https://develop.svn.wordpress.org/trunk@31187 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 00:32:45 +00:00
Scott Taylor
0c71d0033a Ensure that <figcaption> is not autop'd.
Fixes #29219.


git-svn-id: https://develop.svn.wordpress.org/trunk@31186 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 00:26:36 +00:00
Andrew Ozz
adc9a1d565 TinyMCE: remove the fade in/out when opening/closing native modals to match the rest of our UI. Props afercia, avryl. Fixes #27388.
git-svn-id: https://develop.svn.wordpress.org/trunk@31185 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-15 23:28:39 +00:00
Lance Willett
ff779e2d0e Twenty Fifteen: move js and no-js class name functionality out of header template and into a wp_head hook in functions.php file so that the JavaScript functionality isn't hard-coded into a template file.
Fixes #30770, props chipbennett, valendesigns, and peterwilsoncc.

git-svn-id: https://develop.svn.wordpress.org/trunk@31184 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-15 23:09:07 +00:00
Lance Willett
f09026e439 Twenty Fifteen: remove unused CSS rules for wp_page_menu since are not used in the theme. And a bit of CSS cleanup.
Props iamtakashi, fixes #30957.

git-svn-id: https://develop.svn.wordpress.org/trunk@31183 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-15 23:04:28 +00:00
Lance Willett
541ec337cf Twenty Fifteen: remove border on post navigation when post thumbnail is available.
Props jartes, fixes #30918.

git-svn-id: https://develop.svn.wordpress.org/trunk@31182 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-15 23:02:24 +00:00
Helen Hou-Sandi
8ab449ae35 List tables: Use CSS :nth-child() selectors for zebra striping.
Note that this does not fix issues related to comment quick edit. Internal linking also continues to use the `.alternate` class for now. IE8 and below gracefully degrade by not having zebra striping.

There is some hoop jumping with adding an extra table row to maintain zebra striping during quick edit. Documenting that here for future reference; it is also in the inline documentation.

fixes #30981 and #26060. see #25060.


git-svn-id: https://develop.svn.wordpress.org/trunk@31181 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-14 22:13:03 +00:00
Andrew Ozz
84c0411bcc TinyMCE: select the iframe element by id. Needed as some browser extensions insert extra elements in the page. Props avryl, see #30785.
git-svn-id: https://develop.svn.wordpress.org/trunk@31180 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-14 21:32:23 +00:00
Boone Gorges
4b6957c852 Support array values in WP_Date_Query::validate_date_values().
Introduced in [29925], `validate_date_values()` throws `_doing_it_wrong()`
notices when values passed as part of a `WP_Date_Query` do not reflect actual
dates. However, the validation did not account properly for the case where an
array of multiple values is passed, as when doing IN or BETWEEN queries.

Props dlh.
Fixes #31001 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31179 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-14 16:50:09 +00:00
Jeremy Felt
1a930c5d43 Don't overcheck the expected return from get_blog_details() in get_blogaddress_by_id()
If `get_blog_details()` is returning something that is not our expected object or `false`, then a notice would already be thrown there.

Also adds proper return docs to `get_blog_details()`.

Props SergeyBiryukov.

Fixes #30566


git-svn-id: https://develop.svn.wordpress.org/trunk@31178 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-14 05:32:19 +00:00
Sergey Biryukov
02d9bcbb7c Revert [31173] and target only taxonomy and link manager tables in keyboard focus code.
props afercia.
fixes #30980.

git-svn-id: https://develop.svn.wordpress.org/trunk@31177 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-13 14:00:15 +00:00
Sergey Biryukov
74bb197a4a Customizer: Use deep-link for Widgets in toolbar on front-end.
props caseypatrickdriscoll.
fixes #30971.

git-svn-id: https://develop.svn.wordpress.org/trunk@31176 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-13 07:44:57 +00:00
Sergey Biryukov
4b498e9201 Twenty Fifteen: Add print section to the table of contents in the stylesheet.
props iamtakashi.
fixes #30993.

git-svn-id: https://develop.svn.wordpress.org/trunk@31175 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-13 07:20:51 +00:00
Sergey Biryukov
b61f6f3a60 Scope attachment selectors in media views to avoid interfering with attachment pages on front-end.
props valendesigns.
fixes #30878.

git-svn-id: https://develop.svn.wordpress.org/trunk@31174 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-13 07:15:24 +00:00
Sergey Biryukov
cfa5aa457d Reveal row actions on focus on taxonomy screens.
props afercia.
fixes #30980.

git-svn-id: https://develop.svn.wordpress.org/trunk@31173 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-13 07:01:49 +00:00
Sergey Biryukov
819a53be46 Add 'user_id' to the list of fields wp_update_comment() can update.
props jphase.
fixes #30307.

git-svn-id: https://develop.svn.wordpress.org/trunk@31172 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-13 06:47:33 +00:00
Sergey Biryukov
a744bb9a5f Add 'comment_type' to the list of fields wp_update_comment() can update.
props desaiuditd.
fixes #30627.

git-svn-id: https://develop.svn.wordpress.org/trunk@31171 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-13 06:41:19 +00:00
Drew Jaynes (DrewAPicture)
9b0cf1bd5b Ensure we're using the correct @ignore phpDocumentor tag to mark elements that should be skipped when parsing.
Up to this point, various core elements' DocBlocks incorrectly included an `@internal` tag as a means for skipping the parsing process. When paired with a description (inline or otherwise), `@internal` is a valid tag meant to provide internal-only context, but not necessarily to skip parsing the entire element.

See #30987.


git-svn-id: https://develop.svn.wordpress.org/trunk@31170 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-13 00:50:32 +00:00
Drew Jaynes (DrewAPicture)
1f9ee350fc Remove an erroneous @internal tag from the DocBlock for get_children().
Use of the `@internal` tag caused the reference article for this function to be skipped during the parsing process.

Fixes #30987 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@31169 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-13 00:07:39 +00:00
Scott Taylor
865185903b There are some random add_action() and add_filter() calls littered around some files in wp-includes/. These should be moved to wp-includes/default-filters.php with the rest of the registered hooks. It seems like this was the best practice for awhile and then we randomly stopped. This file loads way before any of the includes, so the hooks will be registered for any request that loads WordPress, even SHORTINIT - a lot of the hooks registered won't run anyways (that's already the case).
See #30947.


git-svn-id: https://develop.svn.wordpress.org/trunk@31168 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-12 16:39:39 +00:00
Scott Taylor
47ba5e6c2e WP_Themes_List_Table accesses $_pagination_args from the parent class. Switch $_pagination_args to protected in WP_List_Table.
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31167 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-12 16:25:30 +00:00
Scott Taylor
47a74bb21f Add a private field to WP_Terms_List_Table, $level.
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31166 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-12 16:22:38 +00:00
Scott Taylor
b3f726efc4 Add a private field to WP_Posts_List_Table, $is_trash.
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31165 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-12 16:21:08 +00:00
Scott Taylor
e5672bd8c5 Add a private field to WP_Plugin_Install_List_Table, $error.
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31164 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-12 16:18:52 +00:00
Scott Taylor
02eaef3ae0 In lieu of refactoring, add a private field to WP_MS_Themes_List_Table, $has_items. Ideally, this class would overload ->has_items() and not set a private field.
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31163 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-12 16:16:16 +00:00
Scott Taylor
f0c4ab3e69 Add 2 private fields to WP_Media_List_Table, $detached and $is_trash.
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31162 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-12 16:07:41 +00:00