sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
28,936 Commits 2 Branches 473 Tags 137 MiB
73a85825fb
Commit Graph

5580 Commits

Author SHA1 Message Date
Boone Gorges
8ec0792557 Add classes for custom taxonomy terms in get_post_class(). 
Props sillybean.
Fixes #16223.

git-svn-id: https://develop.svn.wordpress.org/trunk@31271 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-23 15:40:31 +00:00
Boone Gorges
10d3b42211 Introduce 'parent' parameter to wp_get_object_terms(). 
Props mikeschinkel.
Fixes #15675.

git-svn-id: https://develop.svn.wordpress.org/trunk@31270 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-23 14:56:04 +00:00
Sergey Biryukov
63ee24789d In wp_update_user(), make sure $userdata['ID'] is set before using it. 
props tyxla.
fixes #31097.

git-svn-id: https://develop.svn.wordpress.org/trunk@31269 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-22 14:45:14 +00:00
Lance Willett
6629feb738 Twenty Eleven and Twelve: fill in support for screen-reader-text class. 
Props obenland, fixes #31095.

git-svn-id: https://develop.svn.wordpress.org/trunk@31268 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-22 00:55:09 +00:00
Lance Willett
2487709643 Twenty Eleven: fix indentation (spaces to tabs). See #29127. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31267 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-22 00:43:31 +00:00
Lance Willett
9ad83781e9 Twenty Ten: fix escaping and minor code style issues. See #29127. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31266 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-22 00:41:58 +00:00
Lance Willett
31b1340825 Twenty Eleven: fix escaping and minor code style issues. See #29127. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31265 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-22 00:41:36 +00:00
Gary Pendergast
cd02bd0702 Comments: When a comment fails to insert, remove invalid characters from the email and URL fields, too. 
See [31263], #21212



git-svn-id: https://develop.svn.wordpress.org/trunk@31264 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-21 23:17:08 +00:00
Gary Pendergast
b2642750ce Comments: When a comment fails to insert, remove any invalid characters and try again. 
See #21212



git-svn-id: https://develop.svn.wordpress.org/trunk@31263 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-21 23:03:48 +00:00
Lance Willett
260f671a95 Twenty Twelve: more fixes for escaping and minor code style issues. See #29127. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31262 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-21 21:05:29 +00:00
Lance Willett
74eb9552bf Twenty Twelve: fix escaping and minor code style issues. See #29127. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31261 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-21 20:59:15 +00:00
Lance Willett
95f9a91d86 Twenty Thirteen: fix escaping and minor code style issues. See #29127. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31260 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-21 20:48:45 +00:00
Dominik Schilling (ocean90)
3089d4d6cc Customizer: Hide the reorder-widgets button when a widget area is empty. 
props celloexpressions.
fixes #27787.

git-svn-id: https://develop.svn.wordpress.org/trunk@31255 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-20 22:44:11 +00:00
Dominik Schilling (ocean90)
e3bff14246 Customizer: If there's only one available sidebar, hide the move-widget button. 
props celloexpressions.
fixes #30690.

git-svn-id: https://develop.svn.wordpress.org/trunk@31252 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-20 20:35:13 +00:00
Boone Gorges
f1771073dc WP_Date_Query date validation should not fail for hour = 0. 
Props ChriCo, tyxla.
Fixes #31067 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31251 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-20 19:12:48 +00:00
Lance Willett
37ea642f69 Twenty Fourteen: fix escaping and minor code style issues. See #29127. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31250 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-20 19:02:53 +00:00
Gary Pendergast
3a87ef36e2 Texturize: Add "em" as a cockney term, so that "'em" is texturized with an apostrophe, instead of an open quote. 
Fixes #29813.

Props miqrogroove.



git-svn-id: https://develop.svn.wordpress.org/trunk@31249 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-20 18:43:30 +00:00
Boone Gorges
d80ca82693 Better loop detection for _pad_term_counts(). 
The `$ancestors` check must be reset for each term in order for term counts
to be correct.

Fixes #20635.

git-svn-id: https://develop.svn.wordpress.org/trunk@31248 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-19 16:51:44 +00:00
Sergey Biryukov
2c955c0bbf Remove inaccurate part of {$taxonomy}_add_form_fields action description. 
props joostdekeijzer.
fixes #31052.

git-svn-id: https://develop.svn.wordpress.org/trunk@31247 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-19 15:30:09 +00:00
Drew Jaynes (DrewAPicture)
5e301c5794 Add missing summaries and descriptions for various functions in wp-admin/includes/upgrade.php. 
Also generally improve existing parameter, return, and other documentation in various function DocBlocks.

Props morganestes.
Fixes #30825.


git-svn-id: https://develop.svn.wordpress.org/trunk@31246 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-19 09:14:39 +00:00
Drew Jaynes (DrewAPicture)
032ec0d24a Remove a stray period introduced in [31242]. 
Props SergeyBiryukov.
See #31048.


git-svn-id: https://develop.svn.wordpress.org/trunk@31245 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-19 08:46:24 +00:00
Drew Jaynes (DrewAPicture)
b590db9253 Ensure the correct list of default tabs for the Plugin Install screen are documented. 
Props stevenkword.
Fixes #31017.


git-svn-id: https://develop.svn.wordpress.org/trunk@31244 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-19 08:43:15 +00:00
Drew Jaynes (DrewAPicture)
73780fdd32 Add more complete documentation for parameters, globals, and return values to the DocBlocks for remove_shortcode(), shortcode_exists(), and do_shortcode(). 
Props SergeyBiryukov.
Fixes #31048.


git-svn-id: https://develop.svn.wordpress.org/trunk@31243 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-19 08:39:10 +00:00
Drew Jaynes (DrewAPicture)
596412fb0b Ensure both parameters and the return for has_shortcode() are fully documented. 
Props cais, SergeyBiryukov
See #31048.


git-svn-id: https://develop.svn.wordpress.org/trunk@31242 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-19 08:35:05 +00:00
Sergey Biryukov
352be0b432 Display correct title in Archives widget if the type of archive was changed using the 'widget_archives_dropdown_args' filter. 
props floriansimeth for initial patch.
fixes #31024.

git-svn-id: https://develop.svn.wordpress.org/trunk@31241 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-19 08:25:36 +00:00
Sergey Biryukov
4a1cf7a38b Strip HTML tags when searching for installed themes. 
props enej, SergeyBiryukov, obenland.
fixes #27561.

git-svn-id: https://develop.svn.wordpress.org/trunk@31240 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-18 20:39:39 +00:00
Sergey Biryukov
a036114a4d attachment_url_to_postid() should always return an integer. 
props nathan_dawson, ashfame.
fixes #31044.

git-svn-id: https://develop.svn.wordpress.org/trunk@31239 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-18 20:32:50 +00:00
Drew Jaynes (DrewAPicture)
a79297ba2d Minor fix for inline doc syntax in a changelog entry for wp_get_object_terms(). 
See #28688.


git-svn-id: https://develop.svn.wordpress.org/trunk@31238 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-18 19:04:45 +00:00
Boone Gorges
fd886b7d60 Add @since annotation for 'orderby' values introduced in [31236]. 
See #28688.

git-svn-id: https://develop.svn.wordpress.org/trunk@31237 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-18 19:02:34 +00:00
Boone Gorges
9501fb3213 Additional 'orderby' values for wp_get_object_terms(). 
Adds support for ordering by 'taxonomy', 'term_taxonomy_id', and 'parent'.

Props ChriCo.
Fixes #28688.

git-svn-id: https://develop.svn.wordpress.org/trunk@31236 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-18 18:56:38 +00:00
Andrew Ozz
9ade002c6f TinyMCE: fix vertical positioning of the image toolbar when there are several instances of the editor. Props avryl, fixes #31028. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31235 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-18 17:55:39 +00:00
Sergey Biryukov
2b4099c6bd Customizer: Replicate behavior from options-reading.php and hide front page options if there are no pages. 
props Clorith.
fixes #27630.

git-svn-id: https://develop.svn.wordpress.org/trunk@31234 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-18 06:00:18 +00:00
Boone Gorges
c7e95b9433 Correct wp_get_object_terms() documentation. 
The 'orderby' parameter accepts a number of values that have never been
properly documented.

git-svn-id: https://develop.svn.wordpress.org/trunk@31232 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-17 20:38:20 +00:00
Boone Gorges
b18ee3334f Standardize the docblock for wp_get_object_terms(). 
The enumeration of the `$args` parameter has been moved from the long
description to an array hash associated with the proper `@param` attribute.

git-svn-id: https://develop.svn.wordpress.org/trunk@31231 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-17 20:08:11 +00:00
Sergey Biryukov
658d1bb32e Add a changelog entry for the new parameter added in [31228]. 
props DrewAPicture.
fixes #31015.

git-svn-id: https://develop.svn.wordpress.org/trunk@31229 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-17 17:30:10 +00:00
Sergey Biryukov
54f366da0b Pass $force_reauth value to the 'login_url' filter. 
props jfarthing84, MikeHansenMe.
fixes #31015.

git-svn-id: https://develop.svn.wordpress.org/trunk@31228 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-17 17:19:57 +00:00
Sergey Biryukov
3c86263afe Customizer: Make "Search widgets" input sticky. 
props celloexpressions.
fixes #30751.

git-svn-id: https://develop.svn.wordpress.org/trunk@31227 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-17 13:15:00 +00:00
Sergey Biryukov
4c4de36c5c Customizer: Fix form tag replacement in WP_Customize_Widgets::get_widget_control() after [31200]. 
see #30126.

git-svn-id: https://develop.svn.wordpress.org/trunk@31226 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-17 13:10:27 +00:00
Sergey Biryukov
6e206c2973 Use the site's local time to create the first post during installation. 
props extendwings.
fixes #29296.

git-svn-id: https://develop.svn.wordpress.org/trunk@31225 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-17 10:06:42 +00:00
Sergey Biryukov
e7bf16b423 Introduce has_header_image() to check whether a header image is set. 
props GunGeekATX, voldemortensen.
fixes #16268.

git-svn-id: https://develop.svn.wordpress.org/trunk@31224 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-17 06:33:42 +00:00
Andrew Ozz
f18854e866 Add support for IE conditional comments for WP_Scripts to match the functionality of WP_Styles, including unit tests. Props filosofo, aaroncampbell, ethitter, georgestephanis, valendesigns. Fixes #16024. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31223 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-17 01:36:55 +00:00
Andrew Ozz
5378b4e000 TinyMCE: add breaking out of blockquotes by pressing Enter twice. Togging blockquote on|off with the button and the shortcut is unchanged. Props avryl, fixes #23110. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31222 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 23:35:24 +00:00
Scott Taylor
cd2d6d27d9 wp_set_object_terms() takes $taxonomy as a string. Update @param. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31221 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 23:26:38 +00:00
Scott Taylor
357fa4131a Fix some internal types that are passed to functions to avoid changing the acceptable types passed as arguments to those functions: 
* In `WP_Importer->is_user_over_quota()`, the default value for the first argument for `upload_is_user_over_quota()` is `true`. Don't bother passing `1`.
* When calling `submit_button()` with no `$name`, pass empty string instead of `false`.
* The default value for the 2nd argument to `get_edit_post_link()` is `'display'`. Because PHP is PHP, passing `true` is the same as passing `'display'` or nothing. Don't bother passing `true`. 
* In `WP_User_Meta_Session_Tokens::drop_sessions()`, pass `0` instead of `false` to `delete_metadata()` as the value for `$object_id`, which expects an int. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31220 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 22:50:20 +00:00
Scott Taylor
1d3b42d226 Fix some erroneous @param annotations. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31219 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 22:43:13 +00:00
Boone Gorges
5b7baae907 In get_edit_term_link(), default to a valid $object_type. 
The $object_type param is used to set the 'post_type' query var, which
determines the post type menu that will be expanded when clicking through to
the term edit page. Not all taxonomies are associated with Posts, so it makes
sense to default to a post_type that the taxonomy is actually associated with.

Props DzeryCZ, juliobox.
Fixes #29251.

git-svn-id: https://develop.svn.wordpress.org/trunk@31218 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 21:36:12 +00:00
Scott Taylor
5deee71273 Remove unused local vars in delete_plugins(), delete_theme(), WP_Date_Query->validate_date_values(), global_terms(), and WP_Text_Diff_Renderer_Table->_changed(). 
This will clear out the "Unused Code" label in the next Scrutinizer report.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31217 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 21:18:52 +00:00
Scott Taylor
2ed007c023 Calling ->chown() and ->chgrp() in WP_Filesystem_ftpsockets produces no side-effects. Remove the calls. ->chgrp() is defined in the super class, and does nothing, can be removed from the child class. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31216 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 21:09:18 +00:00
Scott Taylor
9a16e6230b Calling ->chown() and ->chgrp() in WP_Filesystem_FTPext produces no side-effects. Remove the calls. ->chgrp() is defined in the super class, and does nothing, can be removed from the child class. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31215 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 21:06:29 +00:00
Lance Willett
19b4a0053a Twenty Fifteen: keep sub-menus open when visiting sub-menu pages, to show context when navigating a site. 
Props jartes, fixes #30722.

git-svn-id: https://develop.svn.wordpress.org/trunk@31214 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 19:16:56 +00:00
Scott Taylor
d29abb1d24 By initializing this array before a loop, Scrutinizer reports 0 (zero) "Coding Style" errors. 
There are plenty of other kinds of errors, but this label will be cleared out.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31213 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 19:12:15 +00:00
Scott Taylor
5743898e1e @param cleanup: 
* `get_metadata()` will return literally anything, needs to be `mixed`
* `wp()` and `WP_Query::__construct()` no longer just take a query string
* Clarify a few others

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31212 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 19:02:26 +00:00
Scott Taylor
835dbe7baf [31210] broke Supportflow on dotorg, which declares these methods as protected. Switch to protected for the noop methods. The subclasses can make them more visible using public. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31211 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 18:36:46 +00:00
Scott Taylor
e3ac341f24 Add 2 noop methods to WP_List_Table: ->column_default() and ->column_cb(). 
`WP_List_Table` is essentially an `abstract` class. Some of its methods throw `die()` warnings if they aren't overridden in a child class.

These noop methods wouldn't be `abstract`, because they are not required in subclasses. However, `WP_List_Table` can call these methods in its own method, `->single_row_columns()`, whether a subclass defined them or not.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31210 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 17:41:50 +00:00
Scott Taylor
07d899740e In WP_Filesystem_Base subclasses that set $wp_base, remove this dead code. 
Unused since [8009] - "Make WP_Filesystem work with new directory constants"

There is currently no declared field and no `@property` annotation.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31209 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 17:22:07 +00:00
Scott Taylor
b0c6a64fbd WP_Filesystem_Base should declare $errors and $options as fields for use by subclasses. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31208 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 17:09:35 +00:00
Boone Gorges
60f2983b2e Bail out of hierarchy loops in _get_term_children(). 
This prevents infinite loops that lead to PHP nesting limit fatal errors.

Props boonebgorges, sgrant.
Fixes #24461.

git-svn-id: https://develop.svn.wordpress.org/trunk@31207 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 17:09:11 +00:00
Boone Gorges
8ae64f6384 Bail out of hierarchy loops in _pad_term_counts(). 
Taxonomy hierarchy loops should not occur naturally, but when they do, the
logic of `_pad_term_counts()` could result in infinite loops, leading to
timeouts. We avoid this by breaking when a loop is detected.

Fixes #20635.

git-svn-id: https://develop.svn.wordpress.org/trunk@31206 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 16:45:21 +00:00
Scott Taylor
18dbceee8c Add <s> to $allowedtags in KSES. 
From https://developer.mozilla.org/en-US/docs/Web/HTML/Element/s :
"The <strike> element, alter ego of the <s> element is obsolete and should not be used on Web sites any more."

`<strike>` shall remain for BC, but `<s>` should not be stripped from the author (et al) role's HTML input.

Props paulschreiber.
Fixes #30954.


git-svn-id: https://develop.svn.wordpress.org/trunk@31205 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 16:06:47 +00:00
Scott Taylor
db1ace58ca In comment_form(), add the HTML5 required attribute next to aria-required in fields that utilize it. 
Props MMN-o.
Fixes #24732.


git-svn-id: https://develop.svn.wordpress.org/trunk@31204 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 15:55:50 +00:00
Boone Gorges
af146fef8c In paginate_links(), don't override custom format arguments when setting up default 'add_args'. 
Since 4.1 [29780], the default value of the 'add_args' argument in
`paginate_links()` has been determined by parsing the current URL. This change
had the side effect of overriding custom values of 'format' that changed the
pagination query var, with the result that plugins using `paginate_links()`
with a custom format generated the incorrect links unless explicitly
declaring 'add_args=false' to prevent the default values from overriding. We
fix this behavior by parsing URL query vars into the 'add_args' array only
after the explicit function params have been parsed, and by skipping the
current page's pagination query var when doing this parsing (to avoid the
override).

Props obenland.
Fixes #30831 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31203 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 15:48:24 +00:00
Scott Taylor
7c707c6633 Add @ignore to _wp_scripts_maybe_doing_it_wrong(). 
Props DrewAPicture for the thought leadership.
See #20513.


git-svn-id: https://develop.svn.wordpress.org/trunk@31202 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 05:37:06 +00:00
Scott Taylor
8ebe917c6b In wp_ajax_parse_media_shortcode(), don't require a global $post for all passed shortcodes. 
`embed` is the only shortcode that requires a post ID. This will allow MCE views to work for `playlist`, `audio`, and `video` outside of the Edit Post screen.

See #30835.


git-svn-id: https://develop.svn.wordpress.org/trunk@31201 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 05:18:17 +00:00
Scott Taylor
83b6fad852 In HTML5, the action attribute is no longer required. Remove this attribute when empty. 
The admin HTML is served with the HTML5 doctype.

"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces." 
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action

Props voldemortensen.
Fixes #30126.


git-svn-id: https://develop.svn.wordpress.org/trunk@31200 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 04:15:52 +00:00
Gary Pendergast
c8c8b66bae When a hyphen - or double hyphen -- was at the start or the end of a string, it wasn't texturized correctly. 
Fixes #31030



git-svn-id: https://develop.svn.wordpress.org/trunk@31199 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 03:54:00 +00:00
Helen Hou-Sandi
d266ecd5b2 Media: Prevent filter selects from jiggling when the spinner shows. 
props valendesigns.
fixes #30725 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@31197 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 02:59:59 +00:00
Scott Taylor
c6ba804b33 Make _wp_scripts_maybe_doing_it_wrong( $function ) "private". 
Props obenland for the thought leadership.
See #20513.


git-svn-id: https://develop.svn.wordpress.org/trunk@31196 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 02:41:07 +00:00
Gary Pendergast
58d931dfc7 Allow comment_post_ID to be passed to wp_update_comment(), so that a comment can be moved to a different post. 
Props tyxla, rachelbaker

Fixes #30946



git-svn-id: https://develop.svn.wordpress.org/trunk@31195 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 02:38:30 +00:00
Scott Taylor
28d654837d After [31192], create a function, wp_styles(), to reduce duplicated code in functions.wp-styles.php. The style functions can reuse wp_scripts_maybe_doing_it_wrong( $function ) internally. 
See #20513.


git-svn-id: https://develop.svn.wordpress.org/trunk@31194 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 02:30:08 +00:00
Scott Taylor
e1da69195d In wp_print_scripts(), bail if $handles is false and the $wp_scripts global has not been instantiated. 
See [31192], #20513.


git-svn-id: https://develop.svn.wordpress.org/trunk@31193 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 02:27:49 +00:00
Scott Taylor
7ccdc6b470 functions.wp-scripts.php contains a lot of duplicated code. Make 2 new functions: wp_scripts() and wp_scripts_maybe_doing_it_wrong( $function ), to encapsulate the repeated logic. 
Props GaryJ, scribu, wonderboymusic.
Fixes #20513.


git-svn-id: https://develop.svn.wordpress.org/trunk@31192 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 02:06:03 +00:00
Scott Taylor
bcc7f9e093 In WP_User, ->get_role_caps() and ->update_user_level_from_caps() must be called inside ->add_cap() and ->remove_cap() after updating user meta. ->has_cap() checks are currently failing directly after calling ->add_cap(). 
Adds unit test.

Props rachelbaker.
Fixes #28374.


git-svn-id: https://develop.svn.wordpress.org/trunk@31190 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 01:48:36 +00:00
Scott Taylor
5412af65d8 Revert [31032], this did not get much love. 
See #25277.


git-svn-id: https://develop.svn.wordpress.org/trunk@31189 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 01:10:39 +00:00
Scott Taylor
5acc6bdb58 In PHP 5.0.0, is_a() became deprecated in favour of the instanceof operator. Calling is_a() would result in an E_STRICT warning. 
In PHP 5.3.0, `is_a()` is no longer deprecated, and will therefore no longer throw `E_STRICT` warnings.

To avoid warnings in PHP < 5.3.0, convert all `is_a()` calls to `$var instanceof WP_Class` calls.

`instanceof` does not throw any error if the variable being tested is not an object, it simply returns `false`.

Props markoheijnen, wonderboymusic.
Fixes #25672.


git-svn-id: https://develop.svn.wordpress.org/trunk@31188 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 01:05:52 +00:00
Scott Taylor
102fb4ac5c Replace the 3 remaining occurrences of wpspin GIF with spinner. 
Props avryl.
Fixes #27482.


git-svn-id: https://develop.svn.wordpress.org/trunk@31187 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 00:32:45 +00:00
Scott Taylor
0c71d0033a Ensure that <figcaption> is not autop'd. 
Fixes #29219.


git-svn-id: https://develop.svn.wordpress.org/trunk@31186 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 00:26:36 +00:00
Andrew Ozz
adc9a1d565 TinyMCE: remove the fade in/out when opening/closing native modals to match the rest of our UI. Props afercia, avryl. Fixes #27388. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31185 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-15 23:28:39 +00:00
Lance Willett
ff779e2d0e Twenty Fifteen: move js and no-js class name functionality out of header template and into a wp_head hook in functions.php file so that the JavaScript functionality isn't hard-coded into a template file. 
Fixes #30770, props chipbennett, valendesigns, and peterwilsoncc.

git-svn-id: https://develop.svn.wordpress.org/trunk@31184 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-15 23:09:07 +00:00
Lance Willett
f09026e439 Twenty Fifteen: remove unused CSS rules for wp_page_menu since are not used in the theme. And a bit of CSS cleanup. 
Props iamtakashi, fixes #30957.

git-svn-id: https://develop.svn.wordpress.org/trunk@31183 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-15 23:04:28 +00:00
Lance Willett
541ec337cf Twenty Fifteen: remove border on post navigation when post thumbnail is available. 
Props jartes, fixes #30918.

git-svn-id: https://develop.svn.wordpress.org/trunk@31182 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-15 23:02:24 +00:00
Helen Hou-Sandi
8ab449ae35 List tables: Use CSS :nth-child() selectors for zebra striping. 
Note that this does not fix issues related to comment quick edit. Internal linking also continues to use the `.alternate` class for now. IE8 and below gracefully degrade by not having zebra striping.

There is some hoop jumping with adding an extra table row to maintain zebra striping during quick edit. Documenting that here for future reference; it is also in the inline documentation.

fixes #30981 and #26060. see #25060.


git-svn-id: https://develop.svn.wordpress.org/trunk@31181 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-14 22:13:03 +00:00
Andrew Ozz
84c0411bcc TinyMCE: select the iframe element by id. Needed as some browser extensions insert extra elements in the page. Props avryl, see #30785. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31180 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-14 21:32:23 +00:00
Boone Gorges
4b6957c852 Support array values in WP_Date_Query::validate_date_values(). 
Introduced in [29925], `validate_date_values()` throws `_doing_it_wrong()`
notices when values passed as part of a `WP_Date_Query` do not reflect actual
dates. However, the validation did not account properly for the case where an
array of multiple values is passed, as when doing IN or BETWEEN queries.

Props dlh.
Fixes #31001 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31179 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-14 16:50:09 +00:00
Jeremy Felt
1a930c5d43 Don't overcheck the expected return from get_blog_details() in get_blogaddress_by_id() 
If `get_blog_details()` is returning something that is not our expected object or `false`, then a notice would already be thrown there.

Also adds proper return docs to `get_blog_details()`.

Props SergeyBiryukov.

Fixes #30566


git-svn-id: https://develop.svn.wordpress.org/trunk@31178 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-14 05:32:19 +00:00
Sergey Biryukov
02d9bcbb7c Revert [31173] and target only taxonomy and link manager tables in keyboard focus code. 
props afercia.
fixes #30980.

git-svn-id: https://develop.svn.wordpress.org/trunk@31177 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-13 14:00:15 +00:00
Sergey Biryukov
74bb197a4a Customizer: Use deep-link for Widgets in toolbar on front-end. 
props caseypatrickdriscoll.
fixes #30971.

git-svn-id: https://develop.svn.wordpress.org/trunk@31176 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-13 07:44:57 +00:00
Sergey Biryukov
4b498e9201 Twenty Fifteen: Add print section to the table of contents in the stylesheet. 
props iamtakashi.
fixes #30993.

git-svn-id: https://develop.svn.wordpress.org/trunk@31175 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-13 07:20:51 +00:00
Sergey Biryukov
b61f6f3a60 Scope attachment selectors in media views to avoid interfering with attachment pages on front-end. 
props valendesigns.
fixes #30878.

git-svn-id: https://develop.svn.wordpress.org/trunk@31174 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-13 07:15:24 +00:00
Sergey Biryukov
cfa5aa457d Reveal row actions on focus on taxonomy screens. 
props afercia.
fixes #30980.

git-svn-id: https://develop.svn.wordpress.org/trunk@31173 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-13 07:01:49 +00:00
Sergey Biryukov
819a53be46 Add 'user_id' to the list of fields wp_update_comment() can update. 
props jphase.
fixes #30307.

git-svn-id: https://develop.svn.wordpress.org/trunk@31172 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-13 06:47:33 +00:00
Sergey Biryukov
a744bb9a5f Add 'comment_type' to the list of fields wp_update_comment() can update. 
props desaiuditd.
fixes #30627.

git-svn-id: https://develop.svn.wordpress.org/trunk@31171 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-13 06:41:19 +00:00
Drew Jaynes (DrewAPicture)
9b0cf1bd5b Ensure we're using the correct @ignore phpDocumentor tag to mark elements that should be skipped when parsing. 
Up to this point, various core elements' DocBlocks incorrectly included an `@internal` tag as a means for skipping the parsing process. When paired with a description (inline or otherwise), `@internal` is a valid tag meant to provide internal-only context, but not necessarily to skip parsing the entire element.

See #30987.


git-svn-id: https://develop.svn.wordpress.org/trunk@31170 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-13 00:50:32 +00:00
Drew Jaynes (DrewAPicture)
1f9ee350fc Remove an erroneous @internal tag from the DocBlock for get_children(). 
Use of the `@internal` tag caused the reference article for this function to be skipped during the parsing process.

Fixes #30987 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@31169 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-13 00:07:39 +00:00
Scott Taylor
865185903b There are some random add_action() and add_filter() calls littered around some files in wp-includes/. These should be moved to wp-includes/default-filters.php with the rest of the registered hooks. It seems like this was the best practice for awhile and then we randomly stopped. This file loads way before any of the includes, so the hooks will be registered for any request that loads WordPress, even SHORTINIT - a lot of the hooks registered won't run anyways (that's already the case). 
See #30947.


git-svn-id: https://develop.svn.wordpress.org/trunk@31168 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 16:39:39 +00:00
Scott Taylor
47ba5e6c2e WP_Themes_List_Table accesses $_pagination_args from the parent class. Switch $_pagination_args to protected in WP_List_Table. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31167 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 16:25:30 +00:00
Scott Taylor
47a74bb21f Add a private field to WP_Terms_List_Table, $level. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31166 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 16:22:38 +00:00
Scott Taylor
b3f726efc4 Add a private field to WP_Posts_List_Table, $is_trash. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31165 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 16:21:08 +00:00
Scott Taylor
e5672bd8c5 Add a private field to WP_Plugin_Install_List_Table, $error. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31164 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 16:18:52 +00:00
Scott Taylor
02eaef3ae0 In lieu of refactoring, add a private field to WP_MS_Themes_List_Table, $has_items. Ideally, this class would overload ->has_items() and not set a private field. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31163 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 16:16:16 +00:00
Scott Taylor
f0c4ab3e69 Add 2 private fields to WP_Media_List_Table, $detached and $is_trash. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31162 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 16:07:41 +00:00
Scott Taylor
243d50d2f7 After [31146], properly declare $user_can as a private field in WP_Comments_List_Table. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31161 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 16:01:53 +00:00
Dion Hulse
32b020bf05 More concise documentation for wp_install_maybe_enable_pretty_permalinks() 
See #6481. Props ericlewis.


git-svn-id: https://develop.svn.wordpress.org/trunk@31160 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 04:32:35 +00:00
Dion Hulse
0aaa2f0f32 The new wp_install_maybe_enable_pretty_permalinks() function doesn't need to be pluggable. 
See #6481. Props nacin, valendesigns


git-svn-id: https://develop.svn.wordpress.org/trunk@31159 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 04:30:01 +00:00
Jeremy Felt
0eb9f7e414 Use a less complex approach for enforcing path slashes in update_blog_details() 
Ensure leading and traling slashes are in place and don't touch anything in the middle. Validating with `array_filter()` would have missed a possible valid falsy path - `/my-path/0/`.

Props nacin.

Fixes #18117.


git-svn-id: https://develop.svn.wordpress.org/trunk@31158 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 04:20:47 +00:00
Jeremy Felt
d759c0ef23 Check for existence of data from get_blogaddress_by_id() before returning a URL 
* Prevent a notice when an invalid ID is used with `get_blogaddres_by_id()`.
* Return a falsy empty string rather than the previous "http://".
* Add unit tests for `get_blogaddress_by_id()`.

Props nerrad.

Fixes #30566.


git-svn-id: https://develop.svn.wordpress.org/trunk@31157 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 02:23:43 +00:00
Jeremy Felt
331262b544 Update home and siteurl after path slashes are validated in update_blog_details() 
When editing a site, if `home` and `siteurl` are checked to be updated along with a site's domain and path, they should receive the results of any modifications in `update_blog_details()` rather than trusting the POST data.

Previously, it was possible to save a value without a leading slash on the path, causing an invalid URL to be stored.

Props earnjam.

Fixes #30417.


git-svn-id: https://develop.svn.wordpress.org/trunk@31156 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 01:56:04 +00:00
Jeremy Felt
f9e9287875 Enforce leading and trailing slashes on paths updated with update_blog_details() 
In multisite, core expects the stored value for a site's path to have leading and trailing slashes. When these slashes are missing, it becomes impossible to visit the site.

This enforces proper `/path/` creation in `update_blog_details()`, most likely used when updating an existing site through `site-info.php`.

Props earnjam, simonwheatley.

Fixes #18117. Fixes #23865.


git-svn-id: https://develop.svn.wordpress.org/trunk@31155 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 01:42:46 +00:00
Gary Pendergast
0b993ffe35 If get_avatar_data() is passed an empty value for the default avatar, we should be using the site's avatar_default option instead. 
See #21195


git-svn-id: https://develop.svn.wordpress.org/trunk@31154 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 00:22:12 +00:00
Gary Pendergast
69f8b26d89 In get_avatar_data(), there's no need to return false if we couldn't find an avatar, as Gravatar can handle being given an empty email hash. This allows the default avatar to show when no email address is given. 
See #21195



git-svn-id: https://develop.svn.wordpress.org/trunk@31153 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 00:19:34 +00:00
Gary Pendergast
d0fab598e7 In get_avatar(), revert the <img> tag attributes to using single quotes, instead of double quotes. This behaviour was changed in [31107], but caused problems for code that attempted to parse the <img> tag. 
See #21195



git-svn-id: https://develop.svn.wordpress.org/trunk@31152 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 00:02:31 +00:00
Scott Taylor
156a673660 In WP_Query, only call magic method internals again whitelists of properties and methods, $compat_fields and $compat_methods. Remove __unset() since __set() is not implemented. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31151 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 22:40:53 +00:00
Scott Taylor
1178e8a6e1 In WP_Comment_Query, only allow __call() to run against ->get_search_sql(). 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31150 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 22:32:44 +00:00
Scott Taylor
f6d7c5e52f In wp_xmlrpc_server, only allow __call() to run against ->_multisite_getUsersBlogs(). 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31149 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 22:30:26 +00:00
Scott Taylor
cd3fde69bb In WP_oEmbed, only allow __call() to run against a whitelist of methods, $compat_methods. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31148 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 22:26:55 +00:00
Scott Taylor
5b6858eff8 In WP_Roles, only allow __call() to run against ->_init(). 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31147 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 22:23:00 +00:00
Scott Taylor
274253629f In WP_List_Table, only call magic method internals again whitelists of properties and methods, $compat_fields and $compat_methods. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31146 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 22:19:58 +00:00
Scott Taylor
ad6dd738b2 In WP_Filesystem_Base, make the only private member, $cache, public and remove magic methods. $cache was always public until [28487], has been essentially public via a magic method since. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31145 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 22:03:59 +00:00
Scott Taylor
bbc7ca2d0d In WP_User_Query, only call magic method internals against a whitelist of properties, $compat_fields. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31144 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 21:59:54 +00:00
Andrew Ozz
43b2de66c6 TinyMCE wpView: when clicking in the editor optimize the caret placement before or after a view. Props avryl, fixes #30938. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31143 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 20:41:36 +00:00
Andrew Ozz
5a29757b92 TinyMCE: fix (switch) the indent/outdent icons in RTL mode so the arrow points at the proper direction. Props avryl, fixes #21281. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31142 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 20:29:56 +00:00
Boone Gorges
29d06de35d Walker::$has_children should be public for backward compatibility. 
See [31137]. See #30891.

git-svn-id: https://develop.svn.wordpress.org/trunk@31141 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 01:55:34 +00:00
Boone Gorges
77128eb048 Default $parent in category_exists() should default to null rather than 0. 
[29863] made the corresponding change in `term_exists()`. Failure to change the
default value in `category_exists()` meant that an unspecified value for
`$parent` would limit results to top-level categories.

Includes unit tests and corrected function documentation.

Props hissy.
Fixes #30975 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31140 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 01:25:19 +00:00
Scott Taylor
f323dc9b48 WP_Ajax_Response has one property only, $responses. It was public until [28508], when it became private in name only. Is it worth 4 magic methods to pretend that this property is private? It is not. 
Make it `public` and remove the magic methods.

See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31139 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 00:12:47 +00:00
Scott Taylor
ad81bf20db In WP_Error: 
* `wp_send_json_error()` accesses `$errors` on an instance, it must be `public`
* `$error_data` is a local message cache for error codes and doesn't particularly hide info, would be the only non-public field or method in the class

Make `$errors` and `$error_data` public and remove magic methods.

See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31138 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 00:00:05 +00:00
Scott Taylor
406b174a55 In Walker: 
* Every subclass of `Walker` overrides `$db_fields` and makes it public
* `wp_list_comments()` accesses `->max_pages` on an instance of `Walker`, it must be public
* `$has_children` was added as `protected` in 4.0. doesn't need BC

Make `$db_fields` and `$max_pages` public and remove magic methods.

See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31137 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 23:43:43 +00:00
Scott Taylor
14555b3af2 In WP_MatchesMapRegex: 
* Exactly one method was made private in [28516], and is only used internally.
* 2 properties were made private, but they just store variables passed to the constructor.
* Instances of this class are never created in core. `WP_MatchesMapRegex::apply()` is called statically in `WP->parse_request()` and `url_to_postid()`. 

The chances that: 
1) this class is used as an instance somewhere and 
2) the properties that have always been marked `@access private` and begin with `_` were used publicly

...is extremely low.

Remove the magic methods, I should not have added them.

While we're at it, use the PHP5-style `__construct()` instead of the class name.

See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31136 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 23:27:00 +00:00
Scott Taylor
f90b923777 In WP_Text_Diff_Renderer_Table: 
* In [28525], `$_diff_threshold`, `$inline_diff_renderer`, and `$_show_split_view` were marked `protected`; magic methods were also added.
* The magic methods should only perform operations on a whitelisted set of properties, now specified in `$compat_fields`
* Remove `__call()`, is unnecessary and can wreak havoc on the parent class.

This class is used in one place: `wp_text_diff()`.

See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31135 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 22:57:17 +00:00
wonderboymusic
cdb5c75ab2 In Custom_Image_Header: 
* In [28481], `$admin_header_callback` and `$admin_image_div_callback` were set to `private` based on their erroneous `@param` values
* `$admin_header_callback` and `$admin_image_div_callback` are used as hook callbacks - as such, they must be `public`
* In [28521] and [28524], magic methods were added for back-compat
* Currently, there are 4 properties marked `private`: `$uploaded_headers`, `$default_headers`, `$page`, and `$updated` - `$page` and `$uploaded_headers` are never used and `$updated` was added by me in [30187] during 4.1. `$default_headers` does not necessarily need to be `private`

Set `$admin_header_callback` and `$admin_image_div_callback` to `public`.
Remove the `$page` property - it duplicated the `$page` local var and is referenced/used nowhere.
Remove the `$uploaded_headers` property - it is used nowhere and is dead code.
Set `$default_headers` to `public`.
Remove the magic methods - they were beyond overkill and rendered moot by the above changes.

See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31134 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 22:10:02 +00:00
Scott Taylor
b23a9d9dff In Custom_Background: 
* In [28481], `$admin_header_callback` and `$admin_image_div_callback` were set to `private` based on their erroneous `@param` value
* `$admin_header_callback` and `$admin_image_div_callback` are used as hook callbacks - as such, they must be `public`
* In [28521] and [28524], magic methods were added for back-compat
* Currently, there are 2 properties marked `private`, `$page` and `$updated` - `$page` is never used and `$updated` was added by me in [30186] during 4.1

Set `$admin_header_callback` and `$admin_image_div_callback` to `public`.
Remove the `$page` property - it duplicated the `$page` local var and is referenced/used nowhere.
Remove the magic methods - they were beyond overkill and rendered moot by the above changes.

See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31133 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 21:58:19 +00:00
Scott Taylor
a8cf928200 get_post() takes $output as its 2nd param. The @return annotation should reflect the function's ability to return an array. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31132 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 21:37:23 +00:00
Scott Taylor
358b309da9 In edit-form-advanced.php: 
* `get_permalink( $post_ID )` can return `false`, set it to a variable and check it
* Using the variable allows us to replace 11 separate calls to `get_permalink( $post_ID )` in the file
* These notices were triggered by the potential for `false` to be passed to `esc_url()`

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31131 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 21:20:01 +00:00
Scott Taylor
d4c4205f31 get_header_image() can return false. In Custom_Image_Header->step_1(), check the value before setting the background-image portion of the style attribute. Setting the the URL to empty string will cause the current request to be set as the source of the background image. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31130 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 21:07:54 +00:00
Scott Taylor
0f54cc95b3 Since get_theme_mod() returns false on failure, $background_image_thumb can be set to it and checked instead of calling get_background_image() 3 times in Custom_Background->admin_page(). 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31129 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 20:43:12 +00:00
Scott Taylor
061daaa7ee Declare $action as a global in wp-admin/comment.php. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31128 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 20:41:04 +00:00
Scott Taylor
979ba60a57 Fix some @param docs that have chars too close them. 
Add `@property` annotations to `WP_User` and `WP_Post`.
Remove erroneous `@param`s from image editor class methods.
Officially add the property `$_column_headers` to `WP_List_Table`.	

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31127 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 06:56:51 +00:00
Scott Taylor
349e5cb318 Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Constructors do not have meaningful return values, anything that is returned from here is discarded. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31126 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 06:53:48 +00:00
Scott Taylor
cb85e15f06 Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value - anything that is returned is discarded. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31125 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 06:12:25 +00:00
Scott Taylor
bc723548a7 Declare $wp_version, $required_php_version, and $required_mysql_version as globals in install and upgrade admin files. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31124 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 05:56:45 +00:00
Scott Taylor
38e18d800c In wp-admin/includes/revision.php, $post->modified is a coding error. It should be $post->post_modified. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31123 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 05:49:24 +00:00
Scott Taylor
164b4f21c9 WP_Upgrader will take any "skin" that is passed to it, and set ->skin via composition. The default type of ->skin is WP_Upgrader_Skin, which doesn't have methods declared for ->bulk_header() and ->bulk_footer(). Add noop methods to WP_Upgrader_Skin. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31122 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 05:41:05 +00:00
Scott Taylor
77cffd8edf Admin globals: 
* Declare `$wp_importers` as a global in `admin.php`
* Declare `$post_type`, `$post_type_object`, and  `$post` as globals where applicable

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31121 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 05:28:46 +00:00
Scott Taylor
c3bd2252f5 Use PHP_SAPI constant instead of php_sapi_name() in iis7_supports_permalinks(), wp_fix_server_vars(), and wp_redirect(). 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31120 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 04:58:49 +00:00
Scott Taylor
44a3c002f5 In wp_ajax_upload_attachment(), wp_check_filetype_and_ext() doesn't need a 3rd param - it already defaults to null. Passing false would fail a strict check 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31119 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 04:54:13 +00:00
Andrew Ozz
23d6e28390 TinyMCE editor-expand: when kitchensink is off hide the statusbar on loading, and when the editor is shorter then the viewport. Props avryl, fixes #30961. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31118 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 01:32:00 +00:00
Andrew Ozz
47cfdb5ced Media modal: do not attempt to focus the hidden file input field added by Plupload when tabbing. Props afercia, fixes #30392. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31117 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 21:46:03 +00:00
Scott Taylor
b3322a9604 In Custom_Background and Custom_Header: 
* In `->init()`, don't check `current_user_can()` since `add_theme_page()` will return `false` immediately if the cap check fails. 
* Bail if `add_theme_page()` returns `false`
* `wp_check_filetype_and_ext()` doesn't need a 3rd param, it already defaults to `null`. Passing `false` would fail a strict check.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31116 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 21:06:13 +00:00
Scott Taylor
38f87e7c56 After [31016], would be cool if we actually included the froogaloop file to interact with Vimeo. 
Props dimadin.
Fixes #29267.


git-svn-id: https://develop.svn.wordpress.org/trunk@31115 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 20:03:58 +00:00
Boone Gorges
d5c9eb41d7 In get_permalink(), don't resolve to pretty permalink if post has 'future' status. 
We already do this for other non-public statuses, to prevent leaking non-public
information about unpublished posts.

Props e.mazovetskiy, CalEvans.
Fixes #30910.

git-svn-id: https://develop.svn.wordpress.org/trunk@31114 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 16:39:56 +00:00
Sergey Biryukov
68191cc15c Add variable type for sync_category_tag_slugs() parameters. 
props tillkruess.
fixes #30718.

git-svn-id: https://develop.svn.wordpress.org/trunk@31113 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 11:18:22 +00:00
Sergey Biryukov
1710690c99 Avoid a PHP notice in _WP_Editors::wp_fullscreen_html() when no $post global is set. 
props marcochiesi.
fixes #30071.

git-svn-id: https://develop.svn.wordpress.org/trunk@31112 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 10:27:05 +00:00
Sergey Biryukov
1e5ed7fdfd Toolbar: Make network admin accessible via keyboard. 
props Cheffheid.
fixes #29422.

git-svn-id: https://develop.svn.wordpress.org/trunk@31111 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 09:50:39 +00:00
Sergey Biryukov
1c88f482bf Use localized format for Last Updated date in plugin details modal, for consistency with [31055]. 
see #30717.

git-svn-id: https://develop.svn.wordpress.org/trunk@31110 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 06:20:08 +00:00
Sergey Biryukov
b641ca55f5 Improve documentation for media_handle_upload(). 
props ericlewis.
fixes #30962.

git-svn-id: https://develop.svn.wordpress.org/trunk@31109 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 05:04:59 +00:00
Sergey Biryukov
c8f0a49dee Correct @return value for WP_Theme::load_textdomain() after [30681]. 
see #30224.

git-svn-id: https://develop.svn.wordpress.org/trunk@31108 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 04:53:29 +00:00
Gary Pendergast
dec1cba410 Add get_avatar_url(), for retrieving just the URL of an avatar, rather than the entire <img> tag that get_avatar() produces. 
Unlike `get_avatar()`, `get_avatar_url()` is not pluggable. It can be extended/or modified through the new filters included.

Fixes #21195.

Props mdawaffe, pento, pathawks, DrewAPicture



git-svn-id: https://develop.svn.wordpress.org/trunk@31107 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 04:42:48 +00:00
Scott Taylor
0c37f866f2 After [31105], don't ditch the isset() calls for BC. Declare $page_hook as null so it is initialized for all execution paths but will still fail isset() checks. 
Fixes #30958.


git-svn-id: https://develop.svn.wordpress.org/trunk@31106 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 22:51:30 +00:00
Scott Taylor
c4e2ad04a2 Properly declare $hook_suffix, $plugin_page, $typenow, and $taxnow as globals in wp-admin/admin.php. 
Fixes #30958.


git-svn-id: https://develop.svn.wordpress.org/trunk@31105 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 22:14:58 +00:00
Sergey Biryukov
9d67bfe82d If WP_Rewrite::flush_rules() is called on 'init' or earlier, wait until 'wp_loaded' before actually flushing the rules, to make sure all the rules registered on 'init' are included. 
props joostdevalk.
see #30501.

git-svn-id: https://develop.svn.wordpress.org/trunk@31104 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:59:57 +00:00
Sergey Biryukov
c96947757a Remove a redundant inline comment with a typo. 
props nicnicnicdevos.
fixes #30956.

git-svn-id: https://develop.svn.wordpress.org/trunk@31103 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:28:11 +00:00
Sergey Biryukov
6ffb5feab9 Make a hint on Edit Selection view in media modal more accurate, as it applies to all media files, not just images. 
props pavelevap.
see #30931.

git-svn-id: https://develop.svn.wordpress.org/trunk@31102 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:23:21 +00:00
Scott Taylor
85595b73cc Overriding methods should do more than simply call the same method in the super class. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31101 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:19:24 +00:00
Scott Taylor
0522fcb3f9 Jump statements should not be followed by other statements (there were 5 lingering). 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31100 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:14:56 +00:00
Scott Taylor
da9057fd6d Use && instead of and in the 3 places where and was used. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31099 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:11:46 +00:00
Sergey Biryukov
907be55276 Pass post type to count_user_posts() in get_the_author_posts(). 
props Caspie, tyxla.
fixes #30904.

git-svn-id: https://develop.svn.wordpress.org/trunk@31098 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 19:52:52 +00:00
Sergey Biryukov
386d0d5fc7 Remove non-functional date filter from Edit Selection view in media modal. 
props tyxla.
fixes #30931.

git-svn-id: https://develop.svn.wordpress.org/trunk@31096 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 18:22:35 +00:00
Helen Hou-Sandi
854ea3e3e6 Collapse additional avatar settings if avatars are disabled. 
props markjaquith, krogsgard, valendesigns.
 fixes #30168.


git-svn-id: https://develop.svn.wordpress.org/trunk@31095 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 17:00:15 +00:00
Gary Pendergast
ceccfa10b4 WPDB: When sanity checking a string, check that it's a string, first - PHP notices can occur if an array or object is handled like a string. 
See #21212


git-svn-id: https://develop.svn.wordpress.org/trunk@31094 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 08:44:10 +00:00
Gary Pendergast
befcf4f442 WPDB: When wpdb::query() needs to sanity check a query string, make sure to run wpdb:flush() afterwards, to ensure the results from sanity check queries aren't mixed up with the results for the user query. 
See #21212.

Fixes #30948.


git-svn-id: https://develop.svn.wordpress.org/trunk@31093 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 08:31:42 +00:00
Scott Taylor
ddbb6c7a0f In wp_xmlrpc_server, remove dead code. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31092 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 07:20:17 +00:00
Scott Taylor
1ca58614b2 In wp-includes/plugin.php, collapse 3 else-newline-tab-if statements. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31091 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 07:12:42 +00:00
Scott Taylor
6fd11624d1 The keyword elseif should be used instead of else if so that all control keywords look like single words. 
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 07:04:40 +00:00
Dion Hulse
d0767caf54 Enable Pretty Permalinks for new sites during install if the server supports it. 
See #6481, Props valendesigns, DrewAPicture & ericlewis


git-svn-id: https://develop.svn.wordpress.org/trunk@31089 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 06:46:55 +00:00
Scott Taylor
59e6292c0e In wp-includes/taxonomy.php: 
The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31087 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 06:25:40 +00:00
Scott Taylor
8108c0babe PHP keywords and constants "true", "false", "null" should be in lower case - there was one lingering capitalized false in _http_build_query(). 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31086 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 06:13:05 +00:00
Scott Taylor
14c2161a3b There is no need to use the final modifier inside a final class. Everything in it is final by default. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31085 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 06:09:59 +00:00
Scott Taylor
101e00314d In Customizer classes: 
* `public final function` methods should be `final public function` - confusing Hack and aligns with PSR2
* Some methods were missing access modifiers

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31083 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 06:01:08 +00:00
wonderboymusic
1dd301f634 WP_Query->parse_tax_query() - for BC, this method is not marked as protected. See [28987]. It needs an access modifier, it shall have public. The comment remains. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31081 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 05:53:58 +00:00
Scott Taylor
5d6cc49628 Perl-style comments should not be used 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31079 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 05:51:39 +00:00
Scott Taylor
97d6901048 Access Modifiers: 
* In `WP_Plugin_Install_List_Table`, use `public` instead of `var`
* In `WP_User`, `->data` is accessed directly on an instance if the constructor receives it: make it `public`
* In `WP_Locale`, every property is exported to a global and is already `public` via `var`, half of the properties are accessed directly already, make them all `public`
* In `WP_Rewrite`, several properties are accessed publicly in functions via the `$wp_rewrite` global, make those props `public`.
* In `WP_Rewrite`, the property `->comment_feed_structure` was misspelled as `->comments_feed_structure`

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31078 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 05:43:54 +00:00
Scott Taylor
469164785f Pinking Shears. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31077 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 05:02:05 +00:00
Sergey Biryukov
621292d70f In dashboard activity widget, display a front-end link if the user cannot edit the post. 
props UaMV, DrewAPicture.
fixes #29025.

git-svn-id: https://develop.svn.wordpress.org/trunk@31075 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 00:25:26 +00:00
Sergey Biryukov
ca34257bd6 Call the init() method for the upgrader in wp_can_install_language_pack() to avoid undefined index notices. 
props ocean90.
fixes #30827 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31074 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 23:42:48 +00:00
Sergey Biryukov
dd05a3a40f TinyMCE: Remove dashicon-no-alt.png, unused since [30694]. 
props kpdesign, MattyRob.
fixes #30791 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31073 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 23:31:16 +00:00
Sergey Biryukov
37499b6169 Theme install: Display an appropriate string if theme has not been rated yet. 
props kevdotbadger, valendesigns.
fixes #28147.

git-svn-id: https://develop.svn.wordpress.org/trunk@31072 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 23:16:19 +00:00
Sergey Biryukov
22c9a89602 Add context for 'Previous' and 'Next' strings in get_the_posts_pagination(). 
fixes #30762 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31071 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 23:06:20 +00:00
Andrew Ozz
3fdc11be29 Image file editor: fix a wrong error message when restoring an edited image and IMAGE_EDIT_OVERWRITE is set. Props tiqbiz, fixes #30167. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31070 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 22:47:32 +00:00
Sergey Biryukov
bac33e9a17 Customizer: Correctly display "Select" option in Navigation section dropdowns. 
props kucrut.
fixes #30929.

git-svn-id: https://develop.svn.wordpress.org/trunk@31069 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 19:49:17 +00:00
Sergey Biryukov
c99a082e25 Dashicons: Fix typo in .dashicons-excerpt-view class. 
props desrosj.
fixes #30832.

git-svn-id: https://develop.svn.wordpress.org/trunk@31068 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 09:01:58 +00:00
Sergey Biryukov
23bb9030f2 Remove obsolete help sentence on Edit User screen. 
fixes #30750.

git-svn-id: https://develop.svn.wordpress.org/trunk@31067 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 08:22:13 +00:00
Sergey Biryukov
4fdc7c7a0b Don't force newlines around URLs in WP_Embed::autoembed(). 
props chipx86, sgrant.
fixes #23776.

git-svn-id: https://develop.svn.wordpress.org/trunk@31066 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 07:50:58 +00:00
Gary Pendergast
d3d11c704d Options: When updating options, make sure the user isn't trying to insert characters that aren't supported by the database character set. 
See #30361.


git-svn-id: https://develop.svn.wordpress.org/trunk@31064 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 04:14:32 +00:00
Drew Jaynes (DrewAPicture)
af680788bc Add a description for the $data parameter in the DocBlock for the customize_save_response hook introduced in [31062]. 
Props westonruter.
Fixes #29098.


git-svn-id: https://develop.svn.wordpress.org/trunk@31063 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 01:47:17 +00:00
Dominik Schilling (ocean90)
8bf3003c67 Customizer: Send JSON success for customize_save and allow response to be filtered. 
props westonruter.
fixes #29098.

git-svn-id: https://develop.svn.wordpress.org/trunk@31062 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-06 21:46:54 +00:00
Dominik Schilling (ocean90)
afb8352a70 Autoprefixer for [31038]. 
see #30886.

git-svn-id: https://develop.svn.wordpress.org/trunk@31061 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-06 21:43:35 +00:00
Sergey Biryukov
76afa9f9a3 Remove space before comma in wp_notify_postauthor() and wp_notify_moderator(). 
see #30930.

git-svn-id: https://develop.svn.wordpress.org/trunk@31060 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-06 17:16:17 +00:00
Sergey Biryukov
ca4df7ec0a Remove padding from the comment notification emails in wp_notify_moderator(). 
See [30015] for wp_notify_postauthor().

props pavelevap.
fixes #30930.

git-svn-id: https://develop.svn.wordpress.org/trunk@31059 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-06 17:09:13 +00:00
Sergey Biryukov
3274f5fee6 Skip building the query in wp_count_posts() if cached results are used. 
props MikeHansenMe.
fixes #30928.

git-svn-id: https://develop.svn.wordpress.org/trunk@31058 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-06 16:57:12 +00:00
Sergey Biryukov
4b29e64a4d Fix 'compare' parameter description in WP_Date_Query. 
props dlh.
fixes #30925.

git-svn-id: https://develop.svn.wordpress.org/trunk@31057 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-06 03:35:56 +00:00
Sergey Biryukov
0d32524409 Remove obsolete inline comment. 
props travisnorthcutt.
fixes #30924.

git-svn-id: https://develop.svn.wordpress.org/trunk@31056 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-06 01:56:07 +00:00
Sergey Biryukov
8e9b9bc458 Use localized format for Last Updated date on Add Plugins screen. 
props tyxla.
fixes #30717.

git-svn-id: https://develop.svn.wordpress.org/trunk@31055 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-06 01:02:21 +00:00