sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
28,936 Commits 2 Branches 473 Tags 137 MiB
73a85825fb
Commit Graph

5580 Commits

Author SHA1 Message Date
Scott Taylor
243d50d2f7 After [31146], properly declare $user_can as a private field in WP_Comments_List_Table. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31161 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 16:01:53 +00:00
Dion Hulse
32b020bf05 More concise documentation for wp_install_maybe_enable_pretty_permalinks() 
See #6481. Props ericlewis.


git-svn-id: https://develop.svn.wordpress.org/trunk@31160 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 04:32:35 +00:00
Dion Hulse
0aaa2f0f32 The new wp_install_maybe_enable_pretty_permalinks() function doesn't need to be pluggable. 
See #6481. Props nacin, valendesigns


git-svn-id: https://develop.svn.wordpress.org/trunk@31159 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 04:30:01 +00:00
Jeremy Felt
0eb9f7e414 Use a less complex approach for enforcing path slashes in update_blog_details() 
Ensure leading and traling slashes are in place and don't touch anything in the middle. Validating with `array_filter()` would have missed a possible valid falsy path - `/my-path/0/`.

Props nacin.

Fixes #18117.


git-svn-id: https://develop.svn.wordpress.org/trunk@31158 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 04:20:47 +00:00
Jeremy Felt
d759c0ef23 Check for existence of data from get_blogaddress_by_id() before returning a URL 
* Prevent a notice when an invalid ID is used with `get_blogaddres_by_id()`.
* Return a falsy empty string rather than the previous "http://".
* Add unit tests for `get_blogaddress_by_id()`.

Props nerrad.

Fixes #30566.


git-svn-id: https://develop.svn.wordpress.org/trunk@31157 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 02:23:43 +00:00
Jeremy Felt
331262b544 Update home and siteurl after path slashes are validated in update_blog_details() 
When editing a site, if `home` and `siteurl` are checked to be updated along with a site's domain and path, they should receive the results of any modifications in `update_blog_details()` rather than trusting the POST data.

Previously, it was possible to save a value without a leading slash on the path, causing an invalid URL to be stored.

Props earnjam.

Fixes #30417.


git-svn-id: https://develop.svn.wordpress.org/trunk@31156 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 01:56:04 +00:00
Jeremy Felt
f9e9287875 Enforce leading and trailing slashes on paths updated with update_blog_details() 
In multisite, core expects the stored value for a site's path to have leading and trailing slashes. When these slashes are missing, it becomes impossible to visit the site.

This enforces proper `/path/` creation in `update_blog_details()`, most likely used when updating an existing site through `site-info.php`.

Props earnjam, simonwheatley.

Fixes #18117. Fixes #23865.


git-svn-id: https://develop.svn.wordpress.org/trunk@31155 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 01:42:46 +00:00
Gary Pendergast
0b993ffe35 If get_avatar_data() is passed an empty value for the default avatar, we should be using the site's avatar_default option instead. 
See #21195


git-svn-id: https://develop.svn.wordpress.org/trunk@31154 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 00:22:12 +00:00
Gary Pendergast
69f8b26d89 In get_avatar_data(), there's no need to return false if we couldn't find an avatar, as Gravatar can handle being given an empty email hash. This allows the default avatar to show when no email address is given. 
See #21195



git-svn-id: https://develop.svn.wordpress.org/trunk@31153 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 00:19:34 +00:00
Gary Pendergast
d0fab598e7 In get_avatar(), revert the <img> tag attributes to using single quotes, instead of double quotes. This behaviour was changed in [31107], but caused problems for code that attempted to parse the <img> tag. 
See #21195



git-svn-id: https://develop.svn.wordpress.org/trunk@31152 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 00:02:31 +00:00
Scott Taylor
156a673660 In WP_Query, only call magic method internals again whitelists of properties and methods, $compat_fields and $compat_methods. Remove __unset() since __set() is not implemented. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31151 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 22:40:53 +00:00
Scott Taylor
1178e8a6e1 In WP_Comment_Query, only allow __call() to run against ->get_search_sql(). 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31150 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 22:32:44 +00:00
Scott Taylor
f6d7c5e52f In wp_xmlrpc_server, only allow __call() to run against ->_multisite_getUsersBlogs(). 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31149 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 22:30:26 +00:00
Scott Taylor
cd3fde69bb In WP_oEmbed, only allow __call() to run against a whitelist of methods, $compat_methods. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31148 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 22:26:55 +00:00
Scott Taylor
5b6858eff8 In WP_Roles, only allow __call() to run against ->_init(). 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31147 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 22:23:00 +00:00
Scott Taylor
274253629f In WP_List_Table, only call magic method internals again whitelists of properties and methods, $compat_fields and $compat_methods. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31146 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 22:19:58 +00:00
Scott Taylor
ad6dd738b2 In WP_Filesystem_Base, make the only private member, $cache, public and remove magic methods. $cache was always public until [28487], has been essentially public via a magic method since. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31145 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 22:03:59 +00:00
Scott Taylor
bbc7ca2d0d In WP_User_Query, only call magic method internals against a whitelist of properties, $compat_fields. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31144 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 21:59:54 +00:00
Andrew Ozz
43b2de66c6 TinyMCE wpView: when clicking in the editor optimize the caret placement before or after a view. Props avryl, fixes #30938. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31143 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 20:41:36 +00:00
Andrew Ozz
5a29757b92 TinyMCE: fix (switch) the indent/outdent icons in RTL mode so the arrow points at the proper direction. Props avryl, fixes #21281. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31142 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 20:29:56 +00:00
Boone Gorges
29d06de35d Walker::$has_children should be public for backward compatibility. 
See [31137]. See #30891.

git-svn-id: https://develop.svn.wordpress.org/trunk@31141 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 01:55:34 +00:00
Boone Gorges
77128eb048 Default $parent in category_exists() should default to null rather than 0. 
[29863] made the corresponding change in `term_exists()`. Failure to change the
default value in `category_exists()` meant that an unspecified value for
`$parent` would limit results to top-level categories.

Includes unit tests and corrected function documentation.

Props hissy.
Fixes #30975 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31140 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 01:25:19 +00:00
Scott Taylor
f323dc9b48 WP_Ajax_Response has one property only, $responses. It was public until [28508], when it became private in name only. Is it worth 4 magic methods to pretend that this property is private? It is not. 
Make it `public` and remove the magic methods.

See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31139 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 00:12:47 +00:00
Scott Taylor
ad81bf20db In WP_Error: 
* `wp_send_json_error()` accesses `$errors` on an instance, it must be `public`
* `$error_data` is a local message cache for error codes and doesn't particularly hide info, would be the only non-public field or method in the class

Make `$errors` and `$error_data` public and remove magic methods.

See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31138 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-11 00:00:05 +00:00
Scott Taylor
406b174a55 In Walker: 
* Every subclass of `Walker` overrides `$db_fields` and makes it public
* `wp_list_comments()` accesses `->max_pages` on an instance of `Walker`, it must be public
* `$has_children` was added as `protected` in 4.0. doesn't need BC

Make `$db_fields` and `$max_pages` public and remove magic methods.

See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31137 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 23:43:43 +00:00
Scott Taylor
14555b3af2 In WP_MatchesMapRegex: 
* Exactly one method was made private in [28516], and is only used internally.
* 2 properties were made private, but they just store variables passed to the constructor.
* Instances of this class are never created in core. `WP_MatchesMapRegex::apply()` is called statically in `WP->parse_request()` and `url_to_postid()`. 

The chances that: 
1) this class is used as an instance somewhere and 
2) the properties that have always been marked `@access private` and begin with `_` were used publicly

...is extremely low.

Remove the magic methods, I should not have added them.

While we're at it, use the PHP5-style `__construct()` instead of the class name.

See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31136 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 23:27:00 +00:00
Scott Taylor
f90b923777 In WP_Text_Diff_Renderer_Table: 
* In [28525], `$_diff_threshold`, `$inline_diff_renderer`, and `$_show_split_view` were marked `protected`; magic methods were also added.
* The magic methods should only perform operations on a whitelisted set of properties, now specified in `$compat_fields`
* Remove `__call()`, is unnecessary and can wreak havoc on the parent class.

This class is used in one place: `wp_text_diff()`.

See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31135 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 22:57:17 +00:00
wonderboymusic
cdb5c75ab2 In Custom_Image_Header: 
* In [28481], `$admin_header_callback` and `$admin_image_div_callback` were set to `private` based on their erroneous `@param` values
* `$admin_header_callback` and `$admin_image_div_callback` are used as hook callbacks - as such, they must be `public`
* In [28521] and [28524], magic methods were added for back-compat
* Currently, there are 4 properties marked `private`: `$uploaded_headers`, `$default_headers`, `$page`, and `$updated` - `$page` and `$uploaded_headers` are never used and `$updated` was added by me in [30187] during 4.1. `$default_headers` does not necessarily need to be `private`

Set `$admin_header_callback` and `$admin_image_div_callback` to `public`.
Remove the `$page` property - it duplicated the `$page` local var and is referenced/used nowhere.
Remove the `$uploaded_headers` property - it is used nowhere and is dead code.
Set `$default_headers` to `public`.
Remove the magic methods - they were beyond overkill and rendered moot by the above changes.

See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31134 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 22:10:02 +00:00
Scott Taylor
b23a9d9dff In Custom_Background: 
* In [28481], `$admin_header_callback` and `$admin_image_div_callback` were set to `private` based on their erroneous `@param` value
* `$admin_header_callback` and `$admin_image_div_callback` are used as hook callbacks - as such, they must be `public`
* In [28521] and [28524], magic methods were added for back-compat
* Currently, there are 2 properties marked `private`, `$page` and `$updated` - `$page` is never used and `$updated` was added by me in [30186] during 4.1

Set `$admin_header_callback` and `$admin_image_div_callback` to `public`.
Remove the `$page` property - it duplicated the `$page` local var and is referenced/used nowhere.
Remove the magic methods - they were beyond overkill and rendered moot by the above changes.

See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31133 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 21:58:19 +00:00
Scott Taylor
a8cf928200 get_post() takes $output as its 2nd param. The @return annotation should reflect the function's ability to return an array. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31132 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 21:37:23 +00:00
Scott Taylor
358b309da9 In edit-form-advanced.php: 
* `get_permalink( $post_ID )` can return `false`, set it to a variable and check it
* Using the variable allows us to replace 11 separate calls to `get_permalink( $post_ID )` in the file
* These notices were triggered by the potential for `false` to be passed to `esc_url()`

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31131 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 21:20:01 +00:00
Scott Taylor
d4c4205f31 get_header_image() can return false. In Custom_Image_Header->step_1(), check the value before setting the background-image portion of the style attribute. Setting the the URL to empty string will cause the current request to be set as the source of the background image. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31130 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 21:07:54 +00:00
Scott Taylor
0f54cc95b3 Since get_theme_mod() returns false on failure, $background_image_thumb can be set to it and checked instead of calling get_background_image() 3 times in Custom_Background->admin_page(). 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31129 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 20:43:12 +00:00
Scott Taylor
061daaa7ee Declare $action as a global in wp-admin/comment.php. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31128 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 20:41:04 +00:00
Scott Taylor
979ba60a57 Fix some @param docs that have chars too close them. 
Add `@property` annotations to `WP_User` and `WP_Post`.
Remove erroneous `@param`s from image editor class methods.
Officially add the property `$_column_headers` to `WP_List_Table`.	

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31127 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 06:56:51 +00:00
Scott Taylor
349e5cb318 Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Constructors do not have meaningful return values, anything that is returned from here is discarded. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31126 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 06:53:48 +00:00
Scott Taylor
cb85e15f06 Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value - anything that is returned is discarded. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31125 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 06:12:25 +00:00
Scott Taylor
bc723548a7 Declare $wp_version, $required_php_version, and $required_mysql_version as globals in install and upgrade admin files. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31124 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 05:56:45 +00:00
Scott Taylor
38e18d800c In wp-admin/includes/revision.php, $post->modified is a coding error. It should be $post->post_modified. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31123 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 05:49:24 +00:00
Scott Taylor
164b4f21c9 WP_Upgrader will take any "skin" that is passed to it, and set ->skin via composition. The default type of ->skin is WP_Upgrader_Skin, which doesn't have methods declared for ->bulk_header() and ->bulk_footer(). Add noop methods to WP_Upgrader_Skin. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31122 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 05:41:05 +00:00
Scott Taylor
77cffd8edf Admin globals: 
* Declare `$wp_importers` as a global in `admin.php`
* Declare `$post_type`, `$post_type_object`, and  `$post` as globals where applicable

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31121 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 05:28:46 +00:00
Scott Taylor
c3bd2252f5 Use PHP_SAPI constant instead of php_sapi_name() in iis7_supports_permalinks(), wp_fix_server_vars(), and wp_redirect(). 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31120 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 04:58:49 +00:00
Scott Taylor
44a3c002f5 In wp_ajax_upload_attachment(), wp_check_filetype_and_ext() doesn't need a 3rd param - it already defaults to null. Passing false would fail a strict check 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31119 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 04:54:13 +00:00
Andrew Ozz
23d6e28390 TinyMCE editor-expand: when kitchensink is off hide the statusbar on loading, and when the editor is shorter then the viewport. Props avryl, fixes #30961. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31118 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-10 01:32:00 +00:00
Andrew Ozz
47cfdb5ced Media modal: do not attempt to focus the hidden file input field added by Plupload when tabbing. Props afercia, fixes #30392. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31117 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 21:46:03 +00:00
Scott Taylor
b3322a9604 In Custom_Background and Custom_Header: 
* In `->init()`, don't check `current_user_can()` since `add_theme_page()` will return `false` immediately if the cap check fails. 
* Bail if `add_theme_page()` returns `false`
* `wp_check_filetype_and_ext()` doesn't need a 3rd param, it already defaults to `null`. Passing `false` would fail a strict check.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31116 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 21:06:13 +00:00
Scott Taylor
38f87e7c56 After [31016], would be cool if we actually included the froogaloop file to interact with Vimeo. 
Props dimadin.
Fixes #29267.


git-svn-id: https://develop.svn.wordpress.org/trunk@31115 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 20:03:58 +00:00
Boone Gorges
d5c9eb41d7 In get_permalink(), don't resolve to pretty permalink if post has 'future' status. 
We already do this for other non-public statuses, to prevent leaking non-public
information about unpublished posts.

Props e.mazovetskiy, CalEvans.
Fixes #30910.

git-svn-id: https://develop.svn.wordpress.org/trunk@31114 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 16:39:56 +00:00
Sergey Biryukov
68191cc15c Add variable type for sync_category_tag_slugs() parameters. 
props tillkruess.
fixes #30718.

git-svn-id: https://develop.svn.wordpress.org/trunk@31113 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 11:18:22 +00:00
Sergey Biryukov
1710690c99 Avoid a PHP notice in _WP_Editors::wp_fullscreen_html() when no $post global is set. 
props marcochiesi.
fixes #30071.

git-svn-id: https://develop.svn.wordpress.org/trunk@31112 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 10:27:05 +00:00
Sergey Biryukov
1e5ed7fdfd Toolbar: Make network admin accessible via keyboard. 
props Cheffheid.
fixes #29422.

git-svn-id: https://develop.svn.wordpress.org/trunk@31111 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 09:50:39 +00:00
Sergey Biryukov
1c88f482bf Use localized format for Last Updated date in plugin details modal, for consistency with [31055]. 
see #30717.

git-svn-id: https://develop.svn.wordpress.org/trunk@31110 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 06:20:08 +00:00
Sergey Biryukov
b641ca55f5 Improve documentation for media_handle_upload(). 
props ericlewis.
fixes #30962.

git-svn-id: https://develop.svn.wordpress.org/trunk@31109 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 05:04:59 +00:00
Sergey Biryukov
c8f0a49dee Correct @return value for WP_Theme::load_textdomain() after [30681]. 
see #30224.

git-svn-id: https://develop.svn.wordpress.org/trunk@31108 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 04:53:29 +00:00
Gary Pendergast
dec1cba410 Add get_avatar_url(), for retrieving just the URL of an avatar, rather than the entire <img> tag that get_avatar() produces. 
Unlike `get_avatar()`, `get_avatar_url()` is not pluggable. It can be extended/or modified through the new filters included.

Fixes #21195.

Props mdawaffe, pento, pathawks, DrewAPicture



git-svn-id: https://develop.svn.wordpress.org/trunk@31107 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 04:42:48 +00:00
Scott Taylor
0c37f866f2 After [31105], don't ditch the isset() calls for BC. Declare $page_hook as null so it is initialized for all execution paths but will still fail isset() checks. 
Fixes #30958.


git-svn-id: https://develop.svn.wordpress.org/trunk@31106 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 22:51:30 +00:00
Scott Taylor
c4e2ad04a2 Properly declare $hook_suffix, $plugin_page, $typenow, and $taxnow as globals in wp-admin/admin.php. 
Fixes #30958.


git-svn-id: https://develop.svn.wordpress.org/trunk@31105 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 22:14:58 +00:00
Sergey Biryukov
9d67bfe82d If WP_Rewrite::flush_rules() is called on 'init' or earlier, wait until 'wp_loaded' before actually flushing the rules, to make sure all the rules registered on 'init' are included. 
props joostdevalk.
see #30501.

git-svn-id: https://develop.svn.wordpress.org/trunk@31104 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:59:57 +00:00
Sergey Biryukov
c96947757a Remove a redundant inline comment with a typo. 
props nicnicnicdevos.
fixes #30956.

git-svn-id: https://develop.svn.wordpress.org/trunk@31103 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:28:11 +00:00
Sergey Biryukov
6ffb5feab9 Make a hint on Edit Selection view in media modal more accurate, as it applies to all media files, not just images. 
props pavelevap.
see #30931.

git-svn-id: https://develop.svn.wordpress.org/trunk@31102 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:23:21 +00:00
Scott Taylor
85595b73cc Overriding methods should do more than simply call the same method in the super class. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31101 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:19:24 +00:00
Scott Taylor
0522fcb3f9 Jump statements should not be followed by other statements (there were 5 lingering). 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31100 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:14:56 +00:00
Scott Taylor
da9057fd6d Use && instead of and in the 3 places where and was used. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31099 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 21:11:46 +00:00
Sergey Biryukov
907be55276 Pass post type to count_user_posts() in get_the_author_posts(). 
props Caspie, tyxla.
fixes #30904.

git-svn-id: https://develop.svn.wordpress.org/trunk@31098 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 19:52:52 +00:00
Sergey Biryukov
386d0d5fc7 Remove non-functional date filter from Edit Selection view in media modal. 
props tyxla.
fixes #30931.

git-svn-id: https://develop.svn.wordpress.org/trunk@31096 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 18:22:35 +00:00
Helen Hou-Sandi
854ea3e3e6 Collapse additional avatar settings if avatars are disabled. 
props markjaquith, krogsgard, valendesigns.
 fixes #30168.


git-svn-id: https://develop.svn.wordpress.org/trunk@31095 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 17:00:15 +00:00
Gary Pendergast
ceccfa10b4 WPDB: When sanity checking a string, check that it's a string, first - PHP notices can occur if an array or object is handled like a string. 
See #21212


git-svn-id: https://develop.svn.wordpress.org/trunk@31094 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 08:44:10 +00:00
Gary Pendergast
befcf4f442 WPDB: When wpdb::query() needs to sanity check a query string, make sure to run wpdb:flush() afterwards, to ensure the results from sanity check queries aren't mixed up with the results for the user query. 
See #21212.

Fixes #30948.


git-svn-id: https://develop.svn.wordpress.org/trunk@31093 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 08:31:42 +00:00
Scott Taylor
ddbb6c7a0f In wp_xmlrpc_server, remove dead code. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31092 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 07:20:17 +00:00
Scott Taylor
1ca58614b2 In wp-includes/plugin.php, collapse 3 else-newline-tab-if statements. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31091 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 07:12:42 +00:00
Scott Taylor
6fd11624d1 The keyword elseif should be used instead of else if so that all control keywords look like single words. 
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 07:04:40 +00:00
Dion Hulse
d0767caf54 Enable Pretty Permalinks for new sites during install if the server supports it. 
See #6481, Props valendesigns, DrewAPicture & ericlewis


git-svn-id: https://develop.svn.wordpress.org/trunk@31089 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 06:46:55 +00:00
Scott Taylor
59e6292c0e In wp-includes/taxonomy.php: 
The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31087 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 06:25:40 +00:00
Scott Taylor
8108c0babe PHP keywords and constants "true", "false", "null" should be in lower case - there was one lingering capitalized false in _http_build_query(). 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31086 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 06:13:05 +00:00
Scott Taylor
14c2161a3b There is no need to use the final modifier inside a final class. Everything in it is final by default. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31085 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 06:09:59 +00:00
Scott Taylor
101e00314d In Customizer classes: 
* `public final function` methods should be `final public function` - confusing Hack and aligns with PSR2
* Some methods were missing access modifiers

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31083 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 06:01:08 +00:00
wonderboymusic
1dd301f634 WP_Query->parse_tax_query() - for BC, this method is not marked as protected. See [28987]. It needs an access modifier, it shall have public. The comment remains. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31081 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 05:53:58 +00:00
Scott Taylor
5d6cc49628 Perl-style comments should not be used 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31079 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 05:51:39 +00:00
Scott Taylor
97d6901048 Access Modifiers: 
* In `WP_Plugin_Install_List_Table`, use `public` instead of `var`
* In `WP_User`, `->data` is accessed directly on an instance if the constructor receives it: make it `public`
* In `WP_Locale`, every property is exported to a global and is already `public` via `var`, half of the properties are accessed directly already, make them all `public`
* In `WP_Rewrite`, several properties are accessed publicly in functions via the `$wp_rewrite` global, make those props `public`.
* In `WP_Rewrite`, the property `->comment_feed_structure` was misspelled as `->comments_feed_structure`

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31078 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 05:43:54 +00:00
Scott Taylor
469164785f Pinking Shears. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31077 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 05:02:05 +00:00
Sergey Biryukov
621292d70f In dashboard activity widget, display a front-end link if the user cannot edit the post. 
props UaMV, DrewAPicture.
fixes #29025.

git-svn-id: https://develop.svn.wordpress.org/trunk@31075 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 00:25:26 +00:00
Sergey Biryukov
ca34257bd6 Call the init() method for the upgrader in wp_can_install_language_pack() to avoid undefined index notices. 
props ocean90.
fixes #30827 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31074 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 23:42:48 +00:00
Sergey Biryukov
dd05a3a40f TinyMCE: Remove dashicon-no-alt.png, unused since [30694]. 
props kpdesign, MattyRob.
fixes #30791 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31073 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 23:31:16 +00:00
Sergey Biryukov
37499b6169 Theme install: Display an appropriate string if theme has not been rated yet. 
props kevdotbadger, valendesigns.
fixes #28147.

git-svn-id: https://develop.svn.wordpress.org/trunk@31072 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 23:16:19 +00:00
Sergey Biryukov
22c9a89602 Add context for 'Previous' and 'Next' strings in get_the_posts_pagination(). 
fixes #30762 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@31071 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 23:06:20 +00:00
Andrew Ozz
3fdc11be29 Image file editor: fix a wrong error message when restoring an edited image and IMAGE_EDIT_OVERWRITE is set. Props tiqbiz, fixes #30167. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31070 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 22:47:32 +00:00
Sergey Biryukov
bac33e9a17 Customizer: Correctly display "Select" option in Navigation section dropdowns. 
props kucrut.
fixes #30929.

git-svn-id: https://develop.svn.wordpress.org/trunk@31069 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 19:49:17 +00:00
Sergey Biryukov
c99a082e25 Dashicons: Fix typo in .dashicons-excerpt-view class. 
props desrosj.
fixes #30832.

git-svn-id: https://develop.svn.wordpress.org/trunk@31068 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 09:01:58 +00:00
Sergey Biryukov
23bb9030f2 Remove obsolete help sentence on Edit User screen. 
fixes #30750.

git-svn-id: https://develop.svn.wordpress.org/trunk@31067 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 08:22:13 +00:00
Sergey Biryukov
4fdc7c7a0b Don't force newlines around URLs in WP_Embed::autoembed(). 
props chipx86, sgrant.
fixes #23776.

git-svn-id: https://develop.svn.wordpress.org/trunk@31066 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 07:50:58 +00:00
Gary Pendergast
d3d11c704d Options: When updating options, make sure the user isn't trying to insert characters that aren't supported by the database character set. 
See #30361.


git-svn-id: https://develop.svn.wordpress.org/trunk@31064 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 04:14:32 +00:00
Drew Jaynes (DrewAPicture)
af680788bc Add a description for the $data parameter in the DocBlock for the customize_save_response hook introduced in [31062]. 
Props westonruter.
Fixes #29098.


git-svn-id: https://develop.svn.wordpress.org/trunk@31063 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-07 01:47:17 +00:00
Dominik Schilling (ocean90)
8bf3003c67 Customizer: Send JSON success for customize_save and allow response to be filtered. 
props westonruter.
fixes #29098.

git-svn-id: https://develop.svn.wordpress.org/trunk@31062 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-06 21:46:54 +00:00
Dominik Schilling (ocean90)
afb8352a70 Autoprefixer for [31038]. 
see #30886.

git-svn-id: https://develop.svn.wordpress.org/trunk@31061 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-06 21:43:35 +00:00
Sergey Biryukov
76afa9f9a3 Remove space before comma in wp_notify_postauthor() and wp_notify_moderator(). 
see #30930.

git-svn-id: https://develop.svn.wordpress.org/trunk@31060 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-06 17:16:17 +00:00
Sergey Biryukov
ca4df7ec0a Remove padding from the comment notification emails in wp_notify_moderator(). 
See [30015] for wp_notify_postauthor().

props pavelevap.
fixes #30930.

git-svn-id: https://develop.svn.wordpress.org/trunk@31059 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-06 17:09:13 +00:00
Sergey Biryukov
3274f5fee6 Skip building the query in wp_count_posts() if cached results are used. 
props MikeHansenMe.
fixes #30928.

git-svn-id: https://develop.svn.wordpress.org/trunk@31058 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-06 16:57:12 +00:00
Sergey Biryukov
4b29e64a4d Fix 'compare' parameter description in WP_Date_Query. 
props dlh.
fixes #30925.

git-svn-id: https://develop.svn.wordpress.org/trunk@31057 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-06 03:35:56 +00:00
Sergey Biryukov
0d32524409 Remove obsolete inline comment. 
props travisnorthcutt.
fixes #30924.

git-svn-id: https://develop.svn.wordpress.org/trunk@31056 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-06 01:56:07 +00:00
Sergey Biryukov
8e9b9bc458 Use localized format for Last Updated date on Add Plugins screen. 
props tyxla.
fixes #30717.

git-svn-id: https://develop.svn.wordpress.org/trunk@31055 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-06 01:02:21 +00:00
Sergey Biryukov
d33e517bb9 Themes: Fix position of admin notice with .notice class. 
fixes #30895.

git-svn-id: https://develop.svn.wordpress.org/trunk@31054 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-05 20:05:19 +00:00
Sergey Biryukov
7d7b33ff49 Pass comment author name and comment ID to 'get_comment_author_link' filter on Edit Comment screen, for consistency with [30092]. 
props tyxla.
fixes #30894.

git-svn-id: https://develop.svn.wordpress.org/trunk@31053 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-05 19:09:36 +00:00
Gary Pendergast
eb4d356e29 size_format() incorrectly included a trailing space for B values: less than 1024 bytes. 
Also add a unit test to check for this, so we don't do it again.

Fixes #30908.

Props tillkruess.
 


git-svn-id: https://develop.svn.wordpress.org/trunk@31052 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-05 13:12:06 +00:00
Gary Pendergast
aada083f3c WPDB: To ensure we're not asking MySQL to read data using queries that it can't handle, make sure that we run all read queries through the character set sanity checks. 
See #21212.



git-svn-id: https://develop.svn.wordpress.org/trunk@31051 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-05 04:39:26 +00:00
Gary Pendergast
ea660736eb WPDB Docs: Update the @since version from 4.1.0 to 4.2.0, for all the methods/members that were punted from 4.1. 
See #21212.



git-svn-id: https://develop.svn.wordpress.org/trunk@31050 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-05 03:50:14 +00:00
Dion Hulse
8cce0f1607 Preinitialize WP_User::$data to an object in the event an empty user object is created. Avoids a "Creating default object from empty value" PHP Warning. 
Fixes #28019


git-svn-id: https://develop.svn.wordpress.org/trunk@31049 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-05 01:40:43 +00:00
Sergey Biryukov
44c0c4a9cd A couple more tweaks to the post-thumbnail-template.php description. 
see #30867.

git-svn-id: https://develop.svn.wordpress.org/trunk@31048 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-04 23:09:53 +00:00
Scott Taylor
2003fcae83 In Media Views, use this.listenTo( this.model, .... ) instead of this.model.on( .... ) to fix garbage collection and to avoid "ghost views." 
Fixes #30896.


git-svn-id: https://develop.svn.wordpress.org/trunk@31045 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-04 05:24:24 +00:00
Scott Taylor
49d19a367a ImageMagick expects TIFF files to have .tiff as an extension, so the key in wp_get_mime_types() should be 'tiff|tif' not 'tif|tiff' so the proper extension is returned in WP_Image_Editor->get_extension() subclass invocations. 
Fixes #30211.


git-svn-id: https://develop.svn.wordpress.org/trunk@31044 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-04 03:08:48 +00:00
Scott Taylor
14ddc6c9c0 If IMAGE_EDIT_OVERWRITE is defined as true, ensure that multiple edits to the same image does not result in the file being deleted (updating the meta fails because the old and new paths are identical). 
Props hew.
Fixes #30394.


git-svn-id: https://develop.svn.wordpress.org/trunk@31043 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-04 02:51:20 +00:00
Scott Taylor
621e909a9b Improve the handling of comma-separated mime-types in wp_match_mime_types(), particularly as pertains to the mime-type selector on the Media list table screen. 
Props mdgl.
Fixes #30788.


git-svn-id: https://develop.svn.wordpress.org/trunk@31042 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-04 02:31:29 +00:00
Scott Taylor
efc61d054e After [31037], ensure that the library is passed as a map to the Media Grid instance. Remove useless query vars. 
Fixes #30584.


git-svn-id: https://develop.svn.wordpress.org/trunk@31041 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-04 02:06:04 +00:00
Scott Taylor
3d3e1fb72a Preserve alpha transparency when rotating a PNG while GD is the active image editor. 
Adds unit tests.

Props frankpw, voldemortensen.
Fixes #30596.


git-svn-id: https://develop.svn.wordpress.org/trunk@31040 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 22:01:54 +00:00
Scott Taylor
6d858cc6e2 In Media Grid, don't immediately load full size images if the requested size passed to wp.media.view.Attachment.imageSize() does not exist, look for other suitable sizes. 
Fixes #30861.


git-svn-id: https://develop.svn.wordpress.org/trunk@31039 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 21:31:23 +00:00
Scott Taylor
3fe38d959a Fix spacing of .compat-item .field form widgets in media modal. 
Props trepmal.
Fixes #30886.


git-svn-id: https://develop.svn.wordpress.org/trunk@31038 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 20:46:16 +00:00
Scott Taylor
5df9963414 Respect query vars for taxonomies passed as URL parameters when in grid mode of Media Library. 
Fixes #30584.


git-svn-id: https://develop.svn.wordpress.org/trunk@31037 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 08:23:06 +00:00
Scott Taylor
fdef2cc755 Remove whitespace side effects from comment_form(). 
Props timersys.
Fixes #30500.


git-svn-id: https://develop.svn.wordpress.org/trunk@31036 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 06:26:38 +00:00
Scott Taylor
ca8fe1a7a4 Use the 'not_found' label when there are no items for a taxonomy in the terms list table. 
Props SergeyBiryukov.
Fixes #30586.


git-svn-id: https://develop.svn.wordpress.org/trunk@31035 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 06:19:46 +00:00
Scott Taylor
47f2c42528 Inline <script>s that are only printed in the admin for pages that are served with the HTML5 doctype absolutely do not need CDATA comments. 
Props tw2113 for the initial patch.
See #18788.


git-svn-id: https://develop.svn.wordpress.org/trunk@31034 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 05:45:17 +00:00
Scott Taylor
5db95f22d0 After [31030]: if a callable is passed as the 3rd arg to wp_localize_script()/WP_Scripts->localize(), pass $handle and $object_name to the user func when invoking it. 
Props jtsternberg.
Fixes #26111.


git-svn-id: https://develop.svn.wordpress.org/trunk@31033 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 05:12:56 +00:00
Scott Taylor
c21e4f95ce Add the ability to print data *after* a script, whether it is concatenated or not: 
* Add a third argument to `WP_Scripts->print_extra_script()`, `$key`, which will be passed to `->get_data()` (no longer passes hardcoded `'data'`)
* When `$key` is set to `'data-after'`, the inline script will be printed after the `<script>` tag. If the scripts are being concatenated, all scripts' `'data-after'` data will be printed after the concatenated `<script>` has been rendered.

Props hakre, wonderboymusic.
Fixes #25277.


git-svn-id: https://develop.svn.wordpress.org/trunk@31032 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 05:07:15 +00:00
Scott Taylor
d699ce8b13 Ensure that inline styles attached to conditional stylesheets are also conditional. 
Adds unit test.

Props georgestephanis.
Fixes #29180.


git-svn-id: https://develop.svn.wordpress.org/trunk@31031 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 04:09:12 +00:00
Scott Taylor
c69dbc8b5a Allow the 3rd argument to wp_localize_script()/WP_Scripts->localize() to be a callable, allowing data to be lazy-loaded when the script is actually enqueued. 
Props jtsternberg.
Fixes #26111.


git-svn-id: https://develop.svn.wordpress.org/trunk@31030 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 03:53:30 +00:00
Scott Taylor
d5328fc674 When outputting JS with a Content-Type header: 
`text/javascript` is obsolete, `application/x-javascript` was experimental. `application/javascript` is the recommended type per RFC 4329.

Props sergej.mueller.
Fixes #29196.


git-svn-id: https://develop.svn.wordpress.org/trunk@31029 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 02:56:14 +00:00
Scott Taylor
8476a2e2fa When calling wp_enqueue_script() with a registered $handle, no $src (using the default value, false), and true as the value for $in_footer, ensure that the script actually loads in the footer. If the handle was registered with $in_footer equal to true, this already worked. Make it work for scripts like where $in_footer was initially false, example: wp_enqueue_script( 'json2', false, array(), false, true ); 
Props SergeyBiryukov.
Fixes #14488.


git-svn-id: https://develop.svn.wordpress.org/trunk@31028 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 02:40:11 +00:00
Boone Gorges
8d990ce6f8 Introduce 'category_css_classes' filter. 
Paralleling the 'page_css_classes' filter, this allows developers to modify
the list of CSS classes used when creating category list markup via
`Walker_Category`.

Props sivel.
Fixes #16497.

git-svn-id: https://develop.svn.wordpress.org/trunk@31027 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 02:30:14 +00:00
Boone Gorges
fd8b7faff6 In Walker_Category, don't generate list elements for empty cat names. 
This change allows the 'list_cats' filter to be used to suppress certain
items in category lists, without creating invalid or superfluous markup.

Props samo9789.
Fixes #16792.

git-svn-id: https://develop.svn.wordpress.org/trunk@31025 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 02:04:17 +00:00
Boone Gorges
4cead42b26 Introduce 'name' parameter for get_terms(). 
This enhancement requires a modification in the way that `wp_dropdown_categories()`
prepares its arguments for `get_terms()`, so that its unrelated 'name' param is
not mistaken for the new 'name' argument in `get_terms()`.

Props danielbachhuber.
Fixes #30611.

git-svn-id: https://develop.svn.wordpress.org/trunk@31024 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-02 21:33:33 +00:00
Andrew Ozz
95fd7b1590 Move the (recently added) .notice admin notices below the first H2, same as the .updated and .error notices. Props sippis, fixes #30885. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31023 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-02 18:51:52 +00:00
Andrew Ozz
bc108a94ce Fix the background color in the auth. check modal. Props melchoyce, fixes #30278. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31022 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-02 17:20:06 +00:00
Scott Taylor
f014d0cf35 If you set '_wp_page_template' for a post, and then switch to a theme that doesn't support the template, subsequent calls to wp_insert_post() will bail early without running a plethora of hooks. This shouldn't happen. We should set the template to 'default' and continue through the rest of the function. The function will still bail if $wp_error is true via wp_insert_post( $arr, true ). 
Props nofearinc.
Fixes #25334.


git-svn-id: https://develop.svn.wordpress.org/trunk@31020 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-01 20:34:19 +00:00
Scott Taylor
64784baa95 WP_List_Table's constructor registers an 'admin_footer' callback when AJAX is enabled. As such, if you create multiple instances of the class, you get multiple JS blobs on the page when the callbacks fire. Extra instances get made when wp_comment_reply() invokes the class constructor without checking for the existing instance via the $wp_list_table global. 
We shall check the `$wp_list_table` global in `wp_comment_reply()`.

Props sorich87.
Fixes #17413.


git-svn-id: https://develop.svn.wordpress.org/trunk@31019 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-01 19:54:53 +00:00
Scott Taylor
186a94fb78 More-specific docs for wp_embed_handler_youtube(). 
Fixes #30711.


git-svn-id: https://develop.svn.wordpress.org/trunk@31018 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-01 19:20:44 +00:00
Sergey Biryukov
944ed3f980 Update license copyright year to 2015. 
props valendesigns.
fixes #30877.

git-svn-id: https://develop.svn.wordpress.org/trunk@31017 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-01 12:24:05 +00:00
Scott Taylor
be8211beac Support chromeless Vimeo via MEjs: 
* Bump MediaElement script loader versions to 2.16.2 - missed in [30634], oops!
* Add `Froogaloop` to `js/mediaelement` scripts for Vimeo
* Check for Vimeo in the same locations that YouTube is checked
* Dynamically load Froogaloop script in admin when editing a TinyMCE view
* Edit MediaElement to call `mejs.$.extend` instead of `$.extend` in `mejs.HtmlMediaElementShim.createPlugin()`, since `$` is not available via WP's jQuery (I will report this upstream):
6f9a78e008/src/js/me-shim.js (L631)

Fixes #29267.


git-svn-id: https://develop.svn.wordpress.org/trunk@31016 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-31 20:40:05 +00:00
Boone Gorges
bd03b2ead8 Support array values for post-related parameters in WP_Comment_Query. 
Props nprasath002, c3mdigital, ianmjones.
Fixes #20006.

git-svn-id: https://develop.svn.wordpress.org/trunk@31015 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-31 19:37:09 +00:00
Boone Gorges
f71821dc05 In remove_all_filters(), only remove callbacks that match the $priority parameter. 
Props GeertDD, valendesigns.
Fixes #20920.

git-svn-id: https://develop.svn.wordpress.org/trunk@31014 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-31 19:06:29 +00:00
Scott Taylor
4d69dbadee Fix docs for WP_User::allcaps: 
The `allcaps` property of the `WP_User` class represents all of the caps of the user, not the caps of the user's role. Introduced in [26126].

Props dlh.
Fixes #30852.


git-svn-id: https://develop.svn.wordpress.org/trunk@31013 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-31 18:14:07 +00:00
Scott Taylor
32e0a1c7b8 Update/fix inline docs for update_object_term_cache(). 
Props DrewAPicture.
Fixes #30731.


git-svn-id: https://develop.svn.wordpress.org/trunk@31012 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-31 18:11:22 +00:00
Scott Taylor
b7d63c3192 Correct a typo in wp-includes/post-thumbnail-template.php. 
Props ixkaito.
Fixes #30867.


git-svn-id: https://develop.svn.wordpress.org/trunk@31011 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-31 18:08:56 +00:00
Aaron Jorbin
43edd17097 Set the type attribute of the buttons for logging out of all sessions to buttons 
By not setting this attribute, the buttons default to submit and as the first
submit button on the page, it causes pressing the enter key to log you out of
all sessions. This change restores the pre 4.1 behavior where pressing enter
while focused on a form field submits the form.

props ocean90
fixes #30871 for trunk



git-svn-id: https://develop.svn.wordpress.org/trunk@31010 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-31 17:32:39 +00:00
Andrew Nacin
25e332e473 Use correct function name in docs for get_plugin_data(). 
props eliorivero.
fixes #30699.


git-svn-id: https://develop.svn.wordpress.org/trunk@31008 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-31 08:07:09 +00:00
Dion Hulse
c34913eae6 Add a revision number to $wp_version for nightly update purposes. See [30411] 
git-svn-id: https://develop.svn.wordpress.org/trunk@31007 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-31 05:34:07 +00:00
Boone Gorges
ae6575685c In wp_dropdown_categories(), allow the term field used to populate option valuesto be specified. 
The new 'value_field' parameter makes it possible to set term slugs (or some
other term property) as the 'value' attribute of the option elements generated
by `wp_dropdown_categories()`. This additional flexibility reduces the effort
required to translate term_id to other term fields when processing form
submissions that include values from taxonomy dropdowns. See #30865 for a
use case.

Props collinsinternet.
Fixes #30306.

git-svn-id: https://develop.svn.wordpress.org/trunk@31006 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-30 21:30:16 +00:00
Boone Gorges
06b820a989 Use proper hash notation for wp_dropdown_categories() docblock. 
See #30306.

git-svn-id: https://develop.svn.wordpress.org/trunk@31005 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-30 20:48:34 +00:00
Andrew Nacin
869798d915 XML-RPC: Send 405 Method Not Allowed for GET requests. 
props maxcutler.
fixes #20986.


git-svn-id: https://develop.svn.wordpress.org/trunk@31004 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-30 20:40:50 +00:00
Boone Gorges
e85543f68b When no plugins are active, return an empty array from validate_active_plugins(). 
This creates parity with the behavior of the function when plugins *are* active,
but none are invalid. It also makes it possible to write unit tests for the
function.

Props sgrant.
Fixes #30860.

git-svn-id: https://develop.svn.wordpress.org/trunk@31003 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-30 19:30:07 +00:00
Lance Willett
95548e511c Twenty Fifteen: more styles for multi-site forms. 
Props iamtakashi, closes #30776.

git-svn-id: https://develop.svn.wordpress.org/trunk@31001 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-30 10:29:18 +00:00
Sergey Biryukov
0d308bfd6b Pass the $adjacent parameter to the "{$adjacent}_post_link" filter. 
props ankit.gade@rtcamp.com, kpdesign.
fixes #30440.

git-svn-id: https://develop.svn.wordpress.org/trunk@31000 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-30 06:56:19 +00:00
Boone Gorges
a441150c17 Fix incorrect @since tag introduced in [30998]. 
Props dimadin.
See #25853.

git-svn-id: https://develop.svn.wordpress.org/trunk@30999 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-29 17:17:09 +00:00
Boone Gorges
51d9fc0ad1 Apply 'taxonomy_parent_dropdown_args' filter when editing terms. 
Added in WP 3.7 [25123], the 'taxonomy_parent_dropdown_args' filter affected
only the term creation interface. This changeset introduces parity by ensuring
that it is applied when editing terms as well.

The new `$context` parameter indicates whether the filter is being applied in
a 'new' or 'edit' context.

Props TimothyBlynJacobs, DrewAPicture.
Fixes #29853.

git-svn-id: https://develop.svn.wordpress.org/trunk@30998 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-29 15:26:51 +00:00
Lance Willett
e30d6790aa Twenty Fifteen: fix missing style for menu in small screens. 
Props valendesigns, fixes #30857.

git-svn-id: https://develop.svn.wordpress.org/trunk@30997 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-29 12:00:35 +00:00
Lance Willett
9a3942ffd8 Twenty Fifteen: pinking shears. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30996 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-29 10:07:50 +00:00
Lance Willett
31114d0d6e Twenty Fifteen: add styles for multisite registration forms. 
Props valendesigns, fixes #30776.

git-svn-id: https://develop.svn.wordpress.org/trunk@30995 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-29 09:57:27 +00:00
Sergey Biryukov
b71e24216d Correct $taxonomies parameter description in get_terms() filters. 
props dlh.
fixes #30851.

git-svn-id: https://develop.svn.wordpress.org/trunk@30994 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-28 01:43:47 +00:00
Boone Gorges
6d5084ef1c Pass $resource_type to 'get_ancestors' filter. 
The `$resource_type` argument was added to the `get_ancestors()` function in
[30141]. In that changeset, the documentation for the filter was updated to
indicate that it would receive `$resource_type` as a param, but the filter
itself was not updated accordingly.

Props tmatsuur, DrewAPicture.
Fixes #30843.

git-svn-id: https://develop.svn.wordpress.org/trunk@30993 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-26 21:29:00 +00:00
Dominik Schilling (ocean90)
f3d83c3f6c Customizer: Use correct event variable when moving widgets to another widget area. 
Fixes "ReferenceError: event is not defined error." in Firefox.

props tywayne.
fixes #30818.

git-svn-id: https://develop.svn.wordpress.org/trunk@30992 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-23 17:23:16 +00:00
Dominik Schilling (ocean90)
c05e46e4d1 Customizer: Improve IE 8 compatibility. 
* Use square bracket notation for `default` keywords.
* Use Underscores `indexOf` for arrays.

props westonruter, ocean90.
fixes #30781 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@30991 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-23 17:04:47 +00:00
Andrew Ozz
8298e94bfe TinyMCE wpView: when clicking on the Edit button, move the focus back to the editor before opening the modal. This is needed for IE so TinyMCE can save the proper DOM "bookmark", and makes it possible to move the focus to the modal after it is opened. 
See #30817.

git-svn-id: https://develop.svn.wordpress.org/trunk@30986 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-22 21:30:16 +00:00
Boone Gorges
5f1ad2d768 In wp_update_term(), limit duplicate slug checks to the same taxonomy as the updated term. 
In 4.1 [30240], `wp_insert_term()` was modified to allow the creation of terms
with duplicate slugs, as long as the terms are in different taxonomies.
`wp_update_term()` didn't get the corresponding modification, with the result
that term updates fail when the term being updated shares a slug with an older
term, regardless of that older term's taxonomy.

Props ipm-frommen.
Fixes #30780 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@30985 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-22 15:32:59 +00:00
Scott Taylor
061bfddda9 Comment List Tables: 
* Declare `$extra_items` property
* Since `->get_column_info()` overrides its parent's method, it doesn't need to set `_column_headers`, which is an undeclared property that is only used for caching the lookup after the first run in the parent class, which isn't called in the child class.
* `$_args` in `WP_List_Table` has to be `protected` for `WP_Post_Comments_List_Table` to legally access it. `$_args` is awkward as is and should probably be only available via a getter.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30984 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-20 23:27:00 +00:00
Scott Taylor
44fe0ebf75 Correct the @param docs for arguments that are truthy/falsey. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30983 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-20 23:03:21 +00:00
Scott Taylor
218dd4fd6b For clarity, initialize some arrays that previously were only assigned via short circuit in loops. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30982 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-20 22:46:53 +00:00
Scott Taylor
91dcf8796b In image_size_input_fields(): 
* Declare `$out` as an empty array - this is not a strict PHP requirement, but is a good practice before loops
* Most of this function was tabbed twice, instead of once

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30981 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-20 22:18:12 +00:00
Scott Taylor
a75c7977b9 In wp_import_handle_upload(): 
`$file` was essentially getting declared/overwritten 3 times. In lieu of this, return an array containing the error immediately instead of doing a short-circuit array key assignment on error. Rename the local variable to `$upload` and use its properties instead of creating 3 new local vars, one of which stomped the array.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30980 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-20 21:09:11 +00:00
Scott Taylor
f6f12912e2 Improve some docs for @param. Remove an unneeded $wpdb global import. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30979 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-20 20:55:21 +00:00
Scott Taylor
04ed6499cd Improve some wp-admin/includes/class-wp-filesystem-*.php docs for @param. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30978 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-20 20:39:41 +00:00
Andrew Ozz
6695ac3bab Editor: when switching editor-expand off for the first time use the default editor height. Props avryl, fixes #30760 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30977 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-20 19:33:01 +00:00
Andrew Nacin
26eeb623a6 About page: CDN images. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30971 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-18 17:54:43 +00:00
Andrew Nacin
657768ff9c Update theme POT files in trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30969 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-18 17:00:41 +00:00
Lance Willett
2f096d219f Bundled Themes: bump version numbers to coordinate with 4.1 release. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30967 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-18 16:18:14 +00:00
Andrew Nacin
e8e2db6e00 Update bundled theme POT files in trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30965 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-18 01:32:09 +00:00
Lance Willett
439d540c20 Twenty Fifteen: use better, universal sans-serif fonts for RTL, similar to Twenty Ten which also had serif fonts throughout. 
Props iamtakashi, see #30752.

git-svn-id: https://develop.svn.wordpress.org/trunk@30961 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-17 22:29:08 +00:00
Andrew Nacin
d268aaf37f Update version numbers in trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30960 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-17 17:37:16 +00:00
Lance Willett
6a312bdd21 Twenty Fifteen: ensure RTL editor font style is consistent with front-end font style. 
Props iamtakashi and alex-ye, see #30746.

git-svn-id: https://develop.svn.wordpress.org/trunk@30956 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-17 17:21:29 +00:00
Lance Willett
340f6052fd Twenty Fifteen: ensure menu icon is properly centered for RTL views on small screens. 
Props iamtakashi, fixes #30739.

git-svn-id: https://develop.svn.wordpress.org/trunk@30955 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-17 16:38:51 +00:00
Boone Gorges
b824d6f56c Update individual term caches in get_terms(). 
This was removed in [29915] as part of the attempt to add cache support to
`get_term_by()`. When that support was removed in [30900], it was not properly
restored.

This changeset includes a unit test to verify that the cache is properly primed
for terms found in `get_terms()`, as well as tests to verify the other cache
setting that was touched by [30900].

Fixes #30749. See #21760.

git-svn-id: https://develop.svn.wordpress.org/trunk@30954 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-17 16:38:44 +00:00
Lance Willett
c7d2f360cb Twenty Fifteen: fix styles for screen-reader-only search button in small screens. 
Props iamtakashi, fixes #30744.

git-svn-id: https://develop.svn.wordpress.org/trunk@30953 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-17 16:37:05 +00:00
Helen Hou-Sandi
908a2e87c8 Ensure inline code examples stay LTR, punctuation and all. 
props alex-ye.
see #30748.


git-svn-id: https://develop.svn.wordpress.org/trunk@30952 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-17 16:21:54 +00:00
Helen Hou-Sandi
d34709eaa5 About page: Don't allow tab text to wrap. 
Some language, browser, and OS combinations (notably Arabic, Chrome, and Windows) were wrapping.

see #30743.


git-svn-id: https://develop.svn.wordpress.org/trunk@30951 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-17 16:01:42 +00:00
Dominik Schilling (ocean90)
fabd47a2ff About: Fix the WordPress badge. 
`css-clean` (minifies our CSS) has an issue when using multiple backgrounds and background position together. Instead of relying on browser support for multiple backgrounds to display the WP logo as SVG, use the `.svg` CSS class.

see #30735.

git-svn-id: https://develop.svn.wordpress.org/trunk@30946 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 22:53:25 +00:00
Lance Willett
e2c36c3176 Twenty Fifteen: hide search input cancel button. See #30728. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30945 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 22:42:24 +00:00
Dominik Schilling (ocean90)
7560f4cf8c Pass locale to wordpress.org theme/plugin API. 
In the future this will be used to return localized plugin/theme info.

see #30735.

git-svn-id: https://develop.svn.wordpress.org/trunk@30944 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 22:38:52 +00:00
Dominik Schilling (ocean90)
6873e08839 Twenty Fifteen: Use dynamic default color value instead of hardcoded color. 
props iamtakashi.
see #30733.

git-svn-id: https://develop.svn.wordpress.org/trunk@30932 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 21:34:46 +00:00
Andrew Nacin
b4dc6629cd Last about page string. props celloexpressions. fixes #30435. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30929 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 21:26:34 +00:00
John Blackbourn
9189fbcff9 Make the DFW paragraph on the About page narrower to mitigate an orphan in Firefox. 
See #30435
Props melchoyce


git-svn-id: https://develop.svn.wordpress.org/trunk@30921 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 20:01:56 +00:00
Mark Jaquith
93ea9862a5 Revert [30036]. 
see #18035

git-svn-id: https://develop.svn.wordpress.org/trunk@30912 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 17:34:17 +00:00
Lance Willett
8d69099344 Twenty Fifteen: fallback hex color for no-comments text should come first. 
Props iamtakashi, fixes #30730.

git-svn-id: https://develop.svn.wordpress.org/trunk@30910 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 16:18:40 +00:00
Scott Taylor
c9707a4a31 In response to regressions on .com, fix MEjs styles for screen reader text and overflow on the volume slider. 
Props obenland.
See #30281.


git-svn-id: https://develop.svn.wordpress.org/trunk@30907 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 15:12:35 +00:00
Dominik Schilling (ocean90)
b258a6c144 Twenty Fifteen: Remove unnecessary esc_html() from get_the_date() and get_the_modified_date(). 
see #30724.

git-svn-id: https://develop.svn.wordpress.org/trunk@30905 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 14:18:48 +00:00
John Blackbourn
2069d52fa1 Move a <code> tag out of a localised string on the About page. 
Props pavelevap
See #30435


git-svn-id: https://develop.svn.wordpress.org/trunk@30903 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 14:03:53 +00:00
Dominik Schilling (ocean90)
1ca9749c93 Twenty Fifteen: Remove esc_html() from get_the_author(). 
The display name is sanitized through `sanitize_text_field`, `wp_filter_kses`, and `_wp_specialchars`.

see #30724.

git-svn-id: https://develop.svn.wordpress.org/trunk@30901 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 13:39:32 +00:00
Boone Gorges
bf62165353 Remove caching for get_term_by() calls. 
The new cache group scheme causes term invalidation to be overly broad, so
that busting the cache for one term will bust the cache for all terms in the
taxonomy. We'll have another go at more focused use of the 'last_changed'
incrementor in a future release.

Reverts [29915], [30073], [30080], [30108], [30112].
See #21760.

git-svn-id: https://develop.svn.wordpress.org/trunk@30900 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 13:26:19 +00:00
Dominik Schilling (ocean90)
3a63ae0cb2 Twenty Fifteen: Don't escape translated strings. 
Replace every unnecessary instance of `esc_html_x()` with just `_x()`.

see #30724.

git-svn-id: https://develop.svn.wordpress.org/trunk@30899 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 13:24:38 +00:00
Dominik Schilling (ocean90)
5447103756 Twenty Fifteen: Remove esc_html() from blog description. 
The blog description gets esc_html()'d *into* the DB. It's also escaped because the filter for `get_bloginfo()` is set to 'display'.

see #30724.

git-svn-id: https://develop.svn.wordpress.org/trunk@30897 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 13:19:17 +00:00
Dominik Schilling (ocean90)
25ffd56152 Twenty Fifteen: Don't escape translated strings. 
Replace every unnecessary instance of `esc_html__()` and `esc_html_e()` with just `__()` and `_e()`.

see #30724.

git-svn-id: https://develop.svn.wordpress.org/trunk@30896 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 12:59:59 +00:00
Dominik Schilling (ocean90)
754fc5f22d Twenty Fifteen: Don't save unfiltered CSS in a setting. 
Introduce `twentyfifteen_get_color_scheme_css( $colors )` which will be used for Underscore/Backbone and the PHP side. Let `twentyfifteen_color_scheme_css()` handle the color calculation on PHP side.

see #30409.

git-svn-id: https://develop.svn.wordpress.org/trunk@30893 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 12:26:49 +00:00
Dominik Schilling (ocean90)
8f323ecf9a Customizer: Export Preview instance to wp.customize.preview. 
see #30409, #30726.

git-svn-id: https://develop.svn.wordpress.org/trunk@30891 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 11:52:38 +00:00
Andrew Nacin
daf16cdb63 Call it 'Distraction-free writing mode' and update the help string. fixes #30657. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30890 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 10:06:17 +00:00
Andrew Nacin
855ff22a53 Update/add plugin recommendation strings. 
Update [30887], add a translation function to the Vine string.

fixes #30337. see #30435.


git-svn-id: https://develop.svn.wordpress.org/trunk@30889 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 10:05:09 +00:00
Andrew Nacin
07e7f03373 Updates to the 'Log out everywhere' implementation. 
* Include a message and a disabled button when you're only logged in at one location.
 * Avoid leaking the session token in HTML.
 * Simplify, simplify, simplify.

see #30264.


git-svn-id: https://develop.svn.wordpress.org/trunk@30888 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 09:15:01 +00:00
Andrew Nacin
82d0ba4b60 Finalize two more about page strings. see #30435. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30887 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 08:57:11 +00:00
Dion Hulse
1e721a144b Add braces around a Docblock in an if statement, although not required by PHP, this is required by our coding standards for readability. 
Introduced in 3.9 with r27365
See #25905


git-svn-id: https://develop.svn.wordpress.org/trunk@30886 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 05:51:49 +00:00
Dominik Schilling (ocean90)
c959c4d4b3 Customizer: Add _wp_attachment_is_custom_background meta to uploaded background images. 
Adds `$type` property to `WP_Customize_Background_Image_Control` (PHP) and introduces `wp.customize.BackgroundControl` (JS).

see #30707.

git-svn-id: https://develop.svn.wordpress.org/trunk@30885 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 23:27:17 +00:00
Dominik Schilling (ocean90)
d5299a9522 Autoprefixer for [30857]. 
see #30435.

git-svn-id: https://develop.svn.wordpress.org/trunk@30884 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 23:19:06 +00:00
John Blackbourn
0533e9bd8c Correct the height of the search type select element when searching the plugin directory. 
See #30719
Props pavelevap, eliorivero


git-svn-id: https://develop.svn.wordpress.org/trunk@30879 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 22:31:35 +00:00
John Blackbourn
5918c5d365 Clarify the behaviour of the wp_editor_set_quality and jpeg_quality filters. 
Props DH-Shredder
See #29856


git-svn-id: https://develop.svn.wordpress.org/trunk@30874 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 21:42:32 +00:00
Dominik Schilling (ocean90)
663d12c8f8 Customizer: Remove date filter from the Header/Background Image upload frames. 
Adds an option to `wp.media.view.AttachmentsBrowser` to hide the date filter added in [29813].

see #30689.

git-svn-id: https://develop.svn.wordpress.org/trunk@30872 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 20:26:54 +00:00
Dominik Schilling (ocean90)
c17317912a Customizer: Import missing wp.customize.Control.prototype._toggleActive. 
Check also if `completeCallback` is set before calling it.

props westonruter.
see #30701.

git-svn-id: https://develop.svn.wordpress.org/trunk@30871 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 19:53:55 +00:00
Lance Willett
eb3ea331f0 Twenty Fifteen: minor updates to readme.txt file for clarity and removing non-ASCII characters. Closes #30675. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30869 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 19:08:54 +00:00
Lance Willett
5f5936f81f Twenty Twelve: fix widget stacking problem in older IE browsers for Front Page template. 
Props TomasM, hiwhatsup. Fixes #28938.

git-svn-id: https://develop.svn.wordpress.org/trunk@30868 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 17:55:37 +00:00
Lance Willett
d931b5cbc5 Twenty Fifteen: remove license details for the image shown in the theme screenshot file as it is Creative Commons Zero, which doesn't require attribution. 
Props iamtakashi, fixes #30156.

git-svn-id: https://develop.svn.wordpress.org/trunk@30867 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 17:43:34 +00:00
Lance Willett
cb816a383a Twenty Fourteen: remove Genericons as a dependency from loading the main stylesheet and IE-specific stylesheet. See #30532. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30866 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 17:39:59 +00:00
Lance Willett
a25f807d6e Twenty Fifteen: remove Genericons as a dependency from loading the main stylesheet. 
Props iamtakashi, fixes #30532.

git-svn-id: https://develop.svn.wordpress.org/trunk@30865 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 17:37:05 +00:00
Dion Hulse
28e22a4ec4 Background Updates: Pass back whether Group Writable support is being leveraged for an update to the WordPress.org API. 
See #30245


git-svn-id: https://develop.svn.wordpress.org/trunk@30860 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 14:07:35 +00:00
Andrew Nacin
5c04326ba6 About page design for 4.1. 
props melchoyce and ryelle, who again outdid themselves.
see #30435.


git-svn-id: https://develop.svn.wordpress.org/trunk@30857 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 10:46:43 +00:00
Andrew Nacin
b38c603682 Rename _wp_clear_update_cache() to wp_clean_update_cache(). 
This makes it match most cache-clearing functions, including the ones it wraps. Also no need for it to be prefixed as "private."

wp_clean_plugins_cache() doesn't always exist, so as a quick fix, clear the transient we care to clear.

see #30369.


git-svn-id: https://develop.svn.wordpress.org/trunk@30856 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 08:54:14 +00:00
Andrew Nacin
0375edc8c6 No need for wp_get_password_hint() to be prefixed as if it is private. 
see #21243.


git-svn-id: https://develop.svn.wordpress.org/trunk@30855 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 08:33:48 +00:00
Andrew Nacin
7344a29063 Avoid repeatedly calling is_tax( 'post_format', '...' ) in get_the_archive_title(). 
see #21995.


git-svn-id: https://develop.svn.wordpress.org/trunk@30854 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 07:31:48 +00:00
Andrew Ozz
34a2576fd6 Editor, new DFW: fix fading out for the right sidebar in IE. Fixes #30714. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30853 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 03:08:12 +00:00
Andrew Ozz
284bfd81b9 Improve the fix for menu shakiness when over-scrolling. Recalculate heights on editor auto-resize. 
See #30692.

git-svn-id: https://develop.svn.wordpress.org/trunk@30852 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 00:10:18 +00:00
Dominik Schilling (ocean90)
326d7f8c5f Customizer: Re-add the possibility to remove and restore a default background image. 
see #21483.
fixes #30683 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@30849 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-14 19:36:27 +00:00
Dominik Schilling (ocean90)
4a662deaa5 Customizer: Don't escape control descriptions in JavaScript templates. 
fixes #30682 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@30847 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-14 19:23:49 +00:00
Boone Gorges
093de0f0be In WP_Meta_Query, interpret 'value' correctly when used with EXISTS/NOT EXISTS. 
As in earlier versions, EXISTS with a value is equivalent to '=', while NOT
EXISTS should always ignore 'value'.

Props barrykooij.
Fixes #30681 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@30846 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-14 19:00:31 +00:00
Dominik Schilling (ocean90)
91ac188a12 Twenty Fifteen: Update the .pot file for [30834]. 
fixes #30152.

git-svn-id: https://develop.svn.wordpress.org/trunk@30845 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-14 12:33:56 +00:00
Andrew Ozz
35c763f795 Fix menu shakiness when over-scrolling in Chrome and Safari on MacOS. 
See #30692.

git-svn-id: https://develop.svn.wordpress.org/trunk@30844 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-14 01:46:39 +00:00
Andrew Ozz
560a1ba478 iOS: do not autofocus the readonly textarea with the code for wp-config.php in setup-config.php. 
See #30703.

git-svn-id: https://develop.svn.wordpress.org/trunk@30843 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-14 00:10:05 +00:00
Andrew Ozz
2fc1155920 Do not autofocus text fields on page load on mobile devices. This is currently broken in many mobile browsers: 
- iOS Safari opens the keyboard and auto-scrolls on the first tap anywhere on the screen triggering the click at an unexpected place. That makes it impossible to follow links or press buttons.
- Chrome on iOS opens the keyboard on load and may scroll the focused field off screen.
- The Android 4.4 browser only highlights the field, the user has to tap it to open the keyboard and type.
See #30703.

git-svn-id: https://develop.svn.wordpress.org/trunk@30842 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-13 22:07:58 +00:00
Andrew Nacin
074d8c1ad7 Finalize more about page strings. see #30435. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30841 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-13 22:04:51 +00:00
Andrew Nacin
095c9857ef About page updates. 
* Live-update the number of active translations.
 * Finalize most strings.
 * Lazily remove links to admin-only screens based on cap checks.
see #30435.


git-svn-id: https://develop.svn.wordpress.org/trunk@30840 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-13 20:11:49 +00:00
Andrew Ozz
276a69d6f9 TinyMCE: add another Edit translatable string for the tooltip of the Edit button on the image toolbar. Props pavelevap, see #30694. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30839 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-13 00:46:20 +00:00
Lance Willett
950126a515 Twenty Fifteen: update scroll functionality to make sure child menu items are always reachable. 
Props iamtakashi, fixes #30674.

git-svn-id: https://develop.svn.wordpress.org/trunk@30838 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-12 23:58:06 +00:00
Andrew Ozz
1bbc18c390 Improve text for the DFW admin pointer. Remove the concatenation. 
Props kpdesign, ianmjones.
See #30671.

git-svn-id: https://develop.svn.wordpress.org/trunk@30837 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-12 22:11:46 +00:00
Andrew Ozz
30a12129af Twenty Fifteen, editor-style: remove margin-bottom from the gallery preview inside the editor. Fixes #30697. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30836 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-12 21:44:21 +00:00
Andrew Ozz
8f7be98176 TinyMCE: make the tooltip for the remove button in the image toolbar translatable. Props pavelevap, fixes #30694 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30835 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-12 21:25:08 +00:00
lancewillett
dc0e4af5ba Twenty Fifteen: update archive pagination links to use aria-hidden for better accessibility. 
Props SergeyBiryukov, fixes #30152.

git-svn-id: https://develop.svn.wordpress.org/trunk@30834 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-12 18:36:02 +00:00
Lance Willett
28b82443c3 Twenty Fifteen: update readme.txt file, props iamtakashi. See #30675. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30833 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-12 18:27:09 +00:00
Lance Willett
2b686ac112 Twenty Fifteen: remove fonts as a style dependency. 
Props obenland, SergeyBiryukov. Fixes #30678.

git-svn-id: https://develop.svn.wordpress.org/trunk@30832 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-12 18:25:30 +00:00
Dominik Schilling (ocean90)
163c32126f Revisions: Fix initial state of compareTwoMode. 
Broken since [30131].

fixes #30672.

git-svn-id: https://develop.svn.wordpress.org/trunk@30831 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-12 09:53:10 +00:00
Andrew Ozz
d8f6e64596 Fix search box position on the Add Plugins screen after resizing the window to narrower than 1000px and then back to wider than 1200px. Fixes #30658. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30830 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-12 00:53:51 +00:00
Andrew Ozz
3fb7f40445 TinyMCE: remove reposition delay on showing the image toolbar. Not needed when no animation. Fixes #30670. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30829 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-12 00:09:29 +00:00
Sergey Biryukov
1afbe9d6b3 Twenty Fifteen: Reflect the change from "no" to "share" icon in [30810] in readme.txt. 
props iamtakashi.
fixes #30148.

git-svn-id: https://develop.svn.wordpress.org/trunk@30828 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-11 17:44:50 +00:00
John Blackbourn
dcff477632 Switch to (get_)the_posts_pagination() in Twenty Fifteen. 
See #29808
Props obenland


git-svn-id: https://develop.svn.wordpress.org/trunk@30824 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-11 10:23:40 +00:00
John Blackbourn
22b5e67b10 Rename (get_)the_pagination() to (get_)the_posts_pagination() for clarity. 
See #29808
Props obenland


git-svn-id: https://develop.svn.wordpress.org/trunk@30823 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-11 10:22:47 +00:00
Andrew Nacin
3c2f9a9ccf About page, text only (not released for translation), first pass. 
Design and finalized text to follow. This is just for the RC crowd.

props johnbillion, helen, markjaquith, nacin.
see #30435.


git-svn-id: https://develop.svn.wordpress.org/trunk@30821 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-11 10:15:14 +00:00
John Blackbourn
9dc69a9fa6 Allow the type argument to be passed through get_the_pagination() as long as its value isn't array. 
For trunk.

See #29808


git-svn-id: https://develop.svn.wordpress.org/trunk@30820 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-11 09:38:18 +00:00
Andrew Nacin
560b6f7978 Editor focus: Don't trigger when typing while the mouse is outside the editor. 
props avryl.
fixes #20668.


git-svn-id: https://develop.svn.wordpress.org/trunk@30817 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-11 09:33:46 +00:00
Andrew Ozz
9bda766f54 Fix the search field width in the media modal, media library grid and on the install new plugins screen. Props helen, fixes #30658. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30813 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-11 04:11:28 +00:00
Andrew Ozz
bd80506437 TinyMCE, image toolbar: remove the animation and make the box-shadow lighter. Props melchoyce, fixes #30664. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30812 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-10 23:53:01 +00:00
Ian Stewart
c1cc682e9f Twenty Fifteen: updating the .pot to reflect changes in r30790. 
Props iamtakashi, fixes #30603.



git-svn-id: https://develop.svn.wordpress.org/trunk@30811 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-10 23:32:46 +00:00
Ian Stewart
5efc35ef83 Twenty Fifteen: using an opaque share icon as the default instead of semi-opaque "no" icon that suggests a bug. 
Props iamtakashi, fixes #30148.



git-svn-id: https://develop.svn.wordpress.org/trunk@30810 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-10 23:13:20 +00:00
Ian Stewart
e8300e1409 Twenty Fifteen: Removing the empty changelog.txt. 
Fixes #30650.



git-svn-id: https://develop.svn.wordpress.org/trunk@30809 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-10 23:05:11 +00:00
Ian Stewart
3b84f1d6d8 Twenty Fifteen: correcting odd scrolling and jumping in IE and no-scroll with window resize. 
Props iamtakashi, ocean90, fixes #30632, #30645.




git-svn-id: https://develop.svn.wordpress.org/trunk@30808 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-10 23:01:03 +00:00
Ian Stewart
9855b67c67 Twenty Fifteen: minor file cleanup. 
Props iamtakashi, fixes #30653.



git-svn-id: https://develop.svn.wordpress.org/trunk@30806 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-10 13:38:51 +00:00
Ian Stewart
54537f5e5d Twenty Fifteen: correct escaping. 
Props iamtakashi, fixes #30651.



git-svn-id: https://develop.svn.wordpress.org/trunk@30805 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-10 13:33:27 +00:00
Ian Stewart
069e31acab Twenty Fifteen: less than or equal to is incorrect here when the sidebar only appears at 955px -- it should be less than for removal of inline styles. 
Props iamtakashi, fixes #30656



git-svn-id: https://develop.svn.wordpress.org/trunk@30804 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-10 13:30:24 +00:00
Ian Stewart
750df27f0e Twenty Fifteen: prevent jumping on hover in blog footer links with Safari 
Props iamtakashi, fixes #30654.



git-svn-id: https://develop.svn.wordpress.org/trunk@30803 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-10 13:23:10 +00:00
Ian Stewart
1a58965428 Twenty Fifteen: we should be checking for twentyfifteen_get_color_scheme_choices here not twentyfifteen_get_color_scheme_control_options 
Props iamtakashi, fixes #30652



git-svn-id: https://develop.svn.wordpress.org/trunk@30802 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-10 13:20:55 +00:00
Ian Stewart
f16ab82cbc Twenty Fifteen: admin-custom-header.css was emptied in r30567 so let's remove it entirely. 
Props kwight, fixes #30648.



git-svn-id: https://develop.svn.wordpress.org/trunk@30801 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-10 13:16:01 +00:00
Andrew Nacin
6933f4329c Trunk is now 4.2 alpha. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30800 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-10 08:40:32 +00:00
Drew Jaynes (DrewAPicture)
7e05cd199d Twenty Fifteen: Replace encoded HTML entities in the file header DocBlock for header.php with 'head element'. 
Props iamtakashi.
Fixes #30649.


git-svn-id: https://develop.svn.wordpress.org/trunk@30798 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-10 03:01:18 +00:00
Dominik Schilling (ocean90)
debc4dab6f Dashicons: Update to the latest files. 
New icons:
* .dashicons-controls-play (f522)
* .dashicons-controls-pause (f523)
* .dashicons-controls-forward (f519)
* .dashicons-controls-skipforward (f517)
* .dashicons-controls-back (f518)
* .dashicons-controls-skipback (f516)
* .dashicons-controls-repeat (f515)
* .dashicons-controls-volumeon (f521)
* .dashicons-controls-volumeoff (f520)
* .dashicons-phone (f525)
* .dashicons-building (f512)
* .dashicons-store (f513)
* .dashicons-album (f514)
* .dashicons-palmtree (f527)
* .dashicons-tickets-alt (f524)
* .dashicons-money (f526)

Updated icons:
* .dashicons-align-left (f135)
* .dashicons-align-right (f136)
* .dashicons-align-center (f134)
* .dashicons-align-none (f138)

props liljimmi, melchoyce, empireoflight.
fixes #29444.

git-svn-id: https://develop.svn.wordpress.org/trunk@30797 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-09 19:33:09 +00:00
John Blackbourn
d884bdb8ec In Twenty Fourteen, move the "Continue Reading" arrows back inside the translatable strings so they can be localised. 
See #30641


git-svn-id: https://develop.svn.wordpress.org/trunk@30796 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-09 18:56:41 +00:00
John Blackbourn
ea614c6841 In Twenty Thirteen, move the "Continue Reading" arrows back inside the translatable strings so they can be localised. 
See #30641


git-svn-id: https://develop.svn.wordpress.org/trunk@30795 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-09 18:55:40 +00:00
Dominik Schilling (ocean90)
23d0e8392e Remove a stray $ from [30793]. 
props ipm-frommen.
see #30553.

git-svn-id: https://develop.svn.wordpress.org/trunk@30794 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-09 11:26:27 +00:00
Dominik Schilling (ocean90)
4975d4255f Themes: Use Customizer deep-links inside the theme modal. 
props DrewAPicture, ocean90.
see #25569, #25571.
fixes #30553.

git-svn-id: https://develop.svn.wordpress.org/trunk@30793 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-08 22:22:23 +00:00
Dominik Schilling (ocean90)
e91efcca38 Fix JSHint error introduced in [30780]. 
see #30608.

git-svn-id: https://develop.svn.wordpress.org/trunk@30792 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-08 22:06:22 +00:00
Sergey Biryukov
27fefdf04b Revert [28948], which caused a regression. 
see #29573 for trunk. see #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@30791 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-08 21:13:56 +00:00
Ian Stewart
9e9134b91e Twenty Fifteen: moving to a single line for tranlator comments to prevent them being missed in i18n tools. 
Props netweb, DrewAPicture, fixes #30603.



git-svn-id: https://develop.svn.wordpress.org/trunk@30790 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-08 18:24:13 +00:00
Ian Stewart
e5f09f28de Twenty Fifteen: layout correction for IE8 and IE7 after r30388 introduced a defect with the header there. 
Props iamtakashi, fixes #30630.



git-svn-id: https://develop.svn.wordpress.org/trunk@30789 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-08 17:45:14 +00:00
Sergey Biryukov
99224928bf Move the logic from WP_Image_Editor::get_quality() to WP_Image_Editor::set_quality(), so that 'wp_editor_set_quality' and 'jpeg_quality' filters run when setting the default value. 
props markoheijnen.
fixes #29856.

git-svn-id: https://develop.svn.wordpress.org/trunk@30788 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-08 16:18:42 +00:00
John Blackbourn
28f8566630 Improve the doing_it_wrong() text for title-tag theme support. 
Props ocean90
Fixes #18548


git-svn-id: https://develop.svn.wordpress.org/trunk@30787 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-08 16:05:34 +00:00
Scott Taylor
0b157bf069 Incorporate https://github.com/johndyer/mediaelement/pull/1385 into our custom build of MediaElement 2.16.2. 
Props bradyvercher.
Fixes #30281.


git-svn-id: https://develop.svn.wordpress.org/trunk@30783 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 23:58:46 +00:00
Andrew Ozz
c8e8281a05 Plugins: move the recommender results to a separate tab. Any outstanding quality issues will be fixed on the API side without needing core changes. Props tellyworth, fixes #30337. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30782 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 23:39:54 +00:00
Andrew Ozz
51272ff656 Twenty Fifteen: add spaces after screen reader text strings to make them readable. Props nvwd, pavelevap, afercia. Fixes #30606. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30781 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 23:27:42 +00:00
Andrew Ozz
8719a8a8b0 Media: ensure the toolbar is shown after leaving iframe-based content. Props mcsf, fixes #30608. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30780 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 21:11:23 +00:00
Drew Jaynes (DrewAPicture)
3913b26b24 Fix formatting in the DocBlock for wp_get_sidebars_widgets(). 
See #30315.


git-svn-id: https://develop.svn.wordpress.org/trunk@30779 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 20:14:10 +00:00
Drew Jaynes (DrewAPicture)
02f8434c28 Flesh out and fix formatting in the DocBlock for wp_register_widget_control(). 
Includes:
* Added todos for documenting `$options` in the hash notation style
* Backtick-escaping and general formatting

See #30315.


git-svn-id: https://develop.svn.wordpress.org/trunk@30778 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 20:12:50 +00:00
Scott Taylor
a0c600a121 When using the spacebar to select something in "bulk select" mode, don't scroll the page. 
Props avryl.
Fixes #30622.


git-svn-id: https://develop.svn.wordpress.org/trunk@30777 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 20:10:56 +00:00
Drew Jaynes (DrewAPicture)
292a65f737 Flesh out information in the DocBlock for wp_register_sidebar_widget(). 
Includes:
* Documenting the `$options` parameter in hash notation style
* Converting `@uses` tags to `@global`
* Various backtick-escaping.

See #30315.


git-svn-id: https://develop.svn.wordpress.org/trunk@30776 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 20:10:37 +00:00
Andrew Ozz
1a8c0b9254 TinyMCE: return focus to the editor after closing the image toolbar. Props afercia, see #27642. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30775 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 20:07:22 +00:00
Drew Jaynes (DrewAPicture)
3e0e0f453e Introduce documentation for three methods in WP_Widget_Factory: register(), unregister(), _register_widgets(). 
See #30315.


git-svn-id: https://develop.svn.wordpress.org/trunk@30774 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 20:07:05 +00:00
Drew Jaynes (DrewAPicture)
3c1a8e1407 Introduce documentation for the $id_base, $name, $widget_options, $control_options, $number, $id, and $updated properties in `WP_Widget'. 
See #30315.


git-svn-id: https://develop.svn.wordpress.org/trunk@30773 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 20:04:43 +00:00
Drew Jaynes (DrewAPicture)
ac47dd2cd0 Tweak formatting in the DocBlock for the install_themes_tabs hook. 
Props kpdesign.
See #28578.


git-svn-id: https://develop.svn.wordpress.org/trunk@30772 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 18:40:03 +00:00
Boone Gorges
98d17497d2 In WP_Query::get_queried_object(), use the new format for referencing tax query clauses. 
`queried_terms`, rather than `queries`, is the tax_query property where a flat
index of terms is stored.

See [29901] for a similar fix in `redirect_canonical()`. See #29738.

Props dd32.
Fixes #30623.

git-svn-id: https://develop.svn.wordpress.org/trunk@30771 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 14:57:53 +00:00
Drew Jaynes (DrewAPicture)
2f25ec0773 Document the default arguments for the_widget() in the hash notation style. 
Props coffee2code.
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@30770 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 11:03:51 +00:00
Drew Jaynes (DrewAPicture)
bf507bd3d0 Document the default arguments for register_sidebars() in the hash notation style. 
Props coffee2code.
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@30769 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 11:00:57 +00:00
Drew Jaynes (DrewAPicture)
a82a0df5f9 Improve inline documentation for wpdb::has_cap(). 
Adds a changelog entry for the addition of the 'utf8mb4' feature, accepted values for `$db_cap`, and a return description.

Props kpdesign.
See #21212.


git-svn-id: https://develop.svn.wordpress.org/trunk@30768 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 05:22:42 +00:00
Drew Jaynes (DrewAPicture)
2b8a662873 Fix a typo in the DocBlock for WP_Http_Curl::$bytes_written_total introduced in [29968]. 
Props kpdesign.
See #26726.


git-svn-id: https://develop.svn.wordpress.org/trunk@30767 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 05:15:50 +00:00
Dion Hulse
8a5ea24f61 In the links_add_base() callback, use a HTTP-aware URL joining function, rather than a filesystem joining function to avoid PHP warnings on certain systems. 
Fixes #29950


git-svn-id: https://develop.svn.wordpress.org/trunk@30766 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 03:18:06 +00:00
Dion Hulse
1a43dda77b WP_HTTP: Revert r30491 which updated the bundled root certificates. There's a report that this is breaking under certain PHP/OpenSSL versions (which we've encountered before), and we're safer with a slighty out of date CA bundle than breaking HTTPS communication on affected sites. 
See #30434


git-svn-id: https://develop.svn.wordpress.org/trunk@30765 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 03:12:14 +00:00
Andrew Ozz
549006887b Admin toolbar: remove unneeded overrides of z-index and left on screens narrower than 782px. Props avryl, babbardel. Fixes #29867. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30764 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 03:00:35 +00:00
Andrew Ozz
958fa3180d Twenty Fifteen: clean up of twentyfifteen_color_scheme_css_template() in customizer.php. Props iamtakashi. Fixes #30601. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30763 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 02:39:22 +00:00
Andrew Ozz
fce20e9784 Better docs for Plugin_Upgrader::deactivate_plugin_before_upgrade(). Props DrewAPicture. Fixes #29088. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30762 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 01:18:21 +00:00
Andrew Ozz
d948f0bf32 Always return a value in Plugin_Upgrader::deactivate_plugin_before_upgrade(). Props jdgrimes. Fixes #29088. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30761 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 00:52:06 +00:00
Andrew Ozz
af5c93a432 Customizer - Widgets: add feedback for screen readers when moving up or down. Props adamsilverstein, afercia. Fixes #28892. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30760 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 00:44:49 +00:00
Drew Jaynes (DrewAPicture)
ae45b7462b Restore missing line in DocBlock for WP_Tax_Query::get_sql_for_clause(). 
Props kpdesign.
See [30622], #30469.


git-svn-id: https://develop.svn.wordpress.org/trunk@30759 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 00:38:48 +00:00
Drew Jaynes (DrewAPicture)
3cdbc730d3 Add missing DocBlocks and parameter descriptions for a wide variety of properties and methods in WP_Upgrader, Plugin_Upgrader, Theme_Upgrader, Language_Pack_Upgrader, Core_Upgrader, and File_upload_Upgrader. 
Props jdgrimes, DrewAPicture.

See #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@30758 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 00:25:44 +00:00
Andrew Ozz
08021593f3 TinyMCE, improve accessibility: 
- Return focus to the editor on pressing Escape while the image toolbar is focused.
- Add a Close button to the Help modal and close it on Escape.
- Override the title on the editor iframe (read by screen reader apps), replace with the Alt+Shift+H shortcut.
- Add focus shortcuts descriptions to the Help modal.
Fixes #27642.

git-svn-id: https://develop.svn.wordpress.org/trunk@30757 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-06 23:52:25 +00:00
Drew Jaynes (DrewAPicture)
716984e94d Add a blank line preceding a Markdown-formatted ordered list in the DocBlock for the admin_body_class filter. 
Props kpdesign.
See #30558.


git-svn-id: https://develop.svn.wordpress.org/trunk@30756 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-06 23:20:12 +00:00