sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
31,339 Commits 2 Branches 473 Tags 137 MiB
Commit Graph

31339 Commits

Author SHA1 Message Date
Gary Pendergast 0b6454bac5 Readme: Update the recommended PHP version to 5.6. 
This also includes a unit test to ensure we're only recommending actively supported versions of PHP in the future.

Fixes #33758.



git-svn-id: https://develop.svn.wordpress.org/trunk@33937 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-07 05:22:03 +00:00
Dion Hulse 95b3edd4ce Cron: Reject events when the provided `$timestamp` is not a valid timestamp. 
Invalid timestamps were previously accepted by the scheduling functions but would never be run due to our implementation which caused the cron option to forever contain the events.
This rejects such events which most likely only occur due to developer error.

Props utkarshpatel, wonderboymusic, SergeyBiryukov.
See #33423, Fixes #33475


git-svn-id: https://develop.svn.wordpress.org/trunk@33936 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-07 02:38:12 +00:00
Dion Hulse 628440fe5d Favicon: Do not specify a `Content-Length: 0` header for our "empty" response to fail more gracefully on environments with extra whitespace on output. 
This allows for the web server to generate the appropriate `Content-Length` header for the request, allowing for strict clients/proxies/servers to process the response.

Props swissspidy.
Fixes #33626


git-svn-id: https://develop.svn.wordpress.org/trunk@33935 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-07 02:17:32 +00:00
Sergey Biryukov 8f2b90e299 Widgets: Don't display sidebar description container if it's empty. 
Props paulwilde.
Fixes #32448.

git-svn-id: https://develop.svn.wordpress.org/trunk@33934 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-06 07:59:01 +00:00
Sergey Biryukov 3853980a9a Merge two permission error strings. 
Props pavelevap.
Fixes #33745.

git-svn-id: https://develop.svn.wordpress.org/trunk@33933 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-06 06:41:58 +00:00
Sergey Biryukov 5d9dcf3d8a Correct description for `version` and `current_version` parameters in `wp_check_browser_version()` response. 
Props extendwings.
Fixes #33753.

git-svn-id: https://develop.svn.wordpress.org/trunk@33932 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-06 00:16:02 +00:00
Sergey Biryukov 4fb57210cd Update the parameter docs for `wp_add_post_tags()`, `wp_set_post_tags()`, and `wp_set_post_terms()`. 
Props johnbillion.
Fixes #33749.

git-svn-id: https://develop.svn.wordpress.org/trunk@33931 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-06 00:11:56 +00:00
Sergey Biryukov 8512ff08c0 Correct the docblock for `wp_list_widget_controls()`. 
Props swissspidy.
Fixes #33751.

git-svn-id: https://develop.svn.wordpress.org/trunk@33930 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 23:37:17 +00:00
John Blackbourn 547742f14a Remove the 'Site Admin' link from the Meta widget if the user doesn't have access to the admin area. 
See #25162


git-svn-id: https://develop.svn.wordpress.org/trunk@33929 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 23:24:06 +00:00
Sergey Biryukov 038a2c3b7a List tables: Adjust the styles for checkbox column to align better with longer column names. 
Props swissspidy.
Fixes #32825.

git-svn-id: https://develop.svn.wordpress.org/trunk@33928 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 23:15:57 +00:00
John Blackbourn 07861df743 Introduce a new `$is_edge` global for the Microsoft Edge browser. 
The `$is_IE` and `$is_chrome` globals no longer return `true` for Edge, which is expected as Edge is its own browser and should not be treated like IE. While it might be beneficial for Edge to be treated like Chrome on the client side, it benefits nobody for the `$is_chrome` global to return true.

See #33193
Props gregrickaby, johnbillion


git-svn-id: https://develop.svn.wordpress.org/trunk@33927 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 22:33:01 +00:00
Scott Taylor 2d68434dff After [33925], rename the unit test class to `Tests_Comment_Meta_Cache` to avoid collisions on the PHP 5.2 superhighway. 
See #16894.


git-svn-id: https://develop.svn.wordpress.org/trunk@33926 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 22:29:59 +00:00
Scott Taylor 542ac152fc In `wp_list_comments()`, update the comment meta cache when the comments derive from `WP_Query` and the new `->comment_meta_cached` prop is `false`. 
There are no uses of `wp_list_comments()` in Core where `$comments` are passed as the 2nd argument.

Adds unit tests.

Props wonderboymusic, bradt.
Fixes #16894.


git-svn-id: https://develop.svn.wordpress.org/trunk@33925 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 22:24:16 +00:00
John Blackbourn 43340fe787 When a user with no role logs in, redirect them to the home page rather than their profile screen which they do not have access to. 
See #25162


git-svn-id: https://develop.svn.wordpress.org/trunk@33924 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 21:34:01 +00:00
John Blackbourn dd9722fac0 Bail out early from `esc_url()` if the URL becomes empty after stripping out disallowed characters. 
Fixes #28015
Props jesin for the unit test


git-svn-id: https://develop.svn.wordpress.org/trunk@33923 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 21:28:50 +00:00
John Blackbourn 6bfd06d5c8 Function docs for the `tax_input` and `meta_input` parameters available for `wp_insert_post()`. 
See #20451


git-svn-id: https://develop.svn.wordpress.org/trunk@33922 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 21:01:37 +00:00
Jeremy Felt 6b5e1e8c9b Multisite: Update help tab text for `site-info.php` to reference "site URL". 
In [32759] and [33586], we combined the domain and path entry for a site to a single "Site URL" field. This updates the help text to reflect that.

Fixes #33748. See #22383.


git-svn-id: https://develop.svn.wordpress.org/trunk@33921 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:52:52 +00:00
John Blackbourn 38fe3c4db5 Implement a language chooser on the Network Admin -> Sites -> Add New screen. 
Props DrewAPicture
Fixes #33528


git-svn-id: https://develop.svn.wordpress.org/trunk@33920 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:47:00 +00:00
Sergey Biryukov f8f8de0ecf Merge two strings in `Walker_Comment::comment()` and `Walker_Comment::html5_comment()`. 
Props pavelevap.
Fixes #33744.

git-svn-id: https://develop.svn.wordpress.org/trunk@33919 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:45:13 +00:00
Jeremy Felt d77b6f99c6 Multisite: Pass the ID of the site being updated to `wpmu_update_blog_options` action. 
Props @swissspidy, @MikeHansenMe.
Fixes #32907.


git-svn-id: https://develop.svn.wordpress.org/trunk@33918 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:38:27 +00:00
Scott Taylor 1adb9643d9 Bump H3 headings to H2 on the {Term} screens for better accessibility. 
Props mrahmadawais.
Fixes #33658.


git-svn-id: https://develop.svn.wordpress.org/trunk@33917 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:16:17 +00:00
Scott Taylor 31663c6782 Bump H3 headings to H2 on the Discussion Settings screen for better accessibility. 
Props mrahmadawais.
Fixes #33609.


git-svn-id: https://develop.svn.wordpress.org/trunk@33916 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:14:00 +00:00
Scott Taylor 3484a266a1 Bump H3 headings to H2 on the Media Settings screen for better accessibility. 
Props metodiew.
Fixes #33610.


git-svn-id: https://develop.svn.wordpress.org/trunk@33915 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:11:24 +00:00
Scott Taylor 32d296fb6a Bump H3 headings to H2 on Export screen for better accessibility. 
Props metodiew.
Fixes #33608.


git-svn-id: https://develop.svn.wordpress.org/trunk@33914 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:08:29 +00:00
Scott Taylor 23f2e79350 Correct the param docs for `comment_guid()` and `get_comment_guid()`. 
Props dimadin.
Fixes #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@33913 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 19:59:10 +00:00
Scott Taylor b8e30f3ec7 Dashicons CSS: one-word font families don't need quotes. Font families with a space in the name should use double-quotes (doesn't apply here). 
Props afercia.
Fixes #32866.


git-svn-id: https://develop.svn.wordpress.org/trunk@33912 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 19:56:15 +00:00
Scott Taylor 38038ccba3 Add Customizer docs. 
Props ericlewis.
See #33503.


git-svn-id: https://develop.svn.wordpress.org/trunk@33911 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 19:52:17 +00:00
Scott Taylor 26dd8b5b08 Allow `wp_insert_post()` to accept a `meta_input` argument. Devs should use `register_meta()` to ensure that specific values specified by key are sanitized properly. 
Adds unit test.

Props CoenJacobs, swissspidy.
Fixes #20451.


git-svn-id: https://develop.svn.wordpress.org/trunk@33910 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 19:49:53 +00:00
Andrea Fercia 7b3b1c12d5 Accessibility: bump H3 headings to H2 on User Edit and Your Profile screens. 
Ongoing effort to restore a good headings hierarchy in the admin screens after the reintroduction of the missing main `<h1>` in [32974].

Fix a typo in the DocBlock for the `additional_capabilities_display` filter.

Props metodiew.
Fixes #33606. See #31650.

git-svn-id: https://develop.svn.wordpress.org/trunk@33909 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 18:29:40 +00:00
Sergey Biryukov 36ed764d60 Fix closing div in `wp_print_request_filesystem_credentials_modal()`. 
Props trepmal.
Fixes #33737.

git-svn-id: https://develop.svn.wordpress.org/trunk@33908 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 15:16:15 +00:00
Sergey Biryukov dde7dc7145 Update `Tests_Sanitize_Option::test_sanitize_option()` after [33858]. 
See #23605.

git-svn-id: https://develop.svn.wordpress.org/trunk@33907 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 14:17:24 +00:00
Sergey Biryukov b0d3f5922e Update `Tests_Admin_includesPlugin::test_menu_page_url()` after [33858]. 
See #23605.

git-svn-id: https://develop.svn.wordpress.org/trunk@33906 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 14:15:51 +00:00
Sergey Biryukov b09823a1d3 Update `Tests_Formatting_GetUrlInContent::get_input_output()` after [33858]. 
Props gitlost.
Fixes #23605.

git-svn-id: https://develop.svn.wordpress.org/trunk@33905 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 14:05:05 +00:00
Boone Gorges 3fba46b557 Allow `wp_terms_checklist()` to return markup rather than echoing it. 
Props kevinlangleyjr.
Fixes #33720.

git-svn-id: https://develop.svn.wordpress.org/trunk@33904 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 21:24:04 +00:00
Boone Gorges 9dfc5551ee In `get_terms()`, allow terms to be ordered by 'term_id'. 
[29128] introduced updated documentation for the `'orderby'` parameter of
`get_terms()`. The new documentation mistakenly said that 'term_id' was a valid
orderby value. The current changeset makes that fantasy...A REALITY.

Props ixkaito.
Fixes #33726.

git-svn-id: https://develop.svn.wordpress.org/trunk@33903 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 21:16:11 +00:00
Sergey Biryukov dfceba6d05 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/js/customize-controls.js`. 
fixes #33685. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33902 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 03:39:33 +00:00
Drew Jaynes 9f5b896fac Docs: Clarify the file header summary for wp-includes/rewrite-constants.php, introduced in [33751]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33901 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 01:51:08 +00:00
Drew Jaynes a767e01f17 Docs: Clarify the file header summary for wp-includes/comment.php, the top-level file for the core Comments API. 
Also adds inline DocBlock for the `require_once()` calls that now bring in the `WP_Comment` and `WP_Comment_Query` classes, as well as core comments functionality.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33900 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 01:46:29 +00:00
Drew Jaynes 3abc0933bb Docs: Clarify the file header summary for wp-includes/comment-functions.php, introduced in [33750]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33899 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 01:41:17 +00:00
Drew Jaynes d615705cec Docs: Add a missing file header for wp-includes/class-wp-comment-query.php, introduced in [33750]. 
Also clarifies the class DocBlock summary and tags for `WP_Comment_Query`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33898 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 01:37:23 +00:00
Drew Jaynes 8cc0808e3b Docs: Clarify the file header summary for wp-includes/user.php, the top-level file for the core Users API. 
Also adds inline DocBlocks for the `require_once()` calls that now bring in core users functionality and the `WP_User_Query` class, as of [33749].

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33897 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 01:32:59 +00:00
Drew Jaynes 68f62a46e5 Docs: Clarify the file header summary for wp-includes/user-functions.php, introduced in [33749]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33896 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 01:28:10 +00:00
Drew Jaynes 8b3693c9e0 Docs: Add a missing file header for wp-includes/class-wp-user-query.php, introduced in [33749]. 
Also clarifies the class DocBlock summary for `WP_User_Query` to better describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33895 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 01:25:56 +00:00
Scott Taylor 43c8ec5f32 Handle more cases (`untrailingslashit`, HTTPS urls) for sanitizing an author URL for display in the comments list table. 
Props afercia, mehulkaklotar, swissspidy, johnbillion.
Fixes #33291.


git-svn-id: https://develop.svn.wordpress.org/trunk@33894 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 23:22:32 +00:00
Drew Jaynes 46af2b9cd9 Docs: Add complete file, class, property, and method documentation for the new `WP_Comment` class, introduced in [33891]. 
It's important for new functionality, especially something as significant as a new class to have complete documentation upon initial commit – not after the fact.

See #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@33893 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 19:57:15 +00:00
Sergey Biryukov 2487080654 Add missing translation functions to the error messages added in [33889]. 
props kraftbj, GaryJ.
fixes #33684.

git-svn-id: https://develop.svn.wordpress.org/trunk@33892 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 18:36:22 +00:00
Scott Taylor 60ba8b05e4 Introduce `WP_Comment` class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity. 
* Takes inspiration from `WP_Post` and adds sanity to comment caching. 
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now

Props wonderboymusic, nacin.

See #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@33891 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 18:16:35 +00:00
Helen Hou-Sandi 52f31a77e9 UI: Restrict textarea resizing to vertical to prevent ugliness. 
props tyxla, MatheusFD.
fixes #33400.


git-svn-id: https://develop.svn.wordpress.org/trunk@33890 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 18:04:27 +00:00
Sergey Biryukov 71d4444ac7 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-includes/class-wp-customize-manager.php`. 
props kraftbj.
fixes #33684. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33889 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 09:20:40 +00:00
Sergey Biryukov 55bb26c58a Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/network/site-users.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33683. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33888 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 09:02:13 +00:00