Commit Graph

33837 Commits

Author SHA1 Message Date
Drew Jaynes
6012464446 Docs: Add a missing @since version to the DocBlock for wp_add_dashboard_widget().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36878 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 22:16:56 +00:00
Andrea Fercia
d92e10fbb1 Customizer: Improve the collapsed view when switching to the responsive view.
Props rittesh.patel, afercia.

Fixes #35220.

git-svn-id: https://develop.svn.wordpress.org/trunk@36877 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 22:04:29 +00:00
Pascal Birchler
bae3fb43a5 Embeds: Add support for embeds in the theme template hierarchy.
This allows themes to directly override the default template. The order in which the template is retrieved is as follows: `embed-$post_type-$post_format.php` -> `embed-$post_type.php` -> `embed.php`.

The `embed_template` filter gets replaced by the dynamic `{$type}_template` filter in `get_query_template()`.

Props ChriCo, swissspidy.
See #34561. Fixes #34278.

git-svn-id: https://develop.svn.wordpress.org/trunk@36876 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 19:33:01 +00:00
Konstantin Obenland
ae79b4f91f Bundled Themes: Prevent elements within fieldsets from overflowing in Webkit.
Fixes #35421.


git-svn-id: https://develop.svn.wordpress.org/trunk@36875 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 19:14:05 +00:00
Pascal Birchler
3a51ff4d2e Taxonomy: Improve backward compatibility on the wp-admin/term.php page.
Specifically, run `do_action( 'edit-tags.php' );` on this new term edit page introduced in [36308]. Changes the GET param back to `tag_ID` and properly sets the screen base in `WP_Screen`.

See #34988.

git-svn-id: https://develop.svn.wordpress.org/trunk@36874 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 12:55:04 +00:00
Pascal Birchler
afdf1c9ec1 Embeds: Adjust the iframe title attribute for improved accessibility.
Changes the title attribute from `Embedded WordPress Post` to `"Post name" — site title`.

Props ramiy.
Fixes #35804.

git-svn-id: https://develop.svn.wordpress.org/trunk@36873 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 09:59:02 +00:00
Dion Hulse
e9dbf32553 Setup config: Generate the default secret keys & salts from the local CSPRNG if available, falling back to the WordPress.org API and a backup psuedo random source.
Props diddledan.
Fixes #35290


git-svn-id: https://develop.svn.wordpress.org/trunk@36872 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-07 06:31:18 +00:00
Dominik Schilling (ocean90)
00e87b40c8 Dependencies: Improve group processing of script dependencies.
This is a follow-up to [36604].

When processing dependencies `$this->group` will be the minimum of the script's registered group and all preceding siblings. This is wrong because only a scripts ancestors in the dependency chain should affect where it is loaded. Effectively `$this->group` introduced a form of global state which potentially corrupted the group of dependencies. Sorting covers up this problem.
The issue in #35873 was that script were not moving their dependencies to a lower group when necessary.

The fix:
* In `WP_Dependencies::all_deps()` pass the new `$group` value to `WP_Dependencies::all_deps()`. Previously the wrong value was passed because the parent script could have moved with `WP_Scripts::set_group()`.
* In `WP_Scripts::all_deps()` pass the `$group` parameter to `WP_Dependencies::all_deps()` so it doesn't always use `false` for `$group`. Same for `WP_Styles::all_deps()`.

Props stephenharris, gitlost.
Fixes #35956.

git-svn-id: https://develop.svn.wordpress.org/trunk@36871 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-06 19:49:54 +00:00
Pascal Birchler
92bdac8474 HTTP: Avoid an undefined index notice in wp_http_validate_url().
Props perezlabs.
Fixes #34164.

git-svn-id: https://develop.svn.wordpress.org/trunk@36870 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-06 15:54:13 +00:00
Andrea Fercia
b723d3fb75 CSS: Rename the handle for deprecated-media.css after [36341].
The `media` handle is now used for `media.css` thus the stylesheet
for the old media UI needs a different handle name.

See #35229.

git-svn-id: https://develop.svn.wordpress.org/trunk@36869 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-06 15:37:25 +00:00
Sergey Biryukov
74da332c40 Docs: Add wp_add_dashboard_widget() parameter descriptions.
Props meitar for initial patch.
Fixes #36092.

git-svn-id: https://develop.svn.wordpress.org/trunk@36868 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-06 12:07:34 +00:00
Jeremy Felt
e3feb63e33 Multisite: Handle redirect to a user's subdomain properly during login
`wp-login.php` uses `wp_safe_redirect()` for all redirects, even those that do not involve unsafe data from the request or referer.

When a user of a subdomain site attempts to login to a network site they do not have access to, the host in the redirect URL is treated as unsafe by `wp_safe_redirect()` as it has no immediate awareness as to which hosts are valid on the network. On a subdirectoy network, everything works as expected because the host is the same.

In this specific block of `wp-login.php`, all URLs are generated by WordPress and we can use `wp_redirect()` to handle the redirects. Users authenticating via other network sites will now be redirected properly. Hosts passed via the `redirect_to` query var will continue to be handled by `wp_safe_redirect()`.

Fixes #30598.


git-svn-id: https://develop.svn.wordpress.org/trunk@36867 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-06 03:05:46 +00:00
Weston Ruter
52d50a6ce9 Customize: Fix image cropping when doing live preview of theme switches.
Ensure that the Customizer gets bootstrapped with the pre-activated `theme` supplied in the `custom-header-crop` admin ajax requests.

Props faishal, rittesh.patel.
Fixes #32783.


git-svn-id: https://develop.svn.wordpress.org/trunk@36866 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-06 01:44:53 +00:00
Aaron Jorbin
6d01e8650c Update grunt-contrib-cssmin ~0.14.0 → ~1.0.0
See #35104.


git-svn-id: https://develop.svn.wordpress.org/trunk@36865 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 23:36:36 +00:00
Aaron Jorbin
366dab5560 Update grunt-contrib-copy ~0.8.2 → ~1.0.0
See #35104.


git-svn-id: https://develop.svn.wordpress.org/trunk@36864 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 23:34:11 +00:00
Aaron Jorbin
a1d75ea8e4 Update grunt-contrib-concat ~0.5.1 → ~1.0.0
see #35104


git-svn-id: https://develop.svn.wordpress.org/trunk@36863 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 23:31:16 +00:00
Aaron Jorbin
9973cb2cc7 Update grunt-contrib-compress ~0.14.0 → ~1.1.0
See #35104


git-svn-id: https://develop.svn.wordpress.org/trunk@36862 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 23:24:23 +00:00
Aaron Jorbin
a0a26df25f Update grunt-contrib-clean from 0.6.0 → 1.0.0
see #35104


git-svn-id: https://develop.svn.wordpress.org/trunk@36861 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 23:18:39 +00:00
Aaron Jorbin
cf923b657f Update Autoprefixer to 6.3.3
See #35104


git-svn-id: https://develop.svn.wordpress.org/trunk@36860 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 23:15:52 +00:00
Aaron Jorbin
4af0645ae8 Ensure Description is respected in post type archive menu items.
Tested scenarios include: using the default (which is the post type description), Setting a custom description for that individual menu item, and setting a custom description that is blank. Introduced in r35382.

Props Toro_Unit, mayukojpn, extendwings, jorbin.
Fixes #35324. See #16075.



git-svn-id: https://develop.svn.wordpress.org/trunk@36859 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 22:56:31 +00:00
Dominik Schilling (ocean90)
e5556666cc Themes: Bring the device preview from [31195] to the theme install previewer.
Props celloexpressions.
Fixes #36017.

git-svn-id: https://develop.svn.wordpress.org/trunk@36858 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 22:06:57 +00:00
Andrew Ozz
25838b4c23 TinyMCE:
- Fix the icon for the native dialogs close button.
- Highlight the button on :focus.

See #36035.

git-svn-id: https://develop.svn.wordpress.org/trunk@36857 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 22:00:45 +00:00
Aaron Jorbin
57d8c6668a Fix License test
Broken in r36855

Fixes #35278



git-svn-id: https://develop.svn.wordpress.org/trunk@36856 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 20:21:23 +00:00
Aaron Jorbin
cdd3d5f318 Clarify Copyright year
Based on http://copyright.gov/title17/92chap4.html#401 and being more consistent with the rest of the document.

See also https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/

Fixes #35278


git-svn-id: https://develop.svn.wordpress.org/trunk@36855 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 20:13:35 +00:00
ericlewis
59c8ba7871 Build/Test Tools: Document PHP unit test classes.
Props boonebgorges.
Fixes #35494.


git-svn-id: https://develop.svn.wordpress.org/trunk@36854 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 19:47:41 +00:00
John Blackbourn
48959ec76e Posts, Post Types: Ensure that non-ASCII characters in attachment slugs aren't shown in urlencoded form in the sample permalink UI.
Fixes #35980


git-svn-id: https://develop.svn.wordpress.org/trunk@36853 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 03:55:33 +00:00
Eric Andrew Lewis
ae1c49027a Menus: Ensure theme location setting data is saved with a large menu.
[36510] introduced a fix to allow users to save large menus on the Edit Menu screen (70+ menu items). The form data is stored as JSON which is used to inject the `$_POST` variable in the form submission handler. This injection was not setting form items with named array elements properly (e.g. `menu-locations[primary]`), which did not save theme location data in a large form.

Props keraweb.
See #14134.


git-svn-id: https://develop.svn.wordpress.org/trunk@36852 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-05 00:46:45 +00:00
Weston Ruter
084772af80 Customize: Eliminate unnecessary WP_Customize_Site_Logo_Control in favor of re-using WP_Customize_Image_Control.
* Removes double `margin-bottom` from all the media controls.
* All media controls now send `{settingId}-attachment-data` messages to the preview when a media setting is updated so that the preview has access to the attachment data.
* Fixes receiving of `attachment-data` message for `custom_logo` which resulted in instant JS-applied preview not working. See #36096.

See #33755.
Fixes #35941.


git-svn-id: https://develop.svn.wordpress.org/trunk@36851 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 23:46:07 +00:00
Dominik Schilling (ocean90)
d9c9742527 I18N: Fix an invalid placeholder added in [36844].
See #36048.

git-svn-id: https://develop.svn.wordpress.org/trunk@36850 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 21:09:31 +00:00
Andrew Ozz
b0865cdcd0 TinyMCE, inline link: add styling for the dialog and UI Autocomplete to Press This.
See #33301.

git-svn-id: https://develop.svn.wordpress.org/trunk@36849 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 20:30:49 +00:00
Andrew Ozz
a9810a6287 Pres This:
- Change the newly added `press_this_save_post_content` filter to `press_this_save_post` and pass the $post_data array to it.
- Remove the newly added `press_this_useful_html_elements`. It only runs in compatibility mode when a URL is typed by the user.
- Remove the `press_this_suggested_content` filter. It is redundant as the suggested HTML for the editor is already filtered by `press_this_suggested_html`.
- Add some more inline docs and rename couple of vars to make the code more readable.

Fixes #34455.

git-svn-id: https://develop.svn.wordpress.org/trunk@36848 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 18:55:23 +00:00
Drew Jaynes
04d3748efa Docs: Improve DocBlock syntax and add a missing @return notation for WP_Image_Editor_Imagick::strip_meta(), introduced in [36700].
See: #33642, #30402, #28634. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36847 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 17:36:10 +00:00
Drew Jaynes
1dfbf0fb1b Docs: Improve the hook doc summary for the image_strip_meta filter, introduced in [36700].
See: #33642, #30402, #28634. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36846 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 17:32:35 +00:00
Sergey Biryukov
d8f72707d2 I18N: Move the aria-label text in get_theme_update_available() to a separate string for easier translation.
Add translator comments.

Props ramiy.
Fixes #36048.

git-svn-id: https://develop.svn.wordpress.org/trunk@36845 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 11:11:03 +00:00
Sergey Biryukov
9c39e27fde I18N: Move the aria-label text in wp_plugin_update_row() and wp_theme_update_row() to a separate string for easier translation.
Add translator comments.

Props ramiy.
See #36048.

git-svn-id: https://develop.svn.wordpress.org/trunk@36844 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 11:07:29 +00:00
Sergey Biryukov
fb7ada9e9a Comment out some CSS files in $_old_files that were added back as a result of [36341].
Add a unit test to make sure the `$_old_files` array does not contain any current project files.

Props joemcgill, swissspidy.
Fixes #36083.

git-svn-id: https://develop.svn.wordpress.org/trunk@36843 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 07:55:21 +00:00
Drew Jaynes
43399f4ff7 Docs: Improve syntax and correct documentation throughout a variety of methods in WP_Customize_Widgets.
See #32246. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36842 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 02:01:15 +00:00
Drew Jaynes
a9cce93ff2 Docs: Improve documentation for WP_Customize_Widgets::customize_dynamic_partial_args(), introduced in [36586].
See #27355. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36841 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 01:44:19 +00:00
Drew Jaynes
9775eef208 Docs: Remove an errant period following the @access tag in the DocBlock for wpdb::close(), mistakenly introduced in [36493].
Props markoheijnen.
See #34903. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36840 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-04 00:02:56 +00:00
Konstantin Obenland
1134b18c6e Customize: Don't show custom image sizes in the media modal.
Custom image sizes for logos should only be used for their intended purpose.

See #33755.


git-svn-id: https://develop.svn.wordpress.org/trunk@36839 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 21:44:26 +00:00
Konstantin Obenland
cf863ab2a8 Customize: Rename custom logo classes after [36837].
Fixes #35945.


git-svn-id: https://develop.svn.wordpress.org/trunk@36838 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 19:58:37 +00:00
Konstantin Obenland
43ff969765 Customize: Site logos are custom logos.
Brings the nomenclature closer to custom headers and backgrounds.

See https://wordpress.slack.com/archives/core/p1456955151003150
See #35945. 


git-svn-id: https://develop.svn.wordpress.org/trunk@36837 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 19:55:15 +00:00
Drew Jaynes
2d64d06594 Docs: Improve DocBlock syntax for WP_Customize_Nav_Menus::customize_dynamic_partial_args(), introduced in [36586].
See #27355. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36836 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 16:06:41 +00:00
Drew Jaynes
9c74b86880 Docs: Improve documentation for WP_Customize_Nav_Menus::filter_nonces(), introduced in [36414].
See #27355, #35617. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36835 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 16:04:43 +00:00
Drew Jaynes
c4ab9aeda8 Docs: Standardize the changelog entry for the new $author_url argument, introduced in [36224].
See #35377. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36834 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 16:01:41 +00:00
Drew Jaynes
8424db5879 Docs: Improve the DocBlock summary and add a missing initial @since version for WP_Admin_Bar::add_node().
See #32246. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36833 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 15:57:46 +00:00
Sergey Biryukov
95f12701fb Date/Time: Add a unit test for mysql_to_rfc3339().
Props borgesbruno.
Fixes #36054.

git-svn-id: https://develop.svn.wordpress.org/trunk@36832 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 13:16:31 +00:00
Joe Hoyle
fc0ed5e1ca REST API: Unit test for OPTIONS request should call rest_send_allow_header
In [36829] we moved this logic to rest_send_allow_header()

See #36829.


git-svn-id: https://develop.svn.wordpress.org/trunk@36831 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 11:37:48 +00:00
Sergey Biryukov
090e49fe74 Docs: Correct $plugins global type in WP_Plugins_List_Table::prepare_items().
Props mt8.biz.
Fixes #36080.

git-svn-id: https://develop.svn.wordpress.org/trunk@36830 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 10:00:40 +00:00
Joe Hoyle
b38ea44e9a OPTIONS requests to REST API should return Allow header.
An OPTIONS request was incorrectly returning an "Accept" header which
was a typo of "Allow". This meant Accept was showing "GET, POST" for example,
however it was also not running the permission checks on the endpoints.

Instead, the correct route needs to be set on the request object, which means
the normal handling for the Allow header will kick in. This technically
breaks backwards compatibility, however given the value of Accept was also wrong
then this should not be an issue.

Fixes #35975.


git-svn-id: https://develop.svn.wordpress.org/trunk@36829 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-03 09:54:32 +00:00