Commit Graph

2100 Commits

Author SHA1 Message Date
Andrew Ozz
d4946a7904 Editor:
- Add CSS reset for the TinyMCE fullscreen mode when used on the Edit Post screen.
- Fix loading of the old and new DFW buttons, use another arg. passed to WP_Editors.
- Reset editor-expand when exiting TinyMCE fullscreen mode.
Fixes #30453.

git-svn-id: https://develop.svn.wordpress.org/trunk@30573 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-26 02:49:41 +00:00
Andrew Ozz
9185f64f20 TwentyFifteen:
- Fix image caption alignment in the editor.
- Remove unused var from functions.js.
Also includes few images that were shrunk a bit when running grunt precommit.
Fixes #30493.

git-svn-id: https://develop.svn.wordpress.org/trunk@30562 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-25 06:11:02 +00:00
Dominik Schilling (ocean90)
3ebd474750 Improve the focus style for review links in the plugin info modal.
props johnbillion.
fixes #30375.

git-svn-id: https://develop.svn.wordpress.org/trunk@30555 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 22:58:12 +00:00
Dominik Schilling (ocean90)
f38be98c89 Clear update caches when site language is changed.
The update screen has a re-install button which could show the wrong language locale after the site language was changed. That's because the update data is cached. 
Introduce `_wp_clear_update_cache()` as a helper function to clean up the update cache.

props SergeyBiryukov, ocean90.
fixes #30369.

git-svn-id: https://develop.svn.wordpress.org/trunk@30554 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 22:49:13 +00:00
Dominik Schilling (ocean90)
ea4528dc43 Customizer: Don't override Section.isContextuallyActive() in SidebarSection.
This fixes a bug where empty widget areas get deactivated in the Customizer.

fixes #30378.
see #30235.
props westonruter.

git-svn-id: https://develop.svn.wordpress.org/trunk@30552 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 22:25:30 +00:00
Dominik Schilling (ocean90)
09f6d69f5a Update the Iris color picker to version 1.0.6.
Changes: https://github.com/Automattic/Iris/compare/1.0.4...1.0.6

props mattwiebe.
fixes #30365.

git-svn-id: https://develop.svn.wordpress.org/trunk@30551 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 22:16:39 +00:00
Drew Jaynes (DrewAPicture)
a22e8b5354 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Backtick-escape code snippets in the description for `get_object_taxonomies()`
* Backtick-escape inline code in a markdown-formatted unordered list in the description for `get_taxonomy_labels()`
* Remove an HTML tag from the summary for the `Walker_Category_Checklist` class
* Remove an HTML tag from the summary for `wp_category_checklist()`, various formatting
* Remove an HTML tag from the summary for `wp_terms_checklist()`
* Backtick-escape an HTML tag in the description for `wp_popular_terms_checklist()`
* Remove HTML tags from the summaries for `page_template_dropdown()`, `parent_dropdown()`, and `wp_dropdown_roles()`
* Backtick-escape HTML tags in a parameter description for `add_settings_error()`
* Various formatting in the description and summary for `settings_errors()`
* Markdown-indent code snippets in the descriptions for `wpdb::prepare()`, `wpdb::insert()`, `wpdb::replace()`, `wpdb::update()`, and `wpdb::delete()`
* Backtick-escape an HTML tag in a parameter description for `login_header()`
* Remove HTML tags from the summaries for the `lostpassword_form` and `signup_header` hooks

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30546 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 06:30:19 +00:00
Drew Jaynes (DrewAPicture)
5f574c7ec8 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the description for `wp_salt()`
* Backtick-escape inline code in the return description for `get_avatar()`
* Various markdown formatting in the description for `add_filter()`
* Markdown-indent a code snippet in the description for `apply_filters()`
* Backtick-escape inline code in the `@see` description for `apply_filters_ref_array()`
* Backtick-escape inline code in the description for `do_action()`
* Backtick-escape variables in the parameter and return descriptions for `do_action_ref_array()`
* Various markdown formatting in the description for `get_plugin_data()`

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30544 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 06:04:10 +00:00
Drew Jaynes (DrewAPicture)
6007c0c17d Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Backtick-escape an HTML tag in the description for the `media_upload_mime_type_links()` hook
* Backtick-escape inline code in the description for `wp_get_active_network_plugins()`
* Remove HTML tags from the summaries for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks
* Backtick-escape HTML tags, add inline `@see` tags to parameter descriptions for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30543 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 05:52:45 +00:00
Drew Jaynes (DrewAPicture)
9a9489db7f Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the file header for wp-admin/install-helper.php
* Add markdown formatting and two inline `@see` tags to the description for `translate()`
* Markdown-indent a code snippet in the description for `_n_noop()`
* Remove HTML tags from the summary for `get_media_embedded_in_content()`
* Remove an HTML tag from the summary for `wpview_media_sandbox_styles()`

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30542 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 05:46:04 +00:00
Drew Jaynes (DrewAPicture)
d93bfdce56 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the description for `_deprecated_argument()`
* Markdown-indent a code snippet in the description for `wp_localize_script()`
* Backtick-escape HTML tags in two parameter descriptions for `wp_register()`
* Various DocBlock formatting in the description for `get_bloginfo()`
* Remove HTML tag from the summary for `_wp_render_title_tag()`
* Backtick-escape a HTML tag in the description for `get_archives_link()`
* Markdown-indent a code snippet in the description for `wp_admin_css_color()`
* Markdown-indent a code snippet in the description for the `welcome_panel` hook

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30541 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 05:38:44 +00:00
Drew Jaynes (DrewAPicture)
2d064e1b86 Ensure the DocBlock directly precedes the hook line for the post_edit_form_tag action in wp-admin/edit-form-advanced.php.
This fixes the parser getting confused about which DocBlock belongs to which hook or function in this file.

See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30539 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 05:21:56 +00:00
Drew Jaynes (DrewAPicture)
ad50389634 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Remove HTML tag from parameter description in `comment_form()`
* Remove HTML tag from a summary for the `comment_form_top` hook
* Markdown-indent a code snippet in the description for `get_linkobjectsbyname()`
* Markdown-indent a code snippet and format an unordered list in the description for `get_linkobjects()`
* Backtick-escape some inline code in the description for `clean_pre()`
* Remove HTML tag from the summary for the `rss_tag_pre` hook
* Various formatting fixes in the descriptions for `get_filesystem_method()` and `request_filesystem_credentials()`

Props rarst for the initial patch.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30538 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 05:18:56 +00:00
Drew Jaynes (DrewAPicture)
ccc5f88887 Ensure inline code is markdown-escaped as such, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Backtick-escapes a `<link>` tag in a parameter description for the `embed_oembed_discover` hook
* Inline code fixes in the summary and return description for `WP_List_Table::get_table_classes()`
* Removes HTML markup from the summary for `WP_List_Table::display_rows_or_placeholder()`
* Backtick-escapes a `<tr>` tag in a parameter description for `WP_Users_List_Table::single_row()`
* Converts non-DocBlocks into multi-line comments in `WP_Dependencies::do_items()`
* Removes HTML markup from the summary for the `comment_form_top` hook.
* Inline code and snippet fixes in the description for `wp_get_schedules()`

Props rarst for the initial patch.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30537 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 04:57:17 +00:00
Drew Jaynes (DrewAPicture)
f50cafce29 Remove HTML <head> tags from DocBlock summaries in wp-admin/admin-header.php.
Also better-specify the `$hook_suffix` value in the `admin_head-$hook_suffix` hook docs per hook documentation precedent.

Props rarst for the initial patch.
See #30473


git-svn-id: https://develop.svn.wordpress.org/trunk@30535 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 04:26:16 +00:00
Andrew Ozz
4140cf6a46 Color Schemes: fix the pointer UP arrow color, fixes #30460.
git-svn-id: https://develop.svn.wordpress.org/trunk@30531 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-23 01:25:14 +00:00
John Blackbourn
577e78f7c0 Abstract the theme browser route paths into attributes so they can be easily overridden.
Fixes #30116
Props matveb


git-svn-id: https://develop.svn.wordpress.org/trunk@30508 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 17:30:00 +00:00
Helen Hou-Sandi
a8821f6b57 Admin notices: Add more variety and make more generically usable.
There is now a base class of `notice`, with additional classes of `notice-success`, `notice-warning`, `notice-error`, and a new blue `notice-info`.

Also corrects some misleading notice colors, such as plugin tested up to warnings and login messages.

props avryl, melchoyce.
fixes #27418.


git-svn-id: https://develop.svn.wordpress.org/trunk@30505 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 16:40:29 +00:00
Helen Hou-Sandi
a42d9584e9 Sessions UI: Ensure screen readers provide feedback on action taken.
Also fixes some invalid HTML that occurs on DOM changes.

props joedolson.
fixes #30364.


git-svn-id: https://develop.svn.wordpress.org/trunk@30504 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 16:24:23 +00:00
Drew Jaynes (DrewAPicture)
1c3fb4f442 Convert <title> to "title tag" in the DocBlock summary for the admin_title hook.
Fixes #30437.


git-svn-id: https://develop.svn.wordpress.org/trunk@30502 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 07:11:14 +00:00
Sergey Biryukov
5f1c87f271 Set min-height for menu item title. Add a fallback for empty-titled items.
props philiparthurmoore.
fixes #30283.

git-svn-id: https://develop.svn.wordpress.org/trunk@30500 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 05:56:23 +00:00
Drew Jaynes (DrewAPicture)
3d2da1bf74 Minor syntactical adjustments to the inline documentation for the revision_text_diff_options hook.
Converts backticked-inline-code to inline `@see` tags (for the full benefit of Code Reference automagical behavior).

See [30396]. See #24908.


git-svn-id: https://develop.svn.wordpress.org/trunk@30497 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 03:49:43 +00:00
Dominik Schilling (ocean90)
df884cb92e Customizer: Use deep-links for Backgrounds, Headers, and Widgets.
Replace links in admin menu and toolbar to Custom Background/Header screen with deep-links to the Customizer section.
On the Widgets screen display a link to the Customizer widgets panel.

props topher1kenobe, rzen, celloexpressions, westonruter
fixes #25569, #25571, #28032.

git-svn-id: https://develop.svn.wordpress.org/trunk@30459 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 15:28:55 +00:00
Andrew Nacin
05facab3d6 Validate image data.
git-svn-id: https://develop.svn.wordpress.org/trunk@30458 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 15:24:40 +00:00
Andrew Nacin
7e75ef00d2 Press This: Ensure the error message is printed. props johnbillion
git-svn-id: https://develop.svn.wordpress.org/trunk@30438 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 13:57:12 +00:00
Jeremy Felt
3223d4a4b3 Prevent wpmu_delete_blog from removing the wrong uploads directory
`wp_upload_dir()` includes some logic to fall back to the default site's upload directory if a specific directory for the requested site cannot be found. Because of this, if `wpmu_delete_blog()` is fired twice in a row for the same site, the main site's upload directory could be deleted as well.

This adds some checks in `wpmu_delete_blog()` so that we are confident in the site and it's upload directory's existence before dropping the site. Tests are added for when `ms_files_rewriting` is enabled or disabled.

Fixes #30121


git-svn-id: https://develop.svn.wordpress.org/trunk@30404 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 06:52:07 +00:00
John Blackbourn
b670f503e5 Introduce two new filters to the post revisions screen:
* `process_text_diff_html` for contextually filtering a diffed line. Allows for the line to be processed in a different manner to the default `htmlspecialchars`.
 * `revision_text_diff_options` for filtering the options passed to `wp_text_diff()` when viewing a post revision.

Fixes #24908
Props adamsilverstein


git-svn-id: https://develop.svn.wordpress.org/trunk@30396 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-19 23:20:07 +00:00
Helen Hou-Sandi
db97a05fce Accessibility: hide admin menu separators from screen readers.
props afercia. fixes #30010.


git-svn-id: https://develop.svn.wordpress.org/trunk@30393 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-19 19:36:43 +00:00
Dion Hulse
9d0c957410 Background Updates: Introduce support to take advantage of Group Writable (or World Writable) to Core Background updates.
This is only enabled when new files will not be installed during the update (as indicated by the WordPress.org API), and does not apply to Plugin/Theme/Translation Background Updates.

Additionally, the code to determine if the 'direct' filesystem transport should be used has been tweaked for wider support (where getmyuid() was unavailalbe) which fixes #10424

See #10205, #30245


git-svn-id: https://develop.svn.wordpress.org/trunk@30384 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-19 05:39:52 +00:00
Drew Jaynes (DrewAPicture)
e4bebb4089 Fix parameter description syntax for WP_Screen::get_option().
Props zrothauser for the initial patch.
See [30368]. Fixes #30363.


git-svn-id: https://develop.svn.wordpress.org/trunk@30369 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-17 17:10:56 +00:00
Drew Jaynes (DrewAPicture)
e6538f5e00 Add a missing @return description for WP_Screen::get_option().
Also declare the default value for the `$key` parameter.

Props dustyf for the initial patch.
Fixes #30363.


git-svn-id: https://develop.svn.wordpress.org/trunk@30368 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-17 17:07:19 +00:00
John Blackbourn
c162a0f82e Decode the sample permalink shown to the user. This avoids showing encoded non-Latin characters in the sample permalink.
Fixes #16496
Props linuxologos


git-svn-id: https://develop.svn.wordpress.org/trunk@30364 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-17 02:59:43 +00:00
John Blackbourn
c33b85fd39 Add a filter to the displayed title of the default page template.
Fixes #27178
Props johnstonphilip


git-svn-id: https://develop.svn.wordpress.org/trunk@30360 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-16 19:32:00 +00:00
John Blackbourn
4e1e4745ff Switch to a 403 response code in places where it is more appropriate than a 500 due to permissions errors.
Fixes #10551
Props nacin


git-svn-id: https://develop.svn.wordpress.org/trunk@30356 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-16 06:15:29 +00:00
John Blackbourn
9a043693da Add some specific JSON responses when there are user permission errors for AJAX file uploads. Replace some usage of wp_json_encode() with wp_send_json_*().
See #25849
Props gcorne


git-svn-id: https://develop.svn.wordpress.org/trunk@30354 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-16 05:46:35 +00:00
John Blackbourn
ee01e3672b Display a faux revision when a post only has one revision but has an autosave.
Fixes #29044
Props adamsilverstein


git-svn-id: https://develop.svn.wordpress.org/trunk@30353 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-16 03:35:37 +00:00
John Blackbourn
b4f9310fa6 Avoid adjusting the current submenu position when tabbing through the admin menu.
Fixes #30349
Props 5um17


git-svn-id: https://develop.svn.wordpress.org/trunk@30352 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-16 02:21:30 +00:00
Andrew Ozz
47a4d58d2b Editor: enable spellchecking of the post title field on the Edit Post screen. Props marsjaninzmarsa, fixes #30338.
git-svn-id: https://develop.svn.wordpress.org/trunk@30350 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-15 01:42:17 +00:00
Gary Pendergast
e1ca159011 If a saving a post fails, remove any invalid characters (such as emoji) from the primary text fields, then try to save it again.
See #21212.



git-svn-id: https://develop.svn.wordpress.org/trunk@30346 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-14 21:33:50 +00:00
Dominik Schilling (ocean90)
1b1f18baf4 Sync our jQuery UI styles with jQuery UI 1.11.2 CSS.
Removes also our own implementations for touch-action compatibility for IE Touch.

props georgestephanis, ocean90.
fixes #26843.

git-svn-id: https://develop.svn.wordpress.org/trunk@30343 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-14 19:27:38 +00:00
Mark Jaquith
78f0186866 Introduce Distraction-Free Writing v2, a re-think of DFW that uses the main editor instance
* the "DFW" button is now an auto/off toggle
* defaulting to auto during beta, decide later for release
* "auto" means that DFW gets enabled as you start typing in editor
* tabbing and mousing out will bring the full interface back
* there is a slight grace period during which your mouse can quickly return

Feature plugin work happened here: https://github.com/avryl/focus

props avryl, azaozz, Michael Arestad
fixes #29806

git-svn-id: https://develop.svn.wordpress.org/trunk@30338 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 22:30:55 +00:00
Dominik Schilling (ocean90)
dc8e01fa9b Site Language: Install translations on the fly.
The language dropdown now includes installed languages and all available translations when the filesystem is writable by WordPress.
Go to wp-admin/options-general.php, select one of the available translations, submit the form and let WordPress handle the rest.
Works for Multisite's Default Language too.

see #29395.

git-svn-id: https://develop.svn.wordpress.org/trunk@30335 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 17:00:08 +00:00
Dominik Schilling (ocean90)
8422a51b98 Improvements to [30333]:
* Move `.hide-if-no-js` class to table row
* Add a wrapper class
* Add missing translators comment

see #30264.

git-svn-id: https://develop.svn.wordpress.org/trunk@30334 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 15:53:52 +00:00
John Blackbourn
d93bad3cd3 Introduce a button on the user profile screen which clears all other sessions, and on the user editing screen which clears all sessions. Only appears when there are applicable sessions which can be cleared.
See #30264.
Props jorbin, ocean90, johnbillion



git-svn-id: https://develop.svn.wordpress.org/trunk@30333 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 15:20:42 +00:00
Dominik Schilling (ocean90)
c55a06370b Fix selector for the "Live Widget Previews" feature pointer.
props rzen.
fixes #30158.

git-svn-id: https://develop.svn.wordpress.org/trunk@30332 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 12:49:42 +00:00
Dominik Schilling (ocean90)
2aac7ef27c Color Picker: Allow to override mode and width values for Iris via wpColorPicker options.
props jtsternberg.
fixes #30182.

git-svn-id: https://develop.svn.wordpress.org/trunk@30330 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 12:33:27 +00:00
Dominik Schilling (ocean90)
8d476eee4f Customizer: Improve ability to filter active state for widget area Customizer sections.
* Mark panels, sections, controls as active if preview explicitly indicates.
* Introduce `WP_Customize_Sidebar_Section` PHP class, and `SidebarSection` JS class.
* Move logic for determining whether a sidebar section is active from the `SidebarControl` to `SidebarSection`.

props westonruter.
fixes #30235.

git-svn-id: https://develop.svn.wordpress.org/trunk@30329 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 12:18:01 +00:00
Dominik Schilling (ocean90)
8d61151356 Improve keyboard accessibility on Custom Header and Custom Background screen.
props florianziegler.
fixes #29289.

git-svn-id: https://develop.svn.wordpress.org/trunk@30327 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 11:59:23 +00:00
Helen Hou-Sandi
7514ac3218 Use a brighter blue against dark backgrounds in the admin menu and toolbar.
Not only does this pass contrast guidelines, but it also visually appears closer to the original highlight blue used against light backgrounds.

props melchoyce. fixes #30323.


git-svn-id: https://develop.svn.wordpress.org/trunk@30313 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-12 20:27:04 +00:00
Dion Hulse
e542c7f7b6 PHP 5.2 compatibility for [30310], __DIR__ wasn't added until PHP 5.3. Props TobiasBg. Fixes #29628
git-svn-id: https://develop.svn.wordpress.org/trunk@30311 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-12 10:43:09 +00:00
Dion Hulse
14d164397a Always use a full filesystem path when including the FTP handler in PemFTP. This prevents other files in the includes directory being scanned/included accidentally.
See #29628


git-svn-id: https://develop.svn.wordpress.org/trunk@30310 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-12 03:05:31 +00:00
Dominik Schilling (ocean90)
4175d8a922 Customizer: Add support for the media library in Background Image controls.
`WP_Customize_Upload_Control` (PHP) and `api.UploadControl` (JS) can now open the media modal.

props celloexpressions, and ericlewis for docs.
see #21483.

git-svn-id: https://develop.svn.wordpress.org/trunk@30309 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-11 23:51:48 +00:00
Dominik Schilling (ocean90)
3566ac62c8 Customizer: Trigger widget-added event when initializing.
Widget controls are now added to the pane dynamically via JavaScript, see #28709.
Remove the event trigger from `SidebarControl.addWidget()` as it's covered by `WidgetControl.ready()`.

props westonruter.
fixes #30236.

git-svn-id: https://develop.svn.wordpress.org/trunk@30308 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-11 22:45:47 +00:00
Dominik Schilling (ocean90)
3b3be684e8 Customizer: Use jQuery.fn.toggle() instead of slideUp/slideDown if panel/section/control is not inserted into DOM yet.
jQuery does nothing when calling `slideUp` on elements that are not inserted into the DOM yet, which can now be the case now when first loading the Customizer as the panels, sections and controls get dynamically inserted, see #28709.

props westonruter.
fixes #30251.

git-svn-id: https://develop.svn.wordpress.org/trunk@30307 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-11 22:36:51 +00:00
Dominik Schilling (ocean90)
63642323a5 Customizer: When navigating around the site within the Customizer preview, update the document title.
props westonruter.
fixes #28542.

git-svn-id: https://develop.svn.wordpress.org/trunk@30306 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-11 22:28:38 +00:00
Drew Jaynes (DrewAPicture)
72cc949b5d Fix the syntax for some status-related documentation introduced in [30155].
* Variables in DocBlocks should be backtick-escaped
* Parameter and return types should be as specific as possible
* `@param` types and variables should align with each other, but not intentionally with the `@return` description

See #30230.


git-svn-id: https://develop.svn.wordpress.org/trunk@30284 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-08 20:55:14 +00:00
Scott Taylor
94e0d1b969 Improve wp.Uploader documentation.
Props ericlewis.
See #30260.


git-svn-id: https://develop.svn.wordpress.org/trunk@30244 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-05 19:36:27 +00:00
Drew Jaynes (DrewAPicture)
d40e689fe1 Ensure the requires for the admin bootstrap are documented in all wp-admin/user/ files.
Props NikV for the initial patch.
Fixes #29111.


git-svn-id: https://develop.svn.wordpress.org/trunk@30228 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-04 16:31:31 +00:00
Drew Jaynes (DrewAPicture)
155561f631 Fix a couple of typos in the hook documentation for the $option filter in wp-admin/includes/class-wp-list-table.php.
Props bobbingwide.
Fixes #30229.


git-svn-id: https://develop.svn.wordpress.org/trunk@30227 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-04 16:04:37 +00:00
Drew Jaynes (DrewAPicture)
ecec9d3595 Add parameter and return descriptions to the WP_List_Table::get_pagination_arg() DocBlock.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30225 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-04 15:54:50 +00:00
Dominik Schilling (ocean90)
507243a3e2 Customizer: Add stable sorting for panels, sections and controls in JS. Improve sorting in PHP.
props westonruter.
fixes #30225.

git-svn-id: https://develop.svn.wordpress.org/trunk@30214 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 21:34:44 +00:00
Scott Taylor
6c5e90eaa5 Correct some types in wp-admin/*-location files' doc blocks.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30203 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 07:08:16 +00:00
Scott Taylor
3942ff4616 Correct all @return unknown instances.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30202 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 06:16:34 +00:00
Scott Taylor
ba85fbacba Fill in the @param types for the args for functions missing them in wp-admin/includes/deprecated.php (pour one out).
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30201 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 06:07:26 +00:00
Scott Taylor
e4b0a71ebd Fill in the @param types for the args for functions missing them in wp-admin/includes/misc.php.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30200 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 06:00:25 +00:00
Scott Taylor
884d27ea00 Fill in the @param types for the args for functions missing them in wp-admin/includes/plugin.php.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30199 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:58:14 +00:00
Scott Taylor
8ddca875b5 Fill in the @param types for the args for functions missing them in wp-admin/includes/post.php.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30198 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:54:04 +00:00
Scott Taylor
53df5b1a61 Fill in the @param types for the args for functions missing them in wp-admin/includes/taxonomy.php.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30197 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:49:57 +00:00
Scott Taylor
43d027f2af Fill in the @param types for the args for functions missing them in wp-admin/includes/template.php.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30196 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:44:33 +00:00
Scott Taylor
aff2817015 Fill in the @param types for the args for make_site_theme_from_default().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30195 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:42:06 +00:00
Scott Taylor
00d5b388c3 Fill in the @param types for the args for make_site_theme_from_oldschool(), which is actually the name of a function?
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30194 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:40:30 +00:00
Scott Taylor
fa5b45c42a Fill in the @param types for the args for dbDelta().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30193 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:39:08 +00:00
Scott Taylor
7ea8e0cb6a Fill in types for the @params for wp_comment_reply().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30190 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:20:43 +00:00
Scott Taylor
c502804272 In Custom_Image_Header:
* In `->process_default_headers()`, remove check on non-existent `$headers` property. Introduced in [13403]. 
* Declare `$updated` as a property.

See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30187 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:14:11 +00:00
Scott Taylor
19eb835aee In Custom_Background, declare $updated as a property.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30186 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:07:49 +00:00
Jeremy Felt
90aa65e0f7 Use common core syntax for checking DOING_AJAX
Our current check for a non truthy `DOING_AJAX` is `! DOING_AJAX`.

props TobiasBg
Fixes #29891


git-svn-id: https://develop.svn.wordpress.org/trunk@30177 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-02 02:23:28 +00:00
Scott Taylor
7acb2c8eb1 Declare the $update_count and $update_current properties for WP_Upgrader.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30171 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 23:06:38 +00:00
Scott Taylor
729bd580ab Declare the $options property for WP_Upgrader_Skin.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30170 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 23:02:52 +00:00
Scott Taylor
bb9f04baa8 Fix the return value doc for WP_List_Table->get_pagination_arg().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30169 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 22:59:48 +00:00
Scott Taylor
c50eaf3b0d In wp_ajax_get_tagcloud(), bail immediately if $_POST['tax'] isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - wp_die() confuses Scrutinizer.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30168 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 22:53:35 +00:00
Scott Taylor
ce6a31c5fe In wp_ajax_ajax_tag_search(), bail immediately if $_GET['tax'] isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - wp_die() confuses Scrutinizer.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30167 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 22:47:27 +00:00
Scott Taylor
b4d0961718 In customize.php, check that $autofocus is an array after running wp_unslash() instead of before. This is admittedly to skip a traversable hint in Scrutinizer.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30164 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 22:16:19 +00:00
Scott Taylor
bdf71f89ad Display error message when Media Library upload fails.
Props gcorne.
Fixes #29891.


git-svn-id: https://develop.svn.wordpress.org/trunk@30156 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 20:24:13 +00:00
Scott Taylor
c8acddfdc8 Improve some post_status-related documentation.
Props ericlewis.
See #30230.


git-svn-id: https://develop.svn.wordpress.org/trunk@30155 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 20:19:26 +00:00
Scott Taylor
c171bb4aae In WP_List_Table, add a property, $modes, to allow WP_Media_List_Table to inherit ->view_switcher().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30154 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 19:55:26 +00:00
Boone Gorges
d6b7b7aa41 Allow resource_type to be specified in get_ancestors().
Being explicit about resource type (taxonomy vs post_type) allows for the
proper resolution of conflicts when a taxonomy and post_type share a slug.

Props filosofo.
Fixes #15029.

git-svn-id: https://develop.svn.wordpress.org/trunk@30141 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 02:57:31 +00:00
Scott Taylor
334fc5b9f2 In Custom_Image_Header->step_2(), $type is set internally but never used.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30136 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 01:23:50 +00:00
Boone Gorges
086f2b9dbd Fix database schema update introduced in [30121].
The index must be manually dropped before `dbDelta()` can add the new index
without throwing a notice.

Fixes #22023.

git-svn-id: https://develop.svn.wordpress.org/trunk@30134 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 01:10:04 +00:00
Scott Taylor
0ae3ac0c05 Revisions modules should not rely on global settings:
* Only pass in global settings on `init`, this allows the classes to be used agnostically elsewhere
* Clean up some erroneous/weird Backbone syntax

Props ericlewis, wonderboymusic.
Fixes #30219.


git-svn-id: https://develop.svn.wordpress.org/trunk@30131 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:38:21 +00:00
Scott Taylor
8d2595d7ff Set revision.settings via short-circuit check for window property: window._wpRevisionsSettings || {}
Props ericlewis.
Fixes #30218.


git-svn-id: https://develop.svn.wordpress.org/trunk@30130 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:19:17 +00:00
Scott Taylor
ee56980498 Add a single responsibility function for outputting Revisions JS templates: wp_print_revision_templates().
Use it in `wp-admin/revision.php`.

Props ericlewis.
Fixes #30220.


git-svn-id: https://develop.svn.wordpress.org/trunk@30129 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:14:45 +00:00
Scott Taylor
c684779022 Allow revision Backbone classes to be used on pages other than revision.php.
Props ericlewis.
Fixes #30221.


git-svn-id: https://develop.svn.wordpress.org/trunk@30128 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:07:34 +00:00
Scott Taylor
55613648fd Add some JSDoc blocks to revisions.js.
Props ericlewis.
See #30222.



git-svn-id: https://develop.svn.wordpress.org/trunk@30127 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 23:54:50 +00:00
Dominik Schilling (ocean90)
40adc7ae16 Customizer: Improve ColorControl's wpColorPicker to update UI based on setting changes.
Update Twenty Fifteen's `colorScheme` control to properly interact with the API, using `wp.customize.control()` instead of traversing DOM for other controls' container elements and stop manually updating color control UIs.

props westonruter.
fixes #30031.

git-svn-id: https://develop.svn.wordpress.org/trunk@30126 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 20:44:19 +00:00
Drew Jaynes (DrewAPicture)
7cd15026bd Correct references of @uses $wpdb in core documentation to use @global.
See #30191, [30105].
Fixes #30217.


git-svn-id: https://develop.svn.wordpress.org/trunk@30122 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 17:55:39 +00:00
Boone Gorges
5073448de6 Bump db_version and add upgrade routine for schema change in [30056].
Fixes #22023.

git-svn-id: https://develop.svn.wordpress.org/trunk@30121 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 16:02:08 +00:00
Sergey Biryukov
f9dc501655 Use correct file name in a hook comment.
props wedi.
fixes #30200.

git-svn-id: https://develop.svn.wordpress.org/trunk@30117 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 18:34:03 +00:00
Drew Jaynes (DrewAPicture)
3cc10d77a0 Remove redundant and erroneous @uses tag from most core inline documentation.
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.

Fixes #30191.


git-svn-id: https://develop.svn.wordpress.org/trunk@30105 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 01:04:55 +00:00
Dominik Schilling (ocean90)
e999d15f44 Customizer: Fix missing newly added widgets in the preview after [29905].
props westonruter.
fixes #29983.

git-svn-id: https://develop.svn.wordpress.org/trunk@30104 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 22:56:53 +00:00
Dominik Schilling (ocean90)
90182015e7 Improve/introduce Customizer JavaScript models for Controls, Sections, and Panels.
* Introduce models for panels and sections.
* Introduce API to expand and focus a control, section or panel.
* Allow deep-linking to panels, sections, and controls inside of the Customizer.
* Clean up `accordion.js`, removing all Customizer-specific logic.
* Add initial unit tests for `wp.customize.Class` in `customize-base.js`.

https://make.wordpress.org/core/2014/10/27/toward-a-complete-javascript-api-for-the-customizer/ provides an overview of how to use the JavaScript API.

props westonruter, celloexpressions, ryankienstra.
see #28032, #28579, #28580, #28650, #28709, #29758.
fixes #29529.



git-svn-id: https://develop.svn.wordpress.org/trunk@30102 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 22:50:21 +00:00
Mark Jaquith
037e00fb15 Fix weird HiDPI screen rendering issue with theme install preview toolbar
fixes #28898
props ocean90

git-svn-id: https://develop.svn.wordpress.org/trunk@30101 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 22:35:27 +00:00
John Blackbourn
6fcb1bf817 Add a hidden submit button to the Appearance -> Header screen so keyboard users can submit the form correctly when a default image provided by the theme is in use.
Fixes #20880.
Props kovshenin, joedolson.


git-svn-id: https://develop.svn.wordpress.org/trunk@30095 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 21:40:58 +00:00
John Blackbourn
32d38fc080 Introduce some actions and filters which aid plugins in revisioning post meta.
* `wp_save_post_revision_post_has_changed` filter which can be used to determine if a post has been changed, and therefore if a revision should be created for a post.
 * `wp_get_revision_ui_diff` filter which can be used to filter the fields displayed in the post revision diff UI.
 * `wp_creating_autosave` action which is fired just before an autosave is created.

See #20564.
Props mattheu, adamsilverstein.


git-svn-id: https://develop.svn.wordpress.org/trunk@30091 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 19:01:15 +00:00
Mark Jaquith
7f0f887357 Increase both mystery and humanism
git-svn-id: https://develop.svn.wordpress.org/trunk@30089 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 03:19:45 +00:00
Aaron Jorbin
233946b852 Update images based on grunt imagemin
The new version of imagemin that was added in r30059 condenses some images more.

see #30141



git-svn-id: https://develop.svn.wordpress.org/trunk@30079 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 22:01:12 +00:00
Scott Taylor
45a635d8c2 In _wp_handle_upload(), if test_upload is set to false in the array of dangerous overrides that the function allows, the only thing that happens when an upload fails is more potential breakage.
`$test_uploaded_file` lets is know if `$file['tmp_name']` exists, which allows to exit with an error, instead of continuing to attempt to move the file.

`$test_upload` override is now a noop.

Fixes #28208.


git-svn-id: https://develop.svn.wordpress.org/trunk@30076 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 21:16:06 +00:00
Boone Gorges
ad4aa0b7e0 Remove UNIQUE key from 'slug' column of terms table.
Each slug is a unique and beautiful snowflake, but let's enforce that
uniqueness elsewhere.

Props hotchkissconsulting.
Fixes #22023.

git-svn-id: https://develop.svn.wordpress.org/trunk@30056 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 18:36:57 +00:00
Gary Pendergast
0e68ecc0b6 Add wp_json_encode(), a wrapper for json_encode() that ensures everything is converted to UTF-8.
Change all core calls from `json_encode()` to `wp_json_encode()`.

Fixes #28786.



git-svn-id: https://develop.svn.wordpress.org/trunk@30055 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 18:34:16 +00:00
John Blackbourn
3d35d8bc5d Add a missing Oxford comma to the install screen. Fixes #30107. Props Ankit K Gupta.
git-svn-id: https://develop.svn.wordpress.org/trunk@30054 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 18:31:19 +00:00
Sergey Biryukov
a32ed9e1ea Remove one-time loop and redundant isset() checks in do_meta_boxes().
See [30022] for do_accordion_sections().

props ipm-frommen.
fixes #30093.

git-svn-id: https://develop.svn.wordpress.org/trunk@30040 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-27 12:57:24 +00:00
Sergey Biryukov
6c69eec02d Make sure the validator list on Credits screen floats correctly with longer names.
props kosvrouvas.
fixes #30066.

git-svn-id: https://develop.svn.wordpress.org/trunk@30037 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-27 02:32:23 +00:00
Drew Jaynes (DrewAPicture)
aae8ddf48f Add a missing asterisk in the DocBlock for write_post().
Also removes several `@uses` tags, which are no longer leveraged as part of the inline documentation standard.

Props tareq1988.
Fixes #30118.


git-svn-id: https://develop.svn.wordpress.org/trunk@30034 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 23:55:16 +00:00
John Blackbourn
bc1168e953 Rename _wp_password_hint() to _wp_get_password_hint() to bring it inline with core terminology. Fixes #21243.
git-svn-id: https://develop.svn.wordpress.org/trunk@30033 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 23:29:11 +00:00
Jeremy Felt
42773dc11b Optimize site query when performing network database upgrades
We only use `blog_id` from the query, so we don't need a wildcard.

props marcosf
Fixes #30097


git-svn-id: https://develop.svn.wordpress.org/trunk@30029 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 22:09:46 +00:00
John Blackbourn
5567318f63 Introduce an edit_form_before_permalink action which gets fired after the title field but before the permalink fields. Fixes #29691. Props captaintheme
git-svn-id: https://develop.svn.wordpress.org/trunk@30028 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 21:48:38 +00:00
John Blackbourn
e6483ffab5 Add labels to the Personal Options input fields on the user profile editing screen. Fixes #30101. Props Ankit K Gupta
git-svn-id: https://develop.svn.wordpress.org/trunk@30027 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 21:28:50 +00:00
Sergey Biryukov
79a5303f68 Fix JSHint errors introduced in [30014].
props adamsilverstein.
see #29572.

git-svn-id: https://develop.svn.wordpress.org/trunk@30024 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 12:05:58 +00:00
Sergey Biryukov
36ee6ba8be Remove one-time loop and redundant isset() checks.
props ipm-frommen.
fixes #30093.

git-svn-id: https://develop.svn.wordpress.org/trunk@30022 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-25 16:33:45 +00:00
Sergey Biryukov
8e3a90887e Fix a copy/paste issue in Custom_Image_Header::get_header_dimensions() introduced in [27497].
props ipm-frommen.
fixes #30095.

git-svn-id: https://develop.svn.wordpress.org/trunk@30021 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-25 15:55:37 +00:00
Sergey Biryukov
f9101c1de9 Users screen in network admin:
* Remove unused $key variables.
* Rename $val to $user_id for clarity.

props ipm-frommen.
fixes #30096.

git-svn-id: https://develop.svn.wordpress.org/trunk@30020 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-25 13:51:36 +00:00
Drew Jaynes (DrewAPicture)
c61e074530 Fix an invalid type for the $section parameter in the do_settings_fields() DocBlock.
Props ipm-frommen.
See #30098.


git-svn-id: https://develop.svn.wordpress.org/trunk@30018 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-25 13:37:59 +00:00
John Blackbourn
37a3642183 Add the ability for a customizer control to render its controls via a JavaScript template. Switches the default color picker control to a JavaScript template. See #29572. Props celloexpressions
git-svn-id: https://develop.svn.wordpress.org/trunk@30014 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-24 16:31:54 +00:00
Jeremy Felt
c7ad092b1d Deprecate admin_created_user_subject()
When `admin_created_user_subjec()` was merged from MU, the accompanying filter was left behind. As it has never been used by WordPress core, and is not an otherwise useful function, it can be deprecated.

Fixes #29915


git-svn-id: https://develop.svn.wordpress.org/trunk@30005 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-24 04:48:31 +00:00
Andrew Ozz
1880bf988c Editor: use <button> instead of <a> for the Visual/Text buttons, make them focusable. Props afercia, fixes #27553
git-svn-id: https://develop.svn.wordpress.org/trunk@30002 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-24 01:20:42 +00:00
Andrew Ozz
2ba822f6f1 Script-loader: remove 'heartbeat' dependency for post.js and inline-edit-post.js, fix dependencies for autosave.js. Fixes #30008
git-svn-id: https://develop.svn.wordpress.org/trunk@29989 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-22 03:40:13 +00:00
John Blackbourn
368bc7b468 Add a focus outline to the widget control toggle arrows. Fixes #27953. Props TomHarrigan.
git-svn-id: https://develop.svn.wordpress.org/trunk@29983 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-21 17:39:02 +00:00
Andrew Ozz
8288e31417 Admin menu:
- Fix scrolling the pinned menu with a mouse wheel.
- Fix pinning when the menu is only slightly taller than the viewport.
- Disable pinning on IE8, updating CSS top makes it jump when scrolling with a mouse wheel.
See #29806

git-svn-id: https://develop.svn.wordpress.org/trunk@29978 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-21 06:11:07 +00:00
Sergey Biryukov
4ea9070f8a Fix copy/paste errors in [27769].
props Corphi.
fixes #30054.

git-svn-id: https://develop.svn.wordpress.org/trunk@29977 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-20 21:34:51 +00:00
Dion Hulse
f2b727f333 Filesystem: Fix the move() method of the SSH2 transport, which was using the SSH2 link rather than the SFTP link.
Props nobleclem. Fixes #29405


git-svn-id: https://develop.svn.wordpress.org/trunk@29970 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-20 07:45:52 +00:00
Dion Hulse
98c438048d Avoid a PHP Notice in the PemFTP Library by adding a missing function parameter. This parameter is unused by WordPress.
Props hugodelgado. Fixes #29628


git-svn-id: https://develop.svn.wordpress.org/trunk@29969 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-20 07:40:41 +00:00
Boone Gorges
5bc62ad1e4 Allow apostrophes in email addresses when adding users via the Dashboard.
Email addresses entered in a number of interfaces were not being stripslashed
properly, with the result that the emails were not being recognized as valid.

Fixes #18039.

git-svn-id: https://develop.svn.wordpress.org/trunk@29966 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-19 20:29:33 +00:00
Sergey Biryukov
512ea93ae4 Live-update site title in toolbar when changing the corresponding field in General Settings.
props celloexpressions, avryl.
fixes #28682.

git-svn-id: https://develop.svn.wordpress.org/trunk@29963 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-19 09:12:11 +00:00
Sergey Biryukov
5ab446aab7 Move password hint text to a function. Add 'password_hint' filter.
props convissor.
fixes #21243.

git-svn-id: https://develop.svn.wordpress.org/trunk@29962 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 20:20:56 +00:00
Sergey Biryukov
ac90567ef1 Use proper functions for escaped translations.
pros jcastaneda.
fixes #30012.

git-svn-id: https://develop.svn.wordpress.org/trunk@29961 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 20:10:47 +00:00
Sergey Biryukov
0caa0b1dbf In wp.updates.decrementCount(), only display the count if it's a valid non-negative integer.
props jdgrimes.
fixes #29527.

git-svn-id: https://develop.svn.wordpress.org/trunk@29960 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 19:54:40 +00:00
Sergey Biryukov
d7955317f3 Theme install:
* Move the "based on" string below the rating to avoid wrapping to a second line.
* Reduce the gap between the theme screenshot and description.
* Fix Install button height on mobile.

props obenland, ocean90.
fixes #28148. see #29556.

git-svn-id: https://develop.svn.wordpress.org/trunk@29959 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 19:42:12 +00:00
Sergey Biryukov
97b07876cb Themes: Make "Live Preview" the primary action and "Activate" secondary.
props celloexpressions.
fixes #26899.

git-svn-id: https://develop.svn.wordpress.org/trunk@29957 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 18:16:23 +00:00
Sergey Biryukov
326aeeba56 Customizer: Use correct panel-back icon in RTL.
props TomHarrigan.
fixes #29946.

git-svn-id: https://develop.svn.wordpress.org/trunk@29955 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 15:34:33 +00:00
Andrew Ozz
8348a50194 Editor-expand:
- Better calculation for the caret position when auto-scrolling while typing.
- Fix auto-scrolling for non-WebKit browsers when the caret is above the top of the editor.
Fixes #29954

git-svn-id: https://develop.svn.wordpress.org/trunk@29929 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 21:31:00 +00:00
Dominik Schilling (ocean90)
3d6d32d9e6 Themes: Make it possible to delete broken themes.
props ideag, obenland.
fixes #28165.

git-svn-id: https://develop.svn.wordpress.org/trunk@29924 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 19:45:26 +00:00
Dominik Schilling (ocean90)
83b0f3f681 Customizer: Only POST dirty settings to preview to improve performance.
props westonruter.
fixes #29983.

git-svn-id: https://develop.svn.wordpress.org/trunk@29905 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-15 17:49:36 +00:00
Dominik Schilling (ocean90)
5829ccba9b Theme install: Remove unused strings.
fixes #29488.

git-svn-id: https://develop.svn.wordpress.org/trunk@29904 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-15 17:21:43 +00:00
Dominik Schilling (ocean90)
ab128698ad Customizer: Change instances of "Theme Customizer" to just "Customizer", as the Customizer isn't necessarily theme-specific.
Also capitalize "Customizer".
See also https://make.wordpress.org/core/2014/07/08/customizer-improvements-in-4-0/.

props studionashvegas, tareq1988.
fixes #29947.

git-svn-id: https://develop.svn.wordpress.org/trunk@29903 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-15 17:20:34 +00:00
Sergey Biryukov
cd19612e1f Twenty Fifteen: Update some more bundled theme references after [29895].
see #29799.

git-svn-id: https://develop.svn.wordpress.org/trunk@29900 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-15 14:34:44 +00:00
Sergey Biryukov
862c82c18f Add line breaks at the end of network setup rules to avoid unintended merging with a subsequent line.
props socki03.
fixes #29945.

git-svn-id: https://develop.svn.wordpress.org/trunk@29899 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-15 14:12:13 +00:00
Andrew Ozz
801ce09508 Admin menu:
- Fix pinning after resizing the window.
- Merge the two DOM ready callbacks in common.js
- Fix the submenus position adjustment on focus.
See #29806

git-svn-id: https://develop.svn.wordpress.org/trunk@29898 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-15 06:04:15 +00:00
Andrew Ozz
f97a5aee3a Editor-expand: reset the editor height after the window is resized. Fixes #29952 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@29886 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-13 21:14:50 +00:00
Sergey Biryukov
9f8e03c390 Avoid PHP notices if 'plugin' is not set for tab=plugin-information.
props avryl.
fixes #29936.

git-svn-id: https://develop.svn.wordpress.org/trunk@29882 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-12 13:05:55 +00:00
Jeremy Felt
bd0e6790a5 Do not send a welcome notification when noconfirmation has been flagged
When adding a new user to a site on the network, 2 emails are sent out - one for confirmation and one as a welcome. If the option for no confirmation is selected, neither should send.

props transom
Fixes #16235


git-svn-id: https://develop.svn.wordpress.org/trunk@29880 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-12 01:10:21 +00:00
Andrew Ozz
463ef0f0fd Fix support for the hide option in wpColorPicker, props tollmanz, fixes #29632
git-svn-id: https://develop.svn.wordpress.org/trunk@29879 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-12 00:50:54 +00:00