sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
28,436 Commits 2 Branches 473 Tags 137 MiB
82d0ba4b60
Commit Graph

2100 Commits

Author SHA1 Message Date
Dion Hulse
14d164397a Always use a full filesystem path when including the FTP handler in PemFTP. This prevents other files in the includes directory being scanned/included accidentally. 
See #29628


git-svn-id: https://develop.svn.wordpress.org/trunk@30310 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-12 03:05:31 +00:00
Dominik Schilling (ocean90)
4175d8a922 Customizer: Add support for the media library in Background Image controls. 
`WP_Customize_Upload_Control` (PHP) and `api.UploadControl` (JS) can now open the media modal.

props celloexpressions, and ericlewis for docs.
see #21483.

git-svn-id: https://develop.svn.wordpress.org/trunk@30309 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-11 23:51:48 +00:00
Dominik Schilling (ocean90)
3566ac62c8 Customizer: Trigger widget-added event when initializing. 
Widget controls are now added to the pane dynamically via JavaScript, see #28709.
Remove the event trigger from `SidebarControl.addWidget()` as it's covered by `WidgetControl.ready()`.

props westonruter.
fixes #30236.

git-svn-id: https://develop.svn.wordpress.org/trunk@30308 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-11 22:45:47 +00:00
Dominik Schilling (ocean90)
3b3be684e8 Customizer: Use jQuery.fn.toggle() instead of slideUp/slideDown if panel/section/control is not inserted into DOM yet. 
jQuery does nothing when calling `slideUp` on elements that are not inserted into the DOM yet, which can now be the case now when first loading the Customizer as the panels, sections and controls get dynamically inserted, see #28709.

props westonruter.
fixes #30251.

git-svn-id: https://develop.svn.wordpress.org/trunk@30307 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-11 22:36:51 +00:00
Dominik Schilling (ocean90)
63642323a5 Customizer: When navigating around the site within the Customizer preview, update the document title. 
props westonruter.
fixes #28542.

git-svn-id: https://develop.svn.wordpress.org/trunk@30306 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-11 22:28:38 +00:00
Drew Jaynes (DrewAPicture)
72cc949b5d Fix the syntax for some status-related documentation introduced in [30155]. 
* Variables in DocBlocks should be backtick-escaped
* Parameter and return types should be as specific as possible
* `@param` types and variables should align with each other, but not intentionally with the `@return` description

See #30230.


git-svn-id: https://develop.svn.wordpress.org/trunk@30284 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-08 20:55:14 +00:00
Scott Taylor
94e0d1b969 Improve wp.Uploader documentation. 
Props ericlewis.
See #30260.


git-svn-id: https://develop.svn.wordpress.org/trunk@30244 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-05 19:36:27 +00:00
Drew Jaynes (DrewAPicture)
d40e689fe1 Ensure the requires for the admin bootstrap are documented in all wp-admin/user/ files. 
Props NikV for the initial patch.
Fixes #29111.


git-svn-id: https://develop.svn.wordpress.org/trunk@30228 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-04 16:31:31 +00:00
Drew Jaynes (DrewAPicture)
155561f631 Fix a couple of typos in the hook documentation for the $option filter in wp-admin/includes/class-wp-list-table.php. 
Props bobbingwide.
Fixes #30229.


git-svn-id: https://develop.svn.wordpress.org/trunk@30227 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-04 16:04:37 +00:00
Drew Jaynes (DrewAPicture)
ecec9d3595 Add parameter and return descriptions to the WP_List_Table::get_pagination_arg() DocBlock. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30225 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-04 15:54:50 +00:00
Dominik Schilling (ocean90)
507243a3e2 Customizer: Add stable sorting for panels, sections and controls in JS. Improve sorting in PHP. 
props westonruter.
fixes #30225.

git-svn-id: https://develop.svn.wordpress.org/trunk@30214 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 21:34:44 +00:00
Scott Taylor
6c5e90eaa5 Correct some types in wp-admin/*-location files' doc blocks. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30203 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 07:08:16 +00:00
Scott Taylor
3942ff4616 Correct all @return unknown instances. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30202 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 06:16:34 +00:00
Scott Taylor
ba85fbacba Fill in the @param types for the args for functions missing them in wp-admin/includes/deprecated.php (pour one out). 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30201 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 06:07:26 +00:00
Scott Taylor
e4b0a71ebd Fill in the @param types for the args for functions missing them in wp-admin/includes/misc.php. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30200 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 06:00:25 +00:00
Scott Taylor
884d27ea00 Fill in the @param types for the args for functions missing them in wp-admin/includes/plugin.php. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30199 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 05:58:14 +00:00
Scott Taylor
8ddca875b5 Fill in the @param types for the args for functions missing them in wp-admin/includes/post.php. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30198 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 05:54:04 +00:00
Scott Taylor
53df5b1a61 Fill in the @param types for the args for functions missing them in wp-admin/includes/taxonomy.php. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30197 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 05:49:57 +00:00
Scott Taylor
43d027f2af Fill in the @param types for the args for functions missing them in wp-admin/includes/template.php. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30196 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 05:44:33 +00:00
Scott Taylor
aff2817015 Fill in the @param types for the args for make_site_theme_from_default(). 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30195 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 05:42:06 +00:00
Scott Taylor
00d5b388c3 Fill in the @param types for the args for make_site_theme_from_oldschool(), which is actually the name of a function? 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30194 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 05:40:30 +00:00
Scott Taylor
fa5b45c42a Fill in the @param types for the args for dbDelta(). 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30193 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 05:39:08 +00:00
Scott Taylor
7ea8e0cb6a Fill in types for the @params for wp_comment_reply(). 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30190 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 05:20:43 +00:00
Scott Taylor
c502804272 In Custom_Image_Header: 
* In `->process_default_headers()`, remove check on non-existent `$headers` property. Introduced in [13403]. 
* Declare `$updated` as a property.

See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30187 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 05:14:11 +00:00
Scott Taylor
19eb835aee In Custom_Background, declare $updated as a property. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30186 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 05:07:49 +00:00
Jeremy Felt
90aa65e0f7 Use common core syntax for checking DOING_AJAX 
Our current check for a non truthy `DOING_AJAX` is `! DOING_AJAX`.

props TobiasBg
Fixes #29891


git-svn-id: https://develop.svn.wordpress.org/trunk@30177 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-02 02:23:28 +00:00
Scott Taylor
7acb2c8eb1 Declare the $update_count and $update_current properties for WP_Upgrader. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30171 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 23:06:38 +00:00
Scott Taylor
729bd580ab Declare the $options property for WP_Upgrader_Skin. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30170 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 23:02:52 +00:00
Scott Taylor
bb9f04baa8 Fix the return value doc for WP_List_Table->get_pagination_arg(). 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30169 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 22:59:48 +00:00
Scott Taylor
c50eaf3b0d In wp_ajax_get_tagcloud(), bail immediately if $_POST['tax'] isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - wp_die() confuses Scrutinizer. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30168 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 22:53:35 +00:00
Scott Taylor
ce6a31c5fe In wp_ajax_ajax_tag_search(), bail immediately if $_GET['tax'] isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - wp_die() confuses Scrutinizer. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30167 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 22:47:27 +00:00
Scott Taylor
b4d0961718 In customize.php, check that $autofocus is an array after running wp_unslash() instead of before. This is admittedly to skip a traversable hint in Scrutinizer. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30164 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 22:16:19 +00:00
Scott Taylor
bdf71f89ad Display error message when Media Library upload fails. 
Props gcorne.
Fixes #29891.


git-svn-id: https://develop.svn.wordpress.org/trunk@30156 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 20:24:13 +00:00
Scott Taylor
c8acddfdc8 Improve some post_status-related documentation. 
Props ericlewis.
See #30230.


git-svn-id: https://develop.svn.wordpress.org/trunk@30155 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 20:19:26 +00:00
Scott Taylor
c171bb4aae In WP_List_Table, add a property, $modes, to allow WP_Media_List_Table to inherit ->view_switcher(). 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30154 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 19:55:26 +00:00
Boone Gorges
d6b7b7aa41 Allow resource_type to be specified in get_ancestors(). 
Being explicit about resource type (taxonomy vs post_type) allows for the
proper resolution of conflicts when a taxonomy and post_type share a slug.

Props filosofo.
Fixes #15029.

git-svn-id: https://develop.svn.wordpress.org/trunk@30141 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 02:57:31 +00:00
Scott Taylor
334fc5b9f2 In Custom_Image_Header->step_2(), $type is set internally but never used. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30136 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 01:23:50 +00:00
Boone Gorges
086f2b9dbd Fix database schema update introduced in [30121]. 
The index must be manually dropped before `dbDelta()` can add the new index
without throwing a notice.

Fixes #22023.

git-svn-id: https://develop.svn.wordpress.org/trunk@30134 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 01:10:04 +00:00
Scott Taylor
0ae3ac0c05 Revisions modules should not rely on global settings: 
* Only pass in global settings on `init`, this allows the classes to be used agnostically elsewhere
* Clean up some erroneous/weird Backbone syntax

Props ericlewis, wonderboymusic.
Fixes #30219.


git-svn-id: https://develop.svn.wordpress.org/trunk@30131 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 00:38:21 +00:00
Scott Taylor
8d2595d7ff Set revision.settings via short-circuit check for window property: window._wpRevisionsSettings || {} 
Props ericlewis.
Fixes #30218.


git-svn-id: https://develop.svn.wordpress.org/trunk@30130 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 00:19:17 +00:00
Scott Taylor
ee56980498 Add a single responsibility function for outputting Revisions JS templates: wp_print_revision_templates(). 
Use it in `wp-admin/revision.php`.

Props ericlewis.
Fixes #30220.


git-svn-id: https://develop.svn.wordpress.org/trunk@30129 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 00:14:45 +00:00
Scott Taylor
c684779022 Allow revision Backbone classes to be used on pages other than revision.php. 
Props ericlewis.
Fixes #30221.


git-svn-id: https://develop.svn.wordpress.org/trunk@30128 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 00:07:34 +00:00
Scott Taylor
55613648fd Add some JSDoc blocks to revisions.js. 
Props ericlewis.
See #30222.



git-svn-id: https://develop.svn.wordpress.org/trunk@30127 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-31 23:54:50 +00:00
Dominik Schilling (ocean90)
40adc7ae16 Customizer: Improve ColorControl's wpColorPicker to update UI based on setting changes. 
Update Twenty Fifteen's `colorScheme` control to properly interact with the API, using `wp.customize.control()` instead of traversing DOM for other controls' container elements and stop manually updating color control UIs.

props westonruter.
fixes #30031.

git-svn-id: https://develop.svn.wordpress.org/trunk@30126 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-31 20:44:19 +00:00
Drew Jaynes (DrewAPicture)
7cd15026bd Correct references of @uses $wpdb in core documentation to use @global. 
See #30191, [30105].
Fixes #30217.


git-svn-id: https://develop.svn.wordpress.org/trunk@30122 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-31 17:55:39 +00:00
Boone Gorges
5073448de6 Bump db_version and add upgrade routine for schema change in [30056]. 
Fixes #22023.

git-svn-id: https://develop.svn.wordpress.org/trunk@30121 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-31 16:02:08 +00:00
Sergey Biryukov
f9dc501655 Use correct file name in a hook comment. 
props wedi.
fixes #30200.

git-svn-id: https://develop.svn.wordpress.org/trunk@30117 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-30 18:34:03 +00:00
Drew Jaynes (DrewAPicture)
3cc10d77a0 Remove redundant and erroneous @uses tag from most core inline documentation. 
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.

Fixes #30191.


git-svn-id: https://develop.svn.wordpress.org/trunk@30105 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-30 01:04:55 +00:00
Dominik Schilling (ocean90)
e999d15f44 Customizer: Fix missing newly added widgets in the preview after [29905]. 
props westonruter.
fixes #29983.

git-svn-id: https://develop.svn.wordpress.org/trunk@30104 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-29 22:56:53 +00:00
Dominik Schilling (ocean90)
90182015e7 Improve/introduce Customizer JavaScript models for Controls, Sections, and Panels. 
* Introduce models for panels and sections.
* Introduce API to expand and focus a control, section or panel.
* Allow deep-linking to panels, sections, and controls inside of the Customizer.
* Clean up `accordion.js`, removing all Customizer-specific logic.
* Add initial unit tests for `wp.customize.Class` in `customize-base.js`.

https://make.wordpress.org/core/2014/10/27/toward-a-complete-javascript-api-for-the-customizer/ provides an overview of how to use the JavaScript API.

props westonruter, celloexpressions, ryankienstra.
see #28032, #28579, #28580, #28650, #28709, #29758.
fixes #29529.



git-svn-id: https://develop.svn.wordpress.org/trunk@30102 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-29 22:50:21 +00:00
Mark Jaquith
037e00fb15 Fix weird HiDPI screen rendering issue with theme install preview toolbar 
fixes #28898
props ocean90

git-svn-id: https://develop.svn.wordpress.org/trunk@30101 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-29 22:35:27 +00:00
John Blackbourn
6fcb1bf817 Add a hidden submit button to the Appearance -> Header screen so keyboard users can submit the form correctly when a default image provided by the theme is in use. 
Fixes #20880.
Props kovshenin, joedolson.


git-svn-id: https://develop.svn.wordpress.org/trunk@30095 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-29 21:40:58 +00:00
John Blackbourn
32d38fc080 Introduce some actions and filters which aid plugins in revisioning post meta. 
* `wp_save_post_revision_post_has_changed` filter which can be used to determine if a post has been changed, and therefore if a revision should be created for a post.
 * `wp_get_revision_ui_diff` filter which can be used to filter the fields displayed in the post revision diff UI.
 * `wp_creating_autosave` action which is fired just before an autosave is created.

See #20564.
Props mattheu, adamsilverstein.


git-svn-id: https://develop.svn.wordpress.org/trunk@30091 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-29 19:01:15 +00:00
Mark Jaquith
7f0f887357 Increase both mystery and humanism 
git-svn-id: https://develop.svn.wordpress.org/trunk@30089 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-29 03:19:45 +00:00
Aaron Jorbin
233946b852 Update images based on grunt imagemin 
The new version of imagemin that was added in r30059 condenses some images more.

see #30141



git-svn-id: https://develop.svn.wordpress.org/trunk@30079 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-28 22:01:12 +00:00
Scott Taylor
45a635d8c2 In _wp_handle_upload(), if test_upload is set to false in the array of dangerous overrides that the function allows, the only thing that happens when an upload fails is more potential breakage. 
`$test_uploaded_file` lets is know if `$file['tmp_name']` exists, which allows to exit with an error, instead of continuing to attempt to move the file.

`$test_upload` override is now a noop.

Fixes #28208.


git-svn-id: https://develop.svn.wordpress.org/trunk@30076 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-28 21:16:06 +00:00
Boone Gorges
ad4aa0b7e0 Remove UNIQUE key from 'slug' column of terms table. 
Each slug is a unique and beautiful snowflake, but let's enforce that
uniqueness elsewhere.

Props hotchkissconsulting.
Fixes #22023.

git-svn-id: https://develop.svn.wordpress.org/trunk@30056 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-28 18:36:57 +00:00
Gary Pendergast
0e68ecc0b6 Add wp_json_encode(), a wrapper for json_encode() that ensures everything is converted to UTF-8. 
Change all core calls from `json_encode()` to `wp_json_encode()`.

Fixes #28786.



git-svn-id: https://develop.svn.wordpress.org/trunk@30055 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-28 18:34:16 +00:00
John Blackbourn
3d35d8bc5d Add a missing Oxford comma to the install screen. Fixes #30107. Props Ankit K Gupta. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30054 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-28 18:31:19 +00:00
Sergey Biryukov
a32ed9e1ea Remove one-time loop and redundant isset() checks in do_meta_boxes(). 
See [30022] for do_accordion_sections().

props ipm-frommen.
fixes #30093.

git-svn-id: https://develop.svn.wordpress.org/trunk@30040 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-27 12:57:24 +00:00
Sergey Biryukov
6c69eec02d Make sure the validator list on Credits screen floats correctly with longer names. 
props kosvrouvas.
fixes #30066.

git-svn-id: https://develop.svn.wordpress.org/trunk@30037 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-27 02:32:23 +00:00
Drew Jaynes (DrewAPicture)
aae8ddf48f Add a missing asterisk in the DocBlock for write_post(). 
Also removes several `@uses` tags, which are no longer leveraged as part of the inline documentation standard.

Props tareq1988.
Fixes #30118.


git-svn-id: https://develop.svn.wordpress.org/trunk@30034 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-26 23:55:16 +00:00
John Blackbourn
bc1168e953 Rename _wp_password_hint() to _wp_get_password_hint() to bring it inline with core terminology. Fixes #21243. 
git-svn-id: https://develop.svn.wordpress.org/trunk@30033 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-26 23:29:11 +00:00
Jeremy Felt
42773dc11b Optimize site query when performing network database upgrades 
We only use `blog_id` from the query, so we don't need a wildcard.

props marcosf
Fixes #30097


git-svn-id: https://develop.svn.wordpress.org/trunk@30029 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-26 22:09:46 +00:00
John Blackbourn
5567318f63 Introduce an edit_form_before_permalink action which gets fired after the title field but before the permalink fields. Fixes #29691. Props captaintheme 
git-svn-id: https://develop.svn.wordpress.org/trunk@30028 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-26 21:48:38 +00:00
John Blackbourn
e6483ffab5 Add labels to the Personal Options input fields on the user profile editing screen. Fixes #30101. Props Ankit K Gupta 
git-svn-id: https://develop.svn.wordpress.org/trunk@30027 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-26 21:28:50 +00:00
Sergey Biryukov
79a5303f68 Fix JSHint errors introduced in [30014]. 
props adamsilverstein.
see #29572.

git-svn-id: https://develop.svn.wordpress.org/trunk@30024 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-26 12:05:58 +00:00
Sergey Biryukov
36ee6ba8be Remove one-time loop and redundant isset() checks. 
props ipm-frommen.
fixes #30093.

git-svn-id: https://develop.svn.wordpress.org/trunk@30022 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-25 16:33:45 +00:00
Sergey Biryukov
8e3a90887e Fix a copy/paste issue in Custom_Image_Header::get_header_dimensions() introduced in [27497]. 
props ipm-frommen.
fixes #30095.

git-svn-id: https://develop.svn.wordpress.org/trunk@30021 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-25 15:55:37 +00:00
Sergey Biryukov
f9101c1de9 Users screen in network admin: 
* Remove unused $key variables.
* Rename $val to $user_id for clarity.

props ipm-frommen.
fixes #30096.

git-svn-id: https://develop.svn.wordpress.org/trunk@30020 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-25 13:51:36 +00:00
Drew Jaynes (DrewAPicture)
c61e074530 Fix an invalid type for the $section parameter in the do_settings_fields() DocBlock. 
Props ipm-frommen.
See #30098.


git-svn-id: https://develop.svn.wordpress.org/trunk@30018 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-25 13:37:59 +00:00
John Blackbourn
37a3642183 Add the ability for a customizer control to render its controls via a JavaScript template. Switches the default color picker control to a JavaScript template. See #29572. Props celloexpressions 
git-svn-id: https://develop.svn.wordpress.org/trunk@30014 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-24 16:31:54 +00:00
Jeremy Felt
c7ad092b1d Deprecate admin_created_user_subject() 
When `admin_created_user_subjec()` was merged from MU, the accompanying filter was left behind. As it has never been used by WordPress core, and is not an otherwise useful function, it can be deprecated.

Fixes #29915


git-svn-id: https://develop.svn.wordpress.org/trunk@30005 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-24 04:48:31 +00:00
Andrew Ozz
1880bf988c Editor: use <button> instead of <a> for the Visual/Text buttons, make them focusable. Props afercia, fixes #27553 
git-svn-id: https://develop.svn.wordpress.org/trunk@30002 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-24 01:20:42 +00:00
Andrew Ozz
2ba822f6f1 Script-loader: remove 'heartbeat' dependency for post.js and inline-edit-post.js, fix dependencies for autosave.js. Fixes #30008 
git-svn-id: https://develop.svn.wordpress.org/trunk@29989 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-22 03:40:13 +00:00
John Blackbourn
368bc7b468 Add a focus outline to the widget control toggle arrows. Fixes #27953. Props TomHarrigan. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29983 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-21 17:39:02 +00:00
Andrew Ozz
8288e31417 Admin menu: 
- Fix scrolling the pinned menu with a mouse wheel.
- Fix pinning when the menu is only slightly taller than the viewport.
- Disable pinning on IE8, updating CSS top makes it jump when scrolling with a mouse wheel.
See #29806

git-svn-id: https://develop.svn.wordpress.org/trunk@29978 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-21 06:11:07 +00:00
Sergey Biryukov
4ea9070f8a Fix copy/paste errors in [27769]. 
props Corphi.
fixes #30054.

git-svn-id: https://develop.svn.wordpress.org/trunk@29977 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-20 21:34:51 +00:00
Dion Hulse
f2b727f333 Filesystem: Fix the move() method of the SSH2 transport, which was using the SSH2 link rather than the SFTP link. 
Props nobleclem. Fixes #29405


git-svn-id: https://develop.svn.wordpress.org/trunk@29970 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-20 07:45:52 +00:00
Dion Hulse
98c438048d Avoid a PHP Notice in the PemFTP Library by adding a missing function parameter. This parameter is unused by WordPress. 
Props hugodelgado. Fixes #29628


git-svn-id: https://develop.svn.wordpress.org/trunk@29969 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-20 07:40:41 +00:00
Boone Gorges
5bc62ad1e4 Allow apostrophes in email addresses when adding users via the Dashboard. 
Email addresses entered in a number of interfaces were not being stripslashed
properly, with the result that the emails were not being recognized as valid.

Fixes #18039.

git-svn-id: https://develop.svn.wordpress.org/trunk@29966 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-19 20:29:33 +00:00
Sergey Biryukov
512ea93ae4 Live-update site title in toolbar when changing the corresponding field in General Settings. 
props celloexpressions, avryl.
fixes #28682.

git-svn-id: https://develop.svn.wordpress.org/trunk@29963 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-19 09:12:11 +00:00
Sergey Biryukov
5ab446aab7 Move password hint text to a function. Add 'password_hint' filter. 
props convissor.
fixes #21243.

git-svn-id: https://develop.svn.wordpress.org/trunk@29962 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-18 20:20:56 +00:00
Sergey Biryukov
ac90567ef1 Use proper functions for escaped translations. 
pros jcastaneda.
fixes #30012.

git-svn-id: https://develop.svn.wordpress.org/trunk@29961 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-18 20:10:47 +00:00
Sergey Biryukov
0caa0b1dbf In wp.updates.decrementCount(), only display the count if it's a valid non-negative integer. 
props jdgrimes.
fixes #29527.

git-svn-id: https://develop.svn.wordpress.org/trunk@29960 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-18 19:54:40 +00:00
Sergey Biryukov
d7955317f3 Theme install: 
* Move the "based on" string below the rating to avoid wrapping to a second line.
* Reduce the gap between the theme screenshot and description.
* Fix Install button height on mobile.

props obenland, ocean90.
fixes #28148. see #29556.

git-svn-id: https://develop.svn.wordpress.org/trunk@29959 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-18 19:42:12 +00:00
Sergey Biryukov
97b07876cb Themes: Make "Live Preview" the primary action and "Activate" secondary. 
props celloexpressions.
fixes #26899.

git-svn-id: https://develop.svn.wordpress.org/trunk@29957 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-18 18:16:23 +00:00
Sergey Biryukov
326aeeba56 Customizer: Use correct panel-back icon in RTL. 
props TomHarrigan.
fixes #29946.

git-svn-id: https://develop.svn.wordpress.org/trunk@29955 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-18 15:34:33 +00:00
Andrew Ozz
8348a50194 Editor-expand: 
- Better calculation for the caret position when auto-scrolling while typing.
- Fix auto-scrolling for non-WebKit browsers when the caret is above the top of the editor.
Fixes #29954

git-svn-id: https://develop.svn.wordpress.org/trunk@29929 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-16 21:31:00 +00:00
Dominik Schilling (ocean90)
3d6d32d9e6 Themes: Make it possible to delete broken themes. 
props ideag, obenland.
fixes #28165.

git-svn-id: https://develop.svn.wordpress.org/trunk@29924 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-16 19:45:26 +00:00
Dominik Schilling (ocean90)
83b0f3f681 Customizer: Only POST dirty settings to preview to improve performance. 
props westonruter.
fixes #29983.

git-svn-id: https://develop.svn.wordpress.org/trunk@29905 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-15 17:49:36 +00:00
Dominik Schilling (ocean90)
5829ccba9b Theme install: Remove unused strings. 
fixes #29488.

git-svn-id: https://develop.svn.wordpress.org/trunk@29904 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-15 17:21:43 +00:00
Dominik Schilling (ocean90)
ab128698ad Customizer: Change instances of "Theme Customizer" to just "Customizer", as the Customizer isn't necessarily theme-specific. 
Also capitalize "Customizer".
See also https://make.wordpress.org/core/2014/07/08/customizer-improvements-in-4-0/.

props studionashvegas, tareq1988.
fixes #29947.

git-svn-id: https://develop.svn.wordpress.org/trunk@29903 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-15 17:20:34 +00:00
Sergey Biryukov
cd19612e1f Twenty Fifteen: Update some more bundled theme references after [29895]. 
see #29799.

git-svn-id: https://develop.svn.wordpress.org/trunk@29900 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-15 14:34:44 +00:00
Sergey Biryukov
862c82c18f Add line breaks at the end of network setup rules to avoid unintended merging with a subsequent line. 
props socki03.
fixes #29945.

git-svn-id: https://develop.svn.wordpress.org/trunk@29899 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-15 14:12:13 +00:00
Andrew Ozz
801ce09508 Admin menu: 
- Fix pinning after resizing the window.
- Merge the two DOM ready callbacks in common.js
- Fix the submenus position adjustment on focus.
See #29806

git-svn-id: https://develop.svn.wordpress.org/trunk@29898 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-15 06:04:15 +00:00
Andrew Ozz
f97a5aee3a Editor-expand: reset the editor height after the window is resized. Fixes #29952 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29886 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-13 21:14:50 +00:00
Sergey Biryukov
9f8e03c390 Avoid PHP notices if 'plugin' is not set for tab=plugin-information. 
props avryl.
fixes #29936.

git-svn-id: https://develop.svn.wordpress.org/trunk@29882 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-12 13:05:55 +00:00
Jeremy Felt
bd0e6790a5 Do not send a welcome notification when noconfirmation has been flagged 
When adding a new user to a site on the network, 2 emails are sent out - one for confirmation and one as a welcome. If the option for no confirmation is selected, neither should send.

props transom
Fixes #16235


git-svn-id: https://develop.svn.wordpress.org/trunk@29880 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-12 01:10:21 +00:00
Andrew Ozz
463ef0f0fd Fix support for the hide option in wpColorPicker, props tollmanz, fixes #29632 
git-svn-id: https://develop.svn.wordpress.org/trunk@29879 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-12 00:50:54 +00:00
Jeremy Felt
f12a68e7c6 Differentiate between invalid and missing admin emails when adding a new site 
Check the emptiness of the admin email before using `sanitize_email()` and `is_email()` to determine if the address is valid.

Fixes #17890


git-svn-id: https://develop.svn.wordpress.org/trunk@29877 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-12 00:21:02 +00:00
Sergey Biryukov
204e5dae21 Add missing label to comment type filter dropdown. 
props afercia.
fixes #29922.

git-svn-id: https://develop.svn.wordpress.org/trunk@29872 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-11 02:25:17 +00:00
Sergey Biryukov
c50be6a735 Remove "View" prefix from category filter dropdowns, for consistency with [27626]. 
props afercia.
see #29921.

git-svn-id: https://develop.svn.wordpress.org/trunk@29871 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-11 02:22:08 +00:00
Sergey Biryukov
8d2f5d0cc5 Add missing labels to category filter dropdowns. 
props afercia.
fixes #29921.

git-svn-id: https://develop.svn.wordpress.org/trunk@29870 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-11 02:20:05 +00:00
Dominik Schilling (ocean90)
e9be4237ba Language packs: Remove translations when deleting a theme or a plugin. 
This is for translation files in WP_LANG_DIR which are installed through a language pack.
Change `wp_get_installed_translations()` to only return a translation if the .mo file also exists.

fixes #29860.

git-svn-id: https://develop.svn.wordpress.org/trunk@29856 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-08 19:04:05 +00:00
Dominik Schilling (ocean90)
539d55e068 Update jQuery UI to 1.11.1. 
Because jQUI's build process no longer provides individual minified files we need some additional changes:
* Rename all files, remove the "jquery.ui." prefix. Add old files to `$_old_files`.
* Add and use non-minified files in /src.
* Add grunt task to minify jQuery UI files.
* (Non-minified files will not be shipped.)

Changelogs:
* http://jqueryui.com/changelog/1.11.0/
* http://jqueryui.com/changelog/1.11.1/

props Fab1en, ocean90.
fixes #29833.

git-svn-id: https://develop.svn.wordpress.org/trunk@29847 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-07 15:27:56 +00:00
Andrew Ozz
107d754683 Add default z-index to the admin menu, see #29806 
git-svn-id: https://develop.svn.wordpress.org/trunk@29841 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-06 01:59:46 +00:00
Sergey Biryukov
65a0f4933a Network Admin: Properly check if the theme is active on the main site to avoid deleting it via bulk actions. 
props ocean90.
fixes #29861.

git-svn-id: https://develop.svn.wordpress.org/trunk@29839 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-05 20:36:11 +00:00
Andrew Ozz
d2c8c72e7f Pin the admin menu on scrolling similarly to how the side metaboxes are pinned on the Edit Post screen, first run. See #29806. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29835 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-05 03:08:11 +00:00
Scott Taylor
11c914bca9 In the admin, give media list table icons auto for width and height. In the post thumbnail metabox, apply width: auto. 
If someone turns on support SVG files, this will allow them to show up.

Props arippberger for an initial patch.
Fixes #26256.


git-svn-id: https://develop.svn.wordpress.org/trunk@29832 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-03 19:07:17 +00:00
Dominik Schilling (ocean90)
f7a4e22bdb Plugin search: Wrap results in a form to fix pagination's paged input field. 
props jesin, ocean90.
see #18724, for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29829 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-03 13:07:18 +00:00
Sergey Biryukov
7d2f7c6ceb Switch line-height added in [29790] to a unitless value. 
props janhenckens.
fixes #29451.

git-svn-id: https://develop.svn.wordpress.org/trunk@29828 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-03 09:41:24 +00:00
Sergey Biryukov
3d0f4d9656 Use correct links for filtering plugin reviews. 
props OriginalEXE.
fixes #29754.

git-svn-id: https://develop.svn.wordpress.org/trunk@29826 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-03 08:08:27 +00:00
Sergey Biryukov
990f01f81f Avoid a PHP notice in list_plugin_updates() if plugins_api() returned a WP_Error object. 
fixes #29583.

git-svn-id: https://develop.svn.wordpress.org/trunk@29825 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-03 00:01:51 +00:00
Sergey Biryukov
32dbb27701 * Use correct context for 'Name' and 'Parent' strings on taxonomy screens. 
* Remove unnecessary context for 'Slug' and 'Description' strings.

props andg.
fixes #29824.

git-svn-id: https://develop.svn.wordpress.org/trunk@29821 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 20:00:11 +00:00
Sergey Biryukov
c231361790 Use a more consistent markup on taxonomy and user screens. 
props paulwilde.
fixes #29842.

git-svn-id: https://develop.svn.wordpress.org/trunk@29820 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 19:39:14 +00:00
Scott Taylor
dcef5d4583 In activate_plugin(), do not re-run the activation routine for already-active network-wide plugins. 
Adds unit test.

Props jbrinley.
Fixes #28651.


git-svn-id: https://develop.svn.wordpress.org/trunk@29818 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 15:55:51 +00:00
Scott Taylor
46b4ea2a6c Network Admin Menu: 
* Don't display update count for Themes when the user doesn't have the 'update_themes' cap
* Don't display update count for Plugins when there aren't any/count is `0`

Props peterchester.
Fixes #29651.


git-svn-id: https://develop.svn.wordpress.org/trunk@29817 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 15:48:36 +00:00
Sergey Biryukov
f4c6eb964b When switching to the Text editor, make the textarea visible to screen readers. 
props afercia.
fixes #29815.

git-svn-id: https://develop.svn.wordpress.org/trunk@29815 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 12:45:42 +00:00
Scott Taylor
7711e9648c Media Grid/List Table parity: when MEDIA_TRASH is true and trash is the current filter for the grid, add a second bulk action button: "Delete Selected" 
Fixes #29742.


git-svn-id: https://develop.svn.wordpress.org/trunk@29811 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 04:12:01 +00:00
Scott Taylor
ec93f031b3 Media List Table: account for MEDIA_TRASH in the bulk action dropdown. 
See #29742.


git-svn-id: https://develop.svn.wordpress.org/trunk@29810 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 03:11:49 +00:00
Sergey Biryukov
c313878af2 Reorder placeholders for consistency. see [29806]. 
see #21089.

git-svn-id: https://develop.svn.wordpress.org/trunk@29807 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 01:37:05 +00:00
Scott Taylor
3a11531451 In the wp_new_blog_notification() email template, include the login url. 
Props obenland, georgestephanis.
Fixes #21089.


git-svn-id: https://develop.svn.wordpress.org/trunk@29806 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 01:27:57 +00:00
Sergey Biryukov
c4fcdf329e Add classes to form containers on Edit User screen. 
props jarednova.
fixes #29348.

git-svn-id: https://develop.svn.wordpress.org/trunk@29804 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 00:55:40 +00:00
Sergey Biryukov
d59e6696b3 Add classes to form containers on taxonomy screens. 
props jarednova.
fixes #28196.

git-svn-id: https://develop.svn.wordpress.org/trunk@29803 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 00:28:45 +00:00
Sergey Biryukov
f6753a316a Change the default orderby value in wp_get_nav_menus() to 'name'. 
props voldemortensen, igmoweb.
fixes #29460.

git-svn-id: https://develop.svn.wordpress.org/trunk@29792 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 15:44:26 +00:00
Sergey Biryukov
8cc322b073 Fix padding for parent theme link on Edit Themes screen. 
props kraftner.
fixes #27825.

git-svn-id: https://develop.svn.wordpress.org/trunk@29791 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 14:09:38 +00:00
Sergey Biryukov
dfc018ccf9 Account for longer translations of 'Customize Your Site' button label. 
props shooper.
fixes #29451.

git-svn-id: https://develop.svn.wordpress.org/trunk@29790 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 13:56:34 +00:00
Mark Jaquith
be8a0c6f89 Use HTTPS URLs for trac.wordpress.org (and use core.trac.wordpress.org) 
see #27115

git-svn-id: https://develop.svn.wordpress.org/trunk@29789 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 13:36:38 +00:00
Mark Jaquith
7063377539 Use HTTPS URLs for core.trac.wordpress.org 
see #27115

git-svn-id: https://develop.svn.wordpress.org/trunk@29788 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 13:27:55 +00:00
Mark Jaquith
4c22a5003b Use HTTPS links for planet.wordpress.org 
see #27115

git-svn-id: https://develop.svn.wordpress.org/trunk@29787 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 13:23:46 +00:00
Sergey Biryukov
029d1dbaa4 Use a more specific selector for the count displayed on Add Themes network admin screen. 
props mantismamita, nikolov.tmw.
fixes #29421.

git-svn-id: https://develop.svn.wordpress.org/trunk@29786 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 13:06:17 +00:00
Mark Jaquith
7402030670 Show the number of approved comments instead of all comments on 
the dashboard in the "At a glance" section.

fixes #26738. props benjmay

git-svn-id: https://develop.svn.wordpress.org/trunk@29785 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 12:41:49 +00:00
Scott Taylor
37da833fce In the form handler logic for edit-tags.php, don't redirect until $_REQUEST['paged'] has been checked. All switch cases (except edit) now use break instead of exit. 
Fixes #16162.


git-svn-id: https://develop.svn.wordpress.org/trunk@29782 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 04:53:07 +00:00
Andrew Ozz
3b757232d0 Media: disable multi-file uploading in iOS 7.x Safari as it prevents uploading of videos. Fixes #29602 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29776 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 00:13:47 +00:00
Sergey Biryukov
2e58e91dcc Remove unnecessary CSS overriding on Add Plugins screen. 
props pavelevap.
fixes #29753.

git-svn-id: https://develop.svn.wordpress.org/trunk@29775 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-28 20:25:33 +00:00
Sergey Biryukov
9e5beefd72 Don't display an empty comment author IP link on Comments screen. 
props afercia.
fixes #29766.

git-svn-id: https://develop.svn.wordpress.org/trunk@29774 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-28 06:37:10 +00:00
Andrew Ozz
d34a54f1e4 Fix tapping on the menu in iOS and Android, fixes #29365 for trunk 
git-svn-id: https://develop.svn.wordpress.org/trunk@29770 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-26 23:01:52 +00:00
Sergey Biryukov
c993055800 Remove extra space from a string. 
props pavelevap.
fixes #29752.

git-svn-id: https://develop.svn.wordpress.org/trunk@29767 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-26 18:48:05 +00:00
Scott Taylor
22db82dff1 In wp_ajax_replyto_comment(), if $_POST['comment_type'] is set, use it for the value of $comment_type, which the compact() call has assumed is set since [8720]. It never was. 
`wp_comment_reply()`'s output can be complete overridden by the `wp_comment_reply` filter, so this check is justified and makes the AJAX callback more flexible.

Props nerrad.
Fixes #29704.


git-svn-id: https://develop.svn.wordpress.org/trunk@29758 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-23 03:28:51 +00:00
Scott Taylor
e97e5048c3 If the current user does not have the delete_posts cap on the current post type, don't list delete or trash as bulk actions for the relevant context of Post list table. 
Props mvd7793.
Fixes #20175.


git-svn-id: https://develop.svn.wordpress.org/trunk@29757 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-23 02:57:43 +00:00
Sergey Biryukov
994566bb17 Pass the attachment ID to the 'image_add_caption_text' filter. 
fixes #29607.

git-svn-id: https://develop.svn.wordpress.org/trunk@29754 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-21 10:10:19 +00:00
Sergey Biryukov
9e673c7eee Add 'image_add_caption_text' filter for changing the pre-parse caption text before output to the editor. 
props collinsinternet, DrewAPicture.
fixes #29607.

git-svn-id: https://develop.svn.wordpress.org/trunk@29753 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-21 09:55:08 +00:00
Andrew Nacin
9c751b268a Don't set ftp_credentials option when installling. see #29635. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29749 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-17 17:57:59 +00:00
wonderboymusic
578609d31e Make the URL output in _thickbox_path_admin_subfolder() use includes_url(). 
Props voldemortensen.
Fixes #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@29741 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-12 22:30:03 +00:00
Andrew Ozz
a9384b7a30 Editor expand: hide TinyMCE float panels and tooltips when scrolling, props avryl, fixes #29516 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29738 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-12 01:20:09 +00:00
Scott Taylor
6ed8bab324 In media_handle_upload(), don't call wp_read_image_metadata() on things that aren't images (like videos). We never caught this error, because we are suppressing it by calling @wp_read_image_metadata(). 
Props jrf for the initial patch.
Fixes #28907.


git-svn-id: https://develop.svn.wordpress.org/trunk@29737 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-11 20:14:56 +00:00
Andrew Ozz
123fae73b5 Media: revert enabling of multi-file uploading for mobile devices. Currently only iOS Safari supports it but has a bug that prevents uploading of videos. Fixes #29602 
git-svn-id: https://develop.svn.wordpress.org/trunk@29729 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-10 22:39:39 +00:00
Scott Taylor
698f77735b Don't overwrite the length property unnecessarily when generating metadata for audio and video files. 
Props jrf, wonderboymusic.
Fixes #29176.


git-svn-id: https://develop.svn.wordpress.org/trunk@29728 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-10 21:56:24 +00:00
Sergey Biryukov
69b97690d5 Widgets: Toggle widget arrow when the widget is closed using Close link. 
props senff.
fixes #29617.

git-svn-id: https://develop.svn.wordpress.org/trunk@29726 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-10 17:35:38 +00:00
Sergey Biryukov
9c48d0f495 Make sure we're on the media grid page before calling wp.media(). 
props azaozz.
fixes #29520 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29725 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-09 10:13:33 +00:00
Sergey Biryukov
8cfdbf1167 Use https for apps.wordpress.org links. 
props pento.
fixes #29595 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29721 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-09 06:28:33 +00:00
Sergey Biryukov
d552ba29bc * Declare $site_mimes before using it in check_upload_mimes(). 
* Use the same default value for 'upload_filetypes' as on Network Settings screen.

props rmccue.
fixes #29512 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29718 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-07 10:10:33 +00:00
Sergey Biryukov
12bffd9665 Use home URL instead of example.org on Permalink Settings screen. 
props voldemortensen, jesin.
fixes #29509.

git-svn-id: https://develop.svn.wordpress.org/trunk@29716 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-07 09:43:48 +00:00
Helen Hou-Sandi
5771e6e1d5 About: Make sure the images are properly responsive. 
props ocean90.
see #29494.


git-svn-id: https://develop.svn.wordpress.org/trunk@29708 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-04 15:23:51 +00:00
Andrew Nacin
ca32a2d410 Pinking shears. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29707 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-04 15:22:58 +00:00
helen
f07a9f28a8 Final about page for 4.0. Enjoy the videos! 
props ryelle, melchoyce, smashcut, wonderboymusic, helen.
fixes #29494.


git-svn-id: https://develop.svn.wordpress.org/trunk@29706 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-04 15:04:02 +00:00
Andrew Nacin
3d698699be i18n: Skip language chooser for localized packages. 
Also fixes the install.php welcome string, which was not bring printed.

fixes #29487.


git-svn-id: https://develop.svn.wordpress.org/trunk@29705 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-04 14:38:17 +00:00
Andrew Nacin
84681ddd39 Link to apps.wordpress.org instead of wordpress.org/mobile. 
props pento.
fixes #29496.


git-svn-id: https://develop.svn.wordpress.org/trunk@29703 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-04 14:21:13 +00:00
Helen Hou-Sandi
2d07fb1b59 Media: Swap in a new icon for the grid mode. 
props melchoyce.
fixes #29353.


git-svn-id: https://develop.svn.wordpress.org/trunk@29702 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-04 14:13:46 +00:00
Andrew Nacin
d53bee91c6 Add 'Release Lead' string to credits. see #29494. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29700 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 23:18:37 +00:00
Andrew Ozz
44466b7627 Editor expand: revert back to scrolling to the editor top when switching Visual to Text, fixes #29338 
git-svn-id: https://develop.svn.wordpress.org/trunk@29698 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 18:03:43 +00:00
Helen Hou-Sandi
f5e371608c Modals: Remove yet more cruft that was causing unwanted coloration of icons. 
props celloexpressions.
fixes #29147 (for real this time).


git-svn-id: https://develop.svn.wordpress.org/trunk@29697 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 17:05:38 +00:00
Sergey Biryukov
0df3044683 Restore the post type's view_item label for preview links that don't submit the changes. 
fixes #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@29695 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 11:32:52 +00:00
Dominik Schilling (ocean90)
350152b49e Language Pack Upgrader: Allow to disable asynchronously translation updates. 
* Don't touch VCS installs.
* Use the `async_update_translation` filter (which corresponds exactly to `auto_update_translation`) to entirely disable it, or based on the update offer. 

props nacin, ocean90.
fixes #28571.

git-svn-id: https://develop.svn.wordpress.org/trunk@29694 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 10:37:21 +00:00
Helen Hou-Sandi
c529b75886 Editor scrolling: Remember and restore scroll position for visual and text modes. 
This prevents the editor from jumping off screen when the rendered visual content is significantly taller than plain text, e.g. when there are views present.

This is also a close restoration of 3.9 behavior, some of which was browser-specific.

props avryl.
fixes #29338.


git-svn-id: https://develop.svn.wordpress.org/trunk@29693 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 09:57:56 +00:00
Andrew Nacin
7716dae9fa Editor scrolling: Avoid jumping to the cursor when modifier and scrolling keys are pressed. 
fixes #29485.


git-svn-id: https://develop.svn.wordpress.org/trunk@29692 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 09:37:01 +00:00
Andrew Nacin
de3b2ccf19 Allow language specified by the WPLANG constant (but not installed) to be chosen. 
fixes #29456.


git-svn-id: https://develop.svn.wordpress.org/trunk@29691 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 08:02:53 +00:00
Andrew Nacin
acbd7696ee Media Library: Fix media trash handling. 
props ocean90, obenland.
fixes #29469.


git-svn-id: https://develop.svn.wordpress.org/trunk@29690 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 06:46:34 +00:00
Helen Hou-Sandi
53f56ffb0f Media: Better padding for attachment items. 
props avryl.
fixes #29085.


git-svn-id: https://develop.svn.wordpress.org/trunk@29687 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 06:27:34 +00:00
Dion Hulse
a01096b872 Language Pack Upgrader: Remove ALL pre-existing filters before performing a translation update these filters may act in an unexpected way during the upgrade process. 
See #29230. Fixes #29425.


git-svn-id: https://develop.svn.wordpress.org/trunk@29685 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 05:37:33 +00:00
Andrew Nacin
609eb61a1c About page: Remove reference to not-yet-operational translated plugins/themes directories. 
props stephdau.
see #29391.


git-svn-id: https://develop.svn.wordpress.org/trunk@29684 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 02:36:23 +00:00
Andrew Nacin
0ab1df4243 Ensure oEmbed previews listen to [embed] width/height attributes. 
props azaozz.
fixes #29474.


git-svn-id: https://develop.svn.wordpress.org/trunk@29681 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 00:39:05 +00:00
Helen Hou-Sandi
2cb48c1039 Plugin install: Better styling to accommodate plugin icons. 
fixes #29466.


git-svn-id: https://develop.svn.wordpress.org/trunk@29679 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 19:46:19 +00:00
Helen Hou-Sandi
cb298d8341 Plugin install: Make sure h3's clear floats to avoid layout problems. 
props SergeyBiryukov.
fixes #29465.


git-svn-id: https://develop.svn.wordpress.org/trunk@29676 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 18:28:23 +00:00
Dominik Schilling (ocean90)
1c82a3bf80 Language Pack Upgrader: Check return value before accessing the first array key. 
Prevents a fatal error when Language_Pack_Upgrader::bulk_upgrade() returns a WP_Error object.

fixes #29470.

git-svn-id: https://develop.svn.wordpress.org/trunk@29675 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 18:27:12 +00:00
Helen Hou-Sandi
3ae3ae5ab2 Modals: Remove some remnant unnecessary blue glow focus styling. 
fixes #29147.


git-svn-id: https://develop.svn.wordpress.org/trunk@29674 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 18:26:18 +00:00
Dominik Schilling (ocean90)
c680af75e8 Install: Only show the language chooser when we have access to the filesystem without asking for credentials. 
fixes #29397.

git-svn-id: https://develop.svn.wordpress.org/trunk@29673 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 18:06:36 +00:00
Dominik Schilling (ocean90)
97921c9fa5 Menus: Improve performance for title live updating. Add change event for IE < 9. 
props helen, SergeyBiryukov.
fixes #23076.

git-svn-id: https://develop.svn.wordpress.org/trunk@29672 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 13:22:14 +00:00
Sergey Biryukov
bd07f41256 Restore 'insert-media-button' as an ID attribute for the first instance of media_buttons(). Remove IDs for subsequent instances. 
props nacin.
fixes #28090.

git-svn-id: https://develop.svn.wordpress.org/trunk@29671 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 09:07:08 +00:00
Sergey Biryukov
81d1c6d2c4 Use wp_admin_css() to enqueue stylesheets in setup-config.php. 
fixes #29464.

git-svn-id: https://develop.svn.wordpress.org/trunk@29670 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 08:53:23 +00:00
Sergey Biryukov
21aa7259c4 Re-initialize $wp_locale global after changing the default textdomain on installation screens. 
props ocean90.
fixes #29452.

git-svn-id: https://develop.svn.wordpress.org/trunk@29669 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 08:09:56 +00:00
Andrew Nacin
7bdd5a7a2e Plugin install: The sort callback doesn't need to be public. 
props helen.
fixes #28673.


git-svn-id: https://develop.svn.wordpress.org/trunk@29666 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 06:50:48 +00:00
Helen Hou-Sandi
2f71d7d8e4 Comments: Simplify JS for inline edit and reply. 
fixes #27533.


git-svn-id: https://develop.svn.wordpress.org/trunk@29662 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 03:56:05 +00:00
Helen Hou-Sandi
e12d2db484 Media: Translate a string for the search placeholder. 
props alex-ye.
fixes #29448.


git-svn-id: https://develop.svn.wordpress.org/trunk@29659 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-01 19:53:37 +00:00
Andrew Ozz
c3222171cd Editor expand: 
- Adjust calculation when comparing sidebar position to wpfooter top. Fixes an annoying jumping when the user scrolls off the bottom.
- Use a var for the 'bottom' distance of the sidebar.
- Fix sidebar pinning when it's height is nearly the same as the viewport height.
Fixes #29349

git-svn-id: https://develop.svn.wordpress.org/trunk@29656 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-01 18:48:07 +00:00
Andrew Ozz
1f2ff1d3f3 Editor expand: add docs for the wp_editor_expand filter, props DrewAPicture, fixes #29423 
git-svn-id: https://develop.svn.wordpress.org/trunk@29654 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-29 02:37:59 +00:00
Andrew Ozz
fcc188193f Editor expand: add a filter to turn it off from PHP, fixes #29423 
git-svn-id: https://develop.svn.wordpress.org/trunk@29653 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-29 02:27:06 +00:00
Helen Hou-Sandi
5d2038c8cd Sync tagline from about page with credits and freedoms. 
props rickalee.
fixes #29409.


git-svn-id: https://develop.svn.wordpress.org/trunk@29652 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-28 17:52:16 +00:00
Sergey Biryukov
368e2ba299 Fix typo in media help text. 
props tai.
fixes #29412.

git-svn-id: https://develop.svn.wordpress.org/trunk@29651 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-28 07:52:13 +00:00
Helen Hou-Sandi
1a1343dbd0 Correct a Sass typo that somehow slipped by in [29616]. 
see #28267.


git-svn-id: https://develop.svn.wordpress.org/trunk@29648 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-27 06:31:22 +00:00
Helen Hou-Sandi
2092bd3092 Help tabs: Update media help text to reflect 4.0. 
fixes #28654.


git-svn-id: https://develop.svn.wordpress.org/trunk@29646 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-27 06:11:28 +00:00
Helen Hou-Sandi
5c64d1f25b Media library: Ensure the header area is spaced consistently between view modes. 
see #28946.


git-svn-id: https://develop.svn.wordpress.org/trunk@29645 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-27 05:39:40 +00:00
Helen Hou-Sandi
2db9b4be18 About page, at last. 
All strings are available for translation. We anticipate few, if any, changes before release. Images and video will be moved to w.org soon.

props ryelle, melchoyce, nacin, MarkJaquith, helen, DrewAPicture, kpdesign.
fixes #29243.


git-svn-id: https://develop.svn.wordpress.org/trunk@29643 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-27 04:39:14 +00:00
Andrew Nacin
04da8db743 Help tabs: Update plugin install and media help text to reflect 4.0. 
see #28654.


git-svn-id: https://develop.svn.wordpress.org/trunk@29642 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-27 04:38:12 +00:00
Helen Hou-Sandi
f1f0eb61ff Media: views_upload filter expects an array, not a string. 
see #28946.


git-svn-id: https://develop.svn.wordpress.org/trunk@29641 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-27 03:06:00 +00:00
Andrew Nacin
61ce27e467 Adjust [29634] so the Upload Plugin button can be shown. see #29236. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29637 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-27 02:58:46 +00:00
Andrew Nacin
8564e3a491 Plugin installer: Minor adjustments to aid with discovery. 
fixes #29387.


git-svn-id: https://develop.svn.wordpress.org/trunk@29636 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-27 02:52:29 +00:00
Andrew Nacin
322991024f Plugin/Theme Uploads: New capabilities; unify UIs; ensure compatibility with old filters. 
Introduce upload_plugins and upload_themes capabilities to allow blocking of plugin and theme uploads, versus the old hacky (and not secure) ways of just hiding UI tabs. These are simply meta capabilities that map to install_plugins and install_themes.
 
Also:
 * Use the same nice design for the plugin upload screen as the theme upload screen.
 * Better compatibility for the old install_themes_tabs filter added in [29002]. see #28578.
 * Ensure using the install_plugins_tabs filter to remove the upload tab removes the new button.
 * Use 'Add Plugins' instead of 'Install Plugins' to match 'Add Themes'.

fixes #29236.


git-svn-id: https://develop.svn.wordpress.org/trunk@29634 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-27 01:31:05 +00:00
Dominik Schilling (ocean90)
8ee417d4f4 Language Form: The language option for $wp_local_package should get the same attributes as the other languages. 
see #15677.

git-svn-id: https://develop.svn.wordpress.org/trunk@29633 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-26 22:26:43 +00:00