Andrew Ozz
8e403519db
TinyMCE gallery preview: fix errors when an image doesn't have/is smaller than thumbnail size, props gcorne, see #26959
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27580 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-18 03:24:17 +00:00
Andrew Ozz
30a83e48e2
TinyMCE: move the caption and gallery toolbars to the right, fix selected gallery border/outline, see #27320
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27579 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-18 02:29:45 +00:00
Andrew Ozz
20eabd30ef
TinyMCE:
...
- Update the styling of the image caption and gallery toolbars.
- Fix issue where the hidden clipboard div in wpView.
- Switch to using the pencil dashicon for Edit.
- Add `max-width: 100%;` to images in the gallery preview and adjust column widths.
Props cramdesign, mattheu, gcorne, melchoyce, see #27320 , fixes #27376 , fixes #27354
git-svn-id: https://develop.svn.wordpress.org/trunk@27578 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-18 00:19:17 +00:00
Andrew Nacin
f36f5c5cdc
Style the cursor in the image editor in the media modal.
...
props tomauger.
fixes #27392 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27577 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-18 00:16:35 +00:00
Andrew Nacin
c914491693
Heartbeat: Hooks should always receive unslashed data.
...
This affects the privileged hooks; the unprivileged hooks already received unslashed data.
props johnbillion, TobiasBg.
fixes #27260 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27576 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-18 00:14:48 +00:00
Andrew Nacin
9d5ce494e4
Clarify that unregister_default_headers() returns void in some situations. fixes #21876 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27575 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-18 00:11:39 +00:00
Dominik Schilling (ocean90)
d23e0a556c
Customizer: Use esc_url_raw
to escape customizer URL settings to prevent double encoding.
...
props westonruter, ocean90.
fixes #26569 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27574 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-17 22:15:27 +00:00
Lance Willett
0ab93452d1
Twenty Fourteen: merge two similar strings in Customizer featured content help text. Props celloexpressions, fixes #26647 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27573 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-17 22:06:08 +00:00
Lance Willett
8f24286ec7
Twenty Twelve: style select
element. Props ramonchiara, fixes #27434 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27572 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-17 21:57:15 +00:00
Lance Willett
14cab57c71
Twenty Twelve: remove unused singular
selectors in print CSS block. Props jbkkd, fixes #26866 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27571 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-17 21:55:09 +00:00
Lance Willett
96abb5ed9a
Twenty Eleven: make sure top post meta output isn't broken on small screens. Fixes #27061 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27570 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-17 21:50:59 +00:00
Lance Willett
0ecf62462b
Twenty Eleven: only show secondary skip link on pages with secondary content, and remove duplicate title attribute in site title output. Props bcworkz, fixes #26950 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27569 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-17 21:49:10 +00:00
Andrew Nacin
2e9869e49a
Avoid notices in wp_notify_postauthor() when a post has no author.
...
props drozdz.
fixes #26659 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27568 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-17 20:30:04 +00:00
Andrew Nacin
7fa7c1340e
Use get_comment_link() in wp_notify_postauthor().
...
Fixes pagination for the link directly to the moderated comment.
props eatingrules.
fixes #26133 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27567 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-17 20:19:29 +00:00
Andrew Nacin
c35a53f8bc
Filesystem: Fix getchmod() for direct and ssh2 transports, for directories.
...
props DavidAnderson.
fixes #26598 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27566 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-17 20:16:40 +00:00
Andrew Nacin
b6195eb82a
In is_serialized(), use substr() rather than array access, for compatibility with multibyte overloading.
...
props SergeyBiryukov.
fixes #18007 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27565 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-17 20:08:25 +00:00
Andrew Nacin
405615dd6a
Comments dashboard widget: Use the proper class to avoid stretched "unapproved" red lines.
...
fixes #26910 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27564 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-17 19:53:22 +00:00
Andrew Nacin
a641b9fb55
Cap and theme support checks for the welcome panel.
...
props MikeHansenMe.
fixes #26276 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27563 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-17 19:46:15 +00:00
Andrew Nacin
681ca37c63
Return false from metadata_exists() if the get_$type_metadata filter returns a false value.
...
props xknown.
fixes #22746 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27562 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-17 19:39:31 +00:00
Dominik Schilling (ocean90)
adf2b46b8e
In Recent Posts widget set default number to 5.
...
props afercia.
fixes #27417 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27561 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-17 17:00:22 +00:00
Sergey Biryukov
d4986f1b61
Avoid PHP notices in Media Library if an attachment parent post type no longer exists.
...
props wpsmith.
fixes #27439 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27560 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-17 15:32:32 +00:00
Andrew Ozz
6d13e3e1ff
Restyle the plugin install details modal to match the rest of the admin. Props avryl and paulwilde for initial mockup, see #26952
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27559 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-16 18:27:38 +00:00
Andrew Nacin
6c28dfde29
Define DOING_AJAX earlier in async-upload.php.
...
props avryl.
fixes #27387 . see [22902].
git-svn-id: https://develop.svn.wordpress.org/trunk@27558 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-15 19:58:52 +00:00
Andrew Nacin
d017a789bc
Send a charset header when erroring out in wp_check_php_mysql_versions().
...
props rodrigosprimo.
fixes #26536 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27557 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-15 06:16:10 +00:00
Andrew Nacin
05911cc3d4
Explicitly assign menu term relationship rather than piggybacking on wp_insert_post() with the tax_input argument.
...
That argument currently depends on user context (see #19373 ).
Adds unit test for properly updating orphaned menu items.
props danielbachhuber.
fixes #27113 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27556 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-15 06:06:41 +00:00
Andrew Nacin
ad650e283b
Themes screens: Lose search input focus when pressing enter.
...
This allows the keyboard to close on iOS, for example.
props matveb.
fixes #27233 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27555 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-15 05:13:23 +00:00
Andrew Nacin
f4cc32fac9
XML-RPC: In wp.editPost, Remove all terms in a taxonomy when an empty array is explicitly passed.
...
props jstraitiff, maxcutler.
fixes #26686 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27554 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-15 05:08:40 +00:00
Andrew Nacin
890b809bb9
XML-RPC: Include 'sticky' in the struct returned from metaWeblog.getRecentPosts.
...
Using wp.getPosts is preferred and non-WP XML-RPC APIs are no longer actively maintained. This is simply for parity with existing MW methods.
props soulseekah.
fixes #26679 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27553 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-15 05:04:54 +00:00
Andrew Nacin
0ed014743d
Allow query strings for servers in IXR_Client and WP_HTTP_IXR_Client.
...
props cfinke.
fixes #26947 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27552 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-15 05:00:27 +00:00
Andrew Nacin
8355232a65
Avoid saving slashed data in XML-RPC's wp.setOptions.
...
props danielbachhuber.
fixes #22936 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27551 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-15 04:46:53 +00:00
Andrew Nacin
5adf89fe26
Pass feed_type arg in wp_list_authors() to get_author_feed_link().
...
Adds a slate of tests for wp_list_authors().
props MikeHansenMe.
fixes #26538 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27550 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-15 04:42:57 +00:00
Andrew Nacin
4380d80c62
Permalink Settings: Don't show "update your .htaccess now" if nothing needs to change.
...
props ldebrouwer, MikeHansenMe.
fixes #19268 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27549 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-15 04:34:23 +00:00
Sergey Biryukov
1f8285b2e1
Fix .comment-grey-bubble markup and remove a stray </h5> tag.
...
props avryl.
fixes #27408 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27548 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-15 04:31:58 +00:00
Andrew Nacin
2123afcbd3
All destructive row actions should be styled as such.
...
This fixes spam and trash links in the dashboard activity widget.
props avryl.
fixes #27370 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27547 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-15 04:25:55 +00:00
Dion Hulse
526bf7d352
WP_Filesystem: Update request_filesystem_credentials() to handle the correct ssh value of FS_METHOD. Props jnielsendotnet. Fixes #27265
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27546 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-15 03:08:47 +00:00
Andrew Ozz
0fdb6dadfb
TinyMCE: add internal command and shortcut (Alt+Shift+X) for toggling <code>. Define a button that can be added to any toolbar as wp_code
. See #6113
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27545 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 22:42:59 +00:00
Scott Taylor
b6e2bd9f0e
MCE Views: don't (re-)render views if the format of the content is "raw" to avoid adding additional undo levels on undo/redo.
...
Props gcorne.
Fixes #27416 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27544 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 20:40:44 +00:00
Dominik Schilling (ocean90)
a339826668
Widget Customizer: Make temp hooks final and add inline docs.
...
New hooks are `dynamic_sidebar_before`, `dynamic_sidebar_after`, `dynamic_sidebar_has_widgets ` and `is_active_sidebar`.
Remove obsolete use of hacky dynamic_sidebar hook.
props westonruter, DrewAPicture.
fixes #25368 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27543 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 20:30:54 +00:00
Scott Taylor
f2164771a7
In wp.media.mixin
, add ua
and a compat
map to separate and clarify browser detection and support. Leverage Underscore list iterators in isCompatible()
.
...
See #27389 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27542 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 20:25:31 +00:00
Dominik Schilling (ocean90)
9e6f811c2b
Widget Customizer: Move widget area sections to bottom.
...
Since a theme can have a lot of widget areas and we don't want to bury third-party sections, bump the widget sections to the bottom with a priority of 1000+. Fixes also the ordering.
props westonruter.
fixes #27401 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27541 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 20:00:09 +00:00
Dominik Schilling (ocean90)
cecef45157
Customizer: Introduce a processing state.
...
The processing state will prevent a save when it doesn't return 0.
Widget Customizer will use the state to prevent a save while a widget is updating, which is an asynchronous process.
props westonruter.
fixes #27390 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27540 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 19:15:04 +00:00
Scott Taylor
bfd0ac1099
The canPlayType
property for audio and video in JS is so bad that the official valid responses are "probably" and "maybe". There are many cases where we might want to know if an audio|video tag is gonna blow up in our face before even attempting to make a MediaElementPlayer
instance out of it.
...
The best (and most cautious) way to tackle this is to whitelist types by browser. Imagine that one implemented MEjs in TinyMCE's rich editor mode, this would be very helpful.
Add `isCompatible( $media )` to `wp.media.mixin`. Future features will use this.
See #27389 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27539 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 14:35:49 +00:00
Scott Taylor
2ba763c9ba
Move removePlayer()
and unsetPlayer()
to wp.media.mixin
so that other classes can take advantage of them.
...
* `removePlayer()` is an alternative to MediaElement's player removal method that does not re-add the audio|video element back to the DOM.
* `unsetPlayer()` will check for an existing `player` property on the passed instance and pause all players before calling `unsetPlayer()`
See #27389 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27538 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 13:47:24 +00:00
Scott Taylor
3d244e1fed
Rather than extending wp.media.mixin
, only borrow coerce
when necessary in wp.media.audio|video|collection
. wp.media.mixin
will make sense to be mixed in for classes that expect to interact with the player. More universal methods can be added and inherited by all those who extend their prototype with it.
...
Assuming someone had implemented players in the editor, pause all players when switching between editor tabs. A method, `pauseAllPlayers`, has been added to `wp.media.mixin`.
See #27389 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27537 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 13:16:07 +00:00
Scott Taylor
5e1e5c53ec
In media.model.PostMedia
, for these 2 scenarios:
...
* `src` is set, and 'Add a Source' results in the same file (or a file with the same extension) being added
* `src` is set, and 'Replace Audio|Video' is used, which will add a model property named by the attachment's extension
... call `model.unset( 'src' )`.
See #27389 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27536 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 12:59:28 +00:00
Scott Taylor
12792afdde
Make media.view.VideoDetails.prepareSrc
a static class method instead of an instance method. Properly pairs it with its incrementing instances
property.
...
See #27389 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27535 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 12:42:57 +00:00
Scott Taylor
86722dfaaa
Load MediaElement's CSS when TinyMCE is loaded via $mce_css
in editor_settings()
. Add some baseline styles in wp-content.css
for audio, video, and embed tags to ensure their max-width
is 100%
, regardless of whether MEjs is implemented in TinyMCE.
...
See #27389 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27534 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 12:33:24 +00:00
Scott Taylor
4a2ffa917c
When rendering Underscore templates for Audio/Video details, use 2 new PHP functions to render the markup for audio and video tags: wp_underscore_audio_template()
and wp_underscore_video_template()
.
...
Future JS templates can follow the convention of expecting `data` to be passed to them containing a `model` property.
See #27389 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27533 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 12:19:40 +00:00
Andrew Ozz
83501070d5
Modals: darken all overlays, update all box-shadows and headings, correct thickbox styling, make the link modal narrower and bring back the animation (css transition). Props avryl, see #26952
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27532 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 05:54:16 +00:00
Andrew Ozz
a33829d1d0
Drag/drop upload: don't trigger on "local" dragging, hide the overlay on click. Props kovshenin, fixes #19845
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27531 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-14 00:41:12 +00:00