Scott Taylor
8fa5426485
Users List Table: show the "Change role to" dropdown on the top and bottom. Currently only shows on top.
...
See #27743 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34636 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 19:10:08 +00:00
Drew Jaynes
b3f49e0cdf
Docs: Fix some syntatical issues in the DocBlock for WP::send_headers()
following [34632].
...
See #20226 . See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34635 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 18:48:14 +00:00
Scott Taylor
4dc810ad3c
Feature Image: Improve the preview for transparent background images by using CSS3 to show a checkered background.
...
Props metodiew.
Fixes #33299 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34634 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 18:40:40 +00:00
Scott Taylor
51b3eb592d
After [34629], update unit tests to reflect this change.
...
See #32093 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34633 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 18:29:53 +00:00
Scott Taylor
f802fef76f
Update the docs in WP
to explain the need to do [34476].
...
Fixes #20226 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34632 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 18:27:15 +00:00
Drew Jaynes
fe14c06e0a
Docs: Add documentation for the $browse
, $user
, $search
, $author
, $tag
, $installed_plugins
, and $page
parameters in plugins_api()
.
...
Props ocean90.
Fixes #34035 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34631 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 18:12:59 +00:00
Scott Taylor
61d6854bae
Nav Menus: in wp_nav_menu()
, $container
is already bound to a list of allowed tags. PHP, being its whimsical self, while return true
if someone sets $container
to true
via in_array( true, [ 'div', 'nav' ] )
. Check that $container
is a string before the in_array()
check. 'true'
does not pass.
...
Props shedonist for the original patch.
Fixes #32464 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34630 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 18:12:20 +00:00
Scott Taylor
b45a72a67c
Add size-$size
class to <img>
in wp_get_attachment_image()
.
...
Fixes #32093 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34629 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 17:54:01 +00:00
Boone Gorges
eb6430708b
Add test for get_term_by( 'slug' )
behavior with accented chars.
...
When passing a value of 'slug' to `wp_insert_term()` that contains non-ASCII
characters, WordPress converts accented characters to non-accented versions.
(See `sanitize_title()` and `remove_accents()`.) The same conversion happens
when fetching when fetching a term using a slug. In this way, it's possible to
create a term and fetch it using the same accented string, even though the slug
is actually stored with non-accented characters.
See #16282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34628 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 16:31:47 +00:00
Boone Gorges
148d6a37fe
Move get_term_by()
tests to their own file.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@34627 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 16:09:12 +00:00
Boone Gorges
8dc7bd8091
Add unit test verifying that 60 char user_login
is valid.
...
Props ruudjoyo.
Fixes #33793 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34626 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 15:41:11 +00:00
Boone Gorges
de0b5c846f
Introduce 'the_category_list'
filter.
...
Used to filter categories as structured data, before building markup in
`get_the_category_list()`.
We use this filter in addition to upstream filters (such as
'get_the_categories'`) because those upstream filters are used in numerous
contexts, while `'the_category_list'` is always used for generating markup
for display.
Props KevinB, ericlewis, SergeyBiryukov, DrewAPicture.
Fixes #9227 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34625 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 02:21:43 +00:00
Boone Gorges
c39a4a6447
Pass the post ID to the get_the_categories
filter.
...
Props SergeyBiryukov.
See #9227 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34624 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 02:16:23 +00:00
Boone Gorges
307c3ca81f
WP_Comment::get_children()
test should be order-agnostic.
...
See #8071 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34623 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 02:00:49 +00:00
Drew Jaynes
5d9625c28c
Restore and deprecate the WP_Widget_Recent_Comments::flush_widget_cache()
method, removed in [34580].
...
Fixes #25556 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34622 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 01:39:37 +00:00
Drew Jaynes
7510d4e58c
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Nav_Menu_Widget
.
...
Props leemon.
Fixes #34015 . Fixes #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34621 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 01:15:13 +00:00
Drew Jaynes
982d5b99ea
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_Archives
.
...
Props leemon.
Fixes #34016 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34620 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 01:10:38 +00:00
Drew Jaynes
9909c7ff2b
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_Calendar
.
...
Props leemon.
Fixes #34017 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34619 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 01:06:20 +00:00
Drew Jaynes
b8264d11bc
Docs: Improve documentation for the __construct()
, widget()
, update()
, form()
, and _get_current_taxonomy()
methods in WP_Widget_Categories
.
...
Props leemon.
Fixes #34018 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34618 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 01:03:31 +00:00
Drew Jaynes
aec4d6abe9
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_Links
.
...
Props leemon.
Fixes #34019 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34617 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:59:44 +00:00
Drew Jaynes
e9f835dc43
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_Meta
.
...
Props leemon.
Fixes #34020 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34616 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:57:03 +00:00
Drew Jaynes
f90a2dbe1c
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_Pages
.
...
Props leemon.
Fixes #34021 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34615 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:53:36 +00:00
Drew Jaynes
f2af1a6a1f
Docs: Improve documentation for the __construct()
, recent_comments_style()
, widget()
, update()
, and form()
methods in WP_Widget_Recent_Comments
.
...
Also fixes a typo in the class DocBlock.
Props leemon.
Fixes #34022 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34614 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:50:04 +00:00
Drew Jaynes
fdd92e64cd
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_Recent_Posts
.
...
Also fixes a typo in the class DocBlock.
Props leemon.
Fixes #34023 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34613 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:45:42 +00:00
Drew Jaynes
14cac9aded
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_RSS
.
...
Props leemon.
Fixes #34024 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34612 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:41:47 +00:00
Drew Jaynes
f111c41375
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_Search
.
...
Props leemon.
Fixes #34025 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34611 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:36:26 +00:00
Drew Jaynes
b28f41f852
Docs: Improve the documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_Tag_Cloud
.
...
Props leemon.
Fixes #34026 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34610 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:31:59 +00:00
Drew Jaynes
d6169cab23
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_Text
.
...
(first!) Props leemon.
Fixes #34027 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34609 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:26:56 +00:00
John Blackbourn
7e5f54d5ef
Add function signature tests for the pluggable functions in wp-admin/includes/schema.php and wp-admin/includes/upgrade.php.
...
See #33867
git-svn-id: https://develop.svn.wordpress.org/trunk@34608 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 22:03:53 +00:00
John Blackbourn
4196a0751c
Add function signature tests for the pluggable functions in wp-includes/cache.php
.
...
See #33867
git-svn-id: https://develop.svn.wordpress.org/trunk@34607 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 22:02:15 +00:00
Aaron Jorbin
7894562b50
Revert change from true to false in multisite upload test
...
This change was introduced in [34601]. 0 is a special snowflake. The code treats it as if it should fall back to the default, rather than respecting 0 as 0. Essentially, 0 means 100. WAT? This has been discussed previusly in https://core.trac.wordpress.org/ticket/19538#comment:10 . This test should return True right now, but the behavior should be discussed and in the future 0 may mean 0.
See #34037
Props jorbin, boonebgorges
git-svn-id: https://develop.svn.wordpress.org/trunk@34606 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 20:58:22 +00:00
Weston Ruter
ab7d1ae62d
Customize: Prevent showing "Front Page" and "Posts Page" states for pages in list table when show_on_front
is not "page".
...
Changing the `show_on_front` option back to "posts" also resets the `page_on_front` and `page_for_posts` options when updating via the Reading settings page. In the Customizer, however, this is not the case as these other options remain unchanged. This change accounts for this difference in behavior.
Fixes #34004 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34605 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 20:53:32 +00:00
Boone Gorges
19b0ea5a8c
Remove failing xmlrpc upload test.
...
This test was added [34577], but shouldn't have been, because the bug it
describes has not been fixed.
See #21292 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34604 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 20:31:57 +00:00
Scott Taylor
591b743362
After [34577], alter wp_xmlrpc_server::mw_newMediaObject()
to check upload space in multisite.
...
See #21292 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34603 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 19:48:57 +00:00
Scott Taylor
7cd7d4622c
After [34601], some more cleanup.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@34602 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 19:28:34 +00:00
Scott Taylor
4470cbf7e3
After [34577] (not because of), uncover and fix some horrifying anomalies in Tests_Multisite_Site
.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@34601 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 19:10:12 +00:00
Aaron Jorbin
aedc063418
Use an http URL rather then an https URL for tests
...
Travis doesn't properly support SSL on older versions of PHP. Since we don't test for SSL support in all of the tests, this can cause these tests to fail. This changes a URL introduced in [34568]
See #33968
git-svn-id: https://develop.svn.wordpress.org/trunk@34600 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 17:47:24 +00:00
Boone Gorges
eb8b241559
Improve post field lazyloading for comments.
...
[34583] modified comment queries so that all post fields are no longer loaded
by default. Instead, they are loaded only when requested on individual comment
objects. This changeset improves that flow:
* `WP_Comment` magic methods `__isset()` and `__get()` should only load the post when a post field is being requested.
* The new `update_comment_post_cache` argument for `WP_Comment_Query` allows developers to specify that, when comments are queried, all of the posts matching those comments should be loaded into cache with a single DB hit. This parameter defaults to false, since typical comment queries are linked to a single post.
Fixes #27571 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34599 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 16:01:05 +00:00
Dominik Schilling (ocean90)
5da80b3d64
Plugins: Don't request all fields via plugins_api( 'plugin_information' )
for plugin installs and update checks.
...
The Plugins API returns a lot of data by default (see [34596]) but when installing or checking for updates we don't need all of it. To save bandwidth, memory and time request only required fields.
Fixes #34030 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34598 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 15:49:06 +00:00
John Blackbourn
60660b0055
Remove the unnecessary horizontal rules in the oEmbed providers table to tidy up the Code Reference.
...
See #32246
git-svn-id: https://develop.svn.wordpress.org/trunk@34597 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 15:16:05 +00:00
Drew Jaynes
de8abd004f
Docs: Add much-needed (and awesome) hash-notation-style documentation for the $args
parameter in the plugins_api()
DocBlock.
...
Also fixes up some formatting in the DocBlock summary and description, and adds a link to the function reference, where supplementary information on return object structs and formatting will live.
Props ocean90.
Fixes #34035 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34596 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 15:12:51 +00:00
Boone Gorges
ecf4b81d72
Use correct property name when setting child comments.
...
This fixes a typo from [34546], uncovered by unrelated changes in [34583].
See #8071 , #27571 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34595 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 14:40:15 +00:00
Sergey Biryukov
5569780f8a
Replace a stray semicolon on Edit Page screen with a full stop.
...
Props manolis09, sjmur.
Fixes #33297 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34594 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 13:43:31 +00:00
Drew Jaynes
11e0b8d0b0
Docs: Fix a minor typo from [34592]. Meant to be past-tense, not present.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34593 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 13:13:50 +00:00
Drew Jaynes
b68ae42ddd
Docs: Add missing parameter documentation for $profileuser
in the hook doc for show_password_fields
, added in [11302].
...
Also adds a changelog entry for when the parameter was introduced.
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34592 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 13:10:47 +00:00
Sergey Biryukov
411f0f126e
Network Admin: Properly pass the number of delete plugins to the corresponding message.
...
Fixes #33239 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34591 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 13:10:05 +00:00
Drew Jaynes
35837a00b7
Docs: Relocate the hook doc for the show_password_fields
filter to its duplicate, since the original was removed in [34582].
...
Adds a changelog entry noting the adjustment in behavior, and simplifies the conditional logic.
Fixes #15115 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34590 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 13:04:23 +00:00
Drew Jaynes
8ec9d5e9e9
Docs: Adjust the table of providers in the hook doc for oembed_providers
to use "No" instead of "!" to signify lack of SSL support.
...
When displayed in the Code Reference, the "!" doesn't convey enough information.
See #32246 . See #28507 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34589 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 12:49:44 +00:00
John Blackbourn
4b9cee0af7
Switch to the https
oEmbed endpoint for Animoto because it redirects there anyway.
...
See #28507
git-svn-id: https://develop.svn.wordpress.org/trunk@34588 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 12:23:21 +00:00
John Blackbourn
b387869c4e
Switch to the https
oEmbed endpoint for Dailymotion so secure embeds are supported.
...
See #28507
git-svn-id: https://develop.svn.wordpress.org/trunk@34587 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 11:50:35 +00:00