Scott Taylor
9d873771b7
Eliminate use of extract()
in wp_xmlrpc_server::blogger_editPost()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28412 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 03:24:40 +00:00
Scott Taylor
c4b23f9fc3
Eliminate use of extract()
in Walker_Category_Checklist::start_el()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28411 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 03:13:44 +00:00
Scott Taylor
85d6f8e54f
Eliminate use of extract()
in wp_terms_checklist()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28410 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 03:08:46 +00:00
Scott Taylor
98ca12ef2e
Eliminate use of extract()
in wp_star_rating()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28409 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:56:56 +00:00
Scott Taylor
5e046b92fd
(REALLY) Eliminate use of extract()
in wp_insert_link()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28408 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:54:27 +00:00
Scott Taylor
27ff2a1cd0
Eliminate use of extract()
in get_media_item()
.
...
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28407 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:45:01 +00:00
Scott Taylor
e0ddd2ebf0
Eliminate use of extract()
in wp_insert_link()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28406 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:27:55 +00:00
Scott Taylor
da440f54fd
Eliminate use of extract()
in wp_list_bookmarks()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28405 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:17:52 +00:00
Scott Taylor
30564338b0
Eliminate use of extract()
in _walk_bookmarks()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28404 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:04:50 +00:00
Scott Taylor
0dd9d3aeff
Eliminate use of extract()
in get_bookmarks()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28403 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 01:57:24 +00:00
Scott Taylor
61faf32275
Eliminate use of extract()
in Walker_Page::start_el()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28402 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 01:40:48 +00:00
Scott Taylor
c96d4a94b9
Eliminate use of extract()
in wp_list_pages()
which, surprisingly, didn't even use any of the extracted variables.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28401 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 01:21:20 +00:00
Scott Taylor
c47d71feb2
Add unit tests for wp_list_pages()
.
...
Props MikeHansenMe.
See #27326 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28400 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 01:17:37 +00:00
Scott Taylor
e4a800238f
Eliminate use of extract()
in wp_dropdown_pages()
.
...
Adds unit tests to: `tests/post/template.php`.
There was previously only one wimpy assertion for `wp_dropdown_pages()`.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28399 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 01:11:21 +00:00
Scott Taylor
21e0370e5c
Eliminate use of extract()
in wp_link_pages()
.
...
Adds unit tests to a new file: `tests/post/template.php`.
There were previously no unit tests for `wp_link_pages()`.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28398 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 00:43:40 +00:00
Scott Taylor
9e07b1037e
Eliminate use of extract()
in paginate_links()
. Adds unit tests. Moves tests/general/template.php
(which only had one method) to tests/general/paginateLinks.php
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28397 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-14 22:28:08 +00:00
Scott Taylor
46f15a84ab
Eliminate use of extract()
in display_setup_form()
. Only needs to read password
and password_message
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28396 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-14 16:42:42 +00:00
Lance Willett
44e4e3e4d0
Twenty Thirteen: add accessibility-ready
tag. Fixes #28225 , props BODA1982.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28395 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 23:10:00 +00:00
Drew Jaynes (DrewAPicture)
cfc1b74ddb
Properly split and document the admin_post*
actions into the following four hooks:
...
* `admin_post_nopriv` – for logged-out requests lacking a supplied action
* `admin_post_nopriv_$action – for logged-out requests with a supplied action
* `admin_post` – for logged-in requests lacking a supplied action
* `admin_post_$action` – for logged-in requests with a supplied action
See [28349], [28350], [28351].
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28394 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 07:23:35 +00:00
Drew Jaynes (DrewAPicture)
1954f9b7d4
Clarify inline documentation for back-compat load-*
action hooks.
...
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28393 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 06:27:11 +00:00
Scott Taylor
540826e4e3
Eliminate use of extract()
in wp_list_authors()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28392 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 06:01:33 +00:00
Scott Taylor
bc17731c23
Eliminate use of extract()
in post_tags_meta_box()
and post_categories_meta_box()
.
...
Both functions only need to read `taxonomy`, yet they extract every available variable from `$box['args']`. Even if those variables were useful, there is no attempt to pass them to anything, and scope in PHP does not allow them to be scooped up by inner functions without being passed directly.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28391 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:47:03 +00:00
Scott Taylor
b72bd1c40f
Eliminate use of extract()
in WP_Terms_List_Table::display_rows_or_placeholder()
:
...
* Set variables for `$page` and `$number`
* `list(...) = $this->get_column_info()` can be removed, as none of the variables returned are used.
* `orderby` and `search` can be checked from `$args`, leaving no reason to extract
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28390 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:36:22 +00:00
Scott Taylor
7c0e12f5c6
Eliminate use of extract()
in WP_List_Table::pagination()
:
...
* Set variables instead of extracting `$this->_pagination_args`
* Weird: `$infinite_scroll` is only presently set in subclasses of `WP_List_Table` and never initialized otherwise.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28389 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:26:34 +00:00
Scott Taylor
31e187faa3
Eliminate use of extract()
in WP_Plugin_Install_List_Table::get_table_classes()
. It only needs to read plural
, no need to extract.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28388 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:16:39 +00:00
Scott Taylor
fac2faee93
Eliminate use of extract()
in WP_List_Table::ajax_response()
:
...
* Extracting `$this->_args` is unnecessary since none of the variables produced are present in the method.
* `total_items` and `total_pages` can be read directly from `$this->_pagination_args`
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28387 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:13:09 +00:00
Scott Taylor
a2122e6f7b
Eliminate use of extract()
in WP_List_Table::display()
. The method only needs to read singular
from $this->_args
. Extraction is unnecessary.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28386 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:07:11 +00:00
Scott Taylor
878a974477
Eliminate use of extract()
in WP_Post_Comments_List_Table::display()
. The method only needs to read singular
from $this->_args
. Extraction is unnecessary.
...
Eliminate use of `extract()` in `WP_Comments_List_Table::display()`. The method uses no variables. Extraction can be completely removed.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28385 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:03:26 +00:00
Scott Taylor
f57bdbd238
Eliminate use of extract()
in Custom_Image_Header::step_2()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28384 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:53:13 +00:00
Scott Taylor
ba8e36f94c
Eliminate use of extract()
in the_title_attribute()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28383 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:47:11 +00:00
Scott Taylor
42d6b5dd1e
Eliminate use of extract()
in trackback_url_list()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28382 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:43:22 +00:00
Scott Taylor
671b47ef73
Eliminate use of extract()
in wp-includes/theme-compat/comments-popup.php
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28381 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:39:17 +00:00
Drew Jaynes (DrewAPicture)
6a63c5b59d
Fix a phpdoc typo and multi-line comment syntax in wp-cron.php.
...
Props rclations.
Fixes #28231 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28380 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:38:15 +00:00
Scott Taylor
77731c03fc
Eliminate use of extract()
in wp_get_archives()
.
...
Adds unit tests: `tests/functions/getArchives.php`.
All other unit tests pass.
Props MikeHansenMe, wonderboymusic.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28379 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:28:56 +00:00
Drew Jaynes (DrewAPicture)
3c80d5f86a
Use a proper docs-specific variable for the first parameter passed to the embed_oembed_discover
filter.
...
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28378 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:28:30 +00:00
Drew Jaynes (DrewAPicture)
e2219e3d48
Add a complete short description to the get_attached_media
filter documentation.
...
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28377 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:20:12 +00:00
Drew Jaynes (DrewAPicture)
68f78b1dcc
Clarify documentation for *what* gets "automatically fired" when the do_mu_upgrade
filter evaluates to true in Multisite.
...
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28376 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:17:16 +00:00
Drew Jaynes (DrewAPicture)
d59c371180
Fix incomplete inline documentation for the wp_header_image_attachment_metadata
filter.
...
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28375 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:12:02 +00:00
Scott Taylor
4e0809e3e4
Eliminate use of extract()
in wp_insert_category()
. Adds unit tests. All unit tests pass.
...
Props MikeHansenMe.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28374 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 03:26:51 +00:00
Scott Taylor
b3ff5285f8
Eliminate use of extract()
in wp-activate.php
.
...
Props jeremyfelt, MikeHansenMe.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28373 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 03:13:21 +00:00
Scott Taylor
961f52d367
Add xps
and oxps
extensions to list of supported document types.
...
More: http://en.wikipedia.org/wiki/Open_XML_Paper_Specification
Fixes #15697 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28372 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 07:18:06 +00:00
Scott Taylor
8dc4b88fcf
In wp.media.view.Settings::update()
, when handling checkboxes, check for a value of 'false'
in addition to casting value
to boolean. !! 'false'
evaluates to true
.
...
Props adamsilverstein.
Fixes #23954 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28371 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 07:02:05 +00:00
Scott Taylor
e8b8e881b2
Allow users to set overrides for MediaElement instances by always passing _wpmejsSettings
instead of just _wpmejsSettings.pluginPath
.
...
Props Otto42 for the initial patch.
Fixes #25243 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28370 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 06:24:58 +00:00
Scott Taylor
e1b341cc59
In the Attachment Details
section of the media modal, only add box-shadow
to images. Other mime-type icons look strange with an arbitrary border.
...
Props avryl.
Fixes #27949 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28369 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 06:18:02 +00:00
Scott Taylor
3f59b86ec5
In media_upload_gallery_form()
's inline JavaScript, remove unnecessary comment tags.
...
Fixes #25637 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28368 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 06:11:08 +00:00
Scott Taylor
3a554b5249
In wp_read_image_metadata()
, the values from exif_read_data()
should only override values from iptcparse()
that are empty.
...
Props SergeyBiryukov.
Fixes #23706 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28367 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 05:53:27 +00:00
Scott Taylor
147eeb2147
Avoid a notice in wp_save_image()
by checking $meta['sizes']['thumbnail']
for ! empty()
before setting a variable to it.
...
Props MikeHansenMe.
Fixes #17736 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28366 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 03:41:31 +00:00
Scott Taylor
4826c12c47
Update the default (WP-defined) styles for MediaElement players to be more in-line with our flat aesthetic. Use the new official colors.
...
Props celloexpressions.
Fixes #27516 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28365 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 02:22:42 +00:00
Scott Taylor
9705736cdf
When pausing "all" players attached to MCE views, don't reach into global scope and pause "every" player. Only pause the players bound to MCE views.
...
Fixes #27971 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28364 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 02:06:36 +00:00
Scott Taylor
487da46928
Support loop
for [audio]
and [video]
shortcodes that specify files that are played using MediaElement's Flash plugin bridge.
...
Fixes #27368 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28363 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 01:27:29 +00:00