Commit Graph

26201 Commits

Author SHA1 Message Date
Scott Taylor
b70967302b In get_the_author_posts(), if there is no current $post, return 0 and bail.
Props krogsgard, aaroncampbell.
Fixes #27998.



git-svn-id: https://develop.svn.wordpress.org/trunk@28362 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 00:25:29 +00:00
Scott Taylor
8998c015b3 MediaElement players need clear: both to play nice with adjacent floated elements.
Fixes #27385.



git-svn-id: https://develop.svn.wordpress.org/trunk@28361 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 00:13:49 +00:00
Scott Taylor
d007994bf3 In WP_Terms_List_Table::single_row(), call sanitize_term() on the passed term ($tag).
Props oso96_2000, c3mdigital, scribu. 
It takes a village.
Fixes #16864.


git-svn-id: https://develop.svn.wordpress.org/trunk@28360 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 00:04:38 +00:00
Scott Taylor
2808673b0c Remove the title attribute from markup generated in wp-includes/category-template.php:
* `get_category_parents()`
* `get_the_category_list()`
* `wp_generate_tag_cloud()`
* `Walker_Category::start_el()`	

Props joedolson.
Fixes #26557.	



git-svn-id: https://develop.svn.wordpress.org/trunk@28359 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-10 23:56:12 +00:00
Scott Taylor
a398f38024 First pass at wpview logic for the [embed] shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet.
Props avryl, wonderboymusic.
See #28195.



git-svn-id: https://develop.svn.wordpress.org/trunk@28358 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-10 23:35:08 +00:00
Drew Jaynes (DrewAPicture)
cb5852a813 Add inline documentation of the default arguments for wp_list_pages().
Props garza for the initial patches.
Fixes #11338.


git-svn-id: https://develop.svn.wordpress.org/trunk@28357 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-10 08:01:13 +00:00
Drew Jaynes (DrewAPicture)
f3d9e1ed7e Fix mid-file section header style in wp-admin/includes/ajax-actions.php.
See #28200.


git-svn-id: https://develop.svn.wordpress.org/trunk@28356 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-10 05:01:15 +00:00
Drew Jaynes (DrewAPicture)
de13f1a60c Add baseline doc blocks for all ajax handlers in ajax-actions.php.
Fixes #28200.


git-svn-id: https://develop.svn.wordpress.org/trunk@28355 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-10 04:59:34 +00:00
Drew Jaynes (DrewAPicture)
0b51b6da2e Minor phpDoc fixes for the got_rewrite, got_url_rewrite, and documentation_ignore_functions hooks.
Props GaryJ.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28352 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-08 11:12:11 +00:00
Drew Jaynes (DrewAPicture)
272f7533dc Rename the $action hook in wp-admin/admin-post.php to admin_post{$action}.
Also, clarify documentation of priv vs nopriv prefixing of the hook name.

See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28351 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-08 10:59:17 +00:00
Drew Jaynes (DrewAPicture)
b0d7e6fe3c Revert [28349] in favor of retaining the single dynamic admin_post* hook.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28350 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-08 10:46:41 +00:00
Drew Jaynes (DrewAPicture)
9392b42e97 Convert and rename the $action hook in wp-admin/admin-post to two dynamic hook sets.
* `admin_post_nopriv{$request_action}` is fired for logged-out users
* `admin_post{$request_action}` is fired for logged-in users

Props Otto42, DrewAPicture.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28349 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-08 10:26:07 +00:00
Drew Jaynes (DrewAPicture)
bbd130fe15 Use interpolation instead of concatenation for the manage_{$screen->id}_columns hook name.
Props Otto42.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28348 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-08 09:57:11 +00:00
Drew Jaynes (DrewAPicture)
30c21227be Use an interpolated hook name for edit_{$post_type}_per_page instead of $per_page and adjust docs accordingly.
Also references the correct variable for the `$posts_per_page` parameter in the `edit_posts_per_page` hook doc.

Props Otto42 for the initial patch.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28347 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-08 08:15:48 +00:00
Scott Taylor
7531fd0070 Leverage size_format() when displaying max_upload_size:
* In `media_upload_form()` 
* The `uploader-inline` Underscore template in the media modal. 

Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.

Fixes #25643.



git-svn-id: https://develop.svn.wordpress.org/trunk@28343 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 18:24:47 +00:00
Scott Taylor
bfe7d38650 audio, video, and playlist shortcodes:
* Convert all instances of variable variables to array properties
* Eradicate use of `extract()`
* Rename `$atts` to `$html_atts` where collision with new `$atts` (shortcode atts holder) var might occur

See #22400, #27881.



git-svn-id: https://develop.svn.wordpress.org/trunk@28342 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 17:35:09 +00:00
Lance Willett
28d6842538 Bundled themes: use correct logic in IE conditional comments in header template. Props mikemanger, fixes #28151.
git-svn-id: https://develop.svn.wordpress.org/trunk@28341 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 04:26:07 +00:00
Scott Taylor
451319728b In wp-login.php, break is unreachable after exit
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28340 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:57:17 +00:00
Scott Taylor
4bddd84276 In wpdb, remove dead code:
* In `->tables()`, `break` is unreachable after `return`
* In `->query()`, `$return` is always set, so doesn't need an initial value of `0`
* In `->delete()`, `$bits` is unused

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28339 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:55:32 +00:00
Scott Taylor
e47eb14575 In WP_Widget::update_callback(), $sidebars_widgets is unused.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28338 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:51:31 +00:00
Scott Taylor
f945487f45 In wp-includes/theme.php, break is unreachable after return.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28337 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:49:19 +00:00
Scott Taylor
b99dead052 In print_admin_styles(), $zip is never used after being set. $compress_css does not need to be imported.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28336 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:46:11 +00:00
Scott Taylor
b62ca9c298 In wp_default_scripts(), $max_upload_size and its entangled children $max_up and $max_post create quite the ternary operator... that is never used.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28335 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:44:06 +00:00
Scott Taylor
f63b6cde3a In wp-includes/revision.php - remove dead code:
* In `wp_get_post_autosave()`, `break` is unreachable after `return`
* In `_wp_put_post_revision()`, `$post_id` is set then never used.

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28334 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:37:45 +00:00
Scott Taylor
098a5145c5 In WP_Query, remove duplicate variable setting:
* In `->parse_search_order()`, a value is always set for `$search_orderby`, no need for empty initialization
* In `->get_posts()`, `$fields` is always set, no need for empty initialization

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28333 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:42:28 +00:00
Scott Taylor
16a58e34a2 In get_pages(), $cache does not need to be reset to an empty array. update_post_cache( $pages ) takes care of priming.
In `set_post_thumbnail()`, (accidental) assignment is unnecessary for `$thumbnail_html` as it is not used. 

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28332 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:38:23 +00:00
Scott Taylor
11e65eb200 In wp_get_attachment_link(), $post_title is set and then not used.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28331 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:34:10 +00:00
Scott Taylor
b626b11590 In Walker_Nav_Menu::start_el(), $class_names is set twice before it is used.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28330 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:32:25 +00:00
Scott Taylor
3f2a078f5e In get_network_by_path(), $exact_domains is unused.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28329 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:31:14 +00:00
Scott Taylor
24b03d819b In update_metadata_by_mid(), $original_value is unused.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28328 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:28:02 +00:00
Scott Taylor
e95edb29aa In edit_post_link(), $post_type_obj is unused.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28327 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:26:20 +00:00
Scott Taylor
5cf2a50dba In paginate_links(), break is unreachable after return.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28326 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:24:22 +00:00
Scott Taylor
ef5998eabb In wp-includes/functions.php, remove dead code:
* In `current_time()`, `break` is unreachable after `return`.
* In `add_query_arg()`, `$ret` is set twice before being used.
* In `wp_mkdir_p()`, `$dir_perms` is set twice before being used.

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28325 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:22:22 +00:00
Scott Taylor
5e90fb1b3e In wp_set_comment_status(), the default case returns, so no default value for $status is needed.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28324 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:16:42 +00:00
Scott Taylor
5530fe4c11 In wp-includes/comment-template.php, remove dead code:
* In `get_comment_reply_link()`, `$link` is set twice before it is used.
* In `Walker_Comment::start_lvl()`, `case 'ul':` is unreachable unless placed before `default:`. 
* In `Walker_Comment::end_lvl()`, `case 'ul':` is unreachable unless placed before `default:`.
* In `comment_form()`, `$id` is conditionally set and never used. 

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28323 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:14:35 +00:00
wonderboymusic
2b1c764ec7 In Walker::walk() and Walker::paged_walk(), $id_field is set and never used.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28322 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:08:02 +00:00
Sergey Biryukov
18916debfd Update deleted site message in ms_site_check().
props boonebgorges.
fixes #28150.

git-svn-id: https://develop.svn.wordpress.org/trunk@28321 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:45:54 +00:00
Scott Taylor
0f4f941900 In WP_Image_Editor::get_output_format(), $file_mime and $file_ext are set twice before they are used.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28320 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:36:34 +00:00
Scott Taylor
9ad07c8c28 In wp-includes/class-wp-customize-setting.php, break is unreachable after return.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28319 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:33:03 +00:00
Scott Taylor
376125e0b7 In wp-includes/class-wp-admin-bar.php, break is unreachabled after return.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28318 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:28:46 +00:00
Scott Taylor
c5463c5cb2 In WP_Http_Curl::request(), $theResponse is unused. There are other curl_exec() calls that do not return as well.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28317 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:26:00 +00:00
Scott Taylor
5df63351b2 In wp-includes/bookmark.php, remove dead code:
* In `get_bookmarks()`, `$cache` is set twice before it is used. 
* In `sanitize_bookmark_field()`, `break` is unreachable after `return`

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28316 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:21:50 +00:00
Scott Taylor
22743ee2c4 In wp-admin/users.php, break is unreachabled after exit.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28315 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:18:12 +00:00
Scott Taylor
64fbddfcd5 In core_upgrade_preamble(), $alternate is set then never used.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28314 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:16:34 +00:00
Scott Taylor
cb0578d77e In wp-admin/theme-editor.php, break is unreachabled after exit.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28313 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:15:18 +00:00
Scott Taylor
0f9b925ed5 In wp-admin/post.php, break is unreachabled after exit.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28312 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:14:16 +00:00
Scott Taylor
a9dfbabfe7 In wp-admin/plugins.php, break is unreachabled after exit.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28311 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:12:44 +00:00
Scott Taylor
e742c23af9 In wp-admin/plugin-editor.php, break is unreachabled after exit.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28310 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:11:30 +00:00
wonderboymusic
1da6728dc0 In wp-admin/network/users.php, break is unreachabled after exit.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28309 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:10:01 +00:00
Scott Taylor
aa7cef0549 In wp-admin/network/themes.php, break is unreachabled after exit.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28308 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:07:33 +00:00