Scott Taylor
940b06cff2
Customizer: Nav Menus JS cleanup, first round
...
* In `init`, settings should be fresh and set to default values before extending
* When looping via `_.each`, pass `this` as 3rd arg to bind context
* Settings should be encapsulated in the module, instead of being exposed as static class props
* `currentRefreshMenuInstanceDebouncedCalls` should be encapsulated and renamed, instead of being the longest symbol in the entire codebase
See #32911 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33345 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-21 16:13:36 +00:00
Ella Iseulde Van Dorpe
e2fab60c51
Editor: word count: exclude HTML comments and entities
...
Also make sure `type` is one of the three allowed types and remove unnecessary regex flags.
See #30966 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33344 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-21 15:23:45 +00:00
Scott Taylor
180d8b3eb0
After [33325], add a doc summary.
...
Fixes #20662 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33343 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-21 15:17:30 +00:00
Scott Taylor
47036da32b
Revert [32466], I will pick this up in 4.4.
...
See #32466 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33342 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-21 15:09:28 +00:00
Ella Iseulde Van Dorpe
311d43e2a1
Publish box: fix leading zeros in date format
...
See #30716 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33341 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-21 14:54:15 +00:00
Ella Iseulde Van Dorpe
bcb2d6d0db
Publish box: fix strange date format after change
...
Part props tyxla.
Fixes #30716 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33340 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-21 11:39:20 +00:00
Dominik Schilling (ocean90)
810ace4a5e
Customizer: Avoid duplicate IDs and remove role presentation from menu items reorder button. Follow-up to [33074].
...
props afercia.
fixes #32725 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33339 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-21 11:36:15 +00:00
Ella Iseulde Van Dorpe
6da15e0528
TinyMCE: views: make sure gallery captions update
...
Part props dmsnell.
Fixes #32779 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33338 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-20 23:55:46 +00:00
Ella Iseulde Van Dorpe
8768541ce5
JSHint: don't redeclare globals listed in .jshintrc
...
See #33021 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33337 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-20 23:38:17 +00:00
Konstantin Obenland
06f92d93cc
Customize: Align screen options toggle with info icon.
...
Fixes #32733 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33336 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-20 21:20:15 +00:00
Konstantin Obenland
358ab7b010
Tests: Remove test for delete_site_icon()
.
...
Removed in [33329].
H/t wonderboymusic.
See #16434 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33335 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-20 20:52:39 +00:00
Konstantin Obenland
8ea9ecdeb1
Toolbar: Restore scroll-to-top functionality.
...
H/t Ipstenu.
Introduced in [33056].
See #29906 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33334 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-20 20:01:34 +00:00
Konstantin Obenland
b480968d9b
Site Icon: Center initial crop position.
...
Starting out at the center of the image makes for a better user experience.
Props iseulde.
Fixes #33050 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33333 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-20 19:01:19 +00:00
Konstantin Obenland
b619b0c194
Site Icon: Improve vertical spacing in preview.
...
Props eliorivero.
Fixes #33038 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33332 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-20 19:00:58 +00:00
Konstantin Obenland
dc90d4217c
Passwords: Use small screen styles for all small screens.
...
H/t johnjamesjacoby.
Introduced in [33206].
See #32589 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33331 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-20 19:00:29 +00:00
Konstantin Obenland
66f22b5c2c
Use WP's version number after monkey-patch in [33329].
...
git-svn-id: https://develop.svn.wordpress.org/trunk@33330 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-20 17:26:05 +00:00
Konstantin Obenland
9fe59ced57
Site Icon: Add crop preview to the media modal.
...
* Monkey patches imgAreaSelect library to support touch events.
* Removes Settings version of Site Icon since it would have been the same flow.
* Removes default value for Customizer setting - there is no default favicon.
Fixes #16434 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33329 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-20 15:56:19 +00:00
Weston Ruter
4ff443dd11
Customizer: Fix previewing certain changes to nav menus.
...
Addresses regression introduced in [33138], where deleted menu items would not be removed from the preview, and changes to a location's assigned menu would likewise not preview. Also makes the binding of the setting change events more robust.
Fixes #33010 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33328 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-20 07:44:00 +00:00
Dion Hulse
534386fcaf
Allow HTML/entities in the Active Theme Name in the themes.php & Customizer templates.
...
Props iCaleb
Fixes #33036
git-svn-id: https://develop.svn.wordpress.org/trunk@33327 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-20 01:45:08 +00:00
Scott Taylor
e690aa50ad
Ensure that private posts cannot be made sticky via Quick Edit.
...
DRY the logic for stickies in `wp_xmlrpc_server` by introducing `->_toggle_sticky()`.
Props wonderboymusic, obenland, chriscct7.
Fixes #20662 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33325 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-19 18:08:55 +00:00
Andrew Nacin
a22368a225
JSHint: Use 'global' rather than 'globals' for inline configuration.
...
Don't declare a global already listed in .jshintrc.
props johnjamesjacoby.
fixes #33021 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33324 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-19 17:08:47 +00:00
Weston Ruter
9ba638910c
Customizer: Indicate when there are no nav menu items available for a given type.
...
Props celloexpressions, valendesigns, rittesh.patel.
Fixes #32810 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33323 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-19 00:05:26 +00:00
Weston Ruter
5c76979fb8
Customizer: Finish unit tests for nav menus.
...
Removes object_type restriction to allow for future extensibility. Refactors some methods to improve testability. Includes new tests for Ajax requests.
Fixes #32687 .
Props valendesigns, welcher, westonruter.
git-svn-id: https://develop.svn.wordpress.org/trunk@33322 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-18 23:19:33 +00:00
Weston Ruter
cd327a2807
Customizer: Prevent wp-a11y
from being needlessly enqueued in the customizer preview.
...
Reduces the number of live regions that screen readers have to deal with.
Fixes #33001 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33321 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-18 17:09:40 +00:00
Ella Iseulde Van Dorpe
16e22cd0aa
Editor: word count: count astrals as one character
...
This makes sure an emoji, for example, is counted as one character.
See #30966 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33320 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-18 11:41:25 +00:00
Drew Jaynes
c1e158cf87
Update the description for get_the_category()
with helpful information for the proper function to use for custom taxonomies.
...
Also adds a missing return description.
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33318 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-17 22:57:20 +00:00
Weston Ruter
d755a8d7f5
Customizer: Move "Menu options" heading outside of a nav menu auto-add control's label.
...
Standardizes capitalization. Amends [33189].
Props valendesigns.
Fixes #32820 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33317 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-17 22:41:56 +00:00
Gary Pendergast
7217a4f6e5
WPDB: ::strip_text_from_query()
doesn't pass a length to ::strip_invalid_text()
, which was causing queries to fail when they contained characters that needed to be sanity checked by MySQL.
...
Props dd32, mdawaffe, pento.
Fixes #32279 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33310 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-17 07:06:33 +00:00
Gary Pendergast
bea2bf1502
WPDB: Remove some of the complexities in ::strip_invalid_text()
associated with switching character sets between queries. Instead of trying to dynamically change connection character sets, we now rely on the value of ::charset
. This also fixes the case where queries were being blocked when DB_CHARSET
was utf8
, but the column character set was non-utf8
.
...
Fixes #32165 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33308 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-17 06:33:36 +00:00
Andrew Ozz
ce14a75784
wpLink: fix vertical alignment of the fields labels.
...
Part props daniluk4000. Fixes #32829 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33300 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 23:57:27 +00:00
Ella Iseulde Van Dorpe
c2c5c5ac27
Editor: word count: exclude shortcodes
...
Props desaiuditd, adamsilverstein, azaozz and iseulde.
Fixes #27386 . See #30966 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33299 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 21:08:05 +00:00
Ella Iseulde Van Dorpe
03653fa600
Editor: Add Media should be a button
...
Props afercia.
Fixes #32969 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33298 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 19:37:07 +00:00
Helen Hou-Sandi
c40301f1a0
Customizer: Ensure consistent margins in sections.
...
Since the customizer dynamically changes, `nth-child` selectors are not always a great idea.
props afercia.
fixes #32902 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33297 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 19:14:31 +00:00
Boone Gorges
cddbfd2727
Improve function description for wp_transition_post_status()
.
...
The documentation should make it clear that the function does not modify the
post object in the database, but only fires hooks related to the transition.
Props AramZS.
Fixes #33014 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33296 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 14:34:42 +00:00
Ella Iseulde Van Dorpe
51e2bc173d
Editor: word count: remove redundant script enqueuing
...
It is now a dependency of `post`.
Part props johnjamesjacoby.
Fixes #31766 . See #30966 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33295 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 12:40:51 +00:00
Ella Iseulde Van Dorpe
795b2211fb
TinyMCE: inline toolbar: fix memory leaks
...
Part props ungestaltbar.
Fixes #32873 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33294 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 11:10:28 +00:00
Ella Iseulde Van Dorpe
524225187f
Editor: DFW: hide udate message
...
Props miqrogroove.
Fixes #32674 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33293 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 10:37:44 +00:00
Ella Iseulde Van Dorpe
129a3affe5
Editor: word count: exclude more characters
...
Also only exclude these characters for the `words` type. They should be counted for other types.
Add the ASCIIOnly option to the uglify config to preserve escaped unicode characters.
See #30966 . Fixes #27391 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33292 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 09:44:43 +00:00
Ella Iseulde Van Dorpe
4b975d8278
Editor: word count: update translator message
...
See #30966 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33291 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 23:51:41 +00:00
iseulde
e1242b6979
Editor: word count: add all
type
...
This type will count all characters including spaces.
See #30966 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33290 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 23:47:02 +00:00
Ella Iseulde Van Dorpe
302a039de1
TinyMCE: fix visual regressions (2)
...
See #32801 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33289 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 23:34:40 +00:00
Konstantin Obenland
149ab85049
4.3-beta3-33288
...
git-svn-id: https://develop.svn.wordpress.org/trunk@33288 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 21:50:34 +00:00
Konstantin Obenland
ef95b71523
4.3-beta3
...
git-svn-id: https://develop.svn.wordpress.org/trunk@33287 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 21:42:47 +00:00
Andrew Ozz
dc3565a6a1
TinyMCE, keyboard shortcuts help: make the popup wider to easily accommodate translations.
...
Part props ocean90. See #31441 ;
git-svn-id: https://develop.svn.wordpress.org/trunk@33286 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 21:33:45 +00:00
Ella Iseulde Van Dorpe
c0e3449295
TinyMCE: fix visual regressions
...
See #32801 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33285 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 21:30:09 +00:00
Helen Hou-Sandi
9c9b61e7da
Toolbar: Ensure icons are colored correctly in alternate schemes.
...
props ryelle.
fixes #32931 . see #29906 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33284 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 20:13:47 +00:00
Weston Ruter
bfe9cce7f2
Customizer: Defer updating nav menu item tabIndex
attributes until pane is reflowed.
...
Introduces `pane-contents-reflowed` Customizer event.
Props valendesigns, westonruter.
Fixes #32943 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33283 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 20:04:41 +00:00
Weston Ruter
d9fcddae25
Customizer: Hide the transport list when it's empty, especially for screen readers.
...
Also prevent invalid markup for `.customize-section-description`.
Props valendesigns.
Fixes #32843 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33282 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 19:58:42 +00:00
Konstantin Obenland
8c36e7b3c4
Feeds: Revert [32765] because of objections raised in #4575 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@33281 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 19:57:47 +00:00
Konstantin Obenland
9352eb41fb
Customize: Provide a default way to save cropped images.
...
Allows plugins and themes to use `WP_Customize_Cropped_Image_Control` without
having to define their own way of saving the cropped image.
Props celloexpressions for initial patch.
Fixes #29211 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33280 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 19:53:23 +00:00