Commit Graph

28104 Commits

Author SHA1 Message Date
Boone Gorges 96f9d84dba Stop checking Trac to skip tests against open tickets.
In general, skipped tests should live only in patches, which are committed at
the same time that the corresponding bug is fixed. In cases where it's
necessary to skip a test, use `markTestSkipped()` to declare this fact
explicitly.

We continue to check Trac when using `WP_UnitTestCase` to run non-core tests.

See #30284.

git-svn-id: https://develop.svn.wordpress.org/trunk@30526 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 21:10:12 +00:00
Boone Gorges ed426ef8ef Repair the `seems_utf8()` tests that use Big5 encoding.
* Provide sample data that is actually encoded in Big5.
* Do some actual assertions against that data.

Props akumria.
Fixes #30455.

git-svn-id: https://develop.svn.wordpress.org/trunk@30525 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 20:56:23 +00:00
Boone Gorges 9b6563f70f Remove failing test related to the 'offset' param of `WP_Query`.
This test has been added as a patch to #18897.

Props MikeHansenMe.
See #30284.

git-svn-id: https://develop.svn.wordpress.org/trunk@30524 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 20:45:58 +00:00
Boone Gorges 83a9ac46fe Remove failing test related to `wp_list_pages()`.
The test has been added as a patch to #27326.

Props MikeHansenMe.
See #30284.

git-svn-id: https://develop.svn.wordpress.org/trunk@30523 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 20:43:56 +00:00
Boone Gorges 086d0311fa Remove failing test related to `wp_unique_post_slug()`.
The test has been added as a patch to #18962.

See #30284.

git-svn-id: https://develop.svn.wordpress.org/trunk@30522 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 20:41:04 +00:00
Boone Gorges e102a22f80 Remove failing `is_textdomain_loaded()` test.
The removed test has been added as a patch to the original ticket, #21319.

Props MikeHansenMe.
See #30284.

git-svn-id: https://develop.svn.wordpress.org/trunk@30521 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 20:36:51 +00:00
Boone Gorges 05336f904f Remove failing assertions from `is_serialized()` tests.
They have been moved to new test methods, which have been attached as a patch
to the ticket #9930.

See #30284.

git-svn-id: https://develop.svn.wordpress.org/trunk@30520 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 20:34:15 +00:00
Boone Gorges 28b45922d5 Remove failing test in the `hooks` group.
The removed test has been added as a patch to #21169.

Props MikeHansenMe.
See #30284.

git-svn-id: https://develop.svn.wordpress.org/trunk@30519 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 20:25:03 +00:00
Boone Gorges 63f6864a9e Remove skipped tests for `WP_Export_Query`.
These tests have been added as a patch to the ticket where the new
functionality was originally proposed, #22435.

See #30284.

git-svn-id: https://develop.svn.wordpress.org/trunk@30518 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 20:22:01 +00:00
Boone Gorges 0b9a21b451 Remove skipped tests for unimplemented JS plural functions.
The tests have been added as a patch for the original ticket, #22229.

Props MikeHansenMe.
See #22229.

git-svn-id: https://develop.svn.wordpress.org/trunk@30517 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 20:11:10 +00:00
Boone Gorges d5b277e6bd Remove failing test for unimplemented `wp_mail()` enhancement.
The removed test has been added as a patch to the original ticket, #15448.

Props MikeHansenMe.
See #30284.

git-svn-id: https://develop.svn.wordpress.org/trunk@30516 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 20:05:34 +00:00
Boone Gorges 73ef6bd6fc Improvements to encoded character formatting tests.
In `sanitize_title_with_dashes()` and `sanitize_user()` tests, we break large
test methods into smaller ones in order to isolate those that actually describe
the bug being reported in ticket #10823. The unit tests that are continuing to
fail have been attached as a patch to that ticket.

See #30284.

git-svn-id: https://develop.svn.wordpress.org/trunk@30515 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 19:53:37 +00:00
Boone Gorges 3818c645c3 Remove failing tests related to square brackets being stripped in URL sanitizers.
These tests have been added as a patch to their original ticket, #16859.

Props MikeHansenMe.
See #30284.

git-svn-id: https://develop.svn.wordpress.org/trunk@30514 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 15:39:38 +00:00
Boone Gorges f0b8424483 Remove failing tests related to `WP_User::__unset()`.
These tests have been added as a patch to their original ticket, #20043.

Props MikeHansenMe.
See #30284.

git-svn-id: https://develop.svn.wordpress.org/trunk@30513 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 15:36:00 +00:00
Boone Gorges fa76c19ecb Declare user_email when setting up fixtures for `count_user_posts()` tests.
Because `setUpBeforeClass()` is called statically and creates its own factory
object, the iterator logic from previous tests is not carried over to these
fixtures, and we risk the possibility of user_email clashes when the tests are
run in certain limited configurations.

git-svn-id: https://develop.svn.wordpress.org/trunk@30512 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 15:04:07 +00:00
Boone Gorges cfeae751a0 Improve performance of post revision order test.
`test_revision_order()` was written ([28541], #26042) to ensure that revision
order was properly preserved in two different cases: (1) where the post_date
varied (in which case the revisions would be sorted by post_date DESC) and
(2) where the post_date was the same (in which case sorting would fall back on
ID DESC). In an attempt to ensure that both of these scenarios arose in the
context of a single test, 100 posts were created. We can make the process far
more efficient by manually creating the revisions with the post_dates
explicitly declared, and splitting the two different cases into two separate
test methods.

This test was previously the single worst offender in the entire suite, taking
upwards of 15 seconds to run. All that most maddens and torments; all that stirs
up the lees of things; all truth with malice in it; all that cracks the sinews
and cakes the brain; all the subtle demonisms of life and thought; all evil, to
crazy Boone, were visibly personified, and made practically assailable in
`test_revision_order()`.

See #30017.

git-svn-id: https://develop.svn.wordpress.org/trunk@30511 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 14:17:21 +00:00
Boone Gorges 36315d2b3f Remove some failing unit tests from the `post` group.
These tests have been added as a patch to ticket #19373.

See #30284.

git-svn-id: https://develop.svn.wordpress.org/trunk@30510 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 12:03:48 +00:00
Andrew Ozz 1e9ffd6988 TinyMCE: set the image toolbar's z-index to be the same as the other TinyMCE panels, or it is under the editor when in fullscreen mode. See #30147.
git-svn-id: https://develop.svn.wordpress.org/trunk@30509 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-22 02:42:30 +00:00
John Blackbourn 577e78f7c0 Abstract the theme browser route paths into attributes so they can be easily overridden.
Fixes #30116
Props matveb


git-svn-id: https://develop.svn.wordpress.org/trunk@30508 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 17:30:00 +00:00
John Blackbourn 3afb2efae4 Update the inline docs for `wp_die()` to reflect parameter changes made in r30355
See #10551


git-svn-id: https://develop.svn.wordpress.org/trunk@30507 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 17:07:42 +00:00
John Blackbourn 8ea65c3c0d Add support for `WP_Error` objects passed to `wp_send_json_error()`. The error object gets output as an array of error codes and messages, rather than as an empty object.
Fixes #28978
Props paulschreiber


git-svn-id: https://develop.svn.wordpress.org/trunk@30506 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 16:55:28 +00:00
Helen Hou-Sandi a8821f6b57 Admin notices: Add more variety and make more generically usable.
There is now a base class of `notice`, with additional classes of `notice-success`, `notice-warning`, `notice-error`, and a new blue `notice-info`.

Also corrects some misleading notice colors, such as plugin tested up to warnings and login messages.

props avryl, melchoyce.
fixes #27418.


git-svn-id: https://develop.svn.wordpress.org/trunk@30505 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 16:40:29 +00:00
Helen Hou-Sandi a42d9584e9 Sessions UI: Ensure screen readers provide feedback on action taken.
Also fixes some invalid HTML that occurs on DOM changes.

props joedolson.
fixes #30364.


git-svn-id: https://develop.svn.wordpress.org/trunk@30504 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 16:24:23 +00:00
Helen Hou-Sandi 9e2519e42c oEmbed: Add support for the Vine endpoint.
props niallkennedy.
fixes #30426.


git-svn-id: https://develop.svn.wordpress.org/trunk@30503 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 16:03:41 +00:00
Drew Jaynes (DrewAPicture) 1c3fb4f442 Convert `<title>` to "title tag" in the DocBlock summary for the `admin_title` hook.
Fixes #30437.


git-svn-id: https://develop.svn.wordpress.org/trunk@30502 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 07:11:14 +00:00
Sergey Biryukov 917a469052 Replace invalid use of ltrim() in attachment_url_to_postid() with substr().
props bradyvercher.
fixes #30346.

git-svn-id: https://develop.svn.wordpress.org/trunk@30501 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 06:34:23 +00:00
Sergey Biryukov 5f1c87f271 Set min-height for menu item title. Add a fallback for empty-titled items.
props philiparthurmoore.
fixes #30283.

git-svn-id: https://develop.svn.wordpress.org/trunk@30500 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 05:56:23 +00:00
John Blackbourn 1eca0cb442 Remove whitespace accidentally introduced in r30498
See #30335


git-svn-id: https://develop.svn.wordpress.org/trunk@30499 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 04:00:38 +00:00
John Blackbourn 5b72f2960a `split_shared_term` is an action, not a filter.
See #30335


git-svn-id: https://develop.svn.wordpress.org/trunk@30498 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 03:50:15 +00:00
Drew Jaynes (DrewAPicture) 3d2da1bf74 Minor syntactical adjustments to the inline documentation for the `revision_text_diff_options` hook.
Converts backticked-inline-code to inline `@see` tags (for the full benefit of Code Reference automagical behavior).

See [30396]. See #24908.


git-svn-id: https://develop.svn.wordpress.org/trunk@30497 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 03:49:43 +00:00
Drew Jaynes (DrewAPicture) 6866523f2b Add an entry to the changelog for `wp_make_link_relative()` noting that intentional support was added for relative URLs.
See #30373.


git-svn-id: https://develop.svn.wordpress.org/trunk@30496 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 03:43:06 +00:00
John Blackbourn 91ca24fe99 Only output an optgroup for installed languages in `wp_dropdown_languages()` if translations are available.
See #30335


git-svn-id: https://develop.svn.wordpress.org/trunk@30495 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 03:19:53 +00:00
Boone Gorges 5e71d5f21e Improve cleanup of cached term_ids after shared terms are split.
* If the split term ID is stored as 'default_category', 'default_link_category', or 'default_email_category', update it to the new ID.
* If the split term ID is associated with a nav menu item, update that piece of postmeta to the new ID.

Props mboynes.
See #30335.

git-svn-id: https://develop.svn.wordpress.org/trunk@30494 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 03:16:08 +00:00
Boone Gorges f14649feb7 Pass the taxonomy of the split tt_id to the 'split_shared_term' filter.
Props mboynes.
See #30335.

git-svn-id: https://develop.svn.wordpress.org/trunk@30493 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 03:13:20 +00:00
Boone Gorges 430e4250db Store data about old and new term IDs when shared terms are split.
Props mboynes.
See #30335.

git-svn-id: https://develop.svn.wordpress.org/trunk@30492 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 03:12:42 +00:00
Dion Hulse 1c11d73f72 Update the bundled root CA's used for outgoing HTTPS requests.
Fixes #30434


git-svn-id: https://develop.svn.wordpress.org/trunk@30491 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 03:02:11 +00:00
Andrew Ozz 9998091278 TinyMCE: change the default font size from 100% to 16px to fix some back-compat issues, fixes #30038.
git-svn-id: https://develop.svn.wordpress.org/trunk@30490 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 22:22:55 +00:00
Drew Jaynes (DrewAPicture) e788b30bcd Update the DocBlock changelogs for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks following [30358], where `$depth` parameters were added.
Props kpdesign.
See [30358]. Fixes #19064.


git-svn-id: https://develop.svn.wordpress.org/trunk@30485 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 18:25:13 +00:00
Andrew Nacin 7d786e8df4 4.1-beta2-30484
git-svn-id: https://develop.svn.wordpress.org/trunk@30484 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 17:44:05 +00:00
Helen Hou-Sandi 00053abb4c Media a11y: Don't set role=checkbox for the attachment details view.
Some unnecessary attributes were inherited from the attachment view, which created difficulties with screen readers.

fixes #30390.


git-svn-id: https://develop.svn.wordpress.org/trunk@30483 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 17:14:11 +00:00
Lance Willett fed984a90c Twenty Twelve and Thirteen: Use proper way to get customizer settings values.
Props obenland, kdoran. Fixes #29577.

git-svn-id: https://develop.svn.wordpress.org/trunk@30482 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 17:05:27 +00:00
John Blackbourn 9aa0e31b28 WordPress 4.1-beta2
git-svn-id: https://develop.svn.wordpress.org/trunk@30481 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 16:52:54 +00:00
John Blackbourn 8fe059d426 Correct an SQL syntax error introduced in r30158. Adds tests.
Fixes #30339
See #18962
Props julien731


git-svn-id: https://develop.svn.wordpress.org/trunk@30480 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 16:45:48 +00:00
Ian Stewart 4dd55dcced Twenty Fifteen: bring back the border between post navigation links we lost in the_post_navigation changes.
Props iamtakashi, fixes #30414.



git-svn-id: https://develop.svn.wordpress.org/trunk@30479 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 16:40:29 +00:00
Andrew Nacin 95dbca94e1 More tests for [30466]. props xknown.
git-svn-id: https://develop.svn.wordpress.org/trunk@30471 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 16:10:24 +00:00
Andrew Nacin aec2f2654e Prevent high resource usage when hashing large passwords. props mdawaffe, pento
git-svn-id: https://develop.svn.wordpress.org/trunk@30466 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 16:02:55 +00:00
Dominik Schilling (ocean90) e1d16e8080 Simplify selectors in [30374].
props wonderboymusic, adamsilverstein.
see #29326.

git-svn-id: https://develop.svn.wordpress.org/trunk@30461 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 15:36:20 +00:00
Dominik Schilling (ocean90) bf014b7e30 `grunt autoprefixer` for [30374].
see #29326.

git-svn-id: https://develop.svn.wordpress.org/trunk@30460 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 15:30:49 +00:00
Dominik Schilling (ocean90) df884cb92e Customizer: Use deep-links for Backgrounds, Headers, and Widgets.
Replace links in admin menu and toolbar to Custom Background/Header screen with deep-links to the Customizer section.
On the Widgets screen display a link to the Customizer widgets panel.

props topher1kenobe, rzen, celloexpressions, westonruter
fixes #25569, #25571, #28032.

git-svn-id: https://develop.svn.wordpress.org/trunk@30459 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 15:28:55 +00:00
Andrew Nacin 05facab3d6 Validate image data.
git-svn-id: https://develop.svn.wordpress.org/trunk@30458 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 15:24:40 +00:00