7193d1987e
Docs: Update the file path in the duplicate hook comment for the `admin_xml_ns` hook in wp-admin/includes/template-functions.php.
...
The hook was "moved" to the newly-created template-functions.php file via `svn cp` in [34241].
Props dimadin.
See #33413 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34391 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 10:31:24 +00:00
2ddc438111
List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used.
...
Props wonderboymusic, Viper007Bond.
Fixes #21249 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34383 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 06:05:39 +00:00
f543c65320
Dashboard: 2 submit buttons don't need names.
...
Props garyc40, gizburdt.
Fixes #16345 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34382 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 05:44:45 +00:00
40b5ade751
After [34374], ensure that `$iptc` is defined.
...
See #33772 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34378 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 04:48:25 +00:00
5dd7bec848
Multisite: as a precaution, make `wp-json` a reserved subdirectory name.
...
Props austinginder.
Fixes #33789 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34375 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 04:20:41 +00:00
70b90490fd
Media: In `wp_read_image_metadata()`, include IPTC Keywords when available in `$meta`.
...
Adds unit test.
Props swissspidy, dbru, SteveHoneyNZ.
Fixes #33772 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34374 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 04:18:02 +00:00
8a33422bfc
Passwords: fix the markup on the Reset Password Form for `user-pass1` so the JavaScript operates properly.
...
Props ldinclaux.
See #33892 .
Fixes #33908 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34371 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 03:56:25 +00:00
f9d1856805
Help Tabs: when returning help tabs, return them in order of priority, but also return the items in each priority in the order that they were added.
...
Fixes #33941 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34370 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 03:36:27 +00:00
782b9085c9
Docs: Move a duplicate hook comment accidentally left behind when its corresponding filter was relocated in [31765].
...
See #31443 . See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34368 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-21 23:12:35 +00:00
9aaa278e02
Notices: Add styles for use against white backgrounds.
...
These colored backgrounds can be accessed by adding the `.notice-alt` class to a notice.
There is also now a large version when using the `.notice-large` class, and a `.notice-title` class that is appropriate for headline text within a large notice.
props paulwilde, hugobaeta, melchoyce.
fixes #32244 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34365 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-21 15:25:37 +00:00
2b3347332e
Meta Boxes: In `post_categories_meta_box()`, convert some spaces to tabs.
...
Props miyauchi.
Fixes #33945 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34364 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-21 15:17:29 +00:00
f80add733c
Implement a 'Mine' link on post listing screens in the admin area for all users who have authored posts. This feature was previously only available to users who cannot edit other users' posts (namely Authors and Contributors).
...
Props linuxologos, wonderboymusic
Fixes #19609
git-svn-id: https://develop.svn.wordpress.org/trunk@34360 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 17:27:35 +00:00
ce126c10c0
Remove the ability to view the term editing screen for taxonomies with `show_ui` set to `false`. It is unexpected and unintended behaviour that this is allowed.
...
If your plugin or site does rely on this behaviour, the arguments that are passed to `register_taxonomy()` should be altered so that `show_ui` is `true`, and arguments such as `show_in_menu` and `show_in_nav_menus` are false.
Fixes #33938
git-svn-id: https://develop.svn.wordpress.org/trunk@34359 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 17:10:55 +00:00
dc7d968b19
Implement some more uses of `wp_login_url()` in places where wp-login.php is hard-coded.
...
See #31495
git-svn-id: https://develop.svn.wordpress.org/trunk@34358 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 16:53:32 +00:00
050def62a3
Multisite: Make site status classes available to other elements.
...
Fixes a regression introduced in [31181], where links to user's site would not
have a colored background based on their status anymore.
Fixed during WordCamp Switzerland Contributor Day.
Props psoluch.
Fixes #33595 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34356 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 12:52:56 +00:00
d3031d522e
Upgrader: Avoid using an HTML tag in a translation string, add translator comments.
...
Props ramiy for initial patch.
Fixes #31860 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34352 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 08:58:27 +00:00
857be1862b
Pass the current post object to `'page_attributes_meta_box_template'` action added in [34340].
...
Props DrewAPicture.
Fixes #33625 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34350 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 08:14:40 +00:00
44c256e8d1
Docs: Use standardized vernacular in the hook doc summary for the `page_attributes_meta_box_template` filter, introduced in [34340].
...
See #33625 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34349 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 06:37:18 +00:00
ed7d34cb13
Pass `false` as the 2nd argument to `class_exists()` to disable autoloading and to not cause problems for those who define `__autoload()`.
...
Fixes #20523 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34348 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 03:51:55 +00:00
520a75f44e
The `'get_sample_permalink_html'` filter's second parameter can be a post ID or a post object. This is confusing. We should pass the post ID and post object separately, for consistency with `'get_sample_permalink'` filter added in [34309].
...
Props SergeyBiryukov.
Fixes #33927 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34347 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 03:25:45 +00:00
df8f10ceff
Plugins Admin: Avoid using HTML tags in translation strings, add translator strings.
...
Props swissspidy, voldemortensen.
Fixes #32269 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34344 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 03:00:57 +00:00
d624c118cb
Plugin Editor: Avoid using HTML tags in translation strings and add context.
...
Props ramiy.
Fixes #31862 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34341 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 02:41:43 +00:00
2812cc9595
In `page_attributes_meta_box()`, add an action, `'page_attributes_meta_box_template'` to allow callbacks to be performed and HTML to be inserted after the title of the Template section.
...
Props sgrant.
Fixes #33625 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34340 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 02:39:31 +00:00
2ccbc51d1e
Login: apply the same margin to the top and bottom of the Back to {Blog} link.
...
Props MikeHansenMe.
Fixes #29249 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34338 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 01:40:42 +00:00
0fdbaecbc6
Export: Add late-escaping to the contents of several nodes to avoid creating invalid XML and XML parse errors.
...
Props westonruter.
Fixes #33732 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34333 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 18:52:27 +00:00
f9c67159d4
Updates: in Theme list table, set `white-space` to `normal` for theme titles at appropriate breakpoint to avoid horizontal scrolling on small screens.
...
Fixes #33831 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34332 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 18:42:45 +00:00
d075313f5b
Post List Table: 'All' view should be selected when appropriate for paged responses.
...
Props kraftbj, wonderboymusic.
Fixes #33923 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34331 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 18:16:31 +00:00
1b550d9fb2
Reinstate [34327]. minus the unit test deletion.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@34329 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 17:48:18 +00:00
1e7832cc3b
Revert [34327] to fix the accidental deletion of some unit tests.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@34328 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 17:45:46 +00:00
750c22abf8
Export: Add a filer, `'export_wp_filename'` to change the filename of the file to download when exporting.
...
Props MikeHansenMe, wonderboymusic.
Fixes #29500 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34327 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 17:43:52 +00:00
3624366045
Export: allow Media to exported separately from other types.
...
Props PhilipLakin.
Fixes #32230 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34326 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 16:46:17 +00:00
d9b58bd4ac
Admin: when toggling select/deselect "all" via JS - `:visible` needs to be bound to not toggle disabled inputs.
...
Props tywayne.
Fixes #32309 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34325 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 16:40:34 +00:00
6d51562d72
Edit Post: When a post is "Pending Review", the "View Post" link should behave like ot does for drafts and generate a preview link.
...
Props wpdev101.
Fixes #33541 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34324 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 16:31:38 +00:00
1ca6eee748
List Tables: Ensure that sorting indicators have layout when cell widths are being calculated.
...
See #27743 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34323 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 16:14:59 +00:00
3cf5d40b9d
Update Core: In `list_plugin_updates()`, when listing plugin updates related to `$core_update_version`, don't skip the check for `$info->tested`.
...
Props MikeHansenMe.
Fixes #27883 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34322 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 16:09:40 +00:00
1c5f85e1a4
When applying the `'editable_slug'` filter, add a second param that provides more context.
...
Props MikeSchinkel, jesin.
Fixes #31568 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34319 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 05:48:30 +00:00
7eb0317968
Don't use `<code>` in translation strings in `wp-admin/options.php`.
...
Props ramiy, wonderboymusic.
Fixes #31861 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34315 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 20:42:20 +00:00
f5eacb71d6
Don't use `<code>` in translation strings in `wp-admin/includes/plugin.php`.
...
Props ramiy.
Fixes #31856 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34314 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 20:28:23 +00:00
0c642e4730
Use correct `@since` tag for `wp_ajax_generate_password()`.
...
See #33450 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34313 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 20:18:22 +00:00
1299974e7d
Profile: when clicking "Cancel" after clicking "Generate Password", request and generate a new password to present to the user.
...
Props adamsilverstein, wonderboymusic.
Fixes #33450 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34312 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 20:13:34 +00:00
b0b36bc346
Add a 'get_sample_permalink' filter.
...
Props SergeyBiryukov, wenthemes, JustinSainton.
Fixes #22338 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34309 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 19:27:24 +00:00
c43a62bde7
Include placeholder in translator comment.
...
See #31863 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34306 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 19:02:37 +00:00
039ce30818
Include placeholder in translator comment.
...
See #31864 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34305 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 19:00:20 +00:00
21a41c100f
Include placeholders in translator comments.
...
See #31857 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34304 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:57:01 +00:00
394e9ac21a
Don't use HTML tags in translation strings in `edit-tags.php`.
...
Props ramiy.
Fixes #31863 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34303 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:52:48 +00:00
de077ac377
Don't use HTML tags in translation strings in `wp_ajax_add_user()`.
...
Props ramiy.
Fixes #31864 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34302 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:50:04 +00:00
5cfdae8b2b
Add missing translator comment after [34295].
...
See #31853 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34301 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:49:40 +00:00
bcc165791f
Add missing translator comments after [34294].
...
See #31852 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34300 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:45:40 +00:00
48c6d925cd
Add missing translator comment after [34292].
...
See #31840 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34299 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:39:20 +00:00
f90ee7b348
Add missing translator comments after [34293].
...
See #31851 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34298 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:38:54 +00:00
310dc18167
Don't use HTML tags in translation strings for "In Reply To" links for comments in the admin.
...
Props ramiy.
Fixes #31857 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34297 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:35:16 +00:00
13889763af
Don't use HTML tags in translation strings in `wp-admin/includes/update.php`.
...
Props ramiy.
Fixes #31855 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34296 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:30:26 +00:00
c10019ec70
Don't use `<code>` in translation strings in `edit-form-comment.php`.
...
Props ramiy.
Fixes #31853 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34295 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:27:29 +00:00
df149fddff
Don't use `<code>` in translation strings in `options-general.php`.
...
Props ramiy, SergeyBiryukov.
Fixes #31852 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34294 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:23:19 +00:00
d2b4e0c728
Don't use `<code>` in translation strings in `wp-admin/includes/schema.php`.
...
Props ramiy.
Fixes #31851 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34293 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:20:46 +00:00
f6d2c30fa7
Network Setup: don't use `<code>` in translation strings in `wp-admin/network` files.
...
Props ramiy.
Fixes #31840 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34292 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 18:17:26 +00:00
308179c232
Remove support for my-hacks.php
...
For the last 10 years, my-hacks has been deprecated and has been throwing a deprecation notice. For the last six years, you haven't been able to enable my-hacks.php in the admin UI. That should be enough time to give developers notice. Plugins and themes seem like they might have staying power.
Fixes #33741
Props bobbingwide
git-svn-id: https://develop.svn.wordpress.org/trunk@34291 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 17:05:28 +00:00
7f562dd69f
Theme Editor: Change file descriptions of `header.php` and `footer.php`.
...
`header.php` is now "Theme Header" and `footer.php` is "Theme Footer". This prevents a clash with other "Header" strings in the context of "Custom Header".
Props ramiy.
Fixes #32975 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34290 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 16:02:24 +00:00
7851406626
Network Admin: Include IDs for users and sites on their respective views.
...
Props danielbachhuber, wonderboymusic.
Fixes #18661 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34289 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 15:57:47 +00:00
09f373d582
Updates: FTP: Add a missing PCRE modifer in [34281].
...
See #16026 , #33432x
git-svn-id: https://develop.svn.wordpress.org/trunk@34282 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 08:22:17 +00:00
b114866bbf
Updates: FTP/PemFTP Library: Remove the usage of deprecated regular expression functions (ereg replaced by PCRE).
...
Props enshrined, aaroncampbell
Fixes #16026 , #33432
git-svn-id: https://develop.svn.wordpress.org/trunk@34281 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 08:19:18 +00:00
50419ff08d
List Tables: ensure that sortable list table column headers have the same padding/line-height as non-sortable headers.
...
Props drozdz.
Fixes #27945 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34276 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 03:25:32 +00:00
ace6756081
Editor: add `hide-if-no-js` class to `<td id="wp-word-count">`. Word Count no worky with no JavaScript.
...
Props chriscct7.
Fixes #33379 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34275 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 02:31:23 +00:00
73c1ac8b26
Posts List Table: Use a more robust technique for calculating `$total_items` so that pagination still appears when items are removed on the last page of results and `->max_num_pages` decreases.
...
Props A5hleyRich.
Fixes #29870 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34271 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 21:17:16 +00:00
5ea07785b3
Customize: Reduce peak memory usage by JSON-encoding settings and controls individually.
...
When there are hundreds of settings and controls (e.g. nav menu items and widget instances) the resulting object that is JSON-encoded can become very large, and `wp_json_encode()` can consume a lot of memory to serialize it. By breaking down the serialization into multiple calls the peak memory usage can be kept in line.
Moves logic out of `wp-admin/customize.php` into the `WP_Customize_Manager` class with new methods:
* `is_ios()`
* `get_document_title_template()`
* `get_preview_url()`/`set_preview_url()`
* `get_return_url()`/`set_return_url()`
* `get_autofocus()`/`set_autofocus()`
* `customize_pane_settings()`
Includes unit tests for these methods, for which the logic was formerly untestable in `customize.php`.
Fixes #33898 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34269 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 19:41:35 +00:00
3531c0bc10
Superglobals: Revert [34059] until further notice.
...
see #33837 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34265 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 12:32:20 +00:00
f9ff998d01
Revert unintended change from [34262].
...
See #33910 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34263 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 09:08:14 +00:00
45610f9464
Docs: Expand the DocBlock for `get_default_post_to_edit()`.
...
Props rabmalin.
Fixes #33910 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34262 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 09:05:44 +00:00
189bc9b5aa
Media: In `wp_ajax_send_attachment_to_editor()`, the fallback logic for `$html` should be tucked into an `else` statement so it isn't run needlessly and overwritten.
...
Props tychay.
Fixes #32072 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34260 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 05:54:56 +00:00
337c87e7c7
Media: In `get_image_send_to_editor()`, allow a custom value for `$rel`.
...
Props tychay.
Fixes #32074 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34259 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 05:45:31 +00:00
a1805ecada
Media List Table: remove the counts from the "views" portion of the toolbar, which are inconsistent with grid view. Also reduces complexity and removes potentially expensive count query.
...
Related to the toolbar view, remove the `wp_admin_canonical_url()` action in grid mode. Grid views that result from links from the list table view are lenses into the library and need to be indicated as such vs being a full attachment query.
Fixes #29744 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34256 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 02:29:22 +00:00
de7c9b6015
Move new user notification emails to `add_action()` callbacks.
...
When a new user is created in various places throughout the interface,
notifications are sent to the site admin and the new user. Previously, these
notifications were fired through direct calls to `wp_new_user_notification()`,
making it difficult to stop or modify the messages.
This changeset introduces a number of new action hooks in place of direct calls
to `wp_new_user_notification()`, and hooks the new wrapper function
`wp_send_new_user_notifications()` to these hooks.
Props dshanske, thomaswm, boonebgorges.
Fixes #33587 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34251 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 22:18:33 +00:00
7c9c635a04
Add a missing Oxford comma on Export screen.
...
Props juhise.
Fixes #33906 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34249 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 21:33:29 +00:00
d2bb55ee92
`wp-admin/includes/template.php` is now a loader for 3 files made via `svn cp`:
...
* `Walker_Category_Checklist` class
* `WP_Internal_Pointers` class
* `template-functions.php`
This is BC for plugins that are loading `wp-admin/includes/template.php` for fun.
See #33413 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34241 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 15:34:17 +00:00
1d4b8ffd1d
Docs: Expand the DocBlock for the `WP_Theme::get_edit_link()` method, introduced in [34084].
...
Fixes #32376 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34238 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 15:00:04 +00:00
7682e433fc
Docs: Put "it's" in its place (again).
...
Props kitchin.
Fixes #33894 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34234 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 12:45:51 +00:00
557d160ca1
Comments: Fix a fatal error in Comments meta box after [34223].
...
Props tyxla.
Fixes #33893 . See #33413 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34231 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 11:36:35 +00:00
3b3a034c11
Docs: Remove markdown from the DocBlock summary for `WP_List_Table::get_primary_column()`, introduced in [34166].
...
The PHP inline documentation standards for [https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#summary-formerly-short-description summaries] call for not using an markup or markdown. Also, using the full Class::method() in this context allows for better clarity in what is being referenced.
See #33854 . See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34229 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 10:50:21 +00:00
f83abcbf3e
Docs: Add a changelog entry for the switch to using `wp_get_attachment_url()` instead of the guid for determining the header image URL in `Custom_Image_Header::step_3()`.
...
The change was introduced in [34188].
See #33319 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34228 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 10:42:08 +00:00
05cd237d5e
Move `WP_Post_Comments_List_Table` to its own file.
...
See #33413 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34223 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 06:52:35 +00:00
1975b0a084
Customizer: Smooth animation for closing accordions in the available nav menu items pane.
...
Props tyxla.
Fixes #33360 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@34219 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 23:39:23 +00:00
0adb6877b2
Improve validation of `user_login` and `user_nicename` length.
...
The `user_login` field only allows 60 characters, and `user_nicename` allows
50. However, there are no protections in the interface, and few in the code,
that prevent the creation of users with values in excess of these limits. Prior
to recent changes in `$wpdb`, users were generally created anyway, MySQL
having performed the necessary truncation. More recently, the `INSERT`s and
`UPDATE`s simply fail, with no real feedback on the nature of the failure.
This changeset addresses the issue in a number of ways:
* On the user-new.php and network/user-new.php panels, don't allow input in excess of the maximum field length.
* In `wp_insert_user()`, throw an error if the value provided for `'user_login'` or `'user_nicename'` exceeds the maximum field length.
* In `wp_insert_user()`, when using `'user_login'` to generate a default value for `'user_nicename'`, ensure that the nicename is properly truncated, even when suffixed for uniqueness (username-2, etc).
Props dipesh.kakadiya, utkarshpatel, tommarshall, boonebgorges.
Fixes #33793 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34218 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 22:13:51 +00:00
1a352d56f9
Implement `wp_login_url()` and `wp_registration_url()` in places where `wp-login.php` is currently hard-coded.
...
See #31495
Props GregLone
git-svn-id: https://develop.svn.wordpress.org/trunk@34213 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 17:10:24 +00:00
2a1ee1a235
Don't redirect to the Term list table after submitting the form on the Edit Term page.
...
Props chiragswadia, UmeshSingla, rhyswynne, afercia.
Fixes #17455 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34202 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 15:58:04 +00:00
acbeef27b9
Similar to #33386 , don't use `guid` when retrieving URL for a cropped header image in the Customizer.
...
Props polevaultweb.
Fixes #33319 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34188 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 14:45:59 +00:00
87d6be5991
Comments: When setting the `colspan` value for inline edit/reply, make sure it's actually a table and the value is not empty.
...
Props afercia.
Fixes #33596 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34179 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 13:43:28 +00:00
b8349f8222
Remove outdated references to the `preview_post_link` filter docs.
...
See #24345
Props paulwilde
git-svn-id: https://develop.svn.wordpress.org/trunk@34178 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 10:31:40 +00:00
a923d36085
Remove the ability to view the post listing screen and post editing screen for post types with `show_ui` set to `false`. It is unexpected and unintended behaviour that this is allowed.
...
If your plugin or site does rely on this behaviour, the arguments that are passed to `register_post_type()` should be altered so that `show_ui` is `true`, and arguments such as `show_in_menu`, `show_in_nav_menus`, and `show_in_admin_bar` are `false`.
Fixes #33763
Props swissspidy, johnbillion
git-svn-id: https://develop.svn.wordpress.org/trunk@34177 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 10:26:22 +00:00
c95d6b3ec8
Use `get_attached_file()` in `attachment_submitbox_metadata()`.
...
Props kitchin.
Fixes #33386 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34171 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 04:17:38 +00:00
c0d850878a
Create a function, `get_preview_post_link()`, to DRY the logic for applying the `'preview_post_link'` filter to a URL.
...
Props TomHarrigan, wonderboymusic.
Fixes #24345 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34170 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 04:14:23 +00:00
ac610c191b
Move `WP_Screen` to its own file.
...
See #33413 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34169 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 04:07:14 +00:00
26ab36f909
Move the admin Nav Menu Walker subclasses into their own files. Load in `nav-menu.php` to remain BC.
...
See #33413 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34168 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 04:01:30 +00:00
1a537a4f6d
Add a doc block to `WP_List_Table::get_primary_column()`.
...
Fixes #33854 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34166 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 03:34:44 +00:00
8df7bd75b6
Ensure that widget carets close when dragging an expanded widget.
...
Props sdavis2702, mindctrl.
Fixes #33578 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34165 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 03:09:35 +00:00
577fea566a
Don't ever use the `guid` value when retrieving URLs for media, use `wp_get_attachment_url()`. Use `get_attached_file()` for path to file.
...
Fixes #33386 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34163 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 02:49:12 +00:00
5c85369bb6
In `_wp_ajax_delete_comment_response()`, read the new `'all'` prop returned by `get_comment_count()` via `wp_count_comments()` when setting `$total`. `'all'` doesn't include `spam` in its count.
...
Updates unit tests.
Props dipesh.kakadiya.
Fixes #32362 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34161 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 01:46:51 +00:00
5168b2e303
After [34070], account for the new ID in Quick Edit JS.
...
Props afercia.
Fixes #33770 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34159 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 01:30:36 +00:00
1541d43033
List tables: escape user e-mails
...
Better safe than sorry.
git-svn-id: https://develop.svn.wordpress.org/trunk@34133 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 22:32:52 +00:00
a9e1f79323
In the `edit-comments.php` admin handler, toggle `wp_defer_comment_counting()` so that only unique post IDs have their comment count updated. Currently, if you delete 50 comments from the same post, the count would get reset 50 times. Not joking.
...
See #33875 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34132 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 22:23:43 +00:00
b42a906512
`wp_unspam_comment()` can accept a full object instead of comment_ID to reduce cache/db lookups..
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34130 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 21:46:40 +00:00
166ee8674b
More comment functions can accept a full object instead of comment_ID to reduce cache/db lookups.
...
See ##33638.
git-svn-id: https://develop.svn.wordpress.org/trunk@34129 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 21:39:46 +00:00
ab7ca361dd
In `WP_List_Table`, make a new `public` method, `->get_primary_column()`, and revert [34101] due to BC issues.
...
Fixes #33854 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34128 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 20:28:29 +00:00
ea610e66d4
In `WP_Media_List_Table`, fetch all pending comment counts at once, instead of for each row in the loop.
...
See #11381 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34127 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 19:24:59 +00:00
08098026ce
Passwords: Deprecate second parameter of `wp_new_user_notification()`.
...
The second parameter `$plaintext_pass` was removed in [33023] and restored as `$notify` in [33620] with a different behavior. If you have a plugin overriding `wp_new_user_notification()` which hasn't been updated you would get a notification with your username and the password "both".
To prevent this the second parameter is now deprecated and reintroduced as the third parameter.
Adds unit tests.
Props kraftbj, adamsilverstein, welcher, ocean90.
Fixes #33654 .
(Don't ask for new pluggables kthxbye)
git-svn-id: https://develop.svn.wordpress.org/trunk@34116 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 12:42:34 +00:00
0a77429937
Passwords: Trigger a `wp-check-valid-field` event when the password field is filled with a password by `generatePassword()`.
...
Updates event handler in `wpAjax.invalidateForm()` to support `wp-check-valid-field`.
See #33406 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34114 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 10:38:32 +00:00
a6a03da7f5
Add an argument to `parent_dropdown()`, `$post`, to allow it to be called for an arbitrary post.
...
Fixes #23162 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34111 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 03:19:59 +00:00
a620cd1e34
Turn off `autocomplete` for the `new-post-slug` field.
...
Props johnbillion.
Fixes #32752 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34105 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 02:02:58 +00:00
5a93988ca3
Make `WP_List_Table::get_primary_column_name()` public in list table classes that have it.
...
Fixes #33854 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34101 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 01:11:44 +00:00
34c6893080
Bump H3 headings to H2 on the Writing Settings screen for better accessibility.
...
Props mrahmadawais.
Fixes #33651 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34096 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-13 16:47:54 +00:00
379dd889c1
Comments: Fix inline edit/reply on small screens.
...
props ocean90, SergeyBiryukov.
fixes #33596 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34094 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-13 12:46:03 +00:00
fd1dbfe003
Customize: Remove redundant `aria-label` attributes.
...
Adds an `$options` array argument to `WP_Screen::render_screen_options()` to allow the `div#screen-options-wrap` element to be omitted when `wrap` value is `false`.
Props afercia, westonruter.
Fixes #33182 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34093 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-13 06:15:42 +00:00
07ea6a2334
Themes: Don't use HTML entities for placeholders.
...
See #32875 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34086 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-12 19:47:53 +00:00
ad20c3db4a
`WP_Posts_List_Table`: there are a cadre of `edit.php` URLs that are generated by string-building instead of using our handy functions. Create a helper method, `->get_edit_link()` that standardizes the generation and escaping of these URLs.
...
Props BdN3504 for the initial patch on the ticket.
Fixes #32376 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34084 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-12 17:12:25 +00:00
2a72a1f959
Use `table-layout: auto` (instead of `fixed`) on `table.fixed` to ensure that things like date/time don't horrendously wrap on small screens. Before/After screenshots attached to the ticket.
...
Props gaelan.
Fixes #32691 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34083 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-12 16:03:17 +00:00
faf87c2ca6
After [34076], fix the logic for `post_status` in months dropdown.
...
See #21015 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34077 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-12 08:18:18 +00:00
927ad00bab
List Tables: don't render "extra tablenav" if there are no posts. This includes Bulk Actions, Dates Dropdown, Category Dropdowns, Pagination.
...
Also ensure that the Months dropdown, when it is shown, shows months from the proper set of posts.
Props egower, CoenJacobs, MikeHansenMe, mehulkaklotar.
Fixes #33824 , #21015 , #21856 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34076 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-12 08:12:43 +00:00
9831fa216c
AJAX Reply to Comment: check the `edit_comment` cap when parent comment will be auto-approved.
...
Props rachelbaker.
Fixes #23939 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34074 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-12 07:18:36 +00:00
3cbec930bb
Edit Comment screen: remove the "View Comment" button (actually a link) from the publish meta box. Mimic the "Edit URL/Permalink" UI from the Edit Post screen to show the comment link below the screen title, but make it an actual link, not a button.
...
Props ocean90, DrewAPicture, wonderboymusic.
Fixes #19168 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34072 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-12 03:19:21 +00:00
6a262bd6ce
Quick Edit: fix an ID attribute name collision by renaming one of the author fields `author-name`.
...
Props afercia.
Fixes #33770 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34070 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-12 02:34:52 +00:00
0f2078bc9e
When clicking "Show More Comments" in the Comments meta box on the Edit Post screen, change the click behavior to call a new class method on `commentsBox`, `->load()`, that resets `st` (cool name) to the number of visible `<tr>`s before calling `->get()`. This will account for spam'd and trash'd comments when returning comments at the proper offset.
...
Props utkarshpatel.
Fixes #33829 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34069 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-12 02:27:50 +00:00
f855ddb134
Settings, password field: fix placement of the error icon and removal of the error class.
...
Props liljimmi, adamsilverstein.
Fixes #33406 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@34068 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-12 00:09:09 +00:00
1a333bd537
Bump H3 headings to H2 on the Plugin Editor screen for better accessibility.
...
Fixes #33839 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34067 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-12 00:07:23 +00:00
41c74b9bf6
Bump H3 headings to H2 on the Theme Editor screen for better accessibility.
...
Props mrahmadawais.
Fixes #33660 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34066 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 23:59:30 +00:00
c492832e6a
Nav Menus: fix the quick search spinner position on Operating Systems that show scrollbars.
...
Fixes #33290 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34065 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 23:51:53 +00:00
bc8e3599e6
Quick Edit: fix the Tags auto-suggest tooltip visibility.
...
Be sure to hide the `jquery.suggest` Tags textarea tooltip also when using the keyboard to Save/Cancel.
Props rommelxcastro for the initial patch.
Fixes #32580 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34064 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 23:33:43 +00:00
e5324c4c91
Settings: properly set the password field label on loading.
...
See #33778 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34062 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 23:04:53 +00:00
504d75e4c1
Settings: reassign the label when switching password fields so it always highlights the visible field.
...
Props umesh.nevase.
Fixes #33778 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@34061 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 22:51:17 +00:00
28c4ddae7c
Passwords: Refresh password fields when content is pasted into fields.
...
Use feature detection to determine whether password inputs should use the `keyup` or `input` event.
Props peterwilsoncc, adamsilverstein.
Fixes #33398 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34060 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 21:51:31 +00:00
33953cb392
Introduce `wp_validate_action( $action = '' )`, a helper function that checks `$_REQUEST` for `action` and returns it, or empty string if not present. If `$action` is passed, it checks to make sure they match before returning it, or an empty string. Strings are always returned to avoid returning multiple types.
...
Implementing this removes 27 uses of direct superglobal access in the admin.
For more reading:
https://codeclimate.com/github/WordPress/WordPress/wp-admin/edit-comments.php
See #33837 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34059 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 21:07:45 +00:00
9805723e3d
Site Icon: For preview fall back to `full` size URL when `thumbnail` size doesn't exist.
...
Prevents a JavaScript error for rare cases when cropping is skipped and the image is smaller than `thumbnail`.
Props tyxla.
Fixes #33417 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34056 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 20:12:50 +00:00
f30a1c86b1
About: Remove period from placeholder.
...
The position of periods is different in some languages, like Japanese. This removes the period from the last placeholder for the Template Hierarchy section. It doesn't include a new period to avoid a string change in a minor release.
Props extendwings, chriscct7.
Fixes #33429 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34054 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 19:26:02 +00:00
a01c10a3b9
Better align table headers with table cells on success screen after installing.
...
Props umesh.nevase.
Fixes #33796 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34043 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 11:25:30 +00:00
5cce4a3262
After [33961], pass `$comment` to `get_comment_link()` where possible to avoid extra cache/db lookups.
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34042 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 06:20:56 +00:00
4a6a7edf55
After [33961], pass `$comment` to `get_comment_date()` where possible to avoid extra cache/db lookups.
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34041 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 06:14:04 +00:00
9ab431873c
After [33961], pass `$comment` to `comment_class()` where possible to avoid extra cache/db lookups.
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34040 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 06:11:35 +00:00
db702bc3ea
After [33961], pass `$comment` to `get_comment_author_link()` where possible to avoid extra cache/db lookups.
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34039 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 06:04:22 +00:00
4cd30ede79
After [34015], handle orphaned comments in the Dashboard comments widget. Pass full `$comment` versus just passing the comment ID when possible.
...
See #33710 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34038 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 05:55:27 +00:00
3f557063be
Create a new file, `wp-admin/includes/noop.php`, which loads all of the noop functions for `load-script|styles.php` and is only loaded by those files. DRYs in the process.
...
See #33813 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34037 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 05:03:55 +00:00
da65ac0471
Move ad hoc functions from `wp-admin/credits.php` to `wp-admin/includes/credits.php`, which is only included by the former.
...
See #33813 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34036 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 04:54:20 +00:00
5b9d9c7c07
Require numeric IDs in user deletion functions.
...
`wp_delete_user()` and `wpmu_delete_user()` both require an `$id` parameter.
Previously, the functions did not verify that the value passed was, in fact,
a number. As such, passing an object or any other entity that would be cast
to int `1` would result in user 1 being deleted. We fix this by enforcing
the requirement that `$id` be numeric.
Props dipesh.kakadiya, utkarshpatel, juliobox.
Fixes #33800 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34034 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 02:24:03 +00:00
32b8ff1b14
Schema: Increase the length of `wp_options.option_name`.
...
It's pretty easy to run over the `option_name` length, which causes undefined behaviour when inserting and retrieving options. Increasing the length from `VARCHAR(64)` to `VARCHAR(191)` significantly reduces the risk of this occurring.
Because `option_name` has a `UNIQUE` index, we can only increase it to 191 characters, rather than 255. The index can only use a prefix of 191 characters, so will incorrectly restrict long different strings that have the same prefix, if we make the column longer.
Props scribu, OriginalEXE, khromov, MikeHansenMe, netweb, pento.
Fixes #13310 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34030 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 01:25:21 +00:00
bdd42a0902
Set the `secure` flag on the `wp-saving-post` cookie when using HTTPS.
...
This cookie doesn't contain any sensitive information, but this change brings its behaviour in line with all other core cookies.
Fixes #31056
git-svn-id: https://develop.svn.wordpress.org/trunk@34027 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 22:41:08 +00:00
b1a91e4a28
Move `network_settings_add_js()` from `wp-admin/network/settings.php` to `wp-admin/includes/ms.php`.
...
See #33813 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34026 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 22:23:47 +00:00
2fe412793e
Move `confirm_delete_users()` from `wp-admin/network/users.php` to `wp-admin/includes/ms.php`.
...
See #33813 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34025 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 22:22:44 +00:00
ea07ff2e63
Create `wp-admin/includes/network.php` via `svn cp` and only load it in `wp-admin/network.php`. Move the functions there.
...
See #33813 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34023 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 22:00:58 +00:00
ab4fcd20d0
Move ad hoc Options functions to `wp-admin/includes/options.php`:
...
* Move `options_discussion_add_js()` from `wp-admin/options-discussion.php`
* Move `options_general_add_js()` from `wp-admin/options-general.php`
* Move `options_permalink_add_js()` from `wp-admin/options-permalink.php`
* Move `options_reading_add_js()` from `wp-admin/options-reading.php`
* Move `options_reading_blog_charset()` from `wp-admin/options-reading.php`
See #33813 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34022 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 21:44:29 +00:00
96a40d6102
Move 2 ad hoc user admin functions:
...
* Move `use_ssl_preference()` from `wp-admin/user-edit.php` to `wp-admin/includes/user.php`.
* Move `admin_created_user_email()` from `wp-admin/user-new.php` to `wp-admin/includes/user.php`.
See #33813 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34021 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 21:32:46 +00:00
d7670b6a38
Move `redirect_post()` from `wp-admin/post.php` to `wp-admin/includes/post.php`.
...
See #33813 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34020 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 21:30:24 +00:00
037cdcb412
Move `comment_footer_die()` from `wp-admin/comment.php` to `wp-admin/includes/comment.php`.
...
See #33813 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34019 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 21:28:18 +00:00
706cdbc671
Move `plugin_sandbox_scrape()` from `wp-admin/plugins.php` to `wp-admin/includes/plugin.php`.
...
See #33813 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34018 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 21:23:17 +00:00
8af9ff0e56
Move `wp_widgets_access_body_class()` (a hook callback) from `wp-admin/widgets.php` to `wp-admin/includes/widgets.php`.
...
See #33813 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34017 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 21:21:27 +00:00
a55b56c3d2
After [34004], don't break apart the paragraph into multiple translatable strings.
...
Fixes #18418 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34016 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 20:59:35 +00:00
7bf64e0125
Comments/PHP Notices: check that a parent comment exists before displaying an orphan's link to it in the admin.
...
Props rachelbaker.
Fixes #33710 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34015 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 20:50:12 +00:00
7b59221ea1
`_wpThemeSettings.l10n.searchPlaceholder` is an input placeholder and doesn't handle UTF-8 or HTML entities properly. In lieu of using literal Unicode here, use `...`.
...
See #32875 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34014 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 20:35:03 +00:00
9b193ad5a4
Multisite: Display content attribution drop down when deleting a user
...
The previous move from `echo()` to `_e()` left some of the output hanging. Introduced in [32333].
Props figureone.
Fixes #33811 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@34012 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 20:25:07 +00:00
d937112e9f
Grunt RTL CSS: `swap-dashicons-left-right-arrows` in `rtlcss:properties` expects double-quoted `content` strings in CSS. It doesn't swap single-quoted values.
...
Props Ankit K Gupta, yoavf, netweb.
Fixes #33786 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34011 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 20:21:57 +00:00
be9cd867df
In `wp_generate_attachment_metadata()`, also pass `$metadata` to the `intermediate_image_sizes_advanced` filter.
...
Props amereservant, wonderboymusic.
Fixes #23401 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34007 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 18:03:20 +00:00
09df5b81a1
Add a "View" row action for approved comments on the Dashboard screen, remove the link labeled `#`.
...
Props rachelbaker, zeo.
Fixes #18885 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34006 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 17:48:34 +00:00
532baa4c5f
In `WP_Posts_List_Table::column_date()`, the order of status and time should be switched. It doesn't make sense for phrases like "Last Modified" to occur AFTER the date. Should be before.
...
Props johnbillion, wonderboymusic.
Fixes #18641 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34005 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 17:42:55 +00:00
f5ce2ba96d
Cleanup the text for `Publish Settings > Publish` in the `edit-form-advanced` help tab. Clarify that Private posts aren't hidden from editors and administrators.
...
Props sillybean.
Fixes #18418 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34004 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 17:35:17 +00:00
0a7636cfa3
In `wp_media_upload_handler()`, replace a lingering instance of `media_upload_gallery()` with `wp_iframe(...)`
...
Props jeffstieler, antpb.
Fixes #17812 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34003 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 17:23:23 +00:00
7178b67671
`media-new.php`, when using the browser uploader, if the result of uploading is a `WP_Error` - `wp_die()` with the error, instead of redirecting with a generic error.
...
Props solarissmoke.
Fixes #16820 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34002 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 17:17:22 +00:00
2deb9565c0
When deleting via User List Table, don't prompt for re-attribution if the user(s) do(es) not have any posts.
...
Props rajnikmit, wojtek.szkutnik, benjmay, wonderboymusic.
Fixes #6405 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34000 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 16:46:38 +00:00
5d8eb77621
Merge two similar strings.
...
Props dipesh.kakadiya.
Fixes #33777 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33998 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 10:58:58 +00:00
ef1f697564
Multisite: Allow users with `manage_network_users` to edit network users.
...
Other users in a network can now be given capabilities to manage users without also having global super admin privileges.
* Users with `manage_network_users` can not edit super admins.
* Users with `manage_network_users` can not promote users to super admin.
* Uses of `is_super_admin()` in `user-new.php` are now updated to `manage_network_users`.
Props daniellandau, chriscct7.
Fixes #16860 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33988 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 03:33:22 +00:00
a025ce4f12
After the `global` churn in [33964], also set `$post` to `null` at the end of `WP_Comments_List_Table::single_row()` to ensure that an orphaned comment doesn't inherit the previous row's `$post` context.
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33986 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 03:11:09 +00:00
6bc498c0e6
Implement a priority system for Help Tabs to add them at specific positions.
...
Adds unit tests.
Props swissspidy.
Fixes #19828 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33985 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 01:26:26 +00:00
89f4c471fa
Add `@access` docs to `class-wp-filesystem-*` files.
...
Props wenthemes.
Fixes #33725 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33984 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 01:20:58 +00:00
c5220e43f5
Plugins page: re-word "No out of date plugins were selected." to "All selected plugins are up to date." since it's not really an error condition.
...
Props swissspidy.
Fixes #26494 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33983 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 01:10:25 +00:00
c83106d13f
After [33821], when dynamically updating the document title text of the Comments List Table page, operate only on the fragment that contains the comment count. This prevents us from including other numbers that may be present in the other title parts (site title, etc).
...
See #33414 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33982 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 01:02:05 +00:00
81ec5c8e91
Docs: Add a changelog entry to the DocBlock for `touch_time()` to mention the shift from accessing the global `$comment` to using `get_comment()`.
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33979 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 15:47:43 +00:00
d6e73d47e4
Round 2 of: We should use ellipses … / … instead of three dots/periods ... e.g Loading… not Loading...
...
Props yoavf.
Fixes #32875 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33970 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 04:38:31 +00:00
047f3ef01a
Revisions screen: change language from "Return to post editor" to "Return to editor" - more generic for usage by custom post types.
...
Props lancewillett, adamsilverstein.
Fixes #31910 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33966 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 03:22:36 +00:00
42e8258275
Use `get_comment()` instead of a global in `touch_time()`.
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33965 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 03:04:38 +00:00
df637648e2
In `WP_Comments_List_Table`, favor passing `WP_Comment` instances instead of `$comment_ID` to template functions. This allows us to bypass unnecessary cache lookups and simply pass the object through when it is set.
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33964 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 02:59:54 +00:00
38d374ab01
After [33891], `get_comment()` returns `global $comment` if no args are passed and the global is set (after setting the default to `null` here). This allows us to ditch global comment imports.
...
See #33638 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33963 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 02:50:43 +00:00
5936394bb6
In `WP_User`, add `@property` docs for `description`, `first_name`, and `last_name`. `user_firstname` and `user_lastname` only exist for back-compat.
...
See #33491 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33958 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 01:12:41 +00:00
f8b6a357a0
Multisite: Don't allow sites to be created with the following reserved slugs: `wp-admin`, `wp-content`, `wp-includes`
...
Props austinginder.
Fixes #33615 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33952 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 19:31:52 +00:00
9f2738924c
Bump H3 headings to H2 on the Network Add New User screen for better accessibility.
...
Props Cheffheid.
Fixes #33605 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33945 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 16:02:43 +00:00
395c8b7cd4
Customize: Fix logic for determining the container element when focusing on a panel, section, or control.
...
Fixes #33695 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@33939 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 05:58:44 +00:00
0c101e8cf6
Customize: Fix clearing of a color control's setting by using proper empty value.
...
Props stevehenty.
Fixes #30280 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33938 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 05:47:17 +00:00
8f2b90e299
Widgets: Don't display sidebar description container if it's empty.
...
Props paulwilde.
Fixes #32448 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33934 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-06 07:59:01 +00:00
3853980a9a
Merge two permission error strings.
...
Props pavelevap.
Fixes #33745 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33933 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-06 06:41:58 +00:00
5d9dcf3d8a
Correct description for `version` and `current_version` parameters in `wp_check_browser_version()` response.
...
Props extendwings.
Fixes #33753 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33932 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-06 00:16:02 +00:00
8512ff08c0
Correct the docblock for `wp_list_widget_controls()`.
...
Props swissspidy.
Fixes #33751 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33930 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 23:37:17 +00:00
038a2c3b7a
List tables: Adjust the styles for checkbox column to align better with longer column names.
...
Props swissspidy.
Fixes #32825 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33928 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 23:15:57 +00:00
6b5e1e8c9b
Multisite: Update help tab text for `site-info.php` to reference "site URL".
...
In [32759] and [33586], we combined the domain and path entry for a site to a single "Site URL" field. This updates the help text to reflect that.
Fixes #33748 . See #22383 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33921 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:52:52 +00:00
38fe3c4db5
Implement a language chooser on the Network Admin -> Sites -> Add New screen.
...
Props DrewAPicture
Fixes #33528
git-svn-id: https://develop.svn.wordpress.org/trunk@33920 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:47:00 +00:00
d77b6f99c6
Multisite: Pass the ID of the site being updated to `wpmu_update_blog_options` action.
...
Props @swissspidy, @MikeHansenMe.
Fixes #32907 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33918 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:38:27 +00:00
1adb9643d9
Bump H3 headings to H2 on the {Term} screens for better accessibility.
...
Props mrahmadawais.
Fixes #33658 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33917 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:16:17 +00:00
31663c6782
Bump H3 headings to H2 on the Discussion Settings screen for better accessibility.
...
Props mrahmadawais.
Fixes #33609 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33916 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:14:00 +00:00
3484a266a1
Bump H3 headings to H2 on the Media Settings screen for better accessibility.
...
Props metodiew.
Fixes #33610 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33915 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:11:24 +00:00
32d296fb6a
Bump H3 headings to H2 on Export screen for better accessibility.
...
Props metodiew.
Fixes #33608 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33914 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 20:08:29 +00:00
b8e30f3ec7
Dashicons CSS: one-word font families don't need quotes. Font families with a space in the name should use double-quotes (doesn't apply here).
...
Props afercia.
Fixes #32866 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33912 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 19:56:15 +00:00
38038ccba3
Add Customizer docs.
...
Props ericlewis.
See #33503 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33911 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 19:52:17 +00:00
7b3b1c12d5
Accessibility: bump H3 headings to H2 on User Edit and Your Profile screens.
...
Ongoing effort to restore a good headings hierarchy in the admin screens after the reintroduction of the missing main `<h1>` in [32974].
Fix a typo in the DocBlock for the `additional_capabilities_display` filter.
Props metodiew.
Fixes #33606 . See #31650 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33909 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 18:29:40 +00:00
36ed764d60
Fix closing div in `wp_print_request_filesystem_credentials_modal()`.
...
Props trepmal.
Fixes #33737 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33908 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 15:16:15 +00:00
3fba46b557
Allow `wp_terms_checklist()` to return markup rather than echoing it.
...
Props kevinlangleyjr.
Fixes #33720 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33904 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 21:24:04 +00:00
dfceba6d05
Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/js/customize-controls.js`.
...
fixes #33685 . see #14530 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33902 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 03:39:33 +00:00
43c8ec5f32
Handle more cases (`untrailingslashit`, HTTPS urls) for sanitizing an author URL for display in the comments list table.
...
Props afercia, mehulkaklotar, swissspidy, johnbillion.
Fixes #33291 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33894 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 23:22:32 +00:00
Drew Jaynes
Scott Taylor
wonderboymusic
Helen Hou-Sandi
John Blackbourn
Konstantin Obenland
Dominik Schilling (ocean90)
Sergey Biryukov
Aaron Jorbin
Dion Hulse
Weston Ruter
Boone Gorges
Nikolay Bachiyski
Andrea Fercia
Andrew Ozz
Gary Pendergast
Jeremy Felt