sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
31,975 Commits 2 Branches 473 Tags 137 MiB
Commit Graph

3571 Commits

Author SHA1 Message Date
Scott Taylor 166ee8674b More comment functions can accept a full object instead of comment_ID to reduce cache/db lookups. 
See ##33638.



git-svn-id: https://develop.svn.wordpress.org/trunk@34129 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 21:39:46 +00:00
Scott Taylor ab7ca361dd In `WP_List_Table`, make a new `public` method, `->get_primary_column()`, and revert [34101] due to BC issues. 
Fixes #33854.


git-svn-id: https://develop.svn.wordpress.org/trunk@34128 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 20:28:29 +00:00
Scott Taylor ea610e66d4 In `WP_Media_List_Table`, fetch all pending comment counts at once, instead of for each row in the loop. 
See #11381.


git-svn-id: https://develop.svn.wordpress.org/trunk@34127 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 19:24:59 +00:00
Dominik Schilling (ocean90) 08098026ce Passwords: Deprecate second parameter of `wp_new_user_notification()`. 
The second parameter `$plaintext_pass` was removed in [33023] and restored as `$notify` in [33620] with a different behavior. If you have a plugin overriding `wp_new_user_notification()` which hasn't been updated you would get a notification with your username and the password "both".
To prevent this the second parameter is now deprecated and reintroduced as the third parameter.

Adds unit tests.

Props kraftbj, adamsilverstein, welcher, ocean90.
Fixes #33654.

(Don't ask for new pluggables kthxbye)

git-svn-id: https://develop.svn.wordpress.org/trunk@34116 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 12:42:34 +00:00
Dominik Schilling (ocean90) 0a77429937 Passwords: Trigger a `wp-check-valid-field` event when the password field is filled with a password by `generatePassword()`. 
Updates event handler in `wpAjax.invalidateForm()` to support `wp-check-valid-field`.

See #33406.

git-svn-id: https://develop.svn.wordpress.org/trunk@34114 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 10:38:32 +00:00
Scott Taylor a6a03da7f5 Add an argument to `parent_dropdown()`, `$post`, to allow it to be called for an arbitrary post. 
Fixes #23162.


git-svn-id: https://develop.svn.wordpress.org/trunk@34111 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 03:19:59 +00:00
Scott Taylor a620cd1e34 Turn off `autocomplete` for the `new-post-slug` field. 
Props johnbillion.
Fixes #32752.


git-svn-id: https://develop.svn.wordpress.org/trunk@34105 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 02:02:58 +00:00
Scott Taylor 5a93988ca3 Make `WP_List_Table::get_primary_column_name()` public in list table classes that have it. 
Fixes #33854.


git-svn-id: https://develop.svn.wordpress.org/trunk@34101 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 01:11:44 +00:00
Andrea Fercia 34c6893080 Bump H3 headings to H2 on the Writing Settings screen for better accessibility. 
Props mrahmadawais.
Fixes #33651.

git-svn-id: https://develop.svn.wordpress.org/trunk@34096 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-13 16:47:54 +00:00
Helen Hou-Sandi 379dd889c1 Comments: Fix inline edit/reply on small screens. 
props ocean90, SergeyBiryukov.
fixes #33596.


git-svn-id: https://develop.svn.wordpress.org/trunk@34094 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-13 12:46:03 +00:00
Weston Ruter fd1dbfe003 Customize: Remove redundant `aria-label` attributes. 
Adds an `$options` array argument to `WP_Screen::render_screen_options()` to allow the `div#screen-options-wrap` element to be omitted when `wrap` value is `false`.

Props afercia, westonruter.
Fixes #33182.


git-svn-id: https://develop.svn.wordpress.org/trunk@34093 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-13 06:15:42 +00:00
Dominik Schilling (ocean90) 07ea6a2334 Themes: Don't use HTML entities for placeholders. 
See #32875.

git-svn-id: https://develop.svn.wordpress.org/trunk@34086 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 19:47:53 +00:00
Scott Taylor ad20c3db4a `WP_Posts_List_Table`: there are a cadre of `edit.php` URLs that are generated by string-building instead of using our handy functions. Create a helper method, `->get_edit_link()` that standardizes the generation and escaping of these URLs. 
Props BdN3504 for the initial patch on the ticket.
Fixes #32376.


git-svn-id: https://develop.svn.wordpress.org/trunk@34084 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 17:12:25 +00:00
Scott Taylor 2a72a1f959 Use `table-layout: auto` (instead of `fixed`) on `table.fixed` to ensure that things like date/time don't horrendously wrap on small screens. Before/After screenshots attached to the ticket. 
Props gaelan.
Fixes #32691.


git-svn-id: https://develop.svn.wordpress.org/trunk@34083 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 16:03:17 +00:00
Scott Taylor faf87c2ca6 After [34076], fix the logic for `post_status` in months dropdown. 
See #21015.


git-svn-id: https://develop.svn.wordpress.org/trunk@34077 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 08:18:18 +00:00
Scott Taylor 927ad00bab List Tables: don't render "extra tablenav" if there are no posts. This includes Bulk Actions, Dates Dropdown, Category Dropdowns, Pagination. 
Also ensure that the Months dropdown, when it is shown, shows months from the proper set of posts.

Props egower, CoenJacobs, MikeHansenMe, mehulkaklotar.
Fixes #33824, #21015, #21856.


git-svn-id: https://develop.svn.wordpress.org/trunk@34076 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 08:12:43 +00:00
Scott Taylor 9831fa216c AJAX Reply to Comment: check the `edit_comment` cap when parent comment will be auto-approved. 
Props rachelbaker.
Fixes #23939.


git-svn-id: https://develop.svn.wordpress.org/trunk@34074 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 07:18:36 +00:00
Scott Taylor 3cbec930bb Edit Comment screen: remove the "View Comment" button (actually a link) from the publish meta box. Mimic the "Edit URL/Permalink" UI from the Edit Post screen to show the comment link below the screen title, but make it an actual link, not a button. 
Props ocean90, DrewAPicture, wonderboymusic.
Fixes #19168.


git-svn-id: https://develop.svn.wordpress.org/trunk@34072 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 03:19:21 +00:00
Scott Taylor 6a262bd6ce Quick Edit: fix an ID attribute name collision by renaming one of the author fields `author-name`. 
Props afercia.
Fixes #33770.


git-svn-id: https://develop.svn.wordpress.org/trunk@34070 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 02:34:52 +00:00
Scott Taylor 0f2078bc9e When clicking "Show More Comments" in the Comments meta box on the Edit Post screen, change the click behavior to call a new class method on `commentsBox`, `->load()`, that resets `st` (cool name) to the number of visible `<tr>`s before calling `->get()`. This will account for spam'd and trash'd comments when returning comments at the proper offset. 
Props utkarshpatel.
Fixes #33829.


git-svn-id: https://develop.svn.wordpress.org/trunk@34069 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 02:27:50 +00:00
Andrew Ozz f855ddb134 Settings, password field: fix placement of the error icon and removal of the error class. 
Props liljimmi, adamsilverstein.
Fixes #33406 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@34068 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 00:09:09 +00:00
Andrea Fercia 1a333bd537 Bump H3 headings to H2 on the Plugin Editor screen for better accessibility. 
Fixes #33839.

git-svn-id: https://develop.svn.wordpress.org/trunk@34067 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 00:07:23 +00:00
Andrea Fercia 41c74b9bf6 Bump H3 headings to H2 on the Theme Editor screen for better accessibility. 
Props mrahmadawais.
Fixes #33660.

git-svn-id: https://develop.svn.wordpress.org/trunk@34066 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 23:59:30 +00:00
Andrea Fercia c492832e6a Nav Menus: fix the quick search spinner position on Operating Systems that show scrollbars. 
Fixes #33290.

git-svn-id: https://develop.svn.wordpress.org/trunk@34065 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 23:51:53 +00:00
Andrea Fercia bc8e3599e6 Quick Edit: fix the Tags auto-suggest tooltip visibility. 
Be sure to hide the `jquery.suggest` Tags textarea tooltip also when using the keyboard to Save/Cancel.

Props rommelxcastro for the initial patch.
Fixes #32580.

git-svn-id: https://develop.svn.wordpress.org/trunk@34064 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 23:33:43 +00:00
Andrew Ozz e5324c4c91 Settings: properly set the password field label on loading. 
See #33778.

git-svn-id: https://develop.svn.wordpress.org/trunk@34062 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 23:04:53 +00:00
Andrew Ozz 504d75e4c1 Settings: reassign the label when switching password fields so it always highlights the visible field. 
Props umesh.nevase.
Fixes #33778 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@34061 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 22:51:17 +00:00
Dominik Schilling (ocean90) 28c4ddae7c Passwords: Refresh password fields when content is pasted into fields. 
Use feature detection to determine whether password inputs should use the `keyup` or `input` event.

Props peterwilsoncc, adamsilverstein.
Fixes #33398.

git-svn-id: https://develop.svn.wordpress.org/trunk@34060 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 21:51:31 +00:00
Scott Taylor 33953cb392 Introduce `wp_validate_action( $action = '' )`, a helper function that checks `$_REQUEST` for `action` and returns it, or empty string if not present. If `$action` is passed, it checks to make sure they match before returning it, or an empty string. Strings are always returned to avoid returning multiple types. 
Implementing this removes 27 uses of direct superglobal access in the admin.

For more reading:
https://codeclimate.com/github/WordPress/WordPress/wp-admin/edit-comments.php

See #33837.


git-svn-id: https://develop.svn.wordpress.org/trunk@34059 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 21:07:45 +00:00
Dominik Schilling (ocean90) 9805723e3d Site Icon: For preview fall back to `full` size URL when `thumbnail` size doesn't exist. 
Prevents a JavaScript error for rare cases when cropping is skipped and the image is smaller than `thumbnail`.

Props tyxla.
Fixes #33417.

git-svn-id: https://develop.svn.wordpress.org/trunk@34056 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 20:12:50 +00:00
Dominik Schilling (ocean90) f30a1c86b1 About: Remove period from placeholder. 
The position of periods is different in some languages, like Japanese. This removes the period from the last placeholder for the Template Hierarchy section. It doesn't include a new period to avoid a string change in a minor release.

Props extendwings, chriscct7.
Fixes #33429.

git-svn-id: https://develop.svn.wordpress.org/trunk@34054 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 19:26:02 +00:00
Sergey Biryukov a01c10a3b9 Better align table headers with table cells on success screen after installing. 
Props umesh.nevase.
Fixes #33796.

git-svn-id: https://develop.svn.wordpress.org/trunk@34043 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 11:25:30 +00:00
Scott Taylor 5cce4a3262 After [33961], pass `$comment` to `get_comment_link()` where possible to avoid extra cache/db lookups. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@34042 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 06:20:56 +00:00
Scott Taylor 4a6a7edf55 After [33961], pass `$comment` to `get_comment_date()` where possible to avoid extra cache/db lookups. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@34041 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 06:14:04 +00:00
Scott Taylor 9ab431873c After [33961], pass `$comment` to `comment_class()` where possible to avoid extra cache/db lookups. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@34040 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 06:11:35 +00:00
Scott Taylor db702bc3ea After [33961], pass `$comment` to `get_comment_author_link()` where possible to avoid extra cache/db lookups. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@34039 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 06:04:22 +00:00
Scott Taylor 4cd30ede79 After [34015], handle orphaned comments in the Dashboard comments widget. Pass full `$comment` versus just passing the comment ID when possible. 
See #33710.


git-svn-id: https://develop.svn.wordpress.org/trunk@34038 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 05:55:27 +00:00
Scott Taylor 3f557063be Create a new file, `wp-admin/includes/noop.php`, which loads all of the noop functions for `load-script|styles.php` and is only loaded by those files. DRYs in the process. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34037 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 05:03:55 +00:00
Scott Taylor da65ac0471 Move ad hoc functions from `wp-admin/credits.php` to `wp-admin/includes/credits.php`, which is only included by the former. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34036 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 04:54:20 +00:00
Boone Gorges 5b9d9c7c07 Require numeric IDs in user deletion functions. 
`wp_delete_user()` and `wpmu_delete_user()` both require an `$id` parameter.
Previously, the functions did not verify that the value passed was, in fact,
a number. As such, passing an object or any other entity that would be cast
to int `1` would result in user 1 being deleted. We fix this by enforcing
the requirement that `$id` be numeric.

Props dipesh.kakadiya, utkarshpatel, juliobox.
Fixes #33800.

git-svn-id: https://develop.svn.wordpress.org/trunk@34034 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 02:24:03 +00:00
Gary Pendergast 32b8ff1b14 Schema: Increase the length of `wp_options.option_name`. 
It's pretty easy to run over the `option_name` length, which causes undefined behaviour when inserting and retrieving options. Increasing the length from `VARCHAR(64)` to `VARCHAR(191)` significantly reduces the risk of this occurring.

Because `option_name` has a `UNIQUE` index, we can only increase it to 191 characters, rather than 255. The index can only use a prefix of 191 characters, so will incorrectly restrict long different strings that have the same prefix, if we make the column longer.

Props scribu, OriginalEXE, khromov, MikeHansenMe, netweb, pento.

Fixes #13310.



git-svn-id: https://develop.svn.wordpress.org/trunk@34030 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 01:25:21 +00:00
John Blackbourn bdd42a0902 Set the `secure` flag on the `wp-saving-post` cookie when using HTTPS. 
This cookie doesn't contain any sensitive information, but this change brings its behaviour in line with all other core cookies.

Fixes #31056


git-svn-id: https://develop.svn.wordpress.org/trunk@34027 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 22:41:08 +00:00
Scott Taylor b1a91e4a28 Move `network_settings_add_js()` from `wp-admin/network/settings.php` to `wp-admin/includes/ms.php`. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34026 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 22:23:47 +00:00
Scott Taylor 2fe412793e Move `confirm_delete_users()` from `wp-admin/network/users.php` to `wp-admin/includes/ms.php`. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34025 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 22:22:44 +00:00
Scott Taylor ea07ff2e63 Create `wp-admin/includes/network.php` via `svn cp` and only load it in `wp-admin/network.php`. Move the functions there. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34023 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 22:00:58 +00:00
Scott Taylor ab4fcd20d0 Move ad hoc Options functions to `wp-admin/includes/options.php`: 
* Move `options_discussion_add_js()` from `wp-admin/options-discussion.php`
* Move `options_general_add_js()` from `wp-admin/options-general.php`
* Move `options_permalink_add_js()` from `wp-admin/options-permalink.php`
* Move `options_reading_add_js()` from `wp-admin/options-reading.php`
* Move `options_reading_blog_charset()` from `wp-admin/options-reading.php`

See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34022 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 21:44:29 +00:00
Scott Taylor 96a40d6102 Move 2 ad hoc user admin functions: 
* Move `use_ssl_preference()` from `wp-admin/user-edit.php` to `wp-admin/includes/user.php`.
* Move `admin_created_user_email()` from `wp-admin/user-new.php` to `wp-admin/includes/user.php`.

See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34021 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 21:32:46 +00:00
Scott Taylor d7670b6a38 Move `redirect_post()` from `wp-admin/post.php` to `wp-admin/includes/post.php`. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34020 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 21:30:24 +00:00
Scott Taylor 037cdcb412 Move `comment_footer_die()` from `wp-admin/comment.php` to `wp-admin/includes/comment.php`. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34019 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 21:28:18 +00:00
Scott Taylor 706cdbc671 Move `plugin_sandbox_scrape()` from `wp-admin/plugins.php` to `wp-admin/includes/plugin.php`. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34018 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 21:23:17 +00:00
Scott Taylor 8af9ff0e56 Move `wp_widgets_access_body_class()` (a hook callback) from `wp-admin/widgets.php` to `wp-admin/includes/widgets.php`. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34017 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 21:21:27 +00:00
Scott Taylor a55b56c3d2 After [34004], don't break apart the paragraph into multiple translatable strings. 
Fixes #18418.


git-svn-id: https://develop.svn.wordpress.org/trunk@34016 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 20:59:35 +00:00
Scott Taylor 7bf64e0125 Comments/PHP Notices: check that a parent comment exists before displaying an orphan's link to it in the admin. 
Props rachelbaker.
Fixes #33710.


git-svn-id: https://develop.svn.wordpress.org/trunk@34015 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 20:50:12 +00:00
Scott Taylor 7b59221ea1 `_wpThemeSettings.l10n.searchPlaceholder` is an input placeholder and doesn't handle UTF-8 or HTML entities properly. In lieu of using literal Unicode here, use `...`. 
See #32875.


git-svn-id: https://develop.svn.wordpress.org/trunk@34014 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 20:35:03 +00:00
Jeremy Felt 9b193ad5a4 Multisite: Display content attribution drop down when deleting a user 
The previous move from `echo()` to `_e()` left some of the output hanging. Introduced in [32333].

Props figureone.
Fixes #33811 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@34012 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 20:25:07 +00:00
Scott Taylor d937112e9f Grunt RTL CSS: `swap-dashicons-left-right-arrows` in `rtlcss:properties` expects double-quoted `content` strings in CSS. It doesn't swap single-quoted values. 
Props Ankit K Gupta, yoavf, netweb.
Fixes #33786.


git-svn-id: https://develop.svn.wordpress.org/trunk@34011 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 20:21:57 +00:00
Scott Taylor be9cd867df In `wp_generate_attachment_metadata()`, also pass `$metadata` to the `intermediate_image_sizes_advanced` filter. 
Props amereservant, wonderboymusic.
Fixes #23401.


git-svn-id: https://develop.svn.wordpress.org/trunk@34007 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 18:03:20 +00:00
Scott Taylor 09df5b81a1 Add a "View" row action for approved comments on the Dashboard screen, remove the link labeled `#`. 
Props rachelbaker, zeo.
Fixes #18885. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34006 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 17:48:34 +00:00
Scott Taylor 532baa4c5f In `WP_Posts_List_Table::column_date()`, the order of status and time should be switched. It doesn't make sense for phrases like "Last Modified" to occur AFTER the date. Should be before. 
Props johnbillion, wonderboymusic.
Fixes #18641. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34005 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 17:42:55 +00:00
Scott Taylor f5ce2ba96d Cleanup the text for `Publish Settings > Publish` in the `edit-form-advanced` help tab. Clarify that Private posts aren't hidden from editors and administrators. 
Props sillybean.
Fixes #18418. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34004 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 17:35:17 +00:00
Scott Taylor 0a7636cfa3 In `wp_media_upload_handler()`, replace a lingering instance of `media_upload_gallery()` with `wp_iframe(...)` 
Props jeffstieler, antpb.
Fixes #17812. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34003 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 17:23:23 +00:00
Scott Taylor 7178b67671 `media-new.php`, when using the browser uploader, if the result of uploading is a `WP_Error` - `wp_die()` with the error, instead of redirecting with a generic error. 
Props solarissmoke.
Fixes #16820. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34002 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 17:17:22 +00:00
Scott Taylor 2deb9565c0 When deleting via User List Table, don't prompt for re-attribution if the user(s) do(es) not have any posts. 
Props rajnikmit, wojtek.szkutnik, benjmay, wonderboymusic.
Fixes #6405. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34000 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 16:46:38 +00:00
Sergey Biryukov 5d8eb77621 Merge two similar strings. 
Props dipesh.kakadiya.
Fixes #33777.

git-svn-id: https://develop.svn.wordpress.org/trunk@33998 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 10:58:58 +00:00
Jeremy Felt ef1f697564 Multisite: Allow users with `manage_network_users` to edit network users. 
Other users in a network can now be given capabilities to manage users without also having global super admin privileges.

* Users with `manage_network_users` can not edit super admins.
* Users with `manage_network_users` can not promote users to super admin.
* Uses of `is_super_admin()` in `user-new.php` are now updated to `manage_network_users`.

Props daniellandau, chriscct7.
Fixes #16860.


git-svn-id: https://develop.svn.wordpress.org/trunk@33988 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 03:33:22 +00:00
Scott Taylor a025ce4f12 After the `global` churn in [33964], also set `$post` to `null` at the end of `WP_Comments_List_Table::single_row()` to ensure that an orphaned comment doesn't inherit the previous row's `$post` context. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33986 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 03:11:09 +00:00
Scott Taylor 6bc498c0e6 Implement a priority system for Help Tabs to add them at specific positions. 
Adds unit tests.

Props swissspidy.
Fixes #19828.


git-svn-id: https://develop.svn.wordpress.org/trunk@33985 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 01:26:26 +00:00
Scott Taylor 89f4c471fa Add `@access` docs to `class-wp-filesystem-*` files. 
Props wenthemes.
Fixes #33725.


git-svn-id: https://develop.svn.wordpress.org/trunk@33984 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 01:20:58 +00:00
Scott Taylor c5220e43f5 Plugins page: re-word "No out of date plugins were selected." to "All selected plugins are up to date." since it's not really an error condition. 
Props swissspidy.
Fixes #26494.


git-svn-id: https://develop.svn.wordpress.org/trunk@33983 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 01:10:25 +00:00
Scott Taylor c83106d13f After [33821], when dynamically updating the document title text of the Comments List Table page, operate only on the fragment that contains the comment count. This prevents us from including other numbers that may be present in the other title parts (site title, etc). 
See #33414.


git-svn-id: https://develop.svn.wordpress.org/trunk@33982 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 01:02:05 +00:00
Drew Jaynes 81ec5c8e91 Docs: Add a changelog entry to the DocBlock for `touch_time()` to mention the shift from accessing the global `$comment` to using `get_comment()`. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33979 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 15:47:43 +00:00
Scott Taylor d6e73d47e4 Round 2 of: We should use ellipses &hellip; / … instead of three dots/periods ... e.g Loading… not Loading... 
Props yoavf.
Fixes #32875.


git-svn-id: https://develop.svn.wordpress.org/trunk@33970 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 04:38:31 +00:00
Scott Taylor 047f3ef01a Revisions screen: change language from "Return to post editor" to "Return to editor" - more generic for usage by custom post types. 
Props lancewillett, adamsilverstein.
Fixes #31910.


git-svn-id: https://develop.svn.wordpress.org/trunk@33966 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 03:22:36 +00:00
Scott Taylor 42e8258275 Use `get_comment()` instead of a global in `touch_time()`. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33965 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 03:04:38 +00:00
Scott Taylor df637648e2 In `WP_Comments_List_Table`, favor passing `WP_Comment` instances instead of `$comment_ID` to template functions. This allows us to bypass unnecessary cache lookups and simply pass the object through when it is set. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33964 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 02:59:54 +00:00
Scott Taylor 38d374ab01 After [33891], `get_comment()` returns `global $comment` if no args are passed and the global is set (after setting the default to `null` here). This allows us to ditch global comment imports. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33963 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 02:50:43 +00:00
Scott Taylor 5936394bb6 In `WP_User`, add `@property` docs for `description`, `first_name`, and `last_name`. `user_firstname` and `user_lastname` only exist for back-compat. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33958 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 01:12:41 +00:00
Scott Taylor f8b6a357a0 Multisite: Don't allow sites to be created with the following reserved slugs: `wp-admin`, `wp-content`, `wp-includes` 
Props austinginder.
Fixes #33615.


git-svn-id: https://develop.svn.wordpress.org/trunk@33952 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-08 19:31:52 +00:00
Andrea Fercia 9f2738924c Bump H3 headings to H2 on the Network Add New User screen for better accessibility. 
Props Cheffheid.
Fixes #33605.

git-svn-id: https://develop.svn.wordpress.org/trunk@33945 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-07 16:02:43 +00:00
Weston Ruter 395c8b7cd4 Customize: Fix logic for determining the container element when focusing on a panel, section, or control. 
Fixes #33695 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33939 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-07 05:58:44 +00:00
Weston Ruter 0c101e8cf6 Customize: Fix clearing of a color control's setting by using proper empty value. 
Props stevehenty.
Fixes #30280.



git-svn-id: https://develop.svn.wordpress.org/trunk@33938 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-07 05:47:17 +00:00
Sergey Biryukov 8f2b90e299 Widgets: Don't display sidebar description container if it's empty. 
Props paulwilde.
Fixes #32448.

git-svn-id: https://develop.svn.wordpress.org/trunk@33934 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-06 07:59:01 +00:00
Sergey Biryukov 3853980a9a Merge two permission error strings. 
Props pavelevap.
Fixes #33745.

git-svn-id: https://develop.svn.wordpress.org/trunk@33933 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-06 06:41:58 +00:00
Sergey Biryukov 5d9dcf3d8a Correct description for `version` and `current_version` parameters in `wp_check_browser_version()` response. 
Props extendwings.
Fixes #33753.

git-svn-id: https://develop.svn.wordpress.org/trunk@33932 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-06 00:16:02 +00:00
Sergey Biryukov 8512ff08c0 Correct the docblock for `wp_list_widget_controls()`. 
Props swissspidy.
Fixes #33751.

git-svn-id: https://develop.svn.wordpress.org/trunk@33930 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 23:37:17 +00:00
Sergey Biryukov 038a2c3b7a List tables: Adjust the styles for checkbox column to align better with longer column names. 
Props swissspidy.
Fixes #32825.

git-svn-id: https://develop.svn.wordpress.org/trunk@33928 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 23:15:57 +00:00
Jeremy Felt 6b5e1e8c9b Multisite: Update help tab text for `site-info.php` to reference "site URL". 
In [32759] and [33586], we combined the domain and path entry for a site to a single "Site URL" field. This updates the help text to reflect that.

Fixes #33748. See #22383.


git-svn-id: https://develop.svn.wordpress.org/trunk@33921 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:52:52 +00:00
John Blackbourn 38fe3c4db5 Implement a language chooser on the Network Admin -> Sites -> Add New screen. 
Props DrewAPicture
Fixes #33528


git-svn-id: https://develop.svn.wordpress.org/trunk@33920 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:47:00 +00:00
Jeremy Felt d77b6f99c6 Multisite: Pass the ID of the site being updated to `wpmu_update_blog_options` action. 
Props @swissspidy, @MikeHansenMe.
Fixes #32907.


git-svn-id: https://develop.svn.wordpress.org/trunk@33918 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:38:27 +00:00
Scott Taylor 1adb9643d9 Bump H3 headings to H2 on the {Term} screens for better accessibility. 
Props mrahmadawais.
Fixes #33658.


git-svn-id: https://develop.svn.wordpress.org/trunk@33917 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:16:17 +00:00
Scott Taylor 31663c6782 Bump H3 headings to H2 on the Discussion Settings screen for better accessibility. 
Props mrahmadawais.
Fixes #33609.


git-svn-id: https://develop.svn.wordpress.org/trunk@33916 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:14:00 +00:00
Scott Taylor 3484a266a1 Bump H3 headings to H2 on the Media Settings screen for better accessibility. 
Props metodiew.
Fixes #33610.


git-svn-id: https://develop.svn.wordpress.org/trunk@33915 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:11:24 +00:00
Scott Taylor 32d296fb6a Bump H3 headings to H2 on Export screen for better accessibility. 
Props metodiew.
Fixes #33608.


git-svn-id: https://develop.svn.wordpress.org/trunk@33914 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 20:08:29 +00:00
Scott Taylor b8e30f3ec7 Dashicons CSS: one-word font families don't need quotes. Font families with a space in the name should use double-quotes (doesn't apply here). 
Props afercia.
Fixes #32866.


git-svn-id: https://develop.svn.wordpress.org/trunk@33912 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 19:56:15 +00:00
Scott Taylor 38038ccba3 Add Customizer docs. 
Props ericlewis.
See #33503.


git-svn-id: https://develop.svn.wordpress.org/trunk@33911 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 19:52:17 +00:00
Andrea Fercia 7b3b1c12d5 Accessibility: bump H3 headings to H2 on User Edit and Your Profile screens. 
Ongoing effort to restore a good headings hierarchy in the admin screens after the reintroduction of the missing main `<h1>` in [32974].

Fix a typo in the DocBlock for the `additional_capabilities_display` filter.

Props metodiew.
Fixes #33606. See #31650.

git-svn-id: https://develop.svn.wordpress.org/trunk@33909 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 18:29:40 +00:00
Sergey Biryukov 36ed764d60 Fix closing div in `wp_print_request_filesystem_credentials_modal()`. 
Props trepmal.
Fixes #33737.

git-svn-id: https://develop.svn.wordpress.org/trunk@33908 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 15:16:15 +00:00
Boone Gorges 3fba46b557 Allow `wp_terms_checklist()` to return markup rather than echoing it. 
Props kevinlangleyjr.
Fixes #33720.

git-svn-id: https://develop.svn.wordpress.org/trunk@33904 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 21:24:04 +00:00
Sergey Biryukov dfceba6d05 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/js/customize-controls.js`. 
fixes #33685. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33902 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 03:39:33 +00:00
Scott Taylor 43c8ec5f32 Handle more cases (`untrailingslashit`, HTTPS urls) for sanitizing an author URL for display in the comments list table. 
Props afercia, mehulkaklotar, swissspidy, johnbillion.
Fixes #33291.


git-svn-id: https://develop.svn.wordpress.org/trunk@33894 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 23:22:32 +00:00
Scott Taylor 60ba8b05e4 Introduce `WP_Comment` class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity. 
* Takes inspiration from `WP_Post` and adds sanity to comment caching. 
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now

Props wonderboymusic, nacin.

See #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@33891 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 18:16:35 +00:00
Helen Hou-Sandi 52f31a77e9 UI: Restrict textarea resizing to vertical to prevent ugliness. 
props tyxla, MatheusFD.
fixes #33400.


git-svn-id: https://develop.svn.wordpress.org/trunk@33890 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 18:04:27 +00:00
Sergey Biryukov 55bb26c58a Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/network/site-users.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33683. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33888 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 09:02:13 +00:00
Sergey Biryukov 7c32770901 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/includes/bookmark.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33682. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33887 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 08:58:34 +00:00
Sergey Biryukov 190561b89d Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/widgets.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33680. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33886 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 08:55:53 +00:00
Sergey Biryukov 708cd13d77 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/users.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33679. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33885 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 08:53:23 +00:00
Sergey Biryukov e7beccf78c Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/user-new.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33678. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33884 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 08:44:37 +00:00
Scott Taylor 4b9ccd27b1 After [33723], ensure that `$i` is properly set before looping. 
See #16865.


git-svn-id: https://develop.svn.wordpress.org/trunk@33867 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 18:47:51 +00:00
Sergey Biryukov 5cf9c22518 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/themes.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33677. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33866 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 18:44:07 +00:00
Sergey Biryukov 45237109dc Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/press-this.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33676. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33865 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 18:37:28 +00:00
Sergey Biryukov 89fca37568 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/post-new.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33675. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33864 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 18:35:05 +00:00
Sergey Biryukov 2dcbf39e2d Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/options.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33674. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33863 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 18:30:58 +00:00
Sergey Biryukov 31caf44a24 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/nav-menus.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33673. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33862 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 18:20:53 +00:00
Sergey Biryukov 50224510ec Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/edit.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33671. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33861 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 18:14:14 +00:00
Sergey Biryukov 0299c00fbb Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/edit-comments.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33669. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33860 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 18:03:10 +00:00
Sergey Biryukov 1ec4b77ac2 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/customize.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33668. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33857 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 17:05:01 +00:00
Andrea Fercia 2ffd8b52cf Customize: use correct CSS selectors for the Menu Customizer reorder-toggle button after [33604]. 
Fixes #33633.

git-svn-id: https://develop.svn.wordpress.org/trunk@33856 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 16:55:46 +00:00
Sergey Biryukov 22919f8150 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/custom-header.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33667. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33854 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 16:28:18 +00:00
Sergey Biryukov 1efad51200 Provide more helful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/media-upload.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33672. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33853 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 16:20:46 +00:00
Sergey Biryukov 029964a5ed Provide more helful feedback than just “Cheatin’ uh?” for permission errors in `wp-admin/edit-tags.php`. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33670. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33852 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 16:05:07 +00:00
John Blackbourn 46c336e78a Introduce `wp_removable_query_args()`, which returns an array of single-use query variables which can be removed from a URL. 
Also applies the function to the return URL when the Customizer is closed.

Fixes #32692
Props swissspidy, Mte90


git-svn-id: https://develop.svn.wordpress.org/trunk@33849 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 11:28:11 +00:00
Jeremy Felt 4d2dbebb35 Multisite: Remove duplicate span element output from row actions 
Fixes #32961.


git-svn-id: https://develop.svn.wordpress.org/trunk@33848 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-01 21:50:33 +00:00
Sergey Biryukov cfff91526f Merge two similar strings. 
props pavelevap.
fixes #33643.

git-svn-id: https://develop.svn.wordpress.org/trunk@33842 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-01 13:45:15 +00:00
Weston Ruter 57a7ed15a7 Customizer: Collapse any expanded panel/sections before expanding other panel/sections 
Fix removes need for workaround introduced in [33488] for direct link from nav menu widget to the customizer widgets panel. The todo is now implemented.

Props celloexpressions, westonruter.
Fixes #33396 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33837 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 23:07:57 +00:00
Andrew Ozz 43d053318e Editor, Press This: force a page reload when the user publishes a post and then clicks the back button. 
Fixes #23691.

git-svn-id: https://develop.svn.wordpress.org/trunk@33836 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 23:07:36 +00:00
Sergey Biryukov 79907af59c Add `'dashboard_secondary_items'` filter for the number of secondary link items in the 'WordPress News' dashboard widget. 
props MikeHansenMe, DrewAPicture.
fixes #31434.

git-svn-id: https://develop.svn.wordpress.org/trunk@33833 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 21:56:50 +00:00
SergeyBiryukov f0ab8b5a06 Add `'update_right_now_text'` filter for the text displayed in the 'At a Glance' dashboard widget. 
props obenland.
fixes #33355.

git-svn-id: https://develop.svn.wordpress.org/trunk@33832 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 21:44:02 +00:00
Drew Jaynes f7507e511d Docs: Add a duplicate filter comment to the `comment_email` filter call in `WP_Comments_List_Table`, introduced in [33829]. 
See #11566.


git-svn-id: https://develop.svn.wordpress.org/trunk@33830 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 21:21:14 +00:00
Scott Taylor e10c682b83 Remove the hamburger global'ing from [33828]: since no args are passed to `comment_author_email_link()`, the internals can be simplified and applied inline. 
See #11566. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33829 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 21:08:17 +00:00
Scott Taylor fef8794b2c Fix warnings after [33826]. Only only one function call needs a global `$comment`, we shall hamburger it. 
See #11566. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33828 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 20:58:12 +00:00
Scott Taylor 0f59069a7f `WP_Comments_List_Table::single_row()` has no reason to set the `$comment` global. No other methods use it, and we are not in template/loop context. This can mess with the response of `get_comment()` elsewhere, since `get_comment()` internally bypasses the cache/db when a global is set. 
See #11566. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33826 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 20:41:09 +00:00
Sergey Biryukov 20767f42aa Use `wp_html_excerpt()` to properly cut comment author URL for display on Comments screen. 
props brettz95, solarissmoke.
fixes #15659.

git-svn-id: https://develop.svn.wordpress.org/trunk@33825 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 20:40:28 +00:00
Scott Taylor af101dec19 Comments: dynamically update the document title text of the Comments List Table page when dynamically updating the number of comments awaiting moderation. 
Fixes #33414. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33821 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 17:57:32 +00:00
Sergey Biryukov ff7e86d14c Bump H3 headings to H2 on Themes screen for better accessibility. 
props joehills.
fixes #33560.

git-svn-id: https://develop.svn.wordpress.org/trunk@33820 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 03:50:05 +00:00
Sergey Biryukov 0de0c060c1 Bump H3 headings to H2 on Tools screen for better accessibility. 
props Cheffheid.
fixes #33607.

git-svn-id: https://develop.svn.wordpress.org/trunk@33819 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 03:31:38 +00:00
Sergey Biryukov 77b54f319d Bump H3 headings to H2 on Permalink Settings screen for better accessibility. 
props Cheffheid.
fixes #33611.

git-svn-id: https://develop.svn.wordpress.org/trunk@33818 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 03:28:32 +00:00
Sergey Biryukov 7f3b90bc77 Bump H3 headings to H2 on WordPress Updates screen for better accessibility. 
props Cheffheid.
fixes #33559.

git-svn-id: https://develop.svn.wordpress.org/trunk@33817 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 03:25:27 +00:00
Scott Taylor 413df72474 Favor using the consistent and agnostic string 'Attach' over 'Attach to a post' in the media list table. 
Props pavelevap.
Fixes #33515.


git-svn-id: https://develop.svn.wordpress.org/trunk@33810 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-30 03:09:25 +00:00
Sergey Biryukov a47ee912ac Make a period translatable. 
props mako09.
fixes #33594.

git-svn-id: https://develop.svn.wordpress.org/trunk@33802 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-29 01:39:51 +00:00
John Blackbourn a4808224ff Bring network admin user searching to parity with single site user searching by wrapping search terms in asterisks. This means that searches don't require an exact match and therefore significantly reduces friction when searching for users on the network admin screens. 
Fixes #32913


git-svn-id: https://develop.svn.wordpress.org/trunk@33801 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-29 00:18:06 +00:00
Sergey Biryukov d5dd61424d Network Admin: Hide the bulk actions checkbox for super admins. 
See [25125] for hiding the checkbox for the main site in Sites table.

props bordoni.
fixes #28529.

git-svn-id: https://develop.svn.wordpress.org/trunk@33777 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 03:48:47 +00:00
Helen Hou-Sandi 0c19c94561 Drop the hyphen from e-mail and standardize on email. 
The AP Stylebook changed this in 2011, and we're woefully inconsistent, so let's go with the standard.

props morganestes, voldemortensen, niallkennedy (for patching on the previous AP style).
fixes #26156.


git-svn-id: https://develop.svn.wordpress.org/trunk@33774 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 03:16:02 +00:00
John Blackbourn d89398f945 Don't change the View Post button permalink in the sample permalink HTML when updating the slug on a published or future post. 
Fixes #32954
Props boonebgorges, johnbillion


git-svn-id: https://develop.svn.wordpress.org/trunk@33773 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-27 20:56:54 +00:00
Sergey Biryukov 65c07b81c0 Remove `wp-includes/comment-functions.php` from the `$_old_files` array. See [33750]. 
props rachelbaker.
fixes #33569.

git-svn-id: https://develop.svn.wordpress.org/trunk@33772 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-27 20:39:58 +00:00
John Blackbourn 0d0a8353f5 Remove `error` from the query variables when cleaning up a URL in `wp_admin_canonical_url()`. 
Fixes #32847


git-svn-id: https://develop.svn.wordpress.org/trunk@33770 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-27 17:25:15 +00:00
John Blackbourn e95ce848f9 Correct the hook docs for the `user_profile_update_errors` action. 
Fixes #33537
Props yamchhetri


git-svn-id: https://develop.svn.wordpress.org/trunk@33769 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-27 17:15:54 +00:00
Sergey Biryukov 30eb4853f0 Prevent unintended password change after clicking "Generate Password" and then "Cancel" when editing a user profile. 
props peterwilsoncc.
fixes #33419 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@33766 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-27 00:10:39 +00:00
Sergey Biryukov a69c9ff66f Make post meta box toggles accessible. 
props joedolson.
fixes #33544.

git-svn-id: https://develop.svn.wordpress.org/trunk@33762 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 15:22:57 +00:00
Weston Ruter 9c4f261598 Customizer: Ensure persistence of unchanged `active` state for controls, sections, and panels. 
Props nikeo, westonruter.
Fixes #33428 for trunk.
See also #33494.


git-svn-id: https://develop.svn.wordpress.org/trunk@33754 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 07:25:20 +00:00
Weston Ruter e32f3cd3e1 Customizer: Prevent JS error during init when `nav_menus` panel is removed by plugin. 
Fixes #33411 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33753 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 06:42:16 +00:00
Sergey Biryukov 6598033243 Remove rounded corners from "Choose from the most used tags" result in Tags meta box. 
props tyxla.
fixes #31560.

git-svn-id: https://develop.svn.wordpress.org/trunk@33742 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 23:13:30 +00:00
Scott Taylor ff7fcf5f04 In `WP_Users_List_Table::single_row()`, `$actions` is not always set before being used. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33735 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 20:37:50 +00:00
Scott Taylor 3b8c5529cb `foreach` is a statement, not a function. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33734 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 20:27:56 +00:00
Scott Taylor 755d109d10 Instead of [33713], allow `WP_Posts_List_Table::get_bulk_actions()` to check `edit_posts` AND `delete_posts`. 
Props DeBAAT.
Fixes #29789.


git-svn-id: https://develop.svn.wordpress.org/trunk@33733 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 20:11:27 +00:00
Sergey Biryukov b59d10ccac Multisite: Add `'invite_user'` action that fires immediately after a user is invited to join a site, but before the notification is sent. 
props ebinnion, MikeHansenMe, DrewAPicture.
fixes #33008.

git-svn-id: https://develop.svn.wordpress.org/trunk@33732 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 17:47:26 +00:00
Drew Jaynes 40ce8c68fe Docs: The type for the `$t_time` parameter in the `post_date_column_time` filter docs should be `string`, not `array`. 
Props jjeaton
Fixes #33540.


git-svn-id: https://develop.svn.wordpress.org/trunk@33731 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 17:14:28 +00:00
Scott Taylor e1b1541932 Media: 
When inserting an image into a post, the values in `wp.media.controller.Library` should not default to linking the image when no user settings are present.

The default display setting value for `link` is now `none`. User settings persist and will override or confirm this value based on user actions.

Props liljimmi, janhenckens, eherman24, wonderboymusic.
Fixes #31467.


git-svn-id: https://develop.svn.wordpress.org/trunk@33729 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 12:12:59 +00:00
Dion Hulse 3b525395cc Term Splitting: Switch to a faster cron unschedule process to benefit sites with thousands of affected jobs. Fix the cron hook name in the failsafe rescheduler. 
Props Otto42, dd32, peterwilsoncc
See #33423


git-svn-id: https://develop.svn.wordpress.org/trunk@33727 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 04:31:52 +00:00
Scott Taylor 5f3879e37c With a few modifications in `wp-admin/menu.php`, we can eliminate the extra logic for Post and Page menu registration. Instead, they can just declare `menu_position` on post type registration. 
Props scribu, wonderboymusic.
Fixes #16865.


git-svn-id: https://develop.svn.wordpress.org/trunk@33723 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-24 21:18:20 +00:00
Scott Taylor 9596ae0993 Posts List Table: 
Don't show bulk actions if the user can't edit posts.

Props DrewAPicture.
Fixes #29789.


git-svn-id: https://develop.svn.wordpress.org/trunk@33713 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-23 16:27:44 +00:00
Scott Taylor e76b48a26c `update-core.php` help docs, update string to include translations: `themes, plugins, and translations` 
Props netweb, DrewAPicture.
Fixes #28201.


git-svn-id: https://develop.svn.wordpress.org/trunk@33704 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-22 16:24:58 +00:00
Scott Taylor e4f8047716 In `wp_ajax_add_meta()`, do not juggle the value of `$_POST` and alter it directly. This was done so that `edit_post()` could pull `$_POST` out of the air by-reference and alter it (equally as bad). `edit_post()` accepts a `$post_data` array. Do that instead. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33697 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 18:12:56 +00:00
Scott Taylor a1e5332489 Make 'Docs Committer' translatable. 
Props dimadin. 
Fixes #33424.


git-svn-id: https://develop.svn.wordpress.org/trunk@33695 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 17:46:54 +00:00
Scott Taylor ab71eb93b1 When createing "Sample Page" on install, comments should be `closed`. 
Props macmanx. 
Fixes #33490.


git-svn-id: https://develop.svn.wordpress.org/trunk@33693 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 17:41:16 +00:00
Scott Taylor 7dd261ce61 Comment List Tables: 
* Toggle visibility of pending bubble when a comment is dynamically moderated
* Add a CSS class to the pending bubble to hide it / remove to show it

See #11200.


git-svn-id: https://develop.svn.wordpress.org/trunk@33692 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 17:25:06 +00:00
Drew Jaynes e6466911d7 Docs: Add a changelog entry for the `$post_type` parameter added to the `restrict_manage_posts` hook in [33644]. 
Props pavelevap
Fixes #17891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33691 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 16:11:31 +00:00
Helen Hou-Sandi 961dd71cf3 List tables: Allow filtering of hidden and default hidden columns. 
Similar to `get_hidden_meta_boxes()`, there are now filters named `default_hidden_columns` and `hidden_columns`.

props Compute, MikeHansenMe, chriscct7.
fixes #32499.


git-svn-id: https://develop.svn.wordpress.org/trunk@33689 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 15:31:30 +00:00
Dion Hulse 466500743f WP_Filesystem: SSH2 handler: Remove support for is_writable() via SSH, it turns out PHP doesn't verify the writability via SFTP and instead uses a comparison based on the current php system process user instead of the ssh user. 
This fixes the 'The update cannot be installed because we will be unable to copy some files.' error encountered during updates by skipping the write test completely.

Props jobst.
Fixes #33480 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@33688 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 11:42:04 +00:00
Drew Jaynes e803952278 Docs: Fix some minor inline documentation syntax issues in the hook docs for the `post_edit_category_parent_dropdown_args` filter, introduced in [33682]. 
See #32246. See #33026.


git-svn-id: https://develop.svn.wordpress.org/trunk@33686 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 04:54:00 +00:00
Drew Jaynes a65c2e068a Docs: Fix a variety of inline documentation syntax issues and add some strategic spacing. 
Fixes #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@33685 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 04:12:45 +00:00
Drew Jaynes c53fe2779e Docs: Add missing `@access` tags to properties and methods in wp-admin/includes/class-wp-upgrader. 
See #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@33684 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 04:04:23 +00:00
Drew Jaynes 3721940e0f Docs: Correct a typo in the summary for the `Theme_Upgrader->bulk` property. 
Also adds a couple of missing `@access` tags.

Props kraftbj
See #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@33683 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 03:14:35 +00:00
Boone Gorges 57592ef976 Filter the arguments passed to `wp_dropdown_categories()` in the Categories post edit metabox. 
The new 'post_edit_category_parent_dropdown_args' provides parity with other
places in wp-admin where `wp_dropdown_categories()` args are filtered, such as
'taxonomy_parent_dropdown_args'.

Props theMikeD.
Fixes #33026.

git-svn-id: https://develop.svn.wordpress.org/trunk@33682 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 01:27:15 +00:00
Drew Jaynes b09cedbd11 Docs: Standardize `@deprecated` tag formatting for deprecated functions in wp-admin/includes/ms-deprecated.php. 
Props Alphawolf for the initial patch
Props DrewAPicture

See #28806.


git-svn-id: https://develop.svn.wordpress.org/trunk@33675 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 22:25:41 +00:00
Scott Taylor 3b1e7ba1e0 After [33666], fix broken `sprintf` cruff. 
See #17609.


git-svn-id: https://develop.svn.wordpress.org/trunk@33672 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 21:36:03 +00:00
Drew Jaynes 8edff9c979 Docs: Standardize `@deprecated` tag formatting and add missing DocBlocks to deprecated functions in wp-admin/includes/deprecated.php. 
Opted not to use the multi-function DocBlock syntax in the name of not taking shortcuts in documentation for the sake of brevity.

Props Alphawolf for the initial patch.
See #28806


git-svn-id: https://develop.svn.wordpress.org/trunk@33671 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 21:22:26 +00:00
Drew Jaynes 5e6f651daf Docs: Add a missing summary to the DocBlock for `wp_media_upload_handler()`. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33670 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 21:00:42 +00:00
Drew Jaynes 0af6d275b0 Docs: Clarify the different return conditions in the DocBlock for `WP_List_Table->handle_row_actions()`. 
This clarification follows the introduction of primary columns in 4.3. See #33313.

Props morganestes.
Fixes #33436.


git-svn-id: https://develop.svn.wordpress.org/trunk@33668 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 20:21:45 +00:00
Scott Taylor 695560bf58 In `WP_Posts_List_Table::inline_edit()`, check that `$post_formats[0]` is an array before traversing. 
Props DrewAPicture.
Fixes #33025.



git-svn-id: https://develop.svn.wordpress.org/trunk@33667 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 20:18:35 +00:00
Scott Taylor 98de66207f Custom Post Types: 
* Introduce `is_post_type_viewable( $post_type_object )`
* Separate the HTML bits from the translatable bits in the `post` messages array in `edit-form-advanced.php`
* Don't show certain UI pieces when a post is not viewable on the front end

When a custom post type item is not viewable on the front end, we don't want to show links to View it (on the front end) all over the admin. We also want to hide the Preview link, et al. We also want our admin messages to not contain said links.

Custom post types with `public_queryable` set to `false` are not viewable on the front end. 
`'page'` is viewable on the front end, but `'page'` is a `_builtin` type, and `public_queryable` is set to `false` when it is registered - see `WP::parse_request()` for when `public_queryable` gets used.

This is confusing, but also somewhat straightforward: to determine if a post type is viewable on the front end, we can check one way for `_builtin => true` and another way for `_builtin => false`:

`$post_type->publicly_queryable || ( $post_type->_builtin && $post_type->public )`

If a post type is `publicly_queryable`, it's viewable. If that value is `false`, it is viewable if it's a `_builtin` type that is also `public`.

I am in search of edge cases, so this shall land.

Props wonderboymusic, DrewAPicture.
See #17609.


git-svn-id: https://develop.svn.wordpress.org/trunk@33666 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 19:39:57 +00:00
Scott Taylor 25004acaa6 After [33662], remove unused var. 
See #11200.


git-svn-id: https://develop.svn.wordpress.org/trunk@33663 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 17:18:51 +00:00
Scott Taylor 28e0ad2de1 Comment List Tables: 
* Ensure that dynamic bubble counts are in sync by `comment_post_ID`
* Scope `:animated` to `#the-comment-list`

See #11200.



git-svn-id: https://develop.svn.wordpress.org/trunk@33662 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 16:35:21 +00:00
Scott Taylor 89ecad8808 JSHint after [33655]. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33660 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 06:30:48 +00:00
Scott Taylor 64944b7a87 Comments List Table: 
* In a view that initially has comments, but they get removed due to user actions: show the `No Items` row instead of bombing out and showing nothing (which looks broken)
* To accomplish this, in `WP_Comments_List_Table::display()`: call `->display_rows_or_placeholder()` instead of `->display()`
* Listen for the end of row `.fadeOut()`s if necessary using jQuery Promises

Fixes #11200.


git-svn-id: https://develop.svn.wordpress.org/trunk@33657 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 05:53:41 +00:00
Scott Taylor 88e804f6c0 Comments List Table: 
* Properly increment/decrement approved/pending bubbles in `response` column

See #11200.


git-svn-id: https://develop.svn.wordpress.org/trunk@33656 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 04:01:35 +00:00
Scott Taylor 9b6f5b6270 Comments List Table: 
* Show count next to "Approved"
* Properly increment/decrement counts when row actions are clicked
* In `_wp_ajax_delete_comment_response()`, return the comment's `status` with the `supplemental` data
* Handle counts properly on each scenario of `undo`

See #11200.


git-svn-id: https://develop.svn.wordpress.org/trunk@33655 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 02:50:20 +00:00
Konstantin Obenland 96437b6d57 Themes: Prevent short descriptions from wrapping version info. 
Props mehulkaklotar for initial patch.
Fixes #33248.



git-svn-id: https://develop.svn.wordpress.org/trunk@33651 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 19:09:20 +00:00
Konstantin Obenland 2ec26f617f Themes: Open preview when requesting a single theme in the installer. 
Props kraftner, obenland.
Fixes #28735.



git-svn-id: https://develop.svn.wordpress.org/trunk@33650 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 18:53:36 +00:00
Dion Hulse f0ec4d5a7b Upgrades: When upgrading via FTP, use `LIST -a` to detect if a file exists. 
`LIST` & `NLST` by default on some servers require the `-a` flag to view hidden files (ie. `.maintenance`)
Although we could simply pass the `-a` flag to `NLST`, opting to use `LIST` which we use elsewhere should mean less chance of server incompatibilities.

Props jcroucher.
Fixes #28013.


git-svn-id: https://develop.svn.wordpress.org/trunk@33648 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 12:37:56 +00:00
Dion Hulse 63fd3a32dd Term Splitting: Fix a reversal of parameters to wp_schedule_single_event() introduced in [33621]. 
The existing invalid cron entries will not be purged automatically (as the 'timestamp' is never matched) so we do this ourselves.

Props mechter for noticing!
See #30261.
Fixes #33423 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33646 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 11:30:42 +00:00
Dion Hulse 26e7094951 Fix PHP notice after [33492] when updating themes. 
Props bobbingwide.
See #33208.
Fixes #33427.


git-svn-id: https://develop.svn.wordpress.org/trunk@33645 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 10:34:51 +00:00
Scott Taylor 5cbc7a706d The `'restrict_manage_posts'` hook currently fires on the Post and Media list tables, but is passed zero arguments. Pass `$post_type`. 
Props sunnyratilal, scribu.
Fixes #17891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33644 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 06:22:40 +00:00
Scott Taylor f8d13a7c86 Replace some hyphens with `&mdash;`s in admin help tabs. 
Props pixolin.
Fixes #30605.


git-svn-id: https://develop.svn.wordpress.org/trunk@33641 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 04:52:17 +00:00
Scott Taylor 4c3f8dac54 Correct punctuation/case for inline comment in `async-upload.php` 
Props chriscct7.
Fixes #33408.


git-svn-id: https://develop.svn.wordpress.org/trunk@33640 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-18 23:34:49 +00:00
Scott Taylor 69338b3fa7 Correct typo in doc block for `WP_Filesystem_ftpsockets::rmdir` 
Props Toro_Unit.
Fixes #33255.


git-svn-id: https://develop.svn.wordpress.org/trunk@33639 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-18 23:33:00 +00:00
Scott Taylor 9b37cc043c Correct typo in JSDoc for `wp.updates.decrementCount` 
Props mt8.biz.
Fixes #33363.


git-svn-id: https://develop.svn.wordpress.org/trunk@33638 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-18 21:46:19 +00:00
Konstantin Obenland 6367a427f4 About: Use actual locale and not subtitle debug cruft. 
H/t dimadin.

See #32929.


git-svn-id: https://develop.svn.wordpress.org/trunk@33632 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-18 17:06:37 +00:00
Konstantin Obenland 03bc4e6299 About: Update release video to use the correct ID. 
Also adjusts locale handling to work with Videopress' subtitle implementation.

Props siobhan, jacklenox, sararosso, hugobaeta, nickmomrik, rauchg.
See #32929.



git-svn-id: https://develop.svn.wordpress.org/trunk@33631 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-18 17:01:50 +00:00
Dominik Schilling (ocean90) 0ec540b946 Pinking shears. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33627 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 21:38:24 +00:00
Dominik Schilling (ocean90) f545d74256 Upgrade: Update `$_old_files` for 4.3. 
fixes #33394.

git-svn-id: https://develop.svn.wordpress.org/trunk@33626 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 20:23:06 +00:00
Konstantin Obenland e7c16b2d0a Passwords: Use `keyup` event to prevent IE8's misinterpretation of `propertychange`. 
Props adamsilverstein, peterwilsoncc.
Fixes #33385.



git-svn-id: https://develop.svn.wordpress.org/trunk@33625 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 18:45:33 +00:00
Andrew Ozz b30fcd7597 Fix creating of extra `<br />` tags in both PHP and JS variants of wpautop(). Add PHP tests to catch similar problems in the future. 
Props valendesigns, azaozz. Fixes #33377.

git-svn-id: https://develop.svn.wordpress.org/trunk@33624 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 17:35:58 +00:00
Helen Hou-Sandi 3b1e1f0376 List tables: Yet more primary column fallbacks. 
Some custom list tables override enough methods for the column definition fallback to never kick in, so let's ensure that toggling columns only applies when a primary column is defined in some way. We also need to show a toggle button when we can when there are no row actions.

props Chouby, obenland, ocean90.
fixes #33313.


git-svn-id: https://develop.svn.wordpress.org/trunk@33623 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 15:37:03 +00:00
Boone Gorges e33ff607e6 Don't run term-splitting routine on new installations. 
Props pento.
Fixes #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@33621 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 14:28:03 +00:00
Konstantin Obenland e7a203cdf2 Passwords: Restore second parameter for `wp_new_user_notification()`. 
After [33023] users would always be notified, this restores previous behavior.

Props markjaquith, ocean90.
Fixes #33358.



git-svn-id: https://develop.svn.wordpress.org/trunk@33620 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 14:24:43 +00:00
Helen Hou-Sandi 7abf08a52c Menu customizer: Ensure the search results section is full height. 
fixes #33375.


git-svn-id: https://develop.svn.wordpress.org/trunk@33618 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-14 21:31:23 +00:00
Weston Ruter a4bbc4454c Customize: Fix keyboard accessibility for toggling screen options and contextual help. 
Also fix layout of search results in mobile.

Props valendesigns, afercia, adamsilverstein.
Fixes #33184.


git-svn-id: https://develop.svn.wordpress.org/trunk@33617 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-14 21:22:57 +00:00
Boone Gorges f18355e66e Term splitting routine should be run in a separate process, triggered via wp-cron. 
[32814] introduced a routine to split shared terms, which was run during the
regular WP database upgrade. This turned out to be problematic because plugins
are not loaded during the db upgrade (due to `WP_INSTALLING`), with the result
that plugins were not able to hook into the 'split_shared_term' action during
the bulk split. We work around this limitation by moving the term splitting
routine to a separate process, triggered by a wp-cron hook.

Props boonebgorges, Chouby, peterwilsoncc, pento, dd32.
Fixes #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@33615 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-14 03:58:41 +00:00
Dominik Schilling (ocean90) 23eaa36145 Capabilities: Fall back to the `edit_posts` capability for orphaned comments. 
Also avoid PHP notices because of orphaned comments in the comments list table.
Includes unit test.

props pento, dd32.
fixes #33154.

git-svn-id: https://develop.svn.wordpress.org/trunk@33614 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-13 22:30:26 +00:00
Konstantin Obenland ce531d8723 About: Third pass at 4.3 about page: 
* Improves some of the feature descriptions.
* Uses .org CDN for images and feature video.
* Fixes an overzealous Jetpack style that adds unwanted padding.
* Uses more specific `WP_List_Table` header.
* Adds 4.3 tagline to freedoms and credit page.
* Adds infrastructure for 4.3 about video. Only the ID needs to be updated.
* Makes all strings translatable.

Props siobhan, adamsilverstein, melchoyce, ocean90, markjaquith, helen, obenland.
Fixes #32929.



git-svn-id: https://develop.svn.wordpress.org/trunk@33613 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-13 22:10:06 +00:00
Boone Gorges ee67bd08f9 When splitting a shared 'nav_menu' term, ensure that nav items and theme locations are retained. 
Props boonebgorges, dd32.
Fixes #33187.

git-svn-id: https://develop.svn.wordpress.org/trunk@33611 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-12 14:06:21 +00:00
Weston Ruter 80bc70fc4b Customize: Fix layout issues in panels and sections when resizing and autofocusing. 
Also reverts [33157] which is no longer needed.

Props valendesigns, mattwiebe, westonruter, ocean90.
Fixes #33220.


git-svn-id: https://develop.svn.wordpress.org/trunk@33610 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-11 23:55:40 +00:00
Andrew Ozz e509984261 Fix paste typos in upgrade.php. 
Props tellyworth. Fixes #33206.

git-svn-id: https://develop.svn.wordpress.org/trunk@33609 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-11 23:43:29 +00:00
Konstantin Obenland 14b7ed65bb After [32948]: Account for the use of `paginate_links()` with table navigation markup. 
Props afercia.
Fixes #32253.



git-svn-id: https://develop.svn.wordpress.org/trunk@33608 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-11 20:42:18 +00:00
Konstantin Obenland a367a1b67b Customize: Limit styles for menu's reorder button to the `nav_menu` control. 
This prevents it from bleeding into other controls, misaligning their buttons.
Selectors use a class now too, which is preferable over ids.

Fixes #33260.



git-svn-id: https://develop.svn.wordpress.org/trunk@33604 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-10 19:35:57 +00:00
Helen Hou-Sandi 19f9dd3b72 Network admin: Internationalize some existing strings that were missed in [33186]. 
Also adds the trailing slash to the `get_home_url()` calls.

props johnbillion.
fixes #33317.


git-svn-id: https://develop.svn.wordpress.org/trunk@33603 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-10 18:10:11 +00:00
Helen Hou-Sandi 0999b0182b Customizer: Rename `WP_New_Menu_Customize_Control` to `WP_Customize_New_Menu_Control` for consistency. 
props DrewAPicture.
fixes #33324.


git-svn-id: https://develop.svn.wordpress.org/trunk@33602 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-10 18:06:01 +00:00
dd32 0c29101892 Function documentation: Fix a broken docbock introduced with [32642]. 
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@33601 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-10 10:49:02 +00:00
Dominik Schilling (ocean90) 3f7b1ca2ff Customizer: Remove obsolete `.control-panel-back` and `.customize-overlay-close` buttons. 
props afercia, ocean90.
see #31336.
fixes #33229.

git-svn-id: https://develop.svn.wordpress.org/trunk@33599 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-09 18:59:34 +00:00
Dominik Schilling (ocean90) 6741897dd0 List tables: Adjust width of Quick Edit labels for longer translations. 
props Clorith, SergeyBiryukov, ocean90.
fixes #33212.

git-svn-id: https://develop.svn.wordpress.org/trunk@33598 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-09 18:54:37 +00:00
Dion Hulse 7ef82c235a Upgrade: Skip the sitecategories table when it doesn't exist (Global Terms is disabled). 
Props nofearinc, obenland, SergeyBiryukov, and pento.
Fixes #33206


git-svn-id: https://develop.svn.wordpress.org/trunk@33597 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-09 02:21:11 +00:00
Dominik Schilling (ocean90) 2d6c10b842 Customizer: Restore Shift + Clicking on widgets to open the widgets panel. 
Includes an alternative for jQuery UI's `:focusable` selector because it has an ancestor visibility requirement, see https://github.com/jquery/jquery-ui/pull/1583.

props westonruter.
fixes #33258.

git-svn-id: https://develop.svn.wordpress.org/trunk@33596 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-08 09:36:55 +00:00
Konstantin Obenland c03388bd9d Install: Adjust `th` padding to align with `td`s. 
Props Ankit K Gupta for initial patch.
Fixes #33280.



git-svn-id: https://develop.svn.wordpress.org/trunk@33595 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-07 22:09:41 +00:00
John Blackbourn 1939742e32 Remove all existing internal feature pointers. 
Fixes #33289
Props obenland, ocean90, SergeyBiryukov


git-svn-id: https://develop.svn.wordpress.org/trunk@33593 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-07 00:58:10 +00:00
Mark Jaquith 3d15757198 Move media hooks out of `admin-filters.php` as sometimes editors are used on the front end. 
fixes #33257
props wonderboymusic

git-svn-id: https://develop.svn.wordpress.org/trunk@33590 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-06 20:39:35 +00:00
Dominik Schilling (ocean90) f29b25e104 Comments: Update help text for new comment bubbles. 
props kraftbj.
fixes #33256.

git-svn-id: https://develop.svn.wordpress.org/trunk@33589 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-06 08:02:53 +00:00
Jeremy Felt 1872e759ea Multisite: Use single URL input when editing sites in a subdirectory configuration 
In [32759], we adjusted `site-info.php` to display a single input for a site's full URL if the network was configured for subdomains. We also enforced path only editing for non-subdomain networks, which is a regression in expected behavior.

The full URL of a site can now be edited in both subdomain and subdirectory configurations.

Props @michaelryanmcneill.
Fixes #22383.


git-svn-id: https://develop.svn.wordpress.org/trunk@33586 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-05 03:33:53 +00:00
Dominik Schilling (ocean90) 9f3217c8eb Multisite mails: Initialize `$current_user` before accessing `$current_user->user_login`. 
props Toro_Unit.
see #31217.
fixes #33254.

git-svn-id: https://develop.svn.wordpress.org/trunk@33569 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-04 11:38:52 +00:00
Dominik Schilling (ocean90) ad74207fa7 Heartbeat: Ensure post locks are released. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33542 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-03 21:11:35 +00:00
Dominik Schilling (ocean90) d834719f34 Nav menus: Adjust redundant titles in accessibility helpers. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33540 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-03 21:03:59 +00:00
Dominik Schilling (ocean90) 2ebc63579c Fix PHP notice after [33492]. 
props jesin.
see #33178.
fixes #33208.

git-svn-id: https://develop.svn.wordpress.org/trunk@33519 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-30 19:58:43 +00:00
Helen Hou-Sandi 4f2573a707 Remove debug cruft from [33511]. 
see #32710.


git-svn-id: https://develop.svn.wordpress.org/trunk@33515 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 23:52:46 +00:00
Helen Hou-Sandi 3fd1376418 Menu customizer: More clearly separate search results from available items. 
Available items now fade from view while you're searching, and there is an explicit way to clear search results. No results gives a better message, though still brief this time around.

props valendesigns, designsimply, DH-Shredder, helen.
fixes #32710.


git-svn-id: https://develop.svn.wordpress.org/trunk@33511 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 23:39:54 +00:00
Konstantin Obenland 63395e7652 Customizer: Improve focus styles for screen option and help toggles. 
Props ocean90.
See #33181.



git-svn-id: https://develop.svn.wordpress.org/trunk@33510 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 23:24:17 +00:00
Dominik Schilling (ocean90) 0bff13a8fd Customizer: This circular focus thing is hot. 
see #33181.

git-svn-id: https://develop.svn.wordpress.org/trunk@33503 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 21:50:27 +00:00
Dominik Schilling (ocean90) 55b1dd3411 Nav menus: Make the selector for the edit menu item link more specific. Prevents clashing with other elements which have the same class. 
fixes #33129.

git-svn-id: https://develop.svn.wordpress.org/trunk@33502 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 21:29:54 +00:00
Weston Ruter 1e2fdf5bc8 Customizer: Stack the menu gear icon below the help icon for more text breathing room. 
Fixes #33181.


git-svn-id: https://develop.svn.wordpress.org/trunk@33500 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 20:22:18 +00:00
Konstantin Obenland fbfcb87b9d About: Second pass at 4.3 about page. 
Adds images and videos for major and minor features.
Restores a mangled placeholder in Formatting Shortcuts description.

Assets still need to be moved to the .org CDN once deemed final.

Props ryelle, melchoyce, helen.
See #32929.



git-svn-id: https://develop.svn.wordpress.org/trunk@33498 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 19:57:00 +00:00
Andrew Ozz f0935052c2 Press This: properly add Open Sans to the editor, using the `mce_css` filter. 
See #26072. Fixes #33189.

git-svn-id: https://develop.svn.wordpress.org/trunk@33497 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 19:37:06 +00:00
Weston Ruter 05c32013d7 Customizer: Update `nav_menu_locations[...]` controls to remove placeholder menus from the dropdown options upon Save & Publish. 
See #32814.
Fixes #33176.


git-svn-id: https://develop.svn.wordpress.org/trunk@33496 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 19:33:07 +00:00
Mark Jaquith 37aa0574c4 Persist (and mask) the password on the install screen if the install does not proceed due to errors. 
If you forget or enter an invalid username/e-mail, the password choosing shouldn't start over.

fixes #33162

git-svn-id: https://develop.svn.wordpress.org/trunk@33495 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 19:21:26 +00:00
Mark Jaquith 4149ad8845 Make the multisite new user messages reflect that reset links are sent, not passwords. 
fixes #33175

git-svn-id: https://develop.svn.wordpress.org/trunk@33494 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 19:03:09 +00:00
Dominik Schilling (ocean90) faac72a070 Themes: Remove legacy theme preview. 
The pre-3.4 theme previewer doesn't work when using a static front page.
We kept the old theme preview for no-JS and some browsers that were less capable. But since browsers are doing a better job today we don't need to continue fixing/shipping this legacy code. Bye!

fixes #33178.

git-svn-id: https://develop.svn.wordpress.org/trunk@33492 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 18:35:40 +00:00
Helen Hou-Sandi 00baf4adea Comments list table: Display that cute lil comment bubble. 
The comments list table suffers from "wall of text" problems, which the two plain text links compounded.

props obenland. fixes #33149.


git-svn-id: https://develop.svn.wordpress.org/trunk@33490 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 18:07:03 +00:00
Weston Ruter dbcb95c022 Customizer: Ensure that all existing menus are shown in the Custom Menu widget's dropdown. 
* Ensure that a Custom Menu widget selecting a newly-inserted menu gets updated to use the new menu ID upon Save & Publish.
* Dynamically update the visibility of the Custom Menu widget's "no menus" message when the number of menus changes between 0 and 1+.
* Send all dirty Customized settings in `update-widget` Ajax request and `preview()` them so that the widget update/form callbacks have access to any data dependencies in the current Customizer session (such as newly created unsaved menus).
* Update link in Custom Menu widget to point to Menus panel as opposed to Menus admin page, when in the Customizer.
* Fix an issue with extra space at top immediately after creating new menu.
* Fix doubled `update-widget` Ajax requests when changing select dropdown; prevent initial from being aborted.
* Add missing `wp_get_nav_menus()` hooks to preview Customizer updates/inserts for `nav_menu` settings; includes tests.
* Update `wp_get_nav_menu_object()` to allow a menu object to be passed in (and thus passed through).

Props westonruter, adamsilverstein.
Fixes #32814.


git-svn-id: https://develop.svn.wordpress.org/trunk@33488 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 16:02:08 +00:00
Dominik Schilling (ocean90) dec1b4da8b Upgrade: Lowercase the "s" in `remove_all_filters()`. 
props afragen.
fixes #33173.

git-svn-id: https://develop.svn.wordpress.org/trunk@33487 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 14:56:23 +00:00
Mark Jaquith e43b4db995 Make the "using default password" nag more accurate. 
"Easy to remember" isn't necessarily what we want to encourage.

fixes #33168
props arjunskumar

git-svn-id: https://develop.svn.wordpress.org/trunk@33485 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 14:05:59 +00:00
Dominik Schilling (ocean90) 8db3eeec7d Customizer: Add an `aria-expanded` attribute to Edit menu item toggles. 
props afercia.
fixes #33129.

git-svn-id: https://develop.svn.wordpress.org/trunk@33483 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 09:49:55 +00:00
Ella Iseulde Van Dorpe 71dc853888 Press This: correct link on the post screens 
Props rabmalin.
Fixes #33169.


git-svn-id: https://develop.svn.wordpress.org/trunk@33482 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 08:43:06 +00:00
Mark Jaquith 11f4909315 Do not re-generate the password after pressing "cancel". Persist the state. 
Also removes pass2 code not needed since we're generating from one field.

fixes #33164

git-svn-id: https://develop.svn.wordpress.org/trunk@33475 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 04:29:36 +00:00
Mark Jaquith fff891b1d9 Autogenerate passwords that more reliably fit within their inputs. 
fixes #33166

git-svn-id: https://develop.svn.wordpress.org/trunk@33474 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 03:55:56 +00:00
Mark Jaquith c13b00709b Re-work user-profile.js so the password meter works in IE8 and password managers can fill multiple times. 
props adamsilverstein
fixes #32886

git-svn-id: https://develop.svn.wordpress.org/trunk@33473 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 03:26:20 +00:00
Mark Jaquith 220ea93449 Omit the "(required)" text for password on the install screen. 
fixes #33163

git-svn-id: https://develop.svn.wordpress.org/trunk@33471 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 01:19:45 +00:00
Andrew Ozz 1558be9dfa Fix updating of nonces on the Edit Post screen after the log in expires and the user logs in again. 
Props iseulde, azaozz. Fixes #33098.

git-svn-id: https://develop.svn.wordpress.org/trunk@33468 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 22:06:52 +00:00
Konstantin Obenland 649d02a16b About: Remove translation functions until strings are final. 
See #32929.


git-svn-id: https://develop.svn.wordpress.org/trunk@33467 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 21:38:32 +00:00
Konstantin Obenland d3dd832933 About: First pass at WordPress 4.3 About page. 
Still missing images and some string revisions.

See #32929.



git-svn-id: https://develop.svn.wordpress.org/trunk@33466 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 21:22:23 +00:00
Mark Jaquith 90e39719d8 Lose the clunky `setTimeout()` code and just track the password value changes. 
see #32886

git-svn-id: https://develop.svn.wordpress.org/trunk@33465 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 21:10:16 +00:00
Sergey Biryukov 962cc345ae Plugins list table: Make selector for Details links more specific to prevent the Description header from being announced as "clickable". 
props afercia.
fixes #32968.

git-svn-id: https://develop.svn.wordpress.org/trunk@33462 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 14:49:41 +00:00
Sergey Biryukov 6c6dc814a3 Replace empty table header with a table cell. 
props afercia.
fixes #33047.

git-svn-id: https://develop.svn.wordpress.org/trunk@33456 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 10:18:47 +00:00
Weston Ruter b53cbb1279 Customizer: Hide empty space in footer on small screens since it is only populated on larger screens. 
Props obenland.
Fixes #33138.


git-svn-id: https://develop.svn.wordpress.org/trunk@33454 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 03:42:36 +00:00
Ella Iseulde Van Dorpe 4c7dfd38f7 Remove broken/dead colour scheme code 
See #32152.


git-svn-id: https://develop.svn.wordpress.org/trunk@33453 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 23:49:07 +00:00
Scott Taylor 68ff8b1a80 Passwords UI: clean up the new JS in `wp-admin/js/user-profile.js`. 
Instead of wrapping `#pass1` in a `<span>` dynamically, add the `<span>` to the HTML in PHP. It currently has no styling.

Fixes #33145.


git-svn-id: https://develop.svn.wordpress.org/trunk@33450 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 21:24:36 +00:00
Mark Jaquith 3f2b0779f5 Don't blindly trust the output of `glob()` to be an array. 
props kitchin
fixes #33093

git-svn-id: https://develop.svn.wordpress.org/trunk@33447 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 18:04:19 +00:00
Konstantin Obenland cd4811bf66 Site Icon: Minor cleanup for `WP_Site_Icon` after [33329]. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33446 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 16:08:47 +00:00
Konstantin Obenland 6bca6cb0b2 Customizer: Use correct spelling when instantiating `CustomizeImageCropper`. 
Introduced in [33329].


git-svn-id: https://develop.svn.wordpress.org/trunk@33445 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 15:54:51 +00:00
Konstantin Obenland 8f588b345b Menus: Readjust screen options toggle icon. 
Third revision. This will let the icon appear slightly bigger than the help
icon on Macs and just slightly smaller on Windows machines. It's a compromise
in every way.

Fixes #32733. Again.



git-svn-id: https://develop.svn.wordpress.org/trunk@33444 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 15:42:44 +00:00
Sergey Biryukov c8f1bf5a94 Merge two similar strings about insufficient permissions. 
props pavelevap.
fixes #33140.

git-svn-id: https://develop.svn.wordpress.org/trunk@33442 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 13:24:39 +00:00
Sergey Biryukov faecac7803 Move the translator note added in [33437] directly before the string it applies to. 
fixes #33091.

git-svn-id: https://develop.svn.wordpress.org/trunk@33441 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 12:42:14 +00:00
Ella Iseulde Van Dorpe aed9a8c5bc Editor: word count: better names for types. 
Also fix it in wp_trim_words().

Fixes #30966.


git-svn-id: https://develop.svn.wordpress.org/trunk@33440 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 11:18:55 +00:00
Mark Jaquith 70dd339fa3 Fix the padding for the feature filter box on the Add Themes screen. 
fixes #33132
props SergeyBiryukov

git-svn-id: https://develop.svn.wordpress.org/trunk@33439 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 03:33:24 +00:00
Mark Jaquith 80c9c8cfca Toggle between dashicons-hidden and dashicons-visibility in the password hide/show button. 
fixes #33135

git-svn-id: https://develop.svn.wordpress.org/trunk@33438 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 03:12:55 +00:00
Mark Jaquith 3ad35be856 Add a translator note for the fix in r33387 
props SergeyBiryukov
fixes 33091

git-svn-id: https://develop.svn.wordpress.org/trunk@33437 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 01:53:04 +00:00
Sergey Biryukov 0fe4782373 Comment string tweaks: 
* Merge two strings about an invalid comment ID.
* Add missing context to 'Mark as Spam' string.
* Merge two 'In Response To' strings, replace redundant context with a translator comment.

props pavelevap.
fixes #32334.

git-svn-id: https://develop.svn.wordpress.org/trunk@33436 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 23:35:47 +00:00
Sergey Biryukov 71b9b522e2 Merge some similar media-related strings. 
props pavelevap.
fixes #32390.

git-svn-id: https://develop.svn.wordpress.org/trunk@33435 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 23:23:48 +00:00
Sergey Biryukov be54cc64a9 Multisite: Introduce a singular string for user removal (we already have one for deletion). 
props pavelevap.
fixes #32387.

git-svn-id: https://develop.svn.wordpress.org/trunk@33434 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 23:18:19 +00:00
Sergey Biryukov 8e7c0148dc Merge two duplicate strings. 
props pavelevap.
fixes #31730.

git-svn-id: https://develop.svn.wordpress.org/trunk@33433 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 23:03:52 +00:00
Sergey Biryukov b8a5123dc9 Merge similar strings for plugin update permissions. 
props pavelevap.
fixes #32388.

git-svn-id: https://develop.svn.wordpress.org/trunk@33432 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 23:00:11 +00:00
Sergey Biryukov 5a23543cc8 Merge duplicate strings related to Trash. 
props pavelevap.
fixes #33133.

git-svn-id: https://develop.svn.wordpress.org/trunk@33431 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 22:47:05 +00:00
Sergey Biryukov 67f74ea9c1 Comment status box: Move focus back to Edit link when changing the date. 
props afercia.
fixes #33062.

git-svn-id: https://develop.svn.wordpress.org/trunk@33422 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 02:25:43 +00:00
Sergey Biryukov a3f2503ddc Update help text after [33368]. 
fixes #33082.

git-svn-id: https://develop.svn.wordpress.org/trunk@33420 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 01:51:18 +00:00
Sergey Biryukov 7214dc6fb4 Remove unused `pw-weak` ID attributes. 
see #33077.

git-svn-id: https://develop.svn.wordpress.org/trunk@33419 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 00:57:21 +00:00
Dominik Schilling (ocean90) cac1d55621 Customizer: Add missing text or labels to some nav menu UI controls. 
props afercia, celloexpressions, westonruter.
fixes #32715.

git-svn-id: https://develop.svn.wordpress.org/trunk@33413 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-24 20:27:04 +00:00
Dominik Schilling (ocean90) c412fd0398 Customizer: Hide inactive reorder buttons for menu items from assistive technologies. 
props afercia.
fixes #33114.

git-svn-id: https://develop.svn.wordpress.org/trunk@33412 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-24 17:56:50 +00:00
Konstantin Obenland 2971d7d3ed Menus: Account for browsers that set a default margin for buttons. 
Fixes #32733.



git-svn-id: https://develop.svn.wordpress.org/trunk@33410 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-24 17:23:05 +00:00
Konstantin Obenland a652f54b0f Comments: Normalize button color on hover in alt color schemes. 
Props iseulde.
Fixes #33086.



git-svn-id: https://develop.svn.wordpress.org/trunk@33409 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-24 17:10:11 +00:00
Konstantin Obenland 3b128efe27 Comments: Align author form label with its field labels below. 
Props liljimmi.
Fixes #33069.



git-svn-id: https://develop.svn.wordpress.org/trunk@33408 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-24 16:50:34 +00:00
Weston Ruter 3ceb11bea4 Customizer: Update JS variable to reference renamed data attribute for available nav menu object. 
Fixes regression for a change that was missed in [33366].

Props valendesigns.
Fixes #32708.


git-svn-id: https://develop.svn.wordpress.org/trunk@33392 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-23 06:01:30 +00:00
Dion Hulse f9ec35ddab Switch to a more performant query in meta_form(). 
Props lumaraf, swissspidy, rarylson, pento
Fixes #24498


git-svn-id: https://develop.svn.wordpress.org/trunk@33390 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-23 05:16:04 +00:00
Mark Jaquith e42e418450 Prevent 1Password from thinking the text "log in" should trigger a password save prompt 
fixes #33091

git-svn-id: https://develop.svn.wordpress.org/trunk@33387 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-23 05:04:55 +00:00
Mark Jaquith b77d19aa8b Do not propagate empty passwords from the hidden form field. 
fixes #32886

git-svn-id: https://develop.svn.wordpress.org/trunk@33384 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-23 04:59:04 +00:00
Mark Jaquith bc7ad4b965 Improve the "sessions" section strings. 
fixes #33082
props johnjamesjacoby

git-svn-id: https://develop.svn.wordpress.org/trunk@33368 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-22 20:49:55 +00:00
Mark Jaquith 1a8b292ab6 Move password and session items into "Account Management" profile section. 
fixes #33080
props johnjamesjacoby

git-svn-id: https://develop.svn.wordpress.org/trunk@33367 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-22 20:44:30 +00:00
Weston Ruter 9e383a560a Customizer: Introduce `customize_nav_menu_available_item_types` and `customize_nav_menu_available_items` filters. 
Allows for new available menu item types/objects to be registered in addition to filtering the available items that are returned for each menu item type/object.

Props valendesigns, imath, westonruter.
See #32832.
Fixes #32708.


git-svn-id: https://develop.svn.wordpress.org/trunk@33366 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-22 20:28:03 +00:00
Mark Jaquith 2d85378c52 Soothe JSHint's rankled spirits 
git-svn-id: https://develop.svn.wordpress.org/trunk@33365 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-22 18:55:27 +00:00
Mark Jaquith 9ca3978a3e Introduce a Cancel button and onUnload warning for password changes. 
fixes #33079
props johnjamesjacoby

git-svn-id: https://develop.svn.wordpress.org/trunk@33364 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-22 18:35:51 +00:00
Mark Jaquith fece657158 Fix up and normalize pw_weak/pw-weak IDs and labels. 
props johnjamesjacoby
fixes #33077

git-svn-id: https://develop.svn.wordpress.org/trunk@33363 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-22 17:23:27 +00:00
Mark Jaquith d1a1e77e40 Make password field toggling work in IE8, and clean up a bunch of password CSS issues. 
fixes #32886
props peterwilsoncc, adamsilverstein

git-svn-id: https://develop.svn.wordpress.org/trunk@33362 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-22 16:55:17 +00:00
Gary Pendergast 7439dd7354 Capabilities: When creating an auto-draft, ensure that the current user still has permission to do so. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33357 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-22 04:01:53 +00:00
Konstantin Obenland 2533d76203 Site Icon: Create custom sizes for images that don't need cropping. 
This will duplicate an image that doesn't need cropping once and will skip
creating new images and custom sizes if the selected image has the `site-icon`
context.

Fixes #33011.


git-svn-id: https://develop.svn.wordpress.org/trunk@33356 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-22 02:29:57 +00:00
Jeremy Felt 7845150324 Nav Menus: Add a Menus title with Manage in Customizer button to nav-menus.php 
This aligns the `<h1>` on `wp-admin/nav-menus.php` with that of other admin screens and aligns the "Manage in Customizer" button with that on `wp-admin/widgets.php`.

Fixes #32808.


git-svn-id: https://develop.svn.wordpress.org/trunk@33355 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-22 01:25:13 +00:00