Commit Graph

29476 Commits

Author SHA1 Message Date
Dominik Schilling (ocean90)
9be177ec95 Customize Widgets: Improve sync logic for select[multiple] inputs.
The current logic doesn't account for the special case of `select[multiple]` inputs which lack a single value to synchronize: The value to synchronize is an array of zero or more values.
This change replaces `_getInputStatePropertyName()` with `_getInputState()`, which returns the state for an input depending on its type, and `_setInputState()`, which updates an input's state based on its type.

props westonruter.
fixes #31885.

git-svn-id: https://develop.svn.wordpress.org/trunk@32012 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 16:33:24 +00:00
Drew Jaynes
58ee5beced Fix filter doc vernacular for the quick_edit_show_taxonomy filter.
See [31308]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32011 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 16:07:48 +00:00
Drew Jaynes
d0d60543ae Fix syntax for the $to_display parameter description in the DocBlock for WP_Posts_List_Table->_page_rows().
See [31730]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32010 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 16:03:20 +00:00
Drew Jaynes
472b335948 Add a return description to the DocBlock for WP_Posts_List_Table->is_base_request().
See [31828]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32009 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 16:00:08 +00:00
Dominik Schilling (ocean90)
d5c14c102b Customizer: Fix spinners after [31996].
props westonruter.
fixes #31884.

git-svn-id: https://develop.svn.wordpress.org/trunk@32008 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 15:41:45 +00:00
Drew Jaynes
f937bdc6ce Fix typos in the function summaries for wp_ajax_press_this_save_post() and wp_ajax_press_this_add_category().
See [31534]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32007 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 14:37:16 +00:00
Drew Jaynes
5394bd31a0 Add an @see mention for Plugin_Upgrader, plus spacing to the wp_ajax_update_plugin() delcaration.
See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32006 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 14:18:52 +00:00
Drew Jaynes
3e5eeaf6f0 Add a more descriptive function summary for options_discussion_add_js().
See [31095]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32005 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 14:15:49 +00:00
Dominik Schilling (ocean90)
b152b46c0e Customizer Theme Switcher: Remove "Add New" reference from customize-controls.js.
see #31837.

git-svn-id: https://develop.svn.wordpress.org/trunk@32004 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 14:13:14 +00:00
Drew Jaynes
f76ed758b8 Fix Docblock syntax for the taxonomy_parent_dropdown_args filter.
See [30998]. See #31888


git-svn-id: https://develop.svn.wordpress.org/trunk@32003 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 14:12:04 +00:00
Boone Gorges
ddb33c9aed After [31114] and [31323], 'View Post' generated in get_sample_permalink_html() should go to pretty permalink.
`get_permalink()` will return a non-pretty permalink for future posts, which
breaks some user workflows that expect View Post to lead to a page with the
pretty permalink.

Fixes #30910.

git-svn-id: https://develop.svn.wordpress.org/trunk@32002 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 01:26:08 +00:00
Boone Gorges
468da41811 WP_User_Query: When querying users with 'fields=all', ensure that caps and roles are filled for the current site.
See [15566] for a parallel fix for 'fields=all_with_meta'.

Fixes #31878.

git-svn-id: https://develop.svn.wordpress.org/trunk@32001 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 14:13:19 +00:00
Boone Gorges
86f074ffde Unit tests verifying the filling of the 'roles' and 'caps' user properties during WP_User_Query.
See #31878.

git-svn-id: https://develop.svn.wordpress.org/trunk@32000 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 14:13:11 +00:00
Sergey Biryukov
667899569f Remove hidden user_id input from wp_comment_reply().
Since [31172], it caused the comment's `user_id` field to be unexpectedly changed to the user who edits the comment.

See [31776] for Edit Comment screen.

props dllh.
fixes #30307.

git-svn-id: https://develop.svn.wordpress.org/trunk@31999 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 13:27:32 +00:00
Drew Jaynes
3e0278aa94 Post-beta4 bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@31998 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 13:00:53 +00:00
Drew Jaynes
123b684b84 WordPress 4.2-beta4
git-svn-id: https://develop.svn.wordpress.org/trunk@31997 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 12:51:02 +00:00
Helen Hou-Sandi
6983294161 Spinners: Toggle a class instead of show/hide.
Toggling spinners also now uses visibility instead of display, so that the space is always reserved and nothing moves around unexpectedly.

props cdog, MikeHansenMe, valendesigns.
fixes #22839. see #31875, #30725.


git-svn-id: https://develop.svn.wordpress.org/trunk@31996 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 04:51:18 +00:00
Andrew Ozz
ca908b2056 Themes screen: remove extra debounce when searching.
Props evansolomon. Fixes #31812.

git-svn-id: https://develop.svn.wordpress.org/trunk@31995 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 02:36:36 +00:00
Andrew Ozz
c3d7fa68ce Accessibility improvements for Themes screen: fix keyboard events and callbacks for the Search field, increase trigger timeout a bit, improve Esc. key handling.
Props joedolson, adamsilverstein, afercia, DrewAPicture. Fixes #26600.

git-svn-id: https://develop.svn.wordpress.org/trunk@31994 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 02:31:11 +00:00
Andrew Ozz
04fbf4cd60 Accessibility improvements for Options general screen: add missing labels and aria attributes.
Props DrewAPicture, afercia. Fixes #31144.

git-svn-id: https://develop.svn.wordpress.org/trunk@31993 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 01:54:47 +00:00
Andrew Ozz
eacf52a68a Press This:
- Show a spinner while saving a post.
- Do not redirect after saving a draft.
- Make the unidentified error message clearer.
Fixes #31875.

git-svn-id: https://develop.svn.wordpress.org/trunk@31992 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 01:33:30 +00:00
John Blackbourn
a0bd96bafb Introduce a string representing bulk plugin update success, ready for string freeze. Not used yet.
See #31770.


git-svn-id: https://develop.svn.wordpress.org/trunk@31991 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 00:17:20 +00:00
Dion Hulse
248c73b1cf Plugins Browser: Replace the download count with the number of Active installs of the plugin.
Fixes #31865


git-svn-id: https://develop.svn.wordpress.org/trunk@31990 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 23:48:26 +00:00
Aaron Jorbin
bd13a5ec12 Add beforeunload string for shiny updates.
See #31769.
Props johnbillion, adamsilverstein, jorbin. 



git-svn-id: https://develop.svn.wordpress.org/trunk@31989 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 22:35:48 +00:00
Drew Jaynes
3bf1329f40 Beta3 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@31988 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 21:42:49 +00:00
Andrew Ozz
4527b2cbb4 Press This: prevent pasting of HTML in the title H2. Insert the clipboard text instead.
Fixes #31768.

git-svn-id: https://develop.svn.wordpress.org/trunk@31987 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 21:10:28 +00:00
Sergey Biryukov
08e6f5306e Remove unnecessary echo(), add translator comment.
props ramiy.
fixes #31873.

git-svn-id: https://develop.svn.wordpress.org/trunk@31986 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 19:00:08 +00:00
Dominik Schilling (ocean90)
2563a4f802 Customizer: Update selector, missed in [31984].
see #28784.

git-svn-id: https://develop.svn.wordpress.org/trunk@31985 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 17:17:19 +00:00
Dominik Schilling (ocean90)
340cb573ae Customizer: Improve the overlay close button for iOS.
see #28784.

git-svn-id: https://develop.svn.wordpress.org/trunk@31984 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 17:15:08 +00:00
John Blackbourn
d92cc07d91 Correctly set the post author in wp_xmlrpc_server::mw_editPost() when the current user is not the author of the post.
Props redsweater, markoheijnen, DrewAPicture
Fixes #24916


git-svn-id: https://develop.svn.wordpress.org/trunk@31983 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 15:48:41 +00:00
Aaron Jorbin
dc502287ef Update aria-label when doing a shiny plugin update
Also updates it again when the shiny plugin update is finished.
Also updates it if the shiny update fails

props mehulkaklotar, afercia
Fixes #31722




git-svn-id: https://develop.svn.wordpress.org/trunk@31982 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 05:30:13 +00:00
Jeremy Felt
111203b0f6 Check for an active blog before generating the my-sites.php URL.
If a super admin does not have an active blog assigned to their account, `$wp_admin_bar->user->active_blog` will be set as `null`. We can then fall back to `admin_url()` to generate the My Sites URL.

Props SergeyBiryukov, deconf.

Fixes #31755.


git-svn-id: https://develop.svn.wordpress.org/trunk@31981 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 05:26:22 +00:00
Sergey Biryukov
b8b33293e1 Press This: Use more accurate wording on Tools screen.
props kraftbj.
see #31836.

git-svn-id: https://develop.svn.wordpress.org/trunk@31980 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 01:29:41 +00:00
Sergey Biryukov
4738590d5e Avoid duplicate classes for different terms with UTF-8 slugs in post_class() and body_class().
Fall back to term ID if the sanitized slug is numeric or only contains hyphens.

props SergeyBiryukov, A5hleyRich, sgrant, davideugenepratt.
fixes #30883.

git-svn-id: https://develop.svn.wordpress.org/trunk@31979 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 01:04:22 +00:00
Gary Pendergast
b9537f9488 Unit Tests added in [31970] need to be restricted to run in Multisite only.
See #17904, #26784.



git-svn-id: https://develop.svn.wordpress.org/trunk@31978 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 00:12:07 +00:00
Gary Pendergast
01cbacb308 Emoji: [31938] forgot a / in the emoji CDN URL.
See #31651.



git-svn-id: https://develop.svn.wordpress.org/trunk@31977 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 00:10:36 +00:00
Dominik Schilling (ocean90)
f6e4d76e5b Customizer Theme Switcher: Update JavaScript template after [31975].
see #31289.

git-svn-id: https://develop.svn.wordpress.org/trunk@31976 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 23:05:41 +00:00
Dominik Schilling (ocean90)
a05bbf7e7b Customizer Theme Switcher: Navigation streamlining.
* Detach Themes section from other controls
* Move to buttons to navigate back and forth
* Change titles based on current theme status, active/previewing
* Hide the active/previewing theme from the list of available themes

props folletto for the design concepts.
props designsimply, celloexpressions for initial patches.
props Team Gandalf.
see #31289.

git-svn-id: https://develop.svn.wordpress.org/trunk@31975 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 22:50:10 +00:00
Dominik Schilling (ocean90)
d6a590e087 Customizer: Make the available widgets overlay closable on narrow screens.
see #28784.

git-svn-id: https://develop.svn.wordpress.org/trunk@31974 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 22:24:21 +00:00
Helen Hou-Sandi
35df5592f1 Admin notices: Make (most) core notices dismissible.
These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.

props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233. see #23367.


git-svn-id: https://develop.svn.wordpress.org/trunk@31973 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 22:05:17 +00:00
Andrew Ozz
e5d660e597 TinyMCE: always focus the editor after using the floated toolbar.
Props iseulde. Fixes #30619.

git-svn-id: https://develop.svn.wordpress.org/trunk@31972 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 21:49:03 +00:00
Lance Willett
00fb680b7d Twenty Eleven: add postMessage support for header_textcolor to improve the user experience in the Customizer.
Fixes #24128, props kovshenin, jcastaneda, and lancewillett. 

git-svn-id: https://develop.svn.wordpress.org/trunk@31971 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 21:41:36 +00:00
Boone Gorges
4201382267 Unit tests for wpmu_validate_user_signup().
See #17904, #26784.

git-svn-id: https://develop.svn.wordpress.org/trunk@31970 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 21:37:34 +00:00
Aaron Jorbin
5b676b4f8e Fix colors for activated and updated plugins
If we don't have the updated class on the TR for he update message, then the message is red and red is scary and they just updated, they should be happy and celebrating, not scared. 

See #31608




git-svn-id: https://develop.svn.wordpress.org/trunk@31969 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 21:30:50 +00:00
Dominik Schilling (ocean90)
365ed7a6cb Customizer Theme Switcher: Remove "Add New" references.
The current iteration takes you out of the customizer context, which isn't great UX and doesn't really fit into the flows targeted by this particular UI.

fixes #31837.

git-svn-id: https://develop.svn.wordpress.org/trunk@31968 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 19:49:41 +00:00
Boone Gorges
a143f7f03b Avoid the use of array_replace() in add_query_arg().
`array_replace()` was introduced PHP 5.3+. Instead, we walk the array manually.

See [31966].

Fixes #31306.

git-svn-id: https://develop.svn.wordpress.org/trunk@31967 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 19:39:24 +00:00
Scott Taylor
d1235e323e Respect numerical keys in add_query_arg(), use array_replace() instead of array_merge().
Adds unit test.

Props tyxla.
Fixes #31306.


git-svn-id: https://develop.svn.wordpress.org/trunk@31966 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 19:14:46 +00:00
Scott Taylor
bcf98c7742 Alter the regex in wptexturize() to properly handle input like: <> "Hello world" <>.
Updates unit test data.

Props miqrogroove.
Fixes #30344.


git-svn-id: https://develop.svn.wordpress.org/trunk@31965 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 19:08:31 +00:00
Sergey Biryukov
e4a9e49b6d When shifting WP_Rewrite::flush_rules() to a later action if it was called too early, make sure to do a hard flush if requested.
props Denis-de-Bernardy, mordauk for initial patch.
fixes #30501.

git-svn-id: https://develop.svn.wordpress.org/trunk@31964 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 19:05:21 +00:00
Scott Taylor
2418711c47 When updating the email address for an existing user, make sure the email address is not already in use.
Adds unit tests.

Props rittesh.patel, DrewAPicture.
Fixes #30647.


git-svn-id: https://develop.svn.wordpress.org/trunk@31963 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 18:22:16 +00:00