Commit Graph

30217 Commits

Author SHA1 Message Date
Scott Taylor 9f5df5d045 Admin menu: improve accessibility when collapsed.
Props afercia.
Fixes #32346.


git-svn-id: https://develop.svn.wordpress.org/trunk@32946 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 19:32:36 +00:00
Scott Taylor 53bc964fc1 After [32796], improve the accessibility and markup for instances of `touch_time()`.
Props rianrietveld, afercia.
Fixes #31714.


git-svn-id: https://develop.svn.wordpress.org/trunk@32945 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 19:30:00 +00:00
Andrew Ozz ae029a133e Press This: better screen reader text for the arrow part of the split button.
Props afercia. See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32944 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 19:23:54 +00:00
Scott Taylor 4d28f9a7de In `get_site_option()` and `get_option()`, ensure that `$notoptions` is an array before writing to it. Prevents a flood of `Cannot use a scalar value as an array`, because `$notoptions` is otherwise set to the result of `wp_cache_get()`, which returns `mixed`.
Props hauvong.
Fixes #31147.


git-svn-id: https://develop.svn.wordpress.org/trunk@32943 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 19:00:51 +00:00
Scott Taylor 6690882fc1 `wpmu_validate_user_signup()` should strictly check against `false` when using `strpos()`.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32942 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 16:56:01 +00:00
Scott Taylor cd188f40d1 `WP_Rewrite::add_rule()` should strictly check against `false` when using `strpos()`.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32941 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 16:55:35 +00:00
Scott Taylor 9cef023a96 `prep_atom_text_construct()` and `before_last_bar()` should strictly check against `false` when using `str(r)?pos()`.
Sidenote: there's a function named `before_last_bar`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32940 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 16:48:14 +00:00
Scott Taylor f335ef9a66 Remove unused code from `WP_Press_This::html()`.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32939 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 16:37:56 +00:00
Scott Taylor 1bae0bb006 Remove unused code from `WP_MS_Sites_List_Table::display_rows()`.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32938 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 16:35:51 +00:00
Andrew Ozz 017d27a2c1 TinyMCE, inline link toolbar:
- Add max-width for all floating toolbars.
- Ensure the inline link toolbar doesn't exceed the width on small screen devices.
- Do not cut/concatenate the URL when it is less than 40 characters long.
- Show more of the URL if the beginning part plus the ending part are less than 40 characters long.
See #32604.

git-svn-id: https://develop.svn.wordpress.org/trunk@32937 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 04:41:34 +00:00
Andrew Ozz 6d6a1980b2 Press This: support passing `i` parameter to add an image src.
Props stephdau, azaozz. Fixes #32173.

git-svn-id: https://develop.svn.wordpress.org/trunk@32936 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 03:05:47 +00:00
Andrew Ozz dc56b51c47 Define `SCRIPT_DEBUG` early on every load, similarly to `WP_DEBUG`. Remove `defined( 'SCRIPT_DEBUG' )` checks.
Fixes #32333.

git-svn-id: https://develop.svn.wordpress.org/trunk@32935 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 02:28:50 +00:00
Andrew Ozz e06cc095b4 Press This, split button: wrap the sub-buttons in an unordered list to aid accessibility.
Props afercia. See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32934 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 01:54:36 +00:00
John Blackbourn dd419b74cc Introduce a `no_terms` label for taxonomies. This label is used when indicating that there are no terms in the given taxonomy associated with an object.
Fixes #32150
Props afercia


git-svn-id: https://develop.svn.wordpress.org/trunk@32933 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 00:15:46 +00:00
Ella Iseulde Van Dorpe 7fc64e8adb wplink: update TinyMCE UI after updating the link
See #32604.


git-svn-id: https://develop.svn.wordpress.org/trunk@32932 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 23:22:44 +00:00
Ella Iseulde Van Dorpe ed5625f831 TinyMCE: wplink: add inline toolbar
Now the URL can be viewed as soon as you put the cursor in an anchor tag. Clicking on it will open the page in a new tab. You also have the edit and remove button close at hand.

First run.
See #32604.


git-svn-id: https://develop.svn.wordpress.org/trunk@32931 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 23:04:46 +00:00
Scott Taylor ac63fb4dc3 YouTube oEmbed parsing: support the `m` subdomain.
Adds unit tests.

Props Toru, johnbillion.
Fixes #32714.


git-svn-id: https://develop.svn.wordpress.org/trunk@32930 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 21:05:59 +00:00
Scott Taylor 2ddca22b66 Remove the `whois.arin.net` link from `wp_notify_postauthor()` and `wp_notify_moderator()`.
Also, remove from `edit-form-comment.php` and add a new filter: `edit_comment_misc_actions`. 

Props ozh, joedolson, rachelbaker.
Fixes #15281.


git-svn-id: https://develop.svn.wordpress.org/trunk@32929 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 20:55:05 +00:00
Sergey Biryukov 8d756c76c1 Add `editor_stylesheets` filter to `get_editor_stylesheets()`.
props danielbachhuber, MikeHansenMe.
fixes #31672.

git-svn-id: https://develop.svn.wordpress.org/trunk@32928 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 13:31:11 +00:00
Drew Jaynes 64da56c543 Fix a typo in the DocBlock for `get_plugins()`.
Props onnimonni, swissspidy.
Fixes #32758.


git-svn-id: https://develop.svn.wordpress.org/trunk@32927 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 12:21:57 +00:00
Drew Jaynes e95626a94f Document default values for optional arguments in `edit_term_link()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32926 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 10:55:13 +00:00
Drew Jaynes bdd00bc8c7 Add missing documentation for the `$echo` parameter in the DocBlock for `edit_term_link()`.
Props tmatsuur.
Fixes #32776.


git-svn-id: https://develop.svn.wordpress.org/trunk@32925 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 10:52:32 +00:00
Dion Hulse b1b9db161f WP Filesystem: Correctly set the @since for WP_Filesystem_Base::getchmod() added in r32923.
This is 2.5.0 as that's when the function become available in all subclasses.
See #29548


git-svn-id: https://develop.svn.wordpress.org/trunk@32924 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 04:51:16 +00:00
Dion Hulse fc52d9cbb1 WP Filesystem: Correctly parse the permissions field in the directory listings, and actually set it in FTP environments
Props mnelson4 for initial patch.
Fixes #29548


git-svn-id: https://develop.svn.wordpress.org/trunk@32923 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 04:48:18 +00:00
Andrew Ozz bdace7c8b5 Press This: fix spinner position relative to the split button.
See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32922 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 03:31:03 +00:00
Andrew Ozz 504f154363 Press This: ensure proper tab order in the split button. Tweak padding and border color a bit.
See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32921 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 03:22:57 +00:00
Andrew Ozz 9911a1cbe6 Press This: convert the Preview | Save | Publish buttons to a split button.
See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32920 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 02:45:38 +00:00
John Blackbourn 447550ec7b Implement tests for the `upload_mimes` filter to ensure it prevents the upload of disallowed file types.
See #32693


git-svn-id: https://develop.svn.wordpress.org/trunk@32919 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 00:42:33 +00:00
John Blackbourn 8c22c526bd Implement canonical and `url_to_postid()` tests for child pages which share a post name with other child pages.
See #32759


git-svn-id: https://develop.svn.wordpress.org/trunk@32918 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 00:40:45 +00:00
John Blackbourn 06ed4c4d0f Correct the title used on the user dashboard.
Fixes #32754
Props johnjamesjacoby


git-svn-id: https://develop.svn.wordpress.org/trunk@32917 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 00:36:40 +00:00
Scott Taylor 7192f7e9cf Because programming is fun. After [32915], `_.find()` will return `undefined` if an empty array is passed - in that case, the function should return `true`.
See #32746.


git-svn-id: https://develop.svn.wordpress.org/trunk@32916 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-23 19:42:50 +00:00
Scott Taylor 75b6e0755d When filtering media by type in `wp.media.model.Attachments.filters.type()`, account for the library's `type` being an array of full mime-types.
Fixes #32746.


git-svn-id: https://develop.svn.wordpress.org/trunk@32915 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-23 19:39:21 +00:00
Scott Taylor 6cded9493a In `wp_prepare_attachment_for_js()`, when setting `filename`, call `wp_basename()` on the result of `get_attached_file()`, not `WP_Post->guid`. `guid` can be set to the result `get_permalink()`, which is not a file path.
Props daxelrod.
Fixes #32531.


git-svn-id: https://develop.svn.wordpress.org/trunk@32914 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-23 18:29:44 +00:00
Scott Taylor 5beca90d40 The `query-attachments` AJAX action immediately errors out if the user doesn't have the `upload_files` cap. As such, the Customizer shouldn't show buttons that launch the media modal when the user doesn't have the proper permissions to query attachments.
See #32654.


git-svn-id: https://develop.svn.wordpress.org/trunk@32913 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-23 18:19:43 +00:00
Boone Gorges 2399de6870 Add `expectedDeprecated` flags to `wp_richedit_pre()` and `wp_htmledit_pre()` unit tests.
These functions were deprecated in [32899].

See #32425.

git-svn-id: https://develop.svn.wordpress.org/trunk@32912 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-23 14:41:39 +00:00
Boone Gorges 641e701865 In `WP_Comment_Query`, parse meta_query vars after the `pre_get_comments` hook.
[31467] included a change that involved generating meta_query SQL before the
`pre_get_comments` hook, with the result that `pre_get_comments` callbacks were
no longer able to modify comment meta queries. We fix the problem by moving the
SQL generation to after the hook.

This changeset also includes a second call to `meta_query->parse_query_vars()`,
to ensure that modifications to metadata-related query vars (such as `meta_key`
and `meta_value`) performed in `pre_get_comments` callbacks have the expected
effect on the comment query.

Fixes #32762.

git-svn-id: https://develop.svn.wordpress.org/trunk@32911 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-23 14:35:29 +00:00
Boone Gorges e0908f450f Fix PHP notice in `WP_Tax_Query::get_sql_for_clause()`.
Previously, the `$where` variable was not initialized, so that when an invalid
'operator' was passed, PHP would complain that `$where` was undefined.

Props dlh.
Fixes #32756.

git-svn-id: https://develop.svn.wordpress.org/trunk@32910 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-23 12:43:05 +00:00
Scott Taylor ff871b3603 Refresh attachment links in the media modal are unneeded since bringing the image editor into it in [27445].
Props rommelxcastro.
Fixes #32550.


git-svn-id: https://develop.svn.wordpress.org/trunk@32909 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 21:32:04 +00:00
Scott Taylor 3b17ffb990 In `wp.media.view.UploaderStatus.filename()`, don't truncate the filename.
Props helen.
Fixes #31216.


git-svn-id: https://develop.svn.wordpress.org/trunk@32908 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 21:25:19 +00:00
Scott Taylor f039546371 Add a label to the content field in the Text Widget for screen readers.
Props afercia.
Fixes #32736.


git-svn-id: https://develop.svn.wordpress.org/trunk@32907 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 21:21:02 +00:00
Scott Taylor 6932a5f558 Sanitize the class passed to `wp_list_bookmarks()` and allow passing an array.
Props ryan, obenland.
Fixes #23150.


git-svn-id: https://develop.svn.wordpress.org/trunk@32906 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 20:54:31 +00:00
Scott Taylor 7af8195803 In `unregister_setting()`, search for `$option_name` in a segment of `$new_whitelist_options` keyed by `$option_group`.
Props nofearinc.
Fixes #26479.


git-svn-id: https://develop.svn.wordpress.org/trunk@32905 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 20:50:30 +00:00
Scott Taylor 9d0fe3958c After [32884], update the default value for `comment_shortcuts`.
Props dlh, rachelbaker, DrewAPicture.
Fixes #31588.


git-svn-id: https://develop.svn.wordpress.org/trunk@32904 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 20:43:58 +00:00
Scott Taylor a147a92046 List table views: fix missing current class for "All" when logged in as an author.
Props afercia.
Fixes #32015.


git-svn-id: https://develop.svn.wordpress.org/trunk@32903 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 20:38:32 +00:00
Helen Hou-Sandi 3f4a902051 Add "Scheduled" to post states.
props rclations.
fixes #32131.


git-svn-id: https://develop.svn.wordpress.org/trunk@32902 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 16:06:45 +00:00
Sergey Biryukov ef8ed3e279 Avoid a PHP notice in `WP_Press_This::get_suggested_content()` after [32828].
props kraftbj.
fixes #32751.

git-svn-id: https://develop.svn.wordpress.org/trunk@32901 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 15:19:53 +00:00
Andrew Ozz e03d853fe6 Fix typo/white space in the docs.
See #32425.

git-svn-id: https://develop.svn.wordpress.org/trunk@32900 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-21 22:07:48 +00:00
Andrew Ozz e366658072 Update the TinyMCE initialization:
- Replace `wp_htmledit_pre()` and `wp_richedit_pre()` with `format_for_editor()`.
- Replace the `'htmledit_pre'` and `'richedit_pre'` filters with `'format_for_editor'`.
- Do not run the post content through `wpautop()` in PHP when the visual editor is default. Run the textarea content through the JS wpautop on initializing TinyMCE.
- Simplify both editors initialization.
- Improve setting of `wpActiveEditor` in Quicktags.
- Improve editor.js, use `tinymce.$` when possible.
See #32425.

git-svn-id: https://develop.svn.wordpress.org/trunk@32899 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-21 22:00:42 +00:00
boonebgorges d54302da5e Pass stylesheet URL as an argument to 'style_loader_tag' filter.
This change brings the filter's signature in line with 'script_loader_tag'.

Props nicholas_io.
Fixes #32660.

git-svn-id: https://develop.svn.wordpress.org/trunk@32898 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-21 19:34:03 +00:00
Dominik Schilling (ocean90) cf57a5e072 Use 3-digit x.x.x style for `4.3.0` @since versions.
see #32335, #32430.

git-svn-id: https://develop.svn.wordpress.org/trunk@32897 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-21 11:40:05 +00:00