Commit Graph

25474 Commits

Author SHA1 Message Date
Andrew Ozz
a00d98a8c2 TinyMCE: bring back removal of the size-* class when the user soft-resizes an image, see #24409
git-svn-id: https://develop.svn.wordpress.org/trunk@27694 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-25 00:15:37 +00:00
Scott Taylor
98921c5ca0 Let us pass jshint:core.
git-svn-id: https://develop.svn.wordpress.org/trunk@27693 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 23:01:15 +00:00
Andrew Nacin
05f0bcabec Use the current post's post type when determining post adjacency.
props ethitter.
fixes #26937.


git-svn-id: https://develop.svn.wordpress.org/trunk@27692 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 21:29:14 +00:00
Andrew Nacin
4983a8b8d0 RSS widgets: Omit the title attribute when the summary is shown.
Trim the title attribute to ensure whitespace isn't rendered.

props SergeyBiryukov.
fixes #26520. see #26552.


git-svn-id: https://develop.svn.wordpress.org/trunk@27691 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 21:07:10 +00:00
Scott Taylor
9cd40edebf In wp_create_post_autosave(), intersect the $new_autosave's keys with the keys from _wp_post_revision_fields() to ensure that all expected fields are present.
Props kovshenin.
Fixes #25416.



git-svn-id: https://develop.svn.wordpress.org/trunk@27690 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 20:31:51 +00:00
Scott Taylor
82ba1702df When using meta_query in a WP_Query, passing NOT EXISTS or '' to compare should not require value to be set. The resulting SQL should then produce the appropriate OR clause for existence of non-existence after passing the query to the $key_only_queries stack internally.
Adds unit tests. 

Props chrisguitarguy, for the original patch.
Fixes #23268.



git-svn-id: https://develop.svn.wordpress.org/trunk@27689 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 19:56:54 +00:00
Andrew Nacin
afde656058 Customizer header images: Fix randomizing headers.
props mcsf.
see #21785.


git-svn-id: https://develop.svn.wordpress.org/trunk@27688 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 19:15:32 +00:00
Andrew Nacin
d9ab8333c8 Media manager: Avoid a blank modal when an invalid image size class is set on the image.
props gcorne.
fixes #24409.


git-svn-id: https://develop.svn.wordpress.org/trunk@27687 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 19:00:15 +00:00
Scott Taylor
710f11f2df When using WP_Query's "fields" => "ids" (or "fields" => "id=>parent"), the returned values should be an array of integers, not array of integers represented by strings.
Adds unit tests. All other unit tests pass.

Props danielbachhuber.
Fixes #27252.



git-svn-id: https://develop.svn.wordpress.org/trunk@27686 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 18:54:38 +00:00
Scott Taylor
651b4a5f5b Fix the video shortcode unit test after [27519].
git-svn-id: https://develop.svn.wordpress.org/trunk@27685 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 17:13:48 +00:00
Scott Taylor
88b610dc72 Fix a swath of broken unit tests from Tests_User_ListAuthors.
git-svn-id: https://develop.svn.wordpress.org/trunk@27684 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 16:52:38 +00:00
Scott Taylor
2583c954b9 Revert [27184] until WP_Query is patched to apply order to each space-delimited orderby value properly.
See #26042.



git-svn-id: https://develop.svn.wordpress.org/trunk@27683 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 14:45:44 +00:00
Scott Taylor
54bc81e04f Do not use the alternative if/elseif/else syntax in prepend_attachment() introduced in [27622], as per kovshenin.
Fixes #27243.



git-svn-id: https://develop.svn.wordpress.org/trunk@27682 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 14:38:31 +00:00
Sergey Biryukov
f966183e51 Fix typo in a comment. see #25663.
git-svn-id: https://develop.svn.wordpress.org/trunk@27681 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 09:08:36 +00:00
Andrew Ozz
2dc003fb02 Two files weren't deleted in [27679], see #27014
git-svn-id: https://develop.svn.wordpress.org/trunk@27680 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 06:12:08 +00:00
Andrew Ozz
0898014ebd Update the TinyMCE tests.
In 4.0.20 all tests were reworked. The 'testrunner' was removed and the PhantomJS Runner QUnit plugin was added making it possible to run the tests from cli. However it is still necessary to run the tests in all supported browsers to test the fixes for all browser quirks and normalization. Also all tests are loaded in one html file.

See #27014

git-svn-id: https://develop.svn.wordpress.org/trunk@27679 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 05:59:45 +00:00
Andrew Nacin
9b56f72fb1 Ensure Thickbox loading spinner is properly sized for HiDPI displays.
props paulwilde.
see #26952.


git-svn-id: https://develop.svn.wordpress.org/trunk@27678 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 03:45:08 +00:00
Andrew Nacin
401aa27073 Plugin Installer: Disable 'Latest Version Installed' buttons.
props paulwilde.
see #26952.


git-svn-id: https://develop.svn.wordpress.org/trunk@27677 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 03:40:28 +00:00
Drew Jaynes (DrewAPicture)
73fe2abadd Inline documentation for hooks in wp-includes/post-template.php.
Props Toru and kpdesign.
Fixes #25621.


git-svn-id: https://develop.svn.wordpress.org/trunk@27676 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 03:36:36 +00:00
Andrew Nacin
48391a7444 Use correct variable. see [27373].
props TobiasBg.
fixes #14424.


git-svn-id: https://develop.svn.wordpress.org/trunk@27675 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 03:24:33 +00:00
Drew Jaynes (DrewAPicture)
0be6f6072a Inline documentation for hooks in wp-admin/includes/taxonomy.php.
Props kpdesign for the initial patch.
Fixes #27433.


git-svn-id: https://develop.svn.wordpress.org/trunk@27674 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 03:13:06 +00:00
Drew Jaynes (DrewAPicture)
7062f3c75a Inline documentation for wp-admin/includes/class-wp-upgrader.php.
Props kpdesign for some minor cleanup.
Fixes #27436.


git-svn-id: https://develop.svn.wordpress.org/trunk@27673 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 02:59:36 +00:00
Drew Jaynes (DrewAPicture)
af0f9a5e00 Inline documentation for hooks in wp-admin/includes/file.php.
Fixes #27429.


git-svn-id: https://develop.svn.wordpress.org/trunk@27672 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 02:44:17 +00:00
Drew Jaynes (DrewAPicture)
99c2775c0f Remove some debug cruft accidentally committed in [27670].
See #27430.


git-svn-id: https://develop.svn.wordpress.org/trunk@27671 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 02:37:05 +00:00
Drew Jaynes (DrewAPicture)
ac9e81e0f0 Inline documentation for hooks in wp-admin/includes/menu.php.
Also fixes syntax for a few unrelated multi-line comments in the file.

Props kpdesign for some minor cleanup.
Fixes #27430.


git-svn-id: https://develop.svn.wordpress.org/trunk@27670 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 02:34:14 +00:00
Drew Jaynes (DrewAPicture)
4d7ca61c09 Inline documentation for hooks in wp-admin/includes/dashboard.php.
Props mauryaratan. Props kpdesign for some minor cleanup.
Fixes #25752.


git-svn-id: https://develop.svn.wordpress.org/trunk@27669 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 02:20:33 +00:00
Andrew Nacin
71917873d4 Introduce HTML5 caption support.
When a theme supports HTML5 captions via add_theme_support( 'html5', 'caption' ), figure and figcaption will be used instead of div and p.

There's a bonus. But first, some history: Captions were introduced with an inline style set for the container. This remains, as it is there to force captions to wrap. But this inline style included an extra 10 pixels, which have vexxed theme developers for years. While these pixels were designed to ensure padding around floated images, modern themes handle this with grace. The additional pixels thus feel encumbering.

As the new HTML5 gallery support avoids outputting default gallery styles (again, irking theme developers for years; see #26697), the new HTML5 caption support will also ditch these 10 pixels of unwanted hand-holding. 

The 10 pixels are also removed entirely in the visual editor (and more styles may also disappear here; see #26642), giving themes the power necessary to match the frontend styles.

The filter img_caption_shortcode_width added in 3.7 to work around this madness (see #14380) is skipped entirely when the theme supports HTML5 captions.

props obenland, azaozz.
see #26642. also fixes #9066.


git-svn-id: https://develop.svn.wordpress.org/trunk@27668 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 02:04:56 +00:00
Drew Jaynes (DrewAPicture)
c7080c0a6b Inline documentation for hooks in wp-admin/includes/post.php.
Also moves the primary PHPDoc for the `edit_posts_per_page` hook to wp-admin/includes/post.php.

Props kpdesign for some cleanup.
Fixes #27431.


git-svn-id: https://develop.svn.wordpress.org/trunk@27667 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 01:48:40 +00:00
Drew Jaynes (DrewAPicture)
7002a26178 Inline documentation for hooks in wp-includes/category-template.php.
Props kpdesign for the cleanup.
Fixes #27432.


git-svn-id: https://develop.svn.wordpress.org/trunk@27666 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 01:34:46 +00:00
Andrew Nacin
06a02bc455 Use wp_cache_add() instead of wp_cache_set() when we don't want an unconditional set.
props jeremyfelt.
see #27003.


git-svn-id: https://develop.svn.wordpress.org/trunk@27665 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 01:02:06 +00:00
Andrew Nacin
9c520a5412 Multisite load: Cache the main site lookup query.
props jeremyfelt.
see #27003.


git-svn-id: https://develop.svn.wordpress.org/trunk@27664 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 01:00:17 +00:00
Andrew Nacin
903c86d927 Introduce a ms_site_not_found filter to replace NOBLOGREDIRECT.
Move some processing down below the point where we bail if there's no site. Add more documentation.

props jeremyfelt.
fixes #21143, see #27003.


git-svn-id: https://develop.svn.wordpress.org/trunk@27663 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 00:13:48 +00:00
Andrew Ozz
263d9c7f33 Plupload: switch to urlstream upload method when the 'flash' runtime is used in non IE browsers. This ensures cookies are sent but limits the maximum file size that flash can handle.
By default only IE9 and older use flash so this change is mostly for completeness. It would affect only the (extremely rare) cases where a plugin disables the html5 runtime.

git-svn-id: https://develop.svn.wordpress.org/trunk@27662 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-23 23:44:20 +00:00
Sergey Biryukov
d5889105bf Twenty Fourteen: Fix typo in contextual help.
props vanillalounge.
fixes #27493.

git-svn-id: https://develop.svn.wordpress.org/trunk@27661 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-23 12:41:58 +00:00
Andrew Ozz
00cb862f5e TinyMCE:
- Fix PressThis styling when the popup is resized.
- Don't force loading of the media JS.
- Add the 'image' plugin as fallback when no media button(s).
- Add back the link icon tooltip/menu item string for translation.
See #24067, see #24409


git-svn-id: https://develop.svn.wordpress.org/trunk@27660 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-23 07:09:23 +00:00
Scott Taylor
d534c8c3eb When inserting a video shortcode into the editor, set the poster attribute automatically if the video has a featured image attached to it.
See #27460.



git-svn-id: https://develop.svn.wordpress.org/trunk@27659 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-23 03:35:50 +00:00
Scott Taylor
559cccfdd1 When an HTML5 fallback button is pressed in the Audio or Video Details state, filter the library by that specific mime-type when the Add Audio|Video Source is activated.
See #27389.



git-svn-id: https://develop.svn.wordpress.org/trunk@27658 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-23 03:15:35 +00:00
Scott Taylor
0697544056 Turn on thumbnail support for attachment:audio and attachment:video. Change conditionals to check for theme OR post type support when determining whether to turn on the Featured Image UI pieces in the admin.
Fixes #27460.



git-svn-id: https://develop.svn.wordpress.org/trunk@27657 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-23 02:34:39 +00:00
Andrew Ozz
7dbbebeb43 Move the styling of drag/drop on the editor uploading to media-views.css, see #27465
git-svn-id: https://develop.svn.wordpress.org/trunk@27656 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-23 01:41:21 +00:00
Scott Taylor
42e7ed7c78 General code cleanup and improving video sizing in the admin:
* Abstract the setting of a primary button and its callback in `wp.media.view.MediaFrame.MediaDetails`
* Account for the existence or non-existence of `$content_width` in the TinyMCE views for video
* Make sure video models always have dimensions, even if they are the defaults
* For browsers that are not Firefox, don't use a timeout when setting the `MediaElementPlayer` instance in TinyMCE views

See #27320.



git-svn-id: https://develop.svn.wordpress.org/trunk@27655 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-22 23:25:08 +00:00
Dominik Schilling (ocean90)
7ad1e0f1bb Widget Customizer: Use Underscores indexOf for IE8 compatibility.
props adamsilverstein.
see #27485.

git-svn-id: https://develop.svn.wordpress.org/trunk@27654 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-22 21:21:36 +00:00
Dominik Schilling (ocean90)
2a1899e319 Widget Customizer: Fix 'WidgetCustomizerPreview' is undefined error in IE8/9.
* Move `WidgetCustomizerPreview` to `wp.customize.WidgetCustomizerPreview`
* Move `WidgetCustomizerPreview_exports` to export_preview_data()
* Use `_wpWidgetCustomizerPreviewSettings` to transfer settings to `wp.customize.WidgetCustomizerPreview`

see #27485.

git-svn-id: https://develop.svn.wordpress.org/trunk@27653 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-22 21:03:18 +00:00
Dominik Schilling (ocean90)
429a018b9c Widget Customizer: Improve error handling. First pass.
* Replace Widget_Customizer_Exception with WP_Error
* Call Previewer.cheatin() to show the cheating message if a user can't change widgets
* Call Previewer.login() to show the login form if a user is logged out
* Show a generic error message on failures

see #27419.

git-svn-id: https://develop.svn.wordpress.org/trunk@27652 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-22 20:54:17 +00:00
Dominik Schilling (ocean90)
a3abe09be2 Customizer: Use the _.now() function from Undescore.js for the current timestamp. Date.now() isn't supported in IE8.
fixes #27477.

git-svn-id: https://develop.svn.wordpress.org/trunk@27651 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-22 10:53:10 +00:00
Dominik Schilling (ocean90)
686896998d Widget Customizer: Improve widget search.
* Removes jQuery.liveFilter dependency
* Filters widget collection directly
* Widget's name, ID and description will be searched

fixes #27451.

git-svn-id: https://develop.svn.wordpress.org/trunk@27650 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-21 21:12:32 +00:00
Dominik Schilling (ocean90)
f0abc9b7e0 Themes: Improve RegExp pattern for search.
* The replacement of spaces is now done globally.
* The search term is now escaped for RegExp meta characters.

props westonruter for the hint.
fixes #27479.

git-svn-id: https://develop.svn.wordpress.org/trunk@27649 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-21 21:03:59 +00:00
Sergey Biryukov
4db18a113d Fix a copy/paste error in WP_Date_Query parameter description.
props jdgrimes.
fixes #27472.

git-svn-id: https://develop.svn.wordpress.org/trunk@27648 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-21 17:52:08 +00:00
Andrew Nacin
ff5c4e186b Add context to 'Browse' (themes). see #27055, #27453.
git-svn-id: https://develop.svn.wordpress.org/trunk@27646 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-21 00:19:38 +00:00
nacin
fe3404bdf1 Merge two strings. see #27320, #27453.
git-svn-id: https://develop.svn.wordpress.org/trunk@27645 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-21 00:18:02 +00:00
Andrew Ozz
4b760ff840 Editing image file: properly refresh the view after restoring the original image or rescaling the image. Props gcorne, see #21811
git-svn-id: https://develop.svn.wordpress.org/trunk@27644 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-20 23:24:43 +00:00