Scott Taylor
a7c1728f2e
Reinstate the changes from [28579] with some adjustments:
...
* Check `! empty( $postarr['file'] )` before calling `update_attached_file()`
* Add a unit test: `test_update_attachment_fields()`
* Run the same logic for empty `guid` for attachments that always ran in `wp_insert_post()`, as per #18310 . This fixes a unit test that would have broken when this ticket was marked closed.
* Updated the unit test in `Tests_Media::test_wp_prepare_attachment_for_js()` to account for `url` no longer being empty
Props kovshenin, wonderboymusic.
See #21963 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28788 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 18:26:17 +00:00
Scott Taylor
05abd7e56f
Cleanup wp_widget_rss_form()
after [28734]. "$$input used sanitized variables which contained actual values, unlike $inputs[$input] which in that context contains data about which input fields are hidden."
...
Props kovshenin.
Fixes #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28787 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 17:28:12 +00:00
Scott Taylor
76ccf2a956
Remove unused globals from link-parse-opml.php
after [28743].
...
Props SergeyBiryukov.
Fixes #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28786 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 17:25:47 +00:00
Scott Taylor
33275a0826
Cleanup after [28671]:
...
* Set better defaults in `paginate_links()`, so that themes don't have to calculate them on their own, like Twenty Fourteen does now.
* Don't set page 1 to `?page=1` or `/page/1/` - that will force a canonical redirect.
* Add and cleanup unit tests
Props obenland, SergeyBiryukov, wonderboymusic.
Fixes #24606 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28785 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 17:11:14 +00:00
Scott Taylor
eb289835f7
Further adjustments after [8364], listen to an editor instance event instead of delegating a body click when attempting to pause all players belonging to a particular MCE view.
...
Props avryl.
Fixes #27971 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28784 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 16:29:47 +00:00
Scott Taylor
5ec545d5ab
Revert [28613] and [28664]. A good idea, but too much BC baggage.
...
See #28099 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28783 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 16:20:35 +00:00
John Blackbourn
dbc30e94b3
Increase the timeout for plugin and theme update checks based on how many are being checked. Props dd32. Fixes #25788
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28782 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 23:20:15 +00:00
John Blackbourn
036c2b5fca
Remove SSL verification by default for requests to wp-cron.php. Props sivel, rhurling. Fixes #12609 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28781 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 22:52:35 +00:00
Andrew Nacin
e27b672b22
Narrower screen when choosing a language. see #28577 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28780 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 04:46:40 +00:00
Andrew Nacin
aa6ef01298
Fix variable usage in new language install choices. see #28577 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28779 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 04:36:29 +00:00
Helen Hou-Sandi
ae2cce3f64
Restore the ability to pass classes to admin menu submenu items, important for the Customize link. Accidentally left out in [24048]. fixes #28583 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28778 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 02:17:08 +00:00
Sergey Biryukov
4bee2a9c4a
Fix copy/paste error in a comment.
...
see #28581 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28777 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 01:35:28 +00:00
Sergey Biryukov
4306de30e3
Move preg_match() that should only run once out of the loop.
...
props dllh.
fixes #28575 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28776 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 00:00:27 +00:00
Scott Taylor
9642d17ff8
Diambiguate type
and shortcode
in TinyMCE view classes and their attached view.View
class. Has the added feature of not causing JS errors.
...
See #28532 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28775 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 23:02:10 +00:00
Andrew Nacin
39cf46851b
Allow a language to be chosen before installing WordPress. First pass.
...
* Checks WordPress.org for available languages.
* In get_locale(), starts using the WPLANG option that has existed in multisite since the MU days.
* Adds new argument to wp_install() for setting WPLANG.
see #28577 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28774 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 19:57:21 +00:00
Scott Taylor
0688f9eb49
In wptexturize()
+ tests:
...
* Allow well-formed HTML inside of shortcode attributes
* Restrict recursion. HTML is allowed but ignored.
* Do not allow exotic HTML comments in shortcode attributes.
* Continue to ignore the [ and ] chars if they appear in any HTML attribute.
* Update related regex patterns.
* Update unit tests.
Props miqrogroove.
Fixes #28564 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28773 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 19:48:46 +00:00
Sergey Biryukov
6719d08d2d
Revert [28766].
...
see #28555 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28772 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 02:22:45 +00:00
Sergey Biryukov
9561db4dee
Don't add # to URL when clicking 'OK' without changing the permalink.
...
props avryl.
fixes #27594 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28771 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 00:28:35 +00:00
Sergey Biryukov
550d0f0aea
Don't generate adjacent links in wp_head() for attachments.
...
props kovshenin.
fixes #21658 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28770 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 00:04:14 +00:00
Sergey Biryukov
566fd5da8d
Pass WP_Customize_Setting instance to 'customize_save_*' action.
...
props danielbachhuber.
fixes #27979 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28769 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 23:57:19 +00:00
Andrew Ozz
b8fd9d997e
TinyMCE: update to 4.0.28+. Includes all changes until 09-06-2014: 32cb108d41
. Changelog: 32cb108d41/changelog.txt
.
...
See #28391 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28768 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 23:49:00 +00:00
Sergey Biryukov
f1172ba195
Pass WP_Customize_Setting instance to 'customize_preview_*' and 'customize_update_*' actions.
...
props dustyn, DrewAPicture.
fixes #27979 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28767 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 23:34:31 +00:00
Sergey Biryukov
63596d6868
Prevent bulk actions from being performed when Filter button is clicked.
...
props layotte.
fixes #28555 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28766 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 22:16:11 +00:00
Scott Taylor
b11edb94d9
Fix abbreviations mixed with quotes, example: '99% of people'
.
...
Add/alter unit tests.
Props miqrogroove.
Fixes #26850 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28765 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 20:18:38 +00:00
Scott Taylor
1f4d925102
In wptexturize()
, adjust for the treatment of abbreviated years at the end of quotations.
...
Silence some unit tests that have never passed and may no longer be applicable.
Props miqrogroove.
Fixes #18549 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28764 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 20:13:54 +00:00
Scott Taylor
6f658551d6
Add unit tests to confirm that ---
is properly converted to —
by wptexturize()
where appropriate.
...
Props miqrogroove.
Fixes #28483 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28763 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 18:06:12 +00:00
Scott Taylor
14f3b15d69
Add Unit Tests for i18n and wptexturize()
. Don't confuse closing single quotes and apostrophes.
...
See #27426 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28762 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 17:56:08 +00:00
Scott Taylor
03a6e5f1fb
wptexturize()
adjustments:
...
* Only place an apostrophe before a number when it has exactly two digits.
* Never match '99' with the single prime pattern.
* Always assume '99' is an abbreviated year at the end of a quotation.
* Add unit tests.
* Resolves the unit test broken in [28721] for #8775 .
See #26850 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28761 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 17:40:07 +00:00
Sergey Biryukov
abddfc4b99
Prevent get_post_class() and get_body_class() from returning duplicate classes.
...
props Compute.
fixes #28541 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28760 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 15:17:36 +00:00
Sergey Biryukov
177d39a15b
Fix labels on installation screen.
...
props avryl.
fixes #28548 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28759 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 14:36:22 +00:00
Lance Willett
f738d86233
Twenty Fourteen: fix masthead behavior in IE when a custom header image is present. Props Kau-Boy, lancewillett. Fixes #27220 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28758 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-16 18:21:01 +00:00
Dominik Schilling (ocean90)
106e1dbedb
Use the value of WP_TESTS_DOMAIN
in some unit tests.
...
props danielhuesken.
fixes #28552 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28757 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-16 15:07:37 +00:00
Dominik Schilling (ocean90)
87f306aa81
Twenty Fourteen: Adjust spacing for menu toggle button to avoid overflowing accented characters.
...
Broken in [28698].
props schoenwaldnils.
fixes #27456 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28756 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-16 14:00:15 +00:00
Andrew Ozz
ed4a159498
TinyMCE wpView: fix selecting all of view's "text" in Safari, props avryl, fixes #28088
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28755 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-16 00:11:45 +00:00
Andrew Ozz
ed07c215dc
wpView: improve handling of embed errors/error messages, see #28195
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28754 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-15 22:52:45 +00:00
Sergey Biryukov
084cc046ac
Correct @return value for term_exists().
...
props simonwheatley.
fixes #28538 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28753 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-14 14:56:21 +00:00
Scott Taylor
69ecca0b6a
Add "edit" mode for [embed]
and URL media previews.
...
See #28532 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28752 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-13 21:41:20 +00:00
Sergey Biryukov
a67759c545
wpLink: use simpler expressions to detect email address or URL. We are not validating user input here, just suggesting.
...
see #19992 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28751 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-13 21:25:16 +00:00
Andrew Ozz
8ed6fd2d50
wpLink: use the proper instance of the editor when looking at the selection. Move the email and URL regexp to variables. See #19992
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28750 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-13 21:13:15 +00:00
Andrew Nacin
65803684f4
Add a new 'Beta Testing' tab on the plugin installer, for features as plugins such as Press This.
...
fixes #28513 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28749 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-12 18:08:56 +00:00
Andrew Ozz
09d4b541fb
wpView:
...
- Don't wrap single-line URLs in [embed]. Use them directly in generating a view.
- If the embedding HTML contains a script, "sandbox" it in an iframe to prevent it from changing the editor DOM.
- Automatically add toolbar and overlay when needed.
- Try to embed single-line URLs only if they are pasted in an empty paragraph.
Props avryl, see #28195
git-svn-id: https://develop.svn.wordpress.org/trunk@28748 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-12 02:48:17 +00:00
Scott Taylor
e0a089d9d8
Don't use variable variables in touch_time()
.
...
See #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28747 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 21:04:56 +00:00
Scott Taylor
61c1da236c
Don't use variable variables in wp_reset_vars()
. Test by searching in list tables, etc.
...
See #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28746 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 19:59:18 +00:00
Scott Taylor
eb23569835
Don't use variable variables in user-new.php
. Test by causing errors when creating a new user.
...
See #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28745 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 19:53:25 +00:00
Scott Taylor
6e159bb671
Don't use variable variables in setup-config.php
(Step 2).
...
See #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28744 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 19:40:27 +00:00
Scott Taylor
98f3cd0548
OPML:
...
* Learn how OPML works, cry.
* Remove unused globals in `startElement()`
* Stop using variable variables in `startElement()`
Tested with the OPML importer plugin
See #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28743 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 19:30:26 +00:00
Scott Taylor
4ccb011960
Don't use variable variables in wp_dashboard_plugins_output()
. Variable variables aren't the worst thing about this function.
...
See #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28742 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 18:55:00 +00:00
Scott Taylor
0675902ec8
Don't use variable variables in wp_salt()
.
...
See #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28741 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 18:35:42 +00:00
Scott Taylor
0d0cdfe1c7
Don't use variable variables in wp_insert_user()
.
...
Add a local array, `$meta`, to provide substantial disambiguation among variables.
See #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28740 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 18:20:57 +00:00
Scott Taylor
35af75077b
Don't use variable variables in plugins_url()
.
...
See #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28739 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 18:17:52 +00:00