Sergey Biryukov
ab9aee8af4
Code Modernization: Only call libxml_disable_entity_loader()
in PHP < 8.
...
This function has been deprecated in PHP 8.0 because in libxml 2.9.0, external entity loading is disabled by default, so this function is no longer needed to protect against XXE attacks.
Props jrf.
Fixes #50898 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48789 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-12 15:23:47 +00:00
Sergey Biryukov
1bf0a780b3
Code Modernization: Remove final
keyword from private methods.
...
Declaring a `private` method as `final` is an oxymoron, as `private` methods cannot be overloaded anyway.
Using `final private function...` will generate a warning in PHP 8.
Props jrf.
Fixes #50897 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48788 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-12 15:03:50 +00:00
Jonathan Desrosiers
56b096195a
Help/About: Final adjustments to the 5.5 About page.
...
- Final CDN asset URLs.
- Some minor color adjustments.
Props ryelle, marybaum, davidbaumwald, audrasjb, estelaris, afercia, cbringmann, andreamiddleton, desrosj, SergeyBiryukov, ocean90, nrqsnchz, spacedmonkey, whyisjake, man4toman.
Fixes #50416 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48783 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-11 16:51:22 +00:00
Sergey Biryukov
a84a5029be
Docs: Consistently use third-person singular verbs for various filter descriptions, per the documentation standards.
...
See #50768 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48782 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-11 00:32:22 +00:00
Sergey Biryukov
635ae16e85
Docs: Update documentation for get_{$meta_type}_metadata
filter for consistency with default_{$meta_type}_metadata
.
...
Follow-up to [48777].
See #50891 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48778 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-10 15:48:25 +00:00
Jake Spurlock
d434a22552
Options, Meta APIs: Update the docs around default metadata values.
...
Add a missing @since value for 5.5 and potential default filter names.
Fixes #50891 .
Props johnbillion.
git-svn-id: https://develop.svn.wordpress.org/trunk@48777 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-10 15:40:18 +00:00
Jonathan Desrosiers
d8985baaad
Bundled Themes: Bump theme versions ahead of WordPress 5.5.
...
The following theme versions will be released in coordination with WordPress 5.5:
- Twenty Ten: 3.1
- Twenty Eleven: 3.5
- Twenty Twelve: 3.2
- Twenty Thirteen: 3.1
- Twenty Fourteen: 2.9
- Twenty Fifteen: 2.7
- Twenty Sixteen: 2.2
- Twenty Seventeen: 2.4
- Twenty Nineteen: 1.7
- Twenty Twenty: 1.5
Props whyisjake, desrosj.
Fixes #50769 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48775 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-10 15:30:18 +00:00
Jonathan Desrosiers
f05d382e09
Build/Test Tools: Update elliptic
in Twenty Twenty.
...
See #50769 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48774 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-10 15:17:11 +00:00
Ella van Durpe
ab5fb855f3
Editor: update packages
...
Fixes #50888
git-svn-id: https://develop.svn.wordpress.org/trunk@48772 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-10 14:16:11 +00:00
Sergey Biryukov
e70870b2c5
I18N: Fix typo in a screen reader text string on the About page.
...
Follow-up to [48729].
Props pedromendonca.
Fixes #50884 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48770 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-10 13:13:34 +00:00
Sergey Biryukov
82104fac79
I18N: Add a class_exists()
check to Plural_Forms
class for consistency with other POMO library classes.
...
Follow-up to [41722].
Fixes #50881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48769 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-10 11:32:01 +00:00
Sergey Biryukov
e0ad73b0a0
I18N: Fix typo in a string in rest_validate_value_from_schema()
.
...
Props pedromendonca.
Fixes #50879 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48767 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-09 01:58:31 +00:00
Sergey Biryukov
f556437ef4
Coding Standards: Remove a few more extra brackets from some conditions in wp-admin/includes/plugin.php
.
...
Follow-up to [48764].
See #50767 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48766 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-09 01:54:28 +00:00
Sergey Biryukov
f09aab7232
Coding Standards: Use consistent formatting for translator comments in wp-includes/rest-api.php
.
...
See #50767 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48765 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-09 01:44:29 +00:00
Sergey Biryukov
18c0692773
Coding Standards: Fix WPCS issues in wp-admin/includes/plugin.php
.
...
Includes minor code layout fixes for better readability.
Props rnaby for initial patch.
See #50767 , #43848 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48764 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-08 21:02:18 +00:00
Sergey Biryukov
9eb6dd69c8
Coding Standards: Simplify some parts of user_can_access_admin_page()
for better readability.
...
Props rnaby, valentinbora, khag7.
Fixes #43848 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48762 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-08 20:22:34 +00:00
Sergey Biryukov
fd8169e525
Help/About: Update videos and their descriptions on the About page.
...
Follow-up to [48675], [48686], [48721], [48729], [48730], [48736].
Props ryelle, marybaum, estelaris, desrosj, joen, afercia.
See #50416 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48761 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-08 14:14:38 +00:00
Sergey Biryukov
5602ba4db7
Docs: Document the return value of get_settings_errors()
using hash notation.
...
Props stevenlinx, webdevmattcrom, atachibana.
Fixes #42786 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48760 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-08 12:37:03 +00:00
Jake Spurlock
6ebff324b2
Themes: Update the test_theme_supports_custom_logo
to check for the unlink-homepage-logo
property.
...
See #37011 , [48757].
Props TimothyBlynJacobs, whyisjake.
git-svn-id: https://develop.svn.wordpress.org/trunk@48758 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-07 20:42:04 +00:00
Sergey Biryukov
a5771dc74b
Themes: Add unlink-homepage-logo
to the create_initial_theme_features()
registration for the custom-logo
theme feature.
...
Follow-up to [48039], [48283], [48749].
Props TimothyBlynJacobs.
Fixes #37011 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48757 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-07 19:41:16 +00:00
Andrew Ozz
5868743f1f
Script Loader: Remove the jquery-migrate-compat-5.5
temporary script handle for now. Can be re-added later if there is a compelling use case. For now it doesn't seem necessary.
...
See #37110 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48754 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-07 18:28:36 +00:00
Sergey Biryukov
910df84191
Script Loader: Add a temporary jquery-migrate-compat-5.5
script handle.
...
This is intended as an easy way for plugins and themes to still be able to load jQuery with jQuery Migrate in WordPress 5.5.
Once jQuery is updated to 3.x, this temporary script handle will be removed. This means plugins and themes still using it at that point will fail to load their scripts (as a dependency will be missing), but will not cause "fatal errors" breaking the rest of JS.
Follow-up to [48323], [48324].
Props azaozz, desrosj, apedog, Clorith, jorbin.
Fixes #37110 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48753 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-07 16:49:24 +00:00
Sergey Biryukov
29b58359ed
Comments: Update DB version number used to trigger the upgrade routine for changing the comment_type
DB field value in comments table.
...
Follow-up to [47597], [47626], [48225], [48227], [48748].
Props desrosj.
See #49236 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48751 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-07 16:30:32 +00:00
Sergey Biryukov
8c11d506e1
Docs: Correct usage of the dynamic auto_update_{$type}
filter.
...
This ensures that the canonical name of the filter is used in Site Health debug data, as well as on plugin and theme screens, so the developer reference site remains correct.
Props johnbillion.
Fixes #50868 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48750 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-07 16:12:11 +00:00
Sergey Biryukov
54cba57fa6
Accessibility: Themes: Only unlink custom logo on the home page if the theme declares support for that.
...
To accommodate for the change, the `custom-logo` theme feature now accepts the `unlink-homepage-logo` parameter.
If and when the logo is linked on the home page, the link has the `aria-current` attribute for better accessibility.
Follow-up to [48039], [48283].
Props sabernhardt, audrasjb, johnstonphilip, demetris.
Fixes #37011 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48749 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-07 15:24:10 +00:00
Sergey Biryukov
def2425406
Comments: Update comment cache in the upgrade routine for changing the comment_type
DB field value in comments table.
...
This ensures that comment object cache is cleared after changing the comment type to `comment` instead of an empty string.
Add a unit test for `_wp_batch_update_comment_type()`.
Follow-up to [47597], [47626], [48225], [48227].
Props imath, westonruter.
Fixes #49236 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48748 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-07 14:27:40 +00:00
Sergey Biryukov
9d1a31cd0a
Site Health: Consistently pass an object to the auto_update_{$type}
filter in Site Health debug data.
...
Previously, some instances of the filter received an array from a plugin or theme update response, potentially triggering PHP notices.
Props bpayton, pbiron.
Fixes #50852 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48745 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-07 13:26:11 +00:00
Sergey Biryukov
58f9000f3e
Tests: Correct duplicate array keys in Tests_Kses::test_wp_filter_post_kses_address()
.
...
Previously, only the last `style` value was actually tested.
Props ediamin.
Fixes #50860 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48744 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-06 13:26:06 +00:00
Sergey Biryukov
103d7d1613
Posts, Post Types: Use a consistent wording in messages about a locked post.
...
Props ramiy.
Fixes #50859 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48743 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-06 13:12:03 +00:00
Sergey Biryukov
f840046391
Site Health: Check if session_status()
exists before calling it.
...
Props bgermann.
Fixes #50862 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48742 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-06 00:23:13 +00:00
Sergey Biryukov
55d73734e4
Comments: Remove a few more unnecessary instances of esc_html()
in WP_Comments_List_Table::comment_status_dropdown()
.
...
Core translations are considered safe, and these labels are not escaped in any other instances.
Follow-up to [48521], [48722], [48724].
See #40188 , #50815 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48741 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-05 13:52:01 +00:00
Sergey Biryukov
581a636bad
Help/About: Correct header spacing on shorter screens after removing the musician name.
...
Remove some unnecessary CSS.
Follow-up to [48730].
Props ryelle.
See #50416 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48736 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 18:09:37 +00:00
Sergey Biryukov
752379652d
Plugins: Move the "Successfully installed the plugin" string to the correct Plugin_Upgrader
method.
...
The string refers to the installation, and belongs in the `::install_strings()` method, not in `::upgrade_strings()`.
Props sswebster, nateinaction, SergeyBiryukov.
Fixes #50837 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48734 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 17:52:36 +00:00
Jake Spurlock
3fb50acb41
Site Health: Display auto-update properly for plugins that don't support auto-updates.
...
Properly filter `auto_update_plugin` when displaying the table.
Fixes #50822 .
Props Gwendydd, pbiron, audrasjb, SergeyBiryukov, whyisjake.
git-svn-id: https://develop.svn.wordpress.org/trunk@48731 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 17:35:09 +00:00
Jonathan Desrosiers
d11bac5030
Help/About: Remove “Musician Name” placeholder.
...
The musician name is traditionally not included on the About page due to i18n concerns regarding last minute changes.
Props audrasjb, SergeyBiryukov.
See #50416 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48730 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 17:33:38 +00:00
Jonathan Desrosiers
926cbb5425
Help/About: String updates and accessibility improvements to the 5.5 About page.
...
Props ryelle, nrqsnchz, desrosj, audrasjb, marybaum, spacedmonkey, SergeyBiryukov, estelaris, afercia, ocean90.
See #50416 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48729 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 17:24:35 +00:00
Sergey Biryukov
68d1605ed7
Editor: Make some hardcoded strings in block patterns translatable.
...
Props ocean90, youknowriad.
Fixes #50842 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48726 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 16:59:03 +00:00
ellatrix
005504cbcd
Editor: update JS packages
...
Fixes #50844 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48725 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 16:46:02 +00:00
Sergey Biryukov
a362852fcf
Comments: Restore the ::has_items()
call in WP_Comments_List_Table::extra_tablenav()
for now, until unit tests are updated accordingly.
...
Follow-up to [48722].
Fixes #40188 . See #50815 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48724 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 16:24:32 +00:00
Sergey Biryukov
21c0ed05c4
Comments: Use the existing static variable instead of calling ::has_items()
again in WP_Comments_List_Table::extra_tablenav()
.
...
Additionally, removed unnecessary `esc_html()` on the Filter button label. Core translations are considered safe, and this label is not escaped in any other instance.
Props whyisjake, SergeyBiryukov.
Fixes #40188 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48722 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 15:55:25 +00:00
Jake Spurlock
39be04b2c2
Help/About: String update for 5.5 release.
...
We don't use hyphens for the [block editor](https://make.wordpress.org/core/handbook/best-practices/spelling/ ).
See #50416 .
Props davidbaumwald, marybaum, desrosj.
git-svn-id: https://develop.svn.wordpress.org/trunk@48721 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 15:54:48 +00:00
Ella van Durpe
3bee99349a
Editor: update JS packages
...
Fixes #50841 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48719 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 13:41:37 +00:00
Andrea Fercia
48837a340d
Accessibility: Administration: Address backward compatibility concerns for the sortable postboxes areas after [48340].
...
Fixes #49288 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48717 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 13:15:52 +00:00
Sergey Biryukov
42dc935f9f
Media: Remove extra space from the width
attribute in wp_playlist_shortcode()
output.
...
Props hvar.
Fixes #50840 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48716 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 12:45:57 +00:00
Sergey Biryukov
59ed4cbfc1
Administration: Allow wp_credits()
to accept $version
and $locale
parameters.
...
This can be helpful for plugin developers to get credits information for older versions or different locales.
Props ramiy.
Fixes #35910 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48715 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-03 12:51:22 +00:00
Sergey Biryukov
35a4b7bc24
Docs: Correct placement for wp_editor_expand
filter DocBlock.
...
See #50768 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48714 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-03 12:09:34 +00:00
Sergey Biryukov
a5cb12dce1
Permalinks: Don't show "You should update your .htaccess
file now" message when saving permalink settings on Multisite.
...
Multisite routing is taken care of by WordPress, not by the web server.
Follow-up to [13706], [37747], [38066].
Props boonebgorges.
Fixes #39547 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48713 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-02 12:55:56 +00:00
Sergey Biryukov
b79a8c6194
Permalinks: Simplify the logic for displaying "You should update your .htaccess
file now" message.
...
See #39547 , #50834 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48712 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-02 12:49:08 +00:00
Sergey Biryukov
2c5ef0fc2f
Docs: Correct formatting for a comment in wp-admin/options-permalink.php
.
...
Previously committed in [48694], accidentally reverted in [48710].
See #50768 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48711 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-02 12:37:08 +00:00
Sergey Biryukov
7bc790c50a
Permalinks: Correct the check whether .htaccess
update is required when saving permalink settings.
...
The check should be performed after the permalink structure update, not before.
Fixes #50834 .
git-svn-id: https://develop.svn.wordpress.org/trunk@48710 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-02 12:34:05 +00:00