Helen Hou-Sandi
b27a8697d6
At long last, improved keyboard accessibility for the media modal.
...
props lessbloat, grahamarmfield, sharonaustin, bramd.
see #23560 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28607 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 03:38:31 +00:00
Andrew Ozz
139b5b3cb0
TinyMCE: update to 4.0.28. Also includes 43fff5b453
. Part-props avryl for the patch on #27941 , fixes #28391 , #27941 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28606 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 00:58:11 +00:00
Scott Taylor
32893ac7ea
Allow users to sort posts by type
in WP_Query
.
...
Props DeBAAT.
Fixes #28214 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28605 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 00:23:45 +00:00
Dominik Schilling (ocean90)
0af37cccdb
Pass $post->ID
to get_comments_number
filter.
...
Also fixes indentation and a typo in corresponding filter docs.
see #26240 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28604 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-28 22:35:21 +00:00
Sergey Biryukov
1140c47c30
Exclude 'test-image.bmp' from the list of non-displayable image types.
...
props atimmer.
fixes #28386 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28603 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-28 22:20:36 +00:00
Drew Jaynes (DrewAPicture)
d201ded99e
Fix parameter description for the $post_id
argument in get_comments_number()
to note that it is optional.
...
Also fixes the corresponding filter docs, as `$post_id`, not `$post` is passed to the filter.
See [27156]. Fixes #26240 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28602 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-28 22:04:59 +00:00
Andrew Nacin
0c7edb2045
Revert [28579] and [28582]. see #21963 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28601 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-28 18:13:55 +00:00
Sergey Biryukov
c73f5ef2de
Fix displaying taxonomies in bulk edit if the post type does not support titles.
...
props scribu.
fixes #16793 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28600 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-28 13:49:21 +00:00
Sergey Biryukov
2d420d52bb
Display Dashboard icon instead of the home icon in toolbar when the link leads to Dashboard.
...
props ghost1227.
fixes #26754 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28599 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-28 13:41:23 +00:00
Sergey Biryukov
98b4b63e40
Twenty Fourteen: Avoid passing an empty string to document.getElementById().
...
props nabil_kadimi.
fixes #28340 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28598 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-28 13:35:47 +00:00
Sergey Biryukov
5a8b1cfac2
Fix SlideShare oEmbed regex.
...
props kovshenin.
fixes #28380 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28597 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-28 13:31:22 +00:00
Scott Taylor
598e79479b
RIP Viddler oEmbed support.
...
More: https://gigaom.com/2014/02/07/viddler-gets-ready-to-delete-personal-videos/
See #28379 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28596 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 21:59:42 +00:00
Scott Taylor
d80969655c
Update the Scribd oEmbed pattern to more actually represent which endpoints from the site are discoverable.
...
See #28379 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28595 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 21:54:24 +00:00
Scott Taylor
0b209f55ee
When parsing an [embed]
shortcode into a TinyMCE view, don't attempt to append any returned <script>
s to the editor's <head>
. This affects only a few supported endpoints: Issuu and Twitter.
...
See #28195 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28594 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 19:59:47 +00:00
Scott Taylor
7eb0253744
For YouTube playlist oEmbed, we need keep BC for wp_oembed_remove_provider()
by not changing the existing YouTube endpoint keys. So, rather than merging the rules, the playlist endpoints should be on their own line.
...
Props kovshenin.
See #28125 , [28552].
git-svn-id: https://develop.svn.wordpress.org/trunk@28593 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 18:42:30 +00:00
Sergey Biryukov
7b133a336f
Remove obsolete code from wp_dashboard_setup().
...
props kitchin.
fixes #26604 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28592 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 15:40:19 +00:00
Sergey Biryukov
2f1ad4ddbf
Move 'Documentation on date and time formatting' link under the 'Time Format' block.
...
props gauravmittal1995.
fixes #28348 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28591 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 14:49:51 +00:00
Sergey Biryukov
b8b933418a
Pass anchor text to 'edit_post_link' and 'edit_comment_link' filters.
...
props kwight.
fixes #28373 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28590 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 13:42:27 +00:00
Sergey Biryukov
86b88bd2b7
Add BMP to the list of displayable image types.
...
props ericlewis.
fixes #26808 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28589 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 13:24:39 +00:00
Sergey Biryukov
a25a5de409
Update documentation for is_new_day().
...
props obenland.
fixes #28333 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28588 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 11:40:11 +00:00
Sergey Biryukov
c2076859eb
Remove redundant get_shortcode_regex() check.
...
props kovshenin.
see #28195 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28587 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 11:29:11 +00:00
Sergey Biryukov
6bca1ca960
Clean up wp_widget_rss_output():
...
* Fix appending […] to $summary.
* Use wp_trim_words() instead of wp_html_excerpt().
* Trim $title before checking if it's empty. props UmeshSingla.
* Use correct escaping function for $title.
fixes #28356 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28586 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 11:07:32 +00:00
Sergey Biryukov
9599dd9705
Avoid a PHP notice in bundled themes if no images were found.
...
props nabil_kadimi.
fixes #28361 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28585 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 10:54:54 +00:00
Sergey Biryukov
06bf55f809
Avoid a PHP notice in adjacent_image_link() if no images were found.
...
props nabil_kadimi.
see #28361 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28584 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 10:54:45 +00:00
Scott Taylor
4dd4a32cde
In wp_get_object_terms()
, before returning terms (and before running them through the 'wp_get_object_terms' filter) - run them through $terms = array_values( array_unique( $terms, SORT_REGULAR ) )
.
...
There will be "dupes" when the function is called with `'fields' => 'all_with_object_id'`, but the objects will actually be unique due to the `object_id` addition, so they shouldn't be filtered out.
Adds unit tests. All other unit tests pass.
Fixes #11003 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28583 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 03:28:05 +00:00
Scott Taylor
7f2cad1809
Fix some inline docs churn in wp_insert_post()
after [28579].
...
Props kpdesign.
See #21963 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28582 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-27 00:23:21 +00:00
Scott Taylor
792fe23675
When adding a URL in the Insert from URL
state in the media modal, attempt to show a preview of the content. Drop the unused width and height fields.
...
This will probably be iterated upon.
Props helen, jtsternberg, wonderboymusic.
See #15490 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28581 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-26 23:56:27 +00:00
Scott Taylor
8567bba0bf
Don't pass embeds through the_content()
when trying to render MCE previews, leverage WP_Embed
and do_shortcode()
instead.
...
Props kovshenin.
See #28195 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28580 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-26 23:42:08 +00:00
Scott Taylor
6cd28991e3
Combine wp_insert_attachment()
and wp_insert_post()
. wp_insert_attachment()
becomes a wrapper. Update inline docs.
...
Props wonderboymusic, DrewAPicture.
See #21963 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28579 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-26 23:19:03 +00:00
Scott Taylor
ef81c3fdba
Add oEmbed support for Mixcloud.
...
Props Jayjdk.
Fixes #27169 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28578 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-26 23:09:00 +00:00
Scott Taylor
5413bfc35a
Allow the settings view for galleries to be disabled when instantiating wp.media.controller.GalleryEdit
.
...
Props nd987.
Fixes #23116 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28577 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-26 22:48:56 +00:00
Andrew Ozz
92f79f5bcd
TinyMCE: fix saving the editor content on switching Visual -> Text, fixes #28353
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28576 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-25 22:46:06 +00:00
Sergey Biryukov
aa6d49590b
Fix typo in [28574].
...
see #28360 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28575 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-25 16:11:26 +00:00
Sergey Biryukov
508c1c1ae7
Replace $in_same_cat with $in_same_term in adjacent post functions for consistency.
...
props ixkaito.
fixes #28360 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28574 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-25 16:09:07 +00:00
Sergey Biryukov
95e42909a9
Suggest get_current_site() as an alternative for get_current_site_name().
...
props jesin.
fixes #28346 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28573 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-25 14:31:16 +00:00
Sergey Biryukov
191705a964
Fix inversed logic in Walker_Category::start_el(). see [28359].
...
Correct 'use_desc_for_title' parameter description.
see #26557 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28572 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-24 13:41:11 +00:00
Sergey Biryukov
90a40a07a1
Pass $post to 'protected_title_format' and 'private_title_format' filters.
...
props johnjamesjacoby, DrewAPicture.
fixes #23724 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28571 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-24 06:47:55 +00:00
Drew Jaynes (DrewAPicture)
cff4631f00
Add inline documentation for the option_none_value
argument added to wp_dropdown_users|categories()
in [28564].
...
Fixes #16625 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28570 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-24 05:38:06 +00:00
Drew Jaynes (DrewAPicture)
c4dc6180a5
Use three-digit x.x.x style version for @deprecated
phpDoc tags.
...
See #18298 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28569 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-24 05:22:34 +00:00
Andrew Ozz
8d02021b7c
TinyMCE: update to 4.0.26. Includes fixes for the 'paste' plugin (paste from Word/Excel, paste in WebKit/Blink), show/hide/isHidden in inline mode, drag/drop in tables and in Safari, and others. Fixes #28342 , #28016 , #28250 and #28067
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28568 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-24 01:43:16 +00:00
Scott Taylor
5c3f7d5392
In media_sideload_image()
, check the returned value of download_url()
earlier to avoid attempting to unlink()
an instance of WP_Error
.
...
Props georgestephanis.
Fixes #28204 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28567 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 21:32:12 +00:00
Scott Taylor
b2db40a694
Add unit tests for functions in wp-includes/category.php
.
...
Props mdbitz.
Fixes #28119 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28566 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 21:07:18 +00:00
Andrew Ozz
cfb7408e2a
wpView: fix selecting a view's text string in Safari, props gcorne, fixes #28088
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28565 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 20:55:53 +00:00
Scott Taylor
cd7d3f2ee8
wp_dropdown_pages()
allows option_none_value
to be passed. Add that arg to the $defaults
for wp_dropdown_users()
and wp_dropdown_categories()
as well.
...
Props solarissmoke.
Fixes #16625 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28564 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 20:46:18 +00:00
Scott Taylor
70f735669a
Replaces all uses of TEMPLATEPATH
and STYLESHEETPATH
in core with get_template_directory()
and get_stylesheet_directory()
.
...
Add `@deprecated` annotations to `TEMPLATEPATH` and `STYLESHEETPATH` definitions.
Props obenland, aaroncampbell.
Fixes #18298 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28563 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 20:11:08 +00:00
Scott Taylor
e2a124a911
When adding queries to tax_query
: if the query's field
is term_taxonomy_id
, don't require taxonomy
to be specified. In WP_Tax_Query::transform_query()
, $query['taxonomy']
is never checked for the 'term_taxonomy_id' case
because 'term_taxonomy_id' is the primary key being looked up.
...
Adds unit tests.
Props helen.
Fixes #25284 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28562 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 19:58:52 +00:00
Scott Taylor
a2b0c8b2e4
In get_terms_to_edit()
, call get_object_term_cache()
before priming cache with wp_get_object_terms()
.
...
In `get_inline_data()`, do the same.
On list table screens with taxonomies in the admin, this dramatically reduces the number of database queries (3x less). Even more so with a persistent object cache (5x less).
Props johnbillion, jeffstieler, wonderboymusic.
Fixes #18968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28561 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 19:28:45 +00:00
Scott Taylor
aa34ede226
Truly check for ! empty()
instead of falsey ''
when determining whether to add LIMIT
clause to SQL in wp_get_archives()
.
...
Props jjeaton for the initial patch.
Fixes #27834 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28560 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 18:27:10 +00:00
Scott Taylor
3b060c1931
Read the src
attribute for the [embed]
shortcode if the shortcode's body is empty.
...
These work:
`[embed src="https://www.youtube.com/watch?v=ZqD-LPOWIT0 "]`
`[embed src="https://www.youtube.com/watch?v=ZqD-LPOWIT0 "][/embed]`
If you do:
`[embed src="https://www.youtube.com/watch?v=ZqD-LPOWIT0 "]http://any-other-url.com[/embed] `
... "http://any-other-url.com " will be the URL that is parsed.
Props kovshenin, aaroncampbell for making initial patches.
Fixes #24456 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28559 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 18:05:24 +00:00
Scott Taylor
1061a15eaf
Allow get_comments_number()
to officially accept $post
or $post_id
. Adds unit tests.
...
Props coffee2code, JanHenkG.
Fixes #26240 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28558 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 17:43:03 +00:00