4415 Commits

Author SHA1 Message Date
Drew Jaynes
d615705cec Docs: Add a missing file header for wp-includes/class-wp-comment-query.php, introduced in [33750].
Also clarifies the class DocBlock summary and tags for `WP_Comment_Query`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33898 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 01:37:23 +00:00
Drew Jaynes
8cc0808e3b Docs: Clarify the file header summary for wp-includes/user.php, the top-level file for the core Users API.
Also adds inline DocBlocks for the `require_once()` calls that now bring in core users functionality and the `WP_User_Query` class, as of [33749].

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33897 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 01:32:59 +00:00
Drew Jaynes
68f62a46e5 Docs: Clarify the file header summary for wp-includes/user-functions.php, introduced in [33749].
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33896 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 01:28:10 +00:00
Drew Jaynes
8b3693c9e0 Docs: Add a missing file header for wp-includes/class-wp-user-query.php, introduced in [33749].
Also clarifies the class DocBlock summary for `WP_User_Query` to better describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33895 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-04 01:25:56 +00:00
Drew Jaynes
46af2b9cd9 Docs: Add complete file, class, property, and method documentation for the new WP_Comment class, introduced in [33891].
It's important for new functionality, especially something as significant as a new class to have complete documentation upon initial commit – not after the fact.

See #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@33893 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 19:57:15 +00:00
Sergey Biryukov
2487080654 Add missing translation functions to the error messages added in [33889].
props kraftbj, GaryJ.
fixes #33684.

git-svn-id: https://develop.svn.wordpress.org/trunk@33892 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 18:36:22 +00:00
Scott Taylor
60ba8b05e4 Introduce WP_Comment class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity.
* Takes inspiration from `WP_Post` and adds sanity to comment caching. 
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now

Props wonderboymusic, nacin.

See #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@33891 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 18:16:35 +00:00
Sergey Biryukov
71d4444ac7 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-includes/class-wp-customize-manager.php.
props kraftbj.
fixes #33684. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33889 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 09:20:40 +00:00
Sergey Biryukov
708cd13d77 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/users.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33679. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33885 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 08:53:23 +00:00
Drew Jaynes
03a85947ef Docs: Add inline DocBlocks for the require_once() calls that now bring in top-level HTTP API functionality and HTTP API classes.
Classes brought in from separate files now include:
* `WP_Http`
* `WP_Http_Streams`
* `WP_Http_Curl`
* `WP_HTTP_Proxy`
* `WP_Http_Cookie`
* `WP_Http_Encoding`

See #33413. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33882 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:46:27 +00:00
Drew Jaynes
febec2128e Docs: Clarify the file header summary for wp-includes/http.php, the top-level file for the HTTP Request API.
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33881 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:40:45 +00:00
Drew Jaynes
77a4ee7659 Docs: Add a missing file header for wp-includes/class-http.php.
Also clarifies the class DocBlock summary for `WP_Http` to more clearly describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33880 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:38:45 +00:00
Drew Jaynes
76f63a3b47 Docs: Clarify the file header summary for wp-includes/http-functions.php, introduced in [33748].
Also removes now-moot extra information from the file header description.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33879 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:36:24 +00:00
Drew Jaynes
608957f426 Docs: Add a missing file header to wp-includes/class-wp-http-streams.php, introduced in [33748].
Also clarifies the class DocBlock summary for `WP_Http_Streams` to better describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33878 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:32:54 +00:00
Drew Jaynes
572a9fa86b Docs: Add a missing file header to wp-includes/class-wp-http-proxy.php, introduced in [33748].
Also clarifies the class DocBlock summary for `WP_HTTP_Proxy` to better describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33876 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:29:39 +00:00
Drew Jaynes
81e8cc3d7e Docs: Add a missing file header for wp-includes/class-wp-http-encoding.php, introduced in [33748].
Also clarifies the class DocBlock summary for `WP_Http_Encoding`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33875 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:27:04 +00:00
Drew Jaynes
069668dde9 Docs: Add a missing file header for wp-includes/class-wp-http-curl.php, introduced in [33748].
Also clarifies the class DocBlock summary for `WP_Http_Curl` to better describe its purpose.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33874 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:22:15 +00:00
Drew Jaynes
b0ea6406a8 Docs: Add a missing file header to wp-includes/class-wp-http-cookie.php, introduced in [33748].
Also clarifies the summary in the class DocBlock for `WP_Http_Cookie`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33873 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:18:20 +00:00
Drew Jaynes
fba0e92dc6 Docs: Clarify the file header summary for wp-includes/widgets.php, the top-level file for the core Widgets API.
Also fixes some minor grammar issues in the file description.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33872 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 03:13:20 +00:00
Drew Jaynes
50d0b587f6 Docs: Clarify the file header summary for widget-functions.php, introduced in [33746].
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33871 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 02:57:10 +00:00
Drew Jaynes
f70c0d7080 Docs: Clarify the file header summary for class-wp-widget-factory.php, introduced in [33746].
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33870 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 02:53:19 +00:00
Drew Jaynes
4c5276edcf Docs: Improve the file header for class-wp-widget.php to describe what the file contains.
Also rewrites the class DocBlock summary for `WP_Widget` to better describe the '''purpose''' of the class.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@33869 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 02:49:39 +00:00
Drew Jaynes
b75e5cdfd8 Docs: Add a missing summary to the DocBlock for Walker::get_number_of_root_elements().
Props wen-solutions
See #33662.


git-svn-id: https://develop.svn.wordpress.org/trunk@33868 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 19:50:32 +00:00
Sergey Biryukov
50224510ec Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/edit.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33671. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33861 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 18:14:14 +00:00
John Blackbourn
65c7f9113d Correctly encode spaces in URLs passed to esc_url() instead of removing them.
Fixes #23605
Props enshrined, johnbillion


git-svn-id: https://develop.svn.wordpress.org/trunk@33858 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 17:19:29 +00:00
John Blackbourn
46c336e78a Introduce wp_removable_query_args(), which returns an array of single-use query variables which can be removed from a URL.
Also applies the function to the return URL when the Customizer is closed.

Fixes #32692
Props swissspidy, Mte90


git-svn-id: https://develop.svn.wordpress.org/trunk@33849 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 11:28:11 +00:00
DrewAPicture
62230a38e1 Docs: Add missing parameter documentation to the the DocBlock for WP_User::__set().
Props racase for the initial patch.
Fixes #33652.


git-svn-id: https://develop.svn.wordpress.org/trunk@33847 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 21:46:02 +00:00
Scott Taylor
a3e0e719d6 De-Jorbin [33814].
See #23012.


git-svn-id: https://develop.svn.wordpress.org/trunk@33845 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 15:47:16 +00:00
Sergey Biryukov
622032fece Make curly quotes in playlist item title translatable.
fixes #33391.

git-svn-id: https://develop.svn.wordpress.org/trunk@33844 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 13:49:57 +00:00
Scott Taylor
1e084b6eaa Move widget classes to their own files in wp-includes/widgets:
* `default-widgets.php` now requires all of the individual classes
* Move the functions scattered about this file to `widget-functions.php`, which loads before `default-widgets.php`, which only conditionally loads anyway in `wp_maybe_load_widgets()`, which is hooked on `plugins_loaded` 

See #33413, #23012.


git-svn-id: https://develop.svn.wordpress.org/trunk@33843 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 13:49:00 +00:00
Scott Taylor
f6ab99bc68 Add some JS docs to customize-base.js
Props ericlewis.
Fixes #33639.


git-svn-id: https://develop.svn.wordpress.org/trunk@33841 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 04:14:50 +00:00
Scott Taylor
99c34d57c1 User Settings: allow dashes in get|set_user_setting() in PHP and get|setUserSetting() in JS.
Add unit tests - there were none. Mock `set_user_setting()` since it won't run due to `headers_sent()` being `true`.

Fixes #22781.


git-svn-id: https://develop.svn.wordpress.org/trunk@33840 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 03:56:44 +00:00
Sergey Biryukov
3710226cf4 Correct @since version for [33838].
props JustinSainton.
see #23692.

git-svn-id: https://develop.svn.wordpress.org/trunk@33839 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 03:13:27 +00:00
Sergey Biryukov
357bd80a0b Add filters to feed_links() to choose whether to display the links to posts feed and comments feed, separately.
props joostdevalk, juliobox.
fixes #23692.

git-svn-id: https://develop.svn.wordpress.org/trunk@33838 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-01 02:45:58 +00:00
Weston Ruter
57a7ed15a7 Customizer: Collapse any expanded panel/sections before expanding other panel/sections
Fix removes need for workaround introduced in [33488] for direct link from nav menu widget to the customizer widgets panel. The todo is now implemented.

Props celloexpressions, westonruter.
Fixes #33396 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33837 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 23:07:57 +00:00
Andrew Ozz
0807da1bdd TinyMCE: disable the native fullscreen plugin on mobile devices by default.
Props iseulde. Fixes #33137;

git-svn-id: https://develop.svn.wordpress.org/trunk@33835 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 22:44:40 +00:00
Andrew Ozz
9c90fe1198 TinyMCE: fix replacing the image caption HTML with the shortcode when saving the content.
Fixes #33477.

git-svn-id: https://develop.svn.wordpress.org/trunk@33834 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 22:06:11 +00:00
John Blackbourn
e5eec20a25 Space out.
git-svn-id: https://develop.svn.wordpress.org/trunk@33831 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 21:24:27 +00:00
Drew Jaynes
f995a3cb96 Docs: Clarify the DocBlock summary for wp_create_nonce() to mention that nonce-creation is also now dependent on user tokens, as of [29221].
Also adds a changelog entry for when user tokens were introduced into the nonce-creation process.

Props ericlewis
Fixes #33636.


git-svn-id: https://develop.svn.wordpress.org/trunk@33827 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 20:49:49 +00:00
Scott Taylor
49923580bd WP_Widget_Pages::widget() has no reason to set $comment and $comments globals.
See #11566. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33824 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 20:30:32 +00:00
Scott Taylor
3028a096be Comments: wp_count_comments() can use get_comment_count() internally to makes its DB query, provided that get_comment_count() returns more properties.
Adds/updates unit tests. There were zero (0) unit tests for `wp_count_comments()`.

Fixes #19903. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33822 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-31 18:50:12 +00:00
Drew Jaynes
8aefa21974 Docs: Bring the file header and class DocBlock summaries for class-wp-widget.php in-line with the intention of the docs standard:
* File headers: _What_ the file is
* Class DocBlocks: What purpose the class serves. Mentioning the class name in the class DocBlock is redundant

See #33413


git-svn-id: https://develop.svn.wordpress.org/trunk@33816 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 23:13:45 +00:00
Konstantin Obenland
903b9af181 Themes: Get the correct theme when template and stylesheet were both passed as arguments.
Fixes a bug where `$new_theme` got set before the second argument was
appropriately handled, causing the `current_theme` option to later always be
updated to the parent theme's name.

Introduced in [21131].

Props obenland, wonderboymusic.
Fixes #32635.



git-svn-id: https://develop.svn.wordpress.org/trunk@33815 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 21:44:38 +00:00
Scott Taylor
e3a3ba4caa Improve/update escaping in default widgets:
* wrap some variables in `esc_attr()` before echoing
* replace some `strip_tags()` calls with `sanitize_text_field()`
* call `esc_url()` when wrapping some URLs

Props welcher.
See #23012.


git-svn-id: https://develop.svn.wordpress.org/trunk@33814 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 05:37:53 +00:00
Scott Taylor
5d91ddf4e1 Improve/update escaping in WP_Widget_Pages.
Props welcher.
See #23012.


git-svn-id: https://develop.svn.wordpress.org/trunk@33813 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 04:47:00 +00:00
Scott Taylor
062aa80c1f Fix the doc block syntax for the 'wp_get_current_commenter' filter.
Props dimadin.
Fixes #33304.


git-svn-id: https://develop.svn.wordpress.org/trunk@33811 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 03:20:24 +00:00
Scott Taylor
75998818a4 Fix copy pasta in wp_cache_decr() doc block.
Props danielbachhuber.
Fixes #33548.


git-svn-id: https://develop.svn.wordpress.org/trunk@33809 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 03:03:47 +00:00
Scott Taylor
905a612d88 Switching themes: if the new theme doesn't have nav_menu_locations defined, but the old theme does, copy the old theme's nav_menu_locations into the new theme's theme mods.
cc melchoyce

Fixes #18588.


git-svn-id: https://develop.svn.wordpress.org/trunk@33808 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 03:00:45 +00:00
Scott Taylor
c4b8ad087f Improve the reliability of the crop returned by image_get_intermediate_size().
Add a bunch of unit tests to `tests/image/intermediate_size.php`.

Props joemcgill, ericlewis, kitchin, SergeyBiryukov, chipbennett.
Fixes #17626.


git-svn-id: https://develop.svn.wordpress.org/trunk@33807 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 02:40:40 +00:00
Scott Taylor
da0a823129 get_comment_count() currently increments awaiting_moderation when comments are in the trash. This occurs because case 0: will match any value passed to switch that is a string that isn't specified in the list of cases. This is terrifying.
* Cases for `0` and `1` should be `'1'` and `'0'`
* Add unit tests for `get_comment_count()`. Currently, there are none.

See #33414.


git-svn-id: https://develop.svn.wordpress.org/trunk@33806 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-30 02:18:18 +00:00