sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
40,765 Commits 2 Branches 473 Tags 137 MiB
Commit Graph

40765 Commits

Author SHA1 Message Date
Sergey Biryukov bf3295d10f Administration: Correct font size for comment count in "At a Glance" dashboard widget on mobile. 
Props donmhico, jeremyfelt.
Fixes #48799.

git-svn-id: https://develop.svn.wordpress.org/trunk@46807 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-30 00:40:24 +00:00
Sergey Biryukov 4bd7b37ef9 Tests: Merge [24251] from `_wp_filter_build_unique_id()` to `_test_filter_build_unique_id()`, for consistency. 
See #47407.

git-svn-id: https://develop.svn.wordpress.org/trunk@46806 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-29 22:15:31 +00:00
Sergey Biryukov aacfec6734 Plugins: In `_wp_filter_build_unique_id()`, remove `$wp_filter` global and `$filter_id_count` static variable, unused since [46220]. 
See #47407, #48074.

git-svn-id: https://develop.svn.wordpress.org/trunk@46805 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-29 22:12:10 +00:00
Sergey Biryukov b5ed00dc82 REST API: Use strict `in_array()` checks for the list of usernames blacklisted via `illegal_user_logins` filter. 
See #48839.

git-svn-id: https://develop.svn.wordpress.org/trunk@46804 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-29 22:02:30 +00:00
Sergey Biryukov e3261b601f REST API: Use a strict `in_array()` check in `WP_REST_Request::get_parameter_order()`. 
See #48839.

git-svn-id: https://develop.svn.wordpress.org/trunk@46803 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-29 21:58:37 +00:00
Sergey Biryukov d50f672908 REST API: Use a strict `in_array()` check in `WP_REST_Meta_Fields::get_registered_fields()`. 
Props dkarfa.
Fixes #48839.

git-svn-id: https://develop.svn.wordpress.org/trunk@46802 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-29 21:57:09 +00:00
Sergey Biryukov 890bd870e8 Docs: Correct `@param` type for the function parameter in `tests_add_filter()` and `_test_filter_build_unique_id()`. 
Synchronize documentation for `add_filter()`, `tests_add_filter()`, `_wp_filter_build_unique_id()`, `_test_filter_build_unique_id()`.

Add a note that `$tag` and `$priority` are no longer used in `_wp_filter_build_unique_id()` since [46220], and the function always returns a string now.

Props donmhico, remcotolsma, SergeyBiryukov.
Fixes #47407. See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46801 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-29 21:40:58 +00:00
Sergey Biryukov a03bb54546 Docs: Replace `@returns` tags in JS docs with `@return`. 
Per the documentation standards, `@returns` is an unsupported synonym, `@return` should be used instead:
https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/

See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46800 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-29 17:59:47 +00:00
Sergey Biryukov ea5bfe134f Docs: Add missing full stops to `@returns` tags in JS docs, per the documentation standards. 
Props shital-patel, kalpshit.
Fixes #48305.

git-svn-id: https://develop.svn.wordpress.org/trunk@46799 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-29 16:55:01 +00:00
Sergey Biryukov 4b60e6a0db Site Health: Add a test for PHP default timezone. 
The test reports a failure if the default timezone was changed with `date_default_timezone_set()` to anything other than `UTC`.

WordPress historically uses `UTC` as the default timezone for calculating date and time offsets, overriding it is not recommended and can cause widespread and obscure issues.

Props Rarst, Clorith, TimothyBlynJacobs.
Fixes #48692.

git-svn-id: https://develop.svn.wordpress.org/trunk@46797 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-28 15:46:45 +00:00
Sergey Biryukov e720a9ddc7 Date/Time: Make `get_permalink()` more resilient against PHP timezone changes. 
Overriding default PHP timezone with `date_default_timezone_set()`, while not recommended, should not inadvertently result in changing existing permalinks.

Add a unit test.

Props Rarst, steevithak, archon810, maciejmackowiak, Ov3rfly, Cybr, hometowntrailers, scvleon, miette49.
Fixes #48623.

git-svn-id: https://develop.svn.wordpress.org/trunk@46795 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-28 13:40:19 +00:00
Sergey Biryukov 9737e5fdc3 KSES: Add support for gradient backgrounds. 
Props jorgefilipecosta.
Fixes #48376.

git-svn-id: https://develop.svn.wordpress.org/trunk@46793 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-28 00:27:21 +00:00
Sergey Biryukov 81581b537a Plugins: Correct default value of `$replacement` parameter in `do_action_deprecated()` and `apply_filters_deprecated()`. 
This addresses an inconsistency with `_deprecated_hook()`, which uses `is_null()` to check if `$replacement` was provided, however the previous default value was `false`.

Props shaampk1, felipeelia.
Fixes #48817.

git-svn-id: https://develop.svn.wordpress.org/trunk@46792 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-27 23:53:31 +00:00
Sergey Biryukov 2dc58b9118 Menus: Improve the wording of instructions for dragging the items into the preferred order. 
Props amolv, equin0x80, dlh.
Fixes #48184.

git-svn-id: https://develop.svn.wordpress.org/trunk@46791 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-27 19:49:24 +00:00
Sergey Biryukov 10d5efa604 Administration: Properly wrap long titles in list tables on smaller screens. 
Props mukesh27, iihglobal, wpamitkumar.
Fixes #48805.

git-svn-id: https://develop.svn.wordpress.org/trunk@46790 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-27 16:50:59 +00:00
Sergey Biryukov 993180b9c9 Users: Display admin email verification screen in user's locale instead of site locale. 
Props sathyapulse, TimothyBlynJacobs.
Fixes #48313.

git-svn-id: https://develop.svn.wordpress.org/trunk@46788 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-27 14:33:47 +00:00
Ian Belanger 43ecd78bd3 Bundled Themes: Fixes JS TypeError in Twenty Twenty. 
On mobile devices using a webkit browser, the menu and search modals could not be opened due to a `TypeError: document.body is null`. This commit fixes that issue by adding a `touch-enabled` class to the body for browsers that do not support media queries.

Props quicoto, poena, Boga86, acosmin, macmanx.
Fixes #48601.

git-svn-id: https://develop.svn.wordpress.org/trunk@46786 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-26 18:19:54 +00:00
Sergey Biryukov 4159a41cef Tests: Add `feed` group for `get_feed_build_date()` test added in [46756]. 
See #48675.

git-svn-id: https://develop.svn.wordpress.org/trunk@46785 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-26 16:17:02 +00:00
Dominik Schilling c2413a4711 Upgrade/Install: Provide a default label for "Continue" button in language selection form. 
Prevents an empty continue button if a translation isn't yet available.

Props sathyapulse.
Fixes #48776.

git-svn-id: https://develop.svn.wordpress.org/trunk@46784 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-26 15:17:30 +00:00
Sergey Biryukov 29f0d74599 Users: Use correct variable when displaying the Additional Capabilities list in user profile. 
Addresses a regression in [45926].

Props wpgurudev, aravindajith, anantajitjg, davidbaumwald.
Fixes #48725.

git-svn-id: https://develop.svn.wordpress.org/trunk@46782 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-25 13:59:02 +00:00
Sergey Biryukov 752d7496b4 Options, Meta APIs: Update `@since` version for the `$force_cache` parameter added for `wp_load_alloptions()` in [46753] to 5.3.1. 
See #31245.

git-svn-id: https://develop.svn.wordpress.org/trunk@46779 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-25 13:42:22 +00:00
Sergey Biryukov 7dfb911b7b Media: Avoid a PHP notice in `image_downsize()` when trying to replace a non-image URL with a rendered image from its meta. 
Props Mte90, jrf, hareesh-pillai.
Fixes #48324.

git-svn-id: https://develop.svn.wordpress.org/trunk@46772 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-25 10:05:39 +00:00
SergeyBiryukov dc486308e6 Accessibility: Administration: Underline links on Dashboard that are located within a line of text and thus need to be underlined: 
* "change your theme completely"
* Active theme in the "At a Glance" box
* "View all drafts" in the Quick Draft box

Split "Manage widgets or menus" into separate items for consistency with other links.

For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished.

Per accessibility coding standards:
> When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#links-underline-or-no-underline
https://make.wordpress.org/accessibility/handbook/design/use-of-color/#not-by-color-alone

Props afercia, audrasjb, karmatosed.
Fixes #48406.

git-svn-id: https://develop.svn.wordpress.org/trunk@46770 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-24 19:55:01 +00:00
Sergey Biryukov 5e801fe58e Twenty Twenty: Remove duplicate array key/value in `TwentyTwenty_Non_Latin_Languages::get_non_latin_css()`. 
Props manikmist09.
Fixes #48624.

git-svn-id: https://develop.svn.wordpress.org/trunk@46765 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-24 10:53:40 +00:00
Sergey Biryukov 29ff549800 Coding Standards: Fix WPCS issue in [46763]. 
See #48777.

git-svn-id: https://develop.svn.wordpress.org/trunk@46764 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-23 19:19:57 +00:00
Sergey Biryukov fec3976927 Docs: Add missing `@since` tags for functions in `wp-admin/includes/update.php`. 
Props sathyapulse, zodiac1978.
Fixes #48777.

git-svn-id: https://develop.svn.wordpress.org/trunk@46763 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-23 18:49:59 +00:00
Sergey Biryukov c5d880c616 Twenty Twenty: Correctly align the author bio and bottom post meta on single posts on mobile. 
Props nielslange, Anlino.
Fixes #48619.

git-svn-id: https://develop.svn.wordpress.org/trunk@46762 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-23 14:52:13 +00:00
Sergey Biryukov 29e97b7b0c Embeds: Remove CollegeHumor oEmbed provider, as the service does not exist anymore. 
Props audrasjb, youknowriad.
Fixes #48696.

git-svn-id: https://develop.svn.wordpress.org/trunk@46761 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-23 10:13:32 +00:00
Sergey Biryukov b718cc0252 Docs: Adjust `wp_is_json_request()` and `wp_is_xml_request()` return value descriptions for consistency. 
See #48771, #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46760 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-22 18:26:41 +00:00
Sergey Biryukov 7551c2b47d Docs: Correct spelling and capitalization in `wp-includes/load.php`: 
* Fix typo in `is_blog_admin()` description.
* Capitalize PHP correctly in `enable_wp_debug_mode_checks` filter description.
* Capitalize XML correctly in `wp_is_xml_request()` return value description.

Props stevegrunwell.
Fixes #48771.

git-svn-id: https://develop.svn.wordpress.org/trunk@46759 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-22 18:14:45 +00:00
Sergey Biryukov 206ea67257 Editor: Improve the appearance of tag cloud in Tags meta box in classic editor. 
Props sathyapulse, Spaceshipone, tmatsuur, audrasjb, afercia.
Fixes #48592.

git-svn-id: https://develop.svn.wordpress.org/trunk@46758 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-22 00:02:12 +00:00
Sergey Biryukov 172f434332 Date/Time: Correct the time format in `get_feed_build_date()` to use 24-hour format. 
Follow-up to [46756].

See #48675.

git-svn-id: https://develop.svn.wordpress.org/trunk@46757 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-21 16:25:38 +00:00
Sergey Biryukov 6ce8175456 Date/Time: Remove `mysql2date()` usage in `get_feed_build_date()` to ensure the output includes correct timezone offset. 
With the changes in [45908], `mysql2date()` works correctly for all local time inputs, but should not be used for UTC time inputs.

Add a unit test.

Props Rarst, lisota.
Fixes #48675.

git-svn-id: https://develop.svn.wordpress.org/trunk@46756 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-21 13:16:50 +00:00
Sergey Biryukov 065a181fc0 I18N: Correct translator comment for `By %s` string in Plugins list table. 
Follow-up to [44541].

See #45898.

git-svn-id: https://develop.svn.wordpress.org/trunk@46755 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-21 00:06:32 +00:00
Sergey Biryukov 3b54ab37ed Customize: If the return URL for Close button is a page added to the Appearance menu by a deactivated theme, fall back to the Themes screen. 
Props JarretC, Jean-David, SergeyBiryukov.
Fixes #46686.

git-svn-id: https://develop.svn.wordpress.org/trunk@46754 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-20 18:47:08 +00:00
Sergey Biryukov 071030b793 Options, Meta APIs: Avoid a race condition causing the first of two subsequent requests updating different options at the same time to lose changes. 
Every time an autoloaded option is updated or deleted, the `alloptions` cache is similarly updated. Due to the race condition, on any autoloaded option being updated, every other autoloaded option had its value set to the value at load time, causing a mismatch between the data in the persistent cache and the database.

This change introduces a `$force_cache` parameter for `wp_load_alloptions()` to force an update of the local `alloptions` cache from the persistent cache when an option is added, updated, or deleted, to minimize the chance of affecting other options.

Props fabifott, rmccue, tollmanz, johnjamesjacoby, spacedmonkey, dd32, jipmoors, tellyworth, jeremyclarke, joehoyle, boonebgorges, danielbachhuber, flixos90, jeichorn, mihdan, Grzegorz.Janoszka, SergeyBiryukov.
See #31245.

git-svn-id: https://develop.svn.wordpress.org/trunk@46753 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-20 13:40:39 +00:00
Sergey Biryukov 54e2c8ccb0 Docs: Fix typo in `README.md`. 
Props dkarfa.
Fixes #48737.

git-svn-id: https://develop.svn.wordpress.org/trunk@46752 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-20 08:31:32 +00:00
Sergey Biryukov 2d097fd6b8 Docs: Clarify that `WP_Theme::get()`, `::display()`, and several related methods treat the `Tags` theme header as an array. 
Props david.binda.
Fixes #48005.

git-svn-id: https://develop.svn.wordpress.org/trunk@46751 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-20 08:29:36 +00:00
Sergey Biryukov 944502a094 XML-RPC: Pass correct variable as the URL parameter to `http_headers_useragent` filter in `wp_xmlrpc_server::pingback_ping()`. 
Props wpgurudev, andreaitm.
Fixes #48721. See #42186.

git-svn-id: https://develop.svn.wordpress.org/trunk@46750 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-19 11:05:08 +00:00
Sergey Biryukov af941d438c Login and Registration: Pass `$user_data` parameter to the `lostpassword_post` action in `retrieve_password()`. 
Props wpgurudev, pagewidth, lukecavanagh, johnbillion, kkarpieszuk.
Fixes #38334.

git-svn-id: https://develop.svn.wordpress.org/trunk@46749 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-19 09:59:19 +00:00
Andrea Fercia 82e352e412 Accessibility: Media: Add an `aria-pressed` attribute to active button within a button group. 
The `aria-pressed` attribute communicates semantically the "active" state of buttons that otherwise only look "active".

Fixes #48355.


git-svn-id: https://develop.svn.wordpress.org/trunk@46748 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-18 22:21:26 +00:00
Sergey Biryukov 4ebaf2b2d2 Twenty Twenty: Fix typos in a variable name and inline comment in `assets/js/color-calculations.js`. 
Props tanvirul.
Fixes #48704.

git-svn-id: https://develop.svn.wordpress.org/trunk@46747 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-18 17:05:23 +00:00
Andrea Fercia 5e574eb45f Accessibility: Add an `aria-current` attribute to the Media Library switch links. 
The `aria-current` attribute is a simple, effective, way to help assistive technology users orientate themselves within a set of items.

Props mayanksonawat, afercia.
Fixes #48271.


git-svn-id: https://develop.svn.wordpress.org/trunk@46746 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-18 16:49:42 +00:00
Andrea Fercia 72e66c100e Widgets: Avoid to move focus to the Image Widget "Insert from URL" field. 
Fixes a bug after [45499], where the backbone view element isn't the input field any longer. Also, managing focus programmatically is often an assumption on a specific user flow and should generally be avoided, see #43169.

Props dufresnesteven.
See #43169.
Fixes #48588.


git-svn-id: https://develop.svn.wordpress.org/trunk@46745 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-18 16:21:37 +00:00
Sergey Biryukov 22eb74c67b Administration: Switch `rgb()` CSS property for paused plugin error message in Plugins list table to `rgba()`. 
While technically correct as is, the latter is more consistent with other admin styles and causes less confusion.

Props manikmist09.
Fixes #48629.

git-svn-id: https://develop.svn.wordpress.org/trunk@46744 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-18 13:16:54 +00:00
Sergey Biryukov f64a6a8da7 Taxonomy: Correct the initial value for `WP_Taxonomy::$labels` to match `get_taxonomy_labels()` return type. 
Improve documentation for consistency with `WP_Post_Type::$labels`.

Props alpipego.
Fixes #48681.

git-svn-id: https://develop.svn.wordpress.org/trunk@46743 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-18 07:57:47 +00:00
Sergey Biryukov e68601875e Docs: Update broken source code link in `WP_Filesystem_SSH2` class. 
Props mryoga, finchps.
Fixes #48467.

git-svn-id: https://develop.svn.wordpress.org/trunk@46742 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-17 16:14:37 +00:00
Sergey Biryukov 8781a41915 Docs: Update broken source code link in `imgAreaSelect` jQuery plugin. 
Props mryoga, finchps.
See #48467.

git-svn-id: https://develop.svn.wordpress.org/trunk@46741 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-17 16:12:43 +00:00
Sergey Biryukov b99845db25 Docs: Replace Codex URLs with corresponding HelpHub articles in `wp-config-sample.php`. 
Props sebastienserre.
Fixes #48680.

git-svn-id: https://develop.svn.wordpress.org/trunk@46740 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-17 11:09:05 +00:00
Sergey Biryukov 7bb2a562a6 Docs: Correct spelling of "subclass" and "overridden" in various docblocks and error messages. 
Props garrett-eclipse.
Fixes #48676.

git-svn-id: https://develop.svn.wordpress.org/trunk@46739 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-17 07:41:49 +00:00