Commit Graph

42234 Commits

Author SHA1 Message Date
Sergey Biryukov
bfc5c53189 Editor: Correctly back up the global $post in wp-admin/edit-form-blocks.php.
To create a copy of the object, instead of a reference to the same object, the `clone` keyword should be used.

Props scarolan.
Fixes #50775.

git-svn-id: https://develop.svn.wordpress.org/trunk@48700 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-31 13:58:09 +00:00
Sergey Biryukov
e95d64569c Widgets: Use correct escaping function in WP_Widget_Archives::widget().
Props chintan1896, afercia.
See #50826.

git-svn-id: https://develop.svn.wordpress.org/trunk@48699 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-31 13:13:36 +00:00
Jake Spurlock
6d3207d564 Upgrade/Install: Pass the plugin file path into the plugin_auto_update_debug_string filter.
Adds better tooling for when user specific plugins can be updated, but platform specific ones cannot.

Fixes #50821.
Props bpayton, pbiron, audrasjb, SergeyBiryukov, whyisjake. 



git-svn-id: https://develop.svn.wordpress.org/trunk@48696 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-30 21:48:19 +00:00
John Blackbourn
1c6ca0998c Docs: Various fixes and improvements to inline documentation.
See #49572

git-svn-id: https://develop.svn.wordpress.org/trunk@48695 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-30 19:12:02 +00:00
Sergey Biryukov
2ec18b9d8e Docs: Correct formatting for a comment in wp-admin/options-permalink.php.
See #50768.

git-svn-id: https://develop.svn.wordpress.org/trunk@48694 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-30 14:00:59 +00:00
Sergey Biryukov
a7e5570da6 Comments: Pass the $which parameter to the manage_comments_nav action.
This brings some consistency with the  `manage_users_extra_tablenav` and `manage_users_extra_tablenav` actions.

Props Tkama, wpgurudev.
Fixes #50736.

git-svn-id: https://develop.svn.wordpress.org/trunk@48693 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-30 13:25:10 +00:00
Sergey Biryukov
bee24dc17c I18N: Use a placeholder instead of the \ character in a translatable string in WP_REST_Users_Controller::check_user_password().
Props ramiy.
Fixes #50812.

git-svn-id: https://develop.svn.wordpress.org/trunk@48692 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-30 12:26:45 +00:00
Sergey Biryukov
e53aaaeead Themes: Pass correct variable to is_php_version_compatible() in wp_theme_update_row().
This applies to the Themes screen in Multisite network admin.

Follow-up to [48660].

Props pbiron, afragen.
Fixes #48507. See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@48689 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-29 21:06:47 +00:00
Jake Spurlock
20ac5dd62d Upgrade/Install: Only show auto-update for themes that support the feature.
Similar to the changes for plugins in [48669], let's only show the UI for themes when updates are supported for that theme.

See #50280.
Props dd32.


git-svn-id: https://develop.svn.wordpress.org/trunk@48688 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-29 19:59:30 +00:00
SergeyBiryukov
a4927249a8 Help/About: Adjust two strings on the About page for better i18n.
Follow-up to [48675].

Props ocean90, audrasjb, kittmedia, nao.
See #50416.

git-svn-id: https://develop.svn.wordpress.org/trunk@48686 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-29 13:27:02 +00:00
Sergey Biryukov
c1101f08d5 Upgrade/Install: Pass correct argument to clear_destination in Theme_Upgrader::install().
Follow-up to [48390].

Props afragen, sabernhardt.
Fixes #9757.

git-svn-id: https://develop.svn.wordpress.org/trunk@48685 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-29 13:07:35 +00:00
Sergey Biryukov
014b40e623 Media: Pass the $rel parameter to image_send_to_editor filter.
Props mihdan, pputzer.
Fixes #50765.

git-svn-id: https://develop.svn.wordpress.org/trunk@48684 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 21:19:53 +00:00
Sergey Biryukov
7aae3c7bbf Trunk is now 5.6 alpha.
git-svn-id: https://develop.svn.wordpress.org/trunk@48683 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 20:54:37 +00:00
Jake Spurlock
ed82e57f8c Post WordPress 5.5 RC 1 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@48681 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 19:13:41 +00:00
Jake Spurlock
14e896dace WordPress 5.5 RC 1.
git-svn-id: https://develop.svn.wordpress.org/trunk@48680 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 18:52:06 +00:00
Jake Spurlock
ce675c0d50 WordPress 5.5 RC 1.
git-svn-id: https://develop.svn.wordpress.org/trunk@48679 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 18:48:51 +00:00
Jake Spurlock
355152a599 Upgrade/Install: Swap auto-update-supported to update-supported in update checks.
Ensures backwards compatability with external updaters.

See #50280.
Props everyone-in-the-core-updates-channel. 



git-svn-id: https://develop.svn.wordpress.org/trunk@48678 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 18:26:58 +00:00
Jonathan Desrosiers
0848bbf334 Upgrade/Install: Clarify the descriptions for install_(plugin|theme)_overwrite_actions.
See #9757.

git-svn-id: https://develop.svn.wordpress.org/trunk@48677 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 18:14:03 +00:00
Jonathan Desrosiers
b60cf9ca31 Upgrade/Install: Correct spelling of “overwrite” in new hooks and array indexes.
See #9757.

git-svn-id: https://develop.svn.wordpress.org/trunk@48676 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 17:54:52 +00:00
Jake Spurlock
29b8823767 Help/About: WordPress 5.5 About Page.
Speed. Search. Security.

This is the start of the WordPress 5.5 about page. 

Fixes #50416. 
Props ryelle, marybaum, estelaris, yvettesonneveld, michelebutcher-jones, metalandcoffee, melchoyce, marktimemedia, abhanonstopnewsuk, elmastudio, davidbaumwald, audrasjb, afercia, cbringmann, andreamiddleton, desrosj, earnjam, SergeyBiryukov, whyisjake, elrae.


git-svn-id: https://develop.svn.wordpress.org/trunk@48675 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 17:43:50 +00:00
Sergey Biryukov
57f9a2c10f Login and Registration: Correct the logic for determining the path to wp-login.php in wp_lostpassword_url().
Follow-up to [48672], [48673].

See #39311.

git-svn-id: https://develop.svn.wordpress.org/trunk@48674 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 17:42:44 +00:00
Sergey Biryukov
d1ef380858 Login and Registration: Only call get_blog_details() in wp_lostpassword_url() on Multisite.
The function does not exist on single site.

Follow-up to [48672].

See #39311.

git-svn-id: https://develop.svn.wordpress.org/trunk@48673 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 17:38:37 +00:00
Sergey Biryukov
087d11282a Login and Registration: Link to the correct site after activating a user on a Multisite install in subdirectory mode.
Props pkarjala, Mista-Flo, tmoore41, Ipstenu, ksoares, mukesh27, whyisjake.
Fixes #39311.

git-svn-id: https://develop.svn.wordpress.org/trunk@48672 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 17:18:06 +00:00
Sergey Biryukov
0dd3bd3b8b Administration: Correct alignment of the "PHP Update Required" dashboard box title.
Restore one instance of `!important` CSS rule for backward compatibility.

Follow-up to [48129], [48373].

Props whyisjake, sabernhardt, TimothyBlynJacobs, SergeyBiryukov.
Fixes #50788.

git-svn-id: https://develop.svn.wordpress.org/trunk@48671 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 17:06:52 +00:00
Sergey Biryukov
d3614d49fe Administration: Don't override the $mode global in WP_Screen::render_view_mode() if it's already set.
Follow-up to [48398], [48423], [48424], [48450].

See #49715.

git-svn-id: https://develop.svn.wordpress.org/trunk@48670 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 16:53:03 +00:00
Jake Spurlock
af4127ab84 Upgrade/Install: Enhance auto-updates to be disabled for plugins that don't suport updates.
This removes the toggle UI when updates aren't available. When plugins use the filter, the UI is updated to show that they are being controlled via code. And then removed entirely when not available.

See #50798.
Fixes #50280.

Props elrae, pbiron, SergeyBiryukov, audrasjb, azaozz, StephenCronin, whyisjake, dd32, TimothyBlynJacobs, desrosj.



git-svn-id: https://develop.svn.wordpress.org/trunk@48669 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 16:30:48 +00:00
Sergey Biryukov
828d287cab Administration: Pull the table_view_mode filter for now.
The extensibility of list table view modes will be explored in a future release.

Props audrasjb.
See #49715.

git-svn-id: https://develop.svn.wordpress.org/trunk@48668 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 16:17:13 +00:00
Sergey Biryukov
18f5561dfd Upgrade/Install: Disable the plugin/theme auto-updates UI if AUTOMATIC_UPDATER_DISABLED is defined and set as true.
Props pbiron, dd32.
Fixes #50798. See #50280.

git-svn-id: https://develop.svn.wordpress.org/trunk@48667 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 16:13:03 +00:00
Sergey Biryukov
9636a9d4d7 Upgrade/Install: Check WordPress and PHP version requirements when uploading a plugin or theme from ZIP file.
Props mariovalney, desrosj.
See #50593.

git-svn-id: https://develop.svn.wordpress.org/trunk@48666 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 16:05:39 +00:00
Sergey Biryukov
cded42aa94 Taxonomy: Rename the default_taxonomy_$taxonomy option key to default_term_$taxonomy.
This better reflects the purpose of the option.

Follow-up to [48356], [48480].

See #43517.

git-svn-id: https://develop.svn.wordpress.org/trunk@48665 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 15:40:35 +00:00
Sergey Biryukov
2547c15fee Coding Standards: Reformat a condifion for default taxonomy terms in map_meta_cap() for better readability.
Follow-up to [48356], [48480].

See #43517.

git-svn-id: https://develop.svn.wordpress.org/trunk@48664 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 14:40:06 +00:00
Sergey Biryukov
6e66f08ec9 Taxonomy: Ensure the child_of argument of get_terms() works as expected with 'fields' => 'id=>name' or 'id=>slug'.
Props Howdy_McGee, deepaklalwani, planvova.
Fixes #46768.

git-svn-id: https://develop.svn.wordpress.org/trunk@48663 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 14:21:54 +00:00
Sergey Biryukov
faa6036d08 Bootstrap/Load: Remove the wp_environment_type and wp_get_environment_type filters.
Since `wp_get_environment_type()` runs too early for plugins to hook these filters, and the result is then cached in a static variable and cannot be changed later, the filters are not that useful.

The `WP_ENVIRONMENT_TYPES` and `WP_ENVIRONMENT_TYPE` constants and environment variables should be enough for now.

Follow-up to [47919], [48188], [48372].

Props Clorith, SergeyBiryukov.
Fixes #33161.

git-svn-id: https://develop.svn.wordpress.org/trunk@48662 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 12:08:41 +00:00
Sergey Biryukov
ae65f096b0 Docs: Add missing documentation for various upgrade/install class properties and methods.
Props ramiy.
Fixes #42923.

git-svn-id: https://develop.svn.wordpress.org/trunk@48661 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 11:55:19 +00:00
Sergey Biryukov
deb78bdf1c Themes: Display a message on Themes list table if a theme update requires a higher version of PHP or WordPress.
This applies to the Themes screen in Multisite network admin.

Props afragen, SergeyBiryukov.
Fixes #48507. See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@48660 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 11:32:53 +00:00
Sergey Biryukov
d67c469b0d Themes: Include theme name in available update messages, for better accessibility and consistency with other similar messages.
Follow-up to [48652-48654].

See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@48659 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 11:29:28 +00:00
Sergey Biryukov
b7a5c75686 Docs: Document that various metadata functions return false for an invalid ID.
Props salcode.
See #40519.

git-svn-id: https://develop.svn.wordpress.org/trunk@48658 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 10:13:50 +00:00
Mike Schroder
81c39e949f Upgrade/Install: Improve wp_opcache_invalidate() performance.
Changes from using `preg_match()` based `.php` extension checking to using `substr()` in `wp_opcache_invalidate()`.

Props jnylen0, aaroncampbell, SergeyBiryukov, desrosj, mikeschroder.
Fixes #50784.

git-svn-id: https://develop.svn.wordpress.org/trunk@48657 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 08:07:04 +00:00
Timothy Jacobs
b29101aca0 REST API: Remove assets field from block directory controller.
Gutenberg no longer uses the assets field to fetch the assets for the installed block so this field can be dropped from the endpoint. This allows us to reintroduce it at a later point without needing to worry about backward compatibility.

See #50732.


git-svn-id: https://develop.svn.wordpress.org/trunk@48656 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 04:08:56 +00:00
Jake Spurlock
5bb5053127 Site Health: Incorrect file path in require_once.
Ensure that background updater can be loaded for testing to see if auto-updates can enable automatic updates.

Fixes #50793.
Props dd32.


git-svn-id: https://develop.svn.wordpress.org/trunk@48655 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 02:19:17 +00:00
Sergey Biryukov
6f79ff4d1c Themes: Display a message in theme updates list if an update requires a higher version of PHP or WordPress.
This applies to the WordPress Updates screen.

Props afragen, SergeyBiryukov.
Fixes #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@48654 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 01:00:40 +00:00
Sergey Biryukov
d29535c25e Themes: Correct the logic for displaying a message in theme grid if a theme update requires a higher version of PHP or WordPress.
This applies to the Themes screen fallback used when JS is turned off.

Follow-up to [48652].

See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@48653 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 00:41:56 +00:00
Sergey Biryukov
7ea44b5add Themes: Display a message in theme grid and Theme Details modal if a theme update requires a higher version of PHP or WordPress.
This applies to the Themes screen and the Customizer theme browser.

Props afragen, SergeyBiryukov.
See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@48652 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 00:08:00 +00:00
Sergey Biryukov
72dfc468c5 Docs: Correct alignment for some parameters in JS documentation.
Follow-up to [48650].

See #43828.

git-svn-id: https://develop.svn.wordpress.org/trunk@48651 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 00:05:59 +00:00
Jake Spurlock
9ed92faaca Build/Test Tools: Enable JSDocs to be linted with ESLint.
As part of the [Javascript Inline Docs Initiative](https://make.wordpress.org/core/handbook/docs/inline/js/) this add some tooling to lint Javascript docblocks. Two new commands:

* `npm run lint:jsdoc`
* `npm run lint:jsdoc:fix`

The latter will run the linter and try to fix an possible issues automatically.

Fixes #43828.
Props netweb, atimmer, kamataryo, whyisjake.



git-svn-id: https://develop.svn.wordpress.org/trunk@48650 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 23:33:51 +00:00
Sergey Biryukov
a1a1173250 Docs: Correct description for wp_filter_content_tags() per the documentation standards.
DocBlocks should start with a brief, one sentence explanation of the purpose of the function spanning a maximum of two lines.

Follow-up to [48648].

See #44427.

git-svn-id: https://develop.svn.wordpress.org/trunk@48649 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 21:47:18 +00:00
Andrew Ozz
3e1083a37e Media: Improve inline docs for wp_filter_content_tags().
Props johnstonphilip.
See #44427.

git-svn-id: https://develop.svn.wordpress.org/trunk@48648 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 21:04:34 +00:00
Jake Spurlock
c230d7a07c Post WordPress 5.5 Beta 4 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@48647 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 20:59:03 +00:00
Jake Spurlock
92521657af WordPress 5.5 Beta 4.
git-svn-id: https://develop.svn.wordpress.org/trunk@48646 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 20:38:25 +00:00
Jake Spurlock
8c9b33c3b6 Mail: PHPMailer swap to use is_email for the default validator.
Prior to the PHPMailer update in 5.5, old version of the PHPMailer was setting the validator to 'auto' resulting in a sophisticated logic for determining what email address validation should be used. But the new version defaults to 'php', possibly leading to rejection of email addresses which were fine prior to the upgrade. Let's use the WordPress core function `is_email()` so that it can be fully pluggable.

Fixes #50720.
Props david.binda, ayeshrajans, Synchro, SergeyBiryukov, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/trunk@48645 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 20:17:36 +00:00