sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
31,608 Commits 2 Branches 473 Tags 137 MiB
c8f167629d
Commit Graph

8096 Commits

Author SHA1 Message Date
Scott Taylor
90fb9480d1 Widgets: Make the categories widget work with custom taxonomies. 
Props fonglh, wonderboymusic, DrewAPicture, kucrut.
Fixes #21165.


git-svn-id: https://develop.svn.wordpress.org/trunk@34376 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:24:53 +00:00
Scott Taylor
5dd7bec848 Multisite: as a precaution, make wp-json a reserved subdirectory name. 
Props austinginder.
Fixes #33789.


git-svn-id: https://develop.svn.wordpress.org/trunk@34375 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:20:41 +00:00
wonderboymusic
70b90490fd Media: In wp_read_image_metadata(), include IPTC Keywords when available in $meta. 
Adds unit test.

Props swissspidy, dbru, SteveHoneyNZ.
Fixes #33772.


git-svn-id: https://develop.svn.wordpress.org/trunk@34374 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:18:02 +00:00
Scott Taylor
1352d3473a Media: Add new functions, get_the_post_thumbnail_url() and the_post_thumbnail_url(). 
Adds unit tests.

Props dipesh.kakadiya, swissspidy, atomicjack.
Fixes #33070.


git-svn-id: https://develop.svn.wordpress.org/trunk@34373 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:14:15 +00:00
Scott Taylor
3c0ecff16e Media: Add a new function, wp_get_attachment_image_url(), which is a shortcut for wp_get_attachment_image_src() - same function signature, but returns just the URL based on $size. 
Adds unit test.

Props dipesh.kakadiya, swissspidy, sebastian.pisula.
Fixes #33878.


git-svn-id: https://develop.svn.wordpress.org/trunk@34372 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:12:44 +00:00
Scott Taylor
8a33422bfc Passwords: fix the markup on the Reset Password Form for user-pass1 so the JavaScript operates properly. 
Props ldinclaux.
See #33892.
Fixes #33908.


git-svn-id: https://develop.svn.wordpress.org/trunk@34371 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 03:56:25 +00:00
Scott Taylor
f9d1856805 Help Tabs: when returning help tabs, return them in order of priority, but also return the items in each priority in the order that they were added. 
Fixes #33941.


git-svn-id: https://develop.svn.wordpress.org/trunk@34370 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 03:36:27 +00:00
Scott Taylor
e75c7651b2 HTTP: Add some new Cookie helper functions: 
* `wp_remote_retrieve_cookies( $response )`
* `wp_remote_retrieve_cookie( $response, $name )`
* `wp_remote_retrieve_cookie_value( $response, $name )`

Adds unit tests.

Props johnbillion.
Fixes #33711.


git-svn-id: https://develop.svn.wordpress.org/trunk@34369 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 03:13:13 +00:00
Drew Jaynes
782b9085c9 Docs: Move a duplicate hook comment accidentally left behind when its corresponding filter was relocated in [31765]. 
See #31443. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34368 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 23:12:35 +00:00
Konstantin Obenland
3cd12045d3 Introduce template functions for comment navigation: 
* `get_the_comments_navigation()` and `the_comments_navigation()` for navigation to the next and previous page of comments.
* `get_the_comments_pagination()` and `the_comments_pagination()` for paginated navigation between pages of comments. Uses `paginate_comments_links()`.

This reduces the need for themes to define their own sets of comment navigation
functions, like Twenty Fifteen and others.
Completes the navigation template tag API started in #29808 for posts.

Fixes #30589.



git-svn-id: https://develop.svn.wordpress.org/trunk@34367 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 16:31:19 +00:00
Scott Taylor
c34e94b693 Docs: is_main_query()'s _doing_it_wrong() notice suggests using WP_Query statically (WP_Query::is_main_query()). Use an alternate syntax: WP_Query->is_main_query(), to not confuse. 
Props DrewAPicture, micahwave.
Fixes #25680.


git-svn-id: https://develop.svn.wordpress.org/trunk@34366 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 15:30:49 +00:00
Helen Hou-Sandi
9aaa278e02 Notices: Add styles for use against white backgrounds. 
These colored backgrounds can be accessed by adding the `.notice-alt` class to a notice.

There is also now a large version when using the `.notice-large` class, and a `.notice-title` class that is appropriate for headline text within a large notice.

props paulwilde, hugobaeta, melchoyce.
fixes #32244.


git-svn-id: https://develop.svn.wordpress.org/trunk@34365 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 15:25:37 +00:00
Scott Taylor
2b3347332e Meta Boxes: In post_categories_meta_box(), convert some spaces to tabs. 
Props miyauchi.
Fixes #33945.


git-svn-id: https://develop.svn.wordpress.org/trunk@34364 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 15:17:29 +00:00
Drew Jaynes
81e235444a Docs: The $post parameter has been passed to the preview_post_link since 4.0.0. 
Fixes a version mixup introduced in [34170].

Props dimadin.
See #24345.


git-svn-id: https://develop.svn.wordpress.org/trunk@34363 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 13:16:36 +00:00
Drew Jaynes
f9e45047c1 Docs: Add a more complete return description for the array of data (or false) returned by image_downsize(). 
If not short-circuited via the `image_downsize` boolean filter, `image_downsize()` returns an array of data including the image URL, width, height, and whether the image size is intermediate, in that order. Otherwise, it returns false.

Fixes #30636.


git-svn-id: https://develop.svn.wordpress.org/trunk@34362 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 10:21:48 +00:00
Drew Jaynes
71ce9e812c Docs: Update the docs for WP_User_Query->prepare_query() for ordering by the value of the include argument, allowed since 4.1. 
Also adds a changelog entry for the additionally-accepted value.

Props danielbachhuber.
Fixes #33937.


git-svn-id: https://develop.svn.wordpress.org/trunk@34361 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 00:46:08 +00:00
John Blackbourn
f80add733c Implement a 'Mine' link on post listing screens in the admin area for all users who have authored posts. This feature was previously only available to users who cannot edit other users' posts (namely Authors and Contributors). 
Props linuxologos, wonderboymusic
Fixes #19609


git-svn-id: https://develop.svn.wordpress.org/trunk@34360 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 17:27:35 +00:00
John Blackbourn
ce126c10c0 Remove the ability to view the term editing screen for taxonomies with show_ui set to false. It is unexpected and unintended behaviour that this is allowed. 
If your plugin or site does rely on this behaviour, the arguments that are passed to `register_taxonomy()` should be altered so that `show_ui` is `true`, and arguments such as `show_in_menu` and `show_in_nav_menus` are false.

Fixes #33938


git-svn-id: https://develop.svn.wordpress.org/trunk@34359 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 17:10:55 +00:00
John Blackbourn
dc7d968b19 Implement some more uses of wp_login_url() in places where wp-login.php is hard-coded. 
See #31495


git-svn-id: https://develop.svn.wordpress.org/trunk@34358 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 16:53:32 +00:00
John Blackbourn
2894423f19 Revisions are an exception when it comes to the editing UI. The revision post type cannot have its show_ui argument set to true because this allows access to the post type listing, creation, and editing UI, but get_edit_post_link() needs to return a URL for the editing UI for revisions as that's how the revisions UI works. 
Fixes #33763


git-svn-id: https://develop.svn.wordpress.org/trunk@34357 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 16:37:41 +00:00
Konstantin Obenland
050def62a3 Multisite: Make site status classes available to other elements. 
Fixes a regression introduced in [31181], where links to user's site would not
have a colored background based on their status anymore.

Fixed during WordCamp Switzerland Contributor Day.

Props psoluch.
Fixes #33595.



git-svn-id: https://develop.svn.wordpress.org/trunk@34356 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 12:52:56 +00:00
Drew Jaynes
e3e91dbadc Docs: Add a description for the documented use of the $wpdb global in _prime_comment_caches(). 
See #8071. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34355 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 09:38:24 +00:00
Dominik Schilling (ocean90)
ce1832f49c Login: Move the "Lost your password?" link into a separate string to reduce HTML tags in translation strings. 
Props ramiy.
Fixes #31870.

git-svn-id: https://develop.svn.wordpress.org/trunk@34354 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 09:10:59 +00:00
John Blackbourn
fe80bec9ee Add @since docs for the show_ui argument in register_post_type(). 
See #33763


git-svn-id: https://develop.svn.wordpress.org/trunk@34353 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 09:04:21 +00:00
Dominik Schilling (ocean90)
d3031d522e Upgrader: Avoid using an HTML tag in a translation string, add translator comments. 
Props ramiy for initial patch. 
Fixes #31860.

git-svn-id: https://develop.svn.wordpress.org/trunk@34352 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 08:58:27 +00:00
Dominik Schilling (ocean90)
ed82c7fb75 Theme Compat: Remove two strings from comments-popup.php. 
`theme-compat/comments-popup.php` is a deprecated file. Instead of improving the strings in [34342] remove both superfluous paragraphs.

See #31867.

git-svn-id: https://develop.svn.wordpress.org/trunk@34351 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 08:48:28 +00:00
Sergey Biryukov
857be1862b Pass the current post object to 'page_attributes_meta_box_template' action added in [34340]. 
Props DrewAPicture.
Fixes #33625.

git-svn-id: https://develop.svn.wordpress.org/trunk@34350 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 08:14:40 +00:00
Drew Jaynes
44c256e8d1 Docs: Use standardized vernacular in the hook doc summary for the page_attributes_meta_box_template filter, introduced in [34340]. 
See #33625.


git-svn-id: https://develop.svn.wordpress.org/trunk@34349 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 06:37:18 +00:00
Scott Taylor
ed7d34cb13 Pass false as the 2nd argument to class_exists() to disable autoloading and to not cause problems for those who define __autoload(). 
Fixes #20523.


git-svn-id: https://develop.svn.wordpress.org/trunk@34348 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 03:51:55 +00:00
Scott Taylor
520a75f44e The 'get_sample_permalink_html' filter​'s second parameter can be a post ID or a post object. This is confusing. We should pass the post ID and post object separately, for consistency with 'get_sample_permalink' filter added in [34309]. 
Props SergeyBiryukov.	
Fixes #33927.


git-svn-id: https://develop.svn.wordpress.org/trunk@34347 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 03:25:45 +00:00
Scott Taylor
0082a438c5 MediaElement, update wp-mediaelement.js: 
* create a public `initialize` method on the `wp.mediaelement` namespace
* make it idempotent to prevent nasty side-effects caused by initializing media elements more than once

Props bradyvercher.	
Fixes #32423.


git-svn-id: https://develop.svn.wordpress.org/trunk@34346 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 03:16:23 +00:00
Scott Taylor
191233f2f9 WP Query: Avoid using HTML tags in translation strings, add translator strings. 
Props ramiy.	
Fixes #31868.


git-svn-id: https://develop.svn.wordpress.org/trunk@34345 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 03:03:28 +00:00
Scott Taylor
df8f10ceff Plugins Admin: Avoid using HTML tags in translation strings, add translator strings. 
Props swissspidy, voldemortensen.	
Fixes #32269.


git-svn-id: https://develop.svn.wordpress.org/trunk@34344 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 03:00:57 +00:00
Scott Taylor
2161a20a68 WP Mail: Avoid using HTML tags in translation strings, add translator strings. 
Props ramiy.	
Fixes #31871.


git-svn-id: https://develop.svn.wordpress.org/trunk@34343 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 02:52:49 +00:00
Scott Taylor
067af6b9aa Theme Compat: Avoid using HTML tags in translation strings. 
Props ramiy.	
Fixes #31867.


git-svn-id: https://develop.svn.wordpress.org/trunk@34342 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 02:46:42 +00:00
Scott Taylor
d624c118cb Plugin Editor: Avoid using HTML tags in translation strings and add context. 
Props ramiy.	
Fixes #31862.


git-svn-id: https://develop.svn.wordpress.org/trunk@34341 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 02:41:43 +00:00
Scott Taylor
2812cc9595 In page_attributes_meta_box(), add an action, 'page_attributes_meta_box_template' to allow callbacks to be performed and HTML to be inserted after the title of the Template section. 
Props sgrant.	
Fixes #33625.


git-svn-id: https://develop.svn.wordpress.org/trunk@34340 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 02:39:31 +00:00
Scott Taylor
a3cb19c52e MediaElement: apply monkey patch to include a PR which fixes a breaking change made upstream on a public interface: 
ccba8d0b6a

Props bradyvercher.
Fixes #33798.


git-svn-id: https://develop.svn.wordpress.org/trunk@34339 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 02:30:06 +00:00
Scott Taylor
2ccbc51d1e Login: apply the same margin to the top and bottom of the Back to {Blog} link. 
Props MikeHansenMe.
Fixes #29249.


git-svn-id: https://develop.svn.wordpress.org/trunk@34338 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 01:40:42 +00:00
Drew Jaynes
12ce04a95e Docs: Add descriptions for $wp_query global phpDoc references in wp-includes/query.php, partially documented in [32620]. 
Fixes #32139.


git-svn-id: https://develop.svn.wordpress.org/trunk@34337 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 00:04:48 +00:00
Scott Taylor
b55de4e5f8 Feeds/Links: fix feed links for unattached attachments. 
Adds unit tests.

Props wonderboymusic, iworks.
Fixes #33693.


git-svn-id: https://develop.svn.wordpress.org/trunk@34336 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 20:09:05 +00:00
Scott Taylor
633b119fd3 Site Icon: for consistency, make all 4 HTML tags in wp_site_icon() self-closing. 
Props Corphi.
Fixes #33930.


git-svn-id: https://develop.svn.wordpress.org/trunk@34334 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 19:06:03 +00:00
Scott Taylor
0fdbaecbc6 Export: Add late-escaping to the contents of several nodes to avoid creating invalid XML and XML parse errors. 
Props westonruter.
Fixes #33732.


git-svn-id: https://develop.svn.wordpress.org/trunk@34333 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 18:52:27 +00:00
Scott Taylor
f9c67159d4 Updates: in Theme list table, set white-space to normal for theme titles at appropriate breakpoint to avoid horizontal scrolling on small screens. 
Fixes #33831.


git-svn-id: https://develop.svn.wordpress.org/trunk@34332 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 18:42:45 +00:00
Scott Taylor
d075313f5b Post List Table: 'All' view should be selected when appropriate for paged responses. 
Props kraftbj, wonderboymusic.
Fixes #33923.


git-svn-id: https://develop.svn.wordpress.org/trunk@34331 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 18:16:31 +00:00
Scott Taylor
f4445d75c4 Add a 'menu_id' argument to wp_page_menu() so that fallback menus have the same attributes as wp_nav_menu(). 
Props lancewillett, ocean90, wonderboymusic.
Fixes #31656.


git-svn-id: https://develop.svn.wordpress.org/trunk@34330 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 18:06:49 +00:00
Scott Taylor
1b550d9fb2 Reinstate [34327]. minus the unit test deletion. 
git-svn-id: https://develop.svn.wordpress.org/trunk@34329 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 17:48:18 +00:00
Scott Taylor
1e7832cc3b Revert [34327] to fix the accidental deletion of some unit tests. 
git-svn-id: https://develop.svn.wordpress.org/trunk@34328 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 17:45:46 +00:00
Scott Taylor
750c22abf8 Export: Add a filer, 'export_wp_filename' to change the filename of the file to download when exporting. 
Props MikeHansenMe, wonderboymusic.
Fixes #29500.


git-svn-id: https://develop.svn.wordpress.org/trunk@34327 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 17:43:52 +00:00
Scott Taylor
3624366045 Export: allow Media to exported separately from other types. 
Props PhilipLakin.
Fixes #32230.


git-svn-id: https://develop.svn.wordpress.org/trunk@34326 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 16:46:17 +00:00
Scott Taylor
d9b58bd4ac Admin: when toggling select/deselect "all" via JS - :visible needs to be bound to not toggle disabled inputs. 
Props tywayne.
Fixes #32309.


git-svn-id: https://develop.svn.wordpress.org/trunk@34325 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 16:40:34 +00:00
Scott Taylor
6d51562d72 Edit Post: When a post is "Pending Review", the "View Post" link should behave like ot does for drafts and generate a preview link. 
Props wpdev101.
Fixes #33541.


git-svn-id: https://develop.svn.wordpress.org/trunk@34324 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 16:31:38 +00:00
Scott Taylor
1ca6eee748 List Tables: Ensure that sorting indicators have layout when cell widths are being calculated. 
See #27743.


git-svn-id: https://develop.svn.wordpress.org/trunk@34323 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 16:14:59 +00:00
Scott Taylor
3cf5d40b9d Update Core: In list_plugin_updates(), when listing plugin updates related to $core_update_version, don't skip the check for $info->tested. 
Props MikeHansenMe.
Fixes #27883.


git-svn-id: https://develop.svn.wordpress.org/trunk@34322 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 16:09:40 +00:00
Konstantin Obenland
bfc9fc4040 Menus: Remove whitespace between nav menu items. 
Avoids CSS hacks like floating menu items or setting the parent element's
font-size to 0 in order to display nav menus horizontally.

Props jjeaton.
Fixes #27762.



git-svn-id: https://develop.svn.wordpress.org/trunk@34321 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 11:39:39 +00:00
Weston Ruter
7bdfb4917f Customize: Flesh out phpdoc for WP_Customize_Manager. 
* Add missing phpdoc for class member variables.
* Supply missing `@return` descriptions from [34269].
* Add missing `@since` tags.
* Remove unused `$customized` protected class member variable.

Fixes #33898.


git-svn-id: https://develop.svn.wordpress.org/trunk@34320 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 06:39:09 +00:00
Scott Taylor
1c5f85e1a4 When applying the 'editable_slug' filter, add a second param that provides more context. 
Props MikeSchinkel, jesin.
Fixes #31568.


git-svn-id: https://develop.svn.wordpress.org/trunk@34319 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 05:48:30 +00:00
Scott Taylor
09e3149b7a Add a 'clean_user_cache' action at the end of clean_user_cache(). This is mighty similar to clean_post_cache(). 
Props elliott-stocks, wonderboymusic.
Fixes #31918.


git-svn-id: https://develop.svn.wordpress.org/trunk@34318 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 05:40:22 +00:00
Andrew Ozz
51078c32ec TinyMCE: remove word-break: break-word; from the default editor CSS to prevent irregular spaces when typing in RTL languages. 
Props iehsanir, alireza1375, ankit-k-gupta.
Fixes #33868.

git-svn-id: https://develop.svn.wordpress.org/trunk@34317 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 23:57:56 +00:00
Dominik Schilling (ocean90)
9b546efc1b Theme Compat: Remove commented out code. 
See #31867.

git-svn-id: https://develop.svn.wordpress.org/trunk@34316 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 21:37:09 +00:00
Dominik Schilling (ocean90)
7eb0317968 Don't use <code> in translation strings in wp-admin/options.php. 
Props ramiy, wonderboymusic.
Fixes #31861.

git-svn-id: https://develop.svn.wordpress.org/trunk@34315 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 20:42:20 +00:00
Dominik Schilling (ocean90)
f5eacb71d6 Don't use <code> in translation strings in wp-admin/includes/plugin.php. 
Props ramiy.
Fixes #31856.

git-svn-id: https://develop.svn.wordpress.org/trunk@34314 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 20:28:23 +00:00
Dominik Schilling (ocean90)
0c642e4730 Use correct @since tag for wp_ajax_generate_password(). 
See #33450.

git-svn-id: https://develop.svn.wordpress.org/trunk@34313 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 20:18:22 +00:00
Scott Taylor
1299974e7d Profile: when clicking "Cancel" after clicking "Generate Password", request and generate a new password to present to the user. 
Props adamsilverstein, wonderboymusic.
Fixes #33450.


git-svn-id: https://develop.svn.wordpress.org/trunk@34312 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 20:13:34 +00:00
Scott Taylor
a5f62a6cd5 Media: add a filter, 'mejs_settings', to allow devs to pass more config settings to MediaElement. 
Fixes #33506.


git-svn-id: https://develop.svn.wordpress.org/trunk@34311 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:59:43 +00:00
Boone Gorges
2fd81992bc Split the comment query. 
`WP_Comment_Query` now fetches comments in two stages: (1) a query to get the
IDs of comments matching the query vars, and (2) a query to populate the
objects corresponding to the matched IDs. The two queries are cached
separately, so that sites with persistent object caches will continue to have
complete cache coverage for normal comment queries.

Splitting the query allows our cache strategy to be more modest and precise, as
full comment data is only stored once per comment. It also makes it possible
to introduce logic for paginated threading, which is necessary to address
certain performance problems.

See #8071.
data is only stored once per comment, instead of along with

git-svn-id: https://develop.svn.wordpress.org/trunk@34310 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:27:39 +00:00
Scott Taylor
b0b36bc346 Add a 'get_sample_permalink' filter. 
Props SergeyBiryukov, wenthemes, JustinSainton.
Fixes #22338.


git-svn-id: https://develop.svn.wordpress.org/trunk@34309 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:27:24 +00:00
Scott Taylor
27eb1ac0da Add title_reply_before and title_reply_after args to comment_form() to allow the "Leave a Reply" heading level to be changed. 
Props tyxla.
Fixes #33775.


git-svn-id: https://develop.svn.wordpress.org/trunk@34308 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:17:19 +00:00
Scott Taylor
b862280404 After [34280], rename menu_tag arg to container, fix docs. 
Props DrewAPicture.
Fixes #10968.


git-svn-id: https://develop.svn.wordpress.org/trunk@34307 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:04:18 +00:00
Sergey Biryukov
c43a62bde7 Include placeholder in translator comment. 
See #31863.

git-svn-id: https://develop.svn.wordpress.org/trunk@34306 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:02:37 +00:00
Sergey Biryukov
039ce30818 Include placeholder in translator comment. 
See #31864.

git-svn-id: https://develop.svn.wordpress.org/trunk@34305 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:00:20 +00:00
Sergey Biryukov
21a41c100f Include placeholders in translator comments. 
See #31857.

git-svn-id: https://develop.svn.wordpress.org/trunk@34304 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:57:01 +00:00
Scott Taylor
394e9ac21a Don't use HTML tags in translation strings in edit-tags.php. 
Props ramiy.
Fixes #31863.


git-svn-id: https://develop.svn.wordpress.org/trunk@34303 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:52:48 +00:00
Scott Taylor
de077ac377 Don't use HTML tags in translation strings in wp_ajax_add_user(). 
Props ramiy.
Fixes #31864.


git-svn-id: https://develop.svn.wordpress.org/trunk@34302 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:50:04 +00:00
Sergey Biryukov
5cfdae8b2b Add missing translator comment after [34295]. 
See #31853.

git-svn-id: https://develop.svn.wordpress.org/trunk@34301 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:49:40 +00:00
Sergey Biryukov
bcc165791f Add missing translator comments after [34294]. 
See #31852.

git-svn-id: https://develop.svn.wordpress.org/trunk@34300 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:45:40 +00:00
Sergey Biryukov
48c6d925cd Add missing translator comment after [34292]. 
See #31840.

git-svn-id: https://develop.svn.wordpress.org/trunk@34299 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:39:20 +00:00
Sergey Biryukov
f90ee7b348 Add missing translator comments after [34293]. 
See #31851.

git-svn-id: https://develop.svn.wordpress.org/trunk@34298 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:38:54 +00:00
Scott Taylor
310dc18167 Don't use HTML tags in translation strings for "In Reply To" links for comments in the admin. 
Props ramiy.
Fixes #31857.


git-svn-id: https://develop.svn.wordpress.org/trunk@34297 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:35:16 +00:00
Scott Taylor
13889763af Don't use HTML tags in translation strings in wp-admin/includes/update.php. 
Props ramiy.
Fixes #31855.


git-svn-id: https://develop.svn.wordpress.org/trunk@34296 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:30:26 +00:00
Scott Taylor
c10019ec70 Don't use <code> in translation strings in edit-form-comment.php. 
Props ramiy.
Fixes #31853.


git-svn-id: https://develop.svn.wordpress.org/trunk@34295 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:27:29 +00:00
Scott Taylor
df149fddff Don't use <code> in translation strings in options-general.php. 
Props ramiy, SergeyBiryukov.
Fixes #31852.


git-svn-id: https://develop.svn.wordpress.org/trunk@34294 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:23:19 +00:00
Scott Taylor
d2b4e0c728 Don't use <code> in translation strings in wp-admin/includes/schema.php. 
Props ramiy.
Fixes #31851.


git-svn-id: https://develop.svn.wordpress.org/trunk@34293 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:20:46 +00:00
Scott Taylor
f6d2c30fa7 Network Setup: don't use <code> in translation strings in wp-admin/network files. 
Props ramiy.
Fixes #31840.


git-svn-id: https://develop.svn.wordpress.org/trunk@34292 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:17:26 +00:00
Aaron Jorbin
308179c232 Remove support for my-hacks.php 
For the last 10 years, my-hacks has been deprecated and has been throwing a deprecation notice. For the last six years, you haven't been able to enable my-hacks.php in the admin UI. That should be enough time to give developers notice. Plugins and themes seem like they might have staying power.

Fixes #33741
Props bobbingwide



git-svn-id: https://develop.svn.wordpress.org/trunk@34291 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 17:05:28 +00:00
Dominik Schilling (ocean90)
7f562dd69f Theme Editor: Change file descriptions of header.php and footer.php. 
`header.php` is now "Theme Header" and `footer.php` is "Theme Footer". This prevents a clash with other "Header" strings in the context of "Custom Header".

Props ramiy.
Fixes #32975.

git-svn-id: https://develop.svn.wordpress.org/trunk@34290 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 16:02:24 +00:00
Sergey Biryukov
7851406626 Network Admin: Include IDs for users and sites on their respective views. 
Props danielbachhuber, wonderboymusic.
Fixes #18661.

git-svn-id: https://develop.svn.wordpress.org/trunk@34289 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 15:57:47 +00:00
Drew Jaynes
a176e78b64 Docs: Clarify the significance of the $accepted_args parameter value in the documentation for add_filter(). 
Adds a couple of examples to illustrate callbacks accepting a variable number of arguments.

Fixes #33862.


git-svn-id: https://develop.svn.wordpress.org/trunk@34288 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 14:52:37 +00:00
Drew Jaynes
efc08d508e Docs: Fix some syntactical issues in the DocBlock for set_query_var(). 
Adds descriptions for the global `WP_Query` instance and the `$value` parameter.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34287 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 10:28:41 +00:00
Drew Jaynes
e889c2e647 Docs: Fix some syntactical issues in the documentation for get_queried_object_id(). 
Adds descriptions for the global `WP_Query` instance and the return.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34286 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 10:26:58 +00:00
Drew Jaynes
4706230535 Docs: Fix some syntactical isses in the DocBlock for get_queried_object(). 
Also add descriptions for the return and the `WP_Query` global.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34285 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 10:20:07 +00:00
Drew Jaynes
572e3ddafb Docs: Add documentation to get_query_var() and WP_Query::get() for the optional $default argument, introduced in 3.9 in [27304]. 
Props swissspidy.
Fixes #33856.


git-svn-id: https://develop.svn.wordpress.org/trunk@34284 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 09:40:51 +00:00
Dion Hulse
6e6d026524 HTTP: Update the Root Certificate bundle. 
See #30434


git-svn-id: https://develop.svn.wordpress.org/trunk@34283 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 08:42:24 +00:00
Dion Hulse
09f373d582 Updates: FTP: Add a missing PCRE modifer in [34281]. 
See #16026, #33432x


git-svn-id: https://develop.svn.wordpress.org/trunk@34282 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 08:22:17 +00:00
Dion Hulse
b114866bbf Updates: FTP/PemFTP Library: Remove the usage of deprecated regular expression functions (ereg replaced by PCRE). 
Props enshrined, aaroncampbell
Fixes #16026, #33432


git-svn-id: https://develop.svn.wordpress.org/trunk@34281 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 08:19:18 +00:00
Scott Taylor
30921dd396 Add an argument to wp_page_menu(), 'menu_tag', which defaults to div but can be overridden to allow HTML5 tags like nav. 
Props paulwilde, stebbiv, wonderboymusic.
Fixes #10968.


git-svn-id: https://develop.svn.wordpress.org/trunk@34280 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 06:06:17 +00:00
Weston Ruter
d81ca65d4c Customize: Fix live previewing of menu changes on subdirectory installs. 
Props adamsilverstein, westonruter.
Fixes #33916.


git-svn-id: https://develop.svn.wordpress.org/trunk@34278 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 05:46:53 +00:00
Scott Taylor
d5e5ca8e93 Comments: in wp_rel_nofollow_callback(), account for the fact that a link might already have a rel attribute. Currently, if a link already has a rel, it will result it duplicate attributes on the element with conflicting values. 
Adds unit tests.

Props junsuijin, wonderboymusic.
Fixes #9959.


git-svn-id: https://develop.svn.wordpress.org/trunk@34277 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 04:35:37 +00:00
Scott Taylor
50419ff08d List Tables: ensure that sortable list table column headers have the same padding/line-height as non-sortable headers. 
Props drozdz.
Fixes #27945.


git-svn-id: https://develop.svn.wordpress.org/trunk@34276 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 03:25:32 +00:00
Scott Taylor
ace6756081 Editor: add hide-if-no-js class to <td id="wp-word-count">. Word Count no worky with no JavaScript. 
Props chriscct7.
Fixes #33379.


git-svn-id: https://develop.svn.wordpress.org/trunk@34275 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 02:31:23 +00:00
Scott Taylor
c5963b8760 In wp-comments-post.php, sanity check a few of the comment inputs that are expected to be a string beford calling string-only functions on them. 
Props Kloon.
Fixes #23416.


git-svn-id: https://develop.svn.wordpress.org/trunk@34274 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 22:21:06 +00:00
Scott Taylor
bec1944e44 Widgets: don't show a dropdown if there is only 1 taxonomy or zero taxonomies available to the Tag Cloud widget form. Don't output the widget if there are no terms in the selected taxonomy. 
Props GautamGupta, wonderboymusic.
Fixes #16125.


git-svn-id: https://develop.svn.wordpress.org/trunk@34273 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 22:10:46 +00:00
Scott Taylor
2a4eba2eb8 Canonical: redirect URLs that match an attachment masked on the wrong URL to the attachment link for the matched attachment. 
Props solarissmoke.
Fixes #19918.


git-svn-id: https://develop.svn.wordpress.org/trunk@34272 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 21:31:21 +00:00
Scott Taylor
73c1ac8b26 Posts List Table: Use a more robust technique for calculating $total_items so that pagination still appears when items are removed on the last page of results and ->max_num_pages decreases. 
Props A5hleyRich.
Fixes #29870.


git-svn-id: https://develop.svn.wordpress.org/trunk@34271 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 21:17:16 +00:00
Boone Gorges
504deb52fc Lazy-load comment meta on single post pages. 
[34268] introduced cache priming for commentmeta, enabled by default. To
ensure performance on single post pages - where commentmeta is most likely
to cause performance issues - we disable up-front cache-priming. Instead, we
prime commentmeta caches for all comments in the loop the first time
`get_comment_meta()` is called on the page.

Props bradt, dd32, wonderboymusic, boonebgorges.
Fixes #16894.

git-svn-id: https://develop.svn.wordpress.org/trunk@34270 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 20:00:31 +00:00
Weston Ruter
5ea07785b3 Customize: Reduce peak memory usage by JSON-encoding settings and controls individually. 
When there are hundreds of settings and controls (e.g. nav menu items and widget instances) the resulting object that is JSON-encoded can become very large, and `wp_json_encode()` can consume a lot of memory to serialize it. By breaking down the serialization into multiple calls the peak memory usage can be kept in line.

Moves logic out of `wp-admin/customize.php` into the `WP_Customize_Manager` class with new methods:

 * `is_ios()`
 * `get_document_title_template()`
 * `get_preview_url()`/`set_preview_url()`
 * `get_return_url()`/`set_return_url()`
 * `get_autofocus()`/`set_autofocus()`
 * `customize_pane_settings()`

Includes unit tests for these methods, for which the logic was formerly untestable in `customize.php`.

Fixes #33898.


git-svn-id: https://develop.svn.wordpress.org/trunk@34269 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 19:41:35 +00:00
Boone Gorges
12329f5ef8 Prime comment meta caches in WP_Comment_Query. 
The new 'update_comment_meta_cache' parameter, which defaults to `true`, can
be used to disable this behavior.

`update_comment_cache()` has been updated to support an `$update_meta_cache`
parameter, which also updates to true; this matches the pattern we use for
priming post caches.

See #16894.

git-svn-id: https://develop.svn.wordpress.org/trunk@34268 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 19:29:46 +00:00
Boone Gorges
b08a176488 Tell the insert_user_meta filter whether user is being updated. 
`insert_user_meta` was introduced in [33708]. This changeset passes the
`$update` parameter to it.

Props tharsheblows, geminorum.
Fixes #31549.

git-svn-id: https://develop.svn.wordpress.org/trunk@34266 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 14:34:49 +00:00
Helen Hou-Sandi
3531c0bc10 Superglobals: Revert [34059] until further notice. 
see #33837.


git-svn-id: https://develop.svn.wordpress.org/trunk@34265 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 12:32:20 +00:00
Drew Jaynes
8c65cfc7f4 Docs: Add a reminder to the DocBlock description for add_query_arg() mentioning that the output is not escaped by default. 
Props brentvr for the initial patch. (first props!)
See #33912. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34264 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 09:38:56 +00:00
Sergey Biryukov
f9ff998d01 Revert unintended change from [34262]. 
See #33910.

git-svn-id: https://develop.svn.wordpress.org/trunk@34263 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 09:08:14 +00:00
Sergey Biryukov
45610f9464 Docs: Expand the DocBlock for get_default_post_to_edit(). 
Props rabmalin.
Fixes #33910.

git-svn-id: https://develop.svn.wordpress.org/trunk@34262 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 09:05:44 +00:00
Scott Taylor
8861e38966 Media: Ensure that HTML5 captions apply the 'img_caption_shortcode_width'. 
Props joemcgill.
Fixes #31053.


git-svn-id: https://develop.svn.wordpress.org/trunk@34261 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 06:03:11 +00:00
Scott Taylor
189bc9b5aa Media: In wp_ajax_send_attachment_to_editor(), the fallback logic for $html should be tucked into an else statement so it isn't run needlessly and overwritten. 
Props tychay.
Fixes #32072.


git-svn-id: https://develop.svn.wordpress.org/trunk@34260 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 05:54:56 +00:00
Scott Taylor
337c87e7c7 Media: In get_image_send_to_editor(), allow a custom value for $rel. 
Props tychay.
Fixes #32074.


git-svn-id: https://develop.svn.wordpress.org/trunk@34259 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 05:45:31 +00:00
Scott Taylor
2e7277b733 Media: In wp_prepare_attachment_for_js(), don't call file_exists() and filesize() to retrieve $bytes if the data is already present in $meta. This is how the same code in attachment_submitbox_metadata() already works. 
Props polevaultweb.
Fixes #33214.


git-svn-id: https://develop.svn.wordpress.org/trunk@34258 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 05:02:52 +00:00
Scott Taylor
79656b5fdd Uploader: Fire 'wp_handle_upload' in wp_upload_bits(). Thusly, the filter in wp_xmlrpc_server::mw_newMediaObject() is redundant. 
Props dllh.
Fixes #33539.


git-svn-id: https://develop.svn.wordpress.org/trunk@34257 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 04:46:00 +00:00
Scott Taylor
a1805ecada Media List Table: remove the counts from the "views" portion of the toolbar, which are inconsistent with grid view. Also reduces complexity and removes potentially expensive count query. 
Related to the toolbar view, remove the `wp_admin_canonical_url()` action in grid mode. Grid views that result from links from the list table view are lenses into the library and need to be indicated as such vs being a full attachment query.

Fixes #29744.


git-svn-id: https://develop.svn.wordpress.org/trunk@34256 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 02:29:22 +00:00
Scott Taylor
25710ecc67 In wp_mime_type_icon(), the length of the $wilds array varies depending on what is passed as $mime. Loop over $wilds instead of arbitrarily checking $wilds[0]. 
Adds unit tests.

Fixes #33012.



git-svn-id: https://develop.svn.wordpress.org/trunk@34255 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 00:36:12 +00:00
Scott Taylor
45c606576c Media JS: ensure that wp.media.frame (a static reference to the "current" Frame) is reset when a cached frame is opened. 
Fixes #33458.


git-svn-id: https://develop.svn.wordpress.org/trunk@34254 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 00:09:40 +00:00
Sergey Biryukov
54835433c5 Docs: Expand the $comment_approved argument description for 'comment_post' action. 
Props cfinke.
Fixes #33903.

git-svn-id: https://develop.svn.wordpress.org/trunk@34253 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 22:29:15 +00:00
Boone Gorges
03ec7cc107 Improve consistency of comment notification callback signatures. 
Both `wp_new_comment_notify_moderator()` and `wp_new_comment_notify_postauthor()`
now accept a single argument: `$comment_ID`.

Props SergeyBiryukov.
Fixes #33587.

git-svn-id: https://develop.svn.wordpress.org/trunk@34252 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 22:25:07 +00:00
Boone Gorges
de7c9b6015 Move new user notification emails to add_action() callbacks. 
When a new user is created in various places throughout the interface,
notifications are sent to the site admin and the new user. Previously, these
notifications were fired through direct calls to `wp_new_user_notification()`,
making it difficult to stop or modify the messages.

This changeset introduces a number of new action hooks in place of direct calls
to `wp_new_user_notification()`, and hooks the new wrapper function
`wp_send_new_user_notifications()` to these hooks.

Props dshanske, thomaswm, boonebgorges.
Fixes #33587.

git-svn-id: https://develop.svn.wordpress.org/trunk@34251 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 22:18:33 +00:00
Boone Gorges
d26b868870 Don't notify post authors about spam comments. 
[34106] moved post author notification to a hook, and in the process, missed
the 'spam' check. This changeset restores that check.

To make unit testing easier, the notification callbacks have been refactored
to return values: false when various conditions aren't met (eg, approved
comments should not trigger moderation emails), and the return value of the
`wp_notify_*()` function otherwise.

Props cfinke, kraftbj.
See #33587.

git-svn-id: https://develop.svn.wordpress.org/trunk@34250 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 21:59:16 +00:00
Sergey Biryukov
7c9c635a04 Add a missing Oxford comma on Export screen. 
Props juhise.
Fixes #33906.

git-svn-id: https://develop.svn.wordpress.org/trunk@34249 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 21:33:29 +00:00
Boone Gorges
c5f34cb4d0 Throw a notice when an invalid tax is passed to wp_insert_post(). 
Props jdgrimes.
Fixes #25477.

git-svn-id: https://develop.svn.wordpress.org/trunk@34248 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 19:24:51 +00:00
Boone Gorges
302e3d1116 Allow taxonomies to be non-public. 
[13216] introduced the 'public' argument for `register_taxonomy()`. This param
was used to set defaults for 'show_ui' and a number of other params, but it
never did anything itself.

With this changeset, taxonomies registered with `public=false` will no longer
be queryable on the front end, ie via taxonomy archive queries.

Props wpsmith, ocean90, nacin, ericlewis, boonebgorges.
Fixes #21949.

git-svn-id: https://develop.svn.wordpress.org/trunk@34247 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 19:04:57 +00:00
Boone Gorges
1b016b6dc6 Failed get_term_by() lookups should always return false. 
Previously, we sometimes returned `null`.

Props charlestonsw, tyxla.
Fixes #33281.

git-svn-id: https://develop.svn.wordpress.org/trunk@34246 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 18:49:28 +00:00
Scott Taylor
3ca5bbb585 Revert [33925], by-reference array manipulation is breaking comments in some themes. 
This implementation is losing its shine.

See #16894.


git-svn-id: https://develop.svn.wordpress.org/trunk@34245 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 18:13:19 +00:00
Scott Taylor
2d11d6cd90 After [34160], also upgrade objects passed to get_avatar(). 
See #32619.



git-svn-id: https://develop.svn.wordpress.org/trunk@34244 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 17:33:34 +00:00
Sergey Biryukov
45c6094dce Docs: Update the DocBlock for wp_page_menu() to include 'before', 'after', and 'walker' arguments added in [34200]. 
Align the `$defaults` array and include the default value for `'show_home'`.

Props stevegrunwell.
Fixes #11095.

git-svn-id: https://develop.svn.wordpress.org/trunk@34243 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 16:46:08 +00:00
Sergey Biryukov
10bc44d8fc Add register_post_type_args filter for changing register_post_type() arguments before further processing. 
Does not apply to built-in post types.

Props MikeSchinkel, nickciske, engelen, swissspidy.
Fixes #17447.

git-svn-id: https://develop.svn.wordpress.org/trunk@34242 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 15:46:14 +00:00
Scott Taylor
d2bb55ee92 wp-admin/includes/template.php is now a loader for 3 files made via svn cp: 
* `Walker_Category_Checklist` class
* `WP_Internal_Pointers` class
* `template-functions.php`

This is BC for plugins that are loading `wp-admin/includes/template.php` for fun.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34241 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 15:34:17 +00:00
Sergey Biryukov
d262ebca0a Docs: Synchronize the $timezone parameter description between get_lastpostdate(), get_lastpostmodified(), and _get_last_post_time(). 
See #17455.

git-svn-id: https://develop.svn.wordpress.org/trunk@34240 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 15:28:12 +00:00
Sergey Biryukov
9ab1dfd03e Docs: Fix some syntactical issues with the DocBlock for wp_mail_failed action, introduced in [34221]. 
Fixes #18926.

git-svn-id: https://develop.svn.wordpress.org/trunk@34239 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 15:12:42 +00:00
Sergey Biryukov
1d4b8ffd1d Docs: Expand the DocBlock for the WP_Theme::get_edit_link() method, introduced in [34084]. 
Fixes #32376.

git-svn-id: https://develop.svn.wordpress.org/trunk@34238 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 15:00:04 +00:00
Drew Jaynes
2b6dc75396 Docs: Add changelog entries for parameters where WP_Comment object support was added in [33961]. 
See #33638. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34237 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 13:51:13 +00:00
Drew Jaynes
c2d0a83330 Docs: Fix some syntactical issues with the DocBlock for the WP_Theme->update property, introduced in [33957]. 
Adds an `@since`.

See #33491. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34236 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 13:28:41 +00:00
Drew Jaynes
bb2fc0933d Docs: Add a changelog entry for the addition of 'wp-admin', 'wp-content', and 'wp-includes' as reserved names for the subdirectory_reserved_names filter docs. 
The new names were introduced in [33952].

See #33615. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34235 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 13:25:05 +00:00
Drew Jaynes
7682e433fc Docs: Put "it's" in its place (again). 
Props kitchin.
Fixes #33894.


git-svn-id: https://develop.svn.wordpress.org/trunk@34234 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 12:45:51 +00:00
Sergey Biryukov
c57efab4f4 Add a comment to strings where the ellipsis cannot be used due to json_encode(), placeholders, or external dependencies. 
Fixes #32875.

git-svn-id: https://develop.svn.wordpress.org/trunk@34233 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 11:58:41 +00:00
Sergey Biryukov
04c1c825e9 Reset Password: Move <div> out of <p> in wp-login.php. 
Props ldinclaux.
Fixes #33892.

git-svn-id: https://develop.svn.wordpress.org/trunk@34232 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 11:45:09 +00:00
Sergey Biryukov
557d160ca1 Comments: Fix a fatal error in Comments meta box after [34223]. 
Props tyxla.
Fixes #33893. See #33413.

git-svn-id: https://develop.svn.wordpress.org/trunk@34231 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 11:36:35 +00:00
Drew Jaynes
fea6142412 Docs: Make a minor adjustment to the description syntax for the optional $comment argument in the DocBlock for comment_link(), introduced in [34071]. 
See #33638. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34230 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 11:01:50 +00:00
Drew Jaynes
3b3a034c11 Docs: Remove markdown from the DocBlock summary for WP_List_Table::get_primary_column(), introduced in [34166]. 
The PHP inline documentation standards for [https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#summary-formerly-short-description summaries] call for not using an markup or markdown. Also, using the full Class::method() in this context allows for better clarity in what is being referenced.

See #33854. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34229 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 10:50:21 +00:00
Drew Jaynes
f83abcbf3e Docs: Add a changelog entry for the switch to using wp_get_attachment_url() instead of the guid for determining the header image URL in Custom_Image_Header::step_3(). 
The change was introduced in [34188].

See #33319.


git-svn-id: https://develop.svn.wordpress.org/trunk@34228 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 10:42:08 +00:00
Drew Jaynes
ff35e34fad Docs: Improve documentation for the WP_Object_Cache class. 
Spaces out parameter documentation for readability, fixes some minor syntactical issues, and adds some missing `@access` tags or reorders tags according to the PHP docs standards.

Also, documents `&$found`, the fourth parameter for the `get()` method, and adds missing parameter and return descriptions for the `_exists()` utility method.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34227 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 10:02:20 +00:00
Drew Jaynes
1075ec80b8 Docs: Remove an errant change made to a _deprecated_function() call in wp_cache_reset() introduced in [34225]. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34226 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 09:41:51 +00:00
Drew Jaynes
741bd4440c Docs: Add more complete documentation for top-level object cache functionality. 
Adds some `@see` tags for corresponding `WP_Object_Cache` methods to DocBlocks for top-level functions. Also adds a standard description for the `@global` tags, spacing for parameter docs readability, and finally, properly marks optional parameters as such.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34225 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 09:39:33 +00:00
Drew Jaynes
f2eb739ea6 Docs: Add documentation for $object_id, the optional second parameter in current_user_can() and WP_User::has_cap(), and the optional third parameter in map_meta_cap(). 
This change introduces the vernacular of "meta" vs "primitive" capabilities to core docs, and providing examples for each inline and attempts to make it clear that `$object_id` is really only useful if the passed `$capability` is of the meta cap variety.

Props jliman for the initial patch.
Fixes #32694.


git-svn-id: https://develop.svn.wordpress.org/trunk@34224 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 07:35:37 +00:00
Scott Taylor
05cd237d5e Move WP_Post_Comments_List_Table to its own file. 
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34223 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 06:52:35 +00:00
Sergey Biryukov
7e706c285b Fix a typo in wptexturize() and wp_replace_in_html_tags() comments. 
Props bobbingwide.
See #15694.

git-svn-id: https://develop.svn.wordpress.org/trunk@34222 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 05:53:09 +00:00
Aaron Jorbin
bf5f316668 Fire Action when mail exception is thrown. 
new action is wp_mail_failed which contains a WP_Error object with the phpmailerException code, message and an array with the mail information. Plugins can hook in and log when mails fail to send due to a phpmailer issue.

Props soulseekah
Fixes #18926



git-svn-id: https://develop.svn.wordpress.org/trunk@34221 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 23:50:30 +00:00
Weston Ruter
1975b0a084 Customizer: Smooth animation for closing accordions in the available nav menu items pane. 
Props tyxla.
Fixes #33360 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@34219 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 23:39:23 +00:00
Boone Gorges
0adb6877b2 Improve validation of user_login and user_nicename length. 
The `user_login` field only allows 60 characters, and `user_nicename` allows
50. However, there are no protections in the interface, and few in the code,
that prevent the creation of users with values in excess of these limits. Prior
to recent changes in `$wpdb`, users were generally created anyway, MySQL
having performed the necessary truncation. More recently, the `INSERT`s and
`UPDATE`s simply fail, with no real feedback on the nature of the failure.

This changeset addresses the issue in a number of ways:
* On the user-new.php and network/user-new.php panels, don't allow input in excess of the maximum field length.
* In `wp_insert_user()`, throw an error if the value provided for `'user_login'` or `'user_nicename'` exceeds the maximum field length.
* In `wp_insert_user()`, when using `'user_login'` to generate a default value for `'user_nicename'`, ensure that the nicename is properly truncated, even when suffixed for uniqueness (username-2, etc).

Props dipesh.kakadiya, utkarshpatel, tommarshall, boonebgorges.
Fixes #33793.

git-svn-id: https://develop.svn.wordpress.org/trunk@34218 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 22:13:51 +00:00
Boone Gorges
2d59d18e3a Omit the ORDER BY clause when updating object term cache. 
The `ORDER BY` clause was forcing filesorts on large tables, and is
unnecessary, since term order doesn't matter when updating the cache.

Props mbrandys, wonderboymusic.
Fixes #28922.

git-svn-id: https://develop.svn.wordpress.org/trunk@34217 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 20:52:40 +00:00
Scott Taylor
e05586646a Apply the new 'respond_link' filter in comments_popup_link() if $number is 0 before outputting the URL. 
Props joedolson.
Fixes #29454.


git-svn-id: https://develop.svn.wordpress.org/trunk@34216 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 20:45:32 +00:00
Scott Taylor
28426c041c In WP::parse_request(), don't add query vars of non-viewable post types to WP::public_query_vars. In register_post_type(), don't add query vars of non-viewable post types to WP::public_query_vars. 
In `_unregister_post_type()` (unit tests), don't add query vars of non-viewable post types to `WP::public_query_vars`.

Adds unit test.

Fixes #30018.


git-svn-id: https://develop.svn.wordpress.org/trunk@34215 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 18:53:12 +00:00
John Blackbourn
1a352d56f9 Implement wp_login_url() and wp_registration_url() in places where wp-login.php is currently hard-coded. 
See #31495
Props GregLone


git-svn-id: https://develop.svn.wordpress.org/trunk@34213 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 17:10:24 +00:00
Scott Taylor
7b93c40830 WP_Comment_Query: add comment__in to allowed values for $orderby. 
Adds unit tests.

Fixes #33883.


git-svn-id: https://develop.svn.wordpress.org/trunk@34212 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 16:34:14 +00:00
Scott Taylor
72bc9d3227 Add parent__in and parent__not_in query vars to WP_Comment_Query. 
Adds unit tests.

Fixes #33882.


git-svn-id: https://develop.svn.wordpress.org/trunk@34205 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 16:22:34 +00:00
Drew Jaynes
f48d395ffb Docs: Update the hook doc summary for the wp_http_ixr_client_headers filter, introduced in [34164]. 
The idea is to try to reflect what the filterable value is rather than why it's filterable.

Fixes #24598.


git-svn-id: https://develop.svn.wordpress.org/trunk@34203 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 16:15:39 +00:00
wonderboymusic
2a1ee1a235 Don't redirect to the Term list table after submitting the form on the Edit Term page. 
Props chiragswadia, UmeshSingla, rhyswynne, afercia.
Fixes #17455.


git-svn-id: https://develop.svn.wordpress.org/trunk@34202 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 15:58:04 +00:00
Scott Taylor
8fc44f8c39 Allow get_lastpostdate(), get_lastpostmodified(), and _get_last_post_time() to accept $post_type and cache separately. 
Props _duck, SergeyBiryukov.
See #17455.


git-svn-id: https://develop.svn.wordpress.org/trunk@34201 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 15:24:04 +00:00
Scott Taylor
b5b07ca329 Allow wp_page_menu() to accept 'walker', 'before', and 'after' to allow custom markup. 
Fixes #11095.


git-svn-id: https://develop.svn.wordpress.org/trunk@34200 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 15:05:34 +00:00
Scott Taylor
acbeef27b9 Similar to #33386, don't use guid when retrieving URL for a cropped header image in the Customizer. 
Props polevaultweb.
Fixes #33319.


git-svn-id: https://develop.svn.wordpress.org/trunk@34188 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 14:45:59 +00:00
Sergey Biryukov
87d6be5991 Comments: When setting the colspan value for inline edit/reply, make sure it's actually a table and the value is not empty. 
Props afercia.
Fixes #33596.

git-svn-id: https://develop.svn.wordpress.org/trunk@34179 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 13:43:28 +00:00
John Blackbourn
b8349f8222 Remove outdated references to the preview_post_link filter docs. 
See #24345
Props paulwilde


git-svn-id: https://develop.svn.wordpress.org/trunk@34178 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 10:31:40 +00:00
John Blackbourn
a923d36085 Remove the ability to view the post listing screen and post editing screen for post types with show_ui set to false. It is unexpected and unintended behaviour that this is allowed. 
If your plugin or site does rely on this behaviour, the arguments that are passed to `register_post_type()` should be altered so that `show_ui` is `true`, and arguments such as `show_in_menu`, `show_in_nav_menus`, and `show_in_admin_bar` are `false`.

Fixes #33763
Props swissspidy, johnbillion


git-svn-id: https://develop.svn.wordpress.org/trunk@34177 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 10:26:22 +00:00
John Blackbourn
9b836740c3 Improve the docblocks for the get_preview_post_link() function and the preview_post_link filter. 
See #24345


git-svn-id: https://develop.svn.wordpress.org/trunk@34176 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 08:24:54 +00:00
John Blackbourn
47a66713ae Correct the value of the preview query variable added by get_preview_post_link(). 
See #24345
Props kitchin


git-svn-id: https://develop.svn.wordpress.org/trunk@34175 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 08:15:22 +00:00
John Blackbourn
c0c2a76778 Place the filter docblock for http_api_transports immediately above the filter. 
See #33413
Props dd32


git-svn-id: https://develop.svn.wordpress.org/trunk@34174 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 08:11:11 +00:00
Scott Taylor
c95d6b3ec8 Use get_attached_file() in attachment_submitbox_metadata(). 
Props kitchin.
Fixes #33386.


git-svn-id: https://develop.svn.wordpress.org/trunk@34171 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 04:17:38 +00:00
Scott Taylor
c0d850878a Create a function, get_preview_post_link(), to DRY the logic for applying the 'preview_post_link' filter to a URL. 
Props TomHarrigan, wonderboymusic.
Fixes #24345.


git-svn-id: https://develop.svn.wordpress.org/trunk@34170 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 04:14:23 +00:00
Scott Taylor
ac610c191b Move WP_Screen to its own file. 
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34169 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 04:07:14 +00:00
Scott Taylor
26ab36f909 Move the admin Nav Menu Walker subclasses into their own files. Load in nav-menu.php to remain BC. 
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34168 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 04:01:30 +00:00
Scott Taylor
c702a71ad1 Update post thumbnail functions to allow a WP_Post to be passed. 
Adds unit tests.

Props swissspidy, Rahe.
Fixes #33723.


git-svn-id: https://develop.svn.wordpress.org/trunk@34167 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 03:45:23 +00:00
Scott Taylor
1a537a4f6d Add a doc block to WP_List_Table::get_primary_column(). 
Fixes #33854.


git-svn-id: https://develop.svn.wordpress.org/trunk@34166 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 03:34:44 +00:00
Scott Taylor
8df7bd75b6 Ensure that widget carets close when dragging an expanded widget. 
Props sdavis2702, mindctrl.
Fixes #33578.


git-svn-id: https://develop.svn.wordpress.org/trunk@34165 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 03:09:35 +00:00
Scott Taylor
030747e429 Add a filter to allow custom headers to be sent via the WP HTTP IXR client: 'wp_http_ixr_client_headers'. 
Props ericmann.
Fixes #24598.


git-svn-id: https://develop.svn.wordpress.org/trunk@34164 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 02:53:18 +00:00
Scott Taylor
577fea566a Don't ever use the guid value when retrieving URLs for media, use wp_get_attachment_url(). Use get_attached_file() for path to file. 
Fixes #33386.


git-svn-id: https://develop.svn.wordpress.org/trunk@34163 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 02:49:12 +00:00
Scott Taylor
337451b099 TwentyFifteen|Sixteen themes have a <div id="content"> in the header. Change the <div> IDs in wp-activate.php and wp-signup.php to be unique to each page. 
Props jfarthing84.
Fixes #33843.


git-svn-id: https://develop.svn.wordpress.org/trunk@34162 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 02:08:07 +00:00
Scott Taylor
5c85369bb6 In _wp_ajax_delete_comment_response(), read the new 'all' prop returned by get_comment_count() via wp_count_comments() when setting $total. 'all' doesn't include spam in its count. 
Updates unit tests.

Props dipesh.kakadiya.
Fixes #32362.


git-svn-id: https://develop.svn.wordpress.org/trunk@34161 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 01:46:51 +00:00
Scott Taylor
2817bb6557 In get_avatar_data(), promote stdClass objects to WP_Comment if passed. 
Props DrewAPicture, ocean90.
Fixes #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@34160 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 01:33:29 +00:00
Scott Taylor
5168b2e303 After [34070], account for the new ID in Quick Edit JS. 
Props afercia.
Fixes #33770.


git-svn-id: https://develop.svn.wordpress.org/trunk@34159 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 01:30:36 +00:00
Scott Taylor
95795c1301 More bonkers comment cache cleanup: toggle wp_defer_comment_counting() in wp_insert_post() and wp_insert_attachment(). Move the cache deletion in wp_update_comment_count_now() to before the get_post() call, so that the caches get deleted even if the post has already been deleted and the function returns early. 
See #33875.


git-svn-id: https://develop.svn.wordpress.org/trunk@34158 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 00:57:48 +00:00
Scott Taylor
8cb6843170 Ensure that the count cache for all is in sync with comment-{$post_id} values. These are the values most often relied-upon by the list table for comments. 
Adds unit tests.

See #33875.


git-svn-id: https://develop.svn.wordpress.org/trunk@34136 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 22:38:02 +00:00
Dominik Schilling (ocean90)
354000b5ca XMLRPC: Don't allow private posts to be sticky. 
See #20662.

git-svn-id: https://develop.svn.wordpress.org/trunk@34135 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 22:37:21 +00:00
Nikolay Bachiyski
c430a82236 Shortcodes: don't allow unclosed HTML elements in attributes 
git-svn-id: https://develop.svn.wordpress.org/trunk@34134 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 22:35:22 +00:00
Nikolay Bachiyski
1541d43033 List tables: escape user e-mails 
Better safe than sorry.


git-svn-id: https://develop.svn.wordpress.org/trunk@34133 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 22:32:52 +00:00
Scott Taylor
a9e1f79323 In the edit-comments.php admin handler, toggle wp_defer_comment_counting() so that only unique post IDs have their comment count updated. Currently, if you delete 50 comments from the same post, the count would get reset 50 times. Not joking. 
See #33875.


git-svn-id: https://develop.svn.wordpress.org/trunk@34132 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 22:23:43 +00:00
Scott Taylor
545da32217 The "counts" cache for comments by post id is never invalidated. Neither wp_update_comment_count() nor wp_update_comment_count_now() touch the cache. 
Adds unit test.
See #33875.


git-svn-id: https://develop.svn.wordpress.org/trunk@34131 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 22:03:23 +00:00
Scott Taylor
b42a906512 wp_unspam_comment() can accept a full object instead of comment_ID to reduce cache/db lookups.. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@34130 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 21:46:40 +00:00
Scott Taylor
166ee8674b More comment functions can accept a full object instead of comment_ID to reduce cache/db lookups. 
See ##33638.



git-svn-id: https://develop.svn.wordpress.org/trunk@34129 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 21:39:46 +00:00
Scott Taylor
ab7ca361dd In WP_List_Table, make a new public method, ->get_primary_column(), and revert [34101] due to BC issues. 
Fixes #33854.


git-svn-id: https://develop.svn.wordpress.org/trunk@34128 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 20:28:29 +00:00
Scott Taylor
ea610e66d4 In WP_Media_List_Table, fetch all pending comment counts at once, instead of for each row in the loop. 
See #11381.


git-svn-id: https://develop.svn.wordpress.org/trunk@34127 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 19:24:59 +00:00
Boone Gorges
974517d2bc Accept 'ID' as a valid $field in get_user_by(). 
We already accept 'id'. `ID` more closely matches the database and
`WP_User` schemas.

Props Shelob9.
Fixes #33869.

git-svn-id: https://develop.svn.wordpress.org/trunk@34125 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 18:57:15 +00:00
John Blackbourn
9700eb511e Add the site icon meta tags to wp-login.php. 
See #33597
Props iworks


git-svn-id: https://develop.svn.wordpress.org/trunk@34124 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 18:01:22 +00:00
Scott Taylor
2c91a4d1e0 Fix the case-sensitivity of some HTTP class usage. 
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34123 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 17:36:37 +00:00
John Blackbourn
811e538325 Update links to the user profile editing screen in the admin toolbar when the current logged in user has no role on the current site. Covers single site and Multisite and introduces tests. 
Fixes #25162


git-svn-id: https://develop.svn.wordpress.org/trunk@34122 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 17:09:58 +00:00