Dion Hulse
9d0c957410
Background Updates: Introduce support to take advantage of Group Writable (or World Writable) to Core Background updates.
...
This is only enabled when new files will not be installed during the update (as indicated by the WordPress.org API), and does not apply to Plugin/Theme/Translation Background Updates.
Additionally, the code to determine if the 'direct' filesystem transport should be used has been tweaked for wider support (where getmyuid() was unavailalbe) which fixes #10424
See #10205 , #30245
git-svn-id: https://develop.svn.wordpress.org/trunk@30384 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-19 05:39:52 +00:00
Scott Taylor
6c5e90eaa5
Correct some types in wp-admin/*
-location files' doc blocks.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30203 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 07:08:16 +00:00
Drew Jaynes (DrewAPicture)
3cc10d77a0
Remove redundant and erroneous @uses
tag from most core inline documentation.
...
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.
Fixes #30191 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30105 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 01:04:55 +00:00
Scott Taylor
45a635d8c2
In _wp_handle_upload()
, if test_upload
is set to false
in the array of dangerous overrides that the function allows, the only thing that happens when an upload fails is more potential breakage.
...
`$test_uploaded_file` lets is know if `$file['tmp_name']` exists, which allows to exit with an error, instead of continuing to attempt to move the file.
`$test_upload` override is now a noop.
Fixes #28208 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30076 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 21:16:06 +00:00
Andrew Nacin
9c751b268a
Don't set ftp_credentials option when installling. see #29635 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@29749 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-17 17:57:59 +00:00
Dominik Schilling (ocean90)
7770a90d74
Add missing array keys for connection type in request_filesystem_credentials()
.
...
see [28456].
fixes #29347 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29580 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 16:04:01 +00:00
Scott Taylor
1cbe1cec12
In sanitize_file_name()
, replace %20
and +
with dashes. Remove unnecessary code from _wp_handle_upload()
.
...
Adds unit tests.
Props ericmann.
Fixes #16330 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29290 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 22:08:09 +00:00
Scott Taylor
f59a307e10
Merge wp_handle_upload()
and wp_handle_sideload()
by making them each wrap a new function: _wp_handle_upload()
.
...
Props DrewAPicture for docs.
Fixes #23686 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29209 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 18:57:26 +00:00
Drew Jaynes (DrewAPicture)
6ddc1e5f6d
Fix syntax for single- and multi-line comments in wp-admin-directory files.
...
See #28931 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29206 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 09:13:53 +00:00
John Blackbourn
3426416dac
Normalise the schemes used in get_home_path()
so it returns the correct path for sites using SSL in the admin area but not the front end. Fixes #25767 . Props GregLone for the initial patch.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28893 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 10:28:52 +00:00
Scott Taylor
ccc874514c
Eliminate use of extract()
in request_filesystem_credentials()
.
...
The only property that doesn't need to be set to a variable is `$password`.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28456 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 18:25:41 +00:00
Scott Taylor
ec17088ff6
Update inline docs for wp_handle_upload|sideload
to reflect their non-use of extract()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28452 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 17:40:44 +00:00
Scott Taylor
8f8b12e6a6
Eliminate use of extract()
in wp_handle_sideload()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28451 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 16:14:56 +00:00
Scott Taylor
176d361626
Eliminate use of extract()
in wp_handle_upload()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28450 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 16:10:00 +00:00
Scott Taylor
650e0580e4
Eliminate one of the uses of extract()
in wp_handle_upload()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28417 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 04:30:32 +00:00
Scott Taylor
219ad73200
Eliminate one of the uses of extract()
in wp_handle_sideload()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28416 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 04:28:24 +00:00
Scott Taylor
e42ec45553
Dead code in wp-admin/includes/file.php
:
...
* In `wp_handle_upload()` and `wp_handle_sideload()`, `$ext` gets conditionally reset... and then is never used.
* In `request_filesystem_credentials()`, `$password` is initialized as an empty string. The variable is never used.
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28268 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 04:21:35 +00:00
Sergey Biryukov
a97e9018c4
Fix typo in verify_file_md5() description. see [25541].
...
props siobhan.
see #27651 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27938 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 00:02:12 +00:00
Drew Jaynes (DrewAPicture)
af0f9a5e00
Inline documentation for hooks in wp-admin/includes/file.php.
...
Fixes #27429 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27672 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-24 02:44:17 +00:00
Dion Hulse
526bf7d352
WP_Filesystem: Update request_filesystem_credentials() to handle the correct ssh value of FS_METHOD. Props jnielsendotnet. Fixes #27265
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27546 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-15 03:08:47 +00:00
Sergey Biryukov
a53fab8750
Avoid an undefined index notice in wp_handle_upload().
...
props tivnet.
fixes #27225 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27319 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-27 21:15:31 +00:00
Andrew Nacin
4cfcdabdd8
Simplify error in validate_file_to_edit().
...
props MattyRob for initial patch.
fixes #25924 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27219 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-21 14:45:06 +00:00
Andrew Ozz
48d24f6bf5
Remove all "valign" attributes from tables in wp-admin, props MikeHansenMe, Marventus. Fixes #22712 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27029 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-24 19:05:15 +00:00
Drew Jaynes
bd39e26032
First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.
...
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713 .
git-svn-id: https://develop.svn.wordpress.org/trunk@26868 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-24 18:56:05 +00:00
Andrew Nacin
1a7bfffd0b
Only enforce disk free space checks when doing background updates.
...
see #25652 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25869 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 18:17:13 +00:00
Dion Hulse
3ce626a96b
Silence PHP warnings from disk_free_space(). disk_free_space() will produce a warning in error conditions in addition to returning false, this includes a case where the bytes free is greater than PHP_INT_MAX (which is a error condition we don't need to check).
...
See #25576 , #22704
git-svn-id: https://develop.svn.wordpress.org/trunk@25831 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 18:39:04 +00:00
Dion Hulse
ddaaa6d88a
Language Packs: Many many fixes such as:
...
- Add a "Update Translations" stand-alone button to the updates page
- Shift Language feedback to before update process completion action links & limit the verbosity of output (name + success/errors)
- Simplify/combine the language update descriptive string to only include a plugin/theme name
- Properly handle cache clearing after language updates to prevent langs being repeditively updated
- Display a "All items up to date" string when there's nothing to do
- Reduce the 'Connection Information' from a <h2> to a <h3> to remove duplicate h2's and screen icons from update screens
- Fix the Direct filesystem method not being used for Language updates because WP_LANG_DIR doesn't exist (check it's parent for writable instead)
See #18200 , #22704
git-svn-id: https://develop.svn.wordpress.org/trunk@25806 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-16 04:14:29 +00:00
Andrew Nacin
3b724d5082
Remove accidental debug cruft in [25780]. see #22704 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25799 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-15 21:24:01 +00:00
Andrew Nacin
c72ba036cf
Use FS_CHMOD_FILE rather than an explicit 0644 in copy_dir() and _copy_dir().
...
This occurs when we can't copy a file. We chmod it and try again.
see #22704 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25793 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-15 19:13:33 +00:00
Andrew Nacin
3eac3d0380
Parse absolute paths out of error data. see #22704 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25780 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 22:24:28 +00:00
Dion Hulse
b492ae85f8
Remove PHP4 compat code from the ZipArchive unzip handler, and pass the failure reason into the WP_Error return.
...
See #22704
git-svn-id: https://develop.svn.wordpress.org/trunk@25779 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 21:54:33 +00:00
Andrew Nacin
b8efab15d8
Account for possible failures by disk_free_space(), as well as the potential need to copy the unzipped files.
...
see #25576 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25776 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 20:57:28 +00:00
Andrew Nacin
5db3863d12
In unzip_file(), confirm we have enough available disk space before extracting.
...
"enough" is calculated by adding up the uncompressed size of the files in the archive, then adding a 20% buffer.
props dd32.
fixes #25576 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25774 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 20:14:13 +00:00
Andrew Nacin
2e605e76c6
Refine error codes throughout the upgrader so we can better detect at what stage updates fail.
...
see #22704 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25763 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-11 16:05:13 +00:00
Dion Hulse
28736216f3
Upgrader: Create Directories with a minimum of 0755 and files with a minimum of 0644 when upgrading, which matches pre-3.7 behaviour. Fixes #20069
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25739 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-09 16:46:31 +00:00
Dion Hulse
f377693931
When using download_url(), if the resource supplies a Content-MD5 header, verify the downloaded file against it. Fixes #20074
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25541 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-21 06:53:50 +00:00
Dion Hulse
eb3bee3ba5
Upgrader: Perform a MD5 file verification check on the files during upgrade. This ensures that both a Partial upgrade build can be used, and that all the files were copied into place correctly.
...
Props pento for initial patch. Fixes #18201
git-svn-id: https://develop.svn.wordpress.org/trunk@25540 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-21 06:48:20 +00:00
Dion Hulse
ea24e2ce0d
WordPress Upgrades: When defining the default filesystem permissions for files/directories, base the value on the existing ABSPATH & index.php file permissions - so as to respect the executable bit (if set) and not set global read if not required.
...
This sets a minimum permission set to 750 and 640 for directories and files, so any systems requring less permission than that will still need to define the constants themselves. Fixes #20069
git-svn-id: https://develop.svn.wordpress.org/trunk@25469 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-17 08:05:23 +00:00
Dion Hulse
47c25b41af
Switch unzip_file() over to using the mbstring.func_override helper functions. See #25259
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25347 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 08:08:35 +00:00
Sergey Biryukov
4e75fe1bf1
Move get_real_file_to_edit() to wp-admin/includes/deprecated.php. props iamfriendly. fixes #23680 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25201 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-01 12:36:45 +00:00
Dion Hulse
ead4efa78a
Add a note that the FTP Password will not be stored on the server to the FTP credentials page. Fixes #16492
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25071 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-21 07:06:12 +00:00
Dion Hulse
e4361d8f96
Check to see if mbstring.func_overload is configured to affect string functions before switching charsets. Props SergeyBiryukov. Fixes #25063
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25056 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-20 06:23:48 +00:00
Andrew Nacin
b43712e0f7
New develop.svn.wordpress.org repository based on the old core.svn repository.
...
* All WordPress files move to a src/ directory.
* New task runner (Grunt), configured to copy a built WordPress to build/.
* svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
* Remove Akismet external from develop.svn. Still exists in core.svn.
* Drop minified files from src/. The build process will now generate these.
props koop.
see #24976 .
and see http://wp.me/p2AvED-1AI .
git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00