Commit Graph

26162 Commits

Author SHA1 Message Date
Scott Taylor 376125e0b7 In `wp-includes/class-wp-admin-bar.php`, `break` is unreachabled after `return`.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28318 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:28:46 +00:00
Scott Taylor c5463c5cb2 In `WP_Http_Curl::request()`, `$theResponse` is unused. There are other `curl_exec()` calls that do not return as well.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28317 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:26:00 +00:00
Scott Taylor 5df63351b2 In `wp-includes/bookmark.php`, remove dead code:
* In `get_bookmarks()`, `$cache` is set twice before it is used. 
* In `sanitize_bookmark_field()`, `break` is unreachable after `return`

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28316 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:21:50 +00:00
Scott Taylor 22743ee2c4 In `wp-admin/users.php`, `break` is unreachabled after `exit`.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28315 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:18:12 +00:00
Scott Taylor 64fbddfcd5 In `core_upgrade_preamble()`, `$alternate` is set then never used.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28314 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:16:34 +00:00
Scott Taylor cb0578d77e In `wp-admin/theme-editor.php`, `break` is unreachabled after `exit`.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28313 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:15:18 +00:00
Scott Taylor 0f9b925ed5 In `wp-admin/post.php`, `break` is unreachabled after `exit`.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28312 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:14:16 +00:00
Scott Taylor a9dfbabfe7 In `wp-admin/plugins.php`, `break` is unreachabled after `exit`.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28311 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:12:44 +00:00
Scott Taylor e742c23af9 In `wp-admin/plugin-editor.php`, `break` is unreachabled after `exit`.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28310 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:11:30 +00:00
wonderboymusic 1da6728dc0 In `wp-admin/network/users.php`, `break` is unreachabled after `exit`.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28309 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:10:01 +00:00
Scott Taylor aa7cef0549 In `wp-admin/network/themes.php`, `break` is unreachabled after `exit`.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28308 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:07:33 +00:00
Scott Taylor 81acc42361 In `wp-admin/link.php`, `break` is unreachabled after `exit`.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28307 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:05:09 +00:00
Scott Taylor e1f5876ac4 In `display_setup_form()`, `$admin_password` is set and (fortunately) not used or displayed.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28306 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:03:34 +00:00
Scott Taylor 3ed59ca164 In `wp-admin/includes/upgrade.php`, remove dead code:
* In `maybe_create_table()` and `maybe_add_column()`, the response of `$wpdb->query()` is set to a variable that is never used.
* In `make_db_current_silent()`, which is a wrapper for `dbDelta`, a variable is set that is not used. This function appears to be a copy-paste of `make_db_current()`'s `dbDelta()` call but is meant to return nothing, and still does not.  

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28305 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 17:26:47 +00:00
Scott Taylor 74ad050063 In `wp-admin/includes/update.php`, remove dead code:
* In `get_core_checksums()`, `$return` is set and never used.
* In `core_update_footer()`, `break` is unnecessary and unreachable after `return`.
* In `get_theme_updates()`, `$themes` is set and never used.
* In `wp_theme_update_row()`, `$theme_name` is the only user of `$themes_allowedtags`... neither are used. 	

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28304 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 17:20:10 +00:00
Scott Taylor fb1054340f In `WP_Screen::render_screen_options()`, remove dead code:
* `$wp_list_table` does not need to be imported.
* `$post` is set and never used.

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28303 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 17:13:30 +00:00
Scott Taylor b64da2cb60 In `get_sample_permalink_html()`, `$view_link` is set and never used.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28302 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 17:10:41 +00:00
Scott Taylor 5d2b452351 In `install_plugin_information()`, `$title` is set in a `foreach` loop and never used. This appears to be due to copy-pasting a previous `foreach` loop and not discarding these bits.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28301 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 16:59:29 +00:00
Scott Taylor ffa620b972 In `wp-admin/includes/nav-menu.php`, remove dead code:
* In `_wp_ajax_menu_quick_search()`, in an `else` block, `$post_obj` was set and not used. Another block sets it again and does use it. 
* In `wp_nav_menu_item_post_type_meta_box()`, `$post_type_object` was set and, sadly, never used. `$error` was set and not used. 

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28300 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 16:54:10 +00:00
Scott Taylor e518d0d652 In `update_option_new_admin_email()`, `$email` is set and never used.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28299 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 16:47:56 +00:00
Scott Taylor ee13be0315 In `attachment_submit_meta_box()`, remove dead code:
* `$action` doesn't need to be imported.
* `$can_publish` is set and never used, which means it doesn't need...
* `$post_type_object` or `$post_type`, which only served `$can_publish`.

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28298 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 16:44:38 +00:00
Scott Taylor d92f5aa154 In `get_media_item()`, `$tags` and `$_tags` are set and never used.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28297 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 16:40:52 +00:00
Scott Taylor fc624a4298 In `WP_Users_List_Table::get_views()`, `$current_role` is set and never used.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28296 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 15:32:16 +00:00
Scott Taylor 1e68b7dab4 In `WP_MS_Users_List_Table::get_views()`, remove dead code:
* `$wp_roles` doesn't need to be imported.
* `$current_role` is set and never used.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28295 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 15:29:22 +00:00
Dominik Schilling (ocean90) b09a91a666 Custom Header: Fix logic when a theme doesn't set `default-text-color`.
fixes #28042.

git-svn-id: https://develop.svn.wordpress.org/trunk@28294 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 15:26:46 +00:00
Scott Taylor 36abe7909c In `WP_Media_List_Table`, remove dead code:
* In `->prepare_items()`, importing `$wpdb` is unnecessary.
* In `->get_columns()`, `$taxonomies` is set twice before it is used.
* In `->display_rows()`, `$taxonomy_object` is set and never used.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28293 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 15:26:32 +00:00
Scott Taylor 41d1eb8f56 In `ajax-actions.php`, remove dead code:
* In `wp_ajax_add_tag()`, `$post_type` is set and never used.
* In `wp_ajax_hidden_columns()`, `$hidden` is set twice, but only checks for the existence of `$_POST['hidden']` the first time. The two lines can be combined and work together.
* In `wp_ajax_inline_save()`, `$mode` is set and never used.
* In `wp_ajax_find_posts()`, `$searchand = $search = '';` is leftover cruft, neither variable is used. `$wpdb` does not need to be imported, it is never used.
* In `wp_ajax_wp_fullscreen_save_post()`, `$post_type` is set and never used.
* In `wp_ajax_save_attachment_order()`, `$post` is set and never used.
* In `wp_ajax_send_attachment_to_editor()`, `$title` is set and never used. 

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28292 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 15:18:42 +00:00
Scott Taylor 909d11cd28 Remove unreachable `break` statements in `wp-admin/edit-tags.php`. `break` is unnecessary after `die`, `exit`, and `wp_die`.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28291 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 14:51:47 +00:00
Scott Taylor 88ad28ffdf In `wp-admin/custom-header.php`, `$default_color` is set twice before it is used. The first is unnecessary.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28290 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 14:50:05 +00:00
Scott Taylor ab01399666 Remove unreachable `break` statements in `wp-admin/comments.php`. `break` is unnecessary after `die`, `exit`, and `wp_die`.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28289 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 14:45:22 +00:00
Sergey Biryukov 7f754fa2e8 Translate a string added in 3.7 but never translated previously.
props andrezrv.
fixes #28025.

git-svn-id: https://develop.svn.wordpress.org/trunk@28288 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 12:48:49 +00:00
Sergey Biryukov 4b8b0e7178 Use a consistent context to remove duplicate strings.
props pavelevap.
fixes #28123.

git-svn-id: https://develop.svn.wordpress.org/trunk@28287 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 12:33:08 +00:00
Sergey Biryukov 046a2bff94 Add context for 'Previous' and 'Next' theme strings.
see #28120, for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@28286 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 12:19:41 +00:00
Sergey Biryukov d7a159bf81 Add a filter for wp_list_comments() arguments.
props greenshady, hlashbrooke.
fixes #19581.

git-svn-id: https://develop.svn.wordpress.org/trunk@28285 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 11:57:36 +00:00
Dominik Schilling (ocean90) c30bb2fd2b Add missing Dashicons classes to User Admin menu.
props imath.
see #28144, #26630.

git-svn-id: https://develop.svn.wordpress.org/trunk@28284 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 07:57:52 +00:00
Drew Jaynes (DrewAPicture) 8764f791f1 Where a filter no longer exists, it need not be notated.
Fixes #24444. See r28258.


git-svn-id: https://develop.svn.wordpress.org/trunk@28283 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 05:37:17 +00:00
Andrew Nacin cb022f4957 Multisite: Treat 'www' as a special subdomain, reversing 3.9 regression.
props jeremyfelt.
fixes #27927.


git-svn-id: https://develop.svn.wordpress.org/trunk@28280 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 05:31:12 +00:00
Scott Taylor 555937dc43 In `WP_List_Table::display_rows_or_placeholder()`, the call to `get_column_info()` in unnecessary and unused. The call to `get_column_count()` immediately after makes the same call internally.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28279 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 05:31:07 +00:00
Andrew Nacin 7839dd671c Multisite: Fix case sensitivity regressions in 3.9.
props jeremyfelt.
fixes #27866.


git-svn-id: https://develop.svn.wordpress.org/trunk@28276 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 05:23:56 +00:00
Andrew Nacin c0822b532e Custom header: Avoid warnings in the process_default_headers() method.
props obenland.
fixes #27850.


git-svn-id: https://develop.svn.wordpress.org/trunk@28275 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 05:06:39 +00:00
Scott Taylor a1c6a10489 In `general-template.php` - remove dead code:
* In `get_calendar()`, `$cache` is set twice. The first is useless. 
* In `wp_default_editor()`, `$user` is (accidentally) assigned in a condition. Since it is never used, this is unnecessary.
* In `language_attributes()`, `$output` is set twice before it is ever used. The first is unnecessary. 
* In `paginate_links()`, `$n` is set twice before it is ever used. The first is unnecessary.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28274 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 04:57:22 +00:00
Scott Taylor f95a4c70be In `edit_form_image_editor()`, `$filename` and `$title` are set and then unused. They shall be removed.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28271 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 04:44:56 +00:00
Andrew Nacin 9259c6baa7 Customizer: Only tie header button action events to the header controls.
props danielbachhuber.
fixes #28046. see #27848.


git-svn-id: https://develop.svn.wordpress.org/trunk@28269 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 04:29:14 +00:00
Scott Taylor e42ec45553 Dead code in `wp-admin/includes/file.php`:
* In `wp_handle_upload()` and `wp_handle_sideload()`, `$ext` gets conditionally reset... and then is never used.
* In `request_filesystem_credentials()`, `$password` is initialized as an empty string. The variable is never used.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28268 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 04:21:35 +00:00
Andrew Nacin 7ada7af9d0 Customizer: Avoid hiding 'Remove' buttons unrelated to custom headers.
props rzen, ehg.
fixes #27848.


git-svn-id: https://develop.svn.wordpress.org/trunk@28266 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 04:13:52 +00:00
Scott Taylor eda51bf856 Remove duplicate variable setting for `$link` in `wp_list_authors()`.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28265 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 03:51:42 +00:00
Scott Taylor f97deae591 Remove unused variable setting for `$revisions` in `wp_prepare_revisions_for_js()`.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28264 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 03:44:30 +00:00
Scott Taylor 4c6f405ee7 Remove a dead variable, `$start`, from `wp_dashboard_recent_comments()`.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28263 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 03:34:22 +00:00
Andrew Nacin 4b6d5b10d4 Move 'home' option to the top of populate_options().
fixes #28141.


git-svn-id: https://develop.svn.wordpress.org/trunk@28260 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 21:56:11 +00:00
Scott Taylor 2b1619329e Add `.dfxp` and `.srt` files to mime-type whitelist in `wp_get_mime_types()`. They are both captioning formats supported by MediaElement.
Props joedolson.
Fixes #27643.



git-svn-id: https://develop.svn.wordpress.org/trunk@28259 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 20:07:53 +00:00