sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
27,172 Commits 2 Branches 473 Tags 137 MiB
de313ebf30
Commit Graph

730 Commits

Author SHA1 Message Date
Scott Taylor
e53cdbb8f0 In wp_dashboard_recent_posts(), $i is set and never used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28545 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 18:55:07 +00:00
Scott Taylor
70342f4a75 $theme_name is set but no longer used in wp_dashboard_right_now(). The theme name is displayed with the call to update_right_now_message(). 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28544 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 18:53:43 +00:00
Scott Taylor
312ef7b264 These functions import $wpdb but do not use it. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28539 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 17:36:42 +00:00
Sergey Biryukov
15588188e8 Fix inconsistent header underlining and spacing in background update emails. 
fixes #28306.

git-svn-id: https://develop.svn.wordpress.org/trunk@28537 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 09:40:36 +00:00
Sergey Biryukov
9966795165 Use correct function name. 
props ericlewis.
fixes #28329.

git-svn-id: https://develop.svn.wordpress.org/trunk@28535 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 07:58:26 +00:00
Scott Taylor
dc1ada20c7 Upgrade _WP_List_Table_Compat to PHP5-style constructor. 
Add `public` to methods/members of `WP_Role`.
Add `public` to methods/members of `WP_User` where appropriate. Don't set `private` where indicated until more study has occurred and tests have been written for compatibiliy with existing magic methods.

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28531 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 17:19:09 +00:00
Scott Taylor
d261d0030a In WP_Filesystem_Base, the constructor is a noop, so it shouldn't even be declared. Setting it implies that parent::__construct() should be called by its subclasses. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28529 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 16:45:42 +00:00
Scott Taylor
daecbc9659 Classes that have __set() also need __isset() and __unset(). 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28524 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 06:51:35 +00:00
Scott Taylor
77c6420969 Some classes with __get() method also need __set(). 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28521 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 06:31:00 +00:00
Scott Taylor
f716ff94e4 Add missing access modifiers to methods/members in Walker and subclasses. Add a magic __get() method. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28514 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:59:07 +00:00
Scott Taylor
e43d2a73d8 Fix some hackificator odds and ends in wp-admin: 
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28500 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:03:44 +00:00
Drew Jaynes (DrewAPicture)
7b2c87df9a Improve inline documentation of default arguments for post_format_meta_box(), post_tags_meta_box(), and post_categories_meta_box(). 
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28499 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 03:22:21 +00:00
Scott Taylor
eef0d99ed8 hackificator doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28497 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:58:28 +00:00
Scott Taylor
afe33f0f68 Add access modifier (public) to methods and members of WP_Upgrader and its subclasses. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28496 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:28:10 +00:00
Scott Taylor
17cabb1d8e Add access modifier (public) to methods and members of WP_Upgrader_Skin and its subclasses. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28495 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:22:55 +00:00
Scott Taylor
b1a09cf65d Add access modifiers to methods and members of WP_Users_List_Table. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28494 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:18:46 +00:00
Scott Taylor
d6a3c2a0de Add access modifiers to methods and members of list table classes: 
* `WP_List_Table` is the base class that implements `__get()` and `__call()` for BC
* Adds unit tests to confirm that subclasses properly inherit magic methods
* Add modifiers to subclasses: `WP_Links_List_Table`, `WP_Media_List_Table`, `WP_MS_Sites_List_Table`, `WP_MS_Themes_List_Table`, `WP_MS_Users_List_Table`, `WP_Plugin_Install_List_Table`, `WP_Plugins_List_Table`, `WP_Posts_List_Table`, `WP_Terms_List_Table`, `WP_Theme_Install_List_Table`, `WP_Themes_List_Table`

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28493 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:16:16 +00:00
Scott Taylor
99c99b77e3 Add access modifier (public) to methods in WP_Importer. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28492 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:19:00 +00:00
Scott Taylor
ae31b3795c Add access modifier (public) to members and methods in WP_Filesystem_SSH2. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28491 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:17:18 +00:00
Scott Taylor
fce8b1e0c3 Add access modifier (public) to members and methods in WP_Filesystem_ftpsockets. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28490 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:13:29 +00:00
Scott Taylor
434ce7f6d8 Add access modifier (public) to members and methods in WP_Filesystem_FTPext. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28489 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:11:21 +00:00
Scott Taylor
ec06d96ce6 Add access modifier (public) to methods in WP_Filesystem_Direct. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28488 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:08:38 +00:00
Scott Taylor
06672a6c5a Add access modifiers to members and methods in WP_Filesystem_Base. Add magic __get() method for backwards compatibility. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28487 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:05:06 +00:00
Scott Taylor
6e09b1f167 Add access modifier (public) to members and methods in WP_Comments_List_Table and WP_Post_Comments_List_Table. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28486 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 23:58:38 +00:00
Scott Taylor
1b4e4e665a hackificator complains if you call include 'file.php' without the parens, needs to be include( 'file.php' ) 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28479 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 20:51:44 +00:00
Sergey Biryukov
0cc180b0a4 Fix wp_insert_link(), broken in [28406]/[28408]. 
see #22400.

git-svn-id: https://develop.svn.wordpress.org/trunk@28475 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 09:55:16 +00:00
Drew Jaynes (DrewAPicture)
9e81d2d692 Add inline documentation for default arguments in wp_insert_category(). 
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28474 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 07:27:25 +00:00
Scott Taylor
40e6ec443f Add inline comment after fix in [28467]. 
Props jesin.
Fixes #28292.



git-svn-id: https://develop.svn.wordpress.org/trunk@28468 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 15:41:40 +00:00
Scott Taylor
14a7b47119 Restore $soucrce in WP_Upgrader::install_package(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28467 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 15:39:33 +00:00
Scott Taylor
ccc874514c Eliminate use of extract() in request_filesystem_credentials(). 
The only property that doesn't need to be set to a variable is `$password`.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28456 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 18:25:41 +00:00
Scott Taylor
ec17088ff6 Update inline docs for wp_handle_upload|sideload to reflect their non-use of extract(). 
See #22400.



git-svn-id: https://develop.svn.wordpress.org/trunk@28452 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 17:40:44 +00:00
Scott Taylor
8f8b12e6a6 Eliminate use of extract() in wp_handle_sideload(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28451 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 16:14:56 +00:00
Scott Taylor
176d361626 Eliminate use of extract() in wp_handle_upload(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28450 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 16:10:00 +00:00
wonderboymusic
30dcd2c3e9 Eliminate the use of extract() in WP_Upgrader. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28418 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 05:01:02 +00:00
Scott Taylor
650e0580e4 Eliminate one of the uses of extract() in wp_handle_upload(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28417 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 04:30:32 +00:00
Scott Taylor
219ad73200 Eliminate one of the uses of extract() in wp_handle_sideload(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28416 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 04:28:24 +00:00
Scott Taylor
c4b23f9fc3 Eliminate use of extract() in Walker_Category_Checklist::start_el(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28411 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 03:13:44 +00:00
Scott Taylor
85d6f8e54f Eliminate use of extract() in wp_terms_checklist(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28410 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 03:08:46 +00:00
Scott Taylor
98ca12ef2e Eliminate use of extract() in wp_star_rating(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28409 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:56:56 +00:00
Scott Taylor
5e046b92fd (REALLY) Eliminate use of extract() in wp_insert_link(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28408 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:54:27 +00:00
Scott Taylor
27ff2a1cd0 Eliminate use of extract() in get_media_item(). 
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`	
	
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28407 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:45:01 +00:00
Scott Taylor
e0ddd2ebf0 Eliminate use of extract() in wp_insert_link(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28406 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:27:55 +00:00
Scott Taylor
bc17731c23 Eliminate use of extract() in post_tags_meta_box() and post_categories_meta_box(). 
Both functions only need to read `taxonomy`, yet they extract every available variable from `$box['args']`. Even if those variables were useful, there is no attempt to pass them to anything, and scope in PHP does not allow them to be scooped up by inner functions without being passed directly.
	
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28391 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:47:03 +00:00
Scott Taylor
b72bd1c40f Eliminate use of extract() in WP_Terms_List_Table::display_rows_or_placeholder(): 
* Set variables for `$page` and `$number`
* `list(...) = $this->get_column_info()` can be removed, as none of the variables returned are used.
* `orderby` and `search` can be checked from `$args`, leaving no reason to extract		

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28390 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:36:22 +00:00
Scott Taylor
7c0e12f5c6 Eliminate use of extract() in WP_List_Table::pagination(): 
* Set variables instead of extracting `$this->_pagination_args`
* Weird: `$infinite_scroll` is only presently set in subclasses of `WP_List_Table` and never initialized otherwise. 		

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28389 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:26:34 +00:00
Scott Taylor
31e187faa3 Eliminate use of extract() in WP_Plugin_Install_List_Table::get_table_classes(). It only needs to read plural, no need to extract. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28388 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:16:39 +00:00
Scott Taylor
fac2faee93 Eliminate use of extract() in WP_List_Table::ajax_response(): 
* Extracting `$this->_args` is unnecessary since none of the variables produced are present in the method.
* `total_items` and `total_pages` can be read directly from `$this->_pagination_args`

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28387 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:13:09 +00:00
Scott Taylor
a2122e6f7b Eliminate use of extract() in WP_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28386 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:07:11 +00:00
Scott Taylor
878a974477 Eliminate use of extract() in WP_Post_Comments_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary. 
Eliminate use of `extract()` in `WP_Comments_List_Table::display()`. The method uses no variables. Extraction can be completely removed.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28385 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:03:26 +00:00
Scott Taylor
4e0809e3e4 Eliminate use of extract() in wp_insert_category(). Adds unit tests. All unit tests pass. 
Props MikeHansenMe.
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28374 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 03:26:51 +00:00
Scott Taylor
3f59b86ec5 In media_upload_gallery_form()'s inline JavaScript, remove unnecessary comment tags. 
Fixes #25637.



git-svn-id: https://develop.svn.wordpress.org/trunk@28368 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 06:11:08 +00:00
Scott Taylor
3a554b5249 In wp_read_image_metadata(), the values from exif_read_data() should only override values from iptcparse() that are empty. 
Props SergeyBiryukov.
Fixes #23706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28367 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 05:53:27 +00:00
Scott Taylor
147eeb2147 Avoid a notice in wp_save_image() by checking $meta['sizes']['thumbnail'] for ! empty() before setting a variable to it. 
Props MikeHansenMe.
Fixes #17736.



git-svn-id: https://develop.svn.wordpress.org/trunk@28366 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 03:41:31 +00:00
Scott Taylor
d007994bf3 In WP_Terms_List_Table::single_row(), call sanitize_term() on the passed term ($tag). 
Props oso96_2000, c3mdigital, scribu. 
It takes a village.
Fixes #16864.


git-svn-id: https://develop.svn.wordpress.org/trunk@28360 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 00:04:38 +00:00
Scott Taylor
a398f38024 First pass at wpview logic for the [embed] shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet. 
Props avryl, wonderboymusic.
See #28195.



git-svn-id: https://develop.svn.wordpress.org/trunk@28358 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-10 23:35:08 +00:00
Drew Jaynes (DrewAPicture)
f3d9e1ed7e Fix mid-file section header style in wp-admin/includes/ajax-actions.php. 
See #28200.


git-svn-id: https://develop.svn.wordpress.org/trunk@28356 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-10 05:01:15 +00:00
Drew Jaynes (DrewAPicture)
de13f1a60c Add baseline doc blocks for all ajax handlers in ajax-actions.php. 
Fixes #28200.


git-svn-id: https://develop.svn.wordpress.org/trunk@28355 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-10 04:59:34 +00:00
Drew Jaynes (DrewAPicture)
0b51b6da2e Minor phpDoc fixes for the got_rewrite, got_url_rewrite, and documentation_ignore_functions hooks. 
Props GaryJ.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28352 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-08 11:12:11 +00:00
Drew Jaynes (DrewAPicture)
bbd130fe15 Use interpolation instead of concatenation for the manage_{$screen->id}_columns hook name. 
Props Otto42.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28348 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-08 09:57:11 +00:00
Drew Jaynes (DrewAPicture)
30c21227be Use an interpolated hook name for edit_{$post_type}_per_page instead of $per_page and adjust docs accordingly. 
Also references the correct variable for the `$posts_per_page` parameter in the `edit_posts_per_page` hook doc.

Props Otto42 for the initial patch.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28347 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-08 08:15:48 +00:00
Scott Taylor
7531fd0070 Leverage size_format() when displaying max_upload_size: 
* In `media_upload_form()` 
* The `uploader-inline` Underscore template in the media modal. 

Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.

Fixes #25643.



git-svn-id: https://develop.svn.wordpress.org/trunk@28343 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 18:24:47 +00:00
Scott Taylor
3ed59ca164 In wp-admin/includes/upgrade.php, remove dead code: 
* In `maybe_create_table()` and `maybe_add_column()`, the response of `$wpdb->query()` is set to a variable that is never used.
* In `make_db_current_silent()`, which is a wrapper for `dbDelta`, a variable is set that is not used. This function appears to be a copy-paste of `make_db_current()`'s `dbDelta()` call but is meant to return nothing, and still does not.  

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28305 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 17:26:47 +00:00
Scott Taylor
74ad050063 In wp-admin/includes/update.php, remove dead code: 
* In `get_core_checksums()`, `$return` is set and never used.
* In `core_update_footer()`, `break` is unnecessary and unreachable after `return`.
* In `get_theme_updates()`, `$themes` is set and never used.
* In `wp_theme_update_row()`, `$theme_name` is the only user of `$themes_allowedtags`... neither are used. 	

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28304 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 17:20:10 +00:00
Scott Taylor
fb1054340f In WP_Screen::render_screen_options(), remove dead code: 
* `$wp_list_table` does not need to be imported.
* `$post` is set and never used.

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28303 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 17:13:30 +00:00
Scott Taylor
b64da2cb60 In get_sample_permalink_html(), $view_link is set and never used. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28302 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 17:10:41 +00:00
Scott Taylor
5d2b452351 In install_plugin_information(), $title is set in a foreach loop and never used. This appears to be due to copy-pasting a previous foreach loop and not discarding these bits. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28301 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:59:29 +00:00
Scott Taylor
ffa620b972 In wp-admin/includes/nav-menu.php, remove dead code: 
* In `_wp_ajax_menu_quick_search()`, in an `else` block, `$post_obj` was set and not used. Another block sets it again and does use it. 
* In `wp_nav_menu_item_post_type_meta_box()`, `$post_type_object` was set and, sadly, never used. `$error` was set and not used. 

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28300 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:54:10 +00:00
Scott Taylor
e518d0d652 In update_option_new_admin_email(), $email is set and never used. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28299 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:47:56 +00:00
Scott Taylor
ee13be0315 In attachment_submit_meta_box(), remove dead code: 
* `$action` doesn't need to be imported.
* `$can_publish` is set and never used, which means it doesn't need...
* `$post_type_object` or `$post_type`, which only served `$can_publish`.

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28298 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:44:38 +00:00
Scott Taylor
d92f5aa154 In get_media_item(), $tags and $_tags are set and never used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28297 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:40:52 +00:00
Scott Taylor
fc624a4298 In WP_Users_List_Table::get_views(), $current_role is set and never used. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28296 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 15:32:16 +00:00
Scott Taylor
1e68b7dab4 In WP_MS_Users_List_Table::get_views(), remove dead code: 
* `$wp_roles` doesn't need to be imported.
* `$current_role` is set and never used.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28295 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 15:29:22 +00:00
Scott Taylor
36abe7909c In WP_Media_List_Table, remove dead code: 
* In `->prepare_items()`, importing `$wpdb` is unnecessary.
* In `->get_columns()`, `$taxonomies` is set twice before it is used.
* In `->display_rows()`, `$taxonomy_object` is set and never used.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28293 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 15:26:32 +00:00
Scott Taylor
41d1eb8f56 In ajax-actions.php, remove dead code: 
* In `wp_ajax_add_tag()`, `$post_type` is set and never used.
* In `wp_ajax_hidden_columns()`, `$hidden` is set twice, but only checks for the existence of `$_POST['hidden']` the first time. The two lines can be combined and work together.
* In `wp_ajax_inline_save()`, `$mode` is set and never used.
* In `wp_ajax_find_posts()`, `$searchand = $search = '';` is leftover cruft, neither variable is used. `$wpdb` does not need to be imported, it is never used.
* In `wp_ajax_wp_fullscreen_save_post()`, `$post_type` is set and never used.
* In `wp_ajax_save_attachment_order()`, `$post` is set and never used.
* In `wp_ajax_send_attachment_to_editor()`, `$title` is set and never used. 

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28292 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 15:18:42 +00:00
Sergey Biryukov
4b8b0e7178 Use a consistent context to remove duplicate strings. 
props pavelevap.
fixes #28123.

git-svn-id: https://develop.svn.wordpress.org/trunk@28287 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 12:33:08 +00:00
Scott Taylor
555937dc43 In WP_List_Table::display_rows_or_placeholder(), the call to get_column_info() in unnecessary and unused. The call to get_column_count() immediately after makes the same call internally. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28279 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 05:31:07 +00:00
Scott Taylor
f95a4c70be In edit_form_image_editor(), $filename and $title are set and then unused. They shall be removed. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28271 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 04:44:56 +00:00
Scott Taylor
e42ec45553 Dead code in wp-admin/includes/file.php: 
* In `wp_handle_upload()` and `wp_handle_sideload()`, `$ext` gets conditionally reset... and then is never used.
* In `request_filesystem_credentials()`, `$password` is initialized as an empty string. The variable is never used.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28268 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 04:21:35 +00:00
Scott Taylor
f97deae591 Remove unused variable setting for $revisions in wp_prepare_revisions_for_js(). 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28264 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 03:44:30 +00:00
Scott Taylor
4c6f405ee7 Remove a dead variable, $start, from wp_dashboard_recent_comments(). 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28263 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 03:34:22 +00:00
Andrew Nacin
4b6d5b10d4 Move 'home' option to the top of populate_options(). 
fixes #28141.


git-svn-id: https://develop.svn.wordpress.org/trunk@28260 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 21:56:11 +00:00
Sergey Biryukov
819ad5babc Deprecate unused argument of delete_plugins(). Clarify @return value. 
props jdgrimes for initial patch.
fixes #28111.

git-svn-id: https://develop.svn.wordpress.org/trunk@28256 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 10:23:16 +00:00
Sergey Biryukov
3e482eb905 Use a time constant in get_theme_feature_list() and File_Upload_Upgrader. 
props GaVrA.
fixes #28124.

git-svn-id: https://develop.svn.wordpress.org/trunk@28253 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 08:25:46 +00:00
Drew Jaynes (DrewAPicture)
609cf29058 Clean up duplicate hook notations and adjacency for calls to the wp_signup_location filter. 
Also adds braces missed in [25535].

See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28215 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 07:11:32 +00:00
Drew Jaynes (DrewAPicture)
379f725bde Ensure the wp_edit_nav_menu_walker filter is only documented once. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28213 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:49:48 +00:00
Drew Jaynes (DrewAPicture)
7a0eb63a19 Ensure the nav_menu_meta_box_object filter hook is only documented once. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28207 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:13:15 +00:00
Andrew Nacin
77c11f6cc9 Theme Installer: Proper redirection and action links post-install in multisite. 
fixes #27869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28163 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-19 18:17:12 +00:00
Andrew Nacin
aeef0e992a Translate a string added in 3.7.1 but never translated previously. 
props SergeyBiryukov.
fixes #27819.


git-svn-id: https://develop.svn.wordpress.org/trunk@28145 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 00:37:59 +00:00
Dion Hulse
60f6968d80 Background Updates: Avoid a PHP warning during theme update checks when there are multiple theme directories registered. Fixes #27815 
git-svn-id: https://develop.svn.wordpress.org/trunk@28137 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 10:56:56 +00:00
Andrew Nacin
0437f710a5 Allow the API to add text to auto update emails. 
fixes #27812.


git-svn-id: https://develop.svn.wordpress.org/trunk@28134 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 08:51:23 +00:00
Andrew Nacin
7ed14feff1 Theme Installer: Revert to proxying through PHP for WordPress.org API requests. 
This is to ensure we have valid installation nonces, though we've run into this as a problem previously (see #27639, #27581, #27055).

A tad slower, but we gained speed in 3.9 by simplifying the request made to the API.

props ocean90.
fixes #27798.


git-svn-id: https://develop.svn.wordpress.org/trunk@28126 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 01:15:43 +00:00
Andrew Nacin
32721b8347 Avoid stomping of bulk postdata inside the bulk_edit_posts() loop. 
Reverts [27990] which did not fix it for authors and comment/ping status.

props dd32, DrewAPicture.
fixes #27792.


git-svn-id: https://develop.svn.wordpress.org/trunk@28113 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 07:47:10 +00:00
Andrew Ozz
bff230b422 Plupload: restore the settings in media_upload_form(), see #27763 
git-svn-id: https://develop.svn.wordpress.org/trunk@28110 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 00:40:45 +00:00
Andrew Nacin
c43b8b063d Fix feature pointer RTL placement. 
props SergeyBiryukov, ocean90.
fixes #27778.


git-svn-id: https://develop.svn.wordpress.org/trunk@28107 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 23:59:01 +00:00
Andrew Nacin
7a25da5240 The widgets pointer requires the edit_theme_options capability. 
(It's hypothetically possible to have only switch_themes.)

see #27777.


git-svn-id: https://develop.svn.wordpress.org/trunk@28093 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 20:52:35 +00:00
Andrew Nacin
863116a5d2 Add a feature pointer for widgets in the customizer in 3.9. Remove older pointers from 3.3 and 3.4. 
see #27777.


git-svn-id: https://develop.svn.wordpress.org/trunk@28090 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 20:47:12 +00:00
Andrew Nacin
6c0420348e Update $_old_files for 3.9. see #27775. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28085 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 18:26:25 +00:00
Drew Jaynes (DrewAPicture)
b5612f8b80 Priority fixes for various existing hook documentation. 
Props kpdesign.
See #26869


git-svn-id: https://develop.svn.wordpress.org/trunk@28083 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 00:00:32 +00:00
Andrew Nacin
2d9949bf91 Account for new cropping settings in the image editor. 
props Otto42, SergeyBiryukov.
fixes #19393.


git-svn-id: https://develop.svn.wordpress.org/trunk@28072 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-11 03:09:35 +00:00
Drew Jaynes (DrewAPicture)
93b19f682e Inline documentation for hooks in wp-admin/includes/class-wp-upgrader-skins.php. 
Fixes #27711.


git-svn-id: https://develop.svn.wordpress.org/trunk@28040 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 06:25:56 +00:00
Andrew Nacin
d5c3a966be Theme Installer: Combine 'Layout' and 'Columns' filters so 'Features' can span two columns. 
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@28037 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 04:30:01 +00:00
Drew Jaynes (DrewAPicture)
4d4921a9ac Use the correct parameter variables in the hook docs for wp_upgrade. 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@27998 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:13:00 +00:00
Drew Jaynes (DrewAPicture)
3b7d881f3c Align parameters in the hook docs for the attachment_thumbnail_args filter. 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@27997 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:10:01 +00:00
Drew Jaynes (DrewAPicture)
95294a170e Add missing parameter descriptions to the PHPDocs for WP_Upgrader_Skin::decrement_update_count() and Bulk_Upgrader_Skin::decrement_update_count(). 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@27996 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:01:35 +00:00
Andrew Nacin
06152cbe6f Avoid stomping of bulk postdata inside the bulk_edit_posts() loop. 
props kovshenin.
see [27964], see #27452.


git-svn-id: https://develop.svn.wordpress.org/trunk@27990 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 17:58:37 +00:00
Andrew Nacin
3fbe1ba7b7 Apply checks in [27964] to wp_write_post(), which is unused and due for dismantling and deprecation. 
see #27452.


git-svn-id: https://develop.svn.wordpress.org/trunk@27975 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-06 22:07:02 +00:00
Drew Jaynes (DrewAPicture)
789305948e Inline documentation for remaining hooks in wp-admin/includes/upgrade.php. 
Props jackreichert, vancoder.
Fixes #27646.


git-svn-id: https://develop.svn.wordpress.org/trunk@27965 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-05 22:29:41 +00:00
Andrew Nacin
14d96748c7 Better checks for contributors when saving posts. 
props dd32, kovshenin, plocha.
see #27452.


git-svn-id: https://develop.svn.wordpress.org/trunk@27964 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-05 21:18:44 +00:00
Sergey Biryukov
96563b4143 Clarify tooltips on Edit Image screen. 
props siobhan.
fixes #27651.

git-svn-id: https://develop.svn.wordpress.org/trunk@27939 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-04 00:02:22 +00:00
Sergey Biryukov
a97e9018c4 Fix typo in verify_file_md5() description. see [25541]. 
props siobhan.
see #27651.

git-svn-id: https://develop.svn.wordpress.org/trunk@27938 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-04 00:02:12 +00:00
Sergey Biryukov
ed139644be Use multiplication sign instead of a colon for selection size when editing an image. 
props siobhan.
fixes #27652.

git-svn-id: https://develop.svn.wordpress.org/trunk@27931 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-03 09:45:44 +00:00
Andrew Nacin
66f20812b9 Remove old links_recently_updated_* DB options that never had a UI. 
fixes #27649.


git-svn-id: https://develop.svn.wordpress.org/trunk@27916 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-03 03:09:59 +00:00
Dion Hulse
48025fabd5 Background Updates: Record Plugin & Theme update statistics like we for for Core updates, Pass Plugin/Theme update objects into the Background updater for consistency with Core & Translations. See #27633 
git-svn-id: https://develop.svn.wordpress.org/trunk@27905 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-02 13:04:30 +00:00
Drew Jaynes (DrewAPicture)
33acf29a46 Clarify PHPDoc return description for media_handle_upload(). 
Props jdgrimes.
Fixes #27519.


git-svn-id: https://develop.svn.wordpress.org/trunk@27880 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-31 22:32:47 +00:00
Scott Taylor
d8d26a4f79 Cleanup up the display, escaping, and handling of ID3 data for media. Rename wp_get_relevant_id3_keys() to wp_get_attachment_id3_keys(). 
Props nacin.
See #27574.



git-svn-id: https://develop.svn.wordpress.org/trunk@27869 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-31 05:15:39 +00:00
Andrew Nacin
70beef6c31 Use correct formatting function. see [27864], see #27574. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27866 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-30 22:11:58 +00:00
Andrew Nacin
877ffc087f Cleanups for audio/video metadata, see [27862]. 
see #27574.


git-svn-id: https://develop.svn.wordpress.org/trunk@27864 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-30 21:07:04 +00:00
Scott Taylor
2846655164 In wp_generate_attachment_metadata(), when an audio or video files contains upload-able image bits in its ID3 tags, only upload it if the image has not already been uploaded. Determine this by checking for a _cover_hash value in post meta that matches the md5 representation of the bits. 
This prevents uploading an album of 10 songs and subsequently uploading 10 copies of the same album cover.

Props GregLone for the new filter/filter docs: `'attachment_thumbnail_args'`.
Fixes #27573.
 


git-svn-id: https://develop.svn.wordpress.org/trunk@27863 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-30 20:53:21 +00:00
Scott Taylor
149f36ed35 Metadata for audio and video files: 
* Make attachment metadata for audio files editable by providing a metabox on the Edit Media page
* Standardize on using the attachment title everywhere
* Label the Caption and Description fields for audio and video appropriately
* Make the playlist Underscore templates more straightforward

See #27574.



git-svn-id: https://develop.svn.wordpress.org/trunk@27862 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-30 19:27:31 +00:00
Andrew Nacin
1c3f9e542b Restyle the image editor so it looks way less hideous. 
props avryl.
see #27544.


git-svn-id: https://develop.svn.wordpress.org/trunk@27842 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-29 08:50:57 +00:00
Drew Jaynes (DrewAPicture)
a2d810d024 The sidebar_admin_setup hook should only be documented once in wp-admin/widgets.php. All others are duplicates. 
See #25374, #25501, #27531.


git-svn-id: https://develop.svn.wordpress.org/trunk@27823 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-28 19:46:26 +00:00
Dominik Schilling (ocean90)
2d4b606e14 Widget Customizer: Convert static WP_Customize_Widgets class into instantiated class and merge Options_Transaction into WP_Customize_Widgets. 
see #27504.
props westonruter.


git-svn-id: https://develop.svn.wordpress.org/trunk@27816 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-28 14:06:10 +00:00
Andrew Nacin
98ac075d8b Always decode special characters for email subjects. 
props tlovett1, jeremyfelt.
fixes #25346.


git-svn-id: https://develop.svn.wordpress.org/trunk@27801 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-28 02:43:04 +00:00
Andrew Nacin
ab787f2f57 Proper IDs for the custom fields box. 
props SergeyBiryukov.
fixes #14376.


git-svn-id: https://develop.svn.wordpress.org/trunk@27776 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-27 06:55:51 +00:00
Andrew Nacin
50d900aa5f Fix docs for hooks in deactivate_plugins() and activate_plugin(). see #27189, #27188. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27769 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-27 02:01:29 +00:00
Scott Taylor
3acb8fcdf6 The bulk editor and post format meta box should use the same checks for available post formats. 
Props eightface.
Fixes #27187.



git-svn-id: https://develop.svn.wordpress.org/trunk@27762 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-27 00:05:14 +00:00
Andrew Nacin
aeda501de1 Merge some theme update strings. 
props pavelevap, yoavf.
fixes #25083.


git-svn-id: https://develop.svn.wordpress.org/trunk@27748 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-26 20:07:10 +00:00
Andrew Nacin
78b05bc236 Avoid JS errors before the commentReply script loads. Let's make this unobtrusive soon. 
props aubreypwd.
fixes #24741.


git-svn-id: https://develop.svn.wordpress.org/trunk@27747 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-26 18:52:31 +00:00
Andrew Nacin
c4b15e91bf Upgrader skins: Strip tags before displaying error data. 
fixes #25394.


git-svn-id: https://develop.svn.wordpress.org/trunk@27737 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-26 14:38:39 +00:00
Andrew Nacin
fbe0b3e5ac Don't allow the image editor thumbnail to be dragged. see #21811. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27712 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-25 16:20:50 +00:00
Andrew Nacin
0fccb7b64d Restore the update message in the dashboard, removed in 3.8. 
props obenland.
fixes #26664.


git-svn-id: https://develop.svn.wordpress.org/trunk@27711 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-25 14:35:23 +00:00
Andrew Nacin
3e28e2fae8 Multisite: Don't set the $super_admins global in grant_super_admin(), revoke_super_admin(). 
Adds tests and docs.

props jdgrimes.
see #27205.


git-svn-id: https://develop.svn.wordpress.org/trunk@27706 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-25 12:13:40 +00:00
Drew Jaynes (DrewAPicture)
0e7a34444d Correct misleading verbiage in 'print' hook docs. 
Standardizes 'print' hook docs on the concept that hooks are fired when scripts and styles are printed.

Props ericlewis for the initial patch.
Fixes #26924.


git-svn-id: https://develop.svn.wordpress.org/trunk@27695 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-25 08:04:44 +00:00
Scott Taylor
9cd40edebf In wp_create_post_autosave(), intersect the $new_autosave's keys with the keys from _wp_post_revision_fields() to ensure that all expected fields are present. 
Props kovshenin.
Fixes #25416.



git-svn-id: https://develop.svn.wordpress.org/trunk@27690 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-24 20:31:51 +00:00
Andrew Nacin
401aa27073 Plugin Installer: Disable 'Latest Version Installed' buttons. 
props paulwilde.
see #26952.


git-svn-id: https://develop.svn.wordpress.org/trunk@27677 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-24 03:40:28 +00:00
Andrew Nacin
48391a7444 Use correct variable. see [27373]. 
props TobiasBg.
fixes #14424.


git-svn-id: https://develop.svn.wordpress.org/trunk@27675 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-24 03:24:33 +00:00
Drew Jaynes (DrewAPicture)
0be6f6072a Inline documentation for hooks in wp-admin/includes/taxonomy.php. 
Props kpdesign for the initial patch.
Fixes #27433.


git-svn-id: https://develop.svn.wordpress.org/trunk@27674 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-24 03:13:06 +00:00
Drew Jaynes (DrewAPicture)
7062f3c75a Inline documentation for wp-admin/includes/class-wp-upgrader.php. 
Props kpdesign for some minor cleanup.
Fixes #27436.


git-svn-id: https://develop.svn.wordpress.org/trunk@27673 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-24 02:59:36 +00:00
Drew Jaynes (DrewAPicture)
af0f9a5e00 Inline documentation for hooks in wp-admin/includes/file.php. 
Fixes #27429.


git-svn-id: https://develop.svn.wordpress.org/trunk@27672 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-24 02:44:17 +00:00
Drew Jaynes (DrewAPicture)
99c2775c0f Remove some debug cruft accidentally committed in [27670]. 
See #27430.


git-svn-id: https://develop.svn.wordpress.org/trunk@27671 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-24 02:37:05 +00:00
Drew Jaynes (DrewAPicture)
ac9e81e0f0 Inline documentation for hooks in wp-admin/includes/menu.php. 
Also fixes syntax for a few unrelated multi-line comments in the file.

Props kpdesign for some minor cleanup.
Fixes #27430.


git-svn-id: https://develop.svn.wordpress.org/trunk@27670 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-24 02:34:14 +00:00
Drew Jaynes (DrewAPicture)
4d7ca61c09 Inline documentation for hooks in wp-admin/includes/dashboard.php. 
Props mauryaratan. Props kpdesign for some minor cleanup.
Fixes #25752.


git-svn-id: https://develop.svn.wordpress.org/trunk@27669 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-24 02:20:33 +00:00
Drew Jaynes (DrewAPicture)
c7080c0a6b Inline documentation for hooks in wp-admin/includes/post.php. 
Also moves the primary PHPDoc for the `edit_posts_per_page` hook to wp-admin/includes/post.php.

Props kpdesign for some cleanup.
Fixes #27431.


git-svn-id: https://develop.svn.wordpress.org/trunk@27667 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-24 01:48:40 +00:00
Andrew Ozz
263d9c7f33 Plupload: switch to urlstream upload method when the 'flash' runtime is used in non IE browsers. This ensures cookies are sent but limits the maximum file size that flash can handle. 
By default only IE9 and older use flash so this change is mostly for completeness. It would affect only the (extremely rare) cases where a plugin disables the html5 runtime.

git-svn-id: https://develop.svn.wordpress.org/trunk@27662 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-23 23:44:20 +00:00
Scott Taylor
0697544056 Turn on thumbnail support for attachment:audio and attachment:video. Change conditionals to check for theme OR post type support when determining whether to turn on the Featured Image UI pieces in the admin. 
Fixes #27460.



git-svn-id: https://develop.svn.wordpress.org/trunk@27657 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-23 02:34:39 +00:00
Dominik Schilling (ocean90)
9e92a95ec5 Remove "Show" prefix from filter dropdowns, see #26743. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27626 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-19 22:12:13 +00:00
Andrew Nacin
b2da716c11 Skipping placeholders in a string will only catch translators off guard. 
see #27453, #27132.


git-svn-id: https://develop.svn.wordpress.org/trunk@27613 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-19 05:53:01 +00:00
Andrew Nacin
d3a873840e Remove two new strings from post_preview(). 
see #25272, #27453.


git-svn-id: https://develop.svn.wordpress.org/trunk@27612 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-19 05:48:28 +00:00
nacin
877e12ee33 Improve the autosave error message on nonce failure. 
see #27453, #25272.


git-svn-id: https://develop.svn.wordpress.org/trunk@27611 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-19 05:46:02 +00:00
John Blackbourn
f850186eff Introduce permission checks for post queries and edit links in the At a Glance dashboard widget. Fixes #27132. Props mattheu. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27596 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-18 22:43:41 +00:00
John Blackbourn
d91dd88edc Remove the "See more" toggle from the At a Glance dashboard widget. Fixes #26614. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27583 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-18 12:55:42 +00:00
Andrew Nacin
c914491693 Heartbeat: Hooks should always receive unslashed data. 
This affects the privileged hooks; the unprivileged hooks already received unslashed data.

props johnbillion, TobiasBg.
fixes #27260.


git-svn-id: https://develop.svn.wordpress.org/trunk@27576 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-18 00:14:48 +00:00
Andrew Nacin
c35a53f8bc Filesystem: Fix getchmod() for direct and ssh2 transports, for directories. 
props DavidAnderson.
fixes #26598.


git-svn-id: https://develop.svn.wordpress.org/trunk@27566 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-17 20:16:40 +00:00
Andrew Nacin
a641b9fb55 Cap and theme support checks for the welcome panel. 
props MikeHansenMe.
fixes #26276.


git-svn-id: https://develop.svn.wordpress.org/trunk@27563 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-17 19:46:15 +00:00
Sergey Biryukov
d4986f1b61 Avoid PHP notices in Media Library if an attachment parent post type no longer exists. 
props wpsmith.
fixes #27439.

git-svn-id: https://develop.svn.wordpress.org/trunk@27560 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-17 15:32:32 +00:00
Andrew Ozz
6d13e3e1ff Restyle the plugin install details modal to match the rest of the admin. Props avryl and paulwilde for initial mockup, see #26952 
git-svn-id: https://develop.svn.wordpress.org/trunk@27559 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-16 18:27:38 +00:00
Sergey Biryukov
1f8285b2e1 Fix .comment-grey-bubble markup and remove a stray </h5> tag. 
props avryl.
fixes #27408.

git-svn-id: https://develop.svn.wordpress.org/trunk@27548 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-15 04:31:58 +00:00
Dion Hulse
526bf7d352 WP_Filesystem: Update request_filesystem_credentials() to handle the correct ssh value of FS_METHOD. Props jnielsendotnet. Fixes #27265 
git-svn-id: https://develop.svn.wordpress.org/trunk@27546 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-15 03:08:47 +00:00
Dominik Schilling (ocean90)
91fbdbbcc4 Widget Customizer: Use ?wp_customize=on. 
Let _wp_customize_include() handle customizer initialisation.
Sets also the priority for the Add Widget and Reorder buttons and removes debug cruft.

props westonruter.
fixes #27291.

git-svn-id: https://develop.svn.wordpress.org/trunk@27524 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-13 18:37:24 +00:00
Scott Taylor
543bc6404a The Image Editor should apply changes to custom image sizes by checking $_wp_additional_image_sizes for $size in wp_save_image() before arbitrarily going to the options table. 
Props Otto42, SergeyBiryukov.
Fixes #19889.



git-svn-id: https://develop.svn.wordpress.org/trunk@27522 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-13 04:17:36 +00:00
John Blackbourn
f3629139a5 Correct the "View Post" button link when changing a post slug. Fixes #16477. Props aubreypwd. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27508 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-11 22:59:03 +00:00
John Blackbourn
f45c06c09c Avoid searching HTML tags when searching plugins and themes. Fixes #27136. Props enej. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27507 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-11 22:23:51 +00:00
Sergey Biryukov
1a769c0e11 Remove duplicate description of WP_List_Table class. 
props bravokeyl.
fixes #27346.

git-svn-id: https://develop.svn.wordpress.org/trunk@27502 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-11 16:22:44 +00:00
Andrew Nacin
6aa60cf530 Assign correct variable. 
props nendeb55.
fixes #27351. see #14424, [27373].


git-svn-id: https://develop.svn.wordpress.org/trunk@27501 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-11 13:23:14 +00:00
Andrew Nacin
96176b269d Bring the theme browsing experience from 3.8 to the theme installer. First pass. 
props matveb with assists from me and gcorne.
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@27499 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-11 07:46:27 +00:00
Drew Jaynes (DrewAPicture)
6308a3c93d Fix docs for the deactivate_$plugin and deactivated_plugin hooks. 
Props wpsmith for the original patch.
Fixes #27189


git-svn-id: https://develop.svn.wordpress.org/trunk@27491 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-10 21:33:54 +00:00
Andrew Nacin
e4bb7b0e8c Editor: Show 'View Post' for any post the author can read. 
This expands it to private posts and matches the logic in the toolbar.

props mordauk, SergeyBiryukov.
fixes #27059.


git-svn-id: https://develop.svn.wordpress.org/trunk@27483 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-09 13:52:08 +00:00
Dominik Schilling (ocean90)
292f70aba3 Admin Menu: Set default value of $icon_url in add_menu_page() to dashicons-admin-generic, fixes #26630. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27482 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-09 11:12:35 +00:00
Andrew Nacin
f225973b62 Allow $crop in add_image_size() to receive crop anchors (top, left, right, bottom, center). 
This also applies to set_post_thumbnail_size() and image_resize_dimensions().

props bradt, wonderboymusic, DH-Shredder.
fixes #19393.


git-svn-id: https://develop.svn.wordpress.org/trunk@27472 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-08 06:13:27 +00:00
Andrew Nacin
928a972fb5 Rename the new page_templates filter to theme_page_templates, and pass it a post object for proper context. 
see #13265.


git-svn-id: https://develop.svn.wordpress.org/trunk@27470 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-08 04:18:30 +00:00
Andrew Nacin
5d48091e5d Remove lame debugging. see #23057. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27467 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-08 03:15:49 +00:00
Andrew Nacin
750fe42507 Normalize $reassign in wp_delete_user() to ensure the hooks receive consistent values. 
fixes #23057.


git-svn-id: https://develop.svn.wordpress.org/trunk@27466 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-08 03:15:06 +00:00
Sergey Biryukov
28b34b3811 Fix docblock formatting in [27462]. see #23057. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27463 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-08 01:25:28 +00:00
Sergey Biryukov
e925502c25 Pass $reassign parameter to 'delete_user' and 'deleted_user' actions. 
props genkisan.
fixes #23057.

git-svn-id: https://develop.svn.wordpress.org/trunk@27462 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-08 01:22:51 +00:00
Andrew Nacin
4bbd5ef1d6 maybe_regenerate_attachment_metadata() is now wp_maybe_generate_attachment_metadata(). 
props kovshenin.
fixes #26825.


git-svn-id: https://develop.svn.wordpress.org/trunk@27441 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-06 19:33:32 +00:00
Drew Jaynes
d9c9ea73ec Inline documentation for hooks in wp-admin/includes/class-wp-theme-install-list-table.php. 
Props kpdesign for the cleanup.
Fixes #27293.


git-svn-id: https://develop.svn.wordpress.org/trunk@27430 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-06 13:43:59 +00:00
Andrew Nacin
f12d7bb35c Add widget management to the customizer. 
This brings in the Widget Customizer plugin: https://wordpress.org/plugins/widget-customizer/.

props westonruter, shaunandrews, michael-arestad, johnregan3, akeda, topher1kenobe, topquarky, bobbravo2, ricardocorreia. And for good measure, props westonruter.
see #27112.


git-svn-id: https://develop.svn.wordpress.org/trunk@27419 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-05 20:40:36 +00:00
Andrew Nacin
a14b999605 Always convert auto-drafts to drafts in edit_draft() and _wp_translate_postdata(). 
This regressed due to refactoring in [26995]. This commit fixes Quick Draft.

see #25272.


git-svn-id: https://develop.svn.wordpress.org/trunk@27405 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-05 06:25:31 +00:00
Andrew Ozz
6beddbe7de Restyles the modal for attaching media to posts, take II (also some autoprefixer and imagemin). Props avryl, see #26952. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27403 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-05 03:53:19 +00:00
Andrew Ozz
ce69c629ff Restyles the modal for attaching media to posts, props avryl, see #26952 
git-svn-id: https://develop.svn.wordpress.org/trunk@27401 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-04 23:10:35 +00:00
Andrew Nacin
28a29842c6 Convert the post lock icon to a dashicon. 
props melchoyce, DH-Shredder.
fixes #26796.


git-svn-id: https://develop.svn.wordpress.org/trunk@27392 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-04 06:52:14 +00:00
Dominik Schilling (ocean90)
ff567294f6 "At a Glance" widget: Move get_avatar() line out of if-block. 
This allows you to show avatars for custom comment types via the `get_avatar_comment_types` filter.

props zodiac1978.
fixes #26944.

git-svn-id: https://develop.svn.wordpress.org/trunk@27384 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-03 20:13:29 +00:00
Drew Jaynes
1b41eea7c7 Generalize the hook documentation for the set-screen-option filter. 
The filter covers more than [items]_per_page screen options.

Fixes #26186.


git-svn-id: https://develop.svn.wordpress.org/trunk@27379 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-03 17:50:33 +00:00
Drew Jaynes
f65484cabf Inline documentation for hooks in wp-admin/includes/misc.php. 
Props JoshuaAbenazer.
Fixes #26186


git-svn-id: https://develop.svn.wordpress.org/trunk@27375 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-03 17:19:31 +00:00
Andrew Nacin
0aae0ca1e6 Slight renaming in our callback in [27373]. see #14424. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27374 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-03 17:08:26 +00:00
Mark Jaquith
7937358328 Eliminate some of our last remaining create_function() instances 
* Moved some into private function callbacks
* Eliminated some that weren't necessary anymore

props obenland, markjaquith, nacin. fixes #14424

git-svn-id: https://develop.svn.wordpress.org/trunk@27373 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-03 16:20:12 +00:00
Andrew Nacin
f3a23fb43f Reference https://wordpress.org rather than http://wordpress.org in strings, links, comments, etc. 
props Ipstenu, markjaquith.
see #27115.


git-svn-id: https://develop.svn.wordpress.org/trunk@27369 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-03 02:33:24 +00:00
Andrew Nacin
6869d203d0 Introduce get_site_by_path() and further rewrite the site detection process for multisite. 
This is the first big step to supporting arbitrary domains and paths. In this new approach, sites are detected first where possible, then the network is inferred. Allows filtering for arbitrary path segments, smooths out some weirdness, and removes various restrictions. A sunrise plugin could do much of its work by adding filters, if those are even needed.

see #27003.


git-svn-id: https://develop.svn.wordpress.org/trunk@27359 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-02 22:24:50 +00:00
Drew Jaynes
94c6c6a213 Inline documentation for hooks in wp-admin/includes/image-edit.php. 
Props theorboman. Props kpdesign for the cleanup.
Fixes #26149.


git-svn-id: https://develop.svn.wordpress.org/trunk@27357 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-02 20:55:10 +00:00
Drew Jaynes
4346d63207 Inline documentation for hooks in wp-admin/includes/class-wp-plugins-list-table.php. 
Props nicolealleyinteractivecom, kpdesign.
Fixes #26957.


git-svn-id: https://develop.svn.wordpress.org/trunk@27356 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-02 20:47:31 +00:00
Drew Jaynes
90033f46bc Tweak inline documentation for hooks in wp-admin/includes/class-wp-users-list-table.php. 
Props kpdesign.
Fixes #26203.


git-svn-id: https://develop.svn.wordpress.org/trunk@27355 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-02 20:31:15 +00:00
Drew Jaynes
34cdf7f7e1 Inline documentation for hooks in wp-admin/includes/class-wp-users-list-table.php. 
Props leewillis77.
Fixes #26203.


git-svn-id: https://develop.svn.wordpress.org/trunk@27342 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-01 14:59:53 +00:00
Dion Hulse
db9eb328e3 Upgrader: Remove more debug from r27336. See #25860 
git-svn-id: https://develop.svn.wordpress.org/trunk@27339 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-01 06:05:02 +00:00
Dion Hulse
e98848a3c6 Upgrader: Remove some debug from r27336. See #25860 
git-svn-id: https://develop.svn.wordpress.org/trunk@27338 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-01 06:03:55 +00:00
Dion Hulse
18364c9625 Upgrader: Remove two stray spaces. See #25860 
git-svn-id: https://develop.svn.wordpress.org/trunk@27337 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-01 06:01:28 +00:00
Dion Hulse
14b4579d98 Upgrader: Copy wp-includes/version.php over last, to avoid an installation failing with the new version.php in place. Fixes #25860 
git-svn-id: https://develop.svn.wordpress.org/trunk@27336 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-01 06:00:47 +00:00
Scott Taylor
07f14d6434 * Videos should always render at the same aspect ratio. 
* Don't force a pseudo-mime-type for `.m4v` files
* Uniformly adapt to `$content_width` when setting video dimensions on the front end
* Add the `height` attribute to the initial `<video>` in the video playlist JS template
* Add some defensive/responsive CSS for a/v on the Edit Media page

See #27243.



git-svn-id: https://develop.svn.wordpress.org/trunk@27328 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-28 21:27:40 +00:00
John Blackbourn
6950f1bcd6 Don't filter out network-only plugins from the Plugins screen if they're individually active on the current site. Add some code comments for clarity. Props mordauk 
git-svn-id: https://develop.svn.wordpress.org/trunk@27326 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-28 20:21:52 +00:00
Sergey Biryukov
ecbe4f0909 Use a consistent format for translator comments. 
props GaryJ.
fixes #27228.

git-svn-id: https://develop.svn.wordpress.org/trunk@27325 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-28 08:08:50 +00:00
Sergey Biryukov
ef8de539b9 Remove temporary hooks added in [26865]. 
fixes #26661.

git-svn-id: https://develop.svn.wordpress.org/trunk@27324 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-28 00:44:38 +00:00