Move initialization of `$customizeSidebar` to `api.ThemesSection.initialize()` to prevent cases where the result can be undefined.
props westonruter, ocean90.
fixes#31793.
git-svn-id: https://develop.svn.wordpress.org/trunk@32119 602fd350-edb4-49c9-b593-d223f7449a82
* If we just tell them they they should set an `id` parameter, they might set an arbitrary one on an existing (i.e. not in-development) theme, causing widgets to be lost.
* This way, we tell them to set it to the auto-generated `id` that the sidebar already has.
* Widget content is not lost, and now their sidebar has a concrete handle.
fixes#31675
git-svn-id: https://develop.svn.wordpress.org/trunk@32110 602fd350-edb4-49c9-b593-d223f7449a82
This manifested in only being able to switch your theme once in the customizer before the "Change" button would appear to stop responding, though a switch to "Preview" and back to "Customize" would reveal the theme switcher after all. Animated positioning appears to be the problem here. The animations are not critical to the experience, particularly on touch+smaller screen devices.
props iseulde.
see #31794.
git-svn-id: https://develop.svn.wordpress.org/trunk@32103 602fd350-edb4-49c9-b593-d223f7449a82
- Fix focusing the Standard Editor link after saving draft, if the user has not focused another element.
- Reset the Save Draft button on node change in the editor.
See #31923.
git-svn-id: https://develop.svn.wordpress.org/trunk@32098 602fd350-edb4-49c9-b593-d223f7449a82
- When saving a draft change the text of the Save Draft button to Saving...
- On success, hide the button and show Edit Post link in its place. If the user focuses the title or the editor, hide the link and show the button again.
Fixes#31923.
git-svn-id: https://develop.svn.wordpress.org/trunk@32092 602fd350-edb4-49c9-b593-d223f7449a82
Headers are currently keyed by the basename of the image, see #31786. When two images have the same key only one image will be listed and the current image can be empty in the header control.
To prevent this we now fall back to the raw current header image if the image isn't in `_wpCustomizeHeader.uploads`.
props sirbrillig.
fixes#31742.
git-svn-id: https://develop.svn.wordpress.org/trunk@32091 602fd350-edb4-49c9-b593-d223f7449a82
Use `$_SERVER['HTTP_HOST']` and `$_SERVER['REQUEST_URI']` instead of `site_url()` and `$_SERVER['REQUEST_URI']`.
fixes#31896.
git-svn-id: https://develop.svn.wordpress.org/trunk@32086 602fd350-edb4-49c9-b593-d223f7449a82
The QS method added in [32067] and modified in [32080] doesn't work when the user changes the tab inside the modal. Instead, let's use the parent window's location.
Fixes#31739
git-svn-id: https://develop.svn.wordpress.org/trunk@32082 602fd350-edb4-49c9-b593-d223f7449a82
`.custom-background` should only be added if a background color or an image divert from their defaults. This behavior exists already in `_custom_background_cb()`.
props slobodanmanic, nitkr, valendesigns, obenland.
see [21054], [21001].
fixes#28687.
git-svn-id: https://develop.svn.wordpress.org/trunk@32081 602fd350-edb4-49c9-b593-d223f7449a82
This fixes two problems. TB seems to sometimes strip window.location.search variables after tb ones, so we need to move it forward. Also fixes logic error.
See #31739
git-svn-id: https://develop.svn.wordpress.org/trunk@32080 602fd350-edb4-49c9-b593-d223f7449a82
Captions containing only whitespace trick `image_add_caption()` into thinking
a caption is required, but the empty caption text confuses wpeditimage into
stripping the 'align' class specified by the user.
Fixes#21848.
git-svn-id: https://develop.svn.wordpress.org/trunk@32079 602fd350-edb4-49c9-b593-d223f7449a82
This particularly fixes the attachment and plugin details modals, but also improves other modals such as wpLink and interim login.
props iseulde.
fixes#31609, #31611. see #31610, #31612.
git-svn-id: https://develop.svn.wordpress.org/trunk@32073 602fd350-edb4-49c9-b593-d223f7449a82
