Commit Graph

4113 Commits

Author SHA1 Message Date
Helen Hou-Sandi
dfab26daf0 Plugin details: Fix review scrolling in some browsers (cough, Chrome).
Remove some unnecessary CSS from [29619].

fixes #29321.


git-svn-id: https://develop.svn.wordpress.org/trunk@29624 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 13:45:23 +00:00
Dominik Schilling (ocean90)
6e8defd150 RTL: Fix modal alignments.
* Prevent horizontal scrollbars in Chrome.
* URL fields should be always LTR.
* Force the plugin details to be LTR for all screens, see #19778.

fixes #29352.

git-svn-id: https://develop.svn.wordpress.org/trunk@29623 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 12:54:23 +00:00
Dominik Schilling (ocean90)
5109e1cacb Theme Upgrader: Set is_multi to true when doing bulk upgrades.
fixes #29234.

git-svn-id: https://develop.svn.wordpress.org/trunk@29622 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 09:23:10 +00:00
Dominik Schilling (ocean90)
3a061c9743 Language Pack Upgrader: Remove any pre-existing package checks and then set the new one for translations.
fixes #29230.

git-svn-id: https://develop.svn.wordpress.org/trunk@29621 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 09:19:17 +00:00
Andrew Nacin
bf0272c8b1 Require a non-empty $nonce value in wp_verify_nonce().
props ocean90.
fixes #29217.


git-svn-id: https://develop.svn.wordpress.org/trunk@29620 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 07:38:51 +00:00
Helen Hou-Sandi
8f66ff570e Plugin details: better review styling.
props Clorith, celloexpressions.
fixes #29321.


git-svn-id: https://develop.svn.wordpress.org/trunk@29619 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 05:49:00 +00:00
Helen Hou-Sandi
ee43238413 Restore spacing on the edit screen when a post type supports title but not editor.
props avryl.
fixes #28893.


git-svn-id: https://develop.svn.wordpress.org/trunk@29618 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 05:24:55 +00:00
Helen Hou-Sandi
3c03251197 Image Details modal: Restore narrow responsive layout.
props celloexpressions.
fixes #29337.


git-svn-id: https://develop.svn.wordpress.org/trunk@29617 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 05:19:45 +00:00
Helen Hou-Sandi
16e9426675 Focus styling: bring the blue glow to more places.
Handles color picker, theme browser, help/screen options, TinyMCE dialog buttons, jQuery UI dialog buttons, and buttons in color schemes.

props avryl, celloexpressions. fixes #28267.


git-svn-id: https://develop.svn.wordpress.org/trunk@29616 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 05:16:14 +00:00
Scott Taylor
c88c4d4f21 MCE View sandboxes:
* Use a `MutationObserver` to listen to the `body` class of the parent editor frame.
* In `wpview_media_sandbox_styles()`, only return the MEjs stylesheets.
* In `wp_ajax_parse_media_shortcode()` and `wp_ajax_parse_embed()`, return an object instead of an HTML blob to allow passing `body` and `head` separately	

Props avryl, azaozz.
Fixes #29048.


git-svn-id: https://develop.svn.wordpress.org/trunk@29615 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 04:45:54 +00:00
Helen Hou-Sandi
b2ee87b291 Media: Fix keying of selected attachments to color schemes.
props celloexpressions. see #28822.


git-svn-id: https://develop.svn.wordpress.org/trunk@29614 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 04:36:53 +00:00
Scott Taylor
927fb11de7 Media Modal:
* the Image Details frame does not have a menu, indicate that by setting `menu: false` when adding states.
* mimic the default router rendering by toggling a `hide-menu` class on the frame when the region for menu is `null`
* remove the dead render code for the Image Details frame

See #29339.


git-svn-id: https://develop.svn.wordpress.org/trunk@29613 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 04:21:06 +00:00
Helen Hou-Sandi
63205d3a43 Media Grid: Show upload errors above the grid rather than as a popup.
props pento, stephdau, helen. fixes #29141.


git-svn-id: https://develop.svn.wordpress.org/trunk@29612 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 04:17:18 +00:00
Andrew Nacin
d49f1405fd Install: Remove reference to readme and add a hyphen missing since 2007.
props ocean90.
fixes #29290.


git-svn-id: https://develop.svn.wordpress.org/trunk@29611 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 04:04:12 +00:00
Helen Hou-Sandi
bcba1996fe Customizer panels: use a single back button for all panels.
This also ensures the back button is visible on iOS devices.

props celloexpressions.
fixes #29135.


git-svn-id: https://develop.svn.wordpress.org/trunk@29610 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 23:04:43 +00:00
Andrew Ozz
f1fe507032 Media modal: fix the progress bar in the attachment thumbnail. Props gcorne, fixes #29367
git-svn-id: https://develop.svn.wordpress.org/trunk@29609 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 22:44:32 +00:00
Helen Hou-Sandi
7b6aabf795 Better visual focus syling in customizer, theme preview, and attachment details modals.
props celloexpressions.
fixes #29147.


git-svn-id: https://develop.svn.wordpress.org/trunk@29608 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 21:57:55 +00:00
Helen Hou-Sandi
eb08fac4f7 Media:
* Make attachment focus styles more obvious, particularly for already selected items.
* Fix styling for the selection set attachments.
* Remove some CSS cruft.

fixes #28822.


git-svn-id: https://develop.svn.wordpress.org/trunk@29607 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 21:25:13 +00:00
Andrew Ozz
649607b139 TinyMCE wpView: exclude more non-printable keyCodes in isSpecialKey(), fixes #29115
git-svn-id: https://develop.svn.wordpress.org/trunk@29606 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 20:40:21 +00:00
Helen Hou-Sandi
0566702a64 Plugin details:
Prevent plugins with long names from looking bad and breaking layouts.

props stephdau. fixes #28883.


git-svn-id: https://develop.svn.wordpress.org/trunk@29605 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 20:19:56 +00:00
Helen Hou-Sandi
330ed83605 Correct cascade oversights in form CSS. fixes #28262.
git-svn-id: https://develop.svn.wordpress.org/trunk@29604 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 19:52:24 +00:00
Andrew Ozz
2f81be2bbc Media modal: when inserting content, prefer the editor id passed while opening the modal. wpActiveEditor can change in the background. (Includes some precommit prefixed selectors.) Fixes #28173
git-svn-id: https://develop.svn.wordpress.org/trunk@29603 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 19:36:12 +00:00
Scott Taylor
15eb91dfdb Media: cleanup recent changes to media.view.FocusManager.
* Adjusts the focus method to target the menu for the current modal
* Refactor the FocusManager so that the method names and the functionality matches more closely with how it currently works. The changes in 4.0 to the FocusManager change the purpose of the focus manager entirely — instead of being a way to save and restore focus state, the new FocusManager is about constraining keyboard navigation via the tab key to inside the modal. 

Props gcorne.
See #23560.


git-svn-id: https://develop.svn.wordpress.org/trunk@29602 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 18:22:34 +00:00
Scott Taylor
361d664db5 Media: when activating a mode after [29056], don't trigger the {mode}:activate event twice in a row.
See #29366.


git-svn-id: https://develop.svn.wordpress.org/trunk@29601 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 18:06:06 +00:00
Scott Taylor
9a52936277 Media Grid: exit selection mode when Esc is pressed.
Fixes #29366.


git-svn-id: https://develop.svn.wordpress.org/trunk@29600 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 17:44:28 +00:00
Sergey Biryukov
feb1b12df1 Send nocache_headers() on installation screens and when redirecting to them.
fixes #29248.

git-svn-id: https://develop.svn.wordpress.org/trunk@29599 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 17:39:46 +00:00
Helen Hou-Sandi
87bf7ef30c Media Grid: Move CSS into an admin-only file.
`media-views.css` can be loaded on the front, which does not need this extra CSS.

fixes #29340.


git-svn-id: https://develop.svn.wordpress.org/trunk@29598 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 16:50:36 +00:00
Helen Hou-Sandi
9252fbec58 Only show one search form for the plugin installer.
The field dropdown now appears in the filter bar only when doing a search.

see #28785.


git-svn-id: https://develop.svn.wordpress.org/trunk@29597 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 16:02:43 +00:00
Helen Hou-Sandi
f187cf1dec Make filter bar CSS less verbose and redundant.
Also removes an unused handler in the theme feature filter.

see #28794.


git-svn-id: https://develop.svn.wordpress.org/trunk@29596 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 15:57:34 +00:00
Andrew Nacin
e8d8b21cec Plugins: Only show details link if user can install plugins.
fixes #17902.


git-svn-id: https://develop.svn.wordpress.org/trunk@29595 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 15:27:45 +00:00
Sergey Biryukov
fae5c2de6f Install Plugins: Don't wp_die() if API can't be reached.
props johnbillion.
fixes #29361.

git-svn-id: https://develop.svn.wordpress.org/trunk@29594 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 15:01:50 +00:00
Andrew Ozz
fa1b34ac78 Editor expand: add border to the Text editor resize helper, helps calculating the height in some cases. Fixes #29225
git-svn-id: https://develop.svn.wordpress.org/trunk@29593 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 03:42:46 +00:00
azaozz
78b5ccd55c Editor scrolling: fix window height when switching Visual to Text and the editor is shorter. Props mackensen, fixes #29226.
git-svn-id: https://develop.svn.wordpress.org/trunk@29592 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 23:11:03 +00:00
Andrew Nacin
4820f78f66 Plugin details: Adjust plugin title when it does not have a banner.
Smaller, bold, and Open Sans, like other modals. Only use Helvetica Neue when the plugin has a banner.

see [29040], see #27440.


git-svn-id: https://develop.svn.wordpress.org/trunk@29591 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 20:47:50 +00:00
Andrew Nacin
c0eabc9901 Plugin details: Correctly calculate the height of the right column for plugins without banners.
Comment these magic numbers.

see #27440, [29474].


git-svn-id: https://develop.svn.wordpress.org/trunk@29590 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 20:44:27 +00:00
Helen Hou-Sandi
b459eb034e Version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@29589 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 18:44:00 +00:00
Andrew Nacin
50706e736d Screen: Move editor scrolling screen option to the proper place.
see [29336], see #28328.


git-svn-id: https://develop.svn.wordpress.org/trunk@29588 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 17:56:25 +00:00
Andrew Nacin
42307f8194 Equal margins for plugin icons. see #28785.
git-svn-id: https://develop.svn.wordpress.org/trunk@29587 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 17:55:05 +00:00
Andrew Nacin
81b52e71e4 Plugin install: Add icons to compatible/incompatible. see #29313.
git-svn-id: https://develop.svn.wordpress.org/trunk@29586 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 17:25:35 +00:00
Scott Taylor
0ccd68f239 Media Grid: Don't make checkboxes tabbable when in bulk select media grid mode, fixes tabbing in bulk select mode.
Props adamsilverstein.
See #28822.


git-svn-id: https://develop.svn.wordpress.org/trunk@29585 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 16:54:35 +00:00
Scott Taylor
506bf18b7e Media Grid: restore focus to the selected item when shift-tab away from the attachment details sidebar.
Fixes #29303.


git-svn-id: https://develop.svn.wordpress.org/trunk@29584 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 16:42:14 +00:00
Dominik Schilling (ocean90)
e4717c19c1 Apply accessibility improvements to Plugins screen too.
props SergeyBiryukov.
fixes #29342.

git-svn-id: https://develop.svn.wordpress.org/trunk@29583 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 16:21:20 +00:00
Helen Hou-Sandi
35ae0bc5a4 Media: Only fire keyboard events for the Attachments view once.
Firing them twice was breaking arrow key navigation in media attachment grids.

props gcorne.
fixes #29304.


git-svn-id: https://develop.svn.wordpress.org/trunk@29582 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 16:17:01 +00:00
Dominik Schilling (ocean90)
19a0a5b64f Plugin compatibility is based on your version of WordPress, not your install.
fixes #29313.

git-svn-id: https://develop.svn.wordpress.org/trunk@29581 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 16:13:54 +00:00
Dominik Schilling (ocean90)
7770a90d74 Add missing array keys for connection type in request_filesystem_credentials().
see [28456].
fixes #29347.


git-svn-id: https://develop.svn.wordpress.org/trunk@29580 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 16:04:01 +00:00
Andrew Ozz
46457ead23 Editor scrolling:
- Pin the TinyMCE statusbar (elements path) to the bottom.
- Add support for pinning the menu when present.
- Add borders from CSS.
- Optimize getting most elements outerHeight.
Part props avryl, fixes #29293, see #28328.

git-svn-id: https://develop.svn.wordpress.org/trunk@29579 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 05:10:52 +00:00
Drew Jaynes (DrewAPicture)
7c8086a9a6 Fix a couple of misplaced/misordered argument descriptions in the WP_Query arguments hash notation.
See #25367.


git-svn-id: https://develop.svn.wordpress.org/trunk@29578 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-23 19:36:00 +00:00
Andrew Ozz
76020bd447 TinyMCE wpView: fix showing errors for non-embeddable URLs, no-ssl or no items. Props avryl, fixes #29114, see #29268.
git-svn-id: https://develop.svn.wordpress.org/trunk@29577 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-22 18:54:08 +00:00
Andrew Ozz
c83a9ca2c9 TinyMCE: update to 4.1.4-20140822. Changes:
- Fixed bug where sometimes the resize rectangles wouldn't properly render on images on WebKit/Blink. 9a2d01cc14
- Fixed nodeChanged selection issue where the image selection wouldn't be removed if you clicked right after/before it. dd729c67e0
- Fixed bug in list plugin where delete/backspace would merge empty LI elements in lists incorrectly. caadfb05dd
See #29310

git-svn-id: https://develop.svn.wordpress.org/trunk@29576 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-22 17:43:39 +00:00
Sergey Biryukov
e6a5a8a36b Fix unintended box-shadow in the opposite corner of thickbox Close icon.
props ocean90.
fixes #29311.

git-svn-id: https://develop.svn.wordpress.org/trunk@29575 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-22 16:03:29 +00:00