Commit Graph

4113 Commits

Author SHA1 Message Date
Sergey Biryukov
947ca94071 Correct references to post-template.php in the inline docs.
props softmodeling.
fixes #29188.

git-svn-id: https://develop.svn.wordpress.org/trunk@29469 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-12 01:08:19 +00:00
John Blackbourn
fcda873946 Correct the docblock for the registered_post_type action. Fixes #29184.
git-svn-id: https://develop.svn.wordpress.org/trunk@29468 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-11 21:20:58 +00:00
John Blackbourn
ccc0673612 Docblock corrections for get_the_terms() function and corresponding filter, and registered_taxonomy action. Fixes #29183.
git-svn-id: https://develop.svn.wordpress.org/trunk@29467 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-11 21:16:52 +00:00
Helen Hou-Sandi
8bdbb3de87 Better focus styling for buttons and button groups. props mattheu, avryl, celloexpressions. fixes #27826. see #28267.
git-svn-id: https://develop.svn.wordpress.org/trunk@29466 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-11 18:20:18 +00:00
Helen Hou-Sandi
18a8b40401 Add styling for various HTML5 input elements. props avryl. fixes #28262.
git-svn-id: https://develop.svn.wordpress.org/trunk@29465 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-11 16:41:35 +00:00
Sergey Biryukov
9f3b8dbead XML-RPC: Avoid a PHP notice in pingback_ping() method.
props jesin, simonp303.
fixes #29177.

git-svn-id: https://develop.svn.wordpress.org/trunk@29464 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-11 15:18:08 +00:00
Andrew Ozz
5b2ae73e18 TinyMCE: update wpview and editimage plugins for 4.1.3. Add show/hide of the Edit and Delete buttons on views and images on 'touchend'. See #28595, #29166
git-svn-id: https://develop.svn.wordpress.org/trunk@29463 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-10 04:21:46 +00:00
Drew Jaynes (DrewAPicture)
e8adffff96 s/does/does not in wp_set_password() docblock.
See [29461]. See #28316.


git-svn-id: https://develop.svn.wordpress.org/trunk@29462 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-10 02:43:07 +00:00
Drew Jaynes (DrewAPicture)
5aef1c5aa5 Improve the wp_set_password() PHPDoc with a note to guard against executing the function on every page load, such as through a theme's functions.php file.
See #28316.


git-svn-id: https://develop.svn.wordpress.org/trunk@29461 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-10 02:38:52 +00:00
Drew Jaynes (DrewAPicture)
39ba840e04 Add @access tags to constructor docblocks in list table classes.
See #28679. See [29459].


git-svn-id: https://develop.svn.wordpress.org/trunk@29460 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-10 02:21:56 +00:00
Drew Jaynes (DrewAPicture)
126147a877 Document default arguments for the WP_List_Table class. Also add referenced docblocks to extending class constructors.
Props mikejolley for the initial patch.
Fixes #28679. See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@29459 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-10 02:17:14 +00:00
Andrew Ozz
f8fed596ec TinyMCE: update to 4.1.3, changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt, fixes #29166
git-svn-id: https://develop.svn.wordpress.org/trunk@29458 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 20:55:34 +00:00
Scott Taylor
e23c1ae3ff Upgrade MediaElement to 2.15.0:
* It is required to set `height` on the parent `.wp-video` wrapper for video
* Fixes the play button hover problem in Chrome
* Includes my pull request: https://github.com/johndyer/mediaelement/pull/1273

All changes:
https://github.com/johndyer/mediaelement/compare/2.14.2...master

See #29110.


git-svn-id: https://develop.svn.wordpress.org/trunk@29457 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 20:43:25 +00:00
Scott Taylor
45368dbfaa Video:
* Don't set height on responsive `<div>` when generating markup
* Move some CSS rules from the style tag to `.wp-video`
* Use Video Details view event delegation instead of click events delegated from `<body>`
* Fix some CSS rule collision in the grid modal

See #29110.


git-svn-id: https://develop.svn.wordpress.org/trunk@29456 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 19:38:40 +00:00
Drew Jaynes (DrewAPicture)
8feaba4ca2 Clean up some missing @access tags and other tweaks for 4.0.0-functionality docs.
See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29455 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 19:31:35 +00:00
Drew Jaynes (DrewAPicture)
a84d50dfa3 Fix some words that aren't words.
See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29454 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 19:29:37 +00:00
Dominik Schilling (ocean90)
e8e0880851 WP_Plugins_List_Table::bulk_actions() method declaration should match WP_List_Table, see [29440].
props imath.
fixes #29148.

git-svn-id: https://develop.svn.wordpress.org/trunk@29453 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 14:45:20 +00:00
Andrew Ozz
c4424ea546 Media at small screens:
- Show the image details/settings as an overlay.
- Better styling for the frame drop-down.
- Remove the multi-select by default on the Insert frame.
See #27423

git-svn-id: https://develop.svn.wordpress.org/trunk@29452 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 05:08:16 +00:00
Scott Taylor
af851b9bda Add some docs to Customizer JS.
Props ericlewis.
See #29157.


git-svn-id: https://develop.svn.wordpress.org/trunk@29451 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 23:30:30 +00:00
Scott Taylor
0a6221058f Add some docs to Customizer JS.
Props ericlewis.
See #29157.


git-svn-id: https://develop.svn.wordpress.org/trunk@29450 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 22:09:46 +00:00
Andrew Ozz
d6d00167a6 TinyMCE: don't access the parent window when opening the (iframe based) Help/Keyboard Shortcuts modal. Fixes #20094.
git-svn-id: https://develop.svn.wordpress.org/trunk@29449 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 21:17:15 +00:00
Andrew Ozz
78c928ad44 Editor: use the post_edit_form_tag action to add autocomplete="off" to the whole form on the Add/Edit Post screen in WebKit. Prevents editor problems when the browser's Back button is used. Fixes #28037.
git-svn-id: https://develop.svn.wordpress.org/trunk@29448 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 20:53:31 +00:00
Helen Hou-Sandi
d837ad9fa3 Revert [29287] based on design and core team feedback. see #29012.
git-svn-id: https://develop.svn.wordpress.org/trunk@29447 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 19:00:28 +00:00
Andrew Ozz
f4e7b2a6ad Media: improve the media modal at small screen sizes and make it usable on phones, first run. Part-props gcorne, see #27423.
git-svn-id: https://develop.svn.wordpress.org/trunk@29446 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 03:45:55 +00:00
Andrew Nacin
f1aceb1667 4.0-beta3-29445
git-svn-id: https://develop.svn.wordpress.org/trunk@29445 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 01:43:45 +00:00
Scott Taylor
8fad4c957c Media Grid: remove Router code that doesn't actually ever run.
See #29121.


git-svn-id: https://develop.svn.wordpress.org/trunk@29444 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 22:36:30 +00:00
Scott Taylor
86034ec04d Media Grid: remove Router code that doesn't actually ever run.
See #29121.


git-svn-id: https://develop.svn.wordpress.org/trunk@29443 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 22:32:58 +00:00
wonderboymusic
fa6508e234 wp_dashboard_cached_rss_widget() contained some func_get_args() code that was indescribably weird.
This keeps it weird, but makes sure that `$check_urls` gets passed to the callback.

Props michalzuber, ocean90.
Fixes #28872.


git-svn-id: https://develop.svn.wordpress.org/trunk@29442 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 21:46:02 +00:00
Scott Taylor
ec7895af29 After [29360], add rules for <input>s in the scope of .media-sidebar.
Props ocean90.
Fixes #28647.


git-svn-id: https://develop.svn.wordpress.org/trunk@29441 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 21:33:33 +00:00
Scott Taylor
9b9b4a82da Mark WP_List_Table::bulk_actions()'s argument $which as optional for BC.
Fixes #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29440 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 21:30:01 +00:00
Scott Taylor
8a0953d88b JSHint after [29437].
git-svn-id: https://develop.svn.wordpress.org/trunk@29439 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 21:20:08 +00:00
Scott Taylor
dc74104c21 Media Grid:
* Use a `media.view.Label` instance in the toolbar for the screen reader text for the "all" dropdown.
* Adjust the spinner's priority.

Fixes #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29438 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 21:00:45 +00:00
Scott Taylor
7b95dc861b Media Grid: use a media.view.Label instance in the toolbar for the screen reader text for Search.
See #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29437 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 20:53:03 +00:00
Helen Hou-Sandi
3d4ebded2f Revert styling changes to the Attachment Details modal from [29289]. fixes #28844.
git-svn-id: https://develop.svn.wordpress.org/trunk@29436 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 20:31:21 +00:00
Scott Taylor
42c1f07705 Media Grid: add screen reader text in a subview on the toolbar, a media.view.Label instance before media.view.DateFilter.
See #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29435 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 20:24:25 +00:00
Scott Taylor
b0d1b8b433 Create a new Backbone view, media.view.Label, which can be used as a subview in things like toolbars, which need screen reader text.
Make an initial instance of it for the label for Bulk Actions in Media Grid.

See #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29434 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 20:08:18 +00:00
Scott Taylor
e0083f398b Add screen reader text to list table date dropdown.
See #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29433 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 19:43:17 +00:00
Scott Taylor
0653e60a5d Revert [29428] to avoid errors with Add Media for now.
See #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29432 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 19:39:10 +00:00
Scott Taylor
3aa94852b3 wptexturize: After [28727], leverage RegeEx possessives (++) to improve performance and avoid libpcre segfaults.
Props kovshenin.
Fixes #12690.


git-svn-id: https://develop.svn.wordpress.org/trunk@29431 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 19:10:13 +00:00
Scott Taylor
7f000f2fdd Video: use auto instead of actual height for the responsive wrapper in generated markup.
See #29110.


git-svn-id: https://develop.svn.wordpress.org/trunk@29430 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 06:19:29 +00:00
wonderboymusic
0b7342e906 MediaElement upgrade: cleanup for generated markup for videos.
See #29110.


git-svn-id: https://develop.svn.wordpress.org/trunk@29429 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 05:52:03 +00:00
Scott Taylor
adff7dfb8e Media Grid: add screen reader labels with more context to filters and bulk actions. Ditto for list view.
Props afercia.
Fixes #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29428 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 05:19:14 +00:00
Scott Taylor
4f3462cc04 Media Grid: remove some unused Trash/Delete handler logic. Rendered useless since [29266] and made official by [29322].
See #28819.


git-svn-id: https://develop.svn.wordpress.org/trunk@29427 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 05:02:18 +00:00
Scott Taylor
6e3e7b374b In media.view.AttachmentFilters.All, make uploaded conditional upon media.view.settings.post.id and include a new filter: unattached.
Drop the `mime-types` filter and related class (which was added for Media Grid) and use `all` instead. 

Props ocean90, wonderboymusic.
Fixes #29065.


git-svn-id: https://develop.svn.wordpress.org/trunk@29426 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 04:43:36 +00:00
Scott Taylor
310a57d799 Media Grid: reduce the padding for .attachments.
Props ocean90, ryelle.
Fixes #29085.


git-svn-id: https://develop.svn.wordpress.org/trunk@29425 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 03:03:28 +00:00
Scott Taylor
277d5a633e After [29201], use aria-label instead of aria-labelledby in WP_Plugin_Install_List_Table::display_rows().
Props nvwd, DrewAPicture.
Fixes #28853.


git-svn-id: https://develop.svn.wordpress.org/trunk@29424 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 02:55:18 +00:00
Scott Taylor
67ef6c5e18 WP_List_Table::items should be public, not protected. It is accessed in a subclass directly via wp_ajax_get_comments().
See [28493].
Fixes #29072.


git-svn-id: https://develop.svn.wordpress.org/trunk@29423 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 02:50:40 +00:00
Scott Taylor
06eea1b33d After [28883], ensure that priorities have callbacks before returning true in has_filter().
Adds unit tests.

Props boonebgorges.
Fixes #29070.


git-svn-id: https://develop.svn.wordpress.org/trunk@29422 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 02:29:15 +00:00
Scott Taylor
e9ba499f23 After [29339] and [29341], add more unit tests and less ambiguous type-checking before bailing in meta-related functions that expect a numeric value for $object_id.
Props SergeyBiryukov.
Fixes #28315.


git-svn-id: https://develop.svn.wordpress.org/trunk@29421 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 22:07:42 +00:00
Scott Taylor
5f2fa44dee Media Grid: expose the $.Deffered() object in media.view.AttachmentsBrowser.updateContent() so the grid can call Backbone.history.start() when models actually exist.
This is a lot better then `_.delay( this.pray, 1000 )`, but needs continued study.

See #29052.


git-svn-id: https://develop.svn.wordpress.org/trunk@29420 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 21:43:26 +00:00
Scott Taylor
e25dc36c2b Media Grid: after [28996], use the same cover size for audio/video files that images use for thumbnails.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29416 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 19:32:51 +00:00
Scott Taylor
ccaf134b33 Media Grid: display upload errors in a dismissable sidebar.
See #29037.


git-svn-id: https://develop.svn.wordpress.org/trunk@29415 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 19:12:41 +00:00
Andrew Nacin
77e8616615 4.0-beta3
git-svn-id: https://develop.svn.wordpress.org/trunk@29414 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 18:27:59 +00:00
Andrew Nacin
996208160d Ignore entities in XML-RPC requests.
props mdawaffe, nacin.


git-svn-id: https://develop.svn.wordpress.org/trunk@29404 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 17:37:22 +00:00
Scott Taylor
1d1d95f4d5 In media.view.BulkSelectionActionButton.click(), do not assume that delete is the only possible bulk action.
Fixes #29101.


git-svn-id: https://develop.svn.wordpress.org/trunk@29403 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 17:23:49 +00:00
Scott Taylor
99a0a62442 Don't show the Featured Image metabox for users with the contributor role. Do enqueue media so that TinyMCE previews work for YouTube embeds, etc.
Props SergeyBiryukov.
Fixes #28327.


git-svn-id: https://develop.svn.wordpress.org/trunk@29402 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 17:16:45 +00:00
Scott Taylor
68a82b0932 Use proper non-capturing regex syntax for YouTube in wp_video_shortcode().
Props Fab1en.
See [27063].
Fixes #29119.


git-svn-id: https://develop.svn.wordpress.org/trunk@29401 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 17:00:13 +00:00
Andrew Nacin
4984b04b81 Escape late in get_avatar().
git-svn-id: https://develop.svn.wordpress.org/trunk@29397 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 07:49:30 +00:00
Andrew Ozz
d74b01a080 Media modal/grid: fix the position of attachment icons, restore the background, fix in ie8. See #27423.
git-svn-id: https://develop.svn.wordpress.org/trunk@29393 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 06:28:54 +00:00
Andrew Nacin
b2d8983dcc Constant time for wp_verify_nonce().
git-svn-id: https://develop.svn.wordpress.org/trunk@29382 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 05:25:03 +00:00
Sergey Biryukov
31105be6c7 Avoid PHP notices in wp-login.php if password reset cookie is not set.
props mdawaffe.
see #29060.

git-svn-id: https://develop.svn.wordpress.org/trunk@29381 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 02:16:51 +00:00
Andrew Ozz
0f01ebb037 TinyMCE: add support for class attribute on the caption shortcode. Part props knutsp, kadamwhite, fixes #28951.
git-svn-id: https://develop.svn.wordpress.org/trunk@29380 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 00:57:12 +00:00
Andrew Ozz
281bf20383 Media modal/grid: get the proper .attachment width in arrow navigation. Props avryl, see #27423.
git-svn-id: https://develop.svn.wordpress.org/trunk@29379 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-05 19:36:41 +00:00
Andrew Nacin
5894507b95 Disable external entities in ID3.
git-svn-id: https://develop.svn.wordpress.org/trunk@29378 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-05 19:13:57 +00:00
Andrew Nacin
a8e8ed6550 Verify the MAC earlier in WP_Customize_Widgets. props duck_.
git-svn-id: https://develop.svn.wordpress.org/trunk@29377 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-05 06:49:22 +00:00
Andrew Ozz
e5836da88d Media modal/grid: remove thumbnail resizing from JS, only keep setting number of columns. Props avryl, see #27423.
git-svn-id: https://develop.svn.wordpress.org/trunk@29376 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-05 05:19:09 +00:00
Sergey Biryukov
508bdec5bd Use wp_normalize_path() in plugins_url().
props paulschreiber.
fixes #29058.

git-svn-id: https://develop.svn.wordpress.org/trunk@29375 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-05 01:30:03 +00:00
Andrew Nacin
587a0bc96d Language chooser: Adjust continue button alignment.
git-svn-id: https://develop.svn.wordpress.org/trunk@29374 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-04 21:22:57 +00:00
Andrew Ozz
98c3058d32 Media modal: use the same classes to hide the "or" that is above the "Select files" button when no drag-drop support. See #28851.
git-svn-id: https://develop.svn.wordpress.org/trunk@29373 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-04 21:16:37 +00:00
Andrew Nacin
42f2f27267 Language chooser imporvements.
* Use a translated 'Continue' string.
 * Go back to using a select element.
 * Only show a spinner when we're installing a language. 

see #28577.


git-svn-id: https://develop.svn.wordpress.org/trunk@29372 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-04 20:46:42 +00:00
Andrew Nacin
be026764a3 Move plugin details link into the description area.
fixes #17902.


git-svn-id: https://develop.svn.wordpress.org/trunk@29371 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-04 18:48:07 +00:00
Andrew Ozz
040ac15f50 TinyMCE: fix alignment buttons when used on image with caption. Remove old/unneeded code. Fixes #28705.
git-svn-id: https://develop.svn.wordpress.org/trunk@29370 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-04 00:51:19 +00:00
Andrew Ozz
daf4baf3ed Mobile: hide the onscreen keyboard when the media modal opens, fixes #28549.
git-svn-id: https://develop.svn.wordpress.org/trunk@29369 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-03 22:33:05 +00:00
Scott Taylor
05bb106161 Media Grid: don't blow away the Attachment Details modal every time a new model is loaded.
Props ericlewis.
Fixes #29104.


git-svn-id: https://develop.svn.wordpress.org/trunk@29368 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-03 19:39:58 +00:00
Scott Taylor
e7eca9d99b Media Grid: don't select body with jQuery when instantiating media.view.UploaderWindow.
Props ericlewis.
See #28965.


git-svn-id: https://develop.svn.wordpress.org/trunk@29367 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-03 19:36:41 +00:00
Andrew Ozz
a1ce4931a1 Fix CSS for form elements for Firefox 30+, fixes #28500.
git-svn-id: https://develop.svn.wordpress.org/trunk@29366 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-03 00:33:31 +00:00
Dominik Schilling (ocean90)
2c320cc7f3 Standardize transition-animations on modal close/arrow buttons.
props celloexpressions.
fixes #29021.

git-svn-id: https://develop.svn.wordpress.org/trunk@29365 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 22:01:49 +00:00
Dominik Schilling (ocean90)
c53e3036ad Media Modal: Restore uploader view, when no items are found.
see #28963.

git-svn-id: https://develop.svn.wordpress.org/trunk@29364 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 20:46:36 +00:00
Scott Taylor
6723459a79 Add an action, pre_get_users, in WP_User_Query::prepare_query().
Props rmccue.
Fixes #29084.


git-svn-id: https://develop.svn.wordpress.org/trunk@29363 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 20:45:07 +00:00
Andrew Ozz
6bac38232c Add blog_id to the wp-settings-* cookie (used for storing user state) to prevent it being overloaded on sub-domain sites. Fixes #29095.
git-svn-id: https://develop.svn.wordpress.org/trunk@29362 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 20:08:52 +00:00
Dominik Schilling (ocean90)
eedb382924 Remove some unused dashboard-widget-* CSS classes. Unused since [9103].
props michalzuber.
fixes #28930.

git-svn-id: https://develop.svn.wordpress.org/trunk@29361 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 20:02:00 +00:00
Dominik Schilling (ocean90)
d12ec06021 Media: Don't stretch radio and checkbox inputs in compat fields. Adjust margin for radio inputs.
props kovshenin for initial patch.
fixes #28647.

git-svn-id: https://develop.svn.wordpress.org/trunk@29360 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 19:52:01 +00:00
Dominik Schilling (ocean90)
a2a3e10f66 Plugin install: Improve styling of the no results message.
see #28753.

git-svn-id: https://develop.svn.wordpress.org/trunk@29359 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 15:23:17 +00:00
Dominik Schilling (ocean90)
bcb49d44ab Language Upgrader: Don't print a footer when translations are updated async.
fixes #28947.

git-svn-id: https://develop.svn.wordpress.org/trunk@29358 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 15:15:27 +00:00
Dominik Schilling (ocean90)
c976db478f Upgrader: Use always window.postMessage for decrement of update count bubbles when IFRAME_REQUEST is defined.
Fixes decrement of translation update count bubbles when updated through the bulk upgrader.

fixes #29054.

git-svn-id: https://develop.svn.wordpress.org/trunk@29357 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 14:36:31 +00:00
Dominik Schilling (ocean90)
ee91f3f94f Attach Media: Display the correct error message when search result is empty.
fixes #29093.

git-svn-id: https://develop.svn.wordpress.org/trunk@29356 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 14:23:42 +00:00
Dominik Schilling (ocean90)
de7962c947 Media Upload: Improve styling of error messages.
props afercia, michalzuber.
fixes #29047.

git-svn-id: https://develop.svn.wordpress.org/trunk@29355 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 14:13:06 +00:00
Dominik Schilling (ocean90)
54faec35e4 To improve troubleshooting use esc_html() for a failed embed.
see #28195.

git-svn-id: https://develop.svn.wordpress.org/trunk@29354 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 22:33:55 +00:00
Dominik Schilling (ocean90)
6d656e7880 RTL: Fix media attach modal alignment.
props SergeyBiryukov.
fixes #28010.

git-svn-id: https://develop.svn.wordpress.org/trunk@29353 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 21:58:48 +00:00
Andrew Ozz
96daabb134 Editor scrolling: run one more adjust() 200ms after scroll or resize in case the browser is slow to re-calculate the element heights and pin/unpin the toolbars. See #28328, fixes #29059.
git-svn-id: https://develop.svn.wordpress.org/trunk@29352 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 21:42:03 +00:00
Dominik Schilling (ocean90)
6489b16efc Add some braces to [29225].
see #28673.

git-svn-id: https://develop.svn.wordpress.org/trunk@29350 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 21:03:48 +00:00
Sergey Biryukov
4b55c3d722 Avoid an undefined index notice in wp_reschedule_event().
props paulschreiber.
fixes #29077.

git-svn-id: https://develop.svn.wordpress.org/trunk@29349 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 20:56:11 +00:00
Dominik Schilling (ocean90)
4c0ae9bc47 Plugin install: Add missing closing HTML tags.
props jwenerd.
fixes #29090. see #28673.

git-svn-id: https://develop.svn.wordpress.org/trunk@29348 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 20:43:26 +00:00
Dominik Schilling (ocean90)
257a3ad0e3 Disable background page scrolling when modals are open.
props celloexpressions.
fixes #29074.

git-svn-id: https://develop.svn.wordpress.org/trunk@29346 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 20:14:43 +00:00
Scott Taylor
4465f7922a Revert [28640] as per @DH-Shredder.
See #24380.


git-svn-id: https://develop.svn.wordpress.org/trunk@29345 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 18:42:46 +00:00
Scott Taylor
91517ce620 Clarify that get_the_date(), get_the_time(), get_post_time() and get_post_modified_time() should return false when get_post() is null.
Adds unit tests.

Props GaryJ, SergeyBiryukov, tollmanz.
Fixes #28310.


git-svn-id: https://develop.svn.wordpress.org/trunk@29344 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 18:39:22 +00:00
Helen Hou-Sandi
8b45f96cba Use the word "Count" instead of the post type label in taxonomy list tables to prevent layout issues. It is also more accurate, as it represents a count of all post types, not just one.
props philipjohn, GaVrA, seanchayes. fixes #17209.


git-svn-id: https://develop.svn.wordpress.org/trunk@29343 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 18:31:52 +00:00
Mark Jaquith
a46a981daa Match background color in DFW and adapt the dashed outline color.
fixes #28330. props avryl, ipstenu.

git-svn-id: https://develop.svn.wordpress.org/trunk@29340 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 18:09:47 +00:00
Scott Taylor
5686f4511a Bail on update_user_meta() when $object_id is non-numeric.
Adds unit test.

Props jacklenox, wonderboymusic.
Fixes #28315.


git-svn-id: https://develop.svn.wordpress.org/trunk@29339 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 17:09:53 +00:00
Helen Hou-Sandi
758b290d02 Remove remaining title attributes from default-widgets.php, with the exception of the one on the link to WordPress.org. fixes #26552.
git-svn-id: https://develop.svn.wordpress.org/trunk@29338 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 17:04:30 +00:00
Scott Taylor
d83ac79c38 Unbreak Media Trash after [28788].
Props SergeyBiryukov.
Fixes #29080.


git-svn-id: https://develop.svn.wordpress.org/trunk@29337 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 15:14:56 +00:00
Andrew Ozz
c94edd08bd Editor scrolling:
- Add a Screen Option to turn it on/off, and on()/off() methods from JS. Store the user preference.
- Fix delayed calls to resize() in the TinyMCE autoresize plugin.
See #28328.

git-svn-id: https://develop.svn.wordpress.org/trunk@29336 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 02:42:30 +00:00
Andrew Ozz
a8a936ebc5 wpLink: add custom open and close events, props bradyvercher, fixes #28095.
git-svn-id: https://develop.svn.wordpress.org/trunk@29335 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 02:03:13 +00:00
Andrew Ozz
c3f712ac63 PressThis: when the Text editor is the default, run the initial textarea content through pre_wpautop() to convert the paragraph tags. Fixes #29081.
git-svn-id: https://develop.svn.wordpress.org/trunk@29334 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 00:54:51 +00:00
Andrew Ozz
0ef495da6a wpLink:
- Fix adding a link on pressing Enter.
- Don't auto-focus the URL field after selecting a local link.
- Don't auto-focus the URL field when opening on touch devices. Toggle focus/blur on it to close the onscreen keyboard so the modal is positioned properly.
See #28897.

git-svn-id: https://develop.svn.wordpress.org/trunk@29333 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-31 23:27:14 +00:00
Andrew Ozz
cba848581b Use node.nodeName instead of tagName for better consistency/compatibility, see #28704.
git-svn-id: https://develop.svn.wordpress.org/trunk@29332 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-30 17:48:21 +00:00
Helen Hou-Sandi
8790d81cb4 Prevent key event handlers from firing when in input areas in the media modal, as people understandably want to type inside said inputs. props kovshenin. fixes #28704.
git-svn-id: https://develop.svn.wordpress.org/trunk@29331 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-30 17:38:18 +00:00
Sergey Biryukov
6be5fc19b3 Make sure phpinfo() is not disabled before calling it in apache_mod_loaded().
props rohan013, harmr.
fixes #26772.

git-svn-id: https://develop.svn.wordpress.org/trunk@29330 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-30 17:27:54 +00:00
Sergey Biryukov
09877657d4 Customizer: Don't hide controls the preview frame has no information about.
props kovshenin.
see #27993.

git-svn-id: https://develop.svn.wordpress.org/trunk@29329 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-30 16:23:47 +00:00
Andrew Nacin
94c53962b1 Don't pass around the password reset key.
props mdawaffe.
fixes #29060.


git-svn-id: https://develop.svn.wordpress.org/trunk@29327 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 18:18:58 +00:00
Sergey Biryukov
502e9b675a In add_submenu_page(), avoid inadvertently copying classes of a menu item to the first submenu item.
fixes #28936.

git-svn-id: https://develop.svn.wordpress.org/trunk@29326 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 16:07:59 +00:00
Helen Hou-Sandi
3c71a49abc Labels for the installation form should get the pointer cursor. props Ankit K Gupta. fixes #28818.
git-svn-id: https://develop.svn.wordpress.org/trunk@29325 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 16:04:44 +00:00
Sergey Biryukov
40d1133c6f Fix duplicate Customize button in theme details modal.
props afercia.
fixes #28987.

git-svn-id: https://develop.svn.wordpress.org/trunk@29324 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 16:01:13 +00:00
Sergey Biryukov
e4c8f3a843 QuickPress: Disable autocomplete for content, enable "Save Draft" button on load.
props morganestes, michalzuber.
fixes #27760.

git-svn-id: https://develop.svn.wordpress.org/trunk@29323 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 15:33:07 +00:00
Sergey Biryukov
fd1652d6bb Media Grid: Close the modal if the attachment is deleted.
props ericlewis.
fixes #28819.

git-svn-id: https://develop.svn.wordpress.org/trunk@29322 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 14:57:21 +00:00
Andrew Ozz
93aff47ac5 wpLink: add keyboard navigation, improve accessibility. Props afercia, fixes #28897.
git-svn-id: https://develop.svn.wordpress.org/trunk@29321 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 03:15:34 +00:00
Sergey Biryukov
e2d9939e57 Avoid PHP notices in Media Library if an attachment parent post type no longer exists.
Synchronize the 'edit_post' capability check between the list table and the media grid.

fixes #27446.

git-svn-id: https://develop.svn.wordpress.org/trunk@29320 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 01:40:24 +00:00
Sergey Biryukov
a475124608 Use 3-digit x.x.x style for two 4.0.0 @since versions.
see #28885.

git-svn-id: https://develop.svn.wordpress.org/trunk@29319 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 00:58:22 +00:00
Sergey Biryukov
7ac0669493 Avoid PHP notices in _count_posts_cache_key(), _update_blog_date_on_post_publish(), and _update_blog_date_on_post_delete() if post type is not registered.
props jesin.
fixes #28135.

git-svn-id: https://develop.svn.wordpress.org/trunk@29318 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 00:50:53 +00:00
Andrew Ozz
fbfd88cecb TinyMCE:
- Use `data-wp-*` for processing and styling of the `more` and `nextpage` placeholders, keep the class names for back-compat. Makes them "immune" to "Clear formatting".
- Translate the titles of the placeholders.
Fixes #28772.

git-svn-id: https://develop.svn.wordpress.org/trunk@29317 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-28 23:44:28 +00:00
Andrew Ozz
01051b4e2f Formatting: make the removal of white space around <option> greedy, see #28217.
git-svn-id: https://develop.svn.wordpress.org/trunk@29316 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-28 19:54:50 +00:00
Andrew Ozz
5fa36977a0 Formatting: no <p> or <br> around <option> tags in both flavours of wpautop, make "selects" easier to read in the Text editor. Fixes #28217.
git-svn-id: https://develop.svn.wordpress.org/trunk@29315 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-28 19:43:06 +00:00
Dominik Schilling (ocean90)
70a6b6390c IE8 doesn't support ::before and ::after pseudo-elements. Replace them with :before and :after.
props andrezrv, DrewAPicture, ocean90.
fixes #28082.

git-svn-id: https://develop.svn.wordpress.org/trunk@29314 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-28 15:51:02 +00:00
Dominik Schilling (ocean90)
41360a0086 Remove parent::footer() in Language_Pack_Upgrader_Skin::bulk_footer() as it prints a closing div which is not needed.
props michalzuber.
fixes #28947.

git-svn-id: https://develop.svn.wordpress.org/trunk@29313 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-28 09:05:33 +00:00
Dominik Schilling (ocean90)
9f105673fb Media Grid: Improve lazy loading.
props kovshenin.
see #24716.

git-svn-id: https://develop.svn.wordpress.org/trunk@29312 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 17:57:25 +00:00
Dominik Schilling (ocean90)
ea34a0bdf7 Replace is_https_url() with 'https' === parse_url( $url, PHP_URL_SCHEME ).
see #28427, #28487.

git-svn-id: https://develop.svn.wordpress.org/trunk@29311 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 17:45:34 +00:00
Dominik Schilling (ocean90)
080f52ceb9 Revert [28894] as it's currently unused in core.
see #28487.

git-svn-id: https://develop.svn.wordpress.org/trunk@29309 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 17:15:22 +00:00
Dominik Schilling (ocean90)
0e42ce2dc0 Add missing screen-reader-text CSS class in [29294].
see #28867.

git-svn-id: https://develop.svn.wordpress.org/trunk@29308 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 13:42:49 +00:00
Dominik Schilling (ocean90)
db77bc8bff Media Grid: Align "Apply" button on small screens.
fixes #28903.

git-svn-id: https://develop.svn.wordpress.org/trunk@29307 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 12:14:58 +00:00
Dominik Schilling (ocean90)
3003895858 Fix jshint errors introduced in [29284] and [29299].
git-svn-id: https://develop.svn.wordpress.org/trunk@29306 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 11:48:26 +00:00
Dominik Schilling (ocean90)
812ecd9b8d Media Grid: Ignore user setting for content.
fixes #29034.

git-svn-id: https://develop.svn.wordpress.org/trunk@29305 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 11:43:08 +00:00
Dominik Schilling (ocean90)
cb5838a937 Media Grid: Improve dropzone margins when viewport height is <400px.
see #28851.

git-svn-id: https://develop.svn.wordpress.org/trunk@29304 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-26 15:29:39 +00:00
Dominik Schilling (ocean90)
0480144f86 Media Grid: Add context for "or" in [29296].
see #28851.

git-svn-id: https://develop.svn.wordpress.org/trunk@29303 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-26 14:36:56 +00:00
Andrew Ozz
42ac48d52a TinyMCE:
- Fix complex character input in Japanese, Chinese, etc. Was broken in getCursorOffset() in editor-expand.js.
- Disable auto-scrolling in some edge cases when editor expanding is enabled.
See #28328.


git-svn-id: https://develop.svn.wordpress.org/trunk@29302 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-26 00:07:55 +00:00
Helen Hou-Sandi
357d96c367 Don't interfere with browser-based autocomplete in the link modal. props SergeyBiryukov. fixes #28685.
git-svn-id: https://develop.svn.wordpress.org/trunk@29301 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 15:56:57 +00:00
Helen Hou-Sandi
59cec2e2ff When adding a post of a post type whose menu item is in a submenu, highlight the correct menu item. props mordauk, markjaquith. fixes #24137.
git-svn-id: https://develop.svn.wordpress.org/trunk@29300 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 15:25:20 +00:00
Scott Taylor
0b3802eb12 Media Grid: when closing the modal, automatically focus the proper attachment by reading the model's ID, which is unique.
Props adamsilverstein (for the red), wonderboymusic (for the green).
Fixes #28857.


git-svn-id: https://develop.svn.wordpress.org/trunk@29299 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:59:29 +00:00
Andrew Ozz
67032cf170 TinyMCE wpView:
- Fix opening the media modal on clicking Edit in Firefox.
- Fix range errors when restoring the selection bookmark in IE11 after editing a view.
See #28595.

git-svn-id: https://develop.svn.wordpress.org/trunk@29298 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:55:33 +00:00
Scott Taylor
e11d72f889 Media Grid: make check box-shadow more subtle.
See #28842.


git-svn-id: https://develop.svn.wordpress.org/trunk@29297 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:46:14 +00:00
Scott Taylor
3fef7648f6 Media Grid: improve uploader styles.
Props michalzuber, ericlewis.
See #28851.


git-svn-id: https://develop.svn.wordpress.org/trunk@29296 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:30:28 +00:00
Scott Taylor
276496aa29 Media Grid: change text to "Close Media Panel" to provide context for screen readers.
Props joedolson.
Fixes #28976.


git-svn-id: https://develop.svn.wordpress.org/trunk@29295 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:25:16 +00:00
Scott Taylor
ced3f94927 Adds <label>s to current page selector and bulk actions <select> field so that screen readers have an explicit label.
Props joedolson.
Fixes #28867.


git-svn-id: https://develop.svn.wordpress.org/trunk@29294 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:19:21 +00:00
Scott Taylor
f0318988c4 Correct a few @param docs for $walker.
Props dnaber-de.
Fixes #29011.


git-svn-id: https://develop.svn.wordpress.org/trunk@29293 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 22:24:07 +00:00
Scott Taylor
6e74d46d94 Whitelist input types that are styled in the scope of .form-field.
Props mauteri.
Fixes #28647.


git-svn-id: https://develop.svn.wordpress.org/trunk@29292 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 22:21:00 +00:00
Scott Taylor
66c8ad501f Add exif orientation to data extracted in wp_read_image_metadata().
Props shanebp.
Fixes 28916.


git-svn-id: https://develop.svn.wordpress.org/trunk@29291 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 22:13:19 +00:00
Scott Taylor
1cbe1cec12 In sanitize_file_name(), replace %20 and + with dashes. Remove unnecessary code from _wp_handle_upload().
Adds unit tests.

Props ericmann.
Fixes #16330.


git-svn-id: https://develop.svn.wordpress.org/trunk@29290 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 22:08:09 +00:00
Scott Taylor
cdf2c8132c Media Grid: UI improvements to Attachment modal.
Props ryelle.
See #28844.


git-svn-id: https://develop.svn.wordpress.org/trunk@29289 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 21:54:22 +00:00
Scott Taylor
dd76aeea5b Media Grid: remove pencil icon from attachment hover and a bunch of unused CSS.
Fixes #28945.


git-svn-id: https://develop.svn.wordpress.org/trunk@29288 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 21:17:32 +00:00
Scott Taylor
1b01b92dc6 Media Grid CSS: Media modal close icon should be consistent with other modals.
Props celloexpressions.
Fixes #29012.


git-svn-id: https://develop.svn.wordpress.org/trunk@29287 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 21:06:42 +00:00
Scott Taylor
052e5c5062 Remove white box-shadow divider from uploading status area for consistency.
Props paulwilde.
Fixes #28751.


git-svn-id: https://develop.svn.wordpress.org/trunk@29286 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 21:03:25 +00:00
Scott Taylor
b1053cca13 Don't render Attachment Display Settings when display is set to false. Currently, the value for display in the media.view.AttachmentsBrowser instance in the media.view.MediaFrame.Select frame is set to the value for displaySettings.
These values do different things, so check for the existence of `display` on the state before arbitrarily setting it to the `displaySettings` value.

Real world: this hides display settings when you select an image while editing a Gallery.

Fixes #28653.


git-svn-id: https://develop.svn.wordpress.org/trunk@29285 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 20:57:05 +00:00
Scott Taylor
c2491f31ae When gallery settings are overridden, the JS-generated shortcodes need to check the new defaults before deleting attributes that it suspects are the same as the original default values.
`wp.media.collection` has a new method to do this: `setDefaults()`.	Also flips the use of `_.extend` to allow this method to be overriden on instance creation.

See #28693.


git-svn-id: https://develop.svn.wordpress.org/trunk@29284 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 19:59:18 +00:00
Scott Taylor
530328ef59 The Underscore templates for Gallery settings should respect defaults when marking an <option> as selected.
See #28693.


git-svn-id: https://develop.svn.wordpress.org/trunk@29283 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 19:34:53 +00:00
Scott Taylor
abc6b8c1d7 Media Grid: Manage focus when toggling between the grid and an edit attachment modal
Props adamsilverstein for the initial patch.
Fixes #28857.


git-svn-id: https://develop.svn.wordpress.org/trunk@29282 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 19:04:48 +00:00
Helen Hou-Sandi
2fd45b514b Set default values for attachment meta and ID3 data when preparing for JS to avoid errors in rendering templates. props ericmann for the initial patch. fixes #29013.
git-svn-id: https://develop.svn.wordpress.org/trunk@29281 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 18:03:58 +00:00
Helen Hou-Sandi
5698a9dc7e Media Grid: Remove fields from showing in the grid itself.
All details are still available within the modal, and less-distinguishable non-image files still show the filename along with the file type icon.

Reverts [29079], [29078], [29077], and [28995]. see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29280 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 05:25:28 +00:00
Andrew Ozz
0a73faec46 Editor scrolling:
- Improve TinyMCE resizing when a floated block is at the end of the content.
- Improve setting the padding/margin under the toolbar on loading.
- Add custom event on TinyMCE resizing and use it to adjust the pinning (if needed).
Part props avryl, see #28328.

git-svn-id: https://develop.svn.wordpress.org/trunk@29279 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 01:32:29 +00:00
Helen Hou-Sandi
3d3b141b30 Add support for attachment_fields_to_edit in the attachment details modal. props ericlewis. fixes #28991, see #24716.
git-svn-id: https://develop.svn.wordpress.org/trunk@29278 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-23 22:08:17 +00:00
Scott Taylor
15aaf0691a After [29179], remove the last instance of this.isCompatibleSrc().
Props kovshenin.
See #28905.



git-svn-id: https://develop.svn.wordpress.org/trunk@29277 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-23 17:53:07 +00:00
Drew Jaynes (DrewAPicture)
d9564736b8 Fix a typo in the PHPDoc for wp_register_sidebar_widget().
Props Jonnyauk.
Fixes #29007.


git-svn-id: https://develop.svn.wordpress.org/trunk@29276 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-23 17:20:10 +00:00
Drew Jaynes (DrewAPicture)
1e2fa2ddd3 Fix a typo in the PHPDoc for get_stylesheet().
Props lgedeon.
Fixes #28985.


git-svn-id: https://develop.svn.wordpress.org/trunk@29275 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-23 05:10:44 +00:00
azaozz
2d466f4c86 wpView: make sure the editor is focused before selecting/deselecting a view, or IE may throw an invalid range error, see #28595.
git-svn-id: https://develop.svn.wordpress.org/trunk@29273 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 21:52:02 +00:00
Andrew Ozz
c2bd765b32 wpView: consolidate pausePlayers() and unsetPlayers(), they are almost the same. Prevent errors when instead of a player ME.js shows only a "Download File" placeholder (in IE). See #28905.
git-svn-id: https://develop.svn.wordpress.org/trunk@29272 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 21:48:41 +00:00
Dominik Schilling (ocean90)
cce3bdf920 Media Grid: Add a date filter.
props ericlewis.
fixes #28895.

git-svn-id: https://develop.svn.wordpress.org/trunk@29271 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 20:46:22 +00:00
Dominik Schilling (ocean90)
f5c0cf95e0 Fix jshint errors introduced in [29259]. see #11325.
git-svn-id: https://develop.svn.wordpress.org/trunk@29269 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 20:02:34 +00:00
Dominik Schilling (ocean90)
5bba352ae0 Media CSS: Fix typo in box-shadow property for WebKit and update indentation to match the other ones.
git-svn-id: https://develop.svn.wordpress.org/trunk@29268 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 19:57:21 +00:00
Scott Taylor
80c4d6a96c Media Grid: general JS cleanup.
Props ericlewis.
See #28965.



git-svn-id: https://develop.svn.wordpress.org/trunk@29266 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 16:20:59 +00:00
Sergey Biryukov
d51539d8b3 Media Grid: Fix missing padding in RTL in Attachment Details modal.
see #28980.

git-svn-id: https://develop.svn.wordpress.org/trunk@29265 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 03:17:59 +00:00
Sergey Biryukov
708af1c467 Media Grid: Swap arrow direction in RTL in Attachment Details modal.
props adamsilverstein.
fixes #28980.

git-svn-id: https://develop.svn.wordpress.org/trunk@29264 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 03:07:21 +00:00
Helen Hou-Sandi
25b733cea2 Move the "view" link for attachment details to the sidebar and use more specific language. Removes an unnecessary JS handler. fixes #28977.
git-svn-id: https://develop.svn.wordpress.org/trunk@29263 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 02:19:21 +00:00
Sergey Biryukov
f171b362a9 Media Grid: Add a View button to Attachment Details modal.
props adamsilverstein.
fixes #28977.

git-svn-id: https://develop.svn.wordpress.org/trunk@29262 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 01:29:17 +00:00
Andrew Ozz
9106987a3f TinyMCE: include 85e22b58e9that and quote one more use of "float". This is "reserved as future keyword by older ECMAScript specifications" according to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar and can throw a syntax error. See #28576.
git-svn-id: https://develop.svn.wordpress.org/trunk@29261 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-21 23:04:29 +00:00
John Blackbourn
dfa33f92ff Add a lang attribute to each language listed on the language selector screen during installation. See #28858, #28577.
git-svn-id: https://develop.svn.wordpress.org/trunk@29260 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-21 21:50:12 +00:00
Sergey Biryukov
ac17007b10 Remove requirement for a minimum image size in the image editor.
props ericlewis, solarissmoke.
fixes #11325.

git-svn-id: https://develop.svn.wordpress.org/trunk@29259 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-21 19:09:44 +00:00
Sergey Biryukov
98e7bb798c Don't always focus password field on interim login.
props johnbillion.
fixes #28961.

git-svn-id: https://develop.svn.wordpress.org/trunk@29258 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-21 16:20:05 +00:00
Sergey Biryukov
4ba18baec2 Remove a redundant condition for comment feeds from WP_Query::get_posts().
props engelen.
fixes #28401.

git-svn-id: https://develop.svn.wordpress.org/trunk@29257 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-21 15:37:14 +00:00
Peter Westwood
01277f8d32 XMLRPC: Switch the file deletion alias to be deleteFile to more closely make uploadFile.
Fixes #5310 props SergeyBiryukov.


git-svn-id: https://develop.svn.wordpress.org/trunk@29255 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-20 14:01:35 +00:00
Peter Westwood
6d0218365b Post beta2 version bump to 4.0-beta2-29254
git-svn-id: https://develop.svn.wordpress.org/trunk@29254 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-20 13:58:21 +00:00
Scott Taylor
b085282340 WP_Dependencies->recurse_deps(): tuck the recursion into elseif so the foreach doesn't break on the first item.
See [29252].


git-svn-id: https://develop.svn.wordpress.org/trunk@29253 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-20 00:33:51 +00:00
Scott Taylor
77ee35c4eb wp_script_is( ..., 'enqueued' ) needs to check dependencies recursively - a single item's dependencies may only be a subset of the full dependency tree. Adds a new method on WP_Dependencies called ->recurse_deps().
Adds unit test.

Props wonderboymusic, SergeyBiryukov, mikejolley.
Fixes #28404.


git-svn-id: https://develop.svn.wordpress.org/trunk@29252 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-20 00:28:57 +00:00
Scott Taylor
ca5d586b8e After [29200], switch back to using static vars instead of adding 2 globals, as per Sergey.
Fixes #28697.


git-svn-id: https://develop.svn.wordpress.org/trunk@29250 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 23:13:19 +00:00
Scott Taylor
a1aa518788 Call untrailingslashit() when adding a theme directory in register_theme_directory(). This prevents double-slashing in generated URLs. Don't add a directory if it is already present.
Adds unit tests.
Props obenland, wonderboymusic.
Fixes #28662.


git-svn-id: https://develop.svn.wordpress.org/trunk@29249 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 23:06:54 +00:00
Scott Taylor
150e1367b4 In get_adjacent_post(), make $excluded_terms work as expected.
Adds unit tests.
Props jessepollak, kovshenin.
Fixes #22112.


git-svn-id: https://develop.svn.wordpress.org/trunk@29248 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 22:26:43 +00:00
Andrew Ozz
9c366c8f61 Fix admin menu open/close issues on some mobile devices, props adamsilverstein, fixes #27980.
git-svn-id: https://develop.svn.wordpress.org/trunk@29247 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 18:54:50 +00:00
Andrew Ozz
b53705fa7b TinyMCE wpView: better removal of views, replace a selected view when pasting. Props avryl, fixes #28913.
git-svn-id: https://develop.svn.wordpress.org/trunk@29246 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 07:29:34 +00:00
Andrew Ozz
8c67be305d TinyMCE wpVIew: use CSS3 currentcolor for the fake carets, see #28595.
git-svn-id: https://develop.svn.wordpress.org/trunk@29245 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 06:28:38 +00:00
Sergey Biryukov
50090763ba Remove redundant title attributes from get_calendar().
props joedolson.
fixes #26561.

git-svn-id: https://develop.svn.wordpress.org/trunk@29244 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 04:40:32 +00:00
Sergey Biryukov
d83dbfca17 Customizer: Remove "Add a Widget" button from tab order when reordering widgets.
fixes #28890.

git-svn-id: https://develop.svn.wordpress.org/trunk@29243 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 03:31:49 +00:00
Sergey Biryukov
45ec949d58 Customizer: When widget reorder button is actioned, transfer focus to the first Move control within the section.
fixes #28891.

git-svn-id: https://develop.svn.wordpress.org/trunk@29242 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 03:23:51 +00:00
Sergey Biryukov
c62cd97555 Add a class for get_comment_author_link() in Recent Comments widget.
props DrewAPicture, dannydehaan, 5um17.
fixes #27944.

git-svn-id: https://develop.svn.wordpress.org/trunk@29241 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 02:43:27 +00:00
Sergey Biryukov
0121e36154 Customizer: Add screen reader text to announce that panels and sections are expandable.
props joedolson, ocean90.
fixes #27591.

git-svn-id: https://develop.svn.wordpress.org/trunk@29240 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 02:36:07 +00:00
Sergey Biryukov
123702b484 Add screen reader text to announce that menu item accordion sections are expandable. Remove redundant title attribute.
props joedolson.
fixes #28866.

git-svn-id: https://develop.svn.wordpress.org/trunk@29239 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 02:20:58 +00:00
Sergey Biryukov
a740868552 Customizer: Add widget title to Move/Up/Down controls to provide context for screen readers when reordering or moving widgets.
fixes #28889.

git-svn-id: https://develop.svn.wordpress.org/trunk@29238 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 01:57:05 +00:00
Sergey Biryukov
7a01c6af7b Customizer: Avoid losing focus when adding widgets via keyboard.
props sathishn.
fixes #28835.

git-svn-id: https://develop.svn.wordpress.org/trunk@29237 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 01:18:39 +00:00
Andrew Ozz
bcff52c1b0 TinyMCE wpView:
- Typing something replaces a selected view.
- Pressing backspace deletes the selection.
- Pressing enter also deletes the selection.
- Pasting something replaces the selection.
- Also merge the different 'keydown' handlers.
Props avryl, fixes #28913.

git-svn-id: https://develop.svn.wordpress.org/trunk@29236 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 00:33:46 +00:00
Sergey Biryukov
fad9723a42 Revert [28963].
see #28006.

git-svn-id: https://develop.svn.wordpress.org/trunk@29235 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 00:25:46 +00:00
Sergey Biryukov
9b1dbf7417 Use an existing string.
see #19205.

git-svn-id: https://develop.svn.wordpress.org/trunk@29234 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 23:55:47 +00:00
Sergey Biryukov
54f0c851d5 Reverse the order of roles in help text on Add New User screen to match [25695].
fixes #28914.

git-svn-id: https://develop.svn.wordpress.org/trunk@29233 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 23:47:54 +00:00
Sergey Biryukov
218cbba634 Add screen reader text for star ratings on Install Plugins screen.
props joedolson.
fixes #28852.

git-svn-id: https://develop.svn.wordpress.org/trunk@29232 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 23:40:43 +00:00
Andrew Ozz
72916a9751 TinyMCE: better "color preview" for the text color button, props avryl, fixes #28280.
git-svn-id: https://develop.svn.wordpress.org/trunk@29231 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 22:14:05 +00:00