Commit Graph

32751 Commits

Author SHA1 Message Date
John Blackbourn
e904632cc3 Remove register_api_field() from core. This is the only core function that utilises the $wp_rest_additional_fields global, and doesn't belong as part of the infrastructure.
See https://github.com/WP-API/WP-API/pull/1748

Fixes #34730


git-svn-id: https://develop.svn.wordpress.org/trunk@35687 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 20:38:25 +00:00
Sergey Biryukov
28a1b19ed1 I18N: After [35620], move the code for standardizing on \n line endings to Translation_Entry::key().
Props dd32.
Fixes #22172.

git-svn-id: https://develop.svn.wordpress.org/trunk@35686 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 20:36:50 +00:00
Dominik Schilling (ocean90)
6d01a1266d Revert [35336] and [35337].
See #28344.

git-svn-id: https://develop.svn.wordpress.org/trunk@35685 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 20:29:44 +00:00
Aaron Jorbin
76da6cf987 Set cssmin compatibility to ie7
This matches the autoprefixer setting. This changes all compiled CSS.

Fixes #34540.
Props christophherr, peterwilsoncc, netweb



git-svn-id: https://develop.svn.wordpress.org/trunk@35684 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 20:27:45 +00:00
Scott Taylor
0749514c94 List Tables: After [35622] and [34271], improve pagination logic when queries are altered.
Props bradyvercher.
Fixes #29870.


git-svn-id: https://develop.svn.wordpress.org/trunk@35683 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 20:24:44 +00:00
Scott Taylor
d2d6241aa5 List Tables: After [34728], don't try to infer orderby from query params.
List tables are really good.

Props cklosows.
Fixes #25493.


git-svn-id: https://develop.svn.wordpress.org/trunk@35682 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 20:18:08 +00:00
Scott Taylor
af97ffd81c Plugins: add dismissible notices to update failures.
Adds unit test.

Props afercia, mehulkaklotar.
Fixes #33465.


git-svn-id: https://develop.svn.wordpress.org/trunk@35681 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 20:09:21 +00:00
Boone Gorges
26a7e29b81 Allow filtering by non-public taxonomies on edit.php.
[35333] enforces protection for taxonomies by preventing non-public taxonomies
from registering query_vars in `register_taxonomy()`. This broke the use of
taxonomy query_vars on edit.php, breaking backward compatibility and
creating inconsistency with the treatment introduced in [34247], which allowed
`taxonomy=foo` filtering on the Dashboard, even when `foo` is non-public. In
this changeset, we make the same Dashboard exception for the query_var.

Fixes #21949.

git-svn-id: https://develop.svn.wordpress.org/trunk@35680 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 19:58:21 +00:00
Scott Taylor
56d7611f09 Rewrite: alleviate conflicts between image attachment pages and posts when permalink structure is /%postname%/.
Adds unit test.

Props SergeyBiryukov.
Fixes #24612.


git-svn-id: https://develop.svn.wordpress.org/trunk@35679 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 19:58:01 +00:00
Scott Taylor
4aa34cf092 Media: when making images responsive, check if they already have a sizes attribute.
Adds unit test.

Props jaspermdegroot.
Fixes #34678.


git-svn-id: https://develop.svn.wordpress.org/trunk@35678 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 19:47:11 +00:00
Scott Taylor
f16f273cd2 Media: in media_send_to_editor(), use wp_json_encode() instead of addslashes().
Props TobiasBg.
Fixes #22135.


git-svn-id: https://develop.svn.wordpress.org/trunk@35677 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 19:39:19 +00:00
Scott Taylor
1d22015fb3 Customizer i18n: provide translator context for current menu name and location.
Props ryankienstra.
Fixes #33431.


git-svn-id: https://develop.svn.wordpress.org/trunk@35676 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 19:20:30 +00:00
Scott Taylor
2499be55d6 Comments: after [35593], extend support to IE8 and improve checking for elements hidden with CSS
Props afercia.
Fixes #29974.


git-svn-id: https://develop.svn.wordpress.org/trunk@35675 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 19:14:50 +00:00
Scott Taylor
0e5625e4fa List Tables: because we can never eradicate the existence of globals, ensure that $comment is hoisted into the global space inside WP_Comments_List_Table::single_row().
Fixes #34654.


git-svn-id: https://develop.svn.wordpress.org/trunk@35674 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 19:04:33 +00:00
Scott Taylor
65c17a2d88 After [35616], improve the consistency of tabs styling.
Props afercia.
Fixes #34214.


git-svn-id: https://develop.svn.wordpress.org/trunk@35673 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 18:54:05 +00:00
Drew Jaynes
8e44704e5f Docs: Properly mark optional parameters as such in the DocBlock and function signature for wp_calculate_image_sizes().
Also updates the subsequent hook docs for the `wp_calculate_image_sizes` filter.

Props joemcgill.
Fixes #34612.


git-svn-id: https://develop.svn.wordpress.org/trunk@35672 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 18:52:15 +00:00
John Blackbourn
355e768312 Update WP_REST_Response::as_error() to handle the new format error responses introduced in [35653].
Props danielbachhuber
Fixes #34551


git-svn-id: https://develop.svn.wordpress.org/trunk@35671 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 18:28:55 +00:00
Sergey Biryukov
20c9a88a18 I18N: After [34424], replace the placeholder with comments count after translate_nooped_plural() runs, not before.
Props hnle.
Fixes #34680.

git-svn-id: https://develop.svn.wordpress.org/trunk@35670 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 18:03:47 +00:00
Drew Jaynes
6ad74f666e Plugins: Rename the delete_plugin action hook (introduced in [35094]) to deleted_plugin as it fires ''following'' a plugin deletion attempt.
Further, introduce a new `delete_plugin` action hook, to be fired ''before'' a plugin deletion attempt. Both changes bring parity with other such transactional hooks in core that fire before and after certain actions, including on plugin activation/deactivation and install/uninstall, among others.

Props johnjamesjacoby.
Fixes #26904.


git-svn-id: https://develop.svn.wordpress.org/trunk@35669 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 17:57:48 +00:00
Sergey Biryukov
8e439f1bd0 I18N: Move translatable Codex URLs to separate strings in wp-includes/ms-load.php.
Props ramiy.
Fixes #34687.

git-svn-id: https://develop.svn.wordpress.org/trunk@35668 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 17:41:21 +00:00
Sergey Biryukov
bfe32a4d38 I18N: Move translatable Codex URLs to separate strings in wp-includes/functions.php.
Props ramiy.
See #34687.

git-svn-id: https://develop.svn.wordpress.org/trunk@35667 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 17:40:43 +00:00
Sergey Biryukov
23a74b7e4d I18N: Remove <a> tag from translatable string in wp-admin/includes/class-wp-comments-list-table.php.
Props ramiy.
Fixes #34686.

git-svn-id: https://develop.svn.wordpress.org/trunk@35666 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 17:33:07 +00:00
Sergey Biryukov
7b6a8a5b7e I18N: Remove <a> tag from translatable string in wp-admin/comment.php.
Props ramiy.
See #34686.

git-svn-id: https://develop.svn.wordpress.org/trunk@35665 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 17:32:08 +00:00
Sergey Biryukov
7ce972bb33 I18N: Add translator comments for strings in wp-admin/includes/class-wp-filesystem-ftpsockets.php.
Fixes #34684.

git-svn-id: https://develop.svn.wordpress.org/trunk@35664 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 17:22:34 +00:00
Sergey Biryukov
7bde9d176b I18N: Add translator comments for strings in wp-admin/includes/class-wp-filesystem-ftpext.php.
See #34684.

git-svn-id: https://develop.svn.wordpress.org/trunk@35663 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 17:21:37 +00:00
Sergey Biryukov
9f4eb39412 I18N: Add translator comments for strings in wp-admin/includes/class-wp-filesystem-base.php.
See #34684.

git-svn-id: https://develop.svn.wordpress.org/trunk@35662 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 17:20:03 +00:00
Sergey Biryukov
61765f4fd3 I18N: Add translator comments for strings in wp-admin/includes/class-wp-filesystem-ssh2.php.
Props ramiy.
See #34684.

git-svn-id: https://develop.svn.wordpress.org/trunk@35661 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 17:17:54 +00:00
John Blackbourn
3ced239517 Correct the parameter type for the $stylesheet parameter in the mce_css filter documentation.
Fixes #34721
Props hnle


git-svn-id: https://develop.svn.wordpress.org/trunk@35660 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 17:06:22 +00:00
Ryan McCue
52bdf9d6a5 REST API: Remove redundant "0" parameter.
This is just an artifact of how we parse the URL, and is already available
via $request->get_route()

Props danielbachhuber.
Fixes #34647.


git-svn-id: https://develop.svn.wordpress.org/trunk@35659 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-18 07:23:38 +00:00
Ella Iseulde Van Dorpe
7b12240b12 TinyMCE 4.2.8 update
Changelog: http://www.tinymce.com/develop/changelog/?ctrl=version&act=view&pr_id=1&vr_id=889

(No plugin, theme, skin or test changes)

Fixes #34671 and #34720.


git-svn-id: https://develop.svn.wordpress.org/trunk@35658 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-17 23:17:20 +00:00
Dominik Schilling (ocean90)
e0e70036de Buttons: Don't transform disabled buttons by 1px on :active.
Fixes #34717.

git-svn-id: https://develop.svn.wordpress.org/trunk@35657 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-17 23:17:10 +00:00
Ryan McCue
6190489e45 oEmbed: Drop the trailing slash from the namespace.
Props swissspidy.
Fixes #34709.


git-svn-id: https://develop.svn.wordpress.org/trunk@35656 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-17 11:26:36 +00:00
Gary Pendergast
d55c605242 WPDB: Fall back to the connection charset when sanity checking strings.
If `DB_CHARSET` isn't defined (or is empty), `wpdb::$charset` will be empty, too. `wpdb::strip_invalid_text()` assumes that it isn't empty, however, so we need to fall back to the connection character set when we're running our sanity checks.

Fixes #34708.



git-svn-id: https://develop.svn.wordpress.org/trunk@35655 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-17 06:12:08 +00:00
Ryan McCue
6ad5ee9786 REST API: Update tests for [35653]
See #34551.


git-svn-id: https://develop.svn.wordpress.org/trunk@35654 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-17 05:26:30 +00:00
Ryan McCue
a6aa1a0754 REST API: Optimise for singular error instances.
Previously, the API returned a list of errors, as WP_Error can hold multiple
error codes internally. This isn't a particularly common use case, and it
makes handling errors on the client side more complex than it needs to be.

Fixes #34551.


git-svn-id: https://develop.svn.wordpress.org/trunk@35653 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-17 04:11:21 +00:00
Ryan McCue
10ecf65a4a REST API: Include enum and description in help data.
Props lcherpit.
Fixes #34543.


git-svn-id: https://develop.svn.wordpress.org/trunk@35652 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-17 02:48:21 +00:00
Ryan McCue
0a501976db REST API: Require namespace when registering routes.
Props danielbachhuber.
Fixes #34416.


git-svn-id: https://develop.svn.wordpress.org/trunk@35651 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-17 02:38:31 +00:00
Ryan McCue
8b4a1d65cd REST API: Change link relations to api.w.org
Fixes #34303.


git-svn-id: https://develop.svn.wordpress.org/trunk@35650 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-17 02:23:52 +00:00
Dominik Schilling (ocean90)
774cf7f0d3 Passwords: Only disable hidden password fields if they are really hidden.
Makes the password field on install and for password resets editable again. Both fields were accidentally set to disabled in [35603].

Props adamsilverstein, flixos90.
Fixes #33699.

git-svn-id: https://develop.svn.wordpress.org/trunk@35649 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-16 20:48:51 +00:00
Dominik Schilling (ocean90)
ffb099099a Thickbox: Change only the background-image property for HiDPI screens.
`background` resets `background-size` and makes the spinner fuzzy. Introduced in [35418].

See #33311.

git-svn-id: https://develop.svn.wordpress.org/trunk@35648 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-16 20:32:24 +00:00
Dominik Schilling (ocean90)
aff0065f28 Themes: Hide the favorites form when performing a search.
The search is global and ignores the user setting. Same for filters.

See #34206.

git-svn-id: https://develop.svn.wordpress.org/trunk@35647 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-16 19:49:38 +00:00
Dominik Schilling (ocean90)
32d4eec670 Themes: Check if the browse view is set in wp_ajax_query_themes() to avoid a PHP notice when searching for new themes.
Introduced in [35527].

See #34206.

git-svn-id: https://develop.svn.wordpress.org/trunk@35646 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-16 19:46:37 +00:00
Boone Gorges
56625d9e13 Correct documentation for 'fields' param of WP_User_Query.
[29843] introduced this documentation, and incorrectly stated that short
column names (eg 'login' instead of 'user_login') could be used.

Props birgire.
Fixes #34701.

git-svn-id: https://develop.svn.wordpress.org/trunk@35645 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-16 19:03:13 +00:00
Dion Hulse
10c377b9b9 Decrease the chances that wp_tempnam() will conflict with an existing file by suffixing a random ID to the generated filename.
This also switches from using `touch()` to using `fopen( $file, 'x')` to ensure that we're the process creating the file.

Fixes #34562


git-svn-id: https://develop.svn.wordpress.org/trunk@35644 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-16 05:32:32 +00:00
Weston Ruter
b1bea5bf5c Customize: Ensure multi-line label alignment for checkbox/radio inputs on both desktop and mobile.
Follow-up to [35608].

Props bordoni, delawski.
Fixes #34607.


git-svn-id: https://develop.svn.wordpress.org/trunk@35643 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-16 04:43:16 +00:00
Dion Hulse
7be4ad61ca Upgrader: Pass the $args['hook_extra'] context to the upgrader_source_selection filter.
Props afragen
Fixes #34696


git-svn-id: https://develop.svn.wordpress.org/trunk@35642 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-16 02:46:43 +00:00
John Blackbourn
002b44dc08 Revert [35639] pending investigation into failures on PHP 5.2.
See #19455


git-svn-id: https://develop.svn.wordpress.org/trunk@35641 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-16 00:53:30 +00:00
Gary Pendergast
1824468e8f Embeds: Add the allow_insecure_embeds filter.
This allows a site to disable non-SSL embeds.

Fixes #34588.



git-svn-id: https://develop.svn.wordpress.org/trunk@35640 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-16 00:22:16 +00:00
John Blackbourn
b32cf6875f On servers running PHP <= 5.4 which have magic_quotes_sybase enabled, the superglobals need to be magic-quoted before magic_quotes_sybase is subsequently disabled to avoid incorrect un-slashing. This must surely effect a miniscule number of servers, but so be it.
Fixes #19455
Props summerblue, kurtpayne, lucatume


git-svn-id: https://develop.svn.wordpress.org/trunk@35639 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-15 22:59:51 +00:00
Dominik Schilling (ocean90)
0792eaf237 Schema: Increase length of user_pass and user_activation_key fields to 255.
Props grvrulz and Miglosh for testing.
Fixes #33904.

git-svn-id: https://develop.svn.wordpress.org/trunk@35638 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-15 14:18:51 +00:00