Commit Graph

27523 Commits

Author SHA1 Message Date
Sergey Biryukov a86e98ba96 Merge two similar strings.
props pavelevap.
fixes #29751.

git-svn-id: https://develop.svn.wordpress.org/trunk@29768 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-26 19:29:59 +00:00
Sergey Biryukov c993055800 Remove extra space from a string.
props pavelevap.
fixes #29752.

git-svn-id: https://develop.svn.wordpress.org/trunk@29767 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-26 18:48:05 +00:00
Andrew Ozz 27806558a2 TinyMCE wpView: when pasting/inserting content before a view, add new paragraph above it and insert the content there. Props avryl, fixes #29380 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@29766 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-26 00:20:28 +00:00
Sergey Biryukov 3226d8b867 Create correct permalinks for child posts of hierarchical post types when default permalinks are used.
props loushou.
fixes #29615 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29765 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-24 21:29:15 +00:00
Sergey Biryukov fe6f5b3af3 Add context for 'Trash' string in media modal.
props pavelevap.
fixes #29739.

git-svn-id: https://develop.svn.wordpress.org/trunk@29764 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-24 13:48:27 +00:00
Drew Jaynes (DrewAPicture) 198db28c17 Improve and clarify inline commenting inside the `check_comment()` function.
Adds logical explanations of what some of the various comment checks are checking for, as well as some general cleanup and syntax fixes.

Fixes #29734.


git-svn-id: https://develop.svn.wordpress.org/trunk@29763 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 18:48:31 +00:00
Drew Jaynes (DrewAPicture) 0adb5f14aa Improve documentation in the `check_comments()` docblock.
* Removes two duplicate sentences from the long description
* Tightens up phrasing elsewhere in the long description for specific checks
* Clarifies the parameter and return descriptions, and adds periods

See #29734.


git-svn-id: https://develop.svn.wordpress.org/trunk@29762 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 18:46:52 +00:00
Scott Taylor 0b0eb4fb20 Ordering by `RAND()`:
The shortcode callbacks for `gallery` and `playlist` check for `'RAND' == $atts['order']`, which isn't a valid value for `order`. Remove those checks and update the docs.

In `WP_Query`, if the value of `orderby` is `rand`, `order` is irrelevant and should be unset.

Adds unit tests.

Fixes #29629.


git-svn-id: https://develop.svn.wordpress.org/trunk@29760 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 03:51:24 +00:00
Scott Taylor af71d22742 Add two properties to `media.model.Attachments.propmap`: `include` and `exclude`, which are aliases for `post__in` and `post__not_in`.
This allows you to instantiate a library that includes and/or excludes specific attachments by passing a single ID or an array of IDs.

Example usage:
{{{
wp.media({frame: 'post', library: {include: [414, 415]}}).open()
wp.media({frame: 'post', library: {include: 414}}).open()
wp.media({frame: 'post', library: {exclude: [414, 415]}}).open()
wp.media({frame: 'post', library: {exclude: 414}}).open()
}}}

Fixes #26587.


git-svn-id: https://develop.svn.wordpress.org/trunk@29759 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 03:37:06 +00:00
Scott Taylor 22db82dff1 In `wp_ajax_replyto_comment()`, if `$_POST['comment_type']` is set, use it for the value of `$comment_type`, which the `compact()` call has assumed is set since [8720]. It never was.
`wp_comment_reply()`'s output can be complete overridden by the `wp_comment_reply` filter, so this check is justified and makes the AJAX callback more flexible.

Props nerrad.
Fixes #29704.


git-svn-id: https://develop.svn.wordpress.org/trunk@29758 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 03:28:51 +00:00
Scott Taylor e97e5048c3 If the current user does not have the `delete_posts` cap on the current post type, don't list `delete` or `trash` as bulk actions for the relevant context of Post list table.
Props mvd7793.
Fixes #20175.


git-svn-id: https://develop.svn.wordpress.org/trunk@29757 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 02:57:43 +00:00
Scott Taylor f00f28cce0 `wp_extract_urls()` needs to also grab URLs with query strings and hashes.
Updates unit test.

Props hauvong, dlh.
Fixes #29314.


git-svn-id: https://develop.svn.wordpress.org/trunk@29756 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 02:49:22 +00:00
Scott Taylor 32c1d55d1f Media Grid:
* In Bulk Edit mode, don't attempt to delete or trash an attachment that doesn't have a `delete` nonce. The subsequent `_requery()` will then properly display the attachment still present in the library.
* Remove all updated models from the selection at the same time to avoid async race conditions. The selection is reset when the grid's `select` mode is deactivated, but this allows this view instance to be more portable.

This fix allows users to set caps on individual attachments without confusing the grid's library. This issue was present for bulk actions in general, had nothing to do with `MEDIA_TRASH` specifically.

Fixes #29597.


git-svn-id: https://develop.svn.wordpress.org/trunk@29755 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-21 18:51:41 +00:00
Sergey Biryukov 994566bb17 Pass the attachment ID to the 'image_add_caption_text' filter.
fixes #29607.

git-svn-id: https://develop.svn.wordpress.org/trunk@29754 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-21 10:10:19 +00:00
Sergey Biryukov 9e673c7eee Add 'image_add_caption_text' filter for changing the pre-parse caption text before output to the editor.
props collinsinternet, DrewAPicture.
fixes #29607.

git-svn-id: https://develop.svn.wordpress.org/trunk@29753 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-21 09:55:08 +00:00
Drew Jaynes (DrewAPicture) 191a7ead45 Add some missing information to the inline docs for `get_post_types()`.
* Improves the `@see` reference for `register_post_type()` to mention that it contains information about accepted arguments
* Adds a description of the accepted values for the `$operator` parameter
* Fixes a typo

Fixes #29721.


git-svn-id: https://develop.svn.wordpress.org/trunk@29752 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-21 08:54:37 +00:00
Andrew Nacin 4c1462f2ff Add safeguards for when ext/hash is not compiled with PHP.
see #29518, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@29751 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-20 17:27:46 +00:00
Sergey Biryukov 5b2c58d5b3 Correct 'wp_get_attachment_image_attributes' filter docs.
props tillkruess.
fixes #29701.

git-svn-id: https://develop.svn.wordpress.org/trunk@29750 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-18 12:35:25 +00:00
Andrew Nacin 9c751b268a Don't set ftp_credentials option when installling. see #29635.
git-svn-id: https://develop.svn.wordpress.org/trunk@29749 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-17 17:57:59 +00:00
Scott Taylor 606cd967f6 `wptexturize()` improvements:
* Expand the `wptexturize()` RegEx to include the list of registered shortcodes.
* Avoid backtracking after `[` chars by not filtering params in registered shortcodes. This will cause escaped shortcodes and their params to become texturized if not registered.
* Registered shortcode params will never be texturized, even when escaped.
* Move all tests involving unregistered shortcodes to a new and improved unit.
* Update one test involving HTML within shortcode params.

Props miqrogroove.
See #29557.


git-svn-id: https://develop.svn.wordpress.org/trunk@29748 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-17 15:13:24 +00:00
Scott Taylor fbf974a962 After [29200] and [29250], `Tests_MS::test_multisite_bootstrap()` should no longer have the `@expectedDeprecated` annotation.
git-svn-id: https://develop.svn.wordpress.org/trunk@29747 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-15 18:05:06 +00:00
Scott Taylor fd0b0d5f4f `assertTag()` has been deprecated in PHPUnit 4.2. Rewrite some of the tests in `Tests_Paginate_Links` to use `DOMDocument`.
Props effstieler.
Fixes #29545.


git-svn-id: https://develop.svn.wordpress.org/trunk@29746 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-15 17:41:47 +00:00
Sergey Biryukov 6e0ca0d8d9 Make sure the $parent argument of wp_insert_attachment() still works as expected after [28579].
prop jesin, dikiy_forester.
fixes #29646 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29745 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-15 14:23:31 +00:00
Sergey Biryukov 1ec860298d Correct @return value for WP_User_Query::get_total().
props jesin.
fixes #29656.

git-svn-id: https://develop.svn.wordpress.org/trunk@29744 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-13 22:23:12 +00:00
Sergey Biryukov 0075f1c7d1 Correct some @since values added in [29739].
see #28459.

git-svn-id: https://develop.svn.wordpress.org/trunk@29743 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-13 12:17:17 +00:00
Scott Taylor 0efd852117 `WP_oEmbed::_strip_newlines` is called as a filter callback for `oembed_dataparse`, must be public. It was marked as private for fun in [14109] and then made `private` officially in [28507].
Fixes #29647 for trunk.



git-svn-id: https://develop.svn.wordpress.org/trunk@29742 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-12 22:53:04 +00:00
wonderboymusic 578609d31e Make the URL output in `_thickbox_path_admin_subfolder()` use `includes_url()`.
Props voldemortensen.
Fixes #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@29741 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-12 22:30:03 +00:00
Andrew Nacin 2dd4990234 kses: Add colgroup.
props collinsinternet.
fixes #29433.


git-svn-id: https://develop.svn.wordpress.org/trunk@29740 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-12 05:50:03 +00:00
Scott Taylor cbaef4a1a3 Add some `@since` annotations to `media-views.js`.
Props DrewAPicture.
See #28459.


git-svn-id: https://develop.svn.wordpress.org/trunk@29739 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-12 03:35:15 +00:00
Andrew Ozz a9384b7a30 Editor expand: hide TinyMCE float panels and tooltips when scrolling, props avryl, fixes #29516 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@29738 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-12 01:20:09 +00:00
Scott Taylor 6ed8bab324 In `media_handle_upload()`, don't call `wp_read_image_metadata()` on things that aren't images (like videos). We never caught this error, because we are suppressing it by calling `@wp_read_image_metadata()`.
Props jrf for the initial patch.
Fixes #28907.


git-svn-id: https://develop.svn.wordpress.org/trunk@29737 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-11 20:14:56 +00:00
Scott Taylor 4d3a00c195 After [29733], version bump for MediaElement.
git-svn-id: https://develop.svn.wordpress.org/trunk@29736 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-11 19:46:49 +00:00
Scott Taylor 1b1c55c583 Allow arbitrary subdomains for the oEmbed endpoint for Slideshare.
Props Latz.
Fixes #29427.


git-svn-id: https://develop.svn.wordpress.org/trunk@29735 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-11 19:24:07 +00:00
Scott Taylor 749f51c348 Update getID3 library to 1.9.8.
Changes:
https://github.com/JamesHeinrich/getID3/compare/1.9.7...v1.9.8

Fixes #29627.


git-svn-id: https://develop.svn.wordpress.org/trunk@29734 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-11 19:06:33 +00:00
Scott Taylor 1930d0940e Upgrade MediaElement to 2.15.1.
Changes from 2.15.0:
https://github.com/johndyer/mediaelement/compare/2.15.0...2.15.1

Continues to revert upstream commit b7f82b4 to restore the status quo for Chromium support.

See [29688].
Fixes #29620 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@29733 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-11 17:43:05 +00:00
Sergey Biryukov 2becf84579 Skip ALTERNATE_WP_CRON redirect when performing XML-RPC requests.
props markoheijnen.
fixes #27447.

git-svn-id: https://develop.svn.wordpress.org/trunk@29732 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-11 14:01:04 +00:00
Sergey Biryukov 5a89372970 XML-RPC: Check if category support was added for pages before calling wp_get_post_categories() to avoid unnecessary query in wp.getPage.
props markoheijnen, nprasath002.
fixes #17920.

git-svn-id: https://develop.svn.wordpress.org/trunk@29731 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-11 13:55:56 +00:00
Andrew Ozz 1190ed50a8 TinyMCE: fix image captions regexp when wpautop is disabled in wp_editor(). Fixes #29592 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@29730 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-10 23:02:05 +00:00
Andrew Ozz 123fae73b5 Media: revert enabling of multi-file uploading for mobile devices. Currently only iOS Safari supports it but has a bug that prevents uploading of videos. Fixes #29602
git-svn-id: https://develop.svn.wordpress.org/trunk@29729 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-10 22:39:39 +00:00
Scott Taylor 698f77735b Don't overwrite the `length` property unnecessarily when generating metadata for audio and video files.
Props jrf, wonderboymusic.
Fixes #29176.


git-svn-id: https://develop.svn.wordpress.org/trunk@29728 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-10 21:56:24 +00:00
Dominik Schilling (ocean90) c339c62e38 Media Frames: Set the box-sizing CSS property to border-box for checkboxes and radio buttons.
props mlteal.
see #29493.

git-svn-id: https://develop.svn.wordpress.org/trunk@29727 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-10 18:08:13 +00:00
Sergey Biryukov 69b97690d5 Widgets: Toggle widget arrow when the widget is closed using Close link.
props senff.
fixes #29617.

git-svn-id: https://develop.svn.wordpress.org/trunk@29726 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-10 17:35:38 +00:00
Sergey Biryukov 9c48d0f495 Make sure we're on the media grid page before calling wp.media().
props azaozz.
fixes #29520 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29725 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-09 10:13:33 +00:00
Sergey Biryukov 00bfc5bc34 Avoid PHP notices in media modal caused by orphaned attachments.
fixes #29566 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29724 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-09 10:02:36 +00:00
Sergey Biryukov 7ce9d697c6 Don't display Edit links for attachments user cannot edit.
props skaeser.
fixes #29596 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29723 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-09 09:49:55 +00:00
Sergey Biryukov eb20eeaa60 Add 'Unattached' filter for galleries.
props pento.
fixes #29329.

git-svn-id: https://develop.svn.wordpress.org/trunk@29722 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-09 07:13:39 +00:00
Sergey Biryukov 8cfdbf1167 Use https for apps.wordpress.org links.
props pento.
fixes #29595 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29721 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-09 06:28:33 +00:00
Sergey Biryukov aa9af951e5 Remove 'WordPress Language' reference from wp-config-sample.php.
props voldemortensen.
see [29630]. fixes #29562.

git-svn-id: https://develop.svn.wordpress.org/trunk@29720 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-09 01:22:05 +00:00
Sergey Biryukov 3136cbb1c9 Twenty Fourteen: Use correct check for the front page in Featured_Content::pre_get_posts().
props kwight.
fixes #29550.

git-svn-id: https://develop.svn.wordpress.org/trunk@29719 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-07 14:22:38 +00:00
Sergey Biryukov d552ba29bc * Declare $site_mimes before using it in check_upload_mimes().
* Use the same default value for 'upload_filetypes' as on Network Settings screen.

props rmccue.
fixes #29512 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29718 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-07 10:10:33 +00:00