Commit Graph

27523 Commits

Author SHA1 Message Date
Drew Jaynes (DrewAPicture) e94fef0168 Clarify inline documentation for the `_is_valid_nav_menu_item()` and `wp_get_nav_menu_items()` in wp-includes/nav-menu.php.
Props morganestes for the initial patch.
Fixes #29914.


git-svn-id: https://develop.svn.wordpress.org/trunk@29868 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-10 17:13:52 +00:00
Boone Gorges bce6d64d59 Return an error when adding a term to a non-existent parent.
Parallels the logic of wp_insert_term(), introduced in [29196].

Props jesin.
Fixes #29614.

git-svn-id: https://develop.svn.wordpress.org/trunk@29867 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-09 18:11:17 +00:00
Drew Jaynes (DrewAPicture) cfac76a2cc Add more complete inline documentation for `get_term_link()`.
Adds more complete parameter descriptions for the `$term` and `$taxonomy` parameters. 

Props amruta123.b for the initial patch.
Fixes #29901.


git-svn-id: https://develop.svn.wordpress.org/trunk@29866 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-09 15:40:53 +00:00
Boone Gorges adbed947d8 Don't bail out of term_exists() when term sanitizes to an empty string.
This change brings return values for failures of this sort in line with other
failed lookups in term_exists(): a null value is now returned in all cases
where the queried term is not found.

Adds unit test for the sanitization issue. Modifies existing unit test to
reflect the change in return value for empty term strings.

Props boonebgorges, georgestephanis.
Fixes #29589.

git-svn-id: https://develop.svn.wordpress.org/trunk@29865 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-09 03:15:50 +00:00
Dion Hulse 8ff133f232 Add some unit tests for WP_HTTP::parse_url() to cover the <PHP 5.4.7 compatibility alterations.
These unit tests cover the expected vehaviour of certain combinations of URL's, but makes no attempt to test invalid URL structures, as PHP's behavious for invalid URL's is undefined (Some will be treated as paths, others fail, and it varies between PHP 5.4.7+ and <5.4.7).
This change also makes WP_HTTP::parse_url() protected in order to allow unit testing.
See #28001, #29886


git-svn-id: https://develop.svn.wordpress.org/trunk@29864 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-09 03:00:16 +00:00
Boone Gorges 568b43f242 Fix term_exists() for parent = 0.
Passing a 0 (or '0') as the 'parent' param of term_exists() should limit
results to terms with no parent.

Adds unit test.

Fixes #29851.

git-svn-id: https://develop.svn.wordpress.org/trunk@29863 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-09 02:48:47 +00:00
Boone Gorges 01c529e062 Improve 'alias_of' handling in wp_insert_term() and wp_update_term().
Using get_term_by() rather than direct SQL queries to fetch the alias term
fixes a number of issues:

* Object cache for aliased term is properly cleared after update.
* If the aliased term is in the object cache, it's served from there, saving a database query.
* Duplicate 'edit_terms' and 'edited_terms' hooks can be removed.
* Fix a PHP notice when the 'alias_of' term is not found.
* Prevent the incorrect creation of a new term group for the primary term when the 'alias_of' term is not found.

Adds unit tests for 'alias_of' functionality in both functions.

Fixes #29848.

git-svn-id: https://develop.svn.wordpress.org/trunk@29862 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-09 02:31:35 +00:00
Dion Hulse c8b53c2d1a Handle deficiencies in PHP's parse_url in older versions of PHP (<5.4.7) in WP_HTTP::make_absolute_url().
In older versions of PHP:
- parse_url() will fail to parse a url where the scheme break (://) is present in a relative URL's path
- parse_url() will include the hostname of a schemeless URL in the path component

This handles those two types of URL's by correcting the response from parse_url().

Fixes #28001, #29886


git-svn-id: https://develop.svn.wordpress.org/trunk@29861 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-09 01:10:25 +00:00
Boone Gorges 5e7be10860 Reset post types and taxonomies before each unit test.
Registering a post type or taxonomy during a unit test causes modifications to
global variables. If the test fails to clean up these globals - either by
neglecting to call _unregister_post_type()/_unregister_taxonomy() at all or by
failing before getting a chance to do so - tests that run later in the suite
can fail, leading to much gnashing of teeth. Wiping all taxonomies and
restoring to the defaults before each test ensures that we always start with a
clean slate.

Fixes #29827.

git-svn-id: https://develop.svn.wordpress.org/trunk@29860 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-09 00:57:26 +00:00
Boone Gorges 91a3b376de Explicitly declare hierarchical=false for post_tag in create_initial_taxonomies().
In certain edge cases, such as during the automated test suite,
create_initial_taxonomies() can be called in a situation where a non-default
permastruct setting has been saved outside of wp-admin. This causes the
'hierarchical' setting for the post_tag taxonomy to remain unset, leading to
PHP notices in get_term_link().

See #29827.

git-svn-id: https://develop.svn.wordpress.org/trunk@29859 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-09 00:57:16 +00:00
Aaron Jorbin 636e35877e .jshintrc is a json file and .editorconfig should treat it like a json file
props netweb
fixes #29884


git-svn-id: https://develop.svn.wordpress.org/trunk@29858 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-08 19:26:50 +00:00
Aaron Jorbin 3bfa930580 Change assertEqual to assertEqualSets since the order that travis-ci creates posts isn't consistent
see #29718



git-svn-id: https://develop.svn.wordpress.org/trunk@29857 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-08 19:21:30 +00:00
Dominik Schilling (ocean90) e9be4237ba Language packs: Remove translations when deleting a theme or a plugin.
This is for translation files in WP_LANG_DIR which are installed through a language pack.
Change `wp_get_installed_translations()` to only return a translation if the .mo file also exists.

fixes #29860.

git-svn-id: https://develop.svn.wordpress.org/trunk@29856 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-08 19:04:05 +00:00
Konstantin Kovshenin 061fe13c9f Use the primary `meta_query` clause when parsing `orderby` in `WP_Query`.
When using legacy `meta_key`, `meta_value`, etc. arguments in `WP_Query`,
they're converted into the first clause of a `meta_query`. By using that
clause instead of the original arguments, we make sure that behavior is
consistent between the two available formats.

props boonebgorges.
fixes #16814.


git-svn-id: https://develop.svn.wordpress.org/trunk@29855 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-08 15:11:14 +00:00
Konstantin Kovshenin 6eea081457 New `remove()` method and some unit tests for the `WP_Error` class.
props stephenharris.
fixes #28092.


git-svn-id: https://develop.svn.wordpress.org/trunk@29854 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-08 07:11:09 +00:00
Dion Hulse eb39c8f75d Avoid a PHP Notice when requesting a url without a path component (http://example.com) in the Streams HTTP component.
Props barrykooij for inital patch; Fixes #27668


git-svn-id: https://develop.svn.wordpress.org/trunk@29853 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-08 06:43:14 +00:00
Dion Hulse 45cd55bfc4 When making a HTTP request to a non-standard port, include the port in the Host header for the Streams HTTP transport. This bring parity to the cURL transport and respects the HTTP RFC.
Props kamelkev for the initial patch; Fixes #28982


git-svn-id: https://develop.svn.wordpress.org/trunk@29852 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-08 06:14:58 +00:00
Dion Hulse 4ae1397f96 Correctly support Schemeless URLs in WP_HTTP::make_absolute_url() by respecting the 'host' field if present in the relative url.
Fixes #29886


git-svn-id: https://develop.svn.wordpress.org/trunk@29851 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-08 05:57:15 +00:00
Dion Hulse e4268adfde Correctly handle url's containing url's in WP_HTTP::make_absolute_url().
A valid relative URL could be mistaken for an absolute url if it contained a :// in any position of the url.
Fixes #28001


git-svn-id: https://develop.svn.wordpress.org/trunk@29850 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-08 05:37:56 +00:00
Dion Hulse 60b8ed120a Always cast the 'code' server response to an int, this provides consistency between both of the HTTP transports.
Previously cURL would return an int and Streams a numeric string.
Fixes #28887


git-svn-id: https://develop.svn.wordpress.org/trunk@29849 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-08 05:20:01 +00:00
Dion Hulse 2ed0d6cae0 Return the correct server response for the 'message' response field from the server.
Previously this would use the generic message corresponding to the response code, which isn't always accurate. Since we're already parsing the headers, we can simply return that directly (This also has the benefit that it's the same code for both Streams and Curl header handling).
Fixes #28919


git-svn-id: https://develop.svn.wordpress.org/trunk@29848 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-08 05:18:22 +00:00
Dominik Schilling (ocean90) 539d55e068 Update jQuery UI to 1.11.1.
Because jQUI's build process no longer provides individual minified files we need some additional changes:
* Rename all files, remove the "jquery.ui." prefix. Add old files to `$_old_files`.
* Add and use non-minified files in /src.
* Add grunt task to minify jQuery UI files.
* (Non-minified files will not be shipped.)

Changelogs:
* http://jqueryui.com/changelog/1.11.0/
* http://jqueryui.com/changelog/1.11.1/

props Fab1en, ocean90.
fixes #29833.

git-svn-id: https://develop.svn.wordpress.org/trunk@29847 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-07 15:27:56 +00:00
Sergey Biryukov 564598f068 Add aria-describedby attributes to comment_form().
props joedolson, bramd.
fixes #24148.

git-svn-id: https://develop.svn.wordpress.org/trunk@29846 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-06 22:10:08 +00:00
Boone Gorges e79c2e0c9e In get_terms(), select term taxonomy count for all values of 'fields'.
Not having the count caused queries with 'fields' values of 'id=>name' and
'id=>slug' to return incorrect results when querying a hierarchical taxonomy
with 'hide_empty=true'.

Includes unit tests for get_terms() when using various combinations of 'fields',
'hide_empty', and 'hierarchical' arguments.

Props technical_mastermind.
Fixes #29859.

git-svn-id: https://develop.svn.wordpress.org/trunk@29845 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-06 22:04:11 +00:00
Aaron Jorbin 3fa30bdd37 PHP 5.6 test failures shouldn't be allowed.
PHP 5.6 was released on 28 August 2014 and thus tests on it should be on the same level as all of our other PHP tests pass.

Fixes #29682
Props netweb



git-svn-id: https://develop.svn.wordpress.org/trunk@29844 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-06 20:00:54 +00:00
Drew Jaynes (DrewAPicture) d8ba2cf553 Add inline documentation for `WP_User_Query` default arguments in the form of a hash notation.
Adds documentation pointers from the class-level doc for `WP_User_Query`, as well as the `get_users()` doc.

Props tschutter.
Fixes #29846.


git-svn-id: https://develop.svn.wordpress.org/trunk@29843 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-06 15:35:49 +00:00
Sergey Biryukov 63760f6a3f Bundled themes: Add an alt attribute with the site title for header images linked to the home page.
props rianrietveld.
fixes #15926.

git-svn-id: https://develop.svn.wordpress.org/trunk@29842 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-06 12:43:55 +00:00
Andrew Ozz 107d754683 Add default z-index to the admin menu, see #29806
git-svn-id: https://develop.svn.wordpress.org/trunk@29841 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-06 01:59:46 +00:00
Sergey Biryukov 937d5cdd11 Translate some previously untranslated _doing_it_wrong() messages.
props georgestephanis.
fixes #25614.

git-svn-id: https://develop.svn.wordpress.org/trunk@29840 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-05 21:05:54 +00:00
Sergey Biryukov 65a0f4933a Network Admin: Properly check if the theme is active on the main site to avoid deleting it via bulk actions.
props ocean90.
fixes #29861.

git-svn-id: https://develop.svn.wordpress.org/trunk@29839 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-05 20:36:11 +00:00
Sergey Biryukov 37f96ce3e6 Fix misleading documentation in customize-loader.js.
props ericlewis.
fixes #29866.

git-svn-id: https://develop.svn.wordpress.org/trunk@29838 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-05 18:39:12 +00:00
Sergey Biryukov 4ba75673d8 Update @param docs for wp_get_attachment_image().
see #29869.

git-svn-id: https://develop.svn.wordpress.org/trunk@29837 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-05 17:51:42 +00:00
Sergey Biryukov a21e5041dd Pass the requested size to 'wp_get_attachment_image_attributes' filter.
props mattheu.
fixes #29869.

git-svn-id: https://develop.svn.wordpress.org/trunk@29836 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-05 17:49:32 +00:00
Andrew Ozz d2c8c72e7f Pin the admin menu on scrolling similarly to how the side metaboxes are pinned on the Edit Post screen, first run. See #29806.
git-svn-id: https://develop.svn.wordpress.org/trunk@29835 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-05 03:08:11 +00:00
Sergey Biryukov 1a7c4efa13 Fix setting default quality in WP_Image_Editor.
props markoheijnen.
fixes #29856 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29834 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-04 13:11:38 +00:00
Scott Taylor 07a38ff81a Allow PSDs (Photoshop documents) to be uploaded.
Props michalzuber, ccprice.
Fixes #28805.


git-svn-id: https://develop.svn.wordpress.org/trunk@29833 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 19:51:56 +00:00
Scott Taylor 11c914bca9 In the admin, give media list table icons `auto` for `width` and `height`. In the post thumbnail metabox, apply `width: auto`.
If someone turns on support SVG files, this will allow them to show up.

Props arippberger for an initial patch.
Fixes #26256.


git-svn-id: https://develop.svn.wordpress.org/trunk@29832 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 19:07:17 +00:00
Scott Taylor a6f6556fca For `attachment-compat` fields, show a spinner while `wp.media.model.Attachment.saveCompat()` is firing.
Fixes #27028.


git-svn-id: https://develop.svn.wordpress.org/trunk@29831 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 18:42:13 +00:00
Boone Gorges ecac4d4a94 Improve unit test coverage for wp_insert_term().
See #5809, #22023.

git-svn-id: https://develop.svn.wordpress.org/trunk@29830 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 13:30:22 +00:00
Dominik Schilling (ocean90) f7a4e22bdb Plugin search: Wrap results in a form to fix pagination's `paged` input field.
props jesin, ocean90.
see #18724, for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29829 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 13:07:18 +00:00
Sergey Biryukov 7d2f7c6ceb Switch line-height added in [29790] to a unitless value.
props janhenckens.
fixes #29451.

git-svn-id: https://develop.svn.wordpress.org/trunk@29828 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 09:41:24 +00:00
Sergey Biryukov b16654400f Twenty Fourteen: Move custom description for background color and image from sections to controls in the customizer.
props jb510.
fixes #29490.

git-svn-id: https://develop.svn.wordpress.org/trunk@29827 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 08:42:39 +00:00
Sergey Biryukov 3d0f4d9656 Use correct links for filtering plugin reviews.
props OriginalEXE.
fixes #29754.

git-svn-id: https://develop.svn.wordpress.org/trunk@29826 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 08:08:27 +00:00
Sergey Biryukov 990f01f81f Avoid a PHP notice in list_plugin_updates() if plugins_api() returned a WP_Error object.
fixes #29583.

git-svn-id: https://develop.svn.wordpress.org/trunk@29825 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 00:01:51 +00:00
Sergey Biryukov 569a80e488 Add unit tests for get_blog_details().
props jeremyfelt.
fixes #29845.

git-svn-id: https://develop.svn.wordpress.org/trunk@29824 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 21:47:25 +00:00
Sergey Biryukov dc62eeff36 Make link construction in get_comment_reply_link() and get_post_reply_link() more readable.
see #16433.

git-svn-id: https://develop.svn.wordpress.org/trunk@29823 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 20:44:34 +00:00
Sergey Biryukov 07cf5c5c76 Add an aria-label attribute with commenter's name to get_comment_reply_link().
props joedolson, merty, andrewryno.
fixes #16433.

git-svn-id: https://develop.svn.wordpress.org/trunk@29822 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 20:40:35 +00:00
Sergey Biryukov 32dbb27701 * Use correct context for 'Name' and 'Parent' strings on taxonomy screens.
* Remove unnecessary context for 'Slug' and 'Description' strings.

props andg.
fixes #29824.

git-svn-id: https://develop.svn.wordpress.org/trunk@29821 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 20:00:11 +00:00
Sergey Biryukov c231361790 Use a more consistent markup on taxonomy and user screens.
props paulwilde.
fixes #29842.

git-svn-id: https://develop.svn.wordpress.org/trunk@29820 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 19:39:14 +00:00
Boone Gorges 6ffb0fcafb Always sanitize user_nicename in wp_insert_user().
Previously, a 'user_nicename' parameter passed into the function was
unsanitized. This could result in a mismatch between the sanitized nicename
generated automatically at user creation, resulting in broken author archive
permalinks.

Props joemcgill.

Fixes #29696.

git-svn-id: https://develop.svn.wordpress.org/trunk@29819 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 18:53:24 +00:00