Commit Graph

27523 Commits

Author SHA1 Message Date
Helen Hou-Sandi 63205d3a43 Media Grid: Show upload errors above the grid rather than as a popup.
props pento, stephdau, helen. fixes #29141.


git-svn-id: https://develop.svn.wordpress.org/trunk@29612 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 04:17:18 +00:00
Andrew Nacin d49f1405fd Install: Remove reference to readme and add a hyphen missing since 2007.
props ocean90.
fixes #29290.


git-svn-id: https://develop.svn.wordpress.org/trunk@29611 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 04:04:12 +00:00
Helen Hou-Sandi bcba1996fe Customizer panels: use a single back button for all panels.
This also ensures the back button is visible on iOS devices.

props celloexpressions.
fixes #29135.


git-svn-id: https://develop.svn.wordpress.org/trunk@29610 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 23:04:43 +00:00
Andrew Ozz f1fe507032 Media modal: fix the progress bar in the attachment thumbnail. Props gcorne, fixes #29367
git-svn-id: https://develop.svn.wordpress.org/trunk@29609 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 22:44:32 +00:00
Helen Hou-Sandi 7b6aabf795 Better visual focus syling in customizer, theme preview, and attachment details modals.
props celloexpressions.
fixes #29147.


git-svn-id: https://develop.svn.wordpress.org/trunk@29608 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 21:57:55 +00:00
Helen Hou-Sandi eb08fac4f7 Media:
* Make attachment focus styles more obvious, particularly for already selected items.
* Fix styling for the selection set attachments.
* Remove some CSS cruft.

fixes #28822.


git-svn-id: https://develop.svn.wordpress.org/trunk@29607 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 21:25:13 +00:00
Andrew Ozz 649607b139 TinyMCE wpView: exclude more non-printable keyCodes in isSpecialKey(), fixes #29115
git-svn-id: https://develop.svn.wordpress.org/trunk@29606 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 20:40:21 +00:00
Helen Hou-Sandi 0566702a64 Plugin details:
Prevent plugins with long names from looking bad and breaking layouts.

props stephdau. fixes #28883.


git-svn-id: https://develop.svn.wordpress.org/trunk@29605 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 20:19:56 +00:00
Helen Hou-Sandi 330ed83605 Correct cascade oversights in form CSS. fixes #28262.
git-svn-id: https://develop.svn.wordpress.org/trunk@29604 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 19:52:24 +00:00
Andrew Ozz 2f81be2bbc Media modal: when inserting content, prefer the editor id passed while opening the modal. wpActiveEditor can change in the background. (Includes some precommit prefixed selectors.) Fixes #28173
git-svn-id: https://develop.svn.wordpress.org/trunk@29603 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 19:36:12 +00:00
Scott Taylor 15eb91dfdb Media: cleanup recent changes to `media.view.FocusManager`.
* Adjusts the focus method to target the menu for the current modal
* Refactor the FocusManager so that the method names and the functionality matches more closely with how it currently works. The changes in 4.0 to the FocusManager change the purpose of the focus manager entirely — instead of being a way to save and restore focus state, the new FocusManager is about constraining keyboard navigation via the tab key to inside the modal. 

Props gcorne.
See #23560.


git-svn-id: https://develop.svn.wordpress.org/trunk@29602 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 18:22:34 +00:00
Scott Taylor 361d664db5 Media: when activating a mode after [29056], don't trigger the `{mode}:activate` event twice in a row.
See #29366.


git-svn-id: https://develop.svn.wordpress.org/trunk@29601 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 18:06:06 +00:00
Scott Taylor 9a52936277 Media Grid: exit selection mode when Esc is pressed.
Fixes #29366.


git-svn-id: https://develop.svn.wordpress.org/trunk@29600 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 17:44:28 +00:00
Sergey Biryukov feb1b12df1 Send nocache_headers() on installation screens and when redirecting to them.
fixes #29248.

git-svn-id: https://develop.svn.wordpress.org/trunk@29599 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 17:39:46 +00:00
Helen Hou-Sandi 87bf7ef30c Media Grid: Move CSS into an admin-only file.
`media-views.css` can be loaded on the front, which does not need this extra CSS.

fixes #29340.


git-svn-id: https://develop.svn.wordpress.org/trunk@29598 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 16:50:36 +00:00
Helen Hou-Sandi 9252fbec58 Only show one search form for the plugin installer.
The field dropdown now appears in the filter bar only when doing a search.

see #28785.


git-svn-id: https://develop.svn.wordpress.org/trunk@29597 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 16:02:43 +00:00
Helen Hou-Sandi f187cf1dec Make filter bar CSS less verbose and redundant.
Also removes an unused handler in the theme feature filter.

see #28794.


git-svn-id: https://develop.svn.wordpress.org/trunk@29596 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 15:57:34 +00:00
Andrew Nacin e8d8b21cec Plugins: Only show details link if user can install plugins.
fixes #17902.


git-svn-id: https://develop.svn.wordpress.org/trunk@29595 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 15:27:45 +00:00
Sergey Biryukov fae5c2de6f Install Plugins: Don't wp_die() if API can't be reached.
props johnbillion.
fixes #29361.

git-svn-id: https://develop.svn.wordpress.org/trunk@29594 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 15:01:50 +00:00
Andrew Ozz fa1b34ac78 Editor expand: add border to the Text editor resize helper, helps calculating the height in some cases. Fixes #29225
git-svn-id: https://develop.svn.wordpress.org/trunk@29593 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 03:42:46 +00:00
azaozz 78b5ccd55c Editor scrolling: fix window height when switching Visual to Text and the editor is shorter. Props mackensen, fixes #29226.
git-svn-id: https://develop.svn.wordpress.org/trunk@29592 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 23:11:03 +00:00
Andrew Nacin 4820f78f66 Plugin details: Adjust plugin title when it does not have a banner.
Smaller, bold, and Open Sans, like other modals. Only use Helvetica Neue when the plugin has a banner.

see [29040], see #27440.


git-svn-id: https://develop.svn.wordpress.org/trunk@29591 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 20:47:50 +00:00
Andrew Nacin c0eabc9901 Plugin details: Correctly calculate the height of the right column for plugins without banners.
Comment these magic numbers.

see #27440, [29474].


git-svn-id: https://develop.svn.wordpress.org/trunk@29590 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 20:44:27 +00:00
Helen Hou-Sandi b459eb034e Version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@29589 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 18:44:00 +00:00
Andrew Nacin 50706e736d Screen: Move editor scrolling screen option to the proper place.
see [29336], see #28328.


git-svn-id: https://develop.svn.wordpress.org/trunk@29588 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 17:56:25 +00:00
Andrew Nacin 42307f8194 Equal margins for plugin icons. see #28785.
git-svn-id: https://develop.svn.wordpress.org/trunk@29587 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 17:55:05 +00:00
Andrew Nacin 81b52e71e4 Plugin install: Add icons to compatible/incompatible. see #29313.
git-svn-id: https://develop.svn.wordpress.org/trunk@29586 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 17:25:35 +00:00
Scott Taylor 0ccd68f239 Media Grid: Don't make checkboxes tabbable when in bulk select media grid mode, fixes tabbing in bulk select mode.
Props adamsilverstein.
See #28822.


git-svn-id: https://develop.svn.wordpress.org/trunk@29585 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 16:54:35 +00:00
Scott Taylor 506bf18b7e Media Grid: restore focus to the selected item when shift-tab away from the attachment details sidebar.
Fixes #29303.


git-svn-id: https://develop.svn.wordpress.org/trunk@29584 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 16:42:14 +00:00
Dominik Schilling (ocean90) e4717c19c1 Apply accessibility improvements to Plugins screen too.
props SergeyBiryukov.
fixes #29342.

git-svn-id: https://develop.svn.wordpress.org/trunk@29583 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 16:21:20 +00:00
Helen Hou-Sandi 35ae0bc5a4 Media: Only fire keyboard events for the Attachments view once.
Firing them twice was breaking arrow key navigation in media attachment grids.

props gcorne.
fixes #29304.


git-svn-id: https://develop.svn.wordpress.org/trunk@29582 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 16:17:01 +00:00
Dominik Schilling (ocean90) 19a0a5b64f Plugin compatibility is based on your version of WordPress, not your install.
fixes #29313.

git-svn-id: https://develop.svn.wordpress.org/trunk@29581 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 16:13:54 +00:00
Dominik Schilling (ocean90) 7770a90d74 Add missing array keys for connection type in `request_filesystem_credentials()`.
see [28456].
fixes #29347.


git-svn-id: https://develop.svn.wordpress.org/trunk@29580 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 16:04:01 +00:00
Andrew Ozz 46457ead23 Editor scrolling:
- Pin the TinyMCE statusbar (elements path) to the bottom.
- Add support for pinning the menu when present.
- Add borders from CSS.
- Optimize getting most elements outerHeight.
Part props avryl, fixes #29293, see #28328.

git-svn-id: https://develop.svn.wordpress.org/trunk@29579 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 05:10:52 +00:00
Drew Jaynes (DrewAPicture) 7c8086a9a6 Fix a couple of misplaced/misordered argument descriptions in the `WP_Query` arguments hash notation.
See #25367.


git-svn-id: https://develop.svn.wordpress.org/trunk@29578 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-23 19:36:00 +00:00
Andrew Ozz 76020bd447 TinyMCE wpView: fix showing errors for non-embeddable URLs, no-ssl or no items. Props avryl, fixes #29114, see #29268.
git-svn-id: https://develop.svn.wordpress.org/trunk@29577 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-22 18:54:08 +00:00
Andrew Ozz c83a9ca2c9 TinyMCE: update to 4.1.4-20140822. Changes:
- Fixed bug where sometimes the resize rectangles wouldn't properly render on images on WebKit/Blink. 9a2d01cc14
- Fixed nodeChanged selection issue where the image selection wouldn't be removed if you clicked right after/before it. dd729c67e0
- Fixed bug in list plugin where delete/backspace would merge empty LI elements in lists incorrectly. caadfb05dd
See #29310

git-svn-id: https://develop.svn.wordpress.org/trunk@29576 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-22 17:43:39 +00:00
Sergey Biryukov e6a5a8a36b Fix unintended box-shadow in the opposite corner of thickbox Close icon.
props ocean90.
fixes #29311.

git-svn-id: https://develop.svn.wordpress.org/trunk@29575 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-22 16:03:29 +00:00
Sergey Biryukov 91f11ca349 Plugin compatibility warnings should be red, not green.
props avryl.
fixes #29309.

git-svn-id: https://develop.svn.wordpress.org/trunk@29574 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-22 03:56:51 +00:00
Andrew Nacin d395f64117 Export: Add wxr_export_skip_commentmeta filter to match the _postmeta filter.
props cfinke.
fixes #28745.


git-svn-id: https://develop.svn.wordpress.org/trunk@29573 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-22 01:47:59 +00:00
Andrew Ozz 0f83364811 Autosave: prevent setting multiple stale `wp-saving-post-*` cookies when the browser disregards "session cookies" expiration on quit:
- Add expiration time of 24 hours for these cookies.
- Rename them to `wp-saving-post` (no post_id) so there is never more than one cookie per domain.
Fixes #29294.

git-svn-id: https://develop.svn.wordpress.org/trunk@29572 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-22 00:24:56 +00:00
Andrew Ozz 362e24eca7 TinyMCE wpView: prevent errors when pasting multiple non-embeddable URLs, props avryl, fixes #29268
git-svn-id: https://develop.svn.wordpress.org/trunk@29571 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-22 00:13:07 +00:00
Andrew Ozz 208645191d TinyMCE: update to 4.1.4. Changelog: http://www.tinymce.com/develop/changelog/?type=tinymce. Fixes #29310
git-svn-id: https://develop.svn.wordpress.org/trunk@29570 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-21 23:52:28 +00:00
Andrew Nacin 7a504df72a Introduce plugin icons in the installer.
See http://wp.me/p2AvED-2P8 for the announcement and how to implement these.

props tellyworth.
see #28785.


git-svn-id: https://develop.svn.wordpress.org/trunk@29569 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-21 19:10:59 +00:00
Scott Taylor f7c295be3e Media Grid: after [29566], account for Trash and Delete.
See #28842.


git-svn-id: https://develop.svn.wordpress.org/trunk@29568 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-21 04:41:01 +00:00
Scott Taylor f46ef728b5 Media Grid: don't hide the uploader progress bar for individual items.
See [29527], #29037.


git-svn-id: https://develop.svn.wordpress.org/trunk@29567 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-21 04:37:01 +00:00
Scott Taylor 87366e71ca Media Grid: after completing a Bulk action, switch from `select` to `edit` mode.
Fixes #28842.


git-svn-id: https://develop.svn.wordpress.org/trunk@29566 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-21 04:19:40 +00:00
Scott Taylor 4a31c2f74a Media Grid: don't auto-select attachments upon upload.
Props ocean90.
See #28842.


git-svn-id: https://develop.svn.wordpress.org/trunk@29565 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-21 03:53:13 +00:00
Scott Taylor 097147c9b6 After [29543], the iframe sandboxes for media need to load Open Sans. Playlists look aggressively bad without it. Adds font styles for the body.
See #29048.


git-svn-id: https://develop.svn.wordpress.org/trunk@29564 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-21 03:35:11 +00:00
Sergey Biryukov 2b3bf48338 Fix strict notices in makepot.
props jdgrimes.
fixes #29254.

git-svn-id: https://develop.svn.wordpress.org/trunk@29563 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-21 02:53:16 +00:00