Commit Graph

39601 Commits

Author SHA1 Message Date
Gary Pendergast
8eca6fd949 Site Health: Remove animated ellipsis from the status loading indicator.
This animation wasn't particularly reliable across browsers.

Props Clorith, afercia.
Fixes #46684.



git-svn-id: https://develop.svn.wordpress.org/trunk@45145 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:28:27 +00:00
Gary Pendergast
cfebdd3752 Widgets: Add rel="noopener noreferrer" to links with target="_blank" in the Image widget.
Props audrasjb, welcher, afercia.
Fixes #43280.



git-svn-id: https://develop.svn.wordpress.org/trunk@45144 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:22:14 +00:00
Gary Pendergast
5dfdc9b9c4 Widgets: Add rel="noopener noreferrer" to links with target="_blank" in the Text and HTML widgets.
Props audrasjb, birgire, mukesh27.
Fixes #46421.



git-svn-id: https://develop.svn.wordpress.org/trunk@45143 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:17:35 +00:00
Gary Pendergast
0f75356246 Privacy: Remove the privacy changes bubble.
This notification was a little too intrustive, and suffered from being difficult to dismiss.

Props garrett-eclipse, xkon, ianbelanger.
Fixes #46819.



git-svn-id: https://develop.svn.wordpress.org/trunk@45142 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:11:36 +00:00
Gary Pendergast
466a7443a6 Menus: Add rel="noopener" to target="_blank" links by default in menus.
This expands upon `rel="noopener"` being previously added to links in the content.

Props audrasjb, welcher.
Fixes #43290.



git-svn-id: https://develop.svn.wordpress.org/trunk@45141 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:05:22 +00:00
Gary Pendergast
8efcc32fde Help: Update support forum links.
There are a lot of places in Core that link to https://wordpress.org/support/ for the support forums, but that's now the URL for HelpHub. The new forums link is https://wordpress.org/support/forums/.

Props jitendrabanjara1991, dilipbheda, mukesh27, ianbelanger.
Fixes #46790.



git-svn-id: https://develop.svn.wordpress.org/trunk@45140 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 22:58:49 +00:00
Gary Pendergast
edd6a1f129 Blocks: Allow for nested the_content calls within do_blocks().
When `do_blocks()` is run, it sets up some special handling of the `wpautop` filter, as we don't want `wpautop` to run on block content, but we do want it to be available for subsequent runs of `the_content`, which may be happening on non-block content.

As we set this up before rendering dynamic blocks, however, a dynamic block choosing to run `the_content` will cause unintentially structural deficiences in this particular recursive block tower.

Moving this handling to after dynamic blocks are rendered makes our tower lean a little less.

Props aldavigdis, pento.
Fixes #45495.



git-svn-id: https://develop.svn.wordpress.org/trunk@45139 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 06:53:14 +00:00
Gary Pendergast
c9bb62507f Block Editor: Update packages to bring a selection of bugfixes in.
Props iseulde, kjellr, aduth, 0mirka00, mcsf, nosolosw, gziolo, jasmussen, talldanwp, notnownikki, swissspidy, jorgefilipecosta, noisysocks.
See https://github.com/WordPress/gutenberg/pull/14796.
Fixes #46801.



git-svn-id: https://develop.svn.wordpress.org/trunk@45138 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 06:36:33 +00:00
Gary Pendergast
f1bef8668b Text Changes: Tweak the wording of email notification subjects.
This change brings more coherence between the subject lines of the various emails WordPress will send.

Props ramiy, pento.
Fixes #37940.


git-svn-id: https://develop.svn.wordpress.org/trunk@45137 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 06:16:41 +00:00
Gary Pendergast
95948eeed4 Post Formats: Remove the post format icons from the post list table.
Props mukesh27, melchoyce, karmatosed, afercia, mapk.
Fixes #46591.


git-svn-id: https://develop.svn.wordpress.org/trunk@45136 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 06:03:58 +00:00
Gary Pendergast
3652d05fcf HTTP: Add support for the host-only flag to Wp_Http_Cookie.
Props soulseekah.
Fixes #43231.


git-svn-id: https://develop.svn.wordpress.org/trunk@45135 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 05:31:35 +00:00
Gary Pendergast
11e97aae1e Emoji: Update Twemoji to version 12.0.0.
Props pento, superpoincare.
Fixes #46404, #46805.


git-svn-id: https://develop.svn.wordpress.org/trunk@45134 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 05:21:49 +00:00
Gary Pendergast
65e057daa2 Canonical: Ensure redirect query keys are URL encoded.
This prevents an infinite redirect loop when a request containing URL-encoded characters triggers `is_404()`.

Props soulseekah, wrwrwr0.
Fixes #43745.


git-svn-id: https://develop.svn.wordpress.org/trunk@45133 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 01:09:01 +00:00
Sergey Biryukov
639f038dae Twenty Nineteen: Fix inconsistent tab/space indentation in style files.
Props iamdmitrymayorov, mukesh27.
Fixes #46821.

git-svn-id: https://develop.svn.wordpress.org/trunk@45132 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 06:17:26 +00:00
Sergey Biryukov
965e7fa46e CSS Coding Standards: Use unitless values for line-height in wp-admin/css/color-picker.css.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46492. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45131 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:53:37 +00:00
Sergey Biryukov
6ba1388522 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/about.css.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46495. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45130 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:50:18 +00:00
Sergey Biryukov
1b69643969 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/customize-nav-menus.css.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46495. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45129 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:48:05 +00:00
Sergey Biryukov
8c6239c27b CSS Coding Standards: Use unitless values for line-height in wp-admin/css/site-health.css.
Props mukesh27, ianbelanger, pbiron, afercia.
Fixes #46760. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45128 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:43:12 +00:00
Sergey Biryukov
66e0c55818 Docs: Fix typo in a comment in editor/dfw.js.
Props garrett-eclipse, mattnyeus.
Fixes #46485.

git-svn-id: https://develop.svn.wordpress.org/trunk@45127 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:39:00 +00:00
Sergey Biryukov
60e5087b36 Bundled Themes: Link to an updated documentation on post thumbnails on developer.wordpress.org, instead of Codex.
Props samanehmirrajabi.
Fixes #46823.

git-svn-id: https://develop.svn.wordpress.org/trunk@45126 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:22:17 +00:00
John Blackbourn
8cd187c23a Bootstrap/Load: Ignore wp-content/fatal-error-handler.php and wp-content/php-error.php from version control.
See #44458


git-svn-id: https://develop.svn.wordpress.org/trunk@45125 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 18:42:26 +00:00
Sergey Biryukov
028e4098c7 Twenty Twelve: Correct linear-gradient direction argument syntax.
In CSS, the `linear-gradient` function requires that the direction value explicitly use `to` instead of an implicit `from`.

Props: ianbelanger, joyously, man4toman.
Fixes #46786.

git-svn-id: https://develop.svn.wordpress.org/trunk@45124 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 16:16:50 +00:00
Sergey Biryukov
bd25bc4473 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/nav-menus.css.
Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46516. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45123 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 16:09:42 +00:00
Sergey Biryukov
0f534cfe11 PHPCS: Fix WPCS violation in [45119].
See #46809.

git-svn-id: https://develop.svn.wordpress.org/trunk@45122 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 16:01:36 +00:00
Sergey Biryukov
c8a29d2789 Site Health: Update recommendation labels to highlight Performance instead of Security when using a supported and actively maintained version of WordPress, PHP, or MySQL.
Props Clorith, earnjam.
Fixes #46789.

git-svn-id: https://develop.svn.wordpress.org/trunk@45121 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 15:59:29 +00:00
Sergey Biryukov
e0041a5794 Site Health: Use a consistent heading and description when referring to Info and Status pages.
Props chetan200891, afercia.
Fixes #46728.

git-svn-id: https://develop.svn.wordpress.org/trunk@45120 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 15:41:41 +00:00
Sergey Biryukov
17728c5215 Site Health: Restore backticks in "Copy to clipboard" functionality, accidentally removed in [45044].
The backticks ensure that the data is formatted accordingly on pasting whenever possible.

Props Clorith.
Fixes #46809.

git-svn-id: https://develop.svn.wordpress.org/trunk@45119 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 15:35:44 +00:00
Sergey Biryukov
d72a0092d5 Site Health: Display a correct error message for a failing request in wp_version_check() test.
Props Clorith, axaak.
Fixes #46814.

git-svn-id: https://develop.svn.wordpress.org/trunk@45118 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 15:27:33 +00:00
Felix Arntz
a511415d0a Administration: Improve user experience and clarify when in recovery mode.
This changeset introduces several changes around usability when recovery mode is active:

* Display a notice in the admin clarifying that the user is in recovery mode.
* Use a highlight color for the admin bar link to exit recovery mode.
* Exit recovery mode automatically when logging out.
* Include a recovery mode indicator in the title tag.

Props aandrewdixon, azaozz, dhanukanuwan, flixos90, henrywright, karmatosed, mapk, melchoyce, spacedmonkey, TimothyBlynJacobs, tinkerbelly.
See #46608.


git-svn-id: https://develop.svn.wordpress.org/trunk@45117 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 16:59:34 +00:00
Felix Arntz
075a85c05e Bootstrap/Load: Do not redefine constants because tests don't like it.
See #46045.


git-svn-id: https://develop.svn.wordpress.org/trunk@45116 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 15:52:39 +00:00
Felix Arntz
dca58d725e Bootstrap/Load: Remove extension from the list of paused extensions when it is deactivated.
With this change, fatal errors recorded before a plugin was deactivated or a theme was switched away from do not persist. This ensures that re-enabling it re-checks for fatal errors correctly.

Props aandrewdixon, dhanukanuwan, henrywright.
Fixes #46812.


git-svn-id: https://develop.svn.wordpress.org/trunk@45115 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 15:32:31 +00:00
Felix Arntz
7f6adbb345 Bootstrap/Load: Ensure WP_Fatal_Error_Handler does not conflict with existing mechanisms treating fatal errors.
Prior to this change, resuming or activating a plugin or theme that is still broken would result in a redirect loop if in recovery mode. If outside recovery mode, it would cause the error template to be displayed.

Furthermore this applies to breaking a plugin or theme when editing from the backend.

Props aandrewdixon, azaozz, dhanukanuwan, henrywright, ocean90, ohiosierra, PandelisZ, xkon.
Fixes #46045, #46751.


git-svn-id: https://develop.svn.wordpress.org/trunk@45114 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 15:19:50 +00:00
Pascal Birchler
99a0145ba1 Site Health: Remove unused $wp_config_path variable.
Discovered and fixed during WordCamp London 2019 contributor day.

Props m_uysl.
Fixes #46808.


git-svn-id: https://develop.svn.wordpress.org/trunk@45113 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 11:08:30 +00:00
Alex Shiels
45771f9f11 Upgrade/Install: Add more context in signature verify failures.
This includes version numbers and signature counts in error reports, to help diagnose isolated failures that have no apparent cause.

Props dd32.
See #39309.


git-svn-id: https://develop.svn.wordpress.org/trunk@45112 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 05:19:15 +00:00
Andrew Ozz
9945849317 Site health: fix usage of max_execution_time. When PHP is run from the cli the default is 0.
Fixes #46645.

git-svn-id: https://develop.svn.wordpress.org/trunk@45111 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-04 21:53:45 +00:00
Jonathan Desrosiers
af60a3c2bf Site Health: Ensure the user locale is listed in debug information.
This change switches to using `get_user_locale()` when adding the language to the Site Health debug information to ensure the user’s locale preference is reflected.

Also, `function_exists()` checks for `switch_to_locale()` and `restore_previous_locale()` were required in the plugin to support older versions of WordPress, but they are not required in core/

Props: Clorith, desrosj.
Fixes #46694.

git-svn-id: https://develop.svn.wordpress.org/trunk@45110 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-04 21:23:29 +00:00
Jonathan Desrosiers
0afc9b5119 Twenty Eleven: Correct linear-gradient direction argument syntax.
In CSS, the `linear-gradient` function requires that the direction value explicitly use `to` instead of an implicit `from`.

Props: ianbelanger, Malae, man4toman.
Fixes #46770.

git-svn-id: https://develop.svn.wordpress.org/trunk@45109 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-04 18:25:21 +00:00
Sergey Biryukov
a0ca5afd89 Site Health: Use wp_get_upload_dir() instead of wp_upload_dir(), remove duplicate call.
Props m_uysl.
Fixes #46729.

git-svn-id: https://develop.svn.wordpress.org/trunk@45108 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-03 11:19:53 +00:00
Sergey Biryukov
681edf04bc Site Health: Use correct property for database-related messages.
Props mukesh27, birgire.
Fixes #46783.

git-svn-id: https://develop.svn.wordpress.org/trunk@45107 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-03 11:00:06 +00:00
Sergey Biryukov
c8913b375e PHPCS: Fix WPCS violations in [45104].
See #46645.

git-svn-id: https://develop.svn.wordpress.org/trunk@45106 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-03 02:13:31 +00:00
Sergey Biryukov
fa0ad447c8 Site Health: Use a consistent verbiage for the suggestion to remove inactive plugins and themes.
Props garrett-eclipse, marybaum, Clorith.
Fixes #46735.

git-svn-id: https://develop.svn.wordpress.org/trunk@45105 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-03 02:00:56 +00:00
Andrew Ozz
d5d4979921 Site health:
- Prevent fatal errors from timeouts on the Tools => Site Health => Info tab.
- Use the `get_dirsize()` and `recurse_dirsize()` functions to calculate directory sizes. The results are cached.
- Introduce "timeout protection" in `recurse_dirsize()`.

Props pento, Clorith, xkon, afercia, jeremyfelt, azaozz.
Fixes #46645.

git-svn-id: https://develop.svn.wordpress.org/trunk@45104 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 23:32:31 +00:00
Sergey Biryukov
f6f02a327f Docs: Remove an empty line between @param and @return in the tests added in [45101], per documentation coding standards.
See #45029.

git-svn-id: https://develop.svn.wordpress.org/trunk@45103 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 22:21:19 +00:00
Sergey Biryukov
3b7028104b Site Health: Use an established pattern for numbered placeholders in translator comments in WP_Debug_Data.
See #46683.

git-svn-id: https://develop.svn.wordpress.org/trunk@45102 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 22:17:18 +00:00
Sergey Biryukov
ffbc0e3b4e Widgets: Make sure changes to media widgets' instance schema via widget_{$this->id_base}_instance_schema filter are not overridden by subclasses.
Add unit tests missed in [45100].

Props Toro_Unit, birgire.
See #45029.

git-svn-id: https://develop.svn.wordpress.org/trunk@45101 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 22:14:19 +00:00
Sergey Biryukov
f4e57f92e4 Widgets: Make sure changes to media widgets' instance schema via widget_{$this->id_base}_instance_schema filter are not overridden by subclasses.
Previously, `WP_Widget_Media_Audio`, `WP_Widget_Media_Image`, and `WP_Widget_Media_Video` used to override the changes due to reversed arguments in `array_merge()` call.

Props Toro_Unit, birgire.
Fixes #45029.

git-svn-id: https://develop.svn.wordpress.org/trunk@45100 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 22:12:11 +00:00
Sergey Biryukov
b3a625fdf1 Site Health: i18n audit, take 1.
* Split plural strings with multiple sentences to avoid duplicating translations.
* Decouple strings where the singular and plural form are not just the same string with different numbers, but essentially two different strings.
* Use an established pattern for numbered placeholders in translator comments.
* Replace constants in translatable strings with placeholders, mark them as code.
* Make sure sentences are translated as a whole, not as separate string parts.
* Remove unnecessary context and escaping.

Props ocean90, SergeyBiryukov.
See #46683.

git-svn-id: https://develop.svn.wordpress.org/trunk@45099 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 21:31:43 +00:00
Sergey Biryukov
e4a0f2dcab Docs: Fix typo in a comment in unzip_file().
Props mukesh27.
Fixes #46766.

git-svn-id: https://develop.svn.wordpress.org/trunk@45098 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 13:33:47 +00:00
Jonathan Desrosiers
91ac8aeefc Administration: Remove unnecessary transition-delay values from Dashicons.
A unitless `0` value for a `<time>` CSS data type was reintroduced in [45040]. This is allowed for `<length>` data types, but is invalid for `<time>`.

See #43195.
Fixes #46774.

git-svn-id: https://develop.svn.wordpress.org/trunk@45097 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 13:18:35 +00:00
Sergey Biryukov
03135696bd Twenty Fifteen: Fix typo in a comment for print styles.
Props mukesh27.
Fixes #46767.

git-svn-id: https://develop.svn.wordpress.org/trunk@45096 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 13:06:40 +00:00