Commit Graph

42788 Commits

Author SHA1 Message Date
Jonathan Desrosiers
ed2b1a43e0 Build/Test Tools: Avoid logging the same debug info twice in the PHPUnit workflow.
Also includes some inline documentation fixes for workflow files.

See #50401.

git-svn-id: https://develop.svn.wordpress.org/trunk@49371 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 01:46:44 +00:00
Sergey Biryukov
6b2f57da36 REST API: Remove accidentally duplicated key in test fixtures.
Follow-up to [49334], [49368].

See #51638.

git-svn-id: https://develop.svn.wordpress.org/trunk@49370 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 01:32:52 +00:00
Jonathan Desrosiers
886a9ddaa4 Build/Test Tools: Use install-changed to install NPM dependencies in GitHub Action workflows.
The `install-changed` package records a hash of the `package.json` file locally in a text file and only runs `npm install` when there are changes to account for. 

This builds on [47497], which only hashes the `package.json` file after a Grunt task is called. By using `npx install-changed` within the workflow files, the package is hashed before the first Grunt task is run.

Props ocean90.
See #50401, #49594.

git-svn-id: https://develop.svn.wordpress.org/trunk@49369 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 01:20:42 +00:00
Sergey Biryukov
df716454a3 REST API: Regenerate test fixtures after [49334].
Props garrett-eclipse.
Fixes #51638.

git-svn-id: https://develop.svn.wordpress.org/trunk@49368 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 01:00:12 +00:00
Sergey Biryukov
cc5e183da9 Themes: Clarify the _doing_it_wrong() message for post formats in add_theme_support().
Follow-up to [49344], [49354], [49365].

See #51390.

git-svn-id: https://develop.svn.wordpress.org/trunk@49367 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 00:07:01 +00:00
Sergey Biryukov
75bb139087 Tests: Correct post formats registration in WP_REST_Search_Controller tests.
When declaring theme support for the `post-formats` feature, an array of supported post formats needs to be specified.

Follow-up to [49344], [49354].

Props garrett-eclipse.
Fixes #51390.

git-svn-id: https://develop.svn.wordpress.org/trunk@49365 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-29 00:02:00 +00:00
Jonathan Desrosiers
c812f63015 Build/Test Tools: Allow the desired version of PHPUnit to be passed to the local Docker environment.
This reintroduces [49358] with a modification to the `.travis.yml` file to avoid an issue with `dotenv-expand` being unable to expand variables into `process.env` only on Travis.

The `LOCAL_PHPUNIT` environment variabl allows the desired version of PHPUnit to be specified when running the PHP tests within the local Docker environment.

Because support for newer versions of PHPUnit is not backported, some versions of PHP need the ability to run multiple versions of PHPUnit for different branches. This adds the flexibility needed to use the Docker environment within those older branches to run the PHP tests.

Props johnbillion, SergeyBiryukov.
See #50042.

git-svn-id: https://develop.svn.wordpress.org/trunk@49362 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-28 23:15:07 +00:00
Jonathan Desrosiers
26278f14bf Build/Test Tools: Revert [49358] to investigate failures.
Unprops desrosj.
See #50042.

git-svn-id: https://develop.svn.wordpress.org/trunk@49360 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-28 19:42:29 +00:00
Jake Spurlock
ebf85d6d3e Embeds: Remove Facebook and Instagram as an oEmbed Source
Facebook has depracated all non-authenticated endpoints for Facebook and Instagram. 

See: https://developers.facebook.com/docs/plugins/oembed-legacy
See also: https://make.wordpress.org/core/2020/09/22/facebook-and-instagram-embeds-to-be-deprecated-october-24th/

With this change, endpoints are being removed. If a site is dependent on this feature, they need to pass either an app or client token. There are a few plugins that add this functionality.

Fixes #50861.
Props johnbillion, joyously, mkaz, dimadin, ayeshrajans, davisshaver, paaljoachim, Clorith, bridgetwillard, jb510, sippis, Clorith, TimothyBlynJacobs, desrosj, smub, audrasjb, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/trunk@49359 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-28 19:09:42 +00:00
Jonathan Desrosiers
a3bd11826a Build/Test Tools: Allow the desired version of PHPUnit to be passed to the local Docker environment.
This change introduces the `LOCAL_PHPUNIT` environment variable that allows the desired version of PHPUnit to be specified when running the PHP tests within the local Docker environment.

Because support for newer versions of PHPUnit is not backported, some versions of PHP need the ability to run multiple versions of PHPUnit for different branches. This adds the flexibility needed to use the Docker environment within those older branches to run the PHP tests.

Props johnbillion.
Fixes #50042.

git-svn-id: https://develop.svn.wordpress.org/trunk@49358 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-28 19:01:19 +00:00
John Blackbourn
72a37d46ac Cron API: Improve the inline documentation for the args passed to the cron event scheduling functions.
Props chadreitsma, peterwilsoncc

Fixes #51605


git-svn-id: https://develop.svn.wordpress.org/trunk@49357 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-28 18:35:14 +00:00
Sergey Biryukov
82227c9fa6 General: Ensure that filtered arguments in get_search_form() contain all required default values.
Props kellybleck, davidbaumwald, whyisjake, SergeyBiryukov.
Fixes #51645.

git-svn-id: https://develop.svn.wordpress.org/trunk@49355 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-28 16:55:42 +00:00
Sergey Biryukov
4f6eee8e72 Themes: Move the test for post-formats theme support to a more appropriate place.
Follow-up to [49344].

See #51390.

git-svn-id: https://develop.svn.wordpress.org/trunk@49354 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-28 15:12:40 +00:00
Sergey Biryukov
7e4debe75c Customize: Update parameter name in api.Class.extend().
This makes the name consistent with the documentation and the `inherits()` function signature.

Props ribaricplusplus, davidbaumwald.
Fixes #51652.

git-svn-id: https://develop.svn.wordpress.org/trunk@49353 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-28 00:43:16 +00:00
Helen Hou-Sandi
2cbaf20dcd Twenty Twenty: Correct some textdomains in block patterns.
Props justinahinon.
Fixes #51648. See #51098.


git-svn-id: https://develop.svn.wordpress.org/trunk@49352 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 22:12:37 +00:00
Helen Hou-Sandi
8187cff8f7 Post WordPress 5.6 beta 2 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@49351 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 22:00:56 +00:00
Helen Hou-Sandi
8a3e34d9ad WordPress 5.6 Beta 2.
git-svn-id: https://develop.svn.wordpress.org/trunk@49350 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 21:40:26 +00:00
Helen Hou-Sandi
7daf3c4187 PHPCS fixes after [49347].
See #51098.


git-svn-id: https://develop.svn.wordpress.org/trunk@49349 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 21:21:33 +00:00
Helen Hou-Sandi
03d0433102 Bundled Themes: Introduce block patterns for Twenty Nineteen.
Including some props I missed on the commit for Twenty Twenty, I am sorry.

Props: kjellr, beafialho, melchoyce, ryelle, jffng, bridgetwillard.
Fixes #51099.


git-svn-id: https://develop.svn.wordpress.org/trunk@49348 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 21:13:09 +00:00
Helen Hou-Sandi
93cc559468 Bundled Themes: Introduce block patterns for Twenty Twenty.
Props melchoyce, Anlino, kjellr, ryelle.
Fixes #51098.


git-svn-id: https://develop.svn.wordpress.org/trunk@49347 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 20:59:30 +00:00
Helen Hou-Sandi
6501d4c93c Menus: Better responsive display for accordion items.
This only applies to the standalone menu screen; fixes for the customizer will be handled separately.

Props audrasjb, garrett-eclipse.
See #49375.


git-svn-id: https://develop.svn.wordpress.org/trunk@49346 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 20:16:22 +00:00
Sergey Biryukov
078dfbafdc Upgrade/Install: Adjust a string in core_auto_updates_settings() for consistency.
Props audrasjb, desrosj.
See #50907.

git-svn-id: https://develop.svn.wordpress.org/trunk@49345 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 20:10:51 +00:00
Helen Hou-Sandi
357c1c0b86 Post Formats: You have to pass an array of supported post formats.
This shows a `_doing_it_wrong()` message and also returns false instead of true if no array of formats is passed in `add_theme_support()`, avoiding a PHP error.

Post formats maintainership comes full circle. 🙃

Props Mista-Flo, sproutchris, garrett-eclipse.
Fixes #51390.


git-svn-id: https://develop.svn.wordpress.org/trunk@49344 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 19:58:10 +00:00
Helen Hou-Sandi
cf4a274466 Media: Fix styling for MediaElement player in media modal.
Fixes #43640.


git-svn-id: https://develop.svn.wordpress.org/trunk@49343 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 19:38:19 +00:00
Helen Hou-Sandi
c36874264b External Libraries: Update jQuery Migrate to 3.3.2-pre.
This is a prerelease version to avoid some errors in 5.6 beta 2. We need to be sure that we ship with a released version by 5.6 RC.

Props mweichert.
Fixes #51621. See #50564.


git-svn-id: https://develop.svn.wordpress.org/trunk@49338 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 18:57:03 +00:00
Helen Hou-Sandi
f293ae18b2 Login: Avoid AJAX error on login screen.
This has to do with the password generator, which does not need to generate and cache passwords in JS as that's already done in PHP.

Props adamsilverstein, sarahricker.
Fixes #51613.


git-svn-id: https://develop.svn.wordpress.org/trunk@49337 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 18:41:32 +00:00
Sergey Biryukov
18f172556d Build/Test Tools: Add Authorization headers support to local-env.
This ensures that basic authorization is passed from nginx to PHP.

Props Clorith.
Fixes #51646.

git-svn-id: https://develop.svn.wordpress.org/trunk@49336 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 18:32:22 +00:00
Jonathan Desrosiers
43b1fe75b8 Build/Test Tools: Specify a type when using wp config set.
This prevents an error if constants are not predefined when running the Docker install script while using older combinations of WordPress/PHP/WP-CLI.

See #48301.

git-svn-id: https://develop.svn.wordpress.org/trunk@49335 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 18:31:27 +00:00
Timothy Jacobs
0187bbdd7e Site Health, App Passwords: Test if the Authorization header is populated correctly.
App Passwords rely on the Authorization header to transport the Basic Auth credentials. For Apache web servers, WordPress automatically includes a RewriteRule to populate the value for servers running in CGI or FastCGI that wouldn't ordinarily populate the value. 

This tests if the header is being filled with the expected values. For Apache users, we direct the user to visit the Permalinks settings to flush their permalinks. For all other users, we direct them to a help document on developer.wordpress.org.

Props Clorith, marybaum, TimothyBlynJacobs.
Fixes #51638.


git-svn-id: https://develop.svn.wordpress.org/trunk@49334 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 18:30:03 +00:00
Helen Hou-Sandi
c81bd5d94b Privacy: Show failures before successes for all bulk actions.
Props garrett-eclipse.
See #44081, [49331].


git-svn-id: https://develop.svn.wordpress.org/trunk@49333 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 18:17:40 +00:00
Helen Hou-Sandi
d4f3bdcf52 Privacy: Show notices for both failed and successful bulk actions.
Props javorszky, garrett-eclipse, hellofromTonya.
Fixes #44081.


git-svn-id: https://develop.svn.wordpress.org/trunk@49331 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 17:45:29 +00:00
Jonathan Desrosiers
21aa04629e Twenty Twenty-One: Import the latest changes.
For a full list of changes since [49320], see 461dcf9cd...5759e96.

Props poena, melchoyce, aristath, justinahinon, ryelle.
See #51526.

git-svn-id: https://develop.svn.wordpress.org/trunk@49330 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 17:05:51 +00:00
Timothy Jacobs
d56906f5b0 REST API: Support a broader range of JSON media types.
Previously, we only supported `application/json` which prevented using subtypes like `application/activity+json`. This allows for the REST API to `json_decode` the body of requests using a JSON subtype `Content-Type`. Additionally, `wp_die()` now properly sends the error as JSON when a JSON subtype is specified in the `Accept` header.

Props pfefferle.
Fixes #49404.


git-svn-id: https://develop.svn.wordpress.org/trunk@49329 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 16:42:38 +00:00
Sergey Biryukov
fce8f2bf4d Posts, Post Types: Check if taxonomy is set for the tax_input parameter of wp_insert_post().
This avoids a PHP notice when creating a post with multiple taxonomies both having a default term.

Props yakimun, szaqal21, hareesh-pillai, audrasjb.
Fixes #51320.

git-svn-id: https://develop.svn.wordpress.org/trunk@49328 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 16:40:35 +00:00
Sergey Biryukov
986becfd4d Tests: Rename some files and classes in phpunit/tests/post/ per the naming conventions.
https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization

Follow-up to [47780].

See #51344.

git-svn-id: https://develop.svn.wordpress.org/trunk@49327 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 16:07:21 +00:00
Sergey Biryukov
548d03026b Docs: Fix typo in {$old_status}_to_{$new_status} hook description.
See #50768.

git-svn-id: https://develop.svn.wordpress.org/trunk@49326 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 15:40:21 +00:00
Andrew Ozz
1a0a55df8c Revert the improvenents to arranging of postboxes/metaboxes, [49179]. The current patch fixes about half a dozen problems, but seems more general improvements are needed to how Screen Options work.
See #50699.

git-svn-id: https://develop.svn.wordpress.org/trunk@49325 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 10:45:36 +00:00
Riad Benguella
dda3adec97 Block Editor: Update the WordPress packages for 5.6 beta 2
It contains:

- Fix drop zone indicators for non blocks.
- Fix archives block render function.
- Code block: preserve indentation on paste.
- Turn off autocomplete for token input. 
- Fix parent post selector: ensure initial value available, search performed, all results shown. 
- Fix gallery block undo issue.

Props isabel_brison.
Fixes #51640.


git-svn-id: https://develop.svn.wordpress.org/trunk@49324 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 09:32:50 +00:00
Sergey Biryukov
89e10133e3 Customize: Ensure the New Menu section is properly rendered.
Follow-up to [30102], [49101].

Props david.binda, boldgrid, dlh, azaozz, Clorith, westonruter, hellofromTonya.
Fixes #51592.

git-svn-id: https://develop.svn.wordpress.org/trunk@49323 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 02:46:27 +00:00
Sergey Biryukov
fff225ed0b Bundled Themes: Update latest version for Tested up to: in readme.txt files.
Props mukesh27.
Fixes #51501.

git-svn-id: https://develop.svn.wordpress.org/trunk@49322 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 02:16:22 +00:00
Sergey Biryukov
a23dcec496 Docs: Add a @global tag for $user_id in WP_Application_Passwords_List_Table::prepare_items().
Props mukesh27.
Fixes #51633.

git-svn-id: https://develop.svn.wordpress.org/trunk@49321 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 02:10:12 +00:00
Jonathan Desrosiers
952860aa13 Twenty Twenty-One: Import the latest changes for 5.6 beta 2.
For a full list of changes since beta 1, see 9e34dca...e580895.

Props poena, melchoyce, luminuu, aristath, justinahinon, jffng, ryelle, kishanjasani, rolfsiebers.
See #51526.

git-svn-id: https://develop.svn.wordpress.org/trunk@49320 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-27 01:58:37 +00:00
Helen Hou-Sandi
9745a84ce8 Administration: Accommodate long translations for "Posts" in list table headers.
This stems from longer translations on the User table, but this will apply to any posts column in a list table. Hyphenation should typically just apply to the column header, as the cell contents are just a count.

This does appear to have some browser inconsistencies, so may need further adjustment in the future.

Props audrasjb, justinahinon.
Fixes #50838.


git-svn-id: https://develop.svn.wordpress.org/trunk@49317 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-26 23:14:06 +00:00
Peter Wilson
db2a1ba75d Taxonomy: Fix values passed to actions in wp_modify_term_count_by_now().
Replace the `WP_Taxonomy` object with the taxonomy slug in the values passed to the actions `edit_term_taxonomy` and `edited_term_taxonomy` within `wp_modify_term_count_by_now()`.

Follow up to [49141], [49171].
Props Chouby, lcyh78.
Fixes #40351.



git-svn-id: https://develop.svn.wordpress.org/trunk@49316 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-26 23:05:22 +00:00
Sergey Biryukov
f108962185 Docs: Correct description for wp_pre_insert_user_data filter.
Props audrasjb.
Fixes #51637.

git-svn-id: https://develop.svn.wordpress.org/trunk@49314 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-26 22:51:51 +00:00
Sergey Biryukov
430320e905 Docs: Correct DocBlock formatting for render_block().
Follow-up to [49310].

See #51606.

git-svn-id: https://develop.svn.wordpress.org/trunk@49312 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-26 21:53:43 +00:00
Sergey Biryukov
f09b69c410 Docs: Add missing @since tags for properties in some block editor classes:
* `WP_Block_Pattern_Categories_Registry`
* `WP_Block_Patterns_Registry`
* `WP_Block_Supports`

Follow-up to [48156], [49226].

See #50768.

git-svn-id: https://develop.svn.wordpress.org/trunk@49311 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-26 21:49:26 +00:00
Riad Benguella
7be4701404 Block Editor: Fix WP_Block_Supports class compatibility with Gutenberg-provided class.
When using WordPress trunk with Gutenberg master, there's an incompatibility causing 
the dynamic block generated classes to be omitted.
This commit refactors the block supports to fix that problem.

Props nosolosw.
Fixes #51606.


git-svn-id: https://develop.svn.wordpress.org/trunk@49310 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-26 08:29:04 +00:00
Sergey Biryukov
f13776cd8d General: Use correct value for the speak property in various CSS files.
Follow-up to [49263].

Props hareesh-pillai.
Fixes #51622.

git-svn-id: https://develop.svn.wordpress.org/trunk@49309 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-26 02:23:24 +00:00
Timothy Jacobs
3646dd2e9f REST API: Prevent PHP warning when metadata schema is missing properties.
This switches to the new `rest_default_additional_properties_to_false()` function which doesn't have this issue and deprecates the `WP_REST_Meta_Fields::default_additional_properties_to_false()` method.

Props austin880625.
Fixes #51389.


git-svn-id: https://develop.svn.wordpress.org/trunk@49308 602fd350-edb4-49c9-b593-d223f7449a82
2020-10-25 20:28:50 +00:00