Commit Graph

29712 Commits

Author SHA1 Message Date
Gary Pendergast
ed53ad2c53 WPDB: When sanity checking query character sets, there's no need to check queries that don't return user data.
See #32104.



git-svn-id: https://develop.svn.wordpress.org/trunk@32374 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 06:04:50 +00:00
Gary Pendergast
923c6c981b WPDB: Allow queries to reference tables in the dbname.tablename format, and allow table names to contain any valid character, rather than just ASCII.
Props pento, willstedt for the initial patch.

See #32090.



git-svn-id: https://develop.svn.wordpress.org/trunk@32368 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 05:00:39 +00:00
Andrew Ozz
8737968ac2 TinyMCE: update to 4.1.10.
Fixes #32262.

git-svn-id: https://develop.svn.wordpress.org/trunk@32366 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 03:22:04 +00:00
Gary Pendergast
2ce97b2984 WPDB: When checking that a string can be sent to MySQL, we shouldn't use mb_convert_encoding(), as it behaves differently to MySQL's character encoding conversion.
Props mdawaffe, pento, nbachiyski, jorbin, johnjamesjacoby, jeremyfelt.

See #32165.



git-svn-id: https://develop.svn.wordpress.org/trunk@32364 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 02:59:50 +00:00
Boone Gorges
35db6d722b In paginate_links(), improve handling of custom pagination query vars.
Custom pagination query vars, as provided in the 'base' parameter, must be
detected in the current page URL and removed before generating fresh pagination
links. The logic introduced in this changeset ensures that these custom
query vars are properly detected in cases where the 'format' param contains
a `#`.

This is a follow-up to [31203] #30831.

Fixes #31939.

git-svn-id: https://develop.svn.wordpress.org/trunk@32359 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 21:58:23 +00:00
Boone Gorges
70f530e238 youtube.com oEmbed test should always expect HTTPS.
YouTube recently changed its oEmbed endpoint so that the iframe markup always
contains an HTTPS URL, regardless of the scheme of the video URL originally
requested. This changeset fixes the corresponding unit test.

Fixes #32260.

git-svn-id: https://develop.svn.wordpress.org/trunk@32358 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 21:30:57 +00:00
Aaron Jorbin
e68f7765c1 Update grunt-autoprefixer to 3.0.0
Two changes we need to know about:
* Aborts build if there is an exception thrown bu autoprefixer
* Less verbose output in standard mode

Major version seems to have been bumped due to change in annotation option which which we do not use.

Upstream Changes e30d2c5bfd...6f8dfe8840

See #31700


git-svn-id: https://develop.svn.wordpress.org/trunk@32357 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 21:29:04 +00:00
Aaron Jorbin
ee60ec1c23 Update grunt-contrib-qunit to 0.7.0
This upgrade adds two changes, both of which are aimed at less reporting of false test passing:
* Log PhantomJS errors as warnings
* Add noGlobals option, forwarded to QUnit. Report proper exit code to grunt based on failures. Add support for AMD.

See #31700



git-svn-id: https://develop.svn.wordpress.org/trunk@32356 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 20:29:29 +00:00
Boone Gorges
bb29a878c6 Improve performance of get_page_children().
The new algorithm uses a hash table rather than function recursion, reducing
complexity to O(N). On large numbers of pages, the performance improvement is
several orders of magnitude.

Props santagada, hailin, mihai.
Fixes #10852.

git-svn-id: https://develop.svn.wordpress.org/trunk@32355 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 19:36:58 +00:00
Boone Gorges
ba712c6789 Unit tests for get_page_children().
Props santagada, boonebgorges.
See #10852.

git-svn-id: https://develop.svn.wordpress.org/trunk@32354 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 19:36:46 +00:00
Boone Gorges
1efe303ebf Improve sanitization of 'name' param in get_terms().
Values of 'name' that contain db-encoded character on insert - like an
ampersand, which is HTML-encoded in the database - will only match if they go
through the same `sanitize_term_field()` routine.

Fixes #32248.

git-svn-id: https://develop.svn.wordpress.org/trunk@32353 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 11:13:51 +00:00
Drew Jaynes
3ca1ff6b72 Fix documentation syntax and formatting for the media_sideload_image() DocBlock.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32352 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 02:19:47 +00:00
Drew Jaynes
9d9fbf6a5b Add a changelog entry for the $resource_type parameter added to the get_ancestors filter in 4.1.1.
Props dimadin.
See #31925.


git-svn-id: https://develop.svn.wordpress.org/trunk@32351 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 02:16:58 +00:00
Drew Jaynes
7138b7e1bd Add two changelog entries for functional changes introduced in 4.2.0.
Props dimadin.
See #31925.


git-svn-id: https://develop.svn.wordpress.org/trunk@32350 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 02:15:27 +00:00
Drew Jaynes
fae4ff9b2f Ensure the optional parameters for get_taxonomies() are documented as such.
See #31800.


git-svn-id: https://develop.svn.wordpress.org/trunk@32349 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 02:04:52 +00:00
Drew Jaynes
e8668f7bca Improve inline documentation in wp-includes/taxonomy.php.
* Adds missing `@since` versions
* Adds `@global` tags and descriptions to DocBlocks where appropriate

Props ChaseWiseman.
See #31800.


git-svn-id: https://develop.svn.wordpress.org/trunk@32348 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 02:00:18 +00:00
Andrew Ozz
717ea3f7cd Emoji: add shorter/faster regex for testing for emoji chars in added nodes.
See #32125.

git-svn-id: https://develop.svn.wordpress.org/trunk@32347 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 01:40:21 +00:00
Boone Gorges
a4625b51eb Add 'webcal' to the list of URI protocols whitelisted by default.
Fixes #31666.

git-svn-id: https://develop.svn.wordpress.org/trunk@32346 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 00:37:14 +00:00
Drew Jaynes
fbb60698ea Add a missing @return tag and description to the DocBlock for WP_Theme::scandir().
Props lamosty.
Fixes #31872.


git-svn-id: https://develop.svn.wordpress.org/trunk@32345 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 00:33:55 +00:00
Drew Jaynes
98bed37af3 Properly document WP_Theme::scandir() as a static method, adjust parameter documentation for formatting and clarity.
See #31872.


git-svn-id: https://develop.svn.wordpress.org/trunk@32344 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 00:32:23 +00:00
Aaron Jorbin
d0567838e4 Update QUnit to v1.18.0
See https://github.com/jquery/qunit/blob/1.18.0/History.md for changes from 1.12.0 to now.  Mostly bug fixes and internal changes in preparation for QUnit v2.

See #30824



git-svn-id: https://develop.svn.wordpress.org/trunk@32343 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 19:43:38 +00:00
Boone Gorges
93a4bf15e4 Attachment URLs should only be forced to SSL on the front end.
Detecting SSL status on the Dashboard introduces problems when writing content
that is saved to the database and then displayed on the front end, where SSL
may be optional (or impossible, due to self-signed certificates). The new
approach parallels the logic in `get_home_url()` for forcing HTTPS.

See [31614] #15928 for background.

Fixes #32112 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@32342 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 13:09:14 +00:00
Drew Jaynes
eea4111667 Add a missing DocBlock for wp_caption_input_textarea().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32341 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 01:12:12 +00:00
Drew Jaynes
b7bce33748 Add a missing @return tag to the DocBlock for `uninstall_plugin().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32340 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 01:07:47 +00:00
Drew Jaynes
5a45289302 Add a missing @return tag to the DocBlock for site_admin_notice().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32339 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 01:05:48 +00:00
Drew Jaynes
511ce10e53 Clarify accepted types for the $args and $context parameters in WP_Filesystem().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32338 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 01:03:08 +00:00
Andrew Ozz
49626f348a Emoji: rename the exclude class to wp-exclude-emoji.
Props Clorith. See #32197.

git-svn-id: https://develop.svn.wordpress.org/trunk@32337 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 00:04:15 +00:00
Andrew Ozz
992cc2e796 Emoji: add an exclude class to wp-emoji checked when monitoring for changes with mutationObserver. Use it for the hidden div used for resizing the Text editor.
See #32197.

git-svn-id: https://develop.svn.wordpress.org/trunk@32336 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-03 20:17:38 +00:00
Andrew Ozz
6368ee0c6a Emoji: before parsing added nodes test if the text in them contains emoji chars. That speeds up the processing quite a bit.
See #32125.

git-svn-id: https://develop.svn.wordpress.org/trunk@32335 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-03 19:07:31 +00:00
Andrew Ozz
9c3c452fa9 Emoji:
- Fix loading errors in IE9 and IE10.
- Add fallbacks for the loading events.
Fixes #32109 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@32334 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-03 18:44:37 +00:00
Sergey Biryukov
2848b8a911 Replace echo __() with _e().
props marsjaninzmarsa.
fixes #32239.

git-svn-id: https://develop.svn.wordpress.org/trunk@32333 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-03 16:17:06 +00:00
Sergey Biryukov
72c437c2a8 Merge two strings from theme details dialog.
props McGuive7.
fixes #32047.

git-svn-id: https://develop.svn.wordpress.org/trunk@32332 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-02 09:10:59 +00:00
Boone Gorges
e5e467a41b Allow metadata to be deleted when meta_value matches 0 or '0'.
In `delete_metadata()`, be stricter about when to ignore a falsey value of
`$meta_value`.

For backward compatibility, an empty string for `$meta_value` is equivalent to
`null` or `false`.

Props sc0ttkclark.
Fixes #32224.

git-svn-id: https://develop.svn.wordpress.org/trunk@32331 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-01 16:37:35 +00:00
Scott Taylor
625e7135f3 After [32258], restore the parts of [31620] and [31626] that weren't changes to the UI, but were improvements to existing code.
* Use `wp.shortcode()` instead of manually constructing a shortcode in `views/embed/link`
* In `WP_Embed`, store the last URL and last set of attributes requested in class properties
* `wp_ajax_parse_embed()`, allow `[embed]`s to have attributes. Return `attr` in the response.

See #31139.


git-svn-id: https://develop.svn.wordpress.org/trunk@32330 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-30 21:39:52 +00:00
Sergey Biryukov
345d34cad9 Bulk Edit: Properly associate the Format select with its label.
props afercia.
fixes #32210.

git-svn-id: https://develop.svn.wordpress.org/trunk@32329 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-30 16:03:06 +00:00
Sergey Biryukov
e4be853426 Use correct closing tag.
props eligijus, TobiasBg.
fixes #32205.

git-svn-id: https://develop.svn.wordpress.org/trunk@32328 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-30 14:29:24 +00:00
Boone Gorges
53d42e6a9c Remove duplicate semicolon introduced in [32326].
git-svn-id: https://develop.svn.wordpress.org/trunk@32327 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-29 12:57:35 +00:00
Boone Gorges
1700d2b265 Improve performance of loop detection in _get_term_children().
Using an array keyed by term_id allows us to use `isset()` rather than the
slower `in_array()`. In addition, it lets us avoid the use of `wp_list_pluck()`
on large arrays, and helps us to avoid arrays that are unnecessarily large due
to duplicate entries.

Fixes #32144 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@32326 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-29 12:55:29 +00:00
Sergey Biryukov
51b69b1f7f Fix typo in a comment in wp_guess_url().
props ixkaito.
fixes #32179.

git-svn-id: https://develop.svn.wordpress.org/trunk@32325 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-29 07:18:35 +00:00
Andrew Ozz
f31aeb97f1 Emoji: fix loop when replacement images fail to load.
Props iseulde. Fixes #32128 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@32323 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-29 03:19:01 +00:00
Dion Hulse
342989657f When creating a temporary file treat the / directory properly, to prevent it ending up in an endless self-calling loop.
Props hnle, taka2. Fixes #32135. See #31811


git-svn-id: https://develop.svn.wordpress.org/trunk@32322 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-29 03:16:06 +00:00
Sergey Biryukov
af0315de16 Bundled themes: use SSL WordPress.org URL in rtl.css.
see #32083.

git-svn-id: https://develop.svn.wordpress.org/trunk@32315 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 18:11:01 +00:00
Lance Willett
0598065cdd Bundled themes: use SSL WordPress.org URLs.
Props SergeyBiryukov, fixes #32083.

git-svn-id: https://develop.svn.wordpress.org/trunk@32314 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 17:35:06 +00:00
Gary Pendergast
0b868edb8e When deleting suspicious comments, do so permanently.
git-svn-id: https://develop.svn.wordpress.org/trunk@32310 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 16:10:50 +00:00
Gary Pendergast
ae1f6413c9 [32308] was for 4.3, not 4.2.1.
git-svn-id: https://develop.svn.wordpress.org/trunk@32309 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 16:07:20 +00:00
Gary Pendergast
0224286861 When upgrading to 4.2.1, delete suspicious comments.
git-svn-id: https://develop.svn.wordpress.org/trunk@32308 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 16:03:48 +00:00
Gary Pendergast
0152b8f49b In [32299], we should be using mb_strlen() for our string size checks.
git-svn-id: https://develop.svn.wordpress.org/trunk@32306 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 14:41:48 +00:00
Gary Pendergast
45b0abbef1 WPDB: Sanity check that any strings being stored in the DB are not too long to store correctly.
git-svn-id: https://develop.svn.wordpress.org/trunk@32299 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 14:02:45 +00:00
Andrew Nacin
ca8d6fb60f Escape the $s global.
fixes #32142.


git-svn-id: https://develop.svn.wordpress.org/trunk@32298 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 05:09:24 +00:00
Sergey Biryukov
fdd254b5d8 Add missing word to wp_insert_term() error strings.
props dipesh.kakadiya.
fixes #32031.

git-svn-id: https://develop.svn.wordpress.org/trunk@32297 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-26 11:49:36 +00:00