Commit Graph

27156 Commits

Author SHA1 Message Date
Helen Hou-Sandi ee20b5a45f Editor scrolling:
* Reduce the starting height of the editor to better match the height at which the top toolbar unpins.
* Pin the side metaboxes so they do not get lost when the editor content is long.
* Turn magic numbers into variables.

props stephdau, azaozz. see #28328.



git-svn-id: https://develop.svn.wordpress.org/trunk@29495 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-15 03:16:07 +00:00
Andrew Ozz 22eca56a81 Some pre-commit cleanup of media-grid.js and media-views.js
git-svn-id: https://develop.svn.wordpress.org/trunk@29494 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-15 01:12:32 +00:00
Sergey Biryukov 97eb710697 Media Grid: Use an existing string for posts without a title.
see #24716.

git-svn-id: https://develop.svn.wordpress.org/trunk@29493 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-14 21:40:11 +00:00
Scott Taylor d0441a6b42 Media Grid, support `MEDIA_TRASH`: add AYS to bulk actions.
See #29145.


git-svn-id: https://develop.svn.wordpress.org/trunk@29492 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-14 19:07:06 +00:00
Scott Taylor 7308949ea3 Media Grid, support `MEDIA_TRASH`:
* Only use the special `trashAttachment` logic when in `edit-metadata` mode.
* Don't support the `trash` filter in the Add Media modal for now.
* Properly toggle trash/untrash logic in the Attachment Details sidebar

See #29145.


git-svn-id: https://develop.svn.wordpress.org/trunk@29491 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-14 18:50:04 +00:00
Scott Taylor 8661fcf0d9 Media Grid, support `MEDIA_TRASH`:
* Add a setting to `_wpMediaViewsL10n.settings`: `mediaTrash`
* In the attachment edit modal, properly toggle between Trash/Untrash
* In `media.view.Attachment`, add a method for `untrashAttachment`
* When creating the grid toolbar, switch the setting order of subviews so that `media.view.DeleteSelectedButton` can listen to the instance of `media.view.AttachmentFilters.All` to update the text in its UI.
* Add a new filter to `media.view.AttachmentFilters.All`, `trash`, when `settings.mediaTrash` is true
* Allow the cached queries in `Query.get()` to be flushed when race conditions exist and collections need to be refreshed. This is currently only being used when `MEDIA_TRASH` is set, to refresh the filtered/mirrored collections related to `all`, `trash`, and any already queried filter.
* Cleanup the bootstrapping of `media.view.MediaFrame.Manage`
* Allow `wp_ajax_query_attachments()` to return items from the trash when `MEDIA_TRASH` is `true`
* Allow `wp_ajax_save_attachment()` to set `post_status` when `MEDIA_TRASH` is `true`. It allows `wp_delete_post()` to be called, which will trash the attachment instead of deleting when the flag is set.

Props koop for the knowledge sharing and thought partnership.
See #29145.


git-svn-id: https://develop.svn.wordpress.org/trunk@29490 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-14 18:30:49 +00:00
Helen Hou-Sandi 1ab750d0d2 Media grid bulk selection styling:
* Fade content within each attachment item so that focus styling is still clear.
* Less jarring toolbar pinning.
* Tighten up the fade in/out transition.

see #28842.


git-svn-id: https://develop.svn.wordpress.org/trunk@29489 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-14 07:17:27 +00:00
Andrew Nacin bc582fc058 Customizer: Mixed priority sorting for panels and top-level sections.
props celloexpressions.
fixes #28979.


git-svn-id: https://develop.svn.wordpress.org/trunk@29488 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-14 04:42:30 +00:00
Andrew Nacin 112f9e9cc7 Separate WP_Customize_Panel from WP_Customize_Section.
props celloexpressions.
fixes #29197.


git-svn-id: https://develop.svn.wordpress.org/trunk@29487 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-14 04:39:42 +00:00
Helen Hou-Sandi cc51f62262 Remove now-unused strings. see #28842.
git-svn-id: https://develop.svn.wordpress.org/trunk@29486 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-14 04:22:34 +00:00
Scott Taylor 2cca041f44 Remove debug line from [29484].
See #28842.



git-svn-id: https://develop.svn.wordpress.org/trunk@29485 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-14 00:36:08 +00:00
Scott Taylor 3ed9e02d0b Media Grid: add Bulk Selection mode for deleting attachments.
* Toolbar is sticky when `select` mode is active
* Selection is toggled when clicking an attachment preview
* Unselected attachments fade out, selected fade in.

See #28842.


git-svn-id: https://develop.svn.wordpress.org/trunk@29484 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-13 22:44:48 +00:00
Scott Taylor ef86826322 Media Grid: treat Edit Image like a `mode`, which it is, instead of a `state`, which it is not.
Fixes #29206.


git-svn-id: https://develop.svn.wordpress.org/trunk@29483 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-13 19:25:23 +00:00
Dominik Schilling (ocean90) f22c2110ac Customizer: Fix ID attribute for a panel.
props celloexpressions.
fixes #29174.

git-svn-id: https://develop.svn.wordpress.org/trunk@29482 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-13 18:25:04 +00:00
Scott Taylor d48bee596a In the Edit Attachment frame, when in Edit Image mode, add a key event for Escape. There are conflicting `keydown` handlers that don't propagate the event to the modal properly.
Fixes #29121.


git-svn-id: https://develop.svn.wordpress.org/trunk@29481 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-13 18:14:15 +00:00
Helen Hou-Sandi 4958fecdaf Plugin details: Remove some CSS rules that were unnecessary and causing issues in Firefox. see #27440.
git-svn-id: https://develop.svn.wordpress.org/trunk@29480 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-13 05:27:01 +00:00
Drew Jaynes (DrewAPicture) ab6063cc88 Fix some documentation typos in various core files.
Props vlajos.
Fixes #29199.


git-svn-id: https://develop.svn.wordpress.org/trunk@29479 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-13 03:55:10 +00:00
Andrew Ozz b343d48221 Fix the `wp-settings-*` cookies used in getUserSetting()/setUserSetting(). They should be set without `COOKIE_DOMAIN` to work properly for sub-domains. Fixes #29095.
git-svn-id: https://develop.svn.wordpress.org/trunk@29478 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-13 02:46:18 +00:00
Sergey Biryukov 6d6bce429d Plugin install: Make plugin groups translatable.
props ocean90 for initial patch.
fixes #29092.

git-svn-id: https://develop.svn.wordpress.org/trunk@29477 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-13 02:30:24 +00:00
John Blackbourn 30f7ce96cb Switch the Polldaddy oEmbed endpoint to HTTPS as it now redirects there. See #28507.
git-svn-id: https://develop.svn.wordpress.org/trunk@29476 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-13 00:16:11 +00:00
Sergey Biryukov c943d6d816 Additional @return clarifications for get_the_terms(), get_the_tag_list(), and get_the_term_list().
see #29183.

git-svn-id: https://develop.svn.wordpress.org/trunk@29475 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-12 23:47:23 +00:00
Helen Hou-Sandi f37a0e160d Plugin details modal:
* Scroll all content, rather than the dual-pane scrolling awkwardness.
* Better align the header image and title overlay with the display on WordPress.org, at least at full-width.
* Move the close button outside of the modal itself, rather than overlay on top of colors we can't predict.

props stephdau, tellyworth, helen. fixes #27440.


git-svn-id: https://develop.svn.wordpress.org/trunk@29474 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-12 23:01:38 +00:00
Andrew Ozz ecfee74ce2 Media modal: make sure the Close button is focused after attempting to close the onscreen keyboard on touch devices. Props celloexpressions, fixes #29166.
git-svn-id: https://develop.svn.wordpress.org/trunk@29473 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-12 21:57:43 +00:00
Scott Taylor 72ca5be593 After [29422], make sure the internal array counter is not reset for the `$wp_filter` global.
Props kovshenin.
See #29070.


git-svn-id: https://develop.svn.wordpress.org/trunk@29472 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-12 14:46:45 +00:00
Andrew Ozz 169a5ae561 TinyMCE: fix the 'editimage' plugin for touch devices. Better attempt to hide the onscreen keyboard when the media modal opens and TinyMCE is in focus. See #28595, #29166
git-svn-id: https://develop.svn.wordpress.org/trunk@29471 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-12 04:26:13 +00:00
Helen Hou-Sandi fff4c473d3 Clearer visual differentiation between panels and sections in the customizer. props celloexpressions. see #28979.
git-svn-id: https://develop.svn.wordpress.org/trunk@29470 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-12 01:17:07 +00:00
Sergey Biryukov 947ca94071 Correct references to post-template.php in the inline docs.
props softmodeling.
fixes #29188.

git-svn-id: https://develop.svn.wordpress.org/trunk@29469 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-12 01:08:19 +00:00
John Blackbourn fcda873946 Correct the docblock for the `registered_post_type` action. Fixes #29184.
git-svn-id: https://develop.svn.wordpress.org/trunk@29468 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-11 21:20:58 +00:00
John Blackbourn ccc0673612 Docblock corrections for `get_the_terms()` function and corresponding filter, and `registered_taxonomy` action. Fixes #29183.
git-svn-id: https://develop.svn.wordpress.org/trunk@29467 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-11 21:16:52 +00:00
Helen Hou-Sandi 8bdbb3de87 Better focus styling for buttons and button groups. props mattheu, avryl, celloexpressions. fixes #27826. see #28267.
git-svn-id: https://develop.svn.wordpress.org/trunk@29466 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-11 18:20:18 +00:00
Helen Hou-Sandi 18a8b40401 Add styling for various HTML5 input elements. props avryl. fixes #28262.
git-svn-id: https://develop.svn.wordpress.org/trunk@29465 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-11 16:41:35 +00:00
Sergey Biryukov 9f3b8dbead XML-RPC: Avoid a PHP notice in pingback_ping() method.
props jesin, simonp303.
fixes #29177.

git-svn-id: https://develop.svn.wordpress.org/trunk@29464 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-11 15:18:08 +00:00
Andrew Ozz 5b2ae73e18 TinyMCE: update wpview and editimage plugins for 4.1.3. Add show/hide of the Edit and Delete buttons on views and images on 'touchend'. See #28595, #29166
git-svn-id: https://develop.svn.wordpress.org/trunk@29463 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-10 04:21:46 +00:00
Drew Jaynes (DrewAPicture) e8adffff96 s/does/does not in `wp_set_password()` docblock.
See [29461]. See #28316.


git-svn-id: https://develop.svn.wordpress.org/trunk@29462 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-10 02:43:07 +00:00
Drew Jaynes (DrewAPicture) 5aef1c5aa5 Improve the `wp_set_password()` PHPDoc with a note to guard against executing the function on every page load, such as through a theme's functions.php file.
See #28316.


git-svn-id: https://develop.svn.wordpress.org/trunk@29461 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-10 02:38:52 +00:00
Drew Jaynes (DrewAPicture) 39ba840e04 Add `@access` tags to constructor docblocks in list table classes.
See #28679. See [29459].


git-svn-id: https://develop.svn.wordpress.org/trunk@29460 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-10 02:21:56 +00:00
Drew Jaynes (DrewAPicture) 126147a877 Document default arguments for the `WP_List_Table` class. Also add referenced docblocks to extending class constructors.
Props mikejolley for the initial patch.
Fixes #28679. See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@29459 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-10 02:17:14 +00:00
Andrew Ozz f8fed596ec TinyMCE: update to 4.1.3, changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt, fixes #29166
git-svn-id: https://develop.svn.wordpress.org/trunk@29458 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 20:55:34 +00:00
Scott Taylor e23c1ae3ff Upgrade MediaElement to 2.15.0:
* It is required to set `height` on the parent `.wp-video` wrapper for video
* Fixes the play button hover problem in Chrome
* Includes my pull request: https://github.com/johndyer/mediaelement/pull/1273

All changes:
https://github.com/johndyer/mediaelement/compare/2.14.2...master

See #29110.


git-svn-id: https://develop.svn.wordpress.org/trunk@29457 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 20:43:25 +00:00
Scott Taylor 45368dbfaa Video:
* Don't set height on responsive `<div>` when generating markup
* Move some CSS rules from the style tag to `.wp-video`
* Use Video Details view event delegation instead of click events delegated from `<body>`
* Fix some CSS rule collision in the grid modal

See #29110.


git-svn-id: https://develop.svn.wordpress.org/trunk@29456 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 19:38:40 +00:00
Drew Jaynes (DrewAPicture) 8feaba4ca2 Clean up some missing `@access` tags and other tweaks for 4.0.0-functionality docs.
See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29455 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 19:31:35 +00:00
Drew Jaynes (DrewAPicture) a84d50dfa3 Fix some words that aren't words.
See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29454 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 19:29:37 +00:00
Dominik Schilling (ocean90) e8e0880851 WP_Plugins_List_Table::bulk_actions() method declaration should match WP_List_Table, see [29440].
props imath.
fixes #29148.

git-svn-id: https://develop.svn.wordpress.org/trunk@29453 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 14:45:20 +00:00
Andrew Ozz c4424ea546 Media at small screens:
- Show the image details/settings as an overlay.
- Better styling for the frame drop-down.
- Remove the multi-select by default on the Insert frame.
See #27423

git-svn-id: https://develop.svn.wordpress.org/trunk@29452 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 05:08:16 +00:00
Scott Taylor af851b9bda Add some docs to Customizer JS.
Props ericlewis.
See #29157.


git-svn-id: https://develop.svn.wordpress.org/trunk@29451 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 23:30:30 +00:00
Scott Taylor 0a6221058f Add some docs to Customizer JS.
Props ericlewis.
See #29157.


git-svn-id: https://develop.svn.wordpress.org/trunk@29450 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 22:09:46 +00:00
Andrew Ozz d6d00167a6 TinyMCE: don't access the parent window when opening the (iframe based) Help/Keyboard Shortcuts modal. Fixes #20094.
git-svn-id: https://develop.svn.wordpress.org/trunk@29449 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 21:17:15 +00:00
Andrew Ozz 78c928ad44 Editor: use the `post_edit_form_tag` action to add autocomplete="off" to the whole form on the Add/Edit Post screen in WebKit. Prevents editor problems when the browser's Back button is used. Fixes #28037.
git-svn-id: https://develop.svn.wordpress.org/trunk@29448 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 20:53:31 +00:00
Helen Hou-Sandi d837ad9fa3 Revert [29287] based on design and core team feedback. see #29012.
git-svn-id: https://develop.svn.wordpress.org/trunk@29447 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 19:00:28 +00:00
Andrew Ozz f4e7b2a6ad Media: improve the media modal at small screen sizes and make it usable on phones, first run. Part-props gcorne, see #27423.
git-svn-id: https://develop.svn.wordpress.org/trunk@29446 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 03:45:55 +00:00