sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
27,222 Commits 2 Branches 473 Tags 137 MiB
eef49c7f45
Commit Graph

1704 Commits

Author SHA1 Message Date
Sergey Biryukov
63596d6868 Prevent bulk actions from being performed when Filter button is clicked. 
props layotte.
fixes #28555.

git-svn-id: https://develop.svn.wordpress.org/trunk@28766 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-17 22:16:11 +00:00
Sergey Biryukov
177d39a15b Fix labels on installation screen. 
props avryl.
fixes #28548.

git-svn-id: https://develop.svn.wordpress.org/trunk@28759 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-17 14:36:22 +00:00
Andrew Ozz
ed07c215dc wpView: improve handling of embed errors/error messages, see #28195 
git-svn-id: https://develop.svn.wordpress.org/trunk@28754 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-15 22:52:45 +00:00
Andrew Nacin
65803684f4 Add a new 'Beta Testing' tab on the plugin installer, for features as plugins such as Press This. 
fixes #28513.


git-svn-id: https://develop.svn.wordpress.org/trunk@28749 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-12 18:08:56 +00:00
Scott Taylor
e0a089d9d8 Don't use variable variables in touch_time(). 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28747 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-11 21:04:56 +00:00
Scott Taylor
61c1da236c Don't use variable variables in wp_reset_vars(). Test by searching in list tables, etc. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28746 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-11 19:59:18 +00:00
Scott Taylor
eb23569835 Don't use variable variables in user-new.php. Test by causing errors when creating a new user. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28745 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-11 19:53:25 +00:00
Scott Taylor
6e159bb671 Don't use variable variables in setup-config.php (Step 2). 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28744 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-11 19:40:27 +00:00
Scott Taylor
98f3cd0548 OPML: 
* Learn how OPML works, cry.
* Remove unused globals in `startElement()`
* Stop using variable variables in `startElement()`

Tested with the OPML importer plugin

See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28743 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-11 19:30:26 +00:00
Scott Taylor
4ccb011960 Don't use variable variables in wp_dashboard_plugins_output(). Variable variables aren't the worst thing about this function. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28742 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-11 18:55:00 +00:00
John Blackbourn
f02e878bb0 Only include relevant post authors in WXR exports. Fixes #20206. Props jeremyfelt. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28731 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-10 19:14:26 +00:00
John Blackbourn
827cf97b00 Add screen reader labels to the date inputs on the post editing screen. Fixes #25461. Props frank-klein. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28730 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-10 18:49:26 +00:00
Scott Taylor
121726df31 edit.php?post_type=attachment should redirect to upload.php. Without the redirect, the user is presented with an empty list table. There are probably other issues to address overall, but this accomplishes what the ticket wants. 
Props knutsp.
Fixes #27951.


git-svn-id: https://develop.svn.wordpress.org/trunk@28729 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-10 18:47:57 +00:00
Scott Taylor
84ad12b439 Replace all uses of like_escape() with $wpdb->esc_like(). 
Props miqrogroove.
See #10041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28712 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-10 00:43:32 +00:00
Scott Taylor
faf208de38 Live update the menu item title when the user is editing the "Navigation Label" field. 
Props celloexpressions.
See #23076.


git-svn-id: https://develop.svn.wordpress.org/trunk@28707 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-09 18:38:29 +00:00
Helen Hou-Sandi
70390c48f5 Properly indicate with the cursor that the editor can be vertically resized using the entire info bar, not just the handle displayed in the corner. 
props torresga. fixes #28420.


git-svn-id: https://develop.svn.wordpress.org/trunk@28703 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-08 19:47:00 +00:00
Helen Hou-Sandi
3d9fc450b2 Grid view for the media library, first pass. This is alpha; expect imperfection. We will be iterating further. 
props ericlewis, shaunandrews, wonderboymusic.
see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28682 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-05 22:00:24 +00:00
Sergey Biryukov
c7c1a4a88a Remove one-time variable from add_settings_error(). 
props niallkennedy.
fixes #22228.

git-svn-id: https://develop.svn.wordpress.org/trunk@28681 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-05 18:28:15 +00:00
Sergey Biryukov
7f3b20c45d Remove redundant 'Visit author homepage' title attributes for plugins and themes. 
props joedolson.
fixes #26554.

git-svn-id: https://develop.svn.wordpress.org/trunk@28673 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-05 04:51:55 +00:00
Drew Jaynes (DrewAPicture)
24b3ed214e Make sure to use 3-digit x.x.x style for two 3.9.0 @since versions. 
Props netweb.
Fixes #28446.


git-svn-id: https://develop.svn.wordpress.org/trunk@28658 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-04 05:34:37 +00:00
Drew Jaynes (DrewAPicture)
9bb9177199 Make sure $post is properly documented as optional where applicable. 
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28653 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-03 03:52:46 +00:00
Sergey Biryukov
e8e39d212b Plugin activation/deletion errors should be styled as such. 
props johnbillion.
fixes #28260.

git-svn-id: https://develop.svn.wordpress.org/trunk@28646 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-31 20:09:26 +00:00
Sergey Biryukov
c04daa1ade Avoid stomping of the $plugin variable in activate_plugin(). 
fixes #28102.

git-svn-id: https://develop.svn.wordpress.org/trunk@28644 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 22:07:43 +00:00
Sergey Biryukov
9120e6a9d7 Display the site scheme, not the current scheme on Edit Site screen in network admin. 
props johnbillion.
fixes #28406.

git-svn-id: https://develop.svn.wordpress.org/trunk@28643 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 22:00:45 +00:00
Sergey Biryukov
dbef7e2587 Add paragraph tags to 'Add Existing User' section on 'Add New User' screen in multisite. 
props jkudish, topher1kenobe.
fixes #20271.

git-svn-id: https://develop.svn.wordpress.org/trunk@28642 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 21:50:24 +00:00
Scott Taylor
804b82bd11 Make the image editor less jumpy when opening. 
Props eddiemoya, ericlewis.
Fixes #22793.



git-svn-id: https://develop.svn.wordpress.org/trunk@28639 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 19:52:35 +00:00
Scott Taylor
e996a74984 Restore $val in WP_Importer::bump_request_timeout() - even though the parent class and WP_Import ignore the parameter, it creates an incompatible interface notice in the plugin. 
See [28629].



git-svn-id: https://develop.svn.wordpress.org/trunk@28637 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 19:34:53 +00:00
Scott Taylor
2cd825a21b Cleanup for switch statements: 
* Move `default` to the bottom in `WP_Theme_Install_List_Table`
* `switch/endswitch` syntax is not supported in Hack. Switch to `switch (...) {  .... }` syntax. (A few template-type instances linger).

Fixes #28409.
See #27881.



git-svn-id: https://develop.svn.wordpress.org/trunk@28633 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 17:57:51 +00:00
Drew Jaynes (DrewAPicture)
dc96d99a70 Remove unnecessary "not used" notation for filter parameters in wp-admin/includes/media.php. 
Also add `@param` and `@return` descriptions.

See #28408.


git-svn-id: https://develop.svn.wordpress.org/trunk@28632 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 17:37:36 +00:00
Scott Taylor
7ab6b096e6 Remove some dead variable assignments. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28629 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 16:58:36 +00:00
Andrew Ozz
d87a482353 TinyMCE in iOS: 
- Fix placing the caret at the bottom of longer posts when the keyboard is open.
- Disable resizing on switching editors and on show/hide the kitchen sink row.
See #28242

git-svn-id: https://develop.svn.wordpress.org/trunk@28626 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 02:37:52 +00:00
Helen Hou-Sandi
220a45a32d Don't use the box shadow focus styling for the admin menu or toolbar. see #28267. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28616 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-29 14:22:39 +00:00
Helen Hou-Sandi
06c142a1a5 Better align link element focus with form focus styling, which also improves the visibility. props zamfeer. see #28267. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28608 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-29 03:57:44 +00:00
Sergey Biryukov
c73f5ef2de Fix displaying taxonomies in bulk edit if the post type does not support titles. 
props scribu.
fixes #16793.

git-svn-id: https://develop.svn.wordpress.org/trunk@28600 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-28 13:49:21 +00:00
Sergey Biryukov
7b133a336f Remove obsolete code from wp_dashboard_setup(). 
props kitchin.
fixes #26604.

git-svn-id: https://develop.svn.wordpress.org/trunk@28592 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 15:40:19 +00:00
Sergey Biryukov
2f1ad4ddbf Move 'Documentation on date and time formatting' link under the 'Time Format' block. 
props gauravmittal1995.
fixes #28348.

git-svn-id: https://develop.svn.wordpress.org/trunk@28591 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 14:49:51 +00:00
Sergey Biryukov
86b88bd2b7 Add BMP to the list of displayable image types. 
props ericlewis.
fixes #26808.

git-svn-id: https://develop.svn.wordpress.org/trunk@28589 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 13:24:39 +00:00
Sergey Biryukov
c2076859eb Remove redundant get_shortcode_regex() check. 
props kovshenin.
see #28195.

git-svn-id: https://develop.svn.wordpress.org/trunk@28587 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 11:29:11 +00:00
Scott Taylor
792fe23675 When adding a URL in the Insert from URL state in the media modal, attempt to show a preview of the content. Drop the unused width and height fields. 
This will probably be iterated upon.

Props helen, jtsternberg, wonderboymusic.
See #15490.


git-svn-id: https://develop.svn.wordpress.org/trunk@28581 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-26 23:56:27 +00:00
Scott Taylor
8567bba0bf Don't pass embeds through the_content() when trying to render MCE previews, leverage WP_Embed and do_shortcode() instead. 
Props kovshenin.
See #28195.



git-svn-id: https://develop.svn.wordpress.org/trunk@28580 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-26 23:42:08 +00:00
Scott Taylor
5c3f7d5392 In media_sideload_image(), check the returned value of download_url() earlier to avoid attempting to unlink() an instance of WP_Error. 
Props georgestephanis. 
Fixes #28204.


git-svn-id: https://develop.svn.wordpress.org/trunk@28567 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-23 21:32:12 +00:00
Scott Taylor
a2b0c8b2e4 In get_terms_to_edit(), call get_object_term_cache() before priming cache with wp_get_object_terms(). 
In `get_inline_data()`, do the same.

On list table screens with taxonomies in the admin, this dramatically reduces the number of database queries (3x less). Even more so with a persistent object cache (5x less).

Props johnbillion, jeffstieler, wonderboymusic.
Fixes #18968.



git-svn-id: https://develop.svn.wordpress.org/trunk@28561 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-23 19:28:45 +00:00
Scott Taylor
a4e1ec0b90 Fix parsing in wp_match_mime_types() to allow some mime-types with + in them to appear in the list of filter links shown above the list table on upload.php. 
Props _duck.
Fixes #20672.



git-svn-id: https://develop.svn.wordpress.org/trunk@28553 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 21:35:36 +00:00
Scott Taylor
e53cdbb8f0 In wp_dashboard_recent_posts(), $i is set and never used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28545 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 18:55:07 +00:00
Scott Taylor
70342f4a75 $theme_name is set but no longer used in wp_dashboard_right_now(). The theme name is displayed with the call to update_right_now_message(). 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28544 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 18:53:43 +00:00
Scott Taylor
312ef7b264 These functions import $wpdb but do not use it. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28539 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 17:36:42 +00:00
Sergey Biryukov
15588188e8 Fix inconsistent header underlining and spacing in background update emails. 
fixes #28306.

git-svn-id: https://develop.svn.wordpress.org/trunk@28537 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 09:40:36 +00:00
Sergey Biryukov
9966795165 Use correct function name. 
props ericlewis.
fixes #28329.

git-svn-id: https://develop.svn.wordpress.org/trunk@28535 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 07:58:26 +00:00
Scott Taylor
dc1ada20c7 Upgrade _WP_List_Table_Compat to PHP5-style constructor. 
Add `public` to methods/members of `WP_Role`.
Add `public` to methods/members of `WP_User` where appropriate. Don't set `private` where indicated until more study has occurred and tests have been written for compatibiliy with existing magic methods.

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28531 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 17:19:09 +00:00
Scott Taylor
be2e5f6fb5 hackificator doesn't like mixed single/double-quoted attributes. These were 2 lingering instances in the admin. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28530 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 17:09:42 +00:00
Scott Taylor
d261d0030a In WP_Filesystem_Base, the constructor is a noop, so it shouldn't even be declared. Setting it implies that parent::__construct() should be called by its subclasses. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28529 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 16:45:42 +00:00
Scott Taylor
daecbc9659 Classes that have __set() also need __isset() and __unset(). 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28524 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 06:51:35 +00:00
Scott Taylor
77c6420969 Some classes with __get() method also need __set(). 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28521 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 06:31:00 +00:00
Scott Taylor
f716ff94e4 Add missing access modifiers to methods/members in Walker and subclasses. Add a magic __get() method. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28514 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:59:07 +00:00
Scott Taylor
e43d2a73d8 Fix some hackificator odds and ends in wp-admin: 
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28500 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:03:44 +00:00
Drew Jaynes (DrewAPicture)
7b2c87df9a Improve inline documentation of default arguments for post_format_meta_box(), post_tags_meta_box(), and post_categories_meta_box(). 
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28499 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 03:22:21 +00:00
Scott Taylor
eef0d99ed8 hackificator doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28497 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:58:28 +00:00
Scott Taylor
afe33f0f68 Add access modifier (public) to methods and members of WP_Upgrader and its subclasses. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28496 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:28:10 +00:00
Scott Taylor
17cabb1d8e Add access modifier (public) to methods and members of WP_Upgrader_Skin and its subclasses. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28495 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:22:55 +00:00
Scott Taylor
b1a09cf65d Add access modifiers to methods and members of WP_Users_List_Table. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28494 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:18:46 +00:00
Scott Taylor
d6a3c2a0de Add access modifiers to methods and members of list table classes: 
* `WP_List_Table` is the base class that implements `__get()` and `__call()` for BC
* Adds unit tests to confirm that subclasses properly inherit magic methods
* Add modifiers to subclasses: `WP_Links_List_Table`, `WP_Media_List_Table`, `WP_MS_Sites_List_Table`, `WP_MS_Themes_List_Table`, `WP_MS_Users_List_Table`, `WP_Plugin_Install_List_Table`, `WP_Plugins_List_Table`, `WP_Posts_List_Table`, `WP_Terms_List_Table`, `WP_Theme_Install_List_Table`, `WP_Themes_List_Table`

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28493 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:16:16 +00:00
Scott Taylor
99c99b77e3 Add access modifier (public) to methods in WP_Importer. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28492 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:19:00 +00:00
Scott Taylor
ae31b3795c Add access modifier (public) to members and methods in WP_Filesystem_SSH2. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28491 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:17:18 +00:00
Scott Taylor
fce8b1e0c3 Add access modifier (public) to members and methods in WP_Filesystem_ftpsockets. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28490 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:13:29 +00:00
Scott Taylor
434ce7f6d8 Add access modifier (public) to members and methods in WP_Filesystem_FTPext. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28489 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:11:21 +00:00
Scott Taylor
ec06d96ce6 Add access modifier (public) to methods in WP_Filesystem_Direct. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28488 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:08:38 +00:00
Scott Taylor
06672a6c5a Add access modifiers to members and methods in WP_Filesystem_Base. Add magic __get() method for backwards compatibility. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28487 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:05:06 +00:00
Scott Taylor
6e09b1f167 Add access modifier (public) to members and methods in WP_Comments_List_Table and WP_Post_Comments_List_Table. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28486 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 23:58:38 +00:00
Scott Taylor
8af8f5f8f2 In edit-link-form.php, hackificator bails because there is a </form> with no open <form>. It exists, but is needlessly constructed with PHP. It always returns a <form>, only the id and name are different. The dynamic piece just returns the ID now. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28485 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 22:06:22 +00:00
Scott Taylor
4f74ef5466 hackificator bails on this file because of mixed quote styles on some HTML attributes. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28484 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 21:47:01 +00:00
Scott Taylor
c6919845ca Remove public keyword from some JS functions. Sorry. 
Props ocean90.
See #22234.



git-svn-id: https://develop.svn.wordpress.org/trunk@28483 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 21:42:32 +00:00
Scott Taylor
01fa4c0c1e hackificator bails on this file because the <meta> isn't self-closing. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28482 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 21:35:03 +00:00
Scott Taylor
e509190fb3 Use proper access modifiers and add a magic __get() method to Custom_Background and Custom_Image_Header. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28481 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 21:30:43 +00:00
Scott Taylor
1b4e4e665a hackificator complains if you call include 'file.php' without the parens, needs to be include( 'file.php' ) 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28479 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 20:51:44 +00:00
Scott Taylor
af0851cc0d Because the WP_ADMIN constant name can be bound in multiple files, all instances should check ! defined first. wp-admin/admin.php already has this check. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28478 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 20:41:28 +00:00
Scott Taylor
f083cc4e9b The About page has a <div> that doesn't close. Also, <hr>s should self-close. hackificator complains about these things. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28477 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 20:32:58 +00:00
Sergey Biryukov
0cc180b0a4 Fix wp_insert_link(), broken in [28406]/[28408]. 
see #22400.

git-svn-id: https://develop.svn.wordpress.org/trunk@28475 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 09:55:16 +00:00
Drew Jaynes (DrewAPicture)
9e81d2d692 Add inline documentation for default arguments in wp_insert_category(). 
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28474 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 07:27:25 +00:00
Sergey Biryukov
d56f67b8e9 Update help text on Add Themes screen. 
props thomasvanderbeek.
fixes #28132.

git-svn-id: https://develop.svn.wordpress.org/trunk@28473 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 23:43:41 +00:00
Scott Taylor
40e6ec443f Add inline comment after fix in [28467]. 
Props jesin.
Fixes #28292.



git-svn-id: https://develop.svn.wordpress.org/trunk@28468 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 15:41:40 +00:00
Scott Taylor
14a7b47119 Restore $soucrce in WP_Upgrader::install_package(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28467 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 15:39:33 +00:00
Scott Taylor
ccc874514c Eliminate use of extract() in request_filesystem_credentials(). 
The only property that doesn't need to be set to a variable is `$password`.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28456 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 18:25:41 +00:00
Andrew Ozz
6fa89637e5 DFW: fix closing only the wpLink or media modal when pressing Esc. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28455 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 18:16:59 +00:00
Scott Taylor
ec17088ff6 Update inline docs for wp_handle_upload|sideload to reflect their non-use of extract(). 
See #22400.



git-svn-id: https://develop.svn.wordpress.org/trunk@28452 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 17:40:44 +00:00
Scott Taylor
8f8b12e6a6 Eliminate use of extract() in wp_handle_sideload(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28451 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 16:14:56 +00:00
Scott Taylor
176d361626 Eliminate use of extract() in wp_handle_upload(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28450 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 16:10:00 +00:00
Sergey Biryukov
6100833f0c DFW: Properly handle Esc key when the content is focused or when switching browser tabs. 
props avryl.
fixes #28279.

git-svn-id: https://develop.svn.wordpress.org/trunk@28443 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 10:42:03 +00:00
wonderboymusic
30dcd2c3e9 Eliminate the use of extract() in WP_Upgrader. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28418 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 05:01:02 +00:00
Scott Taylor
650e0580e4 Eliminate one of the uses of extract() in wp_handle_upload(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28417 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 04:30:32 +00:00
Scott Taylor
219ad73200 Eliminate one of the uses of extract() in wp_handle_sideload(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28416 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 04:28:24 +00:00
Scott Taylor
c4b23f9fc3 Eliminate use of extract() in Walker_Category_Checklist::start_el(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28411 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 03:13:44 +00:00
Scott Taylor
85d6f8e54f Eliminate use of extract() in wp_terms_checklist(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28410 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 03:08:46 +00:00
Scott Taylor
98ca12ef2e Eliminate use of extract() in wp_star_rating(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28409 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:56:56 +00:00
Scott Taylor
5e046b92fd (REALLY) Eliminate use of extract() in wp_insert_link(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28408 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:54:27 +00:00
Scott Taylor
27ff2a1cd0 Eliminate use of extract() in get_media_item(). 
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`	
	
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28407 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:45:01 +00:00
Scott Taylor
e0ddd2ebf0 Eliminate use of extract() in wp_insert_link(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28406 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:27:55 +00:00
Scott Taylor
46f15a84ab Eliminate use of extract() in display_setup_form(). Only needs to read password and password_message. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28396 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-14 16:42:42 +00:00
Drew Jaynes (DrewAPicture)
cfc1b74ddb Properly split and document the admin_post* actions into the following four hooks: 
* `admin_post_nopriv` – for logged-out requests lacking a supplied action
* `admin_post_nopriv_$action – for logged-out requests with a supplied action
* `admin_post` – for logged-in requests lacking a supplied action
* `admin_post_$action` – for logged-in requests with a supplied action

See [28349], [28350], [28351].
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28394 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 07:23:35 +00:00
Drew Jaynes (DrewAPicture)
1954f9b7d4 Clarify inline documentation for back-compat load-* action hooks. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28393 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 06:27:11 +00:00
Scott Taylor
bc17731c23 Eliminate use of extract() in post_tags_meta_box() and post_categories_meta_box(). 
Both functions only need to read `taxonomy`, yet they extract every available variable from `$box['args']`. Even if those variables were useful, there is no attempt to pass them to anything, and scope in PHP does not allow them to be scooped up by inner functions without being passed directly.
	
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28391 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:47:03 +00:00
Scott Taylor
b72bd1c40f Eliminate use of extract() in WP_Terms_List_Table::display_rows_or_placeholder(): 
* Set variables for `$page` and `$number`
* `list(...) = $this->get_column_info()` can be removed, as none of the variables returned are used.
* `orderby` and `search` can be checked from `$args`, leaving no reason to extract		

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28390 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:36:22 +00:00
Scott Taylor
7c0e12f5c6 Eliminate use of extract() in WP_List_Table::pagination(): 
* Set variables instead of extracting `$this->_pagination_args`
* Weird: `$infinite_scroll` is only presently set in subclasses of `WP_List_Table` and never initialized otherwise. 		

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28389 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:26:34 +00:00
Scott Taylor
31e187faa3 Eliminate use of extract() in WP_Plugin_Install_List_Table::get_table_classes(). It only needs to read plural, no need to extract. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28388 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:16:39 +00:00
Scott Taylor
fac2faee93 Eliminate use of extract() in WP_List_Table::ajax_response(): 
* Extracting `$this->_args` is unnecessary since none of the variables produced are present in the method.
* `total_items` and `total_pages` can be read directly from `$this->_pagination_args`

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28387 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:13:09 +00:00
Scott Taylor
a2122e6f7b Eliminate use of extract() in WP_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28386 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:07:11 +00:00
Scott Taylor
878a974477 Eliminate use of extract() in WP_Post_Comments_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary. 
Eliminate use of `extract()` in `WP_Comments_List_Table::display()`. The method uses no variables. Extraction can be completely removed.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28385 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:03:26 +00:00
Scott Taylor
f57bdbd238 Eliminate use of extract() in Custom_Image_Header::step_2(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28384 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:53:13 +00:00
Drew Jaynes (DrewAPicture)
68f78b1dcc Clarify documentation for *what* gets "automatically fired" when the do_mu_upgrade filter evaluates to true in Multisite. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28376 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:17:16 +00:00
Drew Jaynes (DrewAPicture)
d59c371180 Fix incomplete inline documentation for the wp_header_image_attachment_metadata filter. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28375 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:12:02 +00:00
Scott Taylor
4e0809e3e4 Eliminate use of extract() in wp_insert_category(). Adds unit tests. All unit tests pass. 
Props MikeHansenMe.
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28374 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 03:26:51 +00:00
Scott Taylor
3f59b86ec5 In media_upload_gallery_form()'s inline JavaScript, remove unnecessary comment tags. 
Fixes #25637.



git-svn-id: https://develop.svn.wordpress.org/trunk@28368 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 06:11:08 +00:00
Scott Taylor
3a554b5249 In wp_read_image_metadata(), the values from exif_read_data() should only override values from iptcparse() that are empty. 
Props SergeyBiryukov.
Fixes #23706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28367 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 05:53:27 +00:00
Scott Taylor
147eeb2147 Avoid a notice in wp_save_image() by checking $meta['sizes']['thumbnail'] for ! empty() before setting a variable to it. 
Props MikeHansenMe.
Fixes #17736.



git-svn-id: https://develop.svn.wordpress.org/trunk@28366 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 03:41:31 +00:00
Scott Taylor
d007994bf3 In WP_Terms_List_Table::single_row(), call sanitize_term() on the passed term ($tag). 
Props oso96_2000, c3mdigital, scribu. 
It takes a village.
Fixes #16864.


git-svn-id: https://develop.svn.wordpress.org/trunk@28360 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 00:04:38 +00:00
Scott Taylor
a398f38024 First pass at wpview logic for the [embed] shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet. 
Props avryl, wonderboymusic.
See #28195.



git-svn-id: https://develop.svn.wordpress.org/trunk@28358 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-10 23:35:08 +00:00
Drew Jaynes (DrewAPicture)
f3d9e1ed7e Fix mid-file section header style in wp-admin/includes/ajax-actions.php. 
See #28200.


git-svn-id: https://develop.svn.wordpress.org/trunk@28356 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-10 05:01:15 +00:00
Drew Jaynes (DrewAPicture)
de13f1a60c Add baseline doc blocks for all ajax handlers in ajax-actions.php. 
Fixes #28200.


git-svn-id: https://develop.svn.wordpress.org/trunk@28355 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-10 04:59:34 +00:00
Drew Jaynes (DrewAPicture)
0b51b6da2e Minor phpDoc fixes for the got_rewrite, got_url_rewrite, and documentation_ignore_functions hooks. 
Props GaryJ.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28352 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-08 11:12:11 +00:00
Drew Jaynes (DrewAPicture)
272f7533dc Rename the $action hook in wp-admin/admin-post.php to admin_post{$action}. 
Also, clarify documentation of priv vs nopriv prefixing of the hook name.

See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28351 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-08 10:59:17 +00:00
Drew Jaynes (DrewAPicture)
b0d7e6fe3c Revert [28349] in favor of retaining the single dynamic admin_post* hook. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28350 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-08 10:46:41 +00:00
Drew Jaynes (DrewAPicture)
9392b42e97 Convert and rename the $action hook in wp-admin/admin-post to two dynamic hook sets. 
* `admin_post_nopriv{$request_action}` is fired for logged-out users
* `admin_post{$request_action}` is fired for logged-in users

Props Otto42, DrewAPicture.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28349 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-08 10:26:07 +00:00
Drew Jaynes (DrewAPicture)
bbd130fe15 Use interpolation instead of concatenation for the manage_{$screen->id}_columns hook name. 
Props Otto42.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28348 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-08 09:57:11 +00:00
Drew Jaynes (DrewAPicture)
30c21227be Use an interpolated hook name for edit_{$post_type}_per_page instead of $per_page and adjust docs accordingly. 
Also references the correct variable for the `$posts_per_page` parameter in the `edit_posts_per_page` hook doc.

Props Otto42 for the initial patch.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28347 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-08 08:15:48 +00:00
Scott Taylor
7531fd0070 Leverage size_format() when displaying max_upload_size: 
* In `media_upload_form()` 
* The `uploader-inline` Underscore template in the media modal. 

Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.

Fixes #25643.



git-svn-id: https://develop.svn.wordpress.org/trunk@28343 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 18:24:47 +00:00
Scott Taylor
22743ee2c4 In wp-admin/users.php, break is unreachabled after exit. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28315 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:18:12 +00:00
Scott Taylor
64fbddfcd5 In core_upgrade_preamble(), $alternate is set then never used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28314 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:16:34 +00:00
Scott Taylor
cb0578d77e In wp-admin/theme-editor.php, break is unreachabled after exit. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28313 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:15:18 +00:00
Scott Taylor
0f9b925ed5 In wp-admin/post.php, break is unreachabled after exit. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28312 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:14:16 +00:00
Scott Taylor
a9dfbabfe7 In wp-admin/plugins.php, break is unreachabled after exit. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28311 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:12:44 +00:00
Scott Taylor
e742c23af9 In wp-admin/plugin-editor.php, break is unreachabled after exit. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28310 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:11:30 +00:00
wonderboymusic
1da6728dc0 In wp-admin/network/users.php, break is unreachabled after exit. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28309 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:10:01 +00:00
Scott Taylor
aa7cef0549 In wp-admin/network/themes.php, break is unreachabled after exit. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28308 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:07:33 +00:00
Scott Taylor
81acc42361 In wp-admin/link.php, break is unreachabled after exit. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28307 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:05:09 +00:00
Scott Taylor
e1f5876ac4 In display_setup_form(), $admin_password is set and (fortunately) not used or displayed. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28306 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:03:34 +00:00
Scott Taylor
3ed59ca164 In wp-admin/includes/upgrade.php, remove dead code: 
* In `maybe_create_table()` and `maybe_add_column()`, the response of `$wpdb->query()` is set to a variable that is never used.
* In `make_db_current_silent()`, which is a wrapper for `dbDelta`, a variable is set that is not used. This function appears to be a copy-paste of `make_db_current()`'s `dbDelta()` call but is meant to return nothing, and still does not.  

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28305 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 17:26:47 +00:00
Scott Taylor
74ad050063 In wp-admin/includes/update.php, remove dead code: 
* In `get_core_checksums()`, `$return` is set and never used.
* In `core_update_footer()`, `break` is unnecessary and unreachable after `return`.
* In `get_theme_updates()`, `$themes` is set and never used.
* In `wp_theme_update_row()`, `$theme_name` is the only user of `$themes_allowedtags`... neither are used. 	

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28304 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 17:20:10 +00:00
Scott Taylor
fb1054340f In WP_Screen::render_screen_options(), remove dead code: 
* `$wp_list_table` does not need to be imported.
* `$post` is set and never used.

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28303 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 17:13:30 +00:00
Scott Taylor
b64da2cb60 In get_sample_permalink_html(), $view_link is set and never used. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28302 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 17:10:41 +00:00
Scott Taylor
5d2b452351 In install_plugin_information(), $title is set in a foreach loop and never used. This appears to be due to copy-pasting a previous foreach loop and not discarding these bits. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28301 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:59:29 +00:00
Scott Taylor
ffa620b972 In wp-admin/includes/nav-menu.php, remove dead code: 
* In `_wp_ajax_menu_quick_search()`, in an `else` block, `$post_obj` was set and not used. Another block sets it again and does use it. 
* In `wp_nav_menu_item_post_type_meta_box()`, `$post_type_object` was set and, sadly, never used. `$error` was set and not used. 

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28300 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:54:10 +00:00
Scott Taylor
e518d0d652 In update_option_new_admin_email(), $email is set and never used. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28299 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:47:56 +00:00
Scott Taylor
ee13be0315 In attachment_submit_meta_box(), remove dead code: 
* `$action` doesn't need to be imported.
* `$can_publish` is set and never used, which means it doesn't need...
* `$post_type_object` or `$post_type`, which only served `$can_publish`.

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28298 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:44:38 +00:00
Scott Taylor
d92f5aa154 In get_media_item(), $tags and $_tags are set and never used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28297 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:40:52 +00:00
Scott Taylor
fc624a4298 In WP_Users_List_Table::get_views(), $current_role is set and never used. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28296 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 15:32:16 +00:00
Scott Taylor
1e68b7dab4 In WP_MS_Users_List_Table::get_views(), remove dead code: 
* `$wp_roles` doesn't need to be imported.
* `$current_role` is set and never used.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28295 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 15:29:22 +00:00
Dominik Schilling (ocean90)
b09a91a666 Custom Header: Fix logic when a theme doesn't set default-text-color. 
fixes #28042.

git-svn-id: https://develop.svn.wordpress.org/trunk@28294 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 15:26:46 +00:00
Scott Taylor
36abe7909c In WP_Media_List_Table, remove dead code: 
* In `->prepare_items()`, importing `$wpdb` is unnecessary.
* In `->get_columns()`, `$taxonomies` is set twice before it is used.
* In `->display_rows()`, `$taxonomy_object` is set and never used.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28293 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 15:26:32 +00:00
Scott Taylor
41d1eb8f56 In ajax-actions.php, remove dead code: 
* In `wp_ajax_add_tag()`, `$post_type` is set and never used.
* In `wp_ajax_hidden_columns()`, `$hidden` is set twice, but only checks for the existence of `$_POST['hidden']` the first time. The two lines can be combined and work together.
* In `wp_ajax_inline_save()`, `$mode` is set and never used.
* In `wp_ajax_find_posts()`, `$searchand = $search = '';` is leftover cruft, neither variable is used. `$wpdb` does not need to be imported, it is never used.
* In `wp_ajax_wp_fullscreen_save_post()`, `$post_type` is set and never used.
* In `wp_ajax_save_attachment_order()`, `$post` is set and never used.
* In `wp_ajax_send_attachment_to_editor()`, `$title` is set and never used. 

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28292 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 15:18:42 +00:00
Scott Taylor
909d11cd28 Remove unreachable break statements in wp-admin/edit-tags.php. break is unnecessary after die, exit, and wp_die. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28291 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 14:51:47 +00:00
Scott Taylor
88ad28ffdf In wp-admin/custom-header.php, $default_color is set twice before it is used. The first is unnecessary. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28290 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 14:50:05 +00:00
Scott Taylor
ab01399666 Remove unreachable break statements in wp-admin/comments.php. break is unnecessary after die, exit, and wp_die. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28289 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 14:45:22 +00:00
Sergey Biryukov
7f754fa2e8 Translate a string added in 3.7 but never translated previously. 
props andrezrv.
fixes #28025.

git-svn-id: https://develop.svn.wordpress.org/trunk@28288 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 12:48:49 +00:00
Sergey Biryukov
4b8b0e7178 Use a consistent context to remove duplicate strings. 
props pavelevap.
fixes #28123.

git-svn-id: https://develop.svn.wordpress.org/trunk@28287 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 12:33:08 +00:00
Sergey Biryukov
046a2bff94 Add context for 'Previous' and 'Next' theme strings. 
see #28120, for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@28286 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 12:19:41 +00:00
Dominik Schilling (ocean90)
c30bb2fd2b Add missing Dashicons classes to User Admin menu. 
props imath.
see #28144, #26630.

git-svn-id: https://develop.svn.wordpress.org/trunk@28284 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 07:57:52 +00:00
Scott Taylor
555937dc43 In WP_List_Table::display_rows_or_placeholder(), the call to get_column_info() in unnecessary and unused. The call to get_column_count() immediately after makes the same call internally. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28279 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 05:31:07 +00:00
Andrew Nacin
c0822b532e Custom header: Avoid warnings in the process_default_headers() method. 
props obenland.
fixes #27850.


git-svn-id: https://develop.svn.wordpress.org/trunk@28275 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 05:06:39 +00:00
Scott Taylor
f95a4c70be In edit_form_image_editor(), $filename and $title are set and then unused. They shall be removed. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28271 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 04:44:56 +00:00
Andrew Nacin
9259c6baa7 Customizer: Only tie header button action events to the header controls. 
props danielbachhuber.
fixes #28046. see #27848.


git-svn-id: https://develop.svn.wordpress.org/trunk@28269 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 04:29:14 +00:00
Scott Taylor
e42ec45553 Dead code in wp-admin/includes/file.php: 
* In `wp_handle_upload()` and `wp_handle_sideload()`, `$ext` gets conditionally reset... and then is never used.
* In `request_filesystem_credentials()`, `$password` is initialized as an empty string. The variable is never used.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28268 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 04:21:35 +00:00
Scott Taylor
f97deae591 Remove unused variable setting for $revisions in wp_prepare_revisions_for_js(). 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28264 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 03:44:30 +00:00
Scott Taylor
4c6f405ee7 Remove a dead variable, $start, from wp_dashboard_recent_comments(). 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28263 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 03:34:22 +00:00
Andrew Nacin
4b6d5b10d4 Move 'home' option to the top of populate_options(). 
fixes #28141.


git-svn-id: https://develop.svn.wordpress.org/trunk@28260 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 21:56:11 +00:00
Sergey Biryukov
819ad5babc Deprecate unused argument of delete_plugins(). Clarify @return value. 
props jdgrimes for initial patch.
fixes #28111.

git-svn-id: https://develop.svn.wordpress.org/trunk@28256 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 10:23:16 +00:00
Sergey Biryukov
b597b02515 Fix closing tag in image editor. 
props t4k1s.
fixes #28130.

git-svn-id: https://develop.svn.wordpress.org/trunk@28255 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 10:16:14 +00:00
Sergey Biryukov
de80cc6780 Avoid displaying a negative number of plugin updates in admin menu. 
fixes #28073.

git-svn-id: https://develop.svn.wordpress.org/trunk@28254 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 09:38:36 +00:00
Sergey Biryukov
3e482eb905 Use a time constant in get_theme_feature_list() and File_Upload_Upgrader. 
props GaVrA.
fixes #28124.

git-svn-id: https://develop.svn.wordpress.org/trunk@28253 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 08:25:46 +00:00
Dominik Schilling (ocean90)
fe2f5f921e Color Picker: Close color picker when clicking outside of them and when opening another one. 
props mattwiebe.
fixes #25539.

git-svn-id: https://develop.svn.wordpress.org/trunk@28239 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-02 11:17:13 +00:00
Dominik Schilling (ocean90)
a54c311e4f Widgets: Toggle widget arrow when widget is open/closed. 
props MikeHansenMe.
fixes #26748.

git-svn-id: https://develop.svn.wordpress.org/trunk@28235 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-01 14:08:44 +00:00
Dominik Schilling (ocean90)
ed52ae7a3f Quick Draft: Use text cursor for description label. 
fixes #27766.

git-svn-id: https://develop.svn.wordpress.org/trunk@28234 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-01 13:12:01 +00:00
Drew Jaynes (DrewAPicture)
0f759f0c01 Mark the $hook and $page_hook hooks as @internal to skip parsing. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28216 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 07:53:09 +00:00
Drew Jaynes (DrewAPicture)
609cf29058 Clean up duplicate hook notations and adjacency for calls to the wp_signup_location filter. 
Also adds braces missed in [25535].

See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28215 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 07:11:32 +00:00
Drew Jaynes (DrewAPicture)
379f725bde Ensure the wp_edit_nav_menu_walker filter is only documented once. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28213 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:49:48 +00:00
Drew Jaynes (DrewAPicture)
d1137de3de Ensure all duplicate calls of the wp_create_file_in_uploads filter are labeled as such. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28212 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:45:26 +00:00
Drew Jaynes (DrewAPicture)
42d24eebc0 Ensure adjacency of a duplicate hook comment for a the_category filter call. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28211 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:42:21 +00:00
Drew Jaynes (DrewAPicture)
3e2904138e Ensure the submitlink_box action hook is only documented once. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28210 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:34:00 +00:00
Drew Jaynes (DrewAPicture)
7a0eb63a19 Ensure the nav_menu_meta_box_object filter hook is only documented once. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28207 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:13:15 +00:00
Mark Jaquith
c4dd499979 Use '&mdash; Select &mdash;' instead of '-- Select --' for nav menus. Looks nicer. 
see #27878

git-svn-id: https://develop.svn.wordpress.org/trunk@28205 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 00:34:20 +00:00
Andrew Ozz
d19f7a398e Ensure the editor height is saved properly, props jupiterwise, see #28000, for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28193 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-24 04:10:51 +00:00
Andrew Ozz
5bbe3ef38d Fix cursor style for the resize handle of the editor, props avryl, see #27595, for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28186 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-22 21:47:33 +00:00
Helen Hou-Sandi
c4db2733df Don't allow disabled input styling to get lost in the cascade. props ocean90. see #27906 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28179 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-21 20:54:13 +00:00
Helen Hou-Sandi
2344fb91dc Simplify the admin menu notification selector so color schemes don't get stomped. props celloexpressions. see #27920 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28177 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-21 18:54:22 +00:00
Andrew Nacin
77c11f6cc9 Theme Installer: Proper redirection and action links post-install in multisite. 
fixes #27869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28163 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-19 18:17:12 +00:00
Andrew Nacin
47de352468 Use correct echoing context function. see #27889. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28160 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-19 18:08:05 +00:00
Andrew Nacin
cb4f555da4 Context for 'Installed' and 'Already Installed' theme strings. 
props SergeyBiryukov.
see #27889, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28159 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-19 18:07:30 +00:00
Andrew Nacin
fc6d8f705f About page: Don't use wp_playlist_scripts() as that prints stuff. 
fixes #27713.


git-svn-id: https://develop.svn.wordpress.org/trunk@28151 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 17:55:00 +00:00
Andrew Nacin
bd9e4f4f30 Final about page. 
props melchoyce, helen, wonderboymusic, nacin, and the illustrious Michael Pick.
fixes #27713, #27837.


git-svn-id: https://develop.svn.wordpress.org/trunk@28150 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 17:39:18 +00:00
Andrew Nacin
43d194c3b6 Widgets: Better padding for translations of "Reorder". 
fixes #27788.


git-svn-id: https://develop.svn.wordpress.org/trunk@28148 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 13:07:01 +00:00
Andrew Nacin
2d4ea78457 Theme Installer: Properly call router navigation. 
props gcorne.
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@28147 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 03:05:52 +00:00
Andrew Nacin
9720c92028 About page: Use a better preposition to describe drag-and-drop. 
see #27713.


git-svn-id: https://develop.svn.wordpress.org/trunk@28146 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 00:45:34 +00:00
Andrew Nacin
aeef0e992a Translate a string added in 3.7.1 but never translated previously. 
props SergeyBiryukov.
fixes #27819.


git-svn-id: https://develop.svn.wordpress.org/trunk@28145 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 00:37:59 +00:00
Andrew Nacin
6ac55e5a83 Widgets: Remove create_function() from the customizer class. 
props westonruter.
fixes #27805.


git-svn-id: https://develop.svn.wordpress.org/trunk@28143 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 00:10:09 +00:00
Andrew Ozz
48f7c5fce3 TinyMCE: fix icons in IE7, fixes #27829 
git-svn-id: https://develop.svn.wordpress.org/trunk@28142 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 00:09:10 +00:00
Andrew Nacin
68776bd079 Theme Installer: Fixes for browsers without pushState. 
props gcorne.
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@28141 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 00:03:57 +00:00
Dion Hulse
60f6968d80 Background Updates: Avoid a PHP warning during theme update checks when there are multiple theme directories registered. Fixes #27815 
git-svn-id: https://develop.svn.wordpress.org/trunk@28137 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 10:56:56 +00:00
Andrew Nacin
42747be0b2 Fix entities on about page. see #27713. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28136 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 09:21:55 +00:00
Andrew Nacin
0437f710a5 Allow the API to add text to auto update emails. 
fixes #27812.


git-svn-id: https://develop.svn.wordpress.org/trunk@28134 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 08:51:23 +00:00
Andrew Nacin
62a005f254 Fix typo on about page. 
props helen.
see #27713.


git-svn-id: https://develop.svn.wordpress.org/trunk@28133 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 08:25:10 +00:00
Andrew Nacin
fce82f9676 Final about page text. 
props siobhan, kerikae, DH-Shredder, nacin.
see #27713.


git-svn-id: https://develop.svn.wordpress.org/trunk@28132 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 07:52:32 +00:00
Andrew Nacin
606bf33d10 About page design, first pass. 
props melchoyce, ryelle.
see #27713.


git-svn-id: https://develop.svn.wordpress.org/trunk@28127 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 01:30:36 +00:00
Andrew Nacin
7ed14feff1 Theme Installer: Revert to proxying through PHP for WordPress.org API requests. 
This is to ensure we have valid installation nonces, though we've run into this as a problem previously (see #27639, #27581, #27055).

A tad slower, but we gained speed in 3.9 by simplifying the request made to the API.

props ocean90.
fixes #27798.


git-svn-id: https://develop.svn.wordpress.org/trunk@28126 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 01:15:43 +00:00
Andrew Nacin
a8efcb993f Customizer: Properly handle widget settings when activating a previewed theme. 
props westonruter, ocean90, gcorne.
fixes #27767.


git-svn-id: https://develop.svn.wordpress.org/trunk@28124 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 22:45:40 +00:00
Andrew Nacin
b807ab4a34 Theme installer: Improve route handling and make ?theme= work. 
props matveb.
fixes #27708.


git-svn-id: https://develop.svn.wordpress.org/trunk@28123 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 22:05:20 +00:00
Andrew Nacin
7960418895 Color scheme support for widget choosers. 
props ocean90.
fixes #27793.


git-svn-id: https://develop.svn.wordpress.org/trunk@28122 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 20:21:14 +00:00
Andrew Ozz
cd356b6404 DFW: 
- Add background color and remove the top border from the status bar (at the bottom).
- Fix spinner to always be next to the Save button.
- Remove width: auto; from .mce-fixed-width.
Fixes #27709

git-svn-id: https://develop.svn.wordpress.org/trunk@28116 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 08:14:01 +00:00
Andrew Nacin
32721b8347 Avoid stomping of bulk postdata inside the bulk_edit_posts() loop. 
Reverts [27990] which did not fix it for authors and comment/ping status.

props dd32, DrewAPicture.
fixes #27792.


git-svn-id: https://develop.svn.wordpress.org/trunk@28113 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 07:47:10 +00:00
Andrew Ozz
bff230b422 Plupload: restore the settings in media_upload_form(), see #27763 
git-svn-id: https://develop.svn.wordpress.org/trunk@28110 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 00:40:45 +00:00
Andrew Nacin
c43b8b063d Fix feature pointer RTL placement. 
props SergeyBiryukov, ocean90.
fixes #27778.


git-svn-id: https://develop.svn.wordpress.org/trunk@28107 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 23:59:01 +00:00
Andrew Nacin
e7524d0ba7 Theme install: Set a timeout and error message for API responses. 
props ocean90.
fixes #27708.


git-svn-id: https://develop.svn.wordpress.org/trunk@28105 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 19:01:21 +00:00
Andrew Nacin
4c254d8a97 Themes screen: Fix RTL layout issue in Firefox. 
props SergeyBiryukov.
fixes #27779.


git-svn-id: https://develop.svn.wordpress.org/trunk@28104 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 18:25:19 +00:00
Andrew Nacin
e22e40001d Don't auto-resize Quick Draft textarea in IE < 9. Avoids IE8 crash. 
props morganestes.
fixes #27761.


git-svn-id: https://develop.svn.wordpress.org/trunk@28103 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 18:24:25 +00:00
Andrew Nacin
a343c6020a Custom header: Fix image ordering. 
props ehg.
see #21785. fixes #27791.


git-svn-id: https://develop.svn.wordpress.org/trunk@28102 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 18:21:27 +00:00
Andrew Nacin
ffba43a0d9 Fix feature pointer border when using a color scheme. 
props ryelle.
see #27778.


git-svn-id: https://develop.svn.wordpress.org/trunk@28098 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 16:32:39 +00:00
Andrew Nacin
985727f256 RTL for login screen. 
props yoavf.
fixes #27784.


git-svn-id: https://develop.svn.wordpress.org/trunk@28096 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 16:05:16 +00:00
Andrew Nacin
7a25da5240 The widgets pointer requires the edit_theme_options capability. 
(It's hypothetically possible to have only switch_themes.)

see #27777.


git-svn-id: https://develop.svn.wordpress.org/trunk@28093 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 20:52:35 +00:00
Andrew Nacin
a9b0b8cd13 Translate another About string and use _e(). see #27713. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28092 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 20:51:56 +00:00
Andrew Nacin
863116a5d2 Add a feature pointer for widgets in the customizer in 3.9. Remove older pointers from 3.3 and 3.4. 
see #27777.


git-svn-id: https://develop.svn.wordpress.org/trunk@28090 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 20:47:12 +00:00
Andrew Nacin
a1d4430fe0 About page: Translate all Under the Hood strings. 
see #27713.


git-svn-id: https://develop.svn.wordpress.org/trunk@28088 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 19:38:49 +00:00
Andrew Nacin
9defa138a4 Custom Headers: Allow for longer strings. 
props ehg.
see #27755.


git-svn-id: https://develop.svn.wordpress.org/trunk@28086 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 18:39:46 +00:00
Andrew Nacin
6c0420348e Update $_old_files for 3.9. see #27775. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28085 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 18:26:25 +00:00
Drew Jaynes (DrewAPicture)
b5612f8b80 Priority fixes for various existing hook documentation. 
Props kpdesign.
See #26869


git-svn-id: https://develop.svn.wordpress.org/trunk@28083 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 00:00:32 +00:00
Andrew Ozz
33e687ca57 Add the new modlas styling to the importer details Thickbox on Tools -> Import. Props ocean90, fixes #26952 
git-svn-id: https://develop.svn.wordpress.org/trunk@28080 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-11 21:49:18 +00:00
Andrew Ozz
2bde9b5b56 Fix color of disabled buttons in non-default color schemes, props ryelle, fixes #27759 
git-svn-id: https://develop.svn.wordpress.org/trunk@28079 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-11 21:34:14 +00:00
Andrew Nacin
2d9949bf91 Account for new cropping settings in the image editor. 
props Otto42, SergeyBiryukov.
fixes #19393.


git-svn-id: https://develop.svn.wordpress.org/trunk@28072 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-11 03:09:35 +00:00
Andrew Ozz
d3b4c2359a Fix typo in var definition in [28069], see #27750 
git-svn-id: https://develop.svn.wordpress.org/trunk@28070 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-10 22:13:11 +00:00
Andrew Ozz
416b8e348f Fix tabbing out of the title field on Media -> Edit Media screen, fixes #27750 
git-svn-id: https://develop.svn.wordpress.org/trunk@28069 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-10 22:09:50 +00:00
Andrew Ozz
b253355d2c Fix TinyMCE Views in IE8 and 7: 
- Add fallback background images for dashicons.
- Fix hiding the clipboard while still allowing the contents to be selected.
- Work around lack of border-box in gallery styles.
(Includes precommit cleanup for theme.js)
Props gcorne, fixes 27546

git-svn-id: https://develop.svn.wordpress.org/trunk@28062 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-09 00:57:46 +00:00
Andrew Nacin
bef5bdc86a 3.9 about page text, rough cut. 
props markjaquith, nacin.
see #27713.


git-svn-id: https://develop.svn.wordpress.org/trunk@28052 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 17:46:48 +00:00
Andrew Nacin
402bb6208b Don't show featured images for image attachments. Remove abstractions for now. 
fixes #27673.


git-svn-id: https://develop.svn.wordpress.org/trunk@28051 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 17:39:58 +00:00
Andrew Nacin
9fab4162f6 Theme installer keyboard fixes. Updates [28033] and [28036]. 
props matveb.
see #27521.


git-svn-id: https://develop.svn.wordpress.org/trunk@28049 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 16:23:26 +00:00
Dominik Schilling (ocean90)
b48bc8e7d3 Theme Installer: Prevent default events for "Upload Theme" and "Browse" buttons. 
see #27055.

git-svn-id: https://develop.svn.wordpress.org/trunk@28047 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 12:34:10 +00:00
Andrew Ozz
0e44baa89e Precommit cleanup for theme.js, editor.css amd wpdialogs/plugin.js, See #27055, #26907, #16284 
git-svn-id: https://develop.svn.wordpress.org/trunk@28045 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 08:28:57 +00:00
Dominik Schilling (ocean90)
ff78684898 Widget Customizer: Fix widget filtering. 
props westonruter.
fixes #27451.

git-svn-id: https://develop.svn.wordpress.org/trunk@28044 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 08:11:33 +00:00
Andrew Ozz
61d17c2163 DFW: 
- Move the word count and "Just Write" to a fixed bar at the bottom.
- Fix responsive mode to 480px. Narrower screens will have a scroll bar.
- Hide the Help button on screens < 480px, move the Save button to the right, make it bigger to match the others, and other responsive mode fixes.
Fixes #26907, see #27709

git-svn-id: https://develop.svn.wordpress.org/trunk@28043 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 07:48:55 +00:00
Drew Jaynes (DrewAPicture)
93b19f682e Inline documentation for hooks in wp-admin/includes/class-wp-upgrader-skins.php. 
Fixes #27711.


git-svn-id: https://develop.svn.wordpress.org/trunk@28040 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 06:25:56 +00:00
Andrew Nacin
24c0c60802 Theme Installer: Show 'Preview' button for installed themes. 
props adamsilverstein.
see #27055, see #27708.


git-svn-id: https://develop.svn.wordpress.org/trunk@28038 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 04:37:37 +00:00
Andrew Nacin
d5c3a966be Theme Installer: Combine 'Layout' and 'Columns' filters so 'Features' can span two columns. 
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@28037 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 04:30:01 +00:00
Andrew Nacin
62b57b3b1f Theme Installer: Left/right arrow keys in the overlay. 
props adamsilverstein.
see #27521.


git-svn-id: https://develop.svn.wordpress.org/trunk@28036 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 04:12:44 +00:00
nacin
1478afb236 Theme Installer: Use 'browse' instead of 'sort' for routes. 
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@28035 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 04:12:02 +00:00
Andrew Nacin
0cff2558aa Widget Customizer: Fix incorrect replacement in [27995]. 
props westonruter.
fixes #27690.


git-svn-id: https://develop.svn.wordpress.org/trunk@28034 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 04:02:07 +00:00
Andrew Nacin
b47c6d0746 Theme Installer: Disable prev/next buttons on first/last themes, add Esc handling, use IDs. 
props adamsilverstein, DH-Shredder.
fixes #27521.


git-svn-id: https://develop.svn.wordpress.org/trunk@28033 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 03:57:01 +00:00
Andrew Nacin
9875f51f1f Header Images: Add suggested dimensions to the media workflow. 
This updates [28030] to the latest patch.

props gcorne.
see #21785.


git-svn-id: https://develop.svn.wordpress.org/trunk@28031 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 01:56:42 +00:00
Andrew Nacin
d29a5cee5f Header Images: Add suggested dimensions to the media workflow. 
props ehg, gcorne.
see #21785.


git-svn-id: https://develop.svn.wordpress.org/trunk@28030 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 01:54:44 +00:00
Andrew Nacin
1fa68e490b Expose toolbar keyboard shortcut in Help documentation for TinyMCE. 
props joedolson, jorbin.
fixes #27024.


git-svn-id: https://develop.svn.wordpress.org/trunk@28029 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 01:38:42 +00:00
Andrew Nacin
bcc41afd37 Theme Installer: Handle currently installed themes, add search route, let prev/next refresh collections. 
props matveb.
see #27055. fixes #27695.


git-svn-id: https://develop.svn.wordpress.org/trunk@28025 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 23:03:05 +00:00
Dominik Schilling (ocean90)
c80074d551 Widget Customizer: Update icons to new Dashicons, part 2. 
props Michael Arestad.
fixes #27400.

git-svn-id: https://develop.svn.wordpress.org/trunk@28013 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 21:36:52 +00:00
Dominik Schilling (ocean90)
6b007e8345 Widget Customizer: Update icons to new Dashicons. 
props melchoyce.
see #27400.

git-svn-id: https://develop.svn.wordpress.org/trunk@28005 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:49:40 +00:00
Drew Jaynes (DrewAPicture)
4d4921a9ac Use the correct parameter variables in the hook docs for wp_upgrade. 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@27998 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:13:00 +00:00
Drew Jaynes (DrewAPicture)
3b7d881f3c Align parameters in the hook docs for the attachment_thumbnail_args filter. 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@27997 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:10:01 +00:00
Drew Jaynes (DrewAPicture)
95294a170e Add missing parameter descriptions to the PHPDocs for WP_Upgrader_Skin::decrement_update_count() and Bulk_Upgrader_Skin::decrement_update_count(). 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@27996 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:01:35 +00:00
Dominik Schilling (ocean90)
6e3b6066e5 Widget Customizer: Cleanup wp.customize.Widgets.SidebarControl. 
see #27690.

git-svn-id: https://develop.svn.wordpress.org/trunk@27995 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 19:59:49 +00:00
Andrew Nacin
06152cbe6f Avoid stomping of bulk postdata inside the bulk_edit_posts() loop. 
props kovshenin.
see [27964], see #27452.


git-svn-id: https://develop.svn.wordpress.org/trunk@27990 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 17:58:37 +00:00
Dominik Schilling (ocean90)
ce4961c9f7 Widget Customizer: Cleanup wp.customize.Widgets.WidgetControl. 
see #27690.

git-svn-id: https://develop.svn.wordpress.org/trunk@27988 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 16:31:52 +00:00
Dominik Schilling (ocean90)
18d485fb32 Widget Customizer: Make the available widgets panel a Backbone view. 
see #27690.

git-svn-id: https://develop.svn.wordpress.org/trunk@27986 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 14:09:53 +00:00
Dominik Schilling (ocean90)
da677f34aa Widget Customizer: Move WidgetCustomizer to wp.customize.Widgets. First pass. 
see #27690.

git-svn-id: https://develop.svn.wordpress.org/trunk@27985 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 09:03:18 +00:00
Andrew Nacin
3fbe1ba7b7 Apply checks in [27964] to wp_write_post(), which is unused and due for dismantling and deprecation. 
see #27452.


git-svn-id: https://develop.svn.wordpress.org/trunk@27975 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-06 22:07:02 +00:00
Dominik Schilling (ocean90)
2f0a34dbb8 Header images: Improve accessibility of Randomize buttons. 
props ehg.
see #27598, #21785.

git-svn-id: https://develop.svn.wordpress.org/trunk@27970 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-06 19:27:40 +00:00
Dominik Schilling (ocean90)
ab8f7f7afd Widgets: Trigger jQuery events for widget updates. 
* `widget-added` when a widget is added to a sidebar
* `widget-updated` when a widget is updated
A jQuery object of the widget is passed along to the event handler. Same events are used in the Widget Customizer, see [27909].

fixes #19675.

git-svn-id: https://develop.svn.wordpress.org/trunk@27969 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-06 19:05:03 +00:00
Drew Jaynes (DrewAPicture)
789305948e Inline documentation for remaining hooks in wp-admin/includes/upgrade.php. 
Props jackreichert, vancoder.
Fixes #27646.


git-svn-id: https://develop.svn.wordpress.org/trunk@27965 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-05 22:29:41 +00:00
Andrew Nacin
14d96748c7 Better checks for contributors when saving posts. 
props dd32, kovshenin, plocha.
see #27452.


git-svn-id: https://develop.svn.wordpress.org/trunk@27964 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-05 21:18:44 +00:00
Andrew Nacin
12f66b9859 Theme Installer: Separate API from an event handler to avoid issues where a false return value stops the event. 
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@27963 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-05 20:45:37 +00:00
Andrew Nacin
e40de50197 Theme Installer: Don't encode description entities/HTML. 
props johnbillion.
fixes #27641.


git-svn-id: https://develop.svn.wordpress.org/trunk@27962 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-05 20:29:44 +00:00
Andrew Nacin
ba9e3d2bc3 Theme Installer: Use JSONP for api.wordpress.org requests. 
fixes #27639.


git-svn-id: https://develop.svn.wordpress.org/trunk@27961 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-05 20:27:56 +00:00
Andrew Nacin
5863d7874d Theme Installer: Better responsive styles for feature filters. 
props matveb.
fixes #27661.


git-svn-id: https://develop.svn.wordpress.org/trunk@27959 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-05 20:03:41 +00:00
Andrew Nacin
c4d09e4736 Theme Installer: Fix displaying of errors. 
props SergeyBiryukov.
fixes #27640.


git-svn-id: https://develop.svn.wordpress.org/trunk@27958 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-05 19:25:20 +00:00
Andrew Nacin
84c4332b3e RTL: Fix taxonomy quick edit list alignment. 
props SergeyBiryukov.
fixes #27629.


git-svn-id: https://develop.svn.wordpress.org/trunk@27956 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-05 18:13:11 +00:00
Dominik Schilling (ocean90)
8c28ef2b7c Fix typo in hook description for async_upload_{$type}. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27955 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-05 14:11:38 +00:00
Dominik Schilling (ocean90)
fc34a6e63e Customizer: Add height: auto; for select[multiple]. 
fixes #27662.

git-svn-id: https://develop.svn.wordpress.org/trunk@27954 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-05 13:11:39 +00:00
Andrew Ozz
30cdc10180 When autosaving a new post for the first time after a title was typed, cancel the autosave if the user is submitting the form. (Includes a precommit fix for customize-controls.css.) Props Nessworthy, davidmarichal, fixes #27657 
git-svn-id: https://develop.svn.wordpress.org/trunk@27951 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-05 01:28:35 +00:00
Andrew Nacin
6ec7a5a52b Header images: Accessibility and style improvements. Headers no longer jump around when chosen. 
props mcsf, ehg.
see #21785.


git-svn-id: https://develop.svn.wordpress.org/trunk@27947 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-04 15:48:34 +00:00
Andrew Nacin
96e15acb2e Header images: Handle cropping failures. 
props ehg.
see #21785.


git-svn-id: https://develop.svn.wordpress.org/trunk@27946 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-04 15:47:43 +00:00
Andrew Ozz
48269a7c29 TinyMCE: add image backgrounds for more and nextpage tags (also jshint fix for theme.js). Fixes #27106 
git-svn-id: https://develop.svn.wordpress.org/trunk@27944 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-04 05:22:47 +00:00
Andrew Ozz
ec18e88dee TinyMCE: better calculation for editor height when switching Text to Visual and back. Add stopping of editor resizing when the mouse leaves the browser window. See #27279 
git-svn-id: https://develop.svn.wordpress.org/trunk@27941 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-04 01:30:11 +00:00
Andrew Nacin
e8ad1fbf6c Theme Installer: Center spinner, remove plural string. 
fixes #27581. see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@27940 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-04 00:45:13 +00:00
Sergey Biryukov
96563b4143 Clarify tooltips on Edit Image screen. 
props siobhan.
fixes #27651.

git-svn-id: https://develop.svn.wordpress.org/trunk@27939 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-04 00:02:22 +00:00
Sergey Biryukov
a97e9018c4 Fix typo in verify_file_md5() description. see [25541]. 
props siobhan.
see #27651.

git-svn-id: https://develop.svn.wordpress.org/trunk@27938 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-04 00:02:12 +00:00
Andrew Nacin
b29ccb5656 Theme Installer: Fix sorting, counts, keyboard navigation; add prev/next to previews. 
props matveb.
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@27937 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-03 23:52:45 +00:00
Andrew Nacin
e73e290712 Themes: Hide 'Add New' with no JS. see #27055. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27936 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-03 23:05:01 +00:00
Dominik Schilling (ocean90)
d817c574a3 Fix styling for plugin update details Thickbox. 
see #26952.

git-svn-id: https://develop.svn.wordpress.org/trunk@27932 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-03 14:07:42 +00:00
Sergey Biryukov
ed139644be Use multiplication sign instead of a colon for selection size when editing an image. 
props siobhan.
fixes #27652.

git-svn-id: https://develop.svn.wordpress.org/trunk@27931 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-03 09:45:44 +00:00
Andrew Ozz
26391af850 Edit Image modal: 
- Fix issue with adding a link to an image that didn't have one previously.
- Adjust the look-and-feel of the advance options toggle so that it becomes a section heading that can be open/closed.
- Add a Custom Size option to the size drop-down that reveals fields for soft-resizing the image inserted into the post.
Props gcorne, and props sdasse for the design help, see #27366

git-svn-id: https://develop.svn.wordpress.org/trunk@27918 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-03 03:20:40 +00:00
Andrew Nacin
66f20812b9 Remove old links_recently_updated_* DB options that never had a UI. 
fixes #27649.


git-svn-id: https://develop.svn.wordpress.org/trunk@27916 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-03 03:09:59 +00:00
Dominik Schilling (ocean90)
63a83c88f8 Widget Customizer: Restore deferral of previewer-loading class removal until preview is synced. 
props westonruter.
fixes #27635.

git-svn-id: https://develop.svn.wordpress.org/trunk@27913 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-02 19:24:18 +00:00
Dominik Schilling (ocean90)
41c2ce306a Widget Customizer: Don't use opacity for the update spinner. 
`opacity` isn't supported in IE8 and makes the spinner always visible.

see #27485.

git-svn-id: https://develop.svn.wordpress.org/trunk@27912 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-02 19:19:53 +00:00
Dominik Schilling (ocean90)
9f3976baf2 Widget Customizer: Improve support for dynamically-created inputs. 
* Re-work how and when widget forms get updated.
* Replace ad hoc hooks system with jQuery events,
* Add `widget-updated`/`widget-synced` events for widget soft/hard updates.
* Enter into a non-live form update mode, where the Apply button is restored when a sanitized form does not have the same fields as currently in the form, and so the fields cannot be easily updated to their sanitized values without doing a complete form replacement. Also restores live update mode if sanitized fields are aligned with the existing fields again.

Note: jQuery events are *not* final yet, see #19675.

props westonruter.
see #27491.

git-svn-id: https://develop.svn.wordpress.org/trunk@27909 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-02 18:20:00 +00:00
Dominik Schilling (ocean90)
b5780fa7b8 Widget Customizer: Improve plugin compatibility. 
Some plugins are using custom scripts and styles for there widgets. These are available on the Widgets screens, but not in the Customizer yet.
Scripts and styles can be enqueued via: 
* `admin_enqueue_scripts`
* `admin_print_scripts` and `admin_print_scripts-widgets.php`
* `admin_print_styles` and `admin_print_styles-widgets.php`
* `admin_print_footer_scripts` and `admin_footer-widgets.php`
All this hooks are now called in the Customizer too.

Previously we have add the `#widgets-right` ID to a container div via jQuery. Remember: `#widgets-right` exists on the Widgets screen and is used by many plugins to do event delegation from that element.
But since our script files are loaded in the footer, the JavaScript way is a bit late for some plugins.
We have decided to add a `div#widgets-right` container element to customizer. "Less hacky hack."

props westonruter, ocean90. Thanks dpe415 for testing.
fixes #27619.

git-svn-id: https://develop.svn.wordpress.org/trunk@27907 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-02 17:03:14 +00:00
Dion Hulse
48025fabd5 Background Updates: Record Plugin & Theme update statistics like we for for Core updates, Pass Plugin/Theme update objects into the Background updater for consistency with Core & Translations. See #27633 
git-svn-id: https://develop.svn.wordpress.org/trunk@27905 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-02 13:04:30 +00:00
Andrew Ozz
7b272d3a26 Drag and drop files on the editor to upload: add new argument to wp_editor() to enable, fixes #27465 
git-svn-id: https://develop.svn.wordpress.org/trunk@27901 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-02 02:41:24 +00:00
Andrew Ozz
5977c4332e TinyMCE: update to 4.0.21, see #24067 
git-svn-id: https://develop.svn.wordpress.org/trunk@27897 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-01 22:46:00 +00:00
Andrew Nacin
5b4287b991 Theme Installer fixes: 
* Better more filters section. props sonjanyc for some mockups.
 * Better handling of no results.
 * Use # for hrefs.

props matveb.
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@27896 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-01 22:19:51 +00:00
Dominik Schilling (ocean90)
3046451bf7 Cleanup [27892]. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27893 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-01 15:29:34 +00:00
Dominik Schilling (ocean90)
11f6751d51 Widget Customizer: Use postMessage to highlight widgets in preview or sections/controls in Customizer. 
fixes #27622.

git-svn-id: https://develop.svn.wordpress.org/trunk@27892 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-01 15:25:56 +00:00
Dominik Schilling (ocean90)
bb7c7e06c0 Widget Customizer: Remove WidgetCustomizer.showFirstSidebarIfRequested(). 
It's currently unused and needs another iteration.

see #27290.

git-svn-id: https://develop.svn.wordpress.org/trunk@27891 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-01 12:37:43 +00:00
Dominik Schilling (ocean90)
ab5b649243 Revert [27654] for strings. 
props westonruter.
fixes #27485.

git-svn-id: https://develop.svn.wordpress.org/trunk@27890 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-01 11:07:59 +00:00
Drew Jaynes (DrewAPicture)
33acf29a46 Clarify PHPDoc return description for media_handle_upload(). 
Props jdgrimes.
Fixes #27519.


git-svn-id: https://develop.svn.wordpress.org/trunk@27880 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-31 22:32:47 +00:00
Scott Taylor
d8d26a4f79 Cleanup up the display, escaping, and handling of ID3 data for media. Rename wp_get_relevant_id3_keys() to wp_get_attachment_id3_keys(). 
Props nacin.
See #27574.



git-svn-id: https://develop.svn.wordpress.org/trunk@27869 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-31 05:15:39 +00:00
Andrew Nacin
70beef6c31 Use correct formatting function. see [27864], see #27574. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27866 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-30 22:11:58 +00:00
Andrew Nacin
877ffc087f Cleanups for audio/video metadata, see [27862]. 
see #27574.


git-svn-id: https://develop.svn.wordpress.org/trunk@27864 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-30 21:07:04 +00:00
Scott Taylor
2846655164 In wp_generate_attachment_metadata(), when an audio or video files contains upload-able image bits in its ID3 tags, only upload it if the image has not already been uploaded. Determine this by checking for a _cover_hash value in post meta that matches the md5 representation of the bits. 
This prevents uploading an album of 10 songs and subsequently uploading 10 copies of the same album cover.

Props GregLone for the new filter/filter docs: `'attachment_thumbnail_args'`.
Fixes #27573.
 


git-svn-id: https://develop.svn.wordpress.org/trunk@27863 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-30 20:53:21 +00:00
Scott Taylor
149f36ed35 Metadata for audio and video files: 
* Make attachment metadata for audio files editable by providing a metabox on the Edit Media page
* Standardize on using the attachment title everywhere
* Label the Caption and Description fields for audio and video appropriately
* Make the playlist Underscore templates more straightforward

See #27574.



git-svn-id: https://develop.svn.wordpress.org/trunk@27862 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-30 19:27:31 +00:00