f1771073dc
`WP_Date_Query` date validation should not fail for hour = 0.
...
Props ChriCo, tyxla.
Fixes #31067 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@31251 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-20 19:12:48 +00:00
37ea642f69
Twenty Fourteen: fix escaping and minor code style issues. See #29127 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31250 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-20 19:02:53 +00:00
3a87ef36e2
Texturize: Add "em" as a cockney term, so that "'em" is texturized with an apostrophe, instead of an open quote.
...
Fixes #29813 .
Props miqrogroove.
git-svn-id: https://develop.svn.wordpress.org/trunk@31249 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-20 18:43:30 +00:00
d80ca82693
Better loop detection for `_pad_term_counts()`.
...
The `$ancestors` check must be reset for each term in order for term counts
to be correct.
Fixes #20635 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31248 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-19 16:51:44 +00:00
2c955c0bbf
Remove inaccurate part of {$taxonomy}_add_form_fields action description.
...
props joostdekeijzer.
fixes #31052 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31247 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-19 15:30:09 +00:00
5e301c5794
Add missing summaries and descriptions for various functions in wp-admin/includes/upgrade.php.
...
Also generally improve existing parameter, return, and other documentation in various function DocBlocks.
Props morganestes.
Fixes #30825 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31246 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-19 09:14:39 +00:00
032ec0d24a
Remove a stray period introduced in [31242].
...
Props SergeyBiryukov.
See #31048 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31245 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-19 08:46:24 +00:00
b590db9253
Ensure the correct list of default tabs for the Plugin Install screen are documented.
...
Props stevenkword.
Fixes #31017 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31244 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-19 08:43:15 +00:00
73780fdd32
Add more complete documentation for parameters, globals, and return values to the DocBlocks for `remove_shortcode()`, `shortcode_exists()`, and `do_shortcode()`.
...
Props SergeyBiryukov.
Fixes #31048 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31243 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-19 08:39:10 +00:00
596412fb0b
Ensure both parameters and the return for `has_shortcode()` are fully documented.
...
Props cais, SergeyBiryukov
See #31048 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31242 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-19 08:35:05 +00:00
352be0b432
Display correct title in Archives widget if the type of archive was changed using the 'widget_archives_dropdown_args' filter.
...
props floriansimeth for initial patch.
fixes #31024 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31241 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-19 08:25:36 +00:00
4a1cf7a38b
Strip HTML tags when searching for installed themes.
...
props enej, SergeyBiryukov, obenland.
fixes #27561 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31240 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-18 20:39:39 +00:00
a036114a4d
attachment_url_to_postid() should always return an integer.
...
props nathan_dawson, ashfame.
fixes #31044 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31239 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-18 20:32:50 +00:00
a79297ba2d
Minor fix for inline doc syntax in a changelog entry for `wp_get_object_terms()`.
...
See #28688 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31238 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-18 19:04:45 +00:00
fd886b7d60
Add `@since` annotation for 'orderby' values introduced in [31236].
...
See #28688 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31237 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-18 19:02:34 +00:00
9501fb3213
Additional 'orderby' values for `wp_get_object_terms()`.
...
Adds support for ordering by 'taxonomy', 'term_taxonomy_id', and 'parent'.
Props ChriCo.
Fixes #28688 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31236 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-18 18:56:38 +00:00
9ade002c6f
TinyMCE: fix vertical positioning of the image toolbar when there are several instances of the editor. Props avryl, fixes #31028 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31235 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-18 17:55:39 +00:00
2b4099c6bd
Customizer: Replicate behavior from options-reading.php and hide front page options if there are no pages.
...
props Clorith.
fixes #27630 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31234 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-18 06:00:18 +00:00
68283f5fb3
Add unit tests for 'orderby' and 'order' param of `wp_get_object_terms()`.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31233 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 20:38:25 +00:00
c7e95b9433
Correct `wp_get_object_terms()` documentation.
...
The 'orderby' parameter accepts a number of values that have never been
properly documented.
git-svn-id: https://develop.svn.wordpress.org/trunk@31232 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 20:38:20 +00:00
b18ee3334f
Standardize the docblock for `wp_get_object_terms()`.
...
The enumeration of the `$args` parameter has been moved from the long
description to an array hash associated with the proper `@param` attribute.
git-svn-id: https://develop.svn.wordpress.org/trunk@31231 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 20:08:11 +00:00
108e85314b
Move `wp_get_object_terms()` tests into their own file.
...
See #26999 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31230 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 20:08:04 +00:00
658d1bb32e
Add a changelog entry for the new parameter added in [31228].
...
props DrewAPicture.
fixes #31015 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31229 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 17:30:10 +00:00
54f366da0b
Pass $force_reauth value to the 'login_url' filter.
...
props jfarthing84, MikeHansenMe.
fixes #31015 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31228 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 17:19:57 +00:00
3c86263afe
Customizer: Make "Search widgets" input sticky.
...
props celloexpressions.
fixes #30751 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31227 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 13:15:00 +00:00
4c4de36c5c
Customizer: Fix form tag replacement in WP_Customize_Widgets::get_widget_control() after [31200].
...
see #30126 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31226 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 13:10:27 +00:00
6e206c2973
Use the site's local time to create the first post during installation.
...
props extendwings.
fixes #29296 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31225 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 10:06:42 +00:00
e7bf16b423
Introduce has_header_image() to check whether a header image is set.
...
props GunGeekATX, voldemortensen.
fixes #16268 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31224 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 06:33:42 +00:00
f18854e866
Add support for IE conditional comments for WP_Scripts to match the functionality of WP_Styles, including unit tests. Props filosofo, aaroncampbell, ethitter, georgestephanis, valendesigns. Fixes #16024 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31223 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-17 01:36:55 +00:00
5378b4e000
TinyMCE: add breaking out of blockquotes by pressing Enter twice. Togging blockquote on|off with the button and the shortcut is unchanged. Props avryl, fixes #23110 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31222 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 23:35:24 +00:00
cd2d6d27d9
`wp_set_object_terms()` takes `$taxonomy` as a string. Update `@param`.
...
See #30799 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31221 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 23:26:38 +00:00
357fa4131a
Fix some internal types that are passed to functions to avoid changing the acceptable types passed as arguments to those functions:
...
* In `WP_Importer->is_user_over_quota()`, the default value for the first argument for `upload_is_user_over_quota()` is `true`. Don't bother passing `1`.
* When calling `submit_button()` with no `$name`, pass empty string instead of `false`.
* The default value for the 2nd argument to `get_edit_post_link()` is `'display'`. Because PHP is PHP, passing `true` is the same as passing `'display'` or nothing. Don't bother passing `true`.
* In `WP_User_Meta_Session_Tokens::drop_sessions()`, pass `0` instead of `false` to `delete_metadata()` as the value for `$object_id`, which expects an int.
See #30799 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31220 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 22:50:20 +00:00
1d3b42d226
Fix some erroneous `@param` annotations.
...
See #30799 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31219 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 22:43:13 +00:00
5b7baae907
In `get_edit_term_link()`, default to a valid `$object_type`.
...
The $object_type param is used to set the 'post_type' query var, which
determines the post type menu that will be expanded when clicking through to
the term edit page. Not all taxonomies are associated with Posts, so it makes
sense to default to a post_type that the taxonomy is actually associated with.
Props DzeryCZ, juliobox.
Fixes #29251 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31218 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 21:36:12 +00:00
5deee71273
Remove unused local vars in `delete_plugins()`, `delete_theme()`, `WP_Date_Query->validate_date_values()`, `global_terms()`, and `WP_Text_Diff_Renderer_Table->_changed()`.
...
This will clear out the "Unused Code" label in the next Scrutinizer report.
See #30799 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31217 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 21:18:52 +00:00
2ed007c023
Calling `->chown()` and `->chgrp()` in `WP_Filesystem_ftpsockets` produces no side-effects. Remove the calls. `->chgrp()` is defined in the super class, and does nothing, can be removed from the child class.
...
See #30799 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31216 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 21:09:18 +00:00
9a16e6230b
Calling `->chown()` and `->chgrp()` in `WP_Filesystem_FTPext` produces no side-effects. Remove the calls. `->chgrp()` is defined in the super class, and does nothing, can be removed from the child class.
...
See #30799 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31215 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 21:06:29 +00:00
19b4a0053a
Twenty Fifteen: keep sub-menus open when visiting sub-menu pages, to show context when navigating a site.
...
Props jartes, fixes #30722 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31214 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 19:16:56 +00:00
d29abb1d24
By initializing this array before a loop, Scrutinizer reports 0 (zero) "Coding Style" errors.
...
There are plenty of other kinds of errors, but this label will be cleared out.
See #30799 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31213 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 19:12:15 +00:00
5743898e1e
`@param` cleanup:
...
* `get_metadata()` will return literally anything, needs to be `mixed`
* `wp()` and `WP_Query::__construct()` no longer just take a query string
* Clarify a few others
See #30799 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31212 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 19:02:26 +00:00
835dbe7baf
[31210] broke Supportflow on dotorg, which declares these methods as `protected`. Switch to `protected` for the noop methods. The subclasses can make them more visible using `public`.
...
See #30799 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31211 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 18:36:46 +00:00
e3ac341f24
Add 2 noop methods to `WP_List_Table`: `->column_default()` and `->column_cb()`.
...
`WP_List_Table` is essentially an `abstract` class. Some of its methods throw `die()` warnings if they aren't overridden in a child class.
These noop methods wouldn't be `abstract`, because they are not required in subclasses. However, `WP_List_Table` can call these methods in its own method, `->single_row_columns()`, whether a subclass defined them or not.
See #30799 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31210 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 17:41:50 +00:00
07d899740e
In `WP_Filesystem_Base` subclasses that set `$wp_base`, remove this dead code.
...
Unused since [8009] - "Make WP_Filesystem work with new directory constants"
There is currently no declared field and no `@property` annotation.
See #30799 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31209 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 17:22:07 +00:00
b0c6a64fbd
`WP_Filesystem_Base` should declare `$errors` and `$options` as fields for use by subclasses.
...
See #30799 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31208 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 17:09:35 +00:00
60f2983b2e
Bail out of hierarchy loops in `_get_term_children()`.
...
This prevents infinite loops that lead to PHP nesting limit fatal errors.
Props boonebgorges, sgrant.
Fixes #24461 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31207 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 17:09:11 +00:00
8ae64f6384
Bail out of hierarchy loops in `_pad_term_counts()`.
...
Taxonomy hierarchy loops should not occur naturally, but when they do, the
logic of `_pad_term_counts()` could result in infinite loops, leading to
timeouts. We avoid this by breaking when a loop is detected.
Fixes #20635 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31206 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 16:45:21 +00:00
18dbceee8c
Add `<s>` to `$allowedtags` in KSES.
...
From https://developer.mozilla.org/en-US/docs/Web/HTML/Element/s :
"The <strike> element, alter ego of the <s> element is obsolete and should not be used on Web sites any more."
`<strike>` shall remain for BC, but `<s>` should not be stripped from the author (et al) role's HTML input.
Props paulschreiber.
Fixes #30954 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31205 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 16:06:47 +00:00
db1ace58ca
In `comment_form()`, add the HTML5 `required` attribute next to `aria-required` in fields that utilize it.
...
Props MMN-o.
Fixes #24732 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31204 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 15:55:50 +00:00
af146fef8c
In `paginate_links()`, don't override custom format arguments when setting up default 'add_args'.
...
Since 4.1 [29780], the default value of the 'add_args' argument in
`paginate_links()` has been determined by parsing the current URL. This change
had the side effect of overriding custom values of 'format' that changed the
pagination query var, with the result that plugins using `paginate_links()`
with a custom format generated the incorrect links unless explicitly
declaring 'add_args=false' to prevent the default values from overriding. We
fix this behavior by parsing URL query vars into the 'add_args' array only
after the explicit function params have been parsed, and by skipping the
current page's pagination query var when doing this parsing (to avoid the
override).
Props obenland.
Fixes #30831 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@31203 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 15:48:24 +00:00
7c707c6633
Add `@ignore` to `_wp_scripts_maybe_doing_it_wrong()`.
...
Props DrewAPicture for the thought leadership.
See #20513 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31202 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 05:37:06 +00:00
Boone Gorges
Lance Willett
Gary Pendergast
Sergey Biryukov
Drew Jaynes (DrewAPicture)
Andrew Ozz
Scott Taylor