Commit Graph

23429 Commits

Author SHA1 Message Date
Scott Taylor 9dc7afd478 Add `set_current_screen( 'front' )` to `query/conditionals` tests `setUp` routine so that cruff from previous tests doesn't cause every conditional test to fail in debug mode.
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25352 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 17:40:46 +00:00
Scott Taylor d091e1d0b7 Avoid a notice by casting `$args['rewrite']` to `array()` before adding a `slug` property and running `array_merge()`.
Fixes #23668.



git-svn-id: https://develop.svn.wordpress.org/trunk@25351 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 17:17:00 +00:00
Dion Hulse 23d3b372d7 Fix the action that `set_site_transient()` fires so as not to include the private option prefix. This brings set_site_transient() back in line with it's documented behaviour, and the behaviour of all other transient functions. Fixes #25213
git-svn-id: https://develop.svn.wordpress.org/trunk@25350 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 08:45:43 +00:00
Dion Hulse ea6da7d5dc Make use of the mbstring.func_overload helper functions in WP_Filesystem so byte lengths are properly determined. See #25259 Fixes #25237
git-svn-id: https://develop.svn.wordpress.org/trunk@25349 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 08:26:57 +00:00
Dion Hulse 7ebad3db1c Switch WP_HTTP over to using the mbstring.func_overload helper functions. This change moves the check from within the Streaming-handling function to wrap the individual request, this fixes it for both cURL and Streams and any future changes to the transports which use strlen() on binary data. See #25259 See #16057
git-svn-id: https://develop.svn.wordpress.org/trunk@25348 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 08:12:24 +00:00
Dion Hulse 47c25b41af Switch unzip_file() over to using the mbstring.func_override helper functions. See #25259
git-svn-id: https://develop.svn.wordpress.org/trunk@25347 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 08:08:35 +00:00
Dion Hulse 052d276215 Add a set of helpers to turn the behaviour of mbstring.func_overload off when needed. Fixes #25259
git-svn-id: https://develop.svn.wordpress.org/trunk@25346 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 07:22:05 +00:00
Andrew Nacin a1470e6161 Avoid error in ms-files.php after [25317].
git-svn-id: https://develop.svn.wordpress.org/trunk@25344 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 04:48:43 +00:00
Andrew Nacin adf6fab55b Bump version in trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@25343 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 04:19:36 +00:00
Andrew Nacin 1848709736 SimplePie: Fix use of DOMElement as array.
props MikeSchinkel.
fixes #25274.


git-svn-id: https://develop.svn.wordpress.org/trunk@25342 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 04:01:44 +00:00
Andrew Nacin 760e9e02d1 Avoid string offset notices in [25319].
git-svn-id: https://develop.svn.wordpress.org/trunk@25340 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 03:57:00 +00:00
Andrew Nacin 3b314a0adf Improve clarity and speed of [25320].
git-svn-id: https://develop.svn.wordpress.org/trunk@25338 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 03:22:09 +00:00
Andrew Nacin cedb15724a Bump TinyMCE version for [25132]. See #25131.
git-svn-id: https://develop.svn.wordpress.org/trunk@25337 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 02:43:12 +00:00
Scott Taylor 3ee8135baa Don't call `sanitize_title_with_dashes( $taxonomy )` in `register_taxonomy()` unless `$args['rewrite']['slug']` is empty.
Props SergeyBiryukov.
Fixes #23668.



git-svn-id: https://develop.svn.wordpress.org/trunk@25335 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 00:08:04 +00:00
Scott Taylor 0c0c81d81c Add `term_taxonomy_id` to available fields in `get_term_by()`. Adds unit test.
Props jchristopher.
Fixes #21651.



git-svn-id: https://develop.svn.wordpress.org/trunk@25334 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 00:01:19 +00:00
Scott Taylor a963ab0852 Remove dead code in `add_query_arg()`.
Props hakre, c3mdigital.
Fixes #16942.



git-svn-id: https://develop.svn.wordpress.org/trunk@25333 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 23:37:23 +00:00
Scott Taylor 1a46a76c18 Use `wp_get_nav_menus()` instead of `get_terms('nav_menu')` in `WP_Nav_Menu_Widget` to preserve use of `wp_get_nav_menus' filter.
Props Frank Klein.
Fixes #25263.



git-svn-id: https://develop.svn.wordpress.org/trunk@25332 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 23:29:04 +00:00
Scott Taylor d738f5e586 Support `orderby => meta_value` in `WP_User_Query`. Adds unit test.
Props wpsmith.
Fixes #21581.



git-svn-id: https://develop.svn.wordpress.org/trunk@25331 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 23:09:10 +00:00
Scott Taylor 270cc9702d Check `$profileuser->rich_editing` for empty before using it in Edit User admin code.
Props sorich87, c3mdigital.
Fixes #17328.



git-svn-id: https://develop.svn.wordpress.org/trunk@25330 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 22:48:27 +00:00
Scott Taylor c71a0422c0 Add an additional available param (the `WP_User` instance) to the `user_has_cap` filter.
Props Viper007Bond.
Fixes #24490.



git-svn-id: https://develop.svn.wordpress.org/trunk@25329 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 22:22:34 +00:00
Scott Taylor 4fccea305f Add filter `flush_rewrite_rules_hard` to give devs chance to prevent writing to file when hard-flushing rewrite rules.
Props jeremyfelt, nacin.
Fixes #23491.



git-svn-id: https://develop.svn.wordpress.org/trunk@25328 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 22:18:21 +00:00
Scott Taylor a98660d517 Introduce `get_previous_post_link()`, `get_next_post_link()`, and `get_adjacent_post_link()`. Allows developers to retrieve the value without `echo`ing.
Props yoavf, markjaquith, SergeyBiryukov.
Fixes #17302.



git-svn-id: https://develop.svn.wordpress.org/trunk@25327 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 22:11:53 +00:00
Andrew Nacin 9d7689c4ba Loose validation for is_serialized() in maybe_serialize().
git-svn-id: https://develop.svn.wordpress.org/trunk@25320 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 18:09:36 +00:00
Andrew Nacin 0281fc61da Better protocol validation in set_url_scheme().
git-svn-id: https://develop.svn.wordpress.org/trunk@25319 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 18:07:19 +00:00
Andrew Nacin ac3361e997 Validate referrers to prevent off-domain redirects.
git-svn-id: https://develop.svn.wordpress.org/trunk@25318 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 18:06:43 +00:00
Andrew Nacin 31482a7968 Tighten allowed upload file types.
git-svn-id: https://develop.svn.wordpress.org/trunk@25317 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 18:03:26 +00:00
Andrew Nacin 2c0b23557a Ignore user ID post data.
git-svn-id: https://develop.svn.wordpress.org/trunk@25316 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 17:57:14 +00:00
Scott Taylor d141191598 Consistently wrap `author` and `excerpt` nodes with `CDATA` in feeds.
Fixes #18056.



git-svn-id: https://develop.svn.wordpress.org/trunk@25315 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 16:54:16 +00:00
Helen Hou-Sandi 37e5277651 Show the IP address, if available, in the comment edit screen submit meta box. props leewillis77. fixes #24638.
git-svn-id: https://develop.svn.wordpress.org/trunk@25314 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 14:40:15 +00:00
Scott Taylor 5a75531f19 Replace the ancient `phpfreaks.com` RegEx to extract urls to ping with a more robust matcher. URLs with commas and things like `&` were not being pinged. The new matcher even works for most IDN URLs. Adds unit tests.
Fixes #9064.



git-svn-id: https://develop.svn.wordpress.org/trunk@25313 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 03:17:51 +00:00
Scott Taylor e72ffa5d96 Move checks for `post_type` being an array inline. See [25291], [25292], #18614.
git-svn-id: https://develop.svn.wordpress.org/trunk@25312 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 03:01:10 +00:00
Scott Taylor 9ece28e545 Add an action at the end of `WP_Query::parse_tax_query()` called (wait for it...) `parse_tax_query` which will enable developers to alter `$this->tax_query->queries` before SQL is generated. `pre_get_posts` is too early for many scenarios.
git-svn-id: https://develop.svn.wordpress.org/trunk@25311 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 02:35:26 +00:00
Scott Taylor 14e44dcd05 Make sure the queried object is non-null before accessing its properties.
Props markoheijnen, ryan.
Fixes #21394.



git-svn-id: https://develop.svn.wordpress.org/trunk@25310 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 02:27:24 +00:00
Dion Hulse d0a189c6be WP_HTTP: Correct the @since, and, @deprecated PHPDoc tags to reflect the class history. See #25007
git-svn-id: https://develop.svn.wordpress.org/trunk@25309 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-09 08:09:20 +00:00
Dion Hulse 4a56e07c75 Switch to using HTTPS connections for Plugin and Theme API requests when SSL is available. See #18577
git-svn-id: https://develop.svn.wordpress.org/trunk@25308 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-09 07:53:15 +00:00
Dion Hulse 30827b47c1 Upgrader: Deprecate a few mostly unused functions, wp_update_plugin(), wp_update_theme(), and, wp_update_core().
wp_update_core() was still used, as it was never updated to make use of the newer Skins. Fixes #21874


git-svn-id: https://develop.svn.wordpress.org/trunk@25307 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-09 06:44:25 +00:00
Dion Hulse fb20ed8b5b WP_Filesyste: SSH2 PHP Extension support: Fix a case where defining a custom FS_CHMOD_FILE / FS_CHMOD_DIR constant wouldn't take effect due to chmod() failing with a invalid path. Fixes #23589
git-svn-id: https://develop.svn.wordpress.org/trunk@25306 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-09 03:05:01 +00:00
Dion Hulse beaf91c019 WP_Filesystem: Let the code breathe, add some additional whitespace between method definitions and comments.
git-svn-id: https://develop.svn.wordpress.org/trunk@25305 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-09 02:54:50 +00:00
Dion Hulse 2f40784d97 WP_Filesystem: Ensure that all files are read/written correctly by verifying the return values from fwrite() and using FTP_BINARY mode (ASCII converts line endings as per the spec). See #25237
git-svn-id: https://develop.svn.wordpress.org/trunk@25304 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-09 02:42:52 +00:00
Dion Hulse d92f3ab536 WP_HTTP: When streaming to file, ensure that fwrite() suceeds and correctly writes the file to disk. Fixes #16057
git-svn-id: https://develop.svn.wordpress.org/trunk@25303 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-09 01:17:17 +00:00
Sergey Biryukov 22aa493cfc Inline documentation for hooks in http.php.
props tw2113.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25302 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-08 22:03:14 +00:00
Andrew Nacin 7f7aacbdec wp_allowed_protocols() should not contain 'data', as it is not safe. see #19354.
git-svn-id: https://develop.svn.wordpress.org/trunk@25301 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-08 19:41:14 +00:00
Helen Hou-Sandi bde3435a63 Alignment standards for [25296]. props DrewAPicture. see #25171.
git-svn-id: https://develop.svn.wordpress.org/trunk@25300 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 22:06:21 +00:00
Sergey Biryukov 6f6decc3f2 Document 'wp_link_query_args' and 'wp_link_query' filters. props DrewAPicture. fixes #18042.
git-svn-id: https://develop.svn.wordpress.org/trunk@25299 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 19:46:26 +00:00
Sergey Biryukov 8e4a6b31cd Avoid PHP notices when configuring the Incoming Links dashboard widget. fixes #25250.
git-svn-id: https://develop.svn.wordpress.org/trunk@25298 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 18:16:09 +00:00
Helen Hou-Sandi ed6316d44b Add dynamic classes for attachment metadata submitbox sections. see #22333, #25171.
git-svn-id: https://develop.svn.wordpress.org/trunk@25297 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 16:19:39 +00:00
Helen Hou-Sandi e9173ef83b Add `media_submitbox_misc_sections` and `audio_submitbox_misc_sections` filters to allow removing or adding of attachment submitbox sections containing attachment metadata. props desroj, DrewAPicture. fixes #25171.
git-svn-id: https://develop.svn.wordpress.org/trunk@25296 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 16:18:26 +00:00
Sergey Biryukov f9bb59cb30 Clarify a string in discussion settings. props Ipstenu, DrewAPicture. fixes #16705.
git-svn-id: https://develop.svn.wordpress.org/trunk@25295 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 15:35:26 +00:00
Sergey Biryukov c47302e70f Use correct paths in multisite.xml. see [25165]. see #25088.
git-svn-id: https://develop.svn.wordpress.org/trunk@25294 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 15:19:56 +00:00
Sergey Biryukov f6b4d33ae9 Add 'wp_link_query_args' and 'wp_link_query' filters to allow for customizing the internal linking dialog. props CoenJacobs, goldenapples. fixes #18042.
git-svn-id: https://develop.svn.wordpress.org/trunk@25293 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 12:20:57 +00:00