Sergey Biryukov
f3368725ac
Upgrade/Install: In WP_Ajax_Upgrader_Skin
, call ::get_error_codes()
method on a WP_Error
object $this->errors
instead of a string variable $errors
.
...
Props yrpwayne.
Fixes #41449 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41157 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-26 13:38:21 +00:00
Sergey Biryukov
e814f49f74
Users: Use esc_url()
instead of esc_attr()
to escape the value of the srcset
attribute in get_avatar()
.
...
Props joemcgill, henry.wright.
Fixes #41215 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41156 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-26 13:21:37 +00:00
Gary Pendergast
7fc914baa2
REST API: Update the fixture data for wp-api.js
tests.
...
[41139] changed how the REST API URL is generated, but included an incorrect version of `wp-api-generated.js`.
This updates the generator to create the correct `wp-api-generated.js`, and updates ``wp-api-generated.js`.
See #40886 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41154 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-26 03:52:41 +00:00
John Blackbourn
bdc79c0d75
Users: Introduce filters for the contents of email notifications for new user registrations and password resets.
...
Introduces:
* `wp_password_change_notification_subject`
* `wp_password_change_notification_message`
* `wp_password_change_notification_headers`
* `wp_new_user_notification_admin_subject`
* `wp_new_user_notification_admin_message`
* `wp_new_user_notification_admin_headers`
* `wp_new_user_notification_subject`
* `wp_new_user_notification_message`
* `wp_new_user_notification_headers`
Props pbearne, dipesh.kakadiya
Fixes #38068
git-svn-id: https://develop.svn.wordpress.org/trunk@41153 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-26 00:53:21 +00:00
Sergey Biryukov
817e0c1eb7
I18N: Use a consistent context for Visual and Text editor tab labels.
...
Props pedromendonca.
Fixes #41438 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41152 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-25 22:57:16 +00:00
Sergey Biryukov
e8f7df4669
Docs: Use 3-digit, x.x.x style semantic versioning for @since 4.8.0
entries.
...
See #41017 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41151 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-25 22:47:27 +00:00
John Blackbourn
850940a7f7
Users: Show a Super Admin
label next to Super Admins on all user listing screens when the current user can manage network users.
...
Fixes #41165
git-svn-id: https://develop.svn.wordpress.org/trunk@41150 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-25 17:42:14 +00:00
Andrea Fercia
765445ee61
Widgets: make the Recent Posts widget output '(no title)' for posts without a title.
...
Since WordPress 2.3, the Recent Posts widget used to output the post ID for posts
with an empty title. Using '(no title)' seems a best option and is consistent with
what's already used in other similar cases.
Props antonrinas, Ankit K Gupta.
Fixes #35709 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41149 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-25 16:12:29 +00:00
Andrea Fercia
5de0d45b90
Administration: WP_Screen: strip all tags from the columns display name.
...
This ensures all the column titles, not just the Comments column one, are
"clean" when later reused for the Screen Options checkboxes. Also introduces
some consistency with what is already done in WP_List_Table.
Fixes #41261 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41148 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-25 16:04:50 +00:00
Sergey Biryukov
5508cdedba
Docs: Correct @global
entry for $cat_id
in WP_Links_List_Table::column_categories()
.
...
Props tejas5989.
Fixes #41436 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41147 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-25 13:18:20 +00:00
Sergey Biryukov
c0346dc748
Docs: Add a @global
entry for $wpdb
in _get_cron_lock
.
...
Props tejas5989.
Fixes #41433 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41146 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-25 12:55:34 +00:00
Sergey Biryukov
280163f8ef
Docs: Add @access
entry for WP_Comment_Query::fill_descendants()
.
...
Props umangvaghela123.
Fixes #41435 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41145 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-25 12:53:36 +00:00
Weston Ruter
cacfda71c4
TinyMCE: Fix styling of selected state for linked images containing captions.
...
Props azaozz.
Fixes #41408 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41141 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-25 02:18:32 +00:00
Gary Pendergast
029ce05801
REST API: Always add index.php
to the REST URL when pretty permalinks are disabled.
...
When pretty permalinks are disabled, the web server will internally forward requests to `index.php`. Unfortunately, nginx only forwards HTTP/1.0 methods: `PUT`, `PATCH`, and `DELETE` methods will return a 405 error.
To work around this nginx behaviour, including `index.php` in the REST URL skips the internal redirect.
Fixes #40886 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41139 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-25 00:49:22 +00:00
John Blackbourn
44491ba49f
Users: Ensure that users with no role on a site are taken into consideration when listing users on Multisite.
...
This ensures that users who are a member of a site but have no role are correctly listed on the Users screen and can be filtered from the 'None' role filter.
Props tobi823, flixos90, scottlee
Fixes #36196
git-svn-id: https://develop.svn.wordpress.org/trunk@41138 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-25 00:23:44 +00:00
Weston Ruter
06160eb060
Customize: Update Text widget starter content to utilize visual mode.
...
Amends [38991].
Props dlh, westonruter.
See #35243 , #38114 .
Fixes #41410 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41136 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-24 23:24:36 +00:00
Weston Ruter
021dcb13a1
Widgets: Improve notice in Text widget's legacy mode.
...
Also fixes phpunit test which broke in [41132].
Props melchoyce, westonruter, gk.loveweb.
See #41394 , #35243 , #40951 , #40907 .
Fixes #41386 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41134 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-24 23:10:06 +00:00
Weston Ruter
0cfe1b9136
Widgets: Rename Text widget's legacy
mode to non-visual
mode, restore boolean filter
prop, and improve compatibility for widget_text
filters applied in Custom HTML widget.
...
Props westonruter, obenland, timmydcrawford for testing.
Amends [41050].
See #35243 , #40951 , #40907 .
Fixes #41394 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41132 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-24 22:45:55 +00:00
John Blackbourn
0fdf7fdebf
Networks and Sites: Introduce an AYS when bulk deleting sites from the Sites screen in Network Admin.
...
Props flixos90, MaximeCulea
Fixes #41177
git-svn-id: https://develop.svn.wordpress.org/trunk@41131 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-24 22:40:12 +00:00
John Blackbourn
7a965fcfe6
Comments: Ensure the correct comment ID is passed to the get_comment_author_url
filter.
...
Props dominik.schwind
Fixes #41334
git-svn-id: https://develop.svn.wordpress.org/trunk@41127 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-24 22:02:45 +00:00
Sergey Biryukov
a661557bce
Docs: Correct @access
entry for ::load()
in WP_Image_Editor
, WP_Image_Editor_GD
, and WP_Image_Editor_Imagick
.
...
Props upadalavipul.
Fixes #41423 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41125 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-24 14:10:45 +00:00
Sergey Biryukov
cf84ec6a30
Tests: Fix typo in Tests_Functions_AllowedProtocols::data_example_urls()
.
...
Props redrambles.
Fixes #41415 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41124 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-24 10:02:52 +00:00
Sergey Biryukov
3f30fd2866
Docs: Add a @global
entry for $wpdb
in WP_Comment_Query::fill_descendants()
.
...
Props jontyravi.
Fixes #41412 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41123 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-23 10:39:13 +00:00
John Blackbourn
90583c8360
Users: Don't show the 'Add Existing User' form on the 'Add New User' screen to users without the promote_users
capability.
...
Props bseddon, Mista-Flo
Fixes #37836
git-svn-id: https://develop.svn.wordpress.org/trunk@41122 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-23 01:13:13 +00:00
John Blackbourn
5f9b52df35
Login and Registration: Correctly encode the redirect location URL when it's passed as a query parameter to the lost password URL.
...
Props adhun
Fixes #40728
git-svn-id: https://develop.svn.wordpress.org/trunk@41121 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-23 01:05:08 +00:00
John Blackbourn
384ac2a367
Administration: Send an appropriate HTTP response status code when an invalid action is passed to admin-ajax.php
.
...
Props ryanrolds, ayeshrajans
Fixes #41269
git-svn-id: https://develop.svn.wordpress.org/trunk@41120 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-23 00:20:37 +00:00
John Blackbourn
28e67acdce
Docs: Correct some inline docs for the Ajax test case.
...
See #41017
git-svn-id: https://develop.svn.wordpress.org/trunk@41119 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-23 00:01:39 +00:00
Weston Ruter
94d95184b0
Widgets: Fix typo in phpunit test for Custom HTML widget in [41116].
...
Fixed was applied in 4.8 branch via [41117].
See #41392 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41118 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-21 21:21:29 +00:00
Weston Ruter
36c2f88a60
Widgets: Include widget_text
class name on Custom HTML widget wrapper for theme styling compatibility, in addition to previously-added textwidget
class on nested content container.
...
Amends [40893], [41115].
See #40907 .
Fixes #41392 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@41116 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-21 21:01:45 +00:00
Weston Ruter
642693bb91
Widgets: Improve theme styling compatibility for Custom HTML widget by adding container with textwidget
class.
...
The same styling from the Text widget should apply to the Custom HTML widget since users are expected to copy HTML from the (legacy) Text widget into the latter.
Amends [40893].
See #40907 .
Fixes #41392 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41115 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-21 18:12:43 +00:00
Sergey Biryukov
bece1ff7a5
Docs: Correct $term_id
parameter description in wp_xmlrpc_server::get_term_custom_fields()
and ::set_term_custom_fields()
.
...
Props upadalavipul.
Fixes #41397 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41114 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-21 13:39:59 +00:00
Sergey Biryukov
668d465aa3
Docs: Add @staticvar
entries for $cache
and $tested_paths
in wp_upload_dir()
.
...
Props ajayghaghretiya1.
Fixes #41395 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41113 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-21 10:14:09 +00:00
K. Adam White
79bbfd19c9
WP-API JS Client: Interpret Settings resource as a model.
...
The REST API does not provide a mechanism to distinguish between endpoints representing models and those representing collections, so the Backbone client must make that distinction internally. Previously wp-api.js accounted for `/users/me`, but not for `/settings`. This patch updates the logic so that `/settings` is properly registered as a Backbone model.
When calling `wp.api.init`, additional endpoints can be specified to be models using the `modelEndpoints` argument.
Props @adamsilverstein.
Fixes #41056 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41112 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-20 20:25:28 +00:00
Sergey Biryukov
c66c90a438
Docs: Add a @global
entry for $wpdb
in get_author_user_ids()
, get_editable_authors()
, get_editable_user_ids()
, get_nonauthor_user_ids()
, and get_others_unpublished_posts()
.
...
Props parthsanghvi.
Fixes #41368 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41111 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-20 14:01:39 +00:00
Sergey Biryukov
6ac73689f4
Docs: Add a @global
entry for $wp_filesystem
in wp_ajax_install_theme()
, wp_ajax_update_theme()
, wp_ajax_delete_theme()
, wp_ajax_install_plugin()
, wp_ajax_update_plugin()
, and wp_ajax_delete_plugin()
.
...
Props ronakganatra.
Fixes #41382 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41110 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-20 13:46:14 +00:00
Sergey Biryukov
3f38a85894
Docs: Add @staticvar
entries for get_html_split_regex()
and _get_wptexturize_split_regex()
.
...
Props ajayghaghretiya1.
Fixes #41385 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41109 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-20 13:37:19 +00:00
Sergey Biryukov
06f6f249bc
Docs: Add @access
entries for WP_Upgrader_Skin::set_upgrader()
, ::request_filesystem_credentials()
, and ::decrement_update_count()
.
...
See #41383 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41108 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-20 13:34:07 +00:00
Sergey Biryukov
f62453c06f
Docs: Add @access
entry for Automatic_Upgrader_Skin::request_filesystem_credentials()
.
...
Props rushabh4486.
Fixes #41383 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41107 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-20 13:32:19 +00:00
Sergey Biryukov
078f396b17
Docs: Add @access
entries for Bulk_Upgrader_Skin::before()
and ::after()
.
...
Props rushabh4486.
Fixes #41384 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41106 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-20 13:24:05 +00:00
Sergey Biryukov
6229dd05b5
Docs: Change @version
entry for WP_Http::buildCookieHeader()
to @since
.
...
See #41381 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41105 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-20 13:14:50 +00:00
Sergey Biryukov
c6ba869397
Docs: Add @access
entries for WP_Http::block_request()
, ::handle_redirects()
, and ::is_ip_address()
.
...
Props ronakganatra.
Fixes #41381 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41104 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-20 13:13:09 +00:00
Sergey Biryukov
2a4d33f2c6
Docs: Add @access
entries for before()
and after()
methods in Bulk_Plugin_Upgrader_Skin
and Bulk_Theme_Upgrader_Skin
.
...
See #41365 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41103 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-20 12:08:19 +00:00
Sergey Biryukov
977c0592e0
Docs: Add @access
entries for __construct()
in WP_Upgrader_Skin
, Bulk_Upgrader_Skin
, Language_Pack_Upgrader_Skin
, Plugin_Upgrader_Skin
, and Theme_Upgrader_Skin
.
...
Props rushabh4486.
Fixes #41376 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41102 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-20 12:05:34 +00:00
Sergey Biryukov
d27ac87b78
Docs: Add @access
entries for feedback()
and error()
methods in WP_Upgrader_Skin
, Bulk_Upgrader_Skin
, and Language_Pack_Upgrader_Skin
.
...
See #41365 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41101 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-20 11:59:16 +00:00
Sergey Biryukov
dbfa71a638
Docs: Add @access
entries for $admin_header_callback
and $admin_image_div_callback
properties in Custom_Image_Header
and Custom_Background
.
...
Props rushabh4486.
Fixes #41377 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41100 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-20 11:53:15 +00:00
Sergey Biryukov
348073994e
Docs: Correct @access
entry for Custom_Image_Header::default_headers
.
...
Props rushabh4486.
Fixes #41378 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41099 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-20 11:47:34 +00:00
James Nylen
df386b41a9
About page: Add a privacy policy.
...
Props MattyRob, johnbillion, swissspidy.
Fixes #40794 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41096 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-19 21:41:13 +00:00
Weston Ruter
6e30e93d7f
Widgets: Improve Text widget's reliability in syncing Visual tab's contents with Text tab and with hidden sync inputs.
...
Amends [40631].
Props azaozz, westonruter, rinkuyadav999 for testing.
See #35243 .
Fixes #40974 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@41094 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-19 20:48:28 +00:00
Andrew Ozz
8dcb1d0b39
TinyMCE: remove unused code from the wpeditimage
plugin.
...
Fixes #41369 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41092 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-19 13:40:31 +00:00
Sergey Biryukov
f2adcb8e52
Docs: Add @access
entry for Automatic_Upgrader_Skin::feedback()
.
...
Props akbarhusen.
Fixes #41365 .
git-svn-id: https://develop.svn.wordpress.org/trunk@41091 602fd350-edb4-49c9-b593-d223f7449a82
2017-07-19 11:13:19 +00:00