Commit Graph

21238 Commits

Author SHA1 Message Date
Andrew Nacin
f9d1ca1da4 Only unset() after we have confirmed we are not dealing with a WP_Error. props DH-Shredder. fixes #22824.
git-svn-id: https://develop.svn.wordpress.org/trunk@23133 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-09 17:02:22 +00:00
Andrew Nacin
26bb121ddf 3.5-RC5
git-svn-id: https://develop.svn.wordpress.org/trunk@23131 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 23:01:31 +00:00
potbot
45ac1f7e10 POT, generated from r23127
git-svn-id: https://develop.svn.wordpress.org/trunk@23130 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 21:19:19 +00:00
potbot
7773021895 POT, generated from r23127
git-svn-id: https://develop.svn.wordpress.org/trunk@23129 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 21:19:13 +00:00
potbot
a19e5b1809 POT, generated from r23127
git-svn-id: https://develop.svn.wordpress.org/trunk@23128 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 21:19:05 +00:00
bumpbot
168fdca8e2 Compress scripts/styles: 3.5-RC4-23127.
git-svn-id: https://develop.svn.wordpress.org/trunk@23127 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 21:00:25 +00:00
Andrew Nacin
04cb50e1ce Remove 'Insert Multiple Images' from the about page as it is now completely invisible in the UI. Requiring shift-click but not mentioning it is a bad omen. props helenyhou. fixes #22455.
git-svn-id: https://develop.svn.wordpress.org/trunk@23126 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 20:58:34 +00:00
Andrew Nacin
45699e974c Bump the versions for Twenty Ten, Twenty Eleven, and Twenty Twelve.
git-svn-id: https://develop.svn.wordpress.org/trunk@23125 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 20:43:34 +00:00
Daryl Koopersmith
c5eee310f4 Trailing commas make IE7 cry. fixes #22819.
git-svn-id: https://develop.svn.wordpress.org/trunk@23124 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 20:42:10 +00:00
Andrew Nacin
8198998a83 Ensure [23122] gets parsed as context. props TobiasBg. fixes #22808.
git-svn-id: https://develop.svn.wordpress.org/trunk@23123 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 18:50:16 +00:00
Andrew Nacin
53f230b982 Update fullscreen/DFW's "Text" tab to match the string context used for the editor Text tab. Not a string change. props pavelevap, fixes #22808.
git-svn-id: https://develop.svn.wordpress.org/trunk@23122 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 18:36:15 +00:00
bumpbot
be03cb514b Compress scripts/styles: 3.5-RC4-23121. TinyMCE updated.
git-svn-id: https://develop.svn.wordpress.org/trunk@23121 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 11:41:16 +00:00
Andrew Nacin
66f1a19089 Add a sane, inclusive HTML element/attribute schema to TinyMCE.
TinyMCE 3.4.x (shipped with WordPress 3.4.x) had an HTML4-based schema definition, with HTML5 elements added to it. TinyMCE 3.5.x (shipping, again coincidentally, with WordPress 3.5) allows for HTML5 schema support, which also provides for full HTML5 attribute support. The problem is its HTML5 schema excludes all HTML4 elements and attributes that were dropped in the HTML5 spec, which is unacceptable behavior.

This "duck punch" of TinyMCE's Schema.js file creates a new, sane schema. It is TinyMCE's HTML4 and HTML5 schema definitions recursively merged.

Objects are not whitelisted in either schema to allow for embed elements as child nodes, so object, param, and embed remain separately whitelisted in the WordPress TinyMCE plugin. Our attempts to add other attributes in said plugin is now superceded.

props koopersmith, azaozz.
fixes #22790.



git-svn-id: https://develop.svn.wordpress.org/trunk@23120 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 11:26:25 +00:00
Andrew Nacin
35edf3665d Add TinyMCE 3.5.8's Schema.js file in preparation for monkey patching it. see #22790.
git-svn-id: https://develop.svn.wordpress.org/trunk@23119 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 11:12:51 +00:00
Daryl Koopersmith
c2ad016631 Ensure iframes in the media modal on the frontend have no borders. props nacin. fixes #22804.
git-svn-id: https://develop.svn.wordpress.org/trunk@23118 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 10:27:07 +00:00
Ryan Boren
9575d68a6a Make current_user_can_for_blog() safe to run single site.
Props nacin, MarkJaquith
fixes #22803


git-svn-id: https://develop.svn.wordpress.org/trunk@23117 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 09:53:27 +00:00
Lance Willett
7d904038e9 Twenty Twelve: set color values to black to ensure full text color contrast in print styles. Props miqrogroove, fixes #22797.
git-svn-id: https://develop.svn.wordpress.org/trunk@23116 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 01:38:57 +00:00
bumpbot
77d453ddea Compress scripts/styles: 3.5-RC4-23115.
git-svn-id: https://develop.svn.wordpress.org/trunk@23115 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 01:15:44 +00:00
Andrew Nacin
844c3f322d Remove trailing comma from JS. props koopersmith, fixes #22800.
git-svn-id: https://develop.svn.wordpress.org/trunk@23114 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 01:13:04 +00:00
bumpbot
412a605ecf Compress scripts/styles: 3.5-RC4-23113. TinyMCE updated.
git-svn-id: https://develop.svn.wordpress.org/trunk@23113 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 00:07:33 +00:00
Ryan Boren
ce2720984b Extend allowed elements for object and embed.
Props azaozz
fixes #22790


git-svn-id: https://develop.svn.wordpress.org/trunk@23112 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 00:05:54 +00:00
bumpbot
01259734c2 Compress scripts/styles: 3.5-RC4-23111.
git-svn-id: https://develop.svn.wordpress.org/trunk@23111 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 23:17:49 +00:00
Ryan Boren
a0a13a3fc4 When inserting from URL in the media modal, retain query params and properly insert the caption code.
Props koopersmith
fixes #22796


git-svn-id: https://develop.svn.wordpress.org/trunk@23110 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 23:12:59 +00:00
Andrew Nacin
556664dd07 Final screenshot on the about page for the media manager.
props lessbloat.
props matt for the photos.

fixes #22455.



git-svn-id: https://develop.svn.wordpress.org/trunk@23109 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 19:49:42 +00:00
Andrew Nacin
a3222c1926 3.5-RC4.
git-svn-id: https://develop.svn.wordpress.org/trunk@23108 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 09:45:32 +00:00
Andrew Nacin
2583123273 Use $current_site->path instead of $base in wpmu_validate_blog_signup(), as $base is now dead. props MarkJaquith. fixes #22787. see #19796.
git-svn-id: https://develop.svn.wordpress.org/trunk@23107 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 09:43:52 +00:00
Andrew Nacin
110c7769e5 Rip keyboard shortcuts out of the image editor help. props helenyhou. fixes #22786.
git-svn-id: https://develop.svn.wordpress.org/trunk@23106 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 09:21:27 +00:00
Andrew Nacin
24027fdcd7 A neditor is a curious multi-celled organism found deep in the Content Management System "WordPress". It generally subsides on good content. It has an obsession with retina-quality graphical elements, and also has a strong affinity for puns. Occasionally, ACCIDENTAL CAPS LOCK occurs. Some organisms carry British accents; these are prone to changing state but then reverting to their previous state soon after. One has shown superior sleuthing abilities, despite having hardly left its Uni laboratory. Organisms from Australia are usually found deeper in the Content Management System, most of its energy spent on locomotion.
The attitude of a neditor is best described as cranky optimism. Younger organisms are more eager, but quickly tire after working on little sleep. They eventually evolve into the cranky optimism stage in a process that generally takes three to five months.



git-svn-id: https://develop.svn.wordpress.org/trunk@23105 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 09:01:11 +00:00
bumpbot
789be95446 Compress scripts/styles: 3.5-RC3-23104.
git-svn-id: https://develop.svn.wordpress.org/trunk@23104 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 08:13:44 +00:00
Andrew Nacin
2413f5f58e Image editors: After cropping, request new sizes from the image. If we rely on the values passed in, they may be floats. We must see what the image results in.
Cast in update_size() for sanity.

props DH-Shredder.
fixes #22779.



git-svn-id: https://develop.svn.wordpress.org/trunk@23103 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 07:56:04 +00:00
Lance Willett
ca2f9a9bab Twenty Twelve: fix skewed gallery thumbnail images in IE8 by adding selectors to match attachment thumbnails and any mix-and-match of full-size and large-size image that may occur in content. Fixes #22782.
git-svn-id: https://develop.svn.wordpress.org/trunk@23102 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 07:16:31 +00:00
Andrew Nacin
b540525589 Break wp_print_media_templates() into wp-includes/media-template.php and lazy-load that file through wp_enqueue_media(). fixes #22778.
git-svn-id: https://develop.svn.wordpress.org/trunk@23101 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 07:10:20 +00:00
Andrew Nacin
3403c1d157 Properly apply CSS and an ID attribute to the select files container. props koopersmith. fixes #22780. see #22762.
git-svn-id: https://develop.svn.wordpress.org/trunk@23100 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 07:00:41 +00:00
bumpbot
66f7523e43 Compress scripts/styles: 3.5-RC3-23099.
git-svn-id: https://develop.svn.wordpress.org/trunk@23099 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 06:58:33 +00:00
Andrew Nacin
b186d63721 Media: When the attachment details view changes to another view or attachment, save compat fields on destroy. (We already do this for non-compat fields.) props koopersmith. fixes #22776.
git-svn-id: https://develop.svn.wordpress.org/trunk@23098 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 06:56:06 +00:00
Mark Jaquith
affd3a9a98 Remove the "Describe this ___" string on captions in the attachment details view. WP <3 patches with net red. props helenyhou. fixes #22777
git-svn-id: https://develop.svn.wordpress.org/trunk@23097 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 06:35:13 +00:00
Mark Jaquith
6247c1289c Present the correct downsized image dimensions in the Media modal when inserting. Introduces a context parameter for image_constrain_size_for_editor() instead of relying on is_admin(). props jond3r, nacin. fixes #22738
git-svn-id: https://develop.svn.wordpress.org/trunk@23096 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 06:25:39 +00:00
Mark Jaquith
e0f5f47c57 Add the ability to click "Edit" and kick out to the advanced image editor from within the Media modal. New window, with "Refresh" offered on your return. fixes #22743. props koopersmith, nacin, helenyhou.
git-svn-id: https://develop.svn.wordpress.org/trunk@23095 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 05:52:19 +00:00
Mark Jaquith
93442c1773 Run the attachment_fields_to_save filter even if we don't get the fields we used to get. props nacin. fixes #22774
git-svn-id: https://develop.svn.wordpress.org/trunk@23094 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 05:34:17 +00:00
bumpbot
40dad409f4 Compress scripts/styles: 3.5-RC3-23093.
git-svn-id: https://develop.svn.wordpress.org/trunk@23093 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 05:26:39 +00:00
Daryl Koopersmith
a4f2112fd3 Add a canonical location for media frames, an alias to fetch attachments, and frame caching to custom header. fixes #22775.
git-svn-id: https://develop.svn.wordpress.org/trunk@23092 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 05:06:49 +00:00
bumpbot
21f933625f Compress scripts/styles: 3.5-RC3-23091. TinyMCE updated.
git-svn-id: https://develop.svn.wordpress.org/trunk@23091 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 04:58:34 +00:00
Andrew Ozz
b0cd25962e Upgrade to TinyMCE 3.5.8, fixes #22755
git-svn-id: https://develop.svn.wordpress.org/trunk@23090 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 04:50:31 +00:00
Mark Jaquith
d801545ff6 New method of managing media selections. There is now a "master" selection in the background. props koopersmith. fixes #22725
* This especially helps when you switch between insert/gallery and have non-images selected (as galleries don't support non-images).
* The views now act as filters on the "master" selection, instead of having their own selections that get passed around.

git-svn-id: https://develop.svn.wordpress.org/trunk@23089 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 03:55:37 +00:00
Andrew Nacin
90e5fd56c0 Fix branchhing in edit_post() where attachment_fields_to_save would only run when the alt text was sent. It should run whenever an attachment is saved. props sc0ttclark. fixes #22774.
git-svn-id: https://develop.svn.wordpress.org/trunk@23088 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 03:50:31 +00:00
Andrew Nacin
dc3a34b19b Restore captions for non-image attachments. see #22759.
git-svn-id: https://develop.svn.wordpress.org/trunk@23087 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 03:36:17 +00:00
Daryl Koopersmith
f82ed67255 Add hidden fields via attachment_fields_to_edit to the existing compat output. props nacin. fixes #22769.
git-svn-id: https://develop.svn.wordpress.org/trunk@23086 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 03:28:21 +00:00
Daryl Koopersmith
977deb7d63 Do not alter the body's overflow attribute when the media modal is opened. Fix image insertion in the visual editor in Firefox. props azaozz. fixes #22765.
git-svn-id: https://develop.svn.wordpress.org/trunk@23085 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 03:15:39 +00:00
bumpbot
2255750962 Compress scripts/styles: 3.5-RC3-23084.
git-svn-id: https://develop.svn.wordpress.org/trunk@23084 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 00:42:44 +00:00
Andrew Nacin
1cc12103f5 Restore the Description field to the media UI in 3.5.
We tried in vain -- a noble but ultimately failed effort -- to reduce the number of fields for attachments from four (title, caption, alt, description) to one (caption for images, title otherwise). Alternative text needed to stay for accessibility reasons, of course.

Eventually title returned due to heavy plugin reliance. Description is too used by too many plugins (often times incorrectly -- the caption is more likely the proper field), hence its less-than-triumphant return today.

Version 3.5 has tried to streamline media in a number of ways. Removing fields may have been too much at once, as it forced not only a user interface change, but a paradigm change as well.

Finally, on upload we populate the description field with IPTC/EXIF captions, rather than the caption field. See #22768, this should be fixed. For now, Description stays.

This commit also restores 'Title' attribute editing to the main tab of the Edit Image dialog. The "Title" field no longer populates title attributes for <img> tags by design (for accessibility and other purposes, see #18984). So, here is a more obvious 'workaround' for the tooltip community.

Finally, this:
 * Cleans up the post.php attachment editor, including by showing a prettier form of the mime type.
 * Enables plugins to specifically hide attachment_fields_to_edit from either post.php (where you can create meta boxes) or the modal (which you may not want to clutter), for compatibility reasons.
 * Hides the 'Describe this file...' placeholder when a field is read-only in the modal.

props nacin, helenyhou.
fixes #22759.



git-svn-id: https://develop.svn.wordpress.org/trunk@23083 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 00:41:06 +00:00