sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
40,913 Commits 2 Branches 473 Tags 137 MiB
Commit Graph

40913 Commits

Author SHA1 Message Date
Sergey Biryukov f9e52f8cd3 Docs: Synchronize `@return` descriptions for `::handle_row_actions()` methods in list tables. 
Make sure `WP_Comments_List_Table::handle_row_actions()` and `WP_MS_Sites_List_Table::handle_row_actions()` return a string, for consistency with other classes.

See #49170, #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47059 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-11 17:56:15 +00:00
Sergey Biryukov 1824604fc0 Docs: Correct `@return` description for `WP_List_Table::handle_row_actions()`. 
Props pbiron.
Fixes #49170.

git-svn-id: https://develop.svn.wordpress.org/trunk@47058 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-11 17:55:49 +00:00
Sergey Biryukov 5dbe5a8355 Docs: Correct `@return` type for `Theme_Upgrader::check_parent_theme_filter()`. 
Props diddledan.
Fixes #48570.

git-svn-id: https://develop.svn.wordpress.org/trunk@47057 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-11 02:44:17 +00:00
Sergey Biryukov 4a854cd44f Docs: Remove a reference to WordPress 2.7 from `readme.html`. 
Props afercia, donmhico.
Fixes #47963.

git-svn-id: https://develop.svn.wordpress.org/trunk@47056 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-10 14:03:50 +00:00
Sergey Biryukov 32ccb24cb0 Docs: Remove `@return void` from widget DocBlocks. 
Per the documentation standards, it should not be used outside of the default bundled themes.

See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47055 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-10 00:28:10 +00:00
Sergey Biryukov f243dc38c0 Coding Standards: Use strict comparison and Yoda conditions in the root directory files. 
Props pikamander2.
Fixes #48965.

git-svn-id: https://develop.svn.wordpress.org/trunk@47054 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-09 00:53:29 +00:00
Jonathan Desrosiers 424071a2b6 Bundled Themes: Remove duplicate `font-size` property in Twenty Twenty. 
Props ankitmaru.
Fixes #49015.



git-svn-id: https://develop.svn.wordpress.org/trunk@47053 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-08 16:48:43 +00:00
Sergey Biryukov 90db6f5941 Docs: Correct alphabetic order of parameters in `WP_Query::parse_query()` DocBlock. 
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47052 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-08 12:08:49 +00:00
Jorge Costa e02ebc183b Block Editor: Update WordPress Packages. 
Updated packages:
@wordpress/annotations: 1.7.2 -> 1.9.0
@wordpress/api-fetch: 3.6.4 -> 3.8.0
@wordpress/block-directory: 1.0.5 -> 1.2.0
@wordpress/block-editor: 3.2.5 -> 3.4.0
@wordpress/block-library: 2.9.6 -> 2.11.0
@wordpress/blocks: 6.7.2 -> 6.9.0
@wordpress/components: 8.3.2 -> 8.5.0
@wordpress/compose: 3.7.2 -> 3.9.0
@wordpress/core-data: 2.7.5 -> 2.9.0
@wordpress/data: 4.9.2 -> 4.11.0
@wordpress/data-controls: 1.3.4 -> 1.5.0
@wordpress/date: 3.5.0 -> 3.7.0
@wordpress/dom: 2.5.2 -> 2.6.0
@wordpress/e2e-test-utils: 3.0.0 -> 4.0.0
@wordpress/edit-post: 3.8.6 -> 3.10.0
@wordpress/editor: 9.7.6 -> 9.9.0
@wordpress/element: 2.8.2 -> 2.10.0
@wordpress/escape-html: 1.5.1 -> 1.6.0
@wordpress/format-library: 1.9.5 -> 1.11.0
@wordpress/i18n: 3.6.1 -> 3.7.0
@wordpress/keycodes: 2.6.2 -> 2.7.0
@wordpress/list-reusable-blocks: 1.8.4 -> 1.10.0
@wordpress/media-utils: 1.2.4 -> 1.4.0
@wordpress/notices: 1.8.2 -> 1.10.0
@wordpress/nux: 3.7.2 -> 3.9.0
@wordpress/plugins: 2.7.2 -> 2.9.0
@wordpress/rich-text: 3.7.2 -> 3.9.0
@wordpress/scripts: 6.0.0 -> 6.1.1
@wordpress/server-side-render: 1.3.4 -> 1.5.0
@wordpress/shortcode: 2.4.1 -> 2.5.0
@wordpress/token-list: 1.6.1 -> 1.8.0
@wordpress/url: 2.8.2 -> 2.9.0
@wordpress/viewport: 2.8.2 -> 2.10.0

Props gziolo, youknowriad.
Fixes #49142.

git-svn-id: https://develop.svn.wordpress.org/trunk@47051 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-08 11:55:03 +00:00
Sergey Biryukov 7b0f5e5de8 Coding Standards: Use Yoda conditions in `wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php`. 
Props jenilk.
Fixes #49150.

git-svn-id: https://develop.svn.wordpress.org/trunk@47050 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-08 11:30:37 +00:00
Sergey Biryukov 6bf5238ebb Docs: Indicate that `load_script_textdomain_relative_path` filter value can be `false`. 
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47049 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-08 00:25:04 +00:00
Grzegorz (Greg) Ziółkowski 01a3632b15 Build Tools: do not include assets for JS dependencies that do not exist. 
This is a follow-up for #48154, where we started including *.asset.php files to declare package dependencies.
This works well but creates warnings in environments where the package does not exist because WordPress was not fully built.

Props jeherve, swissspidy.

Fixes #49144.



git-svn-id: https://develop.svn.wordpress.org/trunk@47048 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-07 15:26:44 +00:00
Sergey Biryukov 638a948719 Site Health: Make sure the "Copied!" text is vertically centered to the "Copy site info to clipboard" button. 
Props garrett-eclipse.
Fixes #49139.

git-svn-id: https://develop.svn.wordpress.org/trunk@47047 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-07 00:07:53 +00:00
Sergey Biryukov f216d9c73a REST API: Display the actual conflicting value in addition to the taxonomy name in the `_doing_it_wrong()` message for a conflicting `rest_base` or `name` property. 
Follow-up to [47037] and [47045].

Props TimothyBlynJacobs.
See #48401.

git-svn-id: https://develop.svn.wordpress.org/trunk@47046 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-06 17:07:52 +00:00
Sergey Biryukov 105375cce7 REST API: Display the taxonomy name in the `_doing_it_wrong()` message for a conflicting `rest_base` or `name` property, to match the translator comment. 
Follow-up to [47037].

See #48401.

git-svn-id: https://develop.svn.wordpress.org/trunk@47045 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-06 16:45:58 +00:00
Sergey Biryukov 6cd0e35c6b I18N: Replace `rest_authentication_errors` filter name with a placeholder in a translatable string. 
Follow-up to [38947] and [40038].

See #38446.

git-svn-id: https://develop.svn.wordpress.org/trunk@47044 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-06 16:19:51 +00:00
Sergey Biryukov b459cddeaf I18N: Replace `php.ini`, `post_max_size`, and `upload_max_filesize` with placeholders in "File is empty" error message. 
Props ramiy.
Fixes #48868.

git-svn-id: https://develop.svn.wordpress.org/trunk@47043 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-06 16:14:30 +00:00
Dominik Schilling 086ae28f0e Docs: Remove duplicate inline comment in `wp_mail()`. 
See [5639].
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47042 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-06 14:49:13 +00:00
Sergey Biryukov cd5b7df8b8 Docs: Improve documentation for `tests/phpunit/includes/testcase-ajax.php`. 
Props andizer, SergeyBiryukov.
Fixes #47568.

git-svn-id: https://develop.svn.wordpress.org/trunk@47041 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-05 15:31:10 +00:00
Dominik Schilling 5f600eb32a Media: After [46375], enable JavaScript translations for the `media-views` script. 
See #49134.

git-svn-id: https://develop.svn.wordpress.org/trunk@47040 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-05 13:09:52 +00:00
Sergey Biryukov 50ed776846 Docs: Fix typo in `media_post_single_attachment_fields_to_edit()` description. 
Props mukesh27.
Fixes #49131.

git-svn-id: https://develop.svn.wordpress.org/trunk@47039 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-04 17:58:37 +00:00
Sergey Biryukov 0a6720af6b Coding Standards: Add missing braces to `if` conditions in `js/_enqueues/wp/customize/base.js`. 
Props ankitmaru.
Fixes #49122.

git-svn-id: https://develop.svn.wordpress.org/trunk@47038 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-04 01:26:26 +00:00
K. Adam White 746502eaa9 REST API: Issue doing_it_wrong if a taxonomy's specified rest_base is already in use by a different resource. 
Props fgiannar, TimothyBlynJacobs, kingkool68, SergeyBiryukov.
Fixes #48401.



git-svn-id: https://develop.svn.wordpress.org/trunk@47037 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-03 19:22:32 +00:00
K. Adam White 172e0b01c6 REST API: Short-circuit comment controller permissions check if commented-upon post type does not exist. 
Props imani3011, dragosh635, subrataemfluence, timothyblynjacobs.
Fixes #42238.



git-svn-id: https://develop.svn.wordpress.org/trunk@47036 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-03 18:42:09 +00:00
Grzegorz (Greg) Ziółkowski a35e46a937 Build Tools: Integrate DependencyExtractionWebpackPlugin in the JS build. 
This patch integrates DependencyExtractionWebpackPlugin which was battle-tested in Gutenberg. 

This will greatly simplify the process of upgrading npm packages which change after every Gutenberg release. It might even useful during the WordPress release cycle as we might need to publish more often as we discover critical bugs and regressions.

Props jonsurrell, adamsilverstein, youknowriad, ocean90, netweb.

Fixes #48154. 



git-svn-id: https://develop.svn.wordpress.org/trunk@47035 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-03 13:15:33 +00:00
Sergey Biryukov c27ab74ca9 REST API: Synchronize permission checks in `::get_items_permissions_check()` methods for post types, post statuses, and users: 
* Only query post types with `'show_in_rest' => true` instead of looping over all post types and checking the `show_in_rest` property separately.
* Return from the `foreach()` loop as soon as the permission check succeeded.

Props pbiron, TimothyBlynJacobs, SergeyBiryukov.
Fixes #49118.

git-svn-id: https://develop.svn.wordpress.org/trunk@47034 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-03 02:26:36 +00:00
Sergey Biryukov adb9483563 Link Manager: Use a strict `in_array()` check in `wp-links-opml.php`. 
Props dkarfa.
Fixes #49106.

git-svn-id: https://develop.svn.wordpress.org/trunk@47033 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-03 01:12:13 +00:00
Sergey Biryukov b773334bf2 Docs: Synchronize "Default empty array" notes for `$args` parameter in `get_comment_text()` and `comment_text()`. 
Props denisco.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47032 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-02 19:20:33 +00:00
Sergey Biryukov 10d4ad91b0 Site Health: Fix typo in a variable name in `js/_enqueues/admin/site-health.js`. 
Props nickylimjj.
Fixes #49112.

git-svn-id: https://develop.svn.wordpress.org/trunk@47031 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-02 12:09:27 +00:00
Sergey Biryukov 83defdf556 Coding Standards: Move assignment out of condition in `js/media/controllers/library.js`. 
Props ankitmaru.
Fixes #49108.

git-svn-id: https://develop.svn.wordpress.org/trunk@47030 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-02 12:05:29 +00:00
Sergey Biryukov aaee49fb63 Coding Standards: Move assignment out of condition in `js/media/views/settings.js`. 
Props ankitmaru.
Fixes #49107.

git-svn-id: https://develop.svn.wordpress.org/trunk@47029 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-02 12:00:11 +00:00
Sergey Biryukov f4346b9da6 Coding Standards: Use strict comparison in `wp-comments-post.php`. 
Props dkarfa.
Fixes #49105.

git-svn-id: https://develop.svn.wordpress.org/trunk@47028 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-02 11:40:11 +00:00
Sergey Biryukov 3e47858a53 Coding Standards: Use strict comparison and Yoda conditions in `wp-includes/widgets.php`. 
Props jenilk.
Fixes #49104.

git-svn-id: https://develop.svn.wordpress.org/trunk@47027 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-02 11:35:55 +00:00
Sergey Biryukov f4a8e840af Happy New Year! 
Update copyright year to 2020 in bundled themes' `readme.txt`.

git-svn-id: https://develop.svn.wordpress.org/trunk@47026 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-01 03:51:29 +00:00
Sergey Biryukov 7bd615730d Happy New Year! 
Update copyright year to 2020 in `license.txt`.

git-svn-id: https://develop.svn.wordpress.org/trunk@47025 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-01 02:17:53 +00:00
Sergey Biryukov c9a366e857 Docs: Fix typo in `_crop_image_resource()` DocBlock. 
Props mukesh27.
Fixes #49103.

git-svn-id: https://develop.svn.wordpress.org/trunk@47024 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-31 12:32:19 +00:00
Sergey Biryukov ae53e417d5 Docs: Add missing descriptions and `@return` tags for `_WP_Editors::get_mce_locale()` and `::get_baseurl()`. 
Props adnan.limdi.
Fixes #41869.

git-svn-id: https://develop.svn.wordpress.org/trunk@47023 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-31 01:29:42 +00:00
Sergey Biryukov fa0feb0cff Docs: Add missing `@since` tags for `wp-includes/class-wp-editor.php`. 
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47022 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-31 01:23:11 +00:00
Sergey Biryukov e2748f44f4 Docs: Fix typo in `.env` file description. 
Props mujuonly, dkarfa.
Fixes #49095.

git-svn-id: https://develop.svn.wordpress.org/trunk@47021 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-30 13:46:17 +00:00
Sergey Biryukov 7b3483c866 Coding Standards: Fix WPCS issue in [47019]. 
See #49091.

git-svn-id: https://develop.svn.wordpress.org/trunk@47020 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-29 22:30:26 +00:00
Sergey Biryukov 1dfd6c5168 Twenty Twenty: Remove extra space from `arrow-down-circled` icon name in `TwentyTwenty_SVG_Icons::$ui_icons`. 
Props kitchin.
Fixes #49091.

git-svn-id: https://develop.svn.wordpress.org/trunk@47019 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-29 20:43:04 +00:00
Sergey Biryukov ef6973b7f0 Bootstrap/Load: Make handling the `/favicon.ico` requests more flexible. 
Previously, `wp_favicon_request()` was introduced in [13205] to avoid a performance hit of serving a full 404 page on every favicon request.

While working as intended, that implementation did not provide a way for theme or plugin authors to manage the behavior of favicon requests.

This changeset implements the following logic (only applied if WordPress is installed in the root directory):

* If there is a Site Icon set in Customizer, redirect `/favicon.ico` requests to that icon.
* Otherwise, use the WordPress logo as a default icon.
* If a physical `/favicon.ico` file exists, do nothing, let the server handle the request.

Handling `/favicon.ico` is now more consistent with handling `/robots.txt` requests.

New functions and hooks:

* Introduce `is_favicon()` conditional tag to complement `is_robots()`.
* Introduce `do_favicon` action to complement `do_robots` and use it in template loader.
* Introduce `do_favicon()` function, hooked to the above action by default, to complement `do_robots()`.
* Introduce `do_faviconico` action to complement `do_robotstxt`, for plugins to override the default behavior.
* Mark `wp_favicon_request()` as deprecated in favor of `do_favicon()`.

Props jonoaldersonwp, birgire, joostdevalk, mukesh27, SergeyBiryukov.
Fixes #47398.

git-svn-id: https://develop.svn.wordpress.org/trunk@47018 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-28 21:18:03 +00:00
Sergey Biryukov 85c7a64791 Docs: Improve `@return` description for `wp_update_comment()` and `WP_UnitTest_Factory_For_Comment::update_object()`. 
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47017 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-27 00:28:39 +00:00
Sergey Biryukov 004023d493 Coding Standards: Fix WPCS issue in [47015]. 
See #49082.

git-svn-id: https://develop.svn.wordpress.org/trunk@47016 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-26 15:51:33 +00:00
Sergey Biryukov c231e66c0a Docs: Fix typo in `wp_dashboard_cached_rss_widget()` documentation. 
Props mukesh27.
Fixes #49082.

git-svn-id: https://develop.svn.wordpress.org/trunk@47015 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-26 14:40:10 +00:00
Sergey Biryukov 079580a6b7 Tests: Set `network_id` instead of `site_id` in `WP_UnitTest_Factory_For_Blog` defaults. 
Follow-up to [47011], [47013].

See #47195.

git-svn-id: https://develop.svn.wordpress.org/trunk@47014 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-26 00:25:20 +00:00
Sergey Biryukov 93eeb8f1d7 Tests: Update legacy arguments passed to `WP_UnitTest_Factory_For_Blog::create_object()`. 
This converts the arguments originally meant for `wpmu_create_blog()` to the ones used by `wp_insert_site()`.

Follow-up to [47011].

Fixes #47195.

git-svn-id: https://develop.svn.wordpress.org/trunk@47013 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-25 21:39:46 +00:00
Sergey Biryukov f8051662b1 Tests: Replace most instances of `wpmu_delete_blog()` not specifically testing that function with `wp_delete_site()`. 
Follow-up to [47011].

See #47195.

git-svn-id: https://develop.svn.wordpress.org/trunk@47012 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-25 18:15:13 +00:00
Sergey Biryukov ebe75fb903 Tests: Switch `WP_UnitTest_Factory_For_Blog::create_object()` to use `wp_insert_site()`. 
Map some arguments for backward compatibility with `wpmu_create_blog()` previously used there.

Props davidbaumwald, danielbachhuber, jeremyfelt, SergeyBiryukov.
See #47195.

git-svn-id: https://develop.svn.wordpress.org/trunk@47011 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-25 18:10:19 +00:00
Sergey Biryukov dbf6a0ba7c Media: Make sure `attachment_url_to_postid()` performs a case-sensitive search for the uploaded file name. 
Previously, the first available match was returned, regardless of the case, which was not always the expected result.

Props archon810, ben.greeley, tristangemus, vsamoletov, SergeyBiryukov.
Fixes #39768.

git-svn-id: https://develop.svn.wordpress.org/trunk@47010 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-25 02:24:38 +00:00