sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
40,913 Commits 2 Branches 473 Tags 137 MiB
Commit Graph

6578 Commits

Author SHA1 Message Date
Sergey Biryukov f9e52f8cd3 Docs: Synchronize `@return` descriptions for `::handle_row_actions()` methods in list tables. 
Make sure `WP_Comments_List_Table::handle_row_actions()` and `WP_MS_Sites_List_Table::handle_row_actions()` return a string, for consistency with other classes.

See #49170, #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47059 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-11 17:56:15 +00:00
Sergey Biryukov 1824604fc0 Docs: Correct `@return` description for `WP_List_Table::handle_row_actions()`. 
Props pbiron.
Fixes #49170.

git-svn-id: https://develop.svn.wordpress.org/trunk@47058 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-11 17:55:49 +00:00
Sergey Biryukov 5dbe5a8355 Docs: Correct `@return` type for `Theme_Upgrader::check_parent_theme_filter()`. 
Props diddledan.
Fixes #48570.

git-svn-id: https://develop.svn.wordpress.org/trunk@47057 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-11 02:44:17 +00:00
Sergey Biryukov 638a948719 Site Health: Make sure the "Copied!" text is vertically centered to the "Copy site info to clipboard" button. 
Props garrett-eclipse.
Fixes #49139.

git-svn-id: https://develop.svn.wordpress.org/trunk@47047 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-07 00:07:53 +00:00
Sergey Biryukov b459cddeaf I18N: Replace `php.ini`, `post_max_size`, and `upload_max_filesize` with placeholders in "File is empty" error message. 
Props ramiy.
Fixes #48868.

git-svn-id: https://develop.svn.wordpress.org/trunk@47043 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-06 16:14:30 +00:00
Sergey Biryukov 50ed776846 Docs: Fix typo in `media_post_single_attachment_fields_to_edit()` description. 
Props mukesh27.
Fixes #49131.

git-svn-id: https://develop.svn.wordpress.org/trunk@47039 602fd350-edb4-49c9-b593-d223f7449a82
 2020-01-04 17:58:37 +00:00
Sergey Biryukov c9a366e857 Docs: Fix typo in `_crop_image_resource()` DocBlock. 
Props mukesh27.
Fixes #49103.

git-svn-id: https://develop.svn.wordpress.org/trunk@47024 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-31 12:32:19 +00:00
Sergey Biryukov 004023d493 Coding Standards: Fix WPCS issue in [47015]. 
See #49082.

git-svn-id: https://develop.svn.wordpress.org/trunk@47016 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-26 15:51:33 +00:00
Sergey Biryukov c231e66c0a Docs: Fix typo in `wp_dashboard_cached_rss_widget()` documentation. 
Props mukesh27.
Fixes #49082.

git-svn-id: https://develop.svn.wordpress.org/trunk@47015 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-26 14:40:10 +00:00
Sergey Biryukov 67502b3dcd Docs: Correct the note about the `CORE_UPGRADE_SKIP_NEW_BUNDLED` constant in `$_new_bundled_files` global description. 
In order to tell WordPress not to install new bundled themes on update, `CORE_UPGRADE_SKIP_NEW_BUNDLED` should be set to `true`, as the name suggests, not `false`.

Follow-up to [39064].

Props tomgreer, knutsp, crdunst.
See #49056.

git-svn-id: https://develop.svn.wordpress.org/trunk@47007 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-23 17:58:02 +00:00
Sergey Biryukov c273108570 Docs: Improve documentation for admin menu functions: 
* `get_admin_page_parent()`
* `get_admin_page_title()`
* `get_plugin_page_hook()`
* `get_plugin_page_hookname()`
* `user_can_access_admin_page()`

Add missing descriptions and `@since` tags.

Props subrataemfluence, kennithnichol, stevenlinx, SergeyBiryukov.
Fixes #44253, #49067.

git-svn-id: https://develop.svn.wordpress.org/trunk@47006 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-23 14:34:10 +00:00
Sergey Biryukov 56e338c132 Upgrade/Install: When creating the `.htaccess` file in `insert_with_markers()`, make sure it has `0644` as a minimum set of permissions. 
Props rcutmore, dd32, i3anaan.
Fixes #40572.

git-svn-id: https://develop.svn.wordpress.org/trunk@47005 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-22 02:43:30 +00:00
Sergey Biryukov d592888f36 Users: When creating the first user on installation, populate the Website profile field with the site URL. 
Skip setting the field if the user already exists, which is the case when the user tables are being shared among multiple sites.

Props EFAREM, eclare, darrenlambert, zachflauaus, viralsampat.
Fixes #35778.

git-svn-id: https://develop.svn.wordpress.org/trunk@46989 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-18 02:24:05 +00:00
Sergey Biryukov ed3e924683 Upgrade/Install: Remove unused global in `upgrade_430_fix_comments()`. 
Props adnan.limdi.
Fixes #41970.

git-svn-id: https://develop.svn.wordpress.org/trunk@46972 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-17 16:43:22 +00:00
Andrew Ozz 5e813adcdc Fix the colors in all color schemes for the `.active` class for buttons. 
Props ryelle, audrasjb.
Fixes #49003 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@46967 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-17 00:13:47 +00:00
Sergey Biryukov 8a88cfac42 Coding Standards: Use strict comparison in `wp-admin/widgets.php`. 
Props jenilk.
Fixes #49000.

git-svn-id: https://develop.svn.wordpress.org/trunk@46964 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-16 12:53:59 +00:00
Sergey Biryukov 2a8f0cb9e0 Coding Standards: Use strict comparison in `wp-admin/includes/network.php`. 
Props ataurr.
Fixes #48994.

git-svn-id: https://develop.svn.wordpress.org/trunk@46963 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-16 12:35:26 +00:00
Sergey Biryukov 3b25bc4362 Coding Standards: Use strict comparison in `wp-admin/edit-tags.php`. 
Props passoniate.
Fixes #48985.

git-svn-id: https://develop.svn.wordpress.org/trunk@46962 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-15 10:44:37 +00:00
Sergey Biryukov ee4f57d509 Coding Standards: Use strict comparison in `wp-admin/term.php`. 
Props vinita29.
Fixes #48983.

git-svn-id: https://develop.svn.wordpress.org/trunk@46961 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-15 09:43:08 +00:00
Sergey Biryukov 5e840c755e I18N: Replace file names in translatable strings on Permalink Settings screen with placeholders. 
Props ramiy.
Fixes #48863.

git-svn-id: https://develop.svn.wordpress.org/trunk@46957 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-13 21:25:14 +00:00
Sergey Biryukov 2830c6869c Upgrade/Install: Improve the appearance of language selection on install: 
* Remove a stray chevron.
* Improve focus and hover styles.

Props garrett-eclipse, audrasjb.
Fixes #48927.

git-svn-id: https://develop.svn.wordpress.org/trunk@46887 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-11 23:01:23 +00:00
Sergey Biryukov 3575a07f4b Docs: Improve documentation for `wp_dashboard_browser_nag()` and `dashboard_browser_nag_class()`. 
Props grapplerulrich.
Fixes #48932.

git-svn-id: https://develop.svn.wordpress.org/trunk@46880 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-11 10:57:44 +00:00
Sergey Biryukov c1ab0cc974 Menus: Avoid a PHP warning in `add_submenu_page()` when the same value is passed for both `$parent_slug` and `$menu_slug` parameters. 
Props welcher, ispreview, ayeshrajans, NextScripts, adamsilverstein, garrett-eclipse, 123host.
Fixes #48599.

git-svn-id: https://develop.svn.wordpress.org/trunk@46868 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-09 21:01:13 +00:00
Sergey Biryukov f090f8528c Administration: Standardize form control height and alignment across the admin. 
This improves the appearance of various form controls in the admin and addresses some visual inconsistencies in WordPress 5.3.

Props afercia, audrasjb, jameskoster, GDragoN, azaozz, michaelarestad, murgroland, SamuelFernandez, chetan200891, veminom, dlh.
Fixes #48420.

git-svn-id: https://develop.svn.wordpress.org/trunk@46866 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-09 20:24:17 +00:00
Sergey Biryukov a521300d9f Media: Use consistent width for Scale and Crop inputs. 
Follow-up to [46359].

Props sabernhardt, audrasjb.
Fixes #48907.

git-svn-id: https://develop.svn.wordpress.org/trunk@46856 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-09 16:21:10 +00:00
Sergey Biryukov cb9ed875b2 Help/About: Add a hover effect for links on About pages. 
* Add a color that passes WCAG color contrast criteria to every link.
* Add an underline for links in credits list only on hover/focus.

Props audrasjb, ixkaito, mukesh27, melchoyce, SergeyBiryukov.
Fixes #48582.

git-svn-id: https://develop.svn.wordpress.org/trunk@46852 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-09 15:29:47 +00:00
Sergey Biryukov c96a56c223 Administration: Correct checkbox width in list tables on smaller screens. 
Previously, checkboxes for pending comments were partially hidden due to an added `4px` border.

Props audrasjb, jeremyfelt, talldanwp, melchoyce, marcelo2605, waleedt93.
Fixes #48815.

git-svn-id: https://develop.svn.wordpress.org/trunk@46845 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-09 14:24:26 +00:00
Sergey Biryukov 9c82519c13 Accessibility: Menus: Properly disable form controls on the Menus screen that cannot be used until at least one menu is created. 
This ensures that the actual UI controls state matches the visually conveyed state.

Props afercia, audrasjb, dinhtungdu, sathyapulse, simonjanin, welcher, SergeyBiryukov.
Fixes #48409.

git-svn-id: https://develop.svn.wordpress.org/trunk@46842 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-09 13:47:12 +00:00
John Blackbourn e12f866db2 Docs: Further docblock corrections and improvements. 
See #48303

git-svn-id: https://develop.svn.wordpress.org/trunk@46826 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-07 13:21:07 +00:00
John Blackbourn 726d3a1d9c Docs: Increase the specificity of various docblock parameter types and return types. 
See #48303

git-svn-id: https://develop.svn.wordpress.org/trunk@46823 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-06 22:41:26 +00:00
John Blackbourn bcfccc7344 Docs: Correct various docblocks documentation. 
See #48303

git-svn-id: https://develop.svn.wordpress.org/trunk@46821 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-06 22:21:07 +00:00
Aaron Jorbin 8ed3551c81 Text Changes: Rename Comment Blacklist option to be more inclusive 
This doesn't change the underlying option name as that would be a backcompat break, but it makes the UI a bit more inclusive.

Props dartiss, jeremyfelt, aaronjorbin.
Fixes #48900.



git-svn-id: https://develop.svn.wordpress.org/trunk@46820 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-06 18:10:58 +00:00
Sergey Biryukov 47e38ea2e9 Accessibility: Administration: Correct active button color for the alternative color schemes. 
Follow-up to [46815].

Props melchoyce, ryelle, larrach, audrasjb, studiotwee, afercia, azaozz.
Fixes #48598.

git-svn-id: https://develop.svn.wordpress.org/trunk@46817 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-05 22:10:29 +00:00
Sergey Biryukov 94b37d4f90 Accessibility: Administration: Apply a unified design to all secondary buttons across all color schemes. 
This ensures that secondary buttons have an appropriate color contrast in the alternative color schemes.

Props melchoyce, ryelle, audrasjb, ate-up-with-motor, afercia, sabernhardt.
Fixes #48585.

git-svn-id: https://develop.svn.wordpress.org/trunk@46815 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-05 21:30:58 +00:00
Sergey Biryukov 8b08d641a7 I18N: Change context for the "Add New" string on Themes screen for consistency with other similar strings. 
Props ramiy.
Fixes #48875.

git-svn-id: https://develop.svn.wordpress.org/trunk@46812 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-04 10:34:03 +00:00
Sergey Biryukov 972ca00d2d Docs: Move the canonical DocBlock for `handle_bulk_actions-{$screen}` action to `wp-admin/edit.php`. 
* Document accepted values for the `$items` parameter.
* Use interpolated syntax for the filter name.

Props dilipbheda, johnbillion, SergeyBiryukov.
Fixes #48857.

git-svn-id: https://develop.svn.wordpress.org/trunk@46811 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-03 13:56:25 +00:00
Andrew Ozz 8917973d52 Upload: Exclude PNG images from scaling after uploading. Fixes a case where resizing a very large PNG may create a scaled image that has smaller dimensions but larger file size than the original. 
Fixes #48736.

git-svn-id: https://develop.svn.wordpress.org/trunk@46809 602fd350-edb4-49c9-b593-d223f7449a82
 2019-12-01 18:24:30 +00:00
Sergey Biryukov bf3295d10f Administration: Correct font size for comment count in "At a Glance" dashboard widget on mobile. 
Props donmhico, jeremyfelt.
Fixes #48799.

git-svn-id: https://develop.svn.wordpress.org/trunk@46807 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-30 00:40:24 +00:00
Sergey Biryukov b5ed00dc82 REST API: Use strict `in_array()` checks for the list of usernames blacklisted via `illegal_user_logins` filter. 
See #48839.

git-svn-id: https://develop.svn.wordpress.org/trunk@46804 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-29 22:02:30 +00:00
Sergey Biryukov 4b60e6a0db Site Health: Add a test for PHP default timezone. 
The test reports a failure if the default timezone was changed with `date_default_timezone_set()` to anything other than `UTC`.

WordPress historically uses `UTC` as the default timezone for calculating date and time offsets, overriding it is not recommended and can cause widespread and obscure issues.

Props Rarst, Clorith, TimothyBlynJacobs.
Fixes #48692.

git-svn-id: https://develop.svn.wordpress.org/trunk@46797 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-28 15:46:45 +00:00
Sergey Biryukov 2dc58b9118 Menus: Improve the wording of instructions for dragging the items into the preferred order. 
Props amolv, equin0x80, dlh.
Fixes #48184.

git-svn-id: https://develop.svn.wordpress.org/trunk@46791 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-27 19:49:24 +00:00
Sergey Biryukov 10d5efa604 Administration: Properly wrap long titles in list tables on smaller screens. 
Props mukesh27, iihglobal, wpamitkumar.
Fixes #48805.

git-svn-id: https://develop.svn.wordpress.org/trunk@46790 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-27 16:50:59 +00:00
Dominik Schilling c2413a4711 Upgrade/Install: Provide a default label for "Continue" button in language selection form. 
Prevents an empty continue button if a translation isn't yet available.

Props sathyapulse.
Fixes #48776.

git-svn-id: https://develop.svn.wordpress.org/trunk@46784 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-26 15:17:30 +00:00
Sergey Biryukov 29f0d74599 Users: Use correct variable when displaying the Additional Capabilities list in user profile. 
Addresses a regression in [45926].

Props wpgurudev, aravindajith, anantajitjg, davidbaumwald.
Fixes #48725.

git-svn-id: https://develop.svn.wordpress.org/trunk@46782 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-25 13:59:02 +00:00
SergeyBiryukov dc486308e6 Accessibility: Administration: Underline links on Dashboard that are located within a line of text and thus need to be underlined: 
* "change your theme completely"
* Active theme in the "At a Glance" box
* "View all drafts" in the Quick Draft box

Split "Manage widgets or menus" into separate items for consistency with other links.

For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished.

Per accessibility coding standards:
> When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#links-underline-or-no-underline
https://make.wordpress.org/accessibility/handbook/design/use-of-color/#not-by-color-alone

Props afercia, audrasjb, karmatosed.
Fixes #48406.

git-svn-id: https://develop.svn.wordpress.org/trunk@46770 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-24 19:55:01 +00:00
Sergey Biryukov 29ff549800 Coding Standards: Fix WPCS issue in [46763]. 
See #48777.

git-svn-id: https://develop.svn.wordpress.org/trunk@46764 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-23 19:19:57 +00:00
Sergey Biryukov fec3976927 Docs: Add missing `@since` tags for functions in `wp-admin/includes/update.php`. 
Props sathyapulse, zodiac1978.
Fixes #48777.

git-svn-id: https://develop.svn.wordpress.org/trunk@46763 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-23 18:49:59 +00:00
Sergey Biryukov 206ea67257 Editor: Improve the appearance of tag cloud in Tags meta box in classic editor. 
Props sathyapulse, Spaceshipone, tmatsuur, audrasjb, afercia.
Fixes #48592.

git-svn-id: https://develop.svn.wordpress.org/trunk@46758 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-22 00:02:12 +00:00
Sergey Biryukov 065a181fc0 I18N: Correct translator comment for `By %s` string in Plugins list table. 
Follow-up to [44541].

See #45898.

git-svn-id: https://develop.svn.wordpress.org/trunk@46755 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-21 00:06:32 +00:00
Andrea Fercia 5e574eb45f Accessibility: Add an `aria-current` attribute to the Media Library switch links. 
The `aria-current` attribute is a simple, effective, way to help assistive technology users orientate themselves within a set of items.

Props mayanksonawat, afercia.
Fixes #48271.


git-svn-id: https://develop.svn.wordpress.org/trunk@46746 602fd350-edb4-49c9-b593-d223f7449a82
 2019-11-18 16:49:42 +00:00