* reducev: initialize the sum with the addition
Avoids an Orc opcode.
* convi: initialize the sum with the addition
Avoids an Orc opcode.
* vector: add comments to magic numbers
* Inverted order of TIFF tag writing when saving multi-page subifd pyramids to ensure that subifd pyramid layers are correctly tagged as reduced-image subfile type and not as pages
* Use if-else clause to avoid tag overwriting
We added a check that loader ->header() and ->load() methods set the
same dhint. This commit removes that check -- it's not possible to make
header and load match in all cases since images can take so many routes,
and can change between the two events.
If we see performance issues around inappropriate cache sizing again,
try to fix just those cases.
* webpsave: switch to sink_disc
* fix some warnings
* distinguish between animated and single image write
* fix some formatting issues
* add missing comments
* fix webpsave_mime
* don't use sink_disc for single image webp write
* fix potential segv/double free
* update changelog
* remove leftover function declaration
* Revert "don't use sink_disc for single image webp write"
This reverts commit a75922ca93ee8987fa5e1ffc52b68e22bd6fb1fb.
* implement review feedback
* adjust to a column size of 80
* get contiguous RGB(A) buffer directly from VipsRegion
* Revert "get contiguous RGB(A) buffer directly from VipsRegion"
This reverts commit 84fc10e52fb223f0208c605dde92d3f821ceee0e.
* accumulate image data directly in frame_bytes buffer
* switch WebP back to Webp naming scheme
* rename page_index to page_number
* revise formatting
Add a check that header and load methods agree on the demand hint, and
make sure all loaders pass.
If they disagree, you can get bad performance in some cases, since the
pipeline can be built from the header dhint.
* move tiff decompress outside lock
Most time in TIFF read is spent in decompression. If we move this
outside the lock, we can get a useful speedup.
This commit adds the machinery to move the lock to before decompress, so
jp2k decompression is now threaded.
Before:
```
$ vips copy wtc.jpg x.tif[tile,compression=jp2k]
$ time vips avg x.tif
117.249845
real 0m15.085s
user 0m16.155s
sys 0m0.109s
```
After:
```
$ time vips avg x.tif
117.249845
real 0m1.207s
user 0m18.384s
sys 0m0.369s
```
* start moving jpg decode outside the lock
* move jpeg decompress outside the lock
seems to work
* add some more tile size checks
double-check jpeg tile size before decode
* fix tiffload demand hinting
We were not setting the hint correctly in header load, and we were not
hinting smalltile for tiled TIFFs.
John Cupitt
Ruven
Kleis Auke Wolthuizen
Ruven
Lovell Fuller
Sergey Alexandrovich
Luca Corbo
Daniel Löbl