Commit Graph

32 Commits

Author SHA1 Message Date
Xiang Xiao
317f0159a4 telnetd: Fix the buffer overflow
Should only memset ipv6 part of socket address(exclude famliy and port field)

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-07-12 14:11:54 +01:00
Gregory Nutt
c8dbd59e9a netutils/telnetd/telnetd_daemon.c: Avoid a warning if CONFIG_NET_SOCKOPTS=n 2020-02-09 00:33:39 +08:00
Gregory Nutt
d2522e2821 apps/netutils/telnetd: Fix undefined reference to setsockopt.
Recent change from Xiao Xiang enabled the SO_REUSEADDR socket option unconditionally.  This, of course, causes link time failures if socket options are not enabled:

apps/netutils/telnetd/telnetd_daemon.c:182: undefined reference to 'setsockopt'.

Observed during build testing with configuration rddrone-uavcan144:nsh
2020-02-09 00:33:39 +08:00
Gregory Nutt
724a34bd3b Run all files modified by pr45 through nxstyle. 2020-02-03 07:38:57 -06:00
Xiang Xiao
72bbc27b0f Free daemon struct in all telnetd_daemon error path
Change-Id: I7f014dc5f327a6ae6adf9cdbea8089ffab2efe37
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-03 07:17:22 -06:00
Xiang Xiao
d6e450e39a Skip to close acceptsd since it is already closed in SIOCTELNET handler
Change-Id: I669224fd5cd44162bb67c8316b56348f7f298883
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-03 07:17:22 -06:00
Xiang Xiao
579327a972 Remove CONFIG_NET_HAVE_REUSEADDR check from telnetd_daemon
since this option doesn't exist at all

Change-Id: I9ee8e61d0a8af1c9eb690b2f2945a7f7f7b5f834
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-03 07:17:22 -06:00
Xiang Xiao
28891ef27e Remove the global variable in telnetd_daemon
Change-Id: I264d10c0f141109ada6ac90afb2ba3e8cfad4404
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-03 07:17:22 -06:00
Xiang Xiao
857158451b Unify the void cast usage
1.Remove void cast for function because many place ignore the returned value witout cast
2.Replace void cast for variable with UNUSED macro

Change-Id: Ie644129a563244a6397036789c4c3ea83c4e9b09
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-01-02 23:21:01 +08:00
Gregory Nutt
63de16bd58 netutils/telnetd/telnetd_daemon.c: Fix another C89 violation that caused the ez80 build to fail. 2019-06-03 09:07:07 -06:00
Dmitriy Linikov
2f2fb92ae3 Merged in hardlulz/modem-3.0-nuttx-apps/fix-sem-EINTR (pull request #133)
Added ECANCELED condition to DEBUGASSERT-s checking sem_wait result

Approved-by: Gregory Nutt <gnutt@nuttx.org>
2018-02-20 18:37:32 +00:00
Gregory Nutt
28415d662b netutils/telnetd and users of telnetd: Add support for IPv6. 2017-06-27 09:14:13 -06:00
Sebastien Lorquet
2cbad44f1d This is the Pokemon patch to change all includes fronm <apps/bla/bla.h> to "bla/bla.h" 2016-07-11 10:11:18 -06:00
Gregory Nutt
d32f16450d Without lowsyslog() *llerr() is not useful. Eliminate and replace with *err(). 2016-06-20 12:39:46 -06:00
Gregory Nutt
bb06f7368f Without lowsyslog() *llinfo() is not useful. Eliminate and replace with *info(). 2016-06-20 11:48:15 -06:00
Gregory Nutt
586b0aa7e0 Change names of *dbg() * *err() 2016-06-11 15:51:27 -06:00
Gregory Nutt
f4bae25e32 Rename *lldbg to *llerr 2016-06-11 14:55:13 -06:00
Gregory Nutt
468bdcf8e6 Rename CONFIG_DEBUG to CONFIG_DEBUG_FEATURES 2016-06-11 14:13:39 -06:00
Gregory Nutt
344c92e2a4 Replace all occurrences of vdbg with vinfo 2016-06-11 11:55:38 -06:00
Gregory Nutt
c0d0a0821a netutils/telnetd: No longer calls OS interfade telnet_driver. Now creates Telnet sessions by open a new factory device at /dev/telnet and then using ioctl calls to create the session character drivers at /dev/telnetN. 2015-12-07 13:51:37 -06:00
Gregory Nutt
ba8d44d799 netutils/telnetd: Move the Telnet driver to nuttx/drivers/net 2015-12-07 09:29:29 -06:00
Gregory Nutt
9faf23290c netutils/telnetd: Remove unused parameter from telnetd_driver 2015-12-07 08:15:50 -06:00
Gregory Nutt
746f3919cd Networking: Correct the value returned by accept() in the case where net_lockingwait() is called. It was returning -1 and losing the errno value. Noted by Rony Xln 2015-01-22 06:51:31 -06:00
Gregory Nutt
680ee615fa apps/netutils/telnetd: Add protection when CONFIG_SCHED_HAVE_PARENT is enabled: Call sigaction with SA_NOCLDWAIT so that exit status is not retained (no zombies) and block receipt of SIGCHLD so that accept is not awakened by a signal. Iff accept() is awakened by a signal, do not do anything crazy like exit. Most from Rony Xln 2015-01-22 06:33:55 -06:00
Gregory Nutt
8c24662011 Misc changes to get a clean build after all of the syslog changes. There are probably other things still broken 2014-10-08 16:23:48 -06:00
Gregory Nutt
dd8d40dabd Remove final traces of the 8015 from the NuttX source tree 2014-09-01 13:21:15 -06:00
Gregory Nutt
767f1b2993 Fix netutils configuration issues: CONFIG_NETUTILS_HTTPD_SENDFILE was missing from Kconfig; CONFIG_NET_HAVE_SOLINGER should be CONFIG_NET_SOLINGER; Type of CONFIG_NET_HTTPD_MAXPATH was wrong in Kconfig file. From Max 2014-07-11 12:30:23 -06:00
Gregory Nutt
2ee5041477 NET: Rename uiplib/UIPLIB to netlib/NETLIB 2014-07-02 16:04:25 -06:00
Gregory Nutt
b9cf7acb1a More trailing whilespace removal 2014-04-13 16:24:28 -06:00
patacongo
f8e08440f7 Email address change in apps/
git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@5143 42af7a65-404d-4744-a932-0658087f49c3
2012-09-13 16:58:49 +00:00
patacongo
35750bdbcf Fix a error the telnet driver read method. Don't return if only protocol stuff is read
git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@4352 42af7a65-404d-4744-a932-0658087f49c3
2012-01-31 17:38:45 +00:00
patacongo
2223c0eac0 Add new psock layer; telnet session is now wrapped in a character device
git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@4347 42af7a65-404d-4744-a932-0658087f49c3
2012-01-30 21:29:59 +00:00