Scott Taylor
1e68b7dab4
In WP_MS_Users_List_Table::get_views()
, remove dead code:
...
* `$wp_roles` doesn't need to be imported.
* `$current_role` is set and never used.
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28295 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 15:29:22 +00:00
Dominik Schilling (ocean90)
b09a91a666
Custom Header: Fix logic when a theme doesn't set default-text-color
.
...
fixes #28042 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28294 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 15:26:46 +00:00
Scott Taylor
36abe7909c
In WP_Media_List_Table
, remove dead code:
...
* In `->prepare_items()`, importing `$wpdb` is unnecessary.
* In `->get_columns()`, `$taxonomies` is set twice before it is used.
* In `->display_rows()`, `$taxonomy_object` is set and never used.
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28293 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 15:26:32 +00:00
Scott Taylor
41d1eb8f56
In ajax-actions.php
, remove dead code:
...
* In `wp_ajax_add_tag()`, `$post_type` is set and never used.
* In `wp_ajax_hidden_columns()`, `$hidden` is set twice, but only checks for the existence of `$_POST['hidden']` the first time. The two lines can be combined and work together.
* In `wp_ajax_inline_save()`, `$mode` is set and never used.
* In `wp_ajax_find_posts()`, `$searchand = $search = '';` is leftover cruft, neither variable is used. `$wpdb` does not need to be imported, it is never used.
* In `wp_ajax_wp_fullscreen_save_post()`, `$post_type` is set and never used.
* In `wp_ajax_save_attachment_order()`, `$post` is set and never used.
* In `wp_ajax_send_attachment_to_editor()`, `$title` is set and never used.
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28292 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 15:18:42 +00:00
Scott Taylor
909d11cd28
Remove unreachable break
statements in wp-admin/edit-tags.php
. break
is unnecessary after die
, exit
, and wp_die
.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28291 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 14:51:47 +00:00
Scott Taylor
88ad28ffdf
In wp-admin/custom-header.php
, $default_color
is set twice before it is used. The first is unnecessary.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28290 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 14:50:05 +00:00
Scott Taylor
ab01399666
Remove unreachable break
statements in wp-admin/comments.php
. break
is unnecessary after die
, exit
, and wp_die
.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28289 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 14:45:22 +00:00
Sergey Biryukov
7f754fa2e8
Translate a string added in 3.7 but never translated previously.
...
props andrezrv.
fixes #28025 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28288 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 12:48:49 +00:00
Sergey Biryukov
4b8b0e7178
Use a consistent context to remove duplicate strings.
...
props pavelevap.
fixes #28123 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28287 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 12:33:08 +00:00
Sergey Biryukov
046a2bff94
Add context for 'Previous' and 'Next' theme strings.
...
see #28120 , for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@28286 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 12:19:41 +00:00
Sergey Biryukov
d7a159bf81
Add a filter for wp_list_comments() arguments.
...
props greenshady, hlashbrooke.
fixes #19581 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28285 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 11:57:36 +00:00
Dominik Schilling (ocean90)
c30bb2fd2b
Add missing Dashicons classes to User Admin menu.
...
props imath.
see #28144 , #26630 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28284 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 07:57:52 +00:00
Drew Jaynes (DrewAPicture)
8764f791f1
Where a filter no longer exists, it need not be notated.
...
Fixes #24444 . See r28258.
git-svn-id: https://develop.svn.wordpress.org/trunk@28283 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 05:37:17 +00:00
Andrew Nacin
cb022f4957
Multisite: Treat 'www' as a special subdomain, reversing 3.9 regression.
...
props jeremyfelt.
fixes #27927 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28280 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 05:31:12 +00:00
Scott Taylor
555937dc43
In WP_List_Table::display_rows_or_placeholder()
, the call to get_column_info()
in unnecessary and unused. The call to get_column_count()
immediately after makes the same call internally.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28279 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 05:31:07 +00:00
Andrew Nacin
7839dd671c
Multisite: Fix case sensitivity regressions in 3.9.
...
props jeremyfelt.
fixes #27866 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28276 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 05:23:56 +00:00
Andrew Nacin
c0822b532e
Custom header: Avoid warnings in the process_default_headers() method.
...
props obenland.
fixes #27850 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28275 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 05:06:39 +00:00
Scott Taylor
a1c6a10489
In general-template.php
- remove dead code:
...
* In `get_calendar()`, `$cache` is set twice. The first is useless.
* In `wp_default_editor()`, `$user` is (accidentally) assigned in a condition. Since it is never used, this is unnecessary.
* In `language_attributes()`, `$output` is set twice before it is ever used. The first is unnecessary.
* In `paginate_links()`, `$n` is set twice before it is ever used. The first is unnecessary.
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28274 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 04:57:22 +00:00
Scott Taylor
f95a4c70be
In edit_form_image_editor()
, $filename
and $title
are set and then unused. They shall be removed.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28271 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 04:44:56 +00:00
Andrew Nacin
9259c6baa7
Customizer: Only tie header button action events to the header controls.
...
props danielbachhuber.
fixes #28046 . see #27848 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28269 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 04:29:14 +00:00
Scott Taylor
e42ec45553
Dead code in wp-admin/includes/file.php
:
...
* In `wp_handle_upload()` and `wp_handle_sideload()`, `$ext` gets conditionally reset... and then is never used.
* In `request_filesystem_credentials()`, `$password` is initialized as an empty string. The variable is never used.
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28268 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 04:21:35 +00:00
Andrew Nacin
7ada7af9d0
Customizer: Avoid hiding 'Remove' buttons unrelated to custom headers.
...
props rzen, ehg.
fixes #27848 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28266 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 04:13:52 +00:00
Scott Taylor
eda51bf856
Remove duplicate variable setting for $link
in wp_list_authors()
.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28265 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 03:51:42 +00:00
Scott Taylor
f97deae591
Remove unused variable setting for $revisions
in wp_prepare_revisions_for_js()
.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28264 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 03:44:30 +00:00
Scott Taylor
4c6f405ee7
Remove a dead variable, $start
, from wp_dashboard_recent_comments()
.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28263 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 03:34:22 +00:00
Andrew Nacin
4b6d5b10d4
Move 'home' option to the top of populate_options().
...
fixes #28141 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28260 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 21:56:11 +00:00
Scott Taylor
2b1619329e
Add .dfxp
and .srt
files to mime-type whitelist in wp_get_mime_types()
. They are both captioning formats supported by MediaElement.
...
Props joedolson.
Fixes #27643 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28259 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 20:07:53 +00:00
Scott Taylor
5c306af76d
When $type
is atom
in get_the_category_rss()
, use get_bloginfo_rss( 'url' )
when setting the scheme
attribute for the <category>
node.
...
Props ejdanderson.
Fixes #24444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28258 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 19:04:39 +00:00
Scott Taylor
fc4dfba1b8
Remove by-reference modifiers from arguments in wp_remote_retrieve_*
functions.
...
Props jesin.
Fixes #27687 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28257 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 18:45:14 +00:00
Sergey Biryukov
819ad5babc
Deprecate unused argument of delete_plugins(). Clarify @return value.
...
props jdgrimes for initial patch.
fixes #28111 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28256 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 10:23:16 +00:00
Sergey Biryukov
b597b02515
Fix closing tag in image editor.
...
props t4k1s.
fixes #28130 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28255 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 10:16:14 +00:00
Sergey Biryukov
de80cc6780
Avoid displaying a negative number of plugin updates in admin menu.
...
fixes #28073 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28254 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 09:38:36 +00:00
Sergey Biryukov
3e482eb905
Use a time constant in get_theme_feature_list() and File_Upload_Upgrader.
...
props GaVrA.
fixes #28124 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28253 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 08:25:46 +00:00
Scott Taylor
89ecbcc7cb
In WP_Date_Query::get_sql_for_subquery()
, don't parse duplicate parameters - only parse one of w
and week
or month
and monthnum
.
...
Adds unit tests.
Props oso96_2000, ChriCo.
Fixes #25835 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28252 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-04 23:06:07 +00:00
Scott Taylor
61765b8efd
Set the proper value for wp_title()
when is_author()
and is_post_type_archive()
are both true. post_type
should always win due to the precedence indicated in get_queried_object()
.
...
Props mordauk.
Fixes #25398 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28251 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-04 22:20:47 +00:00
Sergey Biryukov
0a16bda6e3
Prevent 'Page %s' from being added to page title on 404 error pages in bundled themes.
...
props psoluch, rob1n.
fixes #16468 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28250 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-04 13:16:30 +00:00
Sergey Biryukov
ece95a0257
Prevent 'paged-*' from being added to body classes on 404 error pages.
...
props psoluch.
see #16468 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28249 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-04 13:16:13 +00:00
Sergey Biryukov
d0ced880bb
Twenty Fourteen: Avoid a PHP notice in Ephemera widget.
...
props jartes.
fixes #28055 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28248 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-02 18:45:06 +00:00
Drew Jaynes (DrewAPicture)
5ad1751132
Improve inline documentation for the wpdb::$show_errors property.
...
Note that SQL/DB errors are displayed by default if both WP_DEBUG and WP_DEBUG_DISPLAY evaluate to true.
Props ericlewis.
Fixes #16615 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28243 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-02 12:18:07 +00:00
Sergey Biryukov
da6a3d1745
Correct @return value for wp_create_nav_menu() and wp_delete_nav_menu().
...
props Tmeister.
fixes #27745 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28242 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-02 11:58:51 +00:00
Sergey Biryukov
6c401709f6
Correct 'show_in_menu' parameter description in register_taxonomy().
...
fixes #27943 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28241 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-02 11:28:05 +00:00
Sergey Biryukov
b9834e8275
Correct @return value for current_time().
...
props arnee.
fixes #27940 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28240 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-02 11:24:23 +00:00
Dominik Schilling (ocean90)
fe2f5f921e
Color Picker: Close color picker when clicking outside of them and when opening another one.
...
props mattwiebe.
fixes #25539 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28239 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-02 11:17:13 +00:00
Dominik Schilling (ocean90)
cb9480b4eb
Update jQuery to 1.11.1.
...
fixes #28103 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28238 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-02 09:28:55 +00:00
Sergey Biryukov
068ec39696
Twenty Eleven: Correct description for twentyeleven_theme_options_render_page().
...
props ericlewis.
fixes #28057 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28237 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-02 00:42:20 +00:00
Sergey Biryukov
2558cf0139
Fix arrow positioning in "Insert/edit link" modal.
...
props avryl, sergej.mueller.
fixes #28096 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28236 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-01 21:20:16 +00:00
Dominik Schilling (ocean90)
a54c311e4f
Widgets: Toggle widget arrow when widget is open/closed.
...
props MikeHansenMe.
fixes #26748 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28235 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-01 14:08:44 +00:00
Dominik Schilling (ocean90)
ed52ae7a3f
Quick Draft: Use text cursor for description label.
...
fixes #27766 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28234 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-01 13:12:01 +00:00
Andrew Nacin
790cb99b27
Shortcode JS: Avoid errors when an escaped shortcode includes a newline between brackets.
...
props gcorne.
props Clorith, jorbin for tests.
see #27907 , for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@28223 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-01 03:36:27 +00:00
Scott Taylor
5907cafe9e
More descriptive docs for grunt jshint:core
.
...
Props netweb, jorbin.
Fixes #27567 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28222 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-30 21:39:43 +00:00